Re: [FFmpeg-devel] [PATCH] avcodec/atrac3p: use float_dsp in ff_atrac3p_power_compensation

2017-07-31 Thread James Almer
On 7/29/2017 1:12 AM, James Almer wrote: > On 7/20/2017 4:01 PM, James Almer wrote: >> Signed-off-by: James Almer >> --- >> Fate passes, so i guess the aligment requirements are met. >> >> libavcodec/atrac3plus.h| 5 +++-- >> libavcodec/atrac3plusdec.c | 36

[FFmpeg-devel] [DISCUSSION] Motion Estimation API/Library

2017-07-31 Thread Davinder Singh
Hello everyone, As we've been planning since forever ( https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/snow.h#L182, http://ffmpeg.org/pipermail/ffmpeg-devel/2016-July/197095.html) we need Motion Estimation code that could be shared in codecs and motion filters. The idea is to make the

Re: [FFmpeg-devel] [PATCH 1/2] fate: add more DCA tests

2017-07-31 Thread James Almer
On 7/31/2017 8:58 PM, foo86 wrote: > On Mon, Jul 31, 2017 at 06:50:44PM -0300, James Almer wrote: >> On 7/31/2017 5:33 PM, foo86 wrote: >>> --- >>> tests/fate/dca.mak | 36 ++ >>> tests/ref/fate/dca-core-14be | 1 + >>> tests/ref/fate/dca-core-14le | 1 + >>>

Re: [FFmpeg-devel] [PATCH 1/2] fate: add more DCA tests

2017-07-31 Thread Michael Niedermayer
On Tue, Aug 01, 2017 at 03:01:38AM +0300, foo86 wrote: > On Mon, Jul 31, 2017 at 11:48:09PM +0200, Michael Niedermayer wrote: > > On Mon, Jul 31, 2017 at 11:46:33PM +0300, foo86 wrote: > > > Oops, meant to include this comment in previous email: > > > > > > Improves code coverage: > > >

Re: [FFmpeg-devel] [PATCH] coverage: filter /usr/include*, not entire /usr*

2017-07-31 Thread foo86
On Mon, Jul 31, 2017 at 11:06:01PM +0200, Nicolas George wrote: > Le tridi 13 thermidor, an CCXXV, foo86 a écrit : > > /usr* filters all sources when building in /usr/src, which is probably > > not intended. > > This is leaving /usr/local/include, and many less known directories, > like

Re: [FFmpeg-devel] [PATCH 1/2] fate: add more DCA tests

2017-07-31 Thread foo86
On Mon, Jul 31, 2017 at 05:14:01PM -0400, Ronald S. Bultje wrote: > Hi, > > On Mon, Jul 31, 2017 at 4:46 PM, foo86 wrote: > > > Oops, meant to include this comment in previous email: > > > > Improves code coverage: > > old%new% > > dca_core76.581.3 >

Re: [FFmpeg-devel] [PATCH 1/2] fate: add more DCA tests

2017-07-31 Thread foo86
On Mon, Jul 31, 2017 at 11:48:09PM +0200, Michael Niedermayer wrote: > On Mon, Jul 31, 2017 at 11:46:33PM +0300, foo86 wrote: > > Oops, meant to include this comment in previous email: > > > > Improves code coverage: > > old%new% > > dca_core76.581.3 > > dca_exss56.5

Re: [FFmpeg-devel] [PATCH 1/2] fate: add more DCA tests

2017-07-31 Thread foo86
On Mon, Jul 31, 2017 at 06:50:44PM -0300, James Almer wrote: > On 7/31/2017 5:33 PM, foo86 wrote: > > --- > > tests/fate/dca.mak | 36 ++ > > tests/ref/fate/dca-core-14be | 1 + > > tests/ref/fate/dca-core-14le | 1 + > > tests/ref/fate/dca-core-16be | 1 + > >

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-07-31 Thread Dale Curtis
I'm not convinced my original patch catches all cases. So here's an updated one which explicitly verifies the contract. - dale On Mon, Jul 31, 2017 at 2:40 PM, Dale Curtis wrote: > [mov] Bail when invalid sample data is present. > > ctts data in ffmpeg relies on the

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-07-31 Thread Dale Curtis
Whoops, that patch accidentally reverted to an earlier version. Here's the fixed one that works with the mpg sample mentioned above. - dale On Mon, Jul 31, 2017 at 2:29 PM, Dale Curtis wrote: > Here's an updated patch with a fate test attached. You'll need to add >

Re: [FFmpeg-devel] [PATCH 1/2] fate: add more DCA tests

2017-07-31 Thread James Almer
On 7/31/2017 5:33 PM, foo86 wrote: > --- > tests/fate/dca.mak | 36 ++ > tests/ref/fate/dca-core-14be | 1 + > tests/ref/fate/dca-core-14le | 1 + > tests/ref/fate/dca-core-16be | 1 + > tests/ref/fate/dca-core-16le | 1 + > tests/ref/fate/dca-core-dmix | 1 + >

Re: [FFmpeg-devel] [PATCH 1/2] fate: add more DCA tests

2017-07-31 Thread Michael Niedermayer
On Mon, Jul 31, 2017 at 11:46:33PM +0300, foo86 wrote: > Oops, meant to include this comment in previous email: > > Improves code coverage: > old%new% > dca_core76.581.3 > dca_exss56.565.6 > dca_lbr 2.280.5 > dca_parser 86.298.6 > dca_xll 81.2

[FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-07-31 Thread Dale Curtis
[mov] Bail when invalid sample data is present. ctts data in ffmpeg relies on the index entries array to be 1:1 with samples... yet sc->sample_count can be read directly from the 'stsz' box and index entries are only generated if a chunk count has been read from 'stco' box. Ensure that if

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-07-31 Thread Dale Curtis
Here's an updated patch with a fate test attached. You'll need to add http://storage.googleapis.com/dalecurtis/buck480p30_na.mp4 to the fate-suite/mov for this test. This is licensed under creative commons attribution, so it should be fine for tests: https://peach.blender.org/about/ I tried to use

Re: [FFmpeg-devel] [PATCH 1/2] fate: add more DCA tests

2017-07-31 Thread Ronald S. Bultje
Hi, On Mon, Jul 31, 2017 at 4:46 PM, foo86 wrote: > Oops, meant to include this comment in previous email: > > Improves code coverage: > old%new% > dca_core76.581.3 > dca_exss56.565.6 > dca_lbr 2.280.5 > dca_parser 86.298.6 >

Re: [FFmpeg-devel] [PATCH] coverage: filter /usr/include*, not entire /usr*

2017-07-31 Thread Nicolas George
Le tridi 13 thermidor, an CCXXV, foo86 a écrit : > /usr* filters all sources when building in /usr/src, which is probably > not intended. This is leaving /usr/local/include, and many less known directories, like compiler-specific includes. Regards, -- Nicolas George signature.asc

Re: [FFmpeg-devel] [PATCH 1/2] fate: add more DCA tests

2017-07-31 Thread Saeid Zangeneh
Excuse me I'm confused! What is this? On Aug 1, 2017 01:16, "foo86" wrote: > Oops, meant to include this comment in previous email: > > Improves code coverage: > old%new% > dca_core76.581.3 > dca_exss56.565.6 > dca_lbr 2.280.5 >

Re: [FFmpeg-devel] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

2017-07-31 Thread Saeid Zangeneh
thanks but i'm using linux ubuntu system. On Tue, Aug 1, 2017 at 1:03 AM, Thilo Borgmann wrote: > Am 31.07.17 um 17:34 schrieb sharpbai: > > From: sharpbai > > > > feature: add scaleFactor attribute for avfoundation > > added by:

Re: [FFmpeg-devel] [PATCH 1/2] fate: add more DCA tests

2017-07-31 Thread foo86
Oops, meant to include this comment in previous email: Improves code coverage: old%new% dca_core76.581.3 dca_exss56.565.6 dca_lbr 2.280.5 dca_parser 86.298.6 dca_xll 81.287.2 dcadec 75.083.0 dcadsp 64.083.8 Samples are here:

[FFmpeg-devel] [PATCH 2/2] fate: add Dolby E test

2017-07-31 Thread foo86
--- Samples are here: https://0x0.st/ket.xz tests/fate/audio.mak | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak index 40c4ca7b75..4fab472f90 100644 --- a/tests/fate/audio.mak +++ b/tests/fate/audio.mak @@ -19,6 +19,11 @@ fate-bmv-audio: CMD

[FFmpeg-devel] [PATCH] coverage: filter /usr/include*, not entire /usr*

2017-07-31 Thread foo86
/usr* filters all sources when building in /usr/src, which is probably not intended. --- tests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile b/tests/Makefile index ab83ae855d..2c67095052 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -228,7

Re: [FFmpeg-devel] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

2017-07-31 Thread Thilo Borgmann
Am 31.07.17 um 17:34 schrieb sharpbai: > From: sharpbai > > feature: add scaleFactor attribute for avfoundation > added by: siyuan.w...@duobei.com > added by: yiren...@duobei.com > --- > doc/indevs.texi| 6 ++ > libavdevice/avfoundation.m | 8 > 2

[FFmpeg-devel] Extarcting mor information in conversion s

2017-07-31 Thread Saeid Zangeneh
Im not familiar with the ffmpeg source code and I'm not so professional in programming to can change or find out the code. I just want to extract quantization matrix in jpeg conversion also the residual error in mpeg conversion. Thanks everyone for helping.

[FFmpeg-devel] [PATCH] avformat/utils: fix memory leak in avformat_free_context

2017-07-31 Thread Steven Siloti
The pointer to the packet queue is stored in the internal structure so the queue needs to be flushed before internal is freed. Signed-off-by: Steven Siloti --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c

Re: [FFmpeg-devel] [PATCH]v6 Opus Pyramid Vector Quantization Search in x86 SIMD asm

2017-07-31 Thread Henrik Gramner
On Wed, Jul 26, 2017 at 4:56 PM, Ivan Kalvachev wrote: > +++ b/libavcodec/x86/opus_pvq_search.asm Generic minor stuff: Use rN instead of rNq for numbered registers (q suffix is used for named args only due to preprocessor limitations). Use the same "standard" vertical

[FFmpeg-devel] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

2017-07-31 Thread sharpbai
From: sharpbai feature: add scaleFactor attribute for avfoundation added by: siyuan.w...@duobei.com added by: yiren...@duobei.com --- doc/indevs.texi| 6 ++ libavdevice/avfoundation.m | 8 2 files changed, 14 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

2017-07-31 Thread Steven Liu
2017-07-31 21:32 GMT+08:00 sharpbai : > From: sharpbai > > feature: add scaleFactor attribute for avfoundation > added by: siyuan.w...@duobei.com > added by: yiren...@duobei.com > --- > doc/indevs.texi| 6 ++ > libavdevice/avfoundation.m |

[FFmpeg-devel] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

2017-07-31 Thread sharpbai
From: sharpbai feature: add scaleFactor attribute for avfoundation added by: siyuan.w...@duobei.com added by: yiren...@duobei.com --- doc/indevs.texi| 6 ++ libavdevice/avfoundation.m | 6 ++ 2 files changed, 12 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH] avfilter: add differencemax mode to the blend video filter

2017-07-31 Thread James Darnley
On 2017-07-31 13:45, Paul B Mahol wrote: > On 7/31/17, James Darnley wrote: >> --- >> Changelog | 1 + >> doc/filters.texi | 1 + >> libavfilter/blend.h| 1 + >> libavfilter/vf_blend.c | 4 >> 4 files changed, 7 insertions(+) >> > > How this compares

Re: [FFmpeg-devel] [PATCH 14/14] lavfi: remove dualinput.

2017-07-31 Thread Nicolas George
Note: with this patch series, including the streamselect conversion, it becomes possible to remove the old framesync code (and rename framesync2 into framesync). A few filters using bufferqueue will still need to be converted to get rid of that one. Regards, -- Nicolas George signature.asc

Re: [FFmpeg-devel] [PATCH 01/14] lavfi: add f_streamsync dependency.

2017-07-31 Thread Nicolas George
Even better. From 836cbf40eb95e16d48bb5a2d356c130ce9d53de1 Mon Sep 17 00:00:00 2001 From: Nicolas George Date: Mon, 31 Jul 2017 13:47:34 +0200 Subject: [PATCH] lavfi/f_streamselect: convert to framesync2. Signed-off-by: Nicolas George --- libavfilter/Makefile

Re: [FFmpeg-devel] [PATCH] examples/vaapi_enc: Add a VAAPI encoding example.

2017-07-31 Thread Mark Thompson
On 31/07/17 04:10, Jun Zhao wrote: > On 2017/7/30 8:07, Mark Thompson wrote: >> On 28/07/17 07:01, Jun Zhao wrote: >>> From d5414b451012b3a0169740a26f452785eb44cce5 Mon Sep 17 00:00:00 2001 >>> From: Jun Zhao >>> Date: Fri, 28 Jul 2017 01:39:27 -0400 >>> Subject: [PATCH]

[FFmpeg-devel] [PATCH 13/14] vf_ssim: convert to framesync2.

2017-07-31 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/Makefile | 2 +- libavfilter/vf_ssim.c | 52 ++- 2 files changed, 28 insertions(+), 26 deletions(-) diff --git a/libavfilter/Makefile b/libavfilter/Makefile index

[FFmpeg-devel] [PATCH 12/14] lavfi/vf_psnr: convert to framesync2.

2017-07-31 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/Makefile | 2 +- libavfilter/vf_psnr.c | 50 +++--- 2 files changed, 28 insertions(+), 24 deletions(-) diff --git a/libavfilter/Makefile b/libavfilter/Makefile index

[FFmpeg-devel] [PATCH 07/14] lavfi/vf_overlay: use framesync2 options.

2017-07-31 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/vf_overlay.c | 45 - 1 file changed, 4 insertions(+), 41 deletions(-) diff --git a/libavfilter/vf_overlay.c b/libavfilter/vf_overlay.c index c1d2a21c05..512df87630 100644 ---

[FFmpeg-devel] [PATCH 11/14] lavfi/vf_paletteuse: convert to framesync2.

2017-07-31 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/Makefile| 2 +- libavfilter/vf_paletteuse.c | 59 - 2 files changed, 38 insertions(+), 23 deletions(-) diff --git a/libavfilter/Makefile b/libavfilter/Makefile index

[FFmpeg-devel] [PATCH 10/14] lavfi/vf_lut3d: convert to framesync2.

2017-07-31 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/Makefile | 2 +- libavfilter/vf_lut3d.c | 49 ++--- 2 files changed, 27 insertions(+), 24 deletions(-) diff --git a/libavfilter/Makefile b/libavfilter/Makefile index

[FFmpeg-devel] [PATCH 09/14] lavfi/vf_libvmaf: convert to framesync2.

2017-07-31 Thread Nicolas George
After this commit, the code compiles, but on my setup it segfaults before and after. It also prints the very worrying warning: src/libavfilter/vf_libvmaf.c:161:66: warning: passing argument 4 of ‘compute_vmaf’ from incompatible pointer type [-Wincompatible-pointer-types]

[FFmpeg-devel] [PATCH 08/14] lavfi/vf_blend: convert to framesync2.

2017-07-31 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/Makefile | 4 ++-- libavfilter/vf_blend.c | 48 +++- 2 files changed, 29 insertions(+), 23 deletions(-) diff --git a/libavfilter/Makefile b/libavfilter/Makefile index

[FFmpeg-devel] [PATCH 05/14] lavfi: search options on child objects.

2017-07-31 Thread Nicolas George
The child objects must be allocated and inited in the preinit() callback. Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index

[FFmpeg-devel] [PATCH 04/14] lavfi: add a preinit callback to filters.

2017-07-31 Thread Nicolas George
It is necessary for filters with child objects, to set the class and default options values. Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 8 libavfilter/avfilter.h | 15 +++ 2 files changed, 23 insertions(+) diff --git

[FFmpeg-devel] [PATCH 06/14] lavfi/framesync2: add common options.

2017-07-31 Thread Nicolas George
Also add functions and macros to help filters chaining these options to their own. Signed-off-by: Nicolas George --- libavfilter/framesync2.c | 55 ++-- libavfilter/framesync2.h | 44 +- 2 files

[FFmpeg-devel] [PATCH 14/14] lavfi: remove dualinput.

2017-07-31 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/dualinput.c | 90 - libavfilter/dualinput.h | 46 - 2 files changed, 136 deletions(-) delete mode 100644 libavfilter/dualinput.c delete mode 100644

[FFmpeg-devel] [PATCH 01/14] lavfi: add f_streamsync dependency.

2017-07-31 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/Makefile b/libavfilter/Makefile index 4d61d7835e..b4cdd303bd 100644 --- a/libavfilter/Makefile +++ b/libavfilter/Makefile @@ -301,7 +301,7 @@

[FFmpeg-devel] [PATCH 03/14] lavfi/vf_overlay: move to framesync2.

2017-07-31 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/Makefile | 2 +- libavfilter/vf_overlay.c | 69 ++-- 2 files changed, 39 insertions(+), 32 deletions(-) diff --git a/libavfilter/Makefile b/libavfilter/Makefile index

[FFmpeg-devel] [PATCH 02/14] lavfi/framesync2: add dualinput helper functions.

2017-07-31 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/framesync2.c | 84 libavfilter/framesync2.h | 20 2 files changed, 83 insertions(+), 21 deletions(-) Nothing changed much. diff --git a/libavfilter/framesync2.c

[FFmpeg-devel] [PATCH 3/3] avcodec/vc2enc: constant quantiser encoding

2017-07-31 Thread James Darnley
--- libavcodec/vc2enc.c | 92 +++-- 1 file changed, 90 insertions(+), 2 deletions(-) diff --git a/libavcodec/vc2enc.c b/libavcodec/vc2enc.c index 5dec88c81b..ca8c8075fd 100644 --- a/libavcodec/vc2enc.c +++ b/libavcodec/vc2enc.c @@ -182,6 +182,8 @@

[FFmpeg-devel] [PATCH 1/3] avcodec/vc2enc: correct the returned error code for invalid options

2017-07-31 Thread James Darnley
--- libavcodec/vc2enc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vc2enc.c b/libavcodec/vc2enc.c index 96e27d93ed..7e0cb03eff 100644 --- a/libavcodec/vc2enc.c +++ b/libavcodec/vc2enc.c @@ -1114,13 +1114,13 @@ static av_cold int

[FFmpeg-devel] [PATCH 2/3] avcodec/vc2enc: assign some slice struct members init

2017-07-31 Thread James Darnley
--- libavcodec/vc2enc.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/libavcodec/vc2enc.c b/libavcodec/vc2enc.c index 7e0cb03eff..5dec88c81b 100644 --- a/libavcodec/vc2enc.c +++ b/libavcodec/vc2enc.c @@ -700,9 +700,6 @@ static int

Re: [FFmpeg-devel] [PATCH] avfilter: add differencemax mode to the blend video filter

2017-07-31 Thread Paul B Mahol
On 7/31/17, James Darnley wrote: > --- > Changelog | 1 + > doc/filters.texi | 1 + > libavfilter/blend.h| 1 + > libavfilter/vf_blend.c | 4 > 4 files changed, 7 insertions(+) > How this compares with lut2 filter regarding speed?

[FFmpeg-devel] [PATCH] avfilter: add differencemax mode to the blend video filter

2017-07-31 Thread James Darnley
--- Changelog | 1 + doc/filters.texi | 1 + libavfilter/blend.h| 1 + libavfilter/vf_blend.c | 4 4 files changed, 7 insertions(+) diff --git a/Changelog b/Changelog index 187ae7950a..894776d63a 100644 --- a/Changelog +++ b/Changelog @@ -29,6 +29,7 @@ version : -

Re: [FFmpeg-devel] [PATCH] libavcodec/mips: Improve avc idct8 msa function

2017-07-31 Thread Manojkumar Bhosale
LGTM thx -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of kaustubh.ra...@imgtec.com Sent: Monday, July 31, 2017 12:07 PM To: ffmpeg-devel@ffmpeg.org Cc: Kaustubh Raste Subject: [FFmpeg-devel] [PATCH] libavcodec/mips: Improve avc idct8 msa

Re: [FFmpeg-devel] [PATCH] avfilter: add VIF filter

2017-07-31 Thread Ashish Pratap Singh
On Mon, Jul 31, 2017 at 3:24 AM, Ronald S. Bultje wrote: > Hi, > > On Sun, Jul 30, 2017 at 1:46 PM, Ashish Pratap Singh > wrote: > > > On Sat, Jul 29, 2017 at 3:15 PM, Moritz Barsnick > wrote: > > > On Sat, Jul 29, 2017 at 14:16:29

Re: [FFmpeg-devel] [PATCH] ffprobe: use consistent string for unspecified color_range value

2017-07-31 Thread Tobias Rapp
On 24.07.2017 09:57, Tobias Rapp wrote: Makes the handling of unspecified/unknown color_range values on stream level consistent to the value used on frame level. Signed-off-by: Tobias Rapp --- ffprobe.c | 2 +- tests/ref/fate/ffprobe_compact | 4

[FFmpeg-devel] [PATCH] libavcodec/mips: Improve avc idct8 msa function

2017-07-31 Thread kaustubh.raste
From: Kaustubh Raste Replace memset call with msa stores. Signed-off-by: Kaustubh Raste --- libavcodec/mips/h264idct_msa.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mips/h264idct_msa.c