Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Alexander Strasser
Hi all, sorry for jumping into the discussion late. I think it is very important though. Please pardon me if I missed anything from the previous discussions on this topic. On 2017-08-11 23:34 +0200, Nicolas George wrote: > Le quartidi 24 thermidor, an CCXXV, Clement Boesch a écrit : [...] > >

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Nicolas George
Le quartidi 24 thermidor, an CCXXV, Clement Boesch a écrit : > That looks like it has a marginal effect in this particular case. I'd I would not have proposed something worse. > agree with just documenting it in the Changelog and still not making it > "the rule" (that is, NAK on the doc patch). A

[FFmpeg-devel] [PATCH 3/3] avcodec/lagarith: Detect end of input in lag_decode_line() loop

2017-08-11 Thread Michael Niedermayer
Fixes: timeout Fixes: 2933/clusterfuzz-testcase-5124990208835584 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/lagarith.c| 6 -- libavcodec/lagarithrac.c | 1 + libavcodec/lagarithrac

[FFmpeg-devel] [PATCH 2/3] avcodec/gdv: Check available space before reading palette

2017-08-11 Thread Michael Niedermayer
Fixes: Timeout Fixes: 2926/clusterfuzz-testcase-498711001458278 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/gdv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/gdv.c b/li

[FFmpeg-devel] [PATCH 1/3] avcodec/ffv1dec_template: Fix undefined shift

2017-08-11 Thread Michael Niedermayer
Fixes: runtime error: left shift of negative value -127 Fixes: 2834/clusterfuzz-testcase-minimized-5988039123795968 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/ffv1dec_template.c | 2 +- 1

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Clément Bœsch
On Fri, Aug 11, 2017 at 12:33:25PM +0200, Nicolas George wrote: > Le quartidi 24 thermidor, an CCXXV, Clement Boesch a écrit : > > I'm afraid of the situation where a developer will feel like the order of > > the options is not ideal, or an option could be renamed for consistency > > with other fil

Re: [FFmpeg-devel] [PATCH] JPEG2000: SSE optimisation of DWT decoding

2017-08-11 Thread Clément Bœsch
On Fri, Aug 11, 2017 at 06:32:37PM +0300, Ivan Kalvachev wrote: > On 8/10/17, maxime taisant wrote: > >> From: Ivan Kalvachev > >> On 8/8/17, maxime taisant wrote: > >> > From: Maxime Taisant > >> > > >> > Hi, > >> > > >> > Here is some SSE optimisations for the dwt function used to decode > >

Re: [FFmpeg-devel] [PATCH] JPEG2000: SSE optimisation of DWT decoding

2017-08-11 Thread Ivan Kalvachev
On 8/10/17, maxime taisant wrote: >> From: Ivan Kalvachev >> On 8/8/17, maxime taisant wrote: >> > From: Maxime Taisant >> > >> > Hi, >> > >> > Here is some SSE optimisations for the dwt function used to decode >> > JPEG2000. >> > I tested this code by using the time command while reading a JP

[FFmpeg-devel] [PATCH 1/3] Add single precision planar RGB pixel formats

2017-08-11 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- libavutil/pixdesc.c | 54 libavutil/pixdesc.h | 5 libavutil/pixfmt.h | 7 ++ tests/ref/fate/sws-pixdesc-query | 20 +++ 4 files changed, 86 insertions(+) d

[FFmpeg-devel] [PATCH] Add tonemap filter

2017-08-11 Thread Vittorio Giovara
Based off mpv automatic tonemapping capabilities. Signed-off-by: Vittorio Giovara --- doc/filters.texi | 108 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h| 2 +- libavfilter/vf_tonemap.c | 349

[FFmpeg-devel] [PATCH 2/3] zscale: Enable single precision input/ouput filtering

2017-08-11 Thread Vittorio Giovara
--- libavfilter/vf_zscale.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index 466689dbc5..1617db7cf0 100644 --- a/libavfilter/vf_zscale.c +++ b/libavfilter/vf_zscale.c @@ -179,6 +179,7 @@ static int query_formats(AVFi

[FFmpeg-devel] [PATCH 0/3] tonemap filter v2

2017-08-11 Thread Vittorio Giovara
Changes since v1: - changed pixel format from yuv to rgb, to sync with mpv's implementation - slightly changed a couple of the algorithms - improved log messages, using the right output context Vittorio Vittorio Giovara (3): Add single precision planar RGB pixel formats zscale: Enable single p

Re: [FFmpeg-devel] [PATCH] JPEG2000: SSE optimisation of DWT decoding

2017-08-11 Thread maxime taisant
> From: Maxime Taisant > > > From: Ivan Kalvachev > > > > On 8/8/17, maxime taisant wrote: > > > From: Maxime Taisant > > > > > > +movups m2, [lineq+2*j0q-24] > > > +movups m5, [lineq+2*j0q-8] > > > +shufps m2, m5, 0xDD > > > +addps m2, m1 > > > +mulps m2, m3 > > > +su

Re: [FFmpeg-devel] Mov/mp4 demuxer failing on mp4 file (Sample size is too large)

2017-08-11 Thread Robert Krüger
On Thu, Aug 10, 2017 at 1:38 PM, Paul B Mahol wrote: > On 8/10/17, Robert Krüger wrote: > > On Thu, Aug 10, 2017 at 10:21 AM, Paul B Mahol wrote: > > > >> On 8/9/17, Robert Krüger wrote: > >> > Hi, > >> > > >> > can someone tell me what this hints at? Is this more likely a broken > >> > file >

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Nicolas George
Le quartidi 24 thermidor, an CCXXV, Clement Boesch a écrit : > I'm afraid of the situation where a developer will feel like the order of > the options is not ideal, or an option could be renamed for consistency > with other filters, and will take the easy way out "oh well, we documented > it's unst

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tests/dct: Add Mean square error test

2017-08-11 Thread Michael Niedermayer
On Sun, Jul 09, 2017 at 03:52:09AM +0200, Michael Niedermayer wrote: > based on quotes of IEEE 1180 / ISO/IEC 23002-1 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/tests/dct.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) applied [...] -- Michael GnuPG fin

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/tests/dct: Add peak mean error check

2017-08-11 Thread Michael Niedermayer
On Sun, Jul 09, 2017 at 03:52:08AM +0200, Michael Niedermayer wrote: > based on quotes of IEEE 1180 / ISO/IEC 23002-1 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/tests/dct.c | 2 ++ > 1 file changed, 2 insertions(+) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF67

Re: [FFmpeg-devel] [PATCH] avformat/avidec: Move packet skip after prefix and related checks

2017-08-11 Thread Michael Niedermayer
On Tue, Aug 08, 2017 at 02:51:07AM +0200, Michael Niedermayer wrote: > This fixes loosing packets > Fixes: big.avi > > Signed-off-by: Michael Niedermayer > --- > libavformat/avidec.c | 25 - > 1 file changed, 12 insertions(+), 13 deletions(-) applied [...] -- Michael

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: Clear mcsel before decoding an image

2017-08-11 Thread Michael Niedermayer
On Sun, Aug 06, 2017 at 02:38:29PM +0200, Michael Niedermayer wrote: > Fixes: runtime error: signed integer overflow: 2146467840 + 1032192 cannot be > represented in type 'int' > Fixes: 2826/clusterfuzz-testcase-minimized-5901511613743104 > > Found-by: continuous fuzzing process > https://github

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Clément Bœsch
On Fri, Aug 11, 2017 at 11:12:32AM +0200, Nicolas George wrote: > Le quartidi 24 thermidor, an CCXXV, Clement Boesch a écrit : > > I'd rather make such changes justified and documented as exceptional in > > the Changelog (or in APIchanges) when we can't get around it cleanly, than > > documenting a

[FFmpeg-devel] [PATCH] lavf/movdec: flag chapter streams as such, even when not reading them

2017-08-11 Thread Rodger Combs
This allows the use of the `ignore_chapters` option to avoid performing extra seeks at startup without producing "subtitle" chapter streams. --- libavformat/mov.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 63f84

Re: [FFmpeg-devel] [PATCH] libavcodec/mips: Improve avc idct8 msa function

2017-08-11 Thread Kaustubh Raste
Please review the patch. -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Kaustubh Raste Sent: Friday, August 4, 2017 5:24 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/mips: Improve avc idct8 ms

[FFmpeg-devel] [PATCH 1/2] libavcodec: Add support for QSV screen capture plugin

2017-08-11 Thread Alexander Bilyak
Intel QSV SDK provide screen capture plugin starting from API ver 1.17 as runtime loadable plugin for QSV decoder. * add API version selection while initialization of QSV context (default is still 1.1 for usual encoding/decoding) --- configure | 2 + libavcodec/Makefile

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Nicolas George
Le quartidi 24 thermidor, an CCXXV, Clement Boesch a écrit : > I'd rather make such changes justified and documented as exceptional in > the Changelog (or in APIchanges) when we can't get around it cleanly, than > documenting a free for all area. > > You're saying documenting the risk or potential

[FFmpeg-devel] [PATCH 2/2] libavdevice: Add SQV screen capture device

2017-08-11 Thread Alexander Bilyak
For making it more reasonable QSV screen capture is added to device list, so it can be read as usual device, producing packets to its output. Nevertheless it is only wrapper around QSV decoder with screen capture plugin loading --- configure| 2 + libavdevice/Makefile | 1 +

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Clément Bœsch
On Thu, Aug 10, 2017 at 01:46:27PM +0200, Nicolas George wrote: > It does not mean that we intend to break the order of options > at a whim, but it gives us more freedom to make necessary > changes without extra unnecessary burden while giving stability > to users that require it. [...] I'd rather

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Nicolas George
Le quartidi 24 thermidor, an CCXXV, Paul B Mahol a écrit : > What about keeping old options intact? That requires glue code and more importantly testing. I do not intend to do it, and it blocks progress. Regards, -- Nicolas George ___ ffmpeg-devel m

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Nicolas George
Le tridi 23 thermidor, an CCXXV, Marton Balint a écrit : > I suggest you push the patch series without this patch, Michael can fix the > overlay and blend/tblend parameter order. If later the needed additional > compatibility code becomes too much of a burden, we can discuss this > further. I coul

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Nicolas George
Le quartidi 24 thermidor, an CCXXV, Michael Niedermayer a écrit : > First, I dont think a single developer should declare a whole class of > interfaces spaning the areas other developers work on unstable against > one or more objections from them. Or if one has that right then everyone > else shoul

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Paul B Mahol
On 8/11/17, Michael Niedermayer wrote: > On Thu, Aug 10, 2017 at 04:15:55PM +0200, Nicolas George wrote: >> Le tridi 23 thermidor, an CCXXV, Michael Niedermayer a écrit : >> > Please limit the notes in filters.texi and Changelog to the filters and >> > options you intend to change. >> >> That woul

Re: [FFmpeg-devel] [PATCH V2 1/4] lavc/vaapi_encode: Change the slice/parameter buffers to dynamic alloc.

2017-08-11 Thread Jun Zhao
On 2017/8/10 5:11, Mark Thompson wrote: > On 02/08/17 06:53, Jun Zhao wrote: >> V2: Change the slice/parameter buffers to dynamic alloc and split >> the mutil-slice support for AVC/HEVC. >> >> From 39fd7852df0c96217310c525107da06a7ec0a062 Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: M