Re: [FFmpeg-devel] [PATCH 4/4] avcodec/decode: Pass on the Closed Captions Side Data

2017-08-31 Thread Jeyapal, Karthick
>Actually in ff_init_buffer_info is a mapping of packet sidedata to >frame sidedata, if you just add the new CC sidedata type there, the >existing code should already handle it, from what i can tell. > >- Hendrik Thanks for that guidance. It makes perfect sense to handle it in ff_init_buffer_info.

Re: [FFmpeg-devel] [PATCH] avio: add a destructor for AVIOContext

2017-08-31 Thread James Almer
On 8/27/2017 1:31 PM, James Almer wrote: > From: Anton Khirnov > > Before this commit, AVIOContext is to be freed with a plain av_free(), > which prevents us from adding any deeper structure to it. > > (cherry picked from commit 99684f3ae752fc8bfb44a2dd1482f8d7a3d8536d) > Signed-off-by: James Al

[FFmpeg-devel] [PATCH v22] avformat/dashdec: add dash demuxer base version

2017-08-31 Thread Steven Liu
ffmpeg need a dash demuxer for demux the dash formats base on https://github.com/samsamsam-iptvplayer/exteplayer3/blob/master/tmp/ffmpeg/patches/3.2.2/01_add_dash_demux.patch TODO: 1. support multi bitrate dash. v2 fixed: 1. from autodetect to disabled 2. from camelCase code style to ffmpeg c

Re: [FFmpeg-devel] [PATCH v3] avformat/dash: move reused API to common file and header file

2017-08-31 Thread Steven Liu
2017-09-01 0:21 GMT+08:00 wm4 : > On Thu, 31 Aug 2017 22:56:53 +0800 > Steven Liu wrote: > >> move from dashenc, move DASHTmplId and dash_fill_tmpl_params to >> dash.c, they will be used by dash demuxer and dash muxer. >> >> v2 fixed: >> 1. rename common file from dashcomm.* to dash.* >> Suggested

Re: [FFmpeg-devel] [PATCH 02/16] build: treat crystalhd like other hwaccels

2017-08-31 Thread Philip Langdale
On Wed, 30 Aug 2017 14:09:01 +0200 Clément Bœsch wrote: > From: Clément Bœsch > > --- > configure | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/configure b/configure > index 44e45791c2..a9932aeba6 100755 > --- a/configure > +++ b/configure > @@ -1532,7 +1532,

Re: [FFmpeg-devel] [PATCH] fate/fits: add new test & gen few samples automatically

2017-08-31 Thread James Almer
On 8/27/2017 2:45 AM, Paras Chadha wrote: > Signed-off-by: Paras Chadha > --- > All other FITS patches need to be applied before this one. > > tests/fate/demux.mak| 3 +- > tests/fate/fits.mak | 57 > ++--- > tests/ref/fate/fi

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

2017-08-31 Thread Thomas Mundt
2017-09-01 1:22 GMT+02:00 Michael Niedermayer : > On Fri, Sep 01, 2017 at 01:18:11AM +0200, Michael Niedermayer wrote: > > On Thu, Aug 31, 2017 at 10:40:12PM +0200, Thomas Mundt wrote: > > > 2017-08-31 21:42 GMT+02:00 Michael Niedermayer >: > > > > > > > On Wed, Aug 30, 2017 at 03:54:08AM +0200,

Re: [FFmpeg-devel] [PATCH 1/3] avformat/nsvdec: Fix DoS due to lack of eof check in nsvs_file_offset loop.

2017-08-31 Thread Michael Niedermayer
On Wed, Aug 30, 2017 at 01:20:25AM +0200, Michael Niedermayer wrote: > From: 孙浩(晓黑) > > Fixes: 20170829.nsv > > Co-Author: 张洪亮(望初)" > Found-by: Xiaohei and Wangchu from Alibaba Security Team > Signed-off-by: Michael Niedermayer > --- > libavformat/nsvdec.c | 5 - > 1 file changed, 4 inser

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

2017-08-31 Thread Michael Niedermayer
On Fri, Sep 01, 2017 at 01:18:11AM +0200, Michael Niedermayer wrote: > On Thu, Aug 31, 2017 at 10:40:12PM +0200, Thomas Mundt wrote: > > 2017-08-31 21:42 GMT+02:00 Michael Niedermayer : > > > > > On Wed, Aug 30, 2017 at 03:54:08AM +0200, Thomas Mundt wrote: > > > > Hi, > > > > > > > > we did a tra

Re: [FFmpeg-devel] [PATCH 2/2] avocdec/libopus: fix typo

2017-08-31 Thread Michael Niedermayer
On Fri, Sep 01, 2017 at 01:11:57AM +0200, pkv.stream wrote: > small typo fix > > libopusenc.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > 5e0298d5098ab63effde707fbe5385e049af6ff2 0002-avocdec-libopus-fix-typo.patch > From 5dabf59f9f070c7d23da03979f06c136fa6817b4 Mon Sep 17 00:0

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

2017-08-31 Thread Michael Niedermayer
On Thu, Aug 31, 2017 at 10:40:12PM +0200, Thomas Mundt wrote: > 2017-08-31 21:42 GMT+02:00 Michael Niedermayer : > > > On Wed, Aug 30, 2017 at 03:54:08AM +0200, Thomas Mundt wrote: > > > Hi, > > > > > > we did a transcoding cascade test at work were over-sharpening became > > > visible with the co

[FFmpeg-devel] [PATCH 2/2] avocdec/libopus: fix typo

2017-08-31 Thread pkv.stream
small typo fix From 5dabf59f9f070c7d23da03979f06c136fa6817b4 Mon Sep 17 00:00:00 2001 From: pkviet Date: Fri, 1 Sep 2017 00:44:11 +0200 Subject: [PATCH 2/2] avocdec/libopus: fix typo --- libavcodec/libopusenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libo

[FFmpeg-devel] [PATCH 1/2] avformat/mpegts: opus muxing & demuxing expanded

2017-08-31 Thread pkv.stream
Hello per Michael requests: 1) I have split patch in 2 2) added malloc checks 3) changed  "for int" loop to C89 style (if I understood well the comment) regards libavcodec/libopusenc.c |2 - libavformat/mpegts.c| 54 +--- libavformat/mp

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

2017-08-31 Thread Thomas Mundt
2017-08-31 21:42 GMT+02:00 Michael Niedermayer : > On Wed, Aug 30, 2017 at 03:54:08AM +0200, Thomas Mundt wrote: > > Hi, > > > > we did a transcoding cascade test at work were over-sharpening became > > visible with the complex low-pass filter. This patch rectifies the > > behaviour. > > > > Pleas

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: opus muxing & demuxing expanded

2017-08-31 Thread pkv.stream
This is missing malloc failure checks, also the "for (int i" syntax is something we avoid due to some at least past portability issues. thanks a lot. Will fix. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/f

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-31 Thread Michael Niedermayer
On Thu, Aug 31, 2017 at 12:23:04PM -0700, Dale Curtis wrote: > Ping, without the patch in the previous message you can get crashes when > encountering these types of files. will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Modern terrorism, a qui

[FFmpeg-devel] Adding "btrt" atom to MOOV

2017-08-31 Thread MediaStream
was looking to add a btrt as per section 5.3.4.1.1 of ISO 14496-15:2004 Attached patch seem to have worked ok with FFmpeg 3.3.3 Thanks Dennis btrt_moovatom.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://f

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: opus muxing & demuxing expanded

2017-08-31 Thread Michael Niedermayer
On Tue, Aug 29, 2017 at 11:53:57PM +0200, pkv.stream wrote: > Hello again (patch attached this time), > > this patch expands support for mapping_family 255 (and part of 1) > for mpegts muxer and demuxer. > > (Ambisonics family 2 & 3 not covered). > > See commit commentary. > > My case use (as a

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

2017-08-31 Thread Michael Niedermayer
On Wed, Aug 30, 2017 at 03:54:08AM +0200, Thomas Mundt wrote: > Hi, > > we did a transcoding cascade test at work were over-sharpening became > visible with the complex low-pass filter. This patch rectifies the > behaviour. > > Please comment... did you perform subjective and or objective tests

Re: [FFmpeg-devel] [PATCH] avformat/mov: prevent duplication of first fragment's ctts_data

2017-08-31 Thread Michael Niedermayer
On Mon, Aug 28, 2017 at 03:22:43PM -0700, Dale Curtis wrote: > lgtm, my patch is still necessary to ensure ctts samples aren't trampled > when new headers do need to be read. This should prevent unnecessary work > and spammy logs. will apply thanks [...] -- Michael GnuPG fingerprint: 9FF212

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-31 Thread Dale Curtis
Ping, without the patch in the previous message you can get crashes when encountering these types of files. - dale On Mon, Aug 28, 2017 at 2:45 PM, Dale Curtis wrote: > On Fri, Aug 25, 2017 at 6:09 PM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: >> >> This changes the printed duratio

Re: [FFmpeg-devel] [PATCH] avfilter/vf_subtitles: enable processing of alpha channel

2017-08-31 Thread Clément Bœsch
On Wed, Aug 30, 2017 at 09:04:59PM +0200, Paul B Mahol wrote: > Fixes #6605. > > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_subtitles.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_subtitles.c b/libavfilter/vf_subtitles.c > index 805ee2d..b7

[FFmpeg-devel] [PATCH] avcodec/mov: Allocate skipped_bytes_pos with av_realloc.

2017-08-31 Thread Mark Wachsler
Memory reallocated with av_reallocp_array is supposed to be allocated with av_realloc, not av_malloc. --- libavcodec/h2645_parse.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c index b0d9ff66f0..1b2534b2e6 100644 --- a/lib

Re: [FFmpeg-devel] [PATCH] avfilter: add ADM filter

2017-08-31 Thread Nicolas George
Le quartidi 14 fructidor, an CCXXV, Ronald S. Bultje a écrit : > The "native" vmaf filter will use this to call adm internally. It probably > needs to use the ff_ namespace, yes. Ok for the rationale. The ff_ namespace is needed indeed. And something must be done for the static variables: ideally,

[FFmpeg-devel] [PATCH 6/6] lavfi: rename framesync2 to framesync.

2017-08-31 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/Makefile | 48 +++ libavfilter/f_streamselect.c | 12 libavfilter/{framesync2.c => framesync.c} | 32 ++--- libavfilter/{framesync2.h => framesync.h} | 42 +

[FFmpeg-devel] [PATCH 4/6] lavfi/af_sidechaincompress: use helper macros.

2017-08-31 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/af_sidechaincompress.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/libavfilter/af_sidechaincompress.c b/libavfilter/af_sidechaincompress.c index f174b70a5b..55bed43844 100644 --- a/libavfilter/af_sidechaincomp

[FFmpeg-devel] [PATCH 5/6] lavfi: remove framesync.

2017-08-31 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/framesync.c | 343 libavfilter/framesync.h | 297 - 2 files changed, 640 deletions(-) delete mode 100644 libavfilter/framesync.c delete mode 100644 libavfilter/

[FFmpeg-devel] [PATCH 3/6] doc: update filter_design.txt.

2017-08-31 Thread Nicolas George
Signed-off-by: Nicolas George --- doc/filter_design.txt | 226 -- 1 file changed, 127 insertions(+), 99 deletions(-) diff --git a/doc/filter_design.txt b/doc/filter_design.txt index e8a7c53ee9..a473026dc2 100644 --- a/doc/filter_design.txt +++ b/do

[FFmpeg-devel] [PATCH 2/6] lavfi/af_agate: use helper macros.

2017-08-31 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/af_agate.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/libavfilter/af_agate.c b/libavfilter/af_agate.c index f4fcabef93..20905ccb19 100644 --- a/libavfilter/af_agate.c +++ b/libavfilter/af_agate.c @@ -270,10 +2

[FFmpeg-devel] [PATCH 1/6] lavfi: add helper functions and macros for activate.

2017-08-31 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 20 + libavfilter/filters.h | 78 ++ 2 files changed, 98 insertions(+) This series is still work-in-progress, but I do not know when I will have time to give it again. The pat

Re: [FFmpeg-devel] [PATCH] avfilter: add ADM filter

2017-08-31 Thread Ronald S. Bultje
Hi, On Thu, Aug 31, 2017 at 1:31 PM, Nicolas George wrote: > Le quartidi 14 fructidor, an CCXXV, Ashish Pratap Singh a écrit : > > From: Ashish Singh > > > > Hi, > > This patch changes adm filter from dualinput to framesync2. > > > > Signed-off-by: Ashish Singh > > --- > > Changelog

Re: [FFmpeg-devel] [PATCH] avfilter: add ADM filter

2017-08-31 Thread Nicolas George
Le quartidi 14 fructidor, an CCXXV, Ashish Pratap Singh a écrit : > From: Ashish Singh > > Hi, > This patch changes adm filter from dualinput to framesync2. > > Signed-off-by: Ashish Singh > --- > Changelog| 1 + > doc/filters.texi | 15 + > libavfilter/Makefile

[FFmpeg-devel] [PATCH] avfilter: add ADM filter

2017-08-31 Thread Ashish Pratap Singh
From: Ashish Singh Hi, This patch changes adm filter from dualinput to framesync2. Signed-off-by: Ashish Singh --- Changelog| 1 + doc/filters.texi | 15 + libavfilter/Makefile | 1 + libavfilter/adm.h| 75 + libavfilter/allfilters.c | 1 + libav

Re: [FFmpeg-devel] [PATCH v3] avformat/dash: move reused API to common file and header file

2017-08-31 Thread wm4
On Thu, 31 Aug 2017 22:56:53 +0800 Steven Liu wrote: > move from dashenc, move DASHTmplId and dash_fill_tmpl_params to > dash.c, they will be used by dash demuxer and dash muxer. > > v2 fixed: > 1. rename common file from dashcomm.* to dash.* > Suggested-by: Hendrik Leppkes > > v3 fixed: > 1.

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/af_agate: switch to activate

2017-08-31 Thread Paul B Mahol
On 8/31/17, Nicolas George wrote: > L'octidi 8 fructidor, an CCXXV, Paul B Mahol a ecrit : >> +if ((ret = ff_inlink_consume_frame(ctx->inputs[0], &in[0])) > 0) { >> +av_audio_fifo_write(s->fifo[0], (void **)in[0]->extended_data, >> +in[0]->nb_samples); >> +

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/af_agate: switch to activate

2017-08-31 Thread Nicolas George
L'octidi 8 fructidor, an CCXXV, Paul B Mahol a écrit : > +if ((ret = ff_inlink_consume_frame(ctx->inputs[0], &in[0])) > 0) { > +av_audio_fifo_write(s->fifo[0], (void **)in[0]->extended_data, > +in[0]->nb_samples); > +av_frame_free(&in[0]); > +} >

[FFmpeg-devel] [PATCH v3] avformat/dash: move reused API to common file and header file

2017-08-31 Thread Steven Liu
move from dashenc, move DASHTmplId and dash_fill_tmpl_params to dash.c, they will be used by dash demuxer and dash muxer. v2 fixed: 1. rename common file from dashcomm.* to dash.* Suggested-by: Hendrik Leppkes v3 fixed: 1. rename header file pre defined 2. add ff_ prefix for the internal API Sug

Re: [FFmpeg-devel] [PATCH v2] avformat/dash: move reused API to common file and header file

2017-08-31 Thread James Almer
On 8/31/2017 6:00 AM, Steven Liu wrote: > diff --git a/libavformat/dash.h b/libavformat/dash.h > new file mode 100644 > index 00..941f7fded1 > --- /dev/null > +++ b/libavformat/dash.h > @@ -0,0 +1,39 @@ > +/* > + * MPEG-DASH ISO BMFF segmenter > + * Copyright (c) 2014 Martin Storsjo > + * >

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/decode: Pass on the Closed Captions Side Data

2017-08-31 Thread Hendrik Leppkes
On Thu, Aug 31, 2017 at 1:21 PM, Jeyapal, Karthick wrote: >>Maybe this should be handled somewhere in generic code? This is hardly >>a v210 property at all. > > Yes, I agree. It is better to handle it in the generic code. Have attached a > patch, where the same is handled in decode.c > Actually

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/decode: Pass on the Closed Captions Side Data

2017-08-31 Thread Jeyapal, Karthick
>Maybe this should be handled somewhere in generic code? This is hardly >a v210 property at all. Yes, I agree. It is better to handle it in the generic code. Have attached a patch, where the same is handled in decode.c Thanks and regards, Karthick 0004-avcodec-decode-Pass-on-the-Closed-Caption

Re: [FFmpeg-devel] [PATCH v3] fate: add tests for some video source filters

2017-08-31 Thread Tobias Rapp
On 31.08.2017 02:50, Michael Niedermayer wrote: On Tue, Aug 29, 2017 at 04:49:58PM +0200, Tobias Rapp wrote: On 25.07.2017 11:11, Tobias Rapp wrote: Adds FATE tests for the previously untested allrgb, allyuv, rgbtestsrc, smptebars, smptehdbars and yuvtestsrc filters. Also adds a test for tests

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/v210dec: Pass on the Closed Captions Side Data

2017-08-31 Thread Hendrik Leppkes
On Thu, Aug 31, 2017 at 10:36 AM, wrote: > From: Karthick J > > Signed-off-by: Karthick J > --- > libavcodec/v210dec.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/libavcodec/v210dec.c b/libavcodec/v210dec.c > index 9af9af6..7b0b68b 100644 > --- a/libavcodec/v210dec.c

[FFmpeg-devel] [PATCH v2] avformat/dash: move reused API to common file and header file

2017-08-31 Thread Steven Liu
move from dashenc, move DASHTmplId and dash_fill_tmpl_params to dash.c, they will be used by dash demuxer and dash muxer. v2 fixed: 1. rename common file from dashcomm.* to dash.* Suggested-by: Hendrik Leppkes Suggested-by: Timo Rothenpieler Signed-off-by: Steven Liu --- libavformat/Makefile

Re: [FFmpeg-devel] [PATCH] avformat/dashcomm: move reused API to common file and header file

2017-08-31 Thread Hendrik Leppkes
On Thu, Aug 31, 2017 at 9:32 AM, Steven Liu wrote: > move from dashenc, move DASHTmplId and dash_fill_tmpl_params to > dashcomm.c, they will be used by dash demuxer and dash muxer. > > Please name it dash.c/h, like we use for common code in all other components. - Hendrik ___

[FFmpeg-devel] [PATCH 4/4] avcodec/v210dec: Pass on the Closed Captions Side Data

2017-08-31 Thread kjeyapal
From: Karthick J Signed-off-by: Karthick J --- libavcodec/v210dec.c | 12 1 file changed, 12 insertions(+) diff --git a/libavcodec/v210dec.c b/libavcodec/v210dec.c index 9af9af6..7b0b68b 100644 --- a/libavcodec/v210dec.c +++ b/libavcodec/v210dec.c @@ -73,6 +73,8 @@ static int deco

[FFmpeg-devel] [PATCH 1/4] avdevice/decklink_dec: Added VANC search for all resolutions

2017-08-31 Thread kjeyapal
From: Karthick J In preparation to make VANC decode modular, to support multiple other VANC data. Signed-off-by: Karthick J --- libavdevice/decklink_dec.cpp | 86 ++-- 1 file changed, 76 insertions(+), 10 deletions(-) diff --git a/libavdevice/decklink_d

[FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC

2017-08-31 Thread kjeyapal
From: Karthick J Signed-off-by: Karthick J --- libavcodec/avcodec.h | 7 ++ libavdevice/decklink_dec.cpp | 167 --- 2 files changed, 165 insertions(+), 9 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 513236a..d4a45

[FFmpeg-devel] [PATCH 2/4] avdevice/decklink_dec: Extraction of luma from V210 VANC modularized

2017-08-31 Thread kjeyapal
From: Karthick J In preparation to support multiple VANC data decode Signed-off-by: Karthick J --- libavdevice/decklink_dec.cpp | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp inde

[FFmpeg-devel] [PATCH v21] avformat/dashdec: add dash demuxer base version

2017-08-31 Thread Steven Liu
ffmpeg need a dash demuxer for demux the dash formats base on https://github.com/samsamsam-iptvplayer/exteplayer3/blob/master/tmp/ffmpeg/patches/3.2.2/01_add_dash_demux.patch TODO: 1. support multi bitrate dash. v2 fixed: 1. from autodetect to disabled 2. from camelCase code style to ffmpeg c

[FFmpeg-devel] [PATCH] avformat/dashcomm: move reused API to common file and header file

2017-08-31 Thread Steven Liu
move from dashenc, move DASHTmplId and dash_fill_tmpl_params to dashcomm.c, they will be used by dash demuxer and dash muxer. Suggested-by: Timo Rothenpieler Signed-off-by: Steven Liu --- libavformat/Makefile | 2 +- libavformat/dashcomm.c | 136 +