[FFmpeg-devel] [PATCH] avcodec/encode: don't return immediately on failure

Fixes memleaks introduced by skipping cleanup at the end of the functions. Regression since a22c6a4796ca1f2cbee6784262515da876fbec22. Signed-off-by: James Almer --- libavcodec/encode.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/encode.c b/lib

[FFmpeg-devel] [PATCH] build: add install targets for the examples

Split it off from install-data. Among other things, this prevents spamming triplicate log lines during install. Signed-off-by: James Almer --- Makefile | 6 ++ doc/examples/Makefile | 14 +- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/Makefile b

[FFmpeg-devel] [PATCH v2] doc: add mailing list faq

Signed-off-by: Lou Logan --- HTML example at http://0x0.st/FTE.html doc/Makefile | 1 + doc/mailing-list-faq.texi | 342 ++ 2 files changed, 343 insertions(+) create mode 100644 doc/mailing-list-faq.texi diff --git a/doc/Makefile b/doc

Re: [FFmpeg-devel] [PATCH 3/7] Removing some debugging

On Mon, Oct 2, 2017 at 4:19 PM, Carl Eugen Hoyos wrote: > 2017-10-02 20:44 GMT+02:00 Bjorn Roche : > > I submitted a complete patch separately > > No. > > What I wrote in my last email was (please > do not top-post here): > >> Instead please merge your paletteuse patches > >> into one patch, I be

Re: [FFmpeg-devel] [PATCH]fate: Add a test for latm-in-dvb autodetection

On Sat, Sep 30, 2017 at 08:38:36PM +0200, Carl Eugen Hoyos wrote: > 2017-09-27 17:12 GMT+02:00 Carl Eugen Hoyos : > > Hi! > > > > Attached patch adds a test for ticket #6657. > > New patch attached. > > Carl Eugen > Makefile |1 + > fate/mpegts.mak| 14 ++

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-10-02 23:47 GMT+02:00 Carl Eugen Hoyos : > 2017-10-02 23:02 GMT+02:00 Michael Niedermayer : >> On Sun, Oct 01, 2017 at 06:23:50PM +0200, Carl Eugen Hoyos wrote: >>> 2017-09-27 18:08 GMT+02:00 Carl Eugen Hoyos : >>> >>> > The existing amr demuxer does not allow reading streams, >>> > it require

Re: [FFmpeg-devel] [PATCH] libavformat/nutenc.c: Use ffv1 as default video encoder for NUT muxing

2017-10-02 23:18 GMT+02:00 Leo Izen : > On 09/28/2017 04:51 PM, Michael Niedermayer wrote: >> >> On Wed, Sep 27, 2017 at 07:14:50PM -0400, Leo Izen wrote: >>> -.video_codec= AV_CODEC_ID_MPEG4, >>> +.video_codec= AV_CODEC_ID_FFV1, >>> .write_header = nut_write_header, >>>

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-10-02 23:02 GMT+02:00 Michael Niedermayer : > On Sun, Oct 01, 2017 at 06:23:50PM +0200, Carl Eugen Hoyos wrote: >> 2017-09-27 18:08 GMT+02:00 Carl Eugen Hoyos : >> >> > The existing amr demuxer does not allow reading streams, >> > it requires the 3GPP-conforming file header. >> > Attached patc

Re: [FFmpeg-devel] [PATCH] libavformat/nutenc.c: Use ffv1 as default video encoder for NUT muxing

On 09/28/2017 04:51 PM, Michael Niedermayer wrote: On Wed, Sep 27, 2017 at 07:14:50PM -0400, Leo Izen wrote: --- libavformat/nutenc.c| 2 +- tests/ref/lavf/nut | 6 +++--- tests/ref/seek/lavf-nut | 54 - 3 files changed, 31 insertio

Re: [FFmpeg-devel] [PATCH] fate: add test for iTunes gapless MP3

On Sun, Oct 01, 2017 at 08:13:11PM -0700, Christopher Snowhill wrote: > > I've finally assembled a fate test for this patch. > > The test file goes here: > > /gapless/gapless-itunes.mp3 > > I have uploaded a copy here: > > https://f.losno.co/gapless-itunes.mp3 uploaded to fate samples thx [

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

On Sun, Oct 01, 2017 at 06:23:50PM +0200, Carl Eugen Hoyos wrote: > 2017-09-27 18:08 GMT+02:00 Carl Eugen Hoyos : > > > The existing amr demuxer does not allow reading streams, > > it requires the 3GPP-conforming file header. > > Attached patch allows reading amrnb and amrwb from (live) > > stream

Re: [FFmpeg-devel] [PATCH 3/7] Removing some debugging

2017-10-02 20:44 GMT+02:00 Bjorn Roche : > I submitted a complete patch separately No. What I wrote in my last email was (please do not top-post here): >> Instead please merge your paletteuse patches >> into one patch, I believe the new patch should >> allow to encode a single RGBA frame with >>

Re: [FFmpeg-devel] [PATCH] build: don't strip binaries during compilation

On 10/2/2017 4:34 PM, Michael Niedermayer wrote: > On Sun, Oct 01, 2017 at 07:55:29PM -0300, James Almer wrote: >> Do it during install instead, like with the libraries. >> >> There's no benefit making a stripped copy of the CLI tools in the >> build folder. Doing it during install saves build time

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

Thanks Michael; replaced the offending MSVC function. Le 02/10/2017 à 9:35 PM, Michael Niedermayer a écrit : On Sun, Oct 01, 2017 at 03:17:30AM +0200, pkv.stream wrote: Hello the submitted patch addresses the regression discussed in ticket #6706. The -

Re: [FFmpeg-devel] [PATCH] build: don't strip binaries during compilation

On Sun, Oct 01, 2017 at 07:55:29PM -0300, James Almer wrote: > Do it during install instead, like with the libraries. > > There's no benefit making a stripped copy of the CLI tools in the > build folder. Doing it during install saves build time and storage > space. > > Signed-off-by: James Almer

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

On Sun, Oct 01, 2017 at 03:17:30AM +0200, pkv.stream wrote: > Hello > > the submitted patch addresses the regression discussed in ticket #6706. > > > > The -channel_layout option is not working when the channel layout is not > a default one (ex: for 4 chann

Re: [FFmpeg-devel] [PATCH 3/7] Removing some debugging

I submitted a complete patch separately ( http://ffmpeg.org/pipermail/ffmpeg-devel/2017-September/216793.html), but this is how git-email formatted things. How would you like me to proceed? On Mon, Oct 2, 2017 at 2:13 PM, Carl Eugen Hoyos wrote: > 2017-10-02 19:24 GMT+02:00 Bjorn Roche : > > Fro

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

On 2 October 2017 at 18:43, pkv.stream wrote: > Le 02/10/2017 à 7:23 PM, Michael Niedermayer a écrit : > >> On Mon, Oct 02, 2017 at 12:52:53AM +0200, pkv.stream wrote: >> >>> Le 02/10/2017 à 12:43 AM, Carl Eugen Hoyos a écrit : >>> 2017-10-02 0:40 GMT+02:00 pkv.stream : > Hi atomnuk

Re: [FFmpeg-devel] [PATCH 1/2 v2] avdevice/decklink_dec: remove av_dup_packet() usage

On 10/2/2017 2:47 PM, James Almer wrote: > On 10/2/2017 2:27 PM, Marton Balint wrote: >> >> >> On Mon, 2 Oct 2017, Marton Balint wrote: >> >>> >>> >>> On Mon, 2 Oct 2017, James Almer wrote: >>> Signed-off-by: James Almer --- Untested. >>> >>> Tested and works. >>> libavdev

Re: [FFmpeg-devel] [PATCH 3/7] Removing some debugging

2017-10-02 19:24 GMT+02:00 Bjorn Roche : > From: Bjorn Roche > -printf( "alpha 1, 2: %d, %d\n", c1[0], c2[0] ); Instead please merge your paletteuse patches into one patch, I believe the new patch should allow to encode a single RGBA frame with transparency into pal8 png or similar. Carl Eu

Re: [FFmpeg-devel] [PATCH 2/2 v2] avdevice/decklink_dec: use av_packet_add_side_data()

On 10/2/2017 2:20 PM, Marton Balint wrote: > > > On Mon, 2 Oct 2017, James Almer wrote: > >> It uses the existing buffer instead of allocating a new one. >> >> Signed-off-by: James Almer >> --- >> Untested. No changes since last version. >> >> libavdevice/decklink_dec.cpp | 6 ++ >> 1 file c

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

Le 02/10/2017 à 7:23 PM, Michael Niedermayer a écrit : On Mon, Oct 02, 2017 at 12:52:53AM +0200, pkv.stream wrote: Le 02/10/2017 à 12:43 AM, Carl Eugen Hoyos a écrit : 2017-10-02 0:40 GMT+02:00 pkv.stream : Hi atomnuker, got your PCE working; the patch you attached contains tabs, they cannot

Re: [FFmpeg-devel] [PATCH 1/2 v2] avdevice/decklink_dec: remove av_dup_packet() usage

On 10/2/2017 2:27 PM, Marton Balint wrote: > > > On Mon, 2 Oct 2017, Marton Balint wrote: > >> >> >> On Mon, 2 Oct 2017, James Almer wrote: >> >>> Signed-off-by: James Almer >>> --- >>> Untested. >> >> Tested and works. >> >>> >>> libavdevice/decklink_dec.cpp | 11 +-- >>> 1 file changed

[FFmpeg-devel] [PATCH 6/7] cleanup

From: Bjorn Roche --- libavcodec/gif.c | 14 +- libavformat/gif.c | 2 +- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/libavcodec/gif.c b/libavcodec/gif.c index 3838aa7592..3ced6d4d45 100644 --- a/libavcodec/gif.c +++ b/libavcodec/gif.c @@ -265,7 +265,7 @@ static

[FFmpeg-devel] [PATCH 4/7] First pass at making the gif support transparency with the right disposal methods. Needs more optimization.

From: Bjorn Roche --- libavcodec/avcodec.h | 6 ++ libavcodec/gif.c | 177 +-- libavformat/gif.c| 16 - 3 files changed, 193 insertions(+), 6 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 5c84974e03..3c

[FFmpeg-devel] [PATCH 0/7] Fix for transparent gif creation

These series of patches fixes transparent gifs. See issue: https://trac.ffmpeg.org/ticket/4443 The paletteuse function had to be patched to support transparency, and the gif encoder had to be patched so that support for transparent gifs worked with animated gifs, not just single frames. In add

Re: [FFmpeg-devel] [PATCH 1/2 v2] avdevice/decklink_dec: remove av_dup_packet() usage

On Mon, 2 Oct 2017, Marton Balint wrote: On Mon, 2 Oct 2017, James Almer wrote: Signed-off-by: James Almer --- Untested. Tested and works. libavdevice/decklink_dec.cpp | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavd

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

On Mon, Oct 02, 2017 at 12:52:53AM +0200, pkv.stream wrote: > Le 02/10/2017 à 12:43 AM, Carl Eugen Hoyos a écrit : > >2017-10-02 0:40 GMT+02:00 pkv.stream : > >>Hi atomnuker, > >> > >>got your PCE working; > >the patch you attached contains tabs, they cannot be committed > >to the FFmpeg repository

[FFmpeg-devel] [PATCH 5/7] Reimplement optimization for transparency

From: Bjorn Roche --- libavcodec/gif.c | 131 +-- 1 file changed, 78 insertions(+), 53 deletions(-) diff --git a/libavcodec/gif.c b/libavcodec/gif.c index db2193a718..3838aa7592 100644 --- a/libavcodec/gif.c +++ b/libavcodec/gif.c @@ -80,7 +80

[FFmpeg-devel] [PATCH 7/7] Fix for detecting opaque correctly.

From: Bjorn Roche --- libavcodec/gif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/gif.c b/libavcodec/gif.c index 3ced6d4d45..758e16b83d 100644 --- a/libavcodec/gif.c +++ b/libavcodec/gif.c @@ -80,7 +80,7 @@ static int is_image_translucent(AVCodecContext *avctx

[FFmpeg-devel] [PATCH 3/7] Removing some debugging

From: Bjorn Roche --- libavfilter/vf_paletteuse.c | 65 - 1 file changed, 11 insertions(+), 54 deletions(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c index abee1b3735..21870c22f5 100644 --- a/libavfilter/vf_paletteuse.c ++

[FFmpeg-devel] [PATCH 1/7] First pass at fixing paletteuse

From: Bjorn Roche Dithering doesn’t work, and only iterative and brute force color mapping work. --- libavfilter/vf_paletteuse.c | 265 +++- 1 file changed, 185 insertions(+), 80 deletions(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_palet

[FFmpeg-devel] [PATCH 2/7] Fix for dithering.

From: Bjorn Roche --- libavfilter/vf_paletteuse.c | 52 - 1 file changed, 18 insertions(+), 34 deletions(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c index e62503c8ea..abee1b3735 100644 --- a/libavfilter/vf_paletteuse.c ++

Re: [FFmpeg-devel] [PATCH 2/2 v2] avdevice/decklink_dec: use av_packet_add_side_data()

On Mon, 2 Oct 2017, James Almer wrote: It uses the existing buffer instead of allocating a new one. Signed-off-by: James Almer --- Untested. No changes since last version. libavdevice/decklink_dec.cpp | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavdevice/deckl

Re: [FFmpeg-devel] [PATCH 1/2 v2] avdevice/decklink_dec: remove av_dup_packet() usage

On Mon, 2 Oct 2017, James Almer wrote: Signed-off-by: James Almer --- Untested. Tested and works. libavdevice/decklink_dec.cpp | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 8a14094474..d8c6

Re: [FFmpeg-devel] [PATCH]lavd/decklink_dec: Do not claim to output transparency information

On Mon, 2 Oct 2017, Maksym Veremeyenko wrote: 29.09.2017 23:54, Marton Balint пише: [...] For output, there is definitely hardware support. For capture - I am not sure. I have not heard of a decklink device capturing key/fill. Unfortunately the decklink SDK uses the same constants for both

[FFmpeg-devel] [PATCH 2/2 v2] avdevice/decklink_dec: use av_packet_add_side_data()

It uses the existing buffer instead of allocating a new one. Signed-off-by: James Almer --- Untested. No changes since last version. libavdevice/decklink_dec.cpp | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/decklink_dec: remove av_dup_packet() usage

On 10/1/2017 11:51 PM, James Almer wrote: > It's no longer needed after the last commit. > > Signed-off-by: James Almer > --- > Untested > > libavdevice/decklink_dec.cpp | 4 > 1 file changed, 4 deletions(-) > > diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp > in

[FFmpeg-devel] [PATCH 1/2 v2] avdevice/decklink_dec: remove av_dup_packet() usage

Signed-off-by: James Almer --- Untested. libavdevice/decklink_dec.cpp | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 8a14094474..d8c624aa5d 100644 --- a/libavdevice/decklink_dec.cpp +++ b/libavdevi

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/decklink_dec: use av_packet_from_data() to create packets from an already allocated buffer

On 10/1/2017 11:51 PM, James Almer wrote: > As a side effect, the packets will now be refcounted. > > Signed-off-by: James Almer > --- > Untested Actually, i think this is wrong. Will send a (hopefully) working and simpler version in a bit. ___ ffmpeg-

Re: [FFmpeg-devel] [PATCH] avcodec/encode: remove usage of av_dup_packet()

On 10/2/2017 6:44 AM, wm4 wrote: > On Sun, 1 Oct 2017 23:17:59 -0300 > James Almer wrote: > >> Signed-off-by: James Almer >> --- >> libavcodec/encode.c | 20 >> 1 file changed, 12 insertions(+), 8 deletions(-) >> >> diff --git a/libavcodec/encode.c b/libavcodec/encode.c >>

[FFmpeg-devel] [PATCH]lavf/protocols: Add a cast to silence a warning

Hi! Attached patch fixes the following warning: libavformat/protocols.c:100:7: warning: assignment discards ‘const’ qualifier from pointer target type Please comment, Carl Eugen From 445245a4eb07b615511b2355b8e9f7baf9b665fe Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 2 Oct 2017 14

Re: [FFmpeg-devel] [PATCH]lavd/decklink_dec: Do not claim to output transparency information

29.09.2017 23:54, Marton Balint пише: [...] For output, there is definitely hardware support. For capture - I am not sure. I have not heard of a decklink device capturing key/fill. Unfortunately the decklink SDK uses the same constants for both capture and output, and if we want to follow the

[FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: Fix labels for IEC PAL DV 420

--- libavformat/mxfenc.c| 9 + tests/ref/lavf/mxf_dv25 | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index 3da96bf919..035e65ed43 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -48,6 +48,7 @@ #includ

[FFmpeg-devel] [PATCH 1/2] avformat/mxfenc: Add IEC DV25

Signed-off-by: Michael Niedermayer --- libavformat/mxfenc.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index b8d3030c40..3da96bf919 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -119,6 +119,8

Re: [FFmpeg-devel] [PATCH]lavf/img2dec: Auto-detect svg images

2017-10-02 11:43 GMT+02:00 wm4 : > On Mon, 2 Oct 2017 01:20:15 +0200 > Carl Eugen Hoyos wrote: > >> Hi! >> >> Attached patch implements auto-detection of svg images. >> >> Please review, Carl Eugen > > That looks like it'd be extremely fragile and react to anything that is > XML and happens to hav

Re: [FFmpeg-devel] [PATCH] avcodec/encode: remove usage of av_dup_packet()

On Sun, 1 Oct 2017 23:17:59 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/encode.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/encode.c b/libavcodec/encode.c > index 525ee1f5d6..dd50486bcf 100644 > --- a/

Re: [FFmpeg-devel] [PATCH]lavf/img2dec: Auto-detect svg images

On Mon, 2 Oct 2017 01:20:15 +0200 Carl Eugen Hoyos wrote: > Hi! > > Attached patch implements auto-detection of svg images. > > Please review, Carl Eugen That looks like it'd be extremely fragile and react to anything that is XML and happens to have the string "svg" and "http://ffmpeg.org/mail

Re: [FFmpeg-devel] [PATCH]lavf/img2dec: Auto-detect svg images

2017-10-02 7:52 GMT+02:00 Clément Bœsch : > On Mon, Oct 02, 2017 at 01:20:15AM +0200, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch implements auto-detection of svg images. >> >> Please review, Carl Eugen > >> From f06137f38f166740565e58d5c7c88777508f59ec Mon Sep 17 00:00:00 2001 >> From: Car