Re: [FFmpeg-devel] [PATCH] avcodec/tak: remove GetBitContext usage from avpriv_tak_parse_streaminfo()

On 10/25/2017 4:37 AM, Paul B Mahol wrote: > On 10/23/17, James Almer wrote: >> This prevents potential ABI issues with GetBitContext. >> >> Signed-off-by: James Almer >> --- >> libavcodec/tak.c | 17 +++-- >> libavcodec/tak.h | 8

Re: [FFmpeg-devel] [PATCH] avcodec/exif: remove GetByteContext usage from avpriv_exif_decode_ifd()

On 10/25/2017 4:32 AM, Paul B Mahol wrote: > On 10/24/17, James Almer wrote: >> This prevents potential ABI issues with GetByteContext. >> >> Signed-off-by: James Almer >> --- >> libavcodec/exif.c | 16 +--- >> libavcodec/exif.h | 6

Re: [FFmpeg-devel] [PATCH] fate: fix mpeg2-ticket6677 faillures on some platforms

On Wed, Oct 25, 2017 at 01:45:22PM +0800, Zhong Li wrote: > Signed-off-by: Zhong Li > --- > tests/fate/video.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many

Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

On Wed, Oct 25, 2017 at 06:48:06PM -0400, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 25, 2017 at 5:57 PM, Carl Eugen Hoyos > wrote: > > > 2017-10-25 16:52 GMT+02:00 Jean-Yves Avenard : > > > hi > > > > > > On 26 August 2017 at 12:08, Carl Eugen Hoyos

[FFmpeg-devel] [PATCH 2/2] avformat/hlsenc: fix missing first segment bug in fmp4 mode

fix ticket id: #6776 fix code logic error, need not check first segment. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index

[FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fix base_output_dirname is null when basename_size is 0 bug

fix ticket id: #6777 when use argument hls_segment_filename, the basename_size will be 0 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

On Wed, Oct 25, 2017 at 4:36 PM, Michael Niedermayer wrote: > On Wed, Oct 25, 2017 at 04:21:28PM -0700, Thierry Foucu wrote: > > On Wed, Oct 25, 2017 at 2:43 PM, Carl Eugen Hoyos > > wrote: > > > > > 2017-10-25 20:38 GMT+02:00 Thierry Foucu

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

On Wed, Oct 25, 2017 at 04:21:28PM -0700, Thierry Foucu wrote: > On Wed, Oct 25, 2017 at 2:43 PM, Carl Eugen Hoyos > wrote: > > > 2017-10-25 20:38 GMT+02:00 Thierry Foucu : > > > > > Without the patch, the decoder will return only 29 frames > > > > Isn't

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

On Wed, Oct 25, 2017 at 2:43 PM, Carl Eugen Hoyos wrote: > 2017-10-25 20:38 GMT+02:00 Thierry Foucu : > > > Without the patch, the decoder will return only 29 frames > > Isn't that the correct and expected output? > Not sure what you mean by correct. There

Re: [FFmpeg-devel] [PATCH] avutil/crc: always use precalculated CRC tables for known polynomials

On Tue, Oct 24, 2017 at 6:05 PM, Michael Niedermayer wrote: > On Mon, Oct 23, 2017 at 10:36:21PM -0300, James Almer wrote: >> On 10/23/2017 10:24 PM, Michael Niedermayer wrote: >> > On Tue, Oct 24, 2017 at 01:39:03AM +0100, Mark Thompson wrote: >> >> On 24/10/17 00:52,

Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

Hi, On Wed, Oct 25, 2017 at 5:57 PM, Carl Eugen Hoyos wrote: > 2017-10-25 16:52 GMT+02:00 Jean-Yves Avenard : > > hi > > > > On 26 August 2017 at 12:08, Carl Eugen Hoyos wrote: > >> 2017-08-25 13:25 GMT+02:00 Jean-Yves Avenard

[FFmpeg-devel] [PATCH 1/2] avcodec/jpeglsdec: Check ilv for being a supported value

Fixes: 1773/clusterfuzz-testcase-minimized-4832523987189760 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/jpeglsdec.c | 4 1 file changed, 4 insertions(+) diff

[FFmpeg-devel] [PATCH 2/2] avcodec/jpeglsdec: Check for end of bitstream in ls_decode_line()

Fixes: 1773/clusterfuzz-testcase-minimized-4832523987189760 Fixes: Timeout Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/jpeglsdec.c | 3 +++ 1 file changed, 3

Re: [FFmpeg-devel] [FFmpeg-cvslog] cbs_mpeg2: Fix type for marker_bit reading

2017-10-25 10:06 GMT+02:00 Hendrik Leppkes : > As if static analyzers always care what you can and cannot do. :p It was actually asan or ubsan iirc. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

2017-10-25 16:52 GMT+02:00 Jean-Yves Avenard : > hi > > On 26 August 2017 at 12:08, Carl Eugen Hoyos wrote: >> 2017-08-25 13:25 GMT+02:00 Jean-Yves Avenard : >> >>> +if (track->par->codec_id == AV_CODEC_ID_FLAC) { >> >> Why

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-25 20:38 GMT+02:00 Thierry Foucu : > Without the patch, the decoder will return only 29 frames Isn't that the correct and expected output? If you need cfr, you can request it. Once the frames are duplicated, you can't undo the file size multiplication. Carl Eugen

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

This time to the list properly... woops. On 10/25/2017 7:38 PM, Thierry Foucu wrote: > I tried using one of those files. > Without the patch, the decoder will return only 29 frames > With this patch, the decoder will return 1947 frames. > The time of decoding the file were the same (with or

Re: [FFmpeg-devel] libavcodec/lossless_videodsp : add add_bytes AVX2

On 10/25/17, Martin Vignali wrote: > 2017-10-25 22:08 GMT+02:00 Paul B Mahol : > >> On 10/25/17, Martin Vignali wrote: >> > 2017-10-25 21:53 GMT+02:00 Paul B Mahol : >> > >> >> On 10/25/17, Martin Vignali

Re: [FFmpeg-devel] libavcodec/lossless_videodsp : add add_bytes AVX2

2017-10-25 22:08 GMT+02:00 Paul B Mahol : > On 10/25/17, Martin Vignali wrote: > > 2017-10-25 21:53 GMT+02:00 Paul B Mahol : > > > >> On 10/25/17, Martin Vignali wrote: > >> > 2017-10-25 9:43 GMT+02:00 Paul

Re: [FFmpeg-devel] libavcodec/lossless_videodsp : add add_bytes AVX2

On 10/25/17, Martin Vignali wrote: > 2017-10-25 21:53 GMT+02:00 Paul B Mahol : > >> On 10/25/17, Martin Vignali wrote: >> > 2017-10-25 9:43 GMT+02:00 Paul B Mahol : >> > >> >> On 10/21/17, Martin Vignali

Re: [FFmpeg-devel] libavcodec/lossless_videodsp : add add_bytes AVX2

2017-10-25 21:53 GMT+02:00 Paul B Mahol : > On 10/25/17, Martin Vignali wrote: > > 2017-10-25 9:43 GMT+02:00 Paul B Mahol : > > > >> On 10/21/17, Martin Vignali wrote: > >> > Hello, > >> > > >> > In attach

Re: [FFmpeg-devel] libavcodec/lossless_videodsp : add add_bytes AVX2

On 10/25/17, Martin Vignali wrote: > 2017-10-25 9:43 GMT+02:00 Paul B Mahol : > >> On 10/21/17, Martin Vignali wrote: >> > Hello, >> > >> > In attach patch to add AVX2 version for add_bytes >> > >> >

Re: [FFmpeg-devel] libavcodec/utvideodsp : add avx2 version

2017-10-22 14:05 GMT+02:00 Martin Vignali : > Hello, > > In attach patch to add AVX2 version for the utvideodsp > > Checkasm result (Kaby Lake, os 10.12) > restore_rgb_planes_c: 8371.0 > restore_rgb_planes_sse2: 6583.7 > restore_rgb_planes_avx2: 3596.5 > >

Re: [FFmpeg-devel] libavcodec/lossless_videodsp : add add_bytes AVX2

2017-10-25 9:43 GMT+02:00 Paul B Mahol : > On 10/21/17, Martin Vignali wrote: > > Hello, > > > > In attach patch to add AVX2 version for add_bytes > > > > 0001-libavcodec-lossless_videodsp-add-add_bytes-avx2-vers : > > add AVX2 version > > > > pass

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

On Wed, Oct 25, 2017 at 4:59 AM, Michael Niedermayer wrote: > On Tue, Oct 24, 2017 at 06:42:54PM -0700, Thierry Foucu wrote: > > Changed the return value when no VOD were encoded in Mpeg4 bistream. > > And if we do have already a decoded frames and we are not in

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

Derek, On Wed, Oct 25, 2017 at 9:43 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 10/25/2017 2:42 AM, Thierry Foucu wrote: > > Changed the return value when no VOD were encoded in Mpeg4 bistream. > > And if we do have already a decoded frames and we are not in xvid_packed > >

[FFmpeg-devel] [PATCH 1/2] lavf/tls_securetransport: return buffered data first from tls_read

From: Aman Gupta This fixes a deadlock while reading a chunked https response, if multiple_requests=1 is also set. Without an EOF to signal the end of the last chunk, tls_read gets stuck forever trying to read more data than is available. This occurs with the http protocol

[FFmpeg-devel] [PATCH 2/2] lavf/tls_securetransport: build on iOS

From: Aman Gupta This works as expected on iOS, except for the ca_file feature which is disabled because SecItemImport is not available. --- configure | 6 +- libavformat/tls_securetransport.c | 4 2 files changed, 9 insertions(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

On Fri, 6 Oct 2017, Devin Heitmueller wrote: From: Devin Heitmueller Hook in libklvanc and use it for output of EIA-708 captions over SDI. The bulk of this patch is just general support for ancillary data for the Decklink SDI module - the real work for

Re: [FFmpeg-devel] [PATCH v2] avformat/wavenc: skip writing incorrect peak-of-peaks position value

On Wed, Oct 25, 2017 at 07:55:52PM +0200, Michael Niedermayer wrote: > On Tue, Oct 24, 2017 at 11:47:21AM +0200, Tobias Rapp wrote: > > According to EBU tech 3285 supplement 3 the dwPosPeakOfPeaks field > > should contain the absolute position to the maximum audio sample value, > > but the current

Re: [FFmpeg-devel] [PATCH 2/2] swscale: use dithering in DITHER_COPY only if not set -sws_dither none

On Tue, Oct 24, 2017 at 10:02:17AM +0200, Mateusz wrote: > This patch uses dithering in DITHER_COPY macro only if > it was not used option '-sws_dither none'. > With option '-sws_dither none' it uses downshift. > > For human eye dithering is OK, for video codecs not necessarily. > If user don't

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve hevc bi weighted hv mc msa functions

On Tue, Oct 24, 2017 at 11:21:39AM +, Manojkumar Bhosale wrote: > LGTM will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The educated differ from the uneducated as much as the living from the dead. -- Aristotle signature.asc Description:

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve avc chroma copy and avg vert mc msa functions

On Tue, Oct 24, 2017 at 11:21:32AM +, Manojkumar Bhosale wrote: > LGTM will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some touch of madness. -- Aristotle signature.asc Description: Digital

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve avc put mc 11, 31, 13 and 33 msa functions

On Tue, Oct 24, 2017 at 11:21:21AM +, Manojkumar Bhosale wrote: > LGTM will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is poorly written but fully understood is good. Rewriting code that one doesnt understand is a sign

Re: [FFmpeg-devel] [PATCH v2] avformat/wavenc: skip writing incorrect peak-of-peaks position value

On Tue, Oct 24, 2017 at 11:47:21AM +0200, Tobias Rapp wrote: > According to EBU tech 3285 supplement 3 the dwPosPeakOfPeaks field > should contain the absolute position to the maximum audio sample value, > but the current implementation writes the relative peak frame index > instead. > > Fix the

Re: [FFmpeg-devel] Don't use _tzcnt instrinics with clang for windows w/o BMI.

On Thu, Oct 26, 2017 at 03:39:57AM +1100, Matt Oliver wrote: > On 25 October 2017 at 07:15, Dale Curtis wrote: > > > Technically _tzcnt* intrinsics are only available when the BMI > > instruction set is present. However the instruction encoding > > degrades to "rep bsf"

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs (requires feedback)

On Wed, Oct 25, 2017 at 09:51:39AM -0400, Bjorn Roche wrote: > On Tue, Oct 24, 2017 at 8:56 PM, Michael Niedermayer > wrote: > > > On Tue, Oct 24, 2017 at 12:40:22PM -0400, Bjorn Roche wrote: > > > Support for transparencies in animated gifs requires modifying both > > >

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

On 10/25/2017 2:42 AM, Thierry Foucu wrote: > Changed the return value when no VOD were encoded in Mpeg4 bistream. > And if we do have already a decoded frames and we are not in xvid_packed > mode, output the existing decoded frame instead of nothing. > --- > libavcodec/h263dec.c | 9

Re: [FFmpeg-devel] Don't use _tzcnt instrinics with clang for windows w/o BMI.

On 25 October 2017 at 07:15, Dale Curtis wrote: > Technically _tzcnt* intrinsics are only available when the BMI > instruction set is present. However the instruction encoding > degrades to "rep bsf" on older processors. > > Clang for Windows debatably restricts the

[FFmpeg-devel] Invalid behaviour of av_parser_parse2 with some content

Hi. According to the documentation of av_parser_parse2: https://www.ffmpeg.org/doxygen/trunk/group__lavc__parsing.html#ga691ca0258e91f99297e7726f56d8c247 "poutbuf_size set to size of parsed buffer or zero if not yet finished. " So we can expect that both poutbuf_size and poutbuf will be set

Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

hi On 26 August 2017 at 12:08, Carl Eugen Hoyos wrote: > 2017-08-25 13:25 GMT+02:00 Jean-Yves Avenard : > >> +if (track->par->codec_id == AV_CODEC_ID_FLAC) { > > Why does this only apply to flac? > Sorry, I had missed your reply. The

Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

Hi, On Fri, Aug 25, 2017 at 7:29 PM, Michael Niedermayer wrote: > On Fri, Aug 25, 2017 at 01:25:23PM +0200, Jean-Yves Avenard wrote: > > From 9baa7166fa96ed6beac9146c7e3b4dcf425a67d0 Mon Sep 17 00:00:00 2001 > > From: Jean-Yves Avenard > > Date:

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs (requires feedback)

On Tue, Oct 24, 2017 at 8:56 PM, Michael Niedermayer wrote: > On Tue, Oct 24, 2017 at 12:40:22PM -0400, Bjorn Roche wrote: > > Support for transparencies in animated gifs requires modifying both > > libavcodec/gif.c and libavformat/gif.c because both the graphics > >

Re: [FFmpeg-devel] [PATCH 2/2] avformat: deprecate getters and setters for AVFormatContext and AVStream fields

On 10/23/17, James Almer wrote: > The fields can be accessed directly, so these are not needed anymore. > > Signed-off-by: James Almer > --- > libavformat/avformat.h | 30 +- > libavformat/utils.c| 4 >

[FFmpeg-devel] [PATCH] configure: v4l2_m2m depends on pthreads

Fixes build with --disable-pthreads. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index c86e578..76523c8 100755 --- a/configure +++ b/configure @@ -2780,7 +2780,7 @@ omx_rpi_select="omx" qsvdec_select="qsv" qsvenc_select="qsv"

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

On Tue, Oct 24, 2017 at 06:42:54PM -0700, Thierry Foucu wrote: > Changed the return value when no VOD were encoded in Mpeg4 bistream. > And if we do have already a decoded frames and we are not in xvid_packed > mode, output the existing decoded frame instead of nothing. > --- >

Re: [FFmpeg-devel] [PATCH 3/3] lavf/aviobuf: return EINVAL when reading from a write-only context.

Le quartidi 4 brumaire, an CCXXVI, Hendrik Leppkes a écrit : > I think you meant to change the other ret assignment? You are entirely right. Locally swapped. Thanks for noticing. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH 3/3] lavf/aviobuf: return EINVAL when reading from a write-only context.

On Wed, Oct 25, 2017 at 10:22 AM, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavformat/aviobuf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Not related to the issue, but seems more correct. > > > diff --git

Re: [FFmpeg-devel] NVENC - HEVC + WP

Am 25.10.2017 um 06:06 schrieb Yogender Gupta: One of the users had recently complained about encoding problems with HEVC encoding with WP (Weighted Prediction). This is a driver issue that has been identified, and shows up when using HEVC + WP + (PictureTimingSEI messages and or buffering

Re: [FFmpeg-devel] [PATCH] libavformat: not treat 0 as EOF

Le tridi 3 brumaire, an CCXXVI, Nicolas George a écrit : > As I said, I will try to find time to implement a correct workaround > tomorrow. Patch series posted. https://ffmpeg.org/pipermail/ffmpeg-devel/2017-October/218482.html https://patchwork.ffmpeg.org/patch/5686/ Please confirm if it fixes

[FFmpeg-devel] [PATCH 3/3] lavf/aviobuf: return EINVAL when reading from a write-only context.

Signed-off-by: Nicolas George --- libavformat/aviobuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Not related to the issue, but seems more correct. diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index bb5bcf7a14..dfe8437b18 100644 ---

[FFmpeg-devel] [PATCH 2/3] lavf/avio: temporarily accept 0 as EOF.

Print a warning to let applicatios fix their use. After a deprecation period, check with a low-level assert. Also make the constraint explicit in the doxygen comment. Signed-off-by: Nicolas George --- libavformat/avio.h| 2 ++ libavformat/aviobuf.c | 30

[FFmpeg-devel] [PATCH 1/3] examples/avio_reading: return AVERROR_EOF at EOF.

Signed-off-by: Nicolas George --- doc/examples/avio_reading.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/examples/avio_reading.c b/doc/examples/avio_reading.c index 02474e907a..7860fd5e2f 100644 --- a/doc/examples/avio_reading.c +++ b/doc/examples/avio_reading.c

Re: [FFmpeg-devel] [FFmpeg-cvslog] cbs_mpeg2: Fix type for marker_bit reading

On Wed, Oct 25, 2017 at 12:42 AM, Mark Thompson wrote: > On 24/10/17 23:34, Carl Eugen Hoyos wrote: >> 2017-10-25 0:29 GMT+02:00 Mark Thompson : >>> On 24/10/17 23:14, Carl Eugen Hoyos wrote: 2017-10-25 0:09 GMT+02:00 Mark Thompson : >

Re: [FFmpeg-devel] libavcodec/bswapdsp : add AVX2 for bswap_buf

On 10/22/17, Martin Vignali wrote: > Hello, > > In attach patch in order to add an AVX2 version for bswap_buf > (swap uint32 in a buffer) > > Checkasm result (Kaby Lake 10.12) > bswap_buf_c: 122.8 > bswap_buf_sse2: 67.8 > bswap_buf_ssse3: 34.3 > bswap_buf_avx2: 21.0 > >

Re: [FFmpeg-devel] [PATCH] avcodec/tak: remove GetBitContext usage from avpriv_tak_parse_streaminfo()

On 10/23/17, James Almer wrote: > This prevents potential ABI issues with GetBitContext. > > Signed-off-by: James Almer > --- > libavcodec/tak.c | 17 +++-- > libavcodec/tak.h | 8 ++-- > libavformat/takdec.c | 7 +-- > 3 files

Re: [FFmpeg-devel] libavcodec/lossless_videodsp : add add_bytes AVX2

On 10/21/17, Martin Vignali wrote: > Hello, > > In attach patch to add AVX2 version for add_bytes > > 0001-libavcodec-lossless_videodsp-add-add_bytes-avx2-vers : > add AVX2 version > > pass fate-test for me (os 10.12, x86_64) > > checkasm result : (Kaby Lake) (run 10

Re: [FFmpeg-devel] [PATCH] avcodec/exif: remove GetByteContext usage from avpriv_exif_decode_ifd()

On 10/24/17, James Almer wrote: > This prevents potential ABI issues with GetByteContext. > > Signed-off-by: James Almer > --- > libavcodec/exif.c | 16 +--- > libavcodec/exif.h | 6 -- > libavcodec/mjpegdec.c | 2 +- >