Re: [FFmpeg-devel] [RFC] Removing mpeg4video from mpegvideo

2017-11-04 Thread Michael Niedermayer
On Sat, Nov 04, 2017 at 08:27:42PM +, Kieran Kunhya wrote: > Hello, > > I need to remove MPEG-4 support from mpegvideo in order to upstream the > following code: > https://github.com/kierank/ffmpeg-sstp > > I'll need to extract mpeg4video from mpegvideo for the following reasons in > the Stud

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: fix calculation of input file duration in seek_to_start()

2017-11-04 Thread Michael Niedermayer
On Sun, Oct 29, 2017 at 03:09:13PM +0100, Peter Große wrote: > On Sun, 29 Oct 2017 14:56:20 +0100 > Moritz Barsnick wrote: > > > On Sun, Oct 29, 2017 at 12:08:05 +0100, Peter Große wrote: > > > } else duration = 1; > > > > For style/readability, the statement should be on a new li

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-11-04 Thread Mironov, Mikhail
> > +// > > + > > +// Reduced AMF API > > +// > > +// Full version of AMF SDK and the latest version of this file > > +// can be found at https://github.com/GPUOpen-LibrariesAndSDKs/AMF > > On further consideration I am against including this header. Just ask the > user > to get it from this lin

Re: [FFmpeg-devel] [RFC/PATCH]lavc/v4l2_context: Change the type of the ioctl cmd to unsigned long

2017-11-04 Thread Mark Thompson
On 05/11/17 00:46, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes a warning on a current 64bit Linux system (that I > do not see on my ancient system where the ioctl cmd has type int). > Is there a better way to deal with it? > Fixes a warning on recent Linux: > libavcodec/v4l2_context.c:

Re: [FFmpeg-devel] [RFC/PATCH]lavc/v4l2_context: Change the type of the ioctl cmd to unsigned long

2017-11-04 Thread Mark Thompson
On 05/11/17 01:25, Carl Eugen Hoyos wrote: > 2017-11-05 1:46 GMT+01:00 Carl Eugen Hoyos : > >> Attached patch fixes a warning on a current 64bit Linux system (that I >> do not see on my ancient system where the ioctl cmd has type int). >> Is there a better way to deal with it? > > The way I under

Re: [FFmpeg-devel] [RFC/PATCH]lavc/v4l2_context: Change the type of the ioctl cmd to unsigned long

2017-11-04 Thread Carl Eugen Hoyos
2017-11-05 1:46 GMT+01:00 Carl Eugen Hoyos : > Attached patch fixes a warning on a current 64bit Linux system (that I > do not see on my ancient system where the ioctl cmd has type int). > Is there a better way to deal with it? The way I understand the issue the attached patch works with both int

Re: [FFmpeg-devel] [RFC] Removing mpeg4video from mpegvideo

2017-11-04 Thread Kieran Kunhya
On Sat, 4 Nov 2017 at 22:33 Carl Eugen Hoyos wrote: > 2017-11-04 21:27 GMT+01:00 Kieran Kunhya : > > > I need to remove MPEG-4 support from mpegvideo in order > > to upstream the following code: > > https://github.com/kierank/ffmpeg-sstp > > Decoding of the yuv422p10 samples does not yet work. >

[FFmpeg-devel] [RFC/PATCH]lavc/v4l2_context: Change the type of the ioctl cmd to unsigned long

2017-11-04 Thread Carl Eugen Hoyos
Hi! Attached patch fixes a warning on a current 64bit Linux system (that I do not see on my ancient system where the ioctl cmd has type int). Is there a better way to deal with it? Please comment, Carl Eugen From 06886eea147cd68ee14291de1e437c364682f8ef Mon Sep 17 00:00:00 2001 From: Carl Eugen H

Re: [FFmpeg-devel] [RFC] Removing mpeg4video from mpegvideo

2017-11-04 Thread Carl Eugen Hoyos
2017-11-04 21:27 GMT+01:00 Kieran Kunhya : > I need to remove MPEG-4 support from mpegvideo in order > to upstream the following code: > https://github.com/kierank/ffmpeg-sstp Decoding of the yuv422p10 samples does not yet work. Is the rgb output correct? It looks as if seen through a strange col

[FFmpeg-devel] [PATCH 2/2] Document the fact that -to option is now also for input

2017-11-04 Thread vi0oss
From: Vitaly _Vi Shukela Signed-off-by: Vitaly _Vi Shukela --- doc/ffmpeg.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 7db80ebf6a..3df171fe63 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -290,7 +290,7 @@ see @ref{time

[FFmpeg-devel] [PATCH 1/2] Allow -to on input files as well

2017-11-04 Thread vi0oss
From: Vitaly _Vi Shukela Why only output files can have both -t and -to? Signed-off-by: Vitaly "_Vi" Shukela --- fftools/ffmpeg_opt.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index ca6f10d5ca..e453cb34c5 1

Re: [FFmpeg-devel] [RFC] Removing mpeg4video from mpegvideo

2017-11-04 Thread James Almer
On 11/4/2017 5:27 PM, Kieran Kunhya wrote: > Hello, > > I need to remove MPEG-4 support from mpegvideo in order to upstream the > following code: > https://github.com/kierank/ffmpeg-sstp > > I'll need to extract mpeg4video from mpegvideo for the following reasons in > the Studio Profile: > > - 1

[FFmpeg-devel] [RFC] Removing mpeg4video from mpegvideo

2017-11-04 Thread Kieran Kunhya
Hello, I need to remove MPEG-4 support from mpegvideo in order to upstream the following code: https://github.com/kierank/ffmpeg-sstp I'll need to extract mpeg4video from mpegvideo for the following reasons in the Studio Profile: - 10-bit video, mpegvideo.c is entirely 8-bit, I'll need to write

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-11-04 Thread Mark Thompson
On 31/10/17 19:39, mmironov wrote: > From 8640b995634f827eb39ae87bcbe2c1992d8140f2 Mon Sep 17 00:00:00 2001 > From: mmironov > Date: Fri, 27 Oct 2017 13:03:15 -0400 > Subject: [PATCH] Added: HW accelerated H.264 and HEVC encoding for AMD GPUs > based on AMF SDK > > Signed-off-by: mmironov > ---

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve hevc uni weighted 4 tap hz mc msa functions

2017-11-04 Thread Michael Niedermayer
On Sat, Nov 04, 2017 at 01:08:20AM +, Manojkumar Bhosale wrote: > LGTM applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Breaking DRM is a little like attempting to break through a door even though the window is wide open and the only thing in

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve hevc uni 4 tap hz and vt mc msa functions

2017-11-04 Thread Michael Niedermayer
On Sat, Nov 04, 2017 at 01:07:41AM +, Manojkumar Bhosale wrote: > LGTM will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Does the universe only have a finite lifespan? No, its going to go on forever, its just that you wont like living in it.

Re: [FFmpeg-devel] [PATCH] avcodec/xan: Check for bitstream end in xan_huffman_decode()

2017-11-04 Thread Michael Niedermayer
On Fri, Nov 03, 2017 at 05:48:29PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: 3707/clusterfuzz-testcase-6465922706440192 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavc

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/exr: fix undefined shift in pxr24_uncompress()

2017-11-04 Thread Michael Niedermayer
On Sat, Nov 04, 2017 at 10:21:37AM +0100, Paul B Mahol wrote: > On 11/4/17, Michael Niedermayer wrote: > > Fixes: runtime error: left shift of 255 by 24 places cannot be represented > > in type 'int' > > Fixes: 3787/clusterfuzz-testcase-minimized-5728764920070144 > > > > Found-by: continuous fuzzi

Re: [FFmpeg-devel] [PATCH]lavc/pcm-dvd: Do not use an incompatible pointer on big-endian.

2017-11-04 Thread Carl Eugen Hoyos
2017-11-01 18:33 GMT+01:00 Carl Eugen Hoyos : > 2017-11-01 18:18 GMT+01:00 Hendrik Leppkes : >> On Wed, Nov 1, 2017 at 5:13 PM, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch silences a gcc warning, tested with Fever.vob >>> >>> >>> @@ -163,10 +162,12 @@ static void *pcm_dvd_decode_samples

Re: [FFmpeg-devel] [PATCH]lavc/pcm-bluray: Do not use incompatible pointers on big-endian.

2017-11-04 Thread Carl Eugen Hoyos
2017-11-01 19:01 GMT+01:00 Carl Eugen Hoyos : > 2017-11-01 18:31 GMT+01:00 Hendrik Leppkes : >> On Wed, Nov 1, 2017 at 6:25 PM, Carl Eugen Hoyos wrote: >>> 2017-11-01 18:16 GMT+01:00 Hendrik Leppkes : On Wed, Nov 1, 2017 at 5:16 PM, Carl Eugen Hoyos wrote: > Hi! > > Attache

Re: [FFmpeg-devel] libavcodec/h264_sei: Don't log random user data.

2017-11-04 Thread Kieran Kunhya
On Sat, 4 Nov 2017 at 18:28 Michael Niedermayer wrote: > > The UUID can be corrupt as well. > > We shouldn't be printing random data from the bitstream to the users > > terminal. > > i agree > Ok, I will push unless someone objects. Kieran ___ ffmpeg-

Re: [FFmpeg-devel] [PATCH] HW accelerator: Indicate when HW acceleration is in use

2017-11-04 Thread Mark Thompson
On 03/11/17 18:35, Michele Lim wrote: > Having clear indication of when a hardware accelerator is in > operation prevents false assumptions, for e.g., in situations when > the command line argument inadvertently omits options for enabling > it, resulting to the framework silently switching to the S

Re: [FFmpeg-devel] [PATCH] ffplay: use SDL2 audio API

2017-11-04 Thread James Almer
On 11/4/2017 3:54 PM, Marton Balint wrote: > It allows us to specify what kind of audio parameter changes are allowed. > > Should fix ticket #6721. Seems to work. Thanks. > > Signed-off-by: Marton Balint > --- > fftools/ffplay.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-)

[FFmpeg-devel] [PATCH] ffplay: use SDL2 audio API

2017-11-04 Thread Marton Balint
It allows us to specify what kind of audio parameter changes are allowed. Should fix ticket #6721. Signed-off-by: Marton Balint --- fftools/ffplay.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index c264e92535..bd1457c7e3 1006

Re: [FFmpeg-devel] libavcodec/utvideodsp : add avx2 version

2017-11-04 Thread Martin Vignali
2017-10-25 21:53 GMT+02:00 Martin Vignali : > > > 2017-10-22 14:05 GMT+02:00 Martin Vignali : > >> Hello, >> >> In attach patch to add AVX2 version for the utvideodsp >> >> Checkasm result (Kaby Lake, os 10.12) >> restore_rgb_planes_c: 8371.0 >> restore_rgb_planes_sse2: 6583.7 >> restore_rgb_plane

Re: [FFmpeg-devel] libavcodec/huffyuvdsp(enc) : add avx2 version for add(diff)_int16

2017-11-04 Thread Martin Vignali
2017-10-22 0:26 GMT+02:00 Martin Vignali : > Hello, > > In attach patch to add avx2 version for huffyuv dsp and huffyuvdsp enc > for add_int16 and diff_int16 func > > Check asm result for add_int16 (Kaby Lake, os 10.12) > add_int16_128_c: 1607.9 > add_int16_128_sse2: 442.7 > add_int16_128_avx2: 21

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: create the window and the renderer before starting playback

2017-11-04 Thread Marton Balint
On Sun, 29 Oct 2017, Marton Balint wrote: On Sat, 28 Oct 2017, Clément Bœsch wrote: On Sat, Oct 28, 2017 at 11:05:15PM +0200, Marton Balint wrote: Signed-off-by: Marton Balint --- fftools/ffplay.c | 67 +--- 1 file changed, 35 inser

Re: [FFmpeg-devel] libavcodec/h264_sei: Don't log random user data.

2017-11-04 Thread Michael Niedermayer
On Sat, Nov 04, 2017 at 06:23:12PM +, Kieran Kunhya wrote: > On Sat, 6 May 2017 at 17:51 James Almer wrote: > > > The proper change here would be to look at the uuid and print only those > > known to store printable strings, and of course after making sure they > > are in fact printable. > >

Re: [FFmpeg-devel] libavcodec/h264_sei: Don't log random user data.

2017-11-04 Thread Kieran Kunhya
On Sat, 6 May 2017 at 17:51 James Almer wrote: > The proper change here would be to look at the uuid and print only those > known to store printable strings, and of course after making sure they > are in fact printable. > As of now, that means x264's uuid only. > The UUID can be corrupt as well.

Re: [FFmpeg-devel] PATCH] h2645: Allocate a single buffer per packet. Drastically reduces memory usage on pathological streams.

2017-11-04 Thread James Almer
On 11/4/2017 2:52 PM, Derek Buitenhuis wrote: > On 11/3/2017 6:23 PM, Kieran Kunhya wrote: >> This patch fixes very high memory usage on pathological streams. > > [...] > >> -H2645Packet pkt = { 0 }; >> +H2645Packet pkt; >> +memset(&pkt, 0, sizeof(pkt)); > > Stray unrelated change.

Re: [FFmpeg-devel] PATCH] h2645: Allocate a single buffer per packet. Drastically reduces memory usage on pathological streams.

2017-11-04 Thread Derek Buitenhuis
On 11/3/2017 6:23 PM, Kieran Kunhya wrote: > This patch fixes very high memory usage on pathological streams. [...] > -H2645Packet pkt = { 0 }; > +H2645Packet pkt; > +memset(&pkt, 0, sizeof(pkt)); Stray unrelated change. Rest seems reasonable from a cursory glance. I assume it's bee

[FFmpeg-devel] [PATCH] web/template_head2: Prevent battleforthenet widget to show again after being clicked away

2017-11-04 Thread Michael Niedermayer
Also ensure that the widget does not use google analytics. Iam not sure it actually did before, my box has too many layers that stop this. Signed-off-by: Michael Niedermayer --- src/template_head2 | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/template_head2 b/sr

Re: [FFmpeg-devel] [PATCH]lavc/alac: Avoid allocating huge memory blocks for malicious alac input.

2017-11-04 Thread Carl Eugen Hoyos
2017-11-04 10:23 GMT+01:00 Paul B Mahol : > On 11/4/17, Carl Eugen Hoyos wrote: >> 2017-11-01 17:03 GMT+01:00 Carl Eugen Hoyos : >>> 2017-11-01 17:01 GMT+01:00 Paul B Mahol : On 11/1/17, Carl Eugen Hoyos wrote: > 2017-11-01 15:40 GMT+01:00 Paul B Mahol : >> On 11/1/17, Carl Eugen Hoy

[FFmpeg-devel] [PATCH] libavformat: LibreSSL (libtls) support

2017-11-04 Thread Stefan _
Attached patch adds support for LibreSSL. Instead of trying to implement support into the existing tls_openssl.c using lots of #ifdefs (which was rejected previously(?)) this adds a new TLS backend making use of the new libtls library. Things to note: - Haven't looked at LibreSSL's license clo

[FFmpeg-devel] Maintainers : add myself for exr

2017-11-04 Thread Martin Vignali
Hello, Following Michael Niedermayer request, patch in attach to add myself for exr decoder Martin 0001-Maintainers-add-myself-for-exr.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/list

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: fix calculation of input file duration in seek_to_start()

2017-11-04 Thread Peter Große
On Sun, 29 Oct 2017 21:45:04 +0100 Peter Große wrote: > On Sun, 29 Oct 2017 21:33:10 +0100 > Michael Niedermayer wrote: > > > seems this doesnt apply > > > > Yeah, it depends on the patch I started the thread with. > > I can swap the order of the two patches if you want, so that the > styl

Re: [FFmpeg-devel] [PATCH] avformat/dv : change audio format endianess to BE

2017-11-04 Thread Michael Niedermayer
On Fri, Nov 03, 2017 at 05:44:28PM -0800, Lou Logan wrote: > On Fri, Nov 3, 2017, at 04:49 PM, Michael Niedermayer wrote: > > This does not explain why this change is done. > > does it fix a bug? > > does it make the code faster? > > ffmbc uses BE too, but I'm ignorant as to why it does. If BE is

[FFmpeg-devel] [PATCH] avformat: add TiVo ty demuxer

2017-11-04 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/ty.c | 765 +++ 3 files changed, 767 insertions(+) create mode 100644 libavformat/ty.c diff --git a/libavformat/Makefile b/libavfor

Re: [FFmpeg-devel] [PATCH]lavc/alac: Avoid allocating huge memory blocks for malicious alac input.

2017-11-04 Thread Paul B Mahol
On 11/4/17, Carl Eugen Hoyos wrote: > 2017-11-01 17:03 GMT+01:00 Carl Eugen Hoyos : >> 2017-11-01 17:01 GMT+01:00 Paul B Mahol : >>> On 11/1/17, Carl Eugen Hoyos wrote: 2017-11-01 15:40 GMT+01:00 Paul B Mahol : > On 11/1/17, Carl Eugen Hoyos wrote: >> Hi! >> >> It appears to

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/exr: fix undefined shift in pxr24_uncompress()

2017-11-04 Thread Paul B Mahol
On 11/4/17, Michael Niedermayer wrote: > Fixes: runtime error: left shift of 255 by 24 places cannot be represented > in type 'int' > Fixes: 3787/clusterfuzz-testcase-minimized-5728764920070144 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpe