[FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-11 Thread Thomas Köppe
Variables used in inline assembly need to be marked with attribute((used)). Static constants already were, via the define of DECLARE_ASM_CONST. But DECLARE_ALIGNED does not add this attribute, and some of the variables defined with it are const only used in inline assembly, and therefore appeared d

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add skip option

2017-11-11 Thread Nicolas George
Le septidi 17 brumaire, an CCXXVI, Paul B Mahol a écrit : > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 5 + > libavfilter/vf_tile.c | 53 > ++- > 2 files changed, 49 insertions(+), 9 deletions(-) The logic of the code looks o

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h265_metadata_bsf: fix the AVClass version number

2017-11-11 Thread Michael Niedermayer
On Sat, Nov 11, 2017 at 01:47:21AM -0300, James Almer wrote: > --- > libavcodec/h265_metadata_bsf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/h265_metadata_bsf.c b/libavcodec/h265_metadata_bsf.c > index 9af5cc256f..67dbe288e3 100644 > --- a/libavcodec/h26

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264_metadata_bsf: fix the AVClass version number

2017-11-11 Thread Michael Niedermayer
On Sat, Nov 11, 2017 at 01:47:20AM -0300, James Almer wrote: > --- > libavcodec/h264_metadata_bsf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c > index 73e73e96e4..ada40a57c7 100644 > --- a/libavcodec/h26

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mpeg2_metadata_bsf: fix the AVClass version number

2017-11-11 Thread Michael Niedermayer
On Sat, Nov 11, 2017 at 01:47:22AM -0300, James Almer wrote: > --- > libavcodec/mpeg2_metadata_bsf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mpeg2_metadata_bsf.c b/libavcodec/mpeg2_metadata_bsf.c > index f1f84e6cd9..b9a49ab943 100644 > --- a/libavcodec/

Re: [FFmpeg-devel] [PATCH v4 07/14] avcodec/h264: implement new decode_params callback for PPS/SPS

2017-11-11 Thread Michael Niedermayer
On Fri, Nov 10, 2017 at 01:40:52PM -0800, Aman Gupta wrote: > From: Aman Gupta > > This callback will be used by the VideoToolbox H264 hwaccel so that it > can receive SPS and PPS NALUs. VideoToolbox requires PPS changes to be > fed into the decoder session, and for the session to be recreated wh

Re: [FFmpeg-devel] [PATCH v4 06/14] avcodec: add decode_params callback to AVHWAccel struct

2017-11-11 Thread Michael Niedermayer
On Fri, Nov 10, 2017 at 01:40:51PM -0800, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/avcodec.h | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index c4134424f0..2bd46faa50 100644 > --- a/libavcodec/avcodec.h >

Re: [FFmpeg-devel] [PATCH v4 05/14] avcodec/h264, videotoolbox: return AVERROR_INVALIDDATA when no frames are produced

2017-11-11 Thread Michael Niedermayer
On Fri, Nov 10, 2017 at 01:40:50PM -0800, Aman Gupta wrote: > From: Aman Gupta > > The only reason videotoolbox wouldn't produce frames is if the data fed > to it was invalid, so returning AVERROR_INVALIDDATA makes sense here. > > Further, it means AVERROR_EXTERNAL can be used in further commits

Re: [FFmpeg-devel] [PATCH] ffmpeg: use explicitly requested hwaccel only

2017-11-11 Thread Michael Niedermayer
On Fri, Nov 10, 2017 at 10:20:46PM +0100, Timo Rothenpieler wrote: > With there being two hwaccels that use the CUDA pix_fmt now, just > relying on the pix_fmt to identify the selected hwaccel is not enough > anymore. > > So this checks if the user explicitly selected a hwaccel, and only > accepts

[FFmpeg-devel] [PATCH 1/2] avcodec/decode: always free private_ref

2017-11-11 Thread Timo Rothenpieler
There is no reason to keep this intact when decoding failed, specially as private_ref is supposed to always be NULL when a frame is returned to the user. --- libavcodec/decode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c inde

[FFmpeg-devel] [PATCH 2/2] wmavoice: free frame before ff_get_buffer

2017-11-11 Thread Timo Rothenpieler
synth_superframe can be called twice per call to decode_packet. It is not fully clear if calling ff_get_buffer on the same frame twice is supported, so unref the frame first to be save. --- libavcodec/wmavoice.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/wmavoice.c b/libavc

Re: [FFmpeg-devel] [PATCH] avformat/utils: preserve AV_PKT_FLAG_DISCARD in parse_packet

2017-11-11 Thread Michael Niedermayer
On Fri, Nov 10, 2017 at 04:07:28PM -0800, John Stebbins wrote: > --- > libavformat/utils.c | 1 + > 1 file changed, 1 insertion(+) will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning the gods, I have no means of knowing whether they ex

Re: [FFmpeg-devel] [PATCH] avformat/img2enc: add frame_pts option for make output filename

2017-11-11 Thread Michael Niedermayer
On Tue, Oct 31, 2017 at 11:47:33PM +0800, Steven Liu wrote: > when use frame_pts option, the output image name can be set with PTS > of current frame. > > Signed-off-by: Steven Liu > --- > doc/muxers.texi | 9 + > libavformat/img2enc.c | 7 +++ > 2 files changed, 16 insertions(

Re: [FFmpeg-devel] [PATCH] avcodec: fix wrong duration of packets (dvd, bluray)

2017-11-11 Thread Michael Niedermayer
On Fri, Nov 10, 2017 at 02:32:39PM +0300, Александр Слободенюк wrote: > Fixing very little bug for blu ray pcm in .mts files: will apply can you make a fate test for this ? thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but th

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

2017-11-11 Thread Michael Niedermayer
On Thu, Nov 09, 2017 at 04:11:22PM -0800, Sasi Inguva wrote: > Partially fixes t/6699. > --- > libavformat/mov.c | 32 +++--- > tests/fate/mov.mak| 4 > tests/ref/fate/mov-elst-ends-betn-b-and-i | 33 > +

Re: [FFmpeg-devel] [PATCH] ffmpeg: use explicitly requested hwaccel only

2017-11-11 Thread Timo Rothenpieler
Am 11.11.2017 um 13:02 schrieb Michael Niedermayer: On Fri, Nov 10, 2017 at 10:20:46PM +0100, Timo Rothenpieler wrote: With there being two hwaccels that use the CUDA pix_fmt now, just relying on the pix_fmt to identify the selected hwaccel is not enough anymore. So this checks if the user expl

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/decode: always free private_ref

2017-11-11 Thread Timo Rothenpieler
series applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/4] MAINTAINERS: update for cuvid/nvdec changes

2017-11-11 Thread Timo Rothenpieler
--- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index c70d949a71..4df6c6533d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -158,7 +158,7 @@ Codecs: cpia.cStephan Hilb crystalhd.c

[FFmpeg-devel] [PATCH 2/4] avcodec/nvdec: correctly set output frame size

2017-11-11 Thread Timo Rothenpieler
--- libavcodec/nvdec.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/libavcodec/nvdec.c b/libavcodec/nvdec.c index db338accfa..780c2e67cf 100644 --- a/libavcodec/nvdec.c +++ b/libavcodec/nvdec.c @@ -232,8 +232,8 @@ int ff_nvdec_decode_init(AVCodecContext *avct

[FFmpeg-devel] [PATCH 4/4] avcodec/nvdec: check hardware capabilities

2017-11-11 Thread Timo Rothenpieler
--- libavcodec/nvdec.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/libavcodec/nvdec.c b/libavcodec/nvdec.c index d3620f0d1f..d706540db0 100644 --- a/libavcodec/nvdec.c +++ b/libavcodec/nvdec.c @@ -74,6 +74,56 @@ static int map_chroma_

[FFmpeg-devel] [PATCH 3/4] avcodec/nvdec: add support for 12 bit formats

2017-11-11 Thread Timo Rothenpieler
--- libavcodec/nvdec.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/libavcodec/nvdec.c b/libavcodec/nvdec.c index 780c2e67cf..d3620f0d1f 100644 --- a/libavcodec/nvdec.c +++ b/libavcodec/nvdec.c @@ -234,9 +234,21 @@ int ff_nvdec_decode_init(AVCodecContext

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/nvdec: correctly set output frame size

2017-11-11 Thread James Almer
On 11/11/2017 12:21 PM, Timo Rothenpieler wrote: > --- > libavcodec/nvdec.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/nvdec.c b/libavcodec/nvdec.c > index db338accfa..780c2e67cf 100644 > --- a/libavcodec/nvdec.c > +++ b/libavcodec/nvdec.c

[FFmpeg-devel] [PATCH 2/4] avcodec/nvdec: correctly set output frame size

2017-11-11 Thread Timo Rothenpieler
--- libavcodec/nvdec.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/nvdec.c b/libavcodec/nvdec.c index db338accfa..894112a144 100644 --- a/libavcodec/nvdec.c +++ b/libavcodec/nvdec.c @@ -232,8 +232,8 @@ int ff_nvdec_decode_init(AVCodecContext *avctx, unsi

Re: [FFmpeg-devel] [PATCH 1/2] swscale: fix dithers table for DITHER_COPY macro

2017-11-11 Thread Mateusz
W dniu 24.10.2017 o 10:02, Mateusz pisze: > The Bayer matrix 8x8 used in DITHER_COPY macro is table dithers[5]. > Remaining dithers[] matrixes are generated from this matrix by > downshift or upshift. > > This patch fixes dithers[6] and dithers[7] matrixes -- they were > too dark. ping _

Re: [FFmpeg-devel] [PATCH 1/4] MAINTAINERS: update for cuvid/nvdec changes

2017-11-11 Thread Michael Niedermayer
On Sat, Nov 11, 2017 at 04:21:36PM +0100, Timo Rothenpieler wrote: > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are best at talking, realize last or never when the

Re: [FFmpeg-devel] [PATCH v4 06/14] avcodec: add decode_params callback to AVHWAccel struct

2017-11-11 Thread Aman Gupta
On Sat, Nov 11, 2017 at 3:54 AM Michael Niedermayer wrote: > On Fri, Nov 10, 2017 at 01:40:51PM -0800, Aman Gupta wrote: > > From: Aman Gupta > > > > --- > > libavcodec/avcodec.h | 14 ++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/libavcodec/avcodec.h b/libavcodec/avc

Re: [FFmpeg-devel] [PATCH v4 06/14] avcodec: add decode_params callback to AVHWAccel struct

2017-11-11 Thread Aman Gupta
On Fri, Nov 10, 2017 at 6:07 PM Aman Gupta wrote: > On Fri, Nov 10, 2017 at 5:45 PM, James Almer wrote: > >> On 11/10/2017 6:40 PM, Aman Gupta wrote: >> > From: Aman Gupta >> > >> > --- >> > libavcodec/avcodec.h | 14 ++ >> > 1 file changed, 14 insertions(+) >> > >> > diff --git a/

[FFmpeg-devel] [PATCH] avfilter/vf_tile: add overlap option

2017-11-11 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 5 + libavfilter/vf_tile.c | 54 ++- 2 files changed, 50 insertions(+), 9 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 5c6729a484..6079290fbd 100644 --- a/doc/filte

[FFmpeg-devel] [PATCH 1/2] avcodec/error_resilience: Use atomic set on writing error_occurred per slice

2017-11-11 Thread Michael Niedermayer
This is more correct if multiple slices are handled in parallel Signed-off-by: Michael Niedermayer --- libavcodec/error_resilience.c | 4 ++-- libavcodec/error_resilience.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/error_resilience.c b/libavcodec/error_res

[FFmpeg-devel] [PATCH 2/2] avcodec/h264: Move error resilience from slice to main context

2017-11-11 Thread Michael Niedermayer
This should fix some issues with slice threads and ER, it may or may not fix all --- libavcodec/h264_slice.c | 26 ++ libavcodec/h264dec.c| 31 +-- libavcodec/h264dec.h| 2 +- 3 files changed, 24 insertions(+), 35 deletions(-) diff --gi

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/error_resilience: Use atomic set on writing error_occurred per slice

2017-11-11 Thread James Almer
On 11/11/2017 7:16 PM, Michael Niedermayer wrote: > This is more correct if multiple slices are handled in parallel > > Signed-off-by: Michael Niedermayer > --- > libavcodec/error_resilience.c | 4 ++-- > libavcodec/error_resilience.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/error_resilience: Use atomic set on writing error_occurred per slice

2017-11-11 Thread Rostislav Pehlivanov
On 11 November 2017 at 22:31, James Almer wrote: > On 11/11/2017 7:16 PM, Michael Niedermayer wrote: > > This is more correct if multiple slices are handled in parallel > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/error_resilience.c | 4 ++-- > > libavcodec/error_resilience

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/error_resilience: Use atomic set on writing error_occurred per slice

2017-11-11 Thread James Almer
On 11/11/2017 7:49 PM, Rostislav Pehlivanov wrote: > On 11 November 2017 at 22:31, James Almer wrote: > >> On 11/11/2017 7:16 PM, Michael Niedermayer wrote: >>> This is more correct if multiple slices are handled in parallel >>> >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavcodec/erro

[FFmpeg-devel] [PATCH] avcodec: implement vp9 nvdec hwaccel

2017-11-11 Thread Timo Rothenpieler
--- configure | 2 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/nvdec.c | 1 + libavcodec/nvdec_vp9.c | 225 + libavcodec/vp9.c | 11 ++- 6 files changed, 240 insertions(+), 1 deletion(-) c

[FFmpeg-devel] [PATCH] avutil: add API for mb_types

2017-11-11 Thread Michael Niedermayer
This is based on motion_type.h Signed-off-by: Michael Niedermayer --- libavutil/block_type.h | 89 ++ 1 file changed, 89 insertions(+) create mode 100644 libavutil/block_type.h diff --git a/libavutil/block_type.h b/libavutil/block_type.h new file

Re: [FFmpeg-devel] [PATCH] avcodec: implement vp9 nvdec hwaccel

2017-11-11 Thread Timo Rothenpieler
actual push will have update Changelog entry and bump minor version smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/nvdec: correctly set output frame size

2017-11-11 Thread Carl Eugen Hoyos
2017-11-11 17:38 GMT+01:00 Timo Rothenpieler : > @@ -249,8 +249,9 @@ int ff_nvdec_decode_init(AVCodecContext *avctx, unsigned > int dpb_size) > > params.ulWidth = avctx->coded_width; > params.ulHeight= avctx->coded_height; > -params.ulTargetWidth = avct

[FFmpeg-devel] [PATCH] avutil: add API for mb types.

2017-11-11 Thread Michael Niedermayer
This is based on motion_type.h Signed-off-by: Michael Niedermayer --- libavutil/block_type.h | 107 + 1 file changed, 107 insertions(+) create mode 100644 libavutil/block_type.h diff --git a/libavutil/block_type.h b/libavutil/block_type.h new fil

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/nvdec: add support for 12 bit formats

2017-11-11 Thread Carl Eugen Hoyos
2017-11-11 16:21 GMT+01:00 Timo Rothenpieler : > --- > libavcodec/nvdec.c | 18 +++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/nvdec.c b/libavcodec/nvdec.c > index 780c2e67cf..d3620f0d1f 100644 > --- a/libavcodec/nvdec.c > +++ b/libavcodec/nvdec.c

[FFmpeg-devel] [PATCH] avformat/dv: change dv audio format endianess to BE.

2017-11-11 Thread Александр Слободенюк
> Divisions should be avoided in the inner loops as they can be slow done > The commit message should explain this done That's nothing but the engineering issue: dv stores BE audio, and we're removing byteswap to LE. It seems that this change is meaningless, yes it is, furthermore,

Re: [FFmpeg-devel] [PATCH] avutil: add API for mb_types

2017-11-11 Thread Ronald S. Bultje
Hi, On Sat, Nov 11, 2017 at 6:21 PM, Michael Niedermayer wrote: > +/** > + * Width and height of the block. > + */ > +uint8_t w, h; > av1 already has up to 128x128 block sizes, so I'm assuming this won't be enough for av2. Maybe that's Ok, but it's easy to make it (u)int16_t now

Re: [FFmpeg-devel] [PATCH] avformat/img2enc: add frame_pts option for make output filename

2017-11-11 Thread Carl Eugen Hoyos
2017-10-31 8:14 GMT+01:00 Steven Liu : > when use frame_pts option, the output image name can be set > with PTS of current frame. If this fixes ticket #1452, please mention it in the commit message. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ff

Re: [FFmpeg-devel] [PATCH] avutil: add API for mb_types

2017-11-11 Thread Rostislav Pehlivanov
On 12 November 2017 at 01:44, Ronald S. Bultje wrote: > Hi, > > On Sat, Nov 11, 2017 at 6:21 PM, Michael Niedermayer > > wrote: > > > +/** > > + * Width and height of the block. > > + */ > > +uint8_t w, h; > > > > av1 already has up to 128x128 block sizes, so I'm assuming this wo

[FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not write 0 duration for subtitles

2017-11-11 Thread Carl Eugen Hoyos
Hi! Attached patch by John Stebbins fixes a warning with mkvalidator here. Please comment, Carl Eugen From dab79ea5cd01187567b1761aaf1c329926483786 Wed Oct 29 00:00:00 2014 From: John Stebbins Date: Wed, 29 Oct 2014 10:54:44 -0700 Subject: [PATCH] lavf/matroskaenc: Fix writing zero duration subt

[FFmpeg-devel] avcodec/qsvenc Question for Intel QSV low latency

2017-11-11 Thread Natsuki Kai
Hello guys, this is my first posting to ffmpeg-devel, and I believe my mail format is correct. I'm using ffmpeg for encoding video in real-time, so low encode delay is needed. Once I call "avcodec_send_frame(avctx, frame)", I'd like to get the encoded data from "avcodec_receive_packet(avctx, avpk

[FFmpeg-devel] [PATCH] videotoolbox: add frame_params support

2017-11-11 Thread James Almer
From: wm4 Allows decoding with API users which require this API. --- libavcodec/videotoolbox.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c index ecb2502c1f..f0790e7353 100644 --- a/libavcodec/videotoolbox.c +++ b/