Re: [FFmpeg-devel] [PATCH] avformat/hls: release mem resource to fix memleak

On 12/31/2017 5:21 AM, Aman Gupta wrote: > I really don't think it makes any sense in this case, since it is expected > that the av_opt_get will fail on non-http io contexts. It doesn't matter if > the failure is due to AVERROR_OPTION_NOT_FOUND or AVERROR(ENOMEM). The only > thing that matters is w

Re: [FFmpeg-devel] [PATCH v2] avformat/hls: release mem resource to fix memleak

On 12/31/2017 5:50 AM, Aman Gupta wrote: > +int r = av_opt_get(v->input, "http_version", AV_OPT_SEARCH_CHILDREN, > &http_version_opt); > +if (r >= 0) { > +c->http_multiple = strncmp((const char *)http_version_opt, > "1.1", 3) == 0; > +av_freep(&http_version

[FFmpeg-devel] [PATCH v2] avformat/hls: release mem resource to fix memleak

From: Steven Liu fix CID: 1426991 Signed-off-by: Steven Liu Signed-off-by: Aman Gupta --- libavformat/hls.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index d9f7c6de4d..950cc4c3bd 100644 --- a/libavformat/hls.c +++ b/libavf

Re: [FFmpeg-devel] [PATCH] avformat/hls: release mem resource to fix memleak

On Sat, Dec 30, 2017 at 2:14 PM Derek Buitenhuis wrote: > On 12/30/2017 5:50 PM, Aman Gupta wrote: > > There is already a check in place to prevent strncmp from being called > with > > NULL. > > The point before still holds. > > Are people really arguing against consistent use of error checking?

Re: [FFmpeg-devel] [PATCH] avformat/hls: release mem resource to fix memleak

> 在 2017年12月31日，上午6:14，Derek Buitenhuis 写道： > >> On 12/30/2017 5:50 PM, Aman Gupta wrote: >> There is already a check in place to prevent strncmp from being called with >> NULL. > > The point before still holds. > > Are people really arguing against consistent use of error checking? > Incons

Re: [FFmpeg-devel] [PATCH 6/6] avformat: deprecate AVFormatContext filename field

On 12/30/2017 6:16 PM, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > doc/APIchanges | 4 > libavformat/avformat.h | 5 + > libavformat/mux.c | 10 ++ > libavformat/utils.c| 8 > libavformat/version.h | 5 - > 5 files changed, 31 in

Re: [FFmpeg-devel] [PATCH 1/6] avformat: add url field to AVFormatContext

On 12/30/2017 9:16 PM, Marton Balint wrote: > + * - muxing: may be set by the caller before avformat_write_header() (or > + * avformat_init_output() if that is called first). Set to an > + * empty string if it was NULL in avformat_init_output(). For the muxing case,

Re: [FFmpeg-devel] [PATCH] avformat/hls: release mem resource to fix memleak

On 12/30/2017 5:50 PM, Aman Gupta wrote: > There is already a check in place to prevent strncmp from being called with > NULL. The point before still holds. Are people really arguing against consistent use of error checking? Inconsistent standards of error checking are how bugs and security issue

Re: [FFmpeg-devel] [PATCH] tcp: properly return EOF

On 12/30/2017 8:44 AM, wm4 wrote: There is no POSIX error code for EOF - recv() signals EOF by simply returning 0. But libavformat recently changed its conventionts and "conventionts" -> "conventions" requires an explicit AVERROR_EOF, or it might get into an endless retry loop, consuming 100%

[FFmpeg-devel] [PATCH 6/6] avformat: deprecate AVFormatContext filename field

Signed-off-by: Marton Balint --- doc/APIchanges | 4 libavformat/avformat.h | 5 + libavformat/mux.c | 10 ++ libavformat/utils.c| 8 libavformat/version.h | 5 - 5 files changed, 31 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/do

[FFmpeg-devel] [PATCH 4/6] avformat/hls: migrate to AVFormatContext->url

Signed-off-by: Marton Balint --- libavformat/hls.c| 4 +- libavformat/hlsenc.c | 230 +-- 2 files changed, 116 insertions(+), 118 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index dccc7c7dd2..865278e6f0 100644 --- a/libavf

[FFmpeg-devel] [PATCH 3/6] avdevice: migrate to AVFormatContext->url

Signed-off-by: Marton Balint --- libavdevice/alsa.c | 4 ++-- libavdevice/avfoundation.m | 2 +- libavdevice/bktr.c | 2 +- libavdevice/caca.c | 2 +- libavdevice/decklink_common.cpp | 2 +- libavdevice/decklink_dec.cpp| 4 ++-- libavdevice/de

[FFmpeg-devel] [PATCH 5/6] avformat: migrate to AVFormatContext->url

Signed-off-by: Marton Balint --- libavformat/concatdec.c | 4 ++-- libavformat/dashenc.c| 16 libavformat/fifo.c | 8 libavformat/flvenc.c | 4 ++-- libavformat/gxfenc.c | 4 ++-- libavformat/hdsenc.c

[FFmpeg-devel] [PATCH 2/6] fftools, tools, examples: migrate to AVFormatContext->url

Signed-off-by: Marton Balint --- doc/examples/transcode_aac.c | 7 +-- fftools/ffmpeg.c | 16 fftools/ffmpeg_opt.c | 8 fftools/ffplay.c | 6 +++--- fftools/ffprobe.c| 2 +- tools/uncoded_frame.c| 2 +- 6 files

[FFmpeg-devel] [PATCH 1/6] avformat: add url field to AVFormatContext

This will replace the 1024 character limited filename field. Compatiblity for output contexts are provided by copying filename field to URL if URL is unset and by providing an internal function for muxers to set both url and filename at once. Signed-off-by: Marton Balint --- doc/APIchanges

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_framerate: calculate interpolation as integer

On Mon, 25 Dec 2017, Michael Niedermayer wrote: On Sat, Dec 23, 2017 at 11:17:38PM +0100, Marton Balint wrote: It was truncated to int later on anyway. Fate test changes are due to rounding instead of truncation. Signed-off-by: Marton Balint --- libavfilter/vf_framerate.c |

Re: [FFmpeg-devel] Global options to compile FFmpeg with only audio-related features

Hi Ronald, Checking AVMEDIA_TYPE seems to be the best way to split audio and video codecs. But what is the best way to exclude demuxers and parsers which have no sense for audio (because they are intended to be used only with video/image without audio for example)? Thanks! -Message d'orig

Re: [FFmpeg-devel] [PATCH] avcodec/exr: Check buf_size more completely

On Fri, Dec 29, 2017 at 03:00:19AM +0100, Michael Niedermayer wrote: > Fixes: Out of heap array read > Fixes: 4683/clusterfuzz-testcase-minimized-6152313673613312 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Nie

Re: [FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

> > >> > > >> This broke several interlace fate tests, including the new checkasm > one > > >> you added. > > >> > > New patch in attach for AVX2 version i add a process of only 1* mmsize, before the loop (who process 2 * mmsize at each loop) Pass

Re: [FFmpeg-devel] h264: fix RTSP stream decoding

On Sat, Dec 30, 2017 at 12:48:19AM +0300, ser...@gavrushkin.com wrote: > > Please add "Fixes ticket #6422" to the commit message. > > > > And maybe remove "rtsp" from the commit title, the issue > > is reproducible with files. > > Done. > > Please feel free to edit commit title/message as you wi

[FFmpeg-devel] [PATCH] avfilter: add entropy filter

Signed-off-by: Paul B Mahol --- doc/filters.texi | 4 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_entropy.c | 206 +++ 4 files changed, 212 insertions(+) create mode 100644 libavfilter/vf_entropy.c di

Re: [FFmpeg-devel] [PATCH 1/2] avformat/http: return EINVAL if ff_http_do_new_request is called with non-http URLContext

On Sat, Dec 30, 2017 at 10:11 AM wm4 wrote: > On Fri, 29 Dec 2017 15:41:57 -0800 > Aman Gupta wrote: > > > From: Aman Gupta > > > > Signed-off-by: Aman Gupta > > --- > > libavformat/http.c | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/libavformat/http.c b/libavformat/htt

Re: [FFmpeg-devel] [PATCH 1/2] avformat/http: return EINVAL if ff_http_do_new_request is called with non-http URLContext

On Fri, 29 Dec 2017 15:41:57 -0800 Aman Gupta wrote: > From: Aman Gupta > > Signed-off-by: Aman Gupta > --- > libavformat/http.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavformat/http.c b/libavformat/http.c > index a376f1a488..8f7e56de54 100644 > --- a/libavformat/htt

Re: [FFmpeg-devel] [PATCH 1/2] avformat/http: return EINVAL if ff_http_do_new_request is called with non-http URLContext

2017-12-30 0:41 GMT+01:00 Aman Gupta : > +if (!h->prot || > +!(!strcmp(h->prot->name, "http") || > + !strcmp(h->prot->name, "https"))) Can't this be simplified? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http:

Re: [FFmpeg-devel] [PATCH] avformat/hls: release mem resource to fix memleak

On Sat, Dec 30, 2017 at 8:34 AM Derek Buitenhuis wrote: > On 12/30/2017 4:31 PM, Nicolas George wrote: > > Does it really matter? If av_opt_get() fails for any reason, > > http_multiple will just be false, which would let the processing > > continue, only in a slightly degraded manner that was th

Re: [FFmpeg-devel] [PATCH v4] lavr: deprecate the entire library

On Sat, 30 Dec 2017 17:21:46 + Derek Buitenhuis wrote: > On 12/30/2017 5:11 PM, Ronald S. Bultje wrote: > > I'm in favour of deprecating and eventually removing it. As Mike used to > > say: you need to break eggs to make omelettes. > > I'm in favour simply because I don't know of a good re

Re: [FFmpeg-devel] [PATCH] http: block while waiting for reconnecting

Am 30.12.2017 um 18:07 schrieb wm4: It makes no sense to return an error after the first reconnect, and then somehow resume the next time it's called. Also make the wait reasonably interruptible. Since there is no mechanism for this in the API, polling is the best we can do. (Some effort could b

Re: [FFmpeg-devel] Global options to compile FFmpeg with only audio-related features

Hi Derek, I would have already sent one if I could... But I do not know enough bash to code one. I was hoping that a developer could either write one, or at least give directions to do so if my feature request makes sense. Cyber Sinh -Message d'origine- De : ffmpeg-devel [mailto:ffmpeg

Re: [FFmpeg-devel] [PATCH v4] lavr: deprecate the entire library

On 12/30/2017 5:11 PM, Ronald S. Bultje wrote: > I'm in favour of deprecating and eventually removing it. As Mike used to > say: you need to break eggs to make omelettes. I'm in favour simply because I don't know of a good reason to *not* deprecate it? Does it have ASM, modes, APIs, etc. that swre

Re: [FFmpeg-devel] [PATCH v4] lavr: deprecate the entire library

Hi, On Sat, Dec 30, 2017 at 10:45 AM, Rostislav Pehlivanov wrote: > On 30 December 2017 at 15:15, wm4 wrote: > > > On Sat, 30 Dec 2017 14:59:19 + > > Rostislav Pehlivanov wrote: > > > > > Deprecate the entire library. Merged years ago to provide compatibility > > > with Libav, it remained

Re: [FFmpeg-devel] [PATCH] tcp: properly return EOF

Hi, On Sat, Dec 30, 2017 at 11:44 AM, wm4 wrote: > There is no POSIX error code for EOF - recv() signals EOF by simply > returning 0. But libavformat recently changed its conventionts and > requires an explicit AVERROR_EOF, or it might get into an endless retry > loop, consuming 100% CPU while d

Re: [FFmpeg-devel] Global options to compile FFmpeg with only audio-related features

Hi, On Sat, Dec 30, 2017 at 11:28 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 12/30/2017 4:00 PM, Cyber Sinh wrote: > > What do you think? > > That patches are welcome :). Just to be clear: I'm not OK with a list of audio or video thingies in configure. Similar to the scrapin

Re: [FFmpeg-devel] [PATCH] avcodec/utvideodec: add support for UMH2, UMY2, UMH4, UMY4, UMRA, UMRG

On 12/30/17, Derek Buitenhuis wrote: > On 12/30/2017 3:10 PM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/utvideo.h| 8 +- >> libavcodec/utvideodec.c | 194 >> ++-- >> libavformat/riff.c | 6 ++ >> 3 files chang

[FFmpeg-devel] [PATCH] avcodec/utvideodec: add support for UMH2, UMY2, UMH4, UMY4, UMRA, UMRG

These are new modes which are supposed to be more SIMD friendly. Signed-off-by: Paul B Mahol --- libavcodec/utvideo.h| 8 +- libavcodec/utvideodec.c | 199 +++- libavformat/riff.c | 6 ++ 3 files changed, 174 insertions(+), 39 deletions(-)

Re: [FFmpeg-devel] [PATCH][RFC]lavu/mem: Do not realloc in av_fast_alloc() if size == min_size

On 12/30/2017 5:02 PM, Carl Eugen Hoyos wrote: > I just confirmed the ("arbitrary") limit defaults to INT_MAX which at least > on some systems is 2G as claimed above. Right, but this is system-dependent, and not specific to FFmpeg, which was what I meant. I digress though, this is off-topic from t

[FFmpeg-devel] [PATCH] http: block while waiting for reconnecting

It makes no sense to return an error after the first reconnect, and then somehow resume the next time it's called. Also make the wait reasonably interruptible. Since there is no mechanism for this in the API, polling is the best we can do. (Some effort could be put into making the wait more accura

Re: [FFmpeg-devel] [PATCH][RFC]lavu/mem: Do not realloc in av_fast_alloc() if size == min_size

2017-12-30 17:24 GMT+01:00 Derek Buitenhuis : > On 12/30/2017 1:44 PM, Carl Eugen Hoyos wrote: >> FFmpeg has an arbitrary allocation limit (2G iirc), av_fast_realloc() >> increases the allocation even if the requested is equal the already >> allocated size. I believe this can lead to unnecessary OO

[FFmpeg-devel] [PATCH] tcp: properly return EOF

There is no POSIX error code for EOF - recv() signals EOF by simply returning 0. But libavformat recently changed its conventionts and requires an explicit AVERROR_EOF, or it might get into an endless retry loop, consuming 100% CPU while doing nothing. --- libavformat/tcp.c | 2 ++ 1 file changed,

Re: [FFmpeg-devel] [PATCH] avcodec/utvideodec: add support for UMH2, UMY2, UMH4, UMY4, UMRA, UMRG

On 12/30/2017 3:10 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/utvideo.h| 8 +- > libavcodec/utvideodec.c | 194 > ++-- > libavformat/riff.c | 6 ++ > 3 files changed, 169 insertions(+), 39 deletions(-) Can yo

Re: [FFmpeg-devel] [PATCH] avformat/hls: release mem resource to fix memleak

On 12/30/2017 4:31 PM, Nicolas George wrote: > Does it really matter? If av_opt_get() fails for any reason, > http_multiple will just be false, which would let the processing > continue, only in a slightly degraded manner that was the norm a few > months ago. I contend that checking errors should

Re: [FFmpeg-devel] [PATCH] avformat/hls: release mem resource to fix memleak

Derek Buitenhuis (2017-12-30): > On 12/30/2017 12:42 PM, Steven Liu wrote: > > av_opt_get(v->input, "http_version", AV_OPT_SEARCH_CHILDREN, > > &http_version_opt); > > c->http_multiple = http_version_opt && strncmp((const char > > *)http_version_opt, "1.1", 3) == 0; > > +

Re: [FFmpeg-devel] Global options to compile FFmpeg with only audio-related features

On 12/30/2017 4:00 PM, Cyber Sinh wrote: > What do you think? That patches are welcome :). - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/hls: release mem resource to fix memleak

On 12/30/2017 12:42 PM, Steven Liu wrote: > av_opt_get(v->input, "http_version", AV_OPT_SEARCH_CHILDREN, > &http_version_opt); > c->http_multiple = http_version_opt && strncmp((const char > *)http_version_opt, "1.1", 3) == 0; > +av_free(http_version_opt); Looks OK, but

Re: [FFmpeg-devel] [PATCH][RFC]lavu/mem: Do not realloc in av_fast_alloc() if size == min_size

On 12/30/2017 1:44 PM, Carl Eugen Hoyos wrote: > FFmpeg has an arbitrary allocation limit (2G iirc), av_fast_realloc() > increases the allocation even if the requested is equal the already > allocated size. I believe this can lead to unnecessary OOM (no > testcase) if the requested (and already all

[FFmpeg-devel] Global options to compile FFmpeg with only audio-related features

Hi, I use FFmpeg in an audio-oriented software (for playing and acoustic fingerprinting). So, I want to compile FFmpeg with only: - audio-oriented features to reduce the size (and compilation time) of the lib (eg. bypass video codecs). A feature should be considered as audio-related if

Re: [FFmpeg-devel] [PATCH v4] lavr: deprecate the entire library

On 30 December 2017 at 15:15, wm4 wrote: > On Sat, 30 Dec 2017 14:59:19 + > Rostislav Pehlivanov wrote: > > > Deprecate the entire library. Merged years ago to provide compatibility > > with Libav, it remained unmaintained by the FFmpeg project and duplicated > > functionality provided by li

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

2017年12月30日 下午7:30，"Nicolas George" 写道： Wu Zhiqiang (2017-12-30): > The command to generate sample video: > > ffmpeg -f lavfi -i testsrc=duration=120 -c:v h264 -profile:v high -level:v > 10 -pix_fmt yuv420p -r 30 -g 30 -c:a aac test.flv > echo -e "file test.flv\nduration 120" > playlist > ffplay

[FFmpeg-devel] [PATCH] avcodec/utvideodec: add support for UMH2, UMY2, UMH4, UMY4, UMRA, UMRG

Signed-off-by: Paul B Mahol --- libavcodec/utvideo.h| 8 +- libavcodec/utvideodec.c | 194 ++-- libavformat/riff.c | 6 ++ 3 files changed, 169 insertions(+), 39 deletions(-) diff --git a/libavcodec/utvideo.h b/libavcodec/utvideo.h index a

Re: [FFmpeg-devel] [PATCH v4] lavr: deprecate the entire library

On Sat, 30 Dec 2017 14:59:19 + Rostislav Pehlivanov wrote: > Deprecate the entire library. Merged years ago to provide compatibility > with Libav, it remained unmaintained by the FFmpeg project and duplicated > functionality provided by libswresample. > > In order to improve consistency and

[FFmpeg-devel] [PATCH v4] lavr: deprecate the entire library

Deprecate the entire library. Merged years ago to provide compatibility with Libav, it remained unmaintained by the FFmpeg project and duplicated functionality provided by libswresample. In order to improve consistency and reduce attack surface, as well as to ease burden on maintainers, it has bee

[FFmpeg-devel] [PATCH][RFC]lavu/mem: Do not realloc in av_fast_alloc() if size == min_size

Hi! FFmpeg has an arbitrary allocation limit (2G iirc), av_fast_realloc() increases the allocation even if the requested is equal the already allocated size. I believe this can lead to unnecessary OOM (no testcase) if the requested (and already allocated) size is close to our limit. Additionally,

Re: [FFmpeg-devel] [PATCH]lavf/mov: Do not blindly allocate stts entries

2017-12-29 23:37 GMT+01:00 Carl Eugen Hoyos : > 2017-11-28 21:32 GMT+01:00 Michael Niedermayer : >> On Mon, Nov 27, 2017 at 05:24:14AM +0100, Carl Eugen Hoyos wrote: > >>> for (i = 0; i < entries && !pb->eof_reached; i++) { >>> -int sample_duration; >>> +int sample_duration, re

[FFmpeg-devel] [PATCH] avformat/hls: release mem resource to fix memleak

fix CID: 1426991 Signed-off-by: Steven Liu --- libavformat/hls.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/hls.c b/libavformat/hls.c index dccc7c7dd2..9918d1af74 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1475,6 +1475,7 @@ reload: uint8_t *http_vers

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

Wu Zhiqiang (2017-12-30): > The command to generate sample video: > > ffmpeg -f lavfi -i testsrc=duration=120 -c:v h264 -profile:v high -level:v > 10 -pix_fmt yuv420p -r 30 -g 30 -c:a aac test.flv > echo -e "file test.flv\nduration 120" > playlist > ffplay -f concat playlist -ss 90 -max_ts_probe

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: use AVIOContext new_http_request callback

On Sat, 30 Dec 2017 11:53:14 +0100 Nicolas George wrote: > Aman Gupta (2017-12-29): > > It also makes it easier in the future to add http keepalive support to > > other consumers like the dash demuxer and the crypto protocol. > > For that, the API does not need to be public, it just need to be

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: use AVIOContext new_http_request callback

Aman Gupta (2017-12-29): > It also makes it easier in the future to add http keepalive support to > other consumers like the dash demuxer and the crypto protocol. For that, the API does not need to be public, it just need to be clean. I thought you were referring to using the hls demuxer with oth

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: use AVIOContext new_http_request callback

On Fri, 29 Dec 2017 23:45:10 +0100 Nicolas George wrote: > Aman Gupta (2017-12-29): > > From: Aman Gupta > > > > This fixes a segfault when streaming from an HLS playlist which uses > > crypto, by ensuring ff_http_do_new_request will never be invoked on a > > non-http URLContext. > > > > Addit

Re: [FFmpeg-devel] [PATCH 8/8] decklink: Add support for compressed AC-3 output over SDI

On 12/29/2017 10:12 AM, Devin Heitmueller wrote: Extend the decklink output to include support for compressed AC-3, encapsulated using the SMPTE ST 377:2015 standard. This functionality can be exercised by using the "copy" codec when the input audio stream is AC-3. For example: ./ffmpeg -i ~/f

Re: [FFmpeg-devel] [PATCH 7/8] decklink: Add support for SCTE-104 to decklink capture

On 12/29/2017 10:12 AM, Devin Heitmueller wrote: Make use of libklvanc to parse SCTE-104 packets and announce them as a new stream. Right now we just pass the payload straight through, but once this is hoooked into libklscte35 we'll be able "hoooked" -> "hooked" to generate SCTE-35 messages