[FFmpeg-devel] [PATCH] fate: add aac id3v2 demux test

2018-02-03 Thread rshaffer
From: Richard Shaffer A basic test for demuxing raw AAC (ADTS) with ID3v2 tags. --- This is related to the patch 'libavformat/aac: Parse ID3 tags between ADTS frames', and will fail without it. The test file contains an ID3 tag at the beginning as well as a second tag between frames. While the te

Re: [FFmpeg-devel] [PATCH] fate: add aac id3v2 demux test

2018-02-03 Thread Richard Shaffer
Attaching sample file for the test. -Richard On Sat, Feb 3, 2018 at 11:24 PM, wrote: > From: Richard Shaffer > > A basic test for demuxing raw AAC (ADTS) with ID3v2 tags. > --- > This is related to the patch 'libavformat/aac: Parse ID3 tags between ADTS > frames', and will fail without it. The

[FFmpeg-devel] FriBidi Version 1.0.0 is released; any changes needed to ffmpeg ?

2018-02-03 Thread walshdcw
I noticed that FriBidi Version 1.0.0 is released on git https://github.com/fribidi/fribidi/releases and has a new api. I wonder, does that mean ffmpeg needs any changes to match it ? "Version 1.0.0 of FriBidi is a major update that adds support for all the changes to the Unicode Bidirectional

[FFmpeg-devel] [PATCH] avcodec/pafvideo: Check allocated frame size

2018-02-03 Thread Michael Niedermayer
Fixes: OOM Fixes: 5549/clusterfuzz-testcase-minimized-5390553567985664 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/pafvideo.c | 4 1 file changed, 4 insertions(+) diff --git a/libavco

Re: [FFmpeg-devel] [PATCH] avcodec/me_cmp: remove ff_me_cmp_init_static()

2018-02-03 Thread James Almer
On 2/3/2018 7:51 PM, Muhammad Faiz wrote: > Precalculate and constify ff_square_tab. > > Signed-off-by: Muhammad Faiz > --- > libavcodec/me_cmp.c | 51 > +--- > libavcodec/me_cmp.h | 4 +--- > libavcodec/mpegvideo_enc.c | 2 +- > lib

Re: [FFmpeg-devel] [PATCH] avfilter/af_loudnorm: correctly initialize PTS

2018-02-03 Thread Muhammad Faiz
On Sat, Feb 3, 2018 at 9:22 PM, Niklas Haas wrote: > From: Niklas Haas > > Right now, the PTS always starts out as 0, which causes problems on a > seek or when inserting this filter mid-stream. > > Initialize it instead to AV_NOPTS_VALUE and copy the PTS from the first > frame instead if this is

Re: [FFmpeg-devel] [PATCH] avcodec: do not use init_static_data on some codecs

2018-02-03 Thread Muhammad Faiz
On Sat, Feb 3, 2018 at 9:29 AM, Michael Niedermayer wrote: > On Sat, Feb 03, 2018 at 01:36:37AM +0700, Muhammad Faiz wrote: >> They don't modify AVCodec, no needs to call it at register. They will be >> wasteful if these codecs are unused. Instead, call static data initialization >> at codecs' ini

Re: [FFmpeg-devel] [PATCH v4 7/7] lavc/bsf: make BSF iteration the same as other iterators

2018-02-03 Thread Muhammad Faiz
On Sat, Feb 3, 2018 at 5:39 PM, wm4 wrote: > On Fri, 2 Feb 2018 19:44:18 + > Josh de Kock wrote: > >> --- >> fftools/cmdutils.c | 2 +- >> libavcodec/avcodec.h | 6 +- >> libavcodec/bitstream_filter.c | 4 ++-- >> libavcodec/bitstream_filters.c | 29 +++

[FFmpeg-devel] [PATCH] avcodec/me_cmp: remove ff_me_cmp_init_static()

2018-02-03 Thread Muhammad Faiz
Precalculate and constify ff_square_tab. Signed-off-by: Muhammad Faiz --- libavcodec/me_cmp.c | 51 +--- libavcodec/me_cmp.h | 4 +--- libavcodec/mpegvideo_enc.c | 2 +- libavcodec/mpegvideoencdsp.c | 2 +- libavcodec/snowenc.c

[FFmpeg-devel] [PATCH] avfilter/af_loudnorm: correctly initialize PTS

2018-02-03 Thread Niklas Haas
From: Niklas Haas Right now, the PTS always starts out as 0, which causes problems on a seek or when inserting this filter mid-stream. Initialize it instead to AV_NOPTS_VALUE and copy the PTS from the first frame instead if this is the case. --- libavfilter/af_loudnorm.c | 5 - 1 file chang

Re: [FFmpeg-devel] [Cellar] [PATCH] avcodec/ffv1: Support for RGBA64 and GBRAP16

2018-02-03 Thread Jean-Christophe Kummer
Loooking to it from a pragmatic management point of view, there is a lot of open source unfriendly community from the EBU/SMPTE world which would have their opinion about a failed or even more delayed IETF spec finalisation. I think - given the efforts which have been put into it, the beauty wit

[FFmpeg-devel] [PATCH] avformat/mov: Move +1 in check to avoid hypothetical overflow in add_ctts_entry()

2018-02-03 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d16b431e03..a9b9ec025f 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -3233,7 +3233,7 @@ static int64_t add_ctts_entr

Re: [FFmpeg-devel] Fix ctts_index calculation

2018-02-03 Thread Michael Niedermayer
On Fri, Feb 02, 2018 at 05:55:38PM -0800, Xiaohan Wang (王消寒) wrote: > > mov.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > 87157b4053de0e044e78db72ef13e8058075c235 > 0001-Fix-ctts_index-calculation.patch > From bb376fd2de5da5f9ecdef41621a579252b899d7d Mon Sep 17 00:00:00 2001 >

Re: [FFmpeg-devel] Abort early on decode_slice error

2018-02-03 Thread Michael Niedermayer
On Sat, Feb 03, 2018 at 02:29:00AM -0800, Xiaohan Wang (王消寒) wrote: > > h264_slice.c | 17 - > 1 file changed, 16 insertions(+), 1 deletion(-) > 7fc1e8d4e0df4223089d2466c5a76b12a9171003 > 0001-ffmpeg-Abort-early-on-decode_slice-error.patch > From 971866f88bba20d7e2a993b1125bd

Re: [FFmpeg-devel] [PATCH] libavformat/hls: Support metadata updates from subdemuxers

2018-02-03 Thread Richard Shaffer
On Saturday, February 3, 2018, wm4 wrote: > On Fri, 2 Feb 2018 12:59:45 -0800 > rshaf...@tunein.com wrote: > > > From: Richard Shaffer > > > > If a subdemuxer has the updated metadata event flag set, the metadata is > copied > > to the corresponding stream. The flag is cleared on the subdemuxer

Re: [FFmpeg-devel] [PATCH] Fix crash in join filter

2018-02-03 Thread Michael Niedermayer
On Sat, Feb 03, 2018 at 10:13:28AM +0100, Paul B Mahol wrote: > On 2/3/18, Nikolas Bowe wrote: > > Previously if ff_outlink_frame_wanted() returned 0 it could dereference a > > null pointer when trying to read nb_samples. > > --- > > libavfilter/af_join.c | 3 +++ > > 1 file changed, 3 insertions

Re: [FFmpeg-devel] [PATCH] avcodec/utvideodec: Fix bytes left check in decode_frame()

2018-02-03 Thread Michael Niedermayer
On Sat, Feb 03, 2018 at 10:16:07AM +0100, Paul B Mahol wrote: > On 2/2/18, Michael Niedermayer wrote: > > Fixes: out of array read > > Fixes: poc-2017.avi > > > > Found-by: GwanYeong Kim > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/utvideodec.c | 2 +- > > 1 file changed, 1 ins

[FFmpeg-devel] [PATCH] avcodec/scpr: Fix reading a pixel before the first

2018-02-03 Thread Michael Niedermayer
Fixes: 5540/clusterfuzz-testcase-minimized-6122458273808384 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/scpr.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/scpr.c b/li

Re: [FFmpeg-devel] [PATCH] avcodec/wavpack: Fix integer overflow in FFABS

2018-02-03 Thread Michael Niedermayer
On Wed, Jan 31, 2018 at 03:17:36AM +0100, Michael Niedermayer wrote: > Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to > an unsigned type to negate this value to itself > Fixes: 5396/clusterfuzz-testcase-minimized-655829281536 > > Found-by: continuous fuzzing proce

Re: [FFmpeg-devel] [Cellar] [PATCH] avcodec/ffv1: Support for RGBA64 and GBRAP16

2018-02-03 Thread Michael Niedermayer
On Sat, Feb 03, 2018 at 01:58:10PM +0100, Reto Kromer wrote: > Michael Niedermayer wrote: > > >To clarify my suggestion, > >the algorithm should be tuned for high bit depth before using > >it for long term storage. This would be v4 (or later). > >Personally i would wait for v4 and not use v3 for h

Re: [FFmpeg-devel] [Cellar] [PATCH] avcodec/ffv1: Support for RGBA64 and GBRAP16

2018-02-03 Thread Reto Kromer
Michael Niedermayer wrote: >To clarify my suggestion, >the algorithm should be tuned for high bit depth before using >it for long term storage. This would be v4 (or later). >Personally i would wait for v4 and not use v3 for high bit >depth. Which is why i think its not smart to extend the v3 >impl

Re: [FFmpeg-devel] [Cellar] [PATCH] avcodec/ffv1: Support for RGBA64 and GBRAP16

2018-02-03 Thread Michael Niedermayer
On Sat, Feb 03, 2018 at 10:57:44AM +0100, Jerome Martinez wrote: > On 03/02/2018 00:10, Michael Niedermayer wrote: > >On Thu, Feb 01, 2018 at 01:43:00PM +0100, Jerome Martinez wrote: > >>Add support for 16-bit/component RGB with Alpha encoding and decoding in > >>FFV1, both RGBA64 and GBRAP16 for e

Re: [FFmpeg-devel] [PATCH v4 7/7] lavc/bsf: make BSF iteration the same as other iterators

2018-02-03 Thread wm4
On Fri, 2 Feb 2018 19:44:18 + Josh de Kock wrote: > --- > fftools/cmdutils.c | 2 +- > libavcodec/avcodec.h | 6 +- > libavcodec/bitstream_filter.c | 4 ++-- > libavcodec/bitstream_filters.c | 29 ++--- > 4 files changed, 26 insertions(+

Re: [FFmpeg-devel] [PATCH] Fix crash in join filter

2018-02-03 Thread Paul B Mahol
On 2/3/18, Nikolas Bowe wrote: > Previously if ff_outlink_frame_wanted() returned 0 it could dereference a > null pointer when trying to read nb_samples. > --- > libavfilter/af_join.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavfilter/af_join.c b/libavfilter/af_join.c > index

Re: [FFmpeg-devel] [PATCH] avcodec: do not use init_static_data on some codecs

2018-02-03 Thread wm4
On Sat, 3 Feb 2018 03:29:40 +0100 Michael Niedermayer wrote: > On Sat, Feb 03, 2018 at 01:36:37AM +0700, Muhammad Faiz wrote: > > They don't modify AVCodec, no needs to call it at register. They will be > > wasteful if these codecs are unused. Instead, call static data > > initialization > > at

Re: [FFmpeg-devel] [PATCH] libavformat/hls: Support metadata updates from subdemuxers

2018-02-03 Thread wm4
On Fri, 2 Feb 2018 12:59:45 -0800 rshaf...@tunein.com wrote: > From: Richard Shaffer > > If a subdemuxer has the updated metadata event flag set, the metadata is > copied > to the corresponding stream. The flag is cleared on the subdemuxer and the > appropriate event flag is set on the stream.

[FFmpeg-devel] Abort early on decode_slice error

2018-02-03 Thread 王消寒
0001-ffmpeg-Abort-early-on-decode_slice-error.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1: Support for RGBA64 and GBRAP16

2018-02-03 Thread Jerome Martinez
On 03/02/2018 00:10, Michael Niedermayer wrote: On Thu, Feb 01, 2018 at 01:43:00PM +0100, Jerome Martinez wrote: Add support for 16-bit/component RGB with Alpha encoding and decoding in FFV1, both RGBA64 and GBRAP16 for encoding, GBRAP16 for decoding. Resulting bitstream was tested about lossle

Re: [FFmpeg-devel] [PATCH] avcodec/utvideodec: Fix bytes left check in decode_frame()

2018-02-03 Thread Paul B Mahol
On 2/2/18, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: poc-2017.avi > > Found-by: GwanYeong Kim > Signed-off-by: Michael Niedermayer > --- > libavcodec/utvideodec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/utvideodec.c b/libavcodec/u

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1: Support for RGBA64 and GBRAP16

2018-02-03 Thread Reto Kromer
Michael Niedermayer wrote: >I would prefer if the algorithm would be tuned to 16bit data >before adding more formats to the encoder which require all >decoders to support them. > >Dont you agree that this would be the better strategy ? To my understanding FFV1 v3 is actually stable. Or am I missi