Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB and RGBA 12-bit packed decoding

2018-02-08 Thread Jerome Martinez
On 09/02/2018 02:19, Carl Eugen Hoyos wrote: 2018-02-08 11:28 GMT+01:00 Jerome Martinez : Currently RGB and RGBA 12-bit are supported by DPX decoder only if component values are padded (packing "Filled to 32-bit words, method A"). This patch adds decoding of RGB and RGBA 12-bit with no padding (

[FFmpeg-devel] [PATCH] avcodec/vp3: Check eob_run

2018-02-08 Thread Michael Niedermayer
Fixes: out of array access Fixes: 5919/clusterfuzz-testcase-minimized-5859311382167552 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vp3.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH] dashdec: Support SegmentTimeline inside Period

2018-02-08 Thread Steven Liu
>> 在 2018年2月7日,上午5:30,Stefan _ 写道: >> >> >> <0001-dashdec-Support-SegmentTimeline-inside-Period.patch> > LGTM Pushed Thanks Steven ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-08 Thread Nekopanda
> From: Carl Eugen Hoyos > > 2018-02-09 3:07 GMT+01:00 Nekopanda > : >>> How did you find this bug ? >>> >>> do you have a testcase / file which shows artifacts without this change > ? >> >> Yes, I have files that show artifacts without this change. Recently, >> Japanese satellite televi

Re: [FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-08 Thread Carl Eugen Hoyos
2018-02-09 3:07 GMT+01:00 Nekopanda : >> How did you find this bug ? >> >> do you have a testcase / file which shows artifacts without this change ? > > Yes, I have files that show artifacts without this change. Recently, > Japanese satellite television started to use field pictures widely, > and m

Re: [FFmpeg-devel] [PATCH] avcodec/codec_desc: sort codec_descriptors

2018-02-08 Thread Michael Niedermayer
On Sat, Feb 03, 2018 at 01:35:34AM +0700, Muhammad Faiz wrote: > Use bsearch on avcodec_descriptor_get(). > > Signed-off-by: Muhammad Faiz > --- > libavcodec/codec_desc.c | 1103 > --- > 1 file changed, 563 insertions(+), 540 deletions(-) probably ok

Re: [FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-08 Thread Nekopanda
> How did you find this bug ? >  > do you have a testcase / file which shows artifacts without this change ? Yes, I have files that show artifacts without this change. Recently, Japanese satellite television started to use field pictures widely, and many of that show artifacts. We need this chan

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-02-08 Thread Michael Niedermayer
On Tue, Jan 30, 2018 at 04:11:03PM -0500, Nablet Developer wrote: > protocol requires libsrt (https://github.com/Haivision/srt) to be > installed > > Signed-off-by: Nablet Developer > --- > MAINTAINERS | 1 + > configure | 9 + > doc/protocols.texi | 116 ++

Re: [FFmpeg-devel] [PATCH] examples: Don't call deprecated functions which don't do anything

2018-02-08 Thread James Almer
On 2/8/2018 10:41 PM, Jun Zhao wrote: > > > On 2018/2/8 3:44, Mark Thompson wrote: >> --- >> doc/examples/avio_dir_cmd.c | 2 -- >> doc/examples/avio_reading.c | 3 --- >> doc/examples/decode_audio.c | 3 --- >> doc/examples/decode_video.c | 2 -- >> doc/examples/demuxing_dec

Re: [FFmpeg-devel] [PATCH] examples: Don't call deprecated functions which don't do anything

2018-02-08 Thread Jun Zhao
On 2018/2/8 3:44, Mark Thompson wrote: > --- > doc/examples/avio_dir_cmd.c | 2 -- > doc/examples/avio_reading.c | 3 --- > doc/examples/decode_audio.c | 3 --- > doc/examples/decode_video.c | 2 -- > doc/examples/demuxing_decoding.c | 3 --- > doc/examples/encode_audio.c

Re: [FFmpeg-devel] [FFmpeng-devel] Dose ffmpeg plan to support FMO decode in h264

2018-02-08 Thread Wei Gao
2018-02-08 6:59 GMT+08:00 Michael Niedermayer : > On Wed, Feb 07, 2018 at 02:15:26PM +0800, Wei Gao wrote: > > 2018-02-07 6:57 GMT+08:00 Michael Niedermayer : > > > > > On Tue, Feb 06, 2018 at 11:14:49AM +0800, Wei Gao wrote: > > > > Hi > > > > > > > > I have a question. > > > > > > > > Does ffmpe

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB and RGBA 12-bit packed decoding

2018-02-08 Thread Carl Eugen Hoyos
2018-02-08 11:28 GMT+01:00 Jerome Martinez : > Currently RGB and RGBA 12-bit are supported by DPX decoder only if component > values are padded (packing "Filled to 32-bit words, method A"). > This patch adds decoding of RGB > and RGBA 12-bit with no padding (packing "Packed into 32-bit words"). I

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: add support for low-power encoding

2018-02-08 Thread Xiang, Haihao
> On 06/02/18 08:17, Haihao Xiang wrote: > > Although VAEntrypointEncSliceLP was added in old version of VAAPI, we > > never implemented it for VAAPI H265 encoder before. so it is reasonable > > to require VAAPI 1.0 > > > > Signed-off-by: Haihao Xiang > > --- > > libavcodec/vaapi_encode_h265.c

Re: [FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-08 Thread Michael Niedermayer
On Fri, Feb 09, 2018 at 02:03:24AM +0900, Nekopanda wrote: > - Fix field selection for skipped macroblocks > > For B field pictures, the spec says, > > > The prediction shall be made from the field of the same parity as the field > > being predicted. > > I did it. > > - Fix motion vector round

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/huffyuvdec: Check input buffer size

2018-02-08 Thread Michael Niedermayer
On Thu, Feb 08, 2018 at 06:09:46PM +0100, Paul B Mahol wrote: > On 2/5/18, Michael Niedermayer wrote: > > On Mon, Feb 05, 2018 at 10:04:47AM +0100, Paul B Mahol wrote: > >> On 2/5/18, Michael Niedermayer wrote: > >> > On Thu, Feb 01, 2018 at 02:36:16AM +0100, Michael Niedermayer wrote: > >> >> On

Re: [FFmpeg-devel] [PATCH] cmdutils: fix printing of codecs

2018-02-08 Thread Michael Niedermayer
On Thu, Feb 08, 2018 at 06:21:06PM +0100, wm4 wrote: > On Thu, 8 Feb 2018 12:34:07 -0300 > James Almer wrote: > > > On 2/8/2018 7:25 AM, Rostislav Pehlivanov wrote: > > > On 8 February 2018 at 10:06, Nicolas George wrote: > > > > > >> Michael Niedermayer (2018-02-08): > > >>> +1 > > >> >

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mpegenc - accept PCM_DVD streams

2018-02-08 Thread Michael Niedermayer
On Thu, Feb 08, 2018 at 02:04:57PM +0530, Gyan Doshi wrote: > > > On 2/3/2018 3:59 AM, Michael Niedermayer wrote: > > >>PCM_S16BE stream packets in MPEG-PS have a 3-byte header > >>and recognized as PCM_DVD by the demuxer which prevents > >>their proper remuxing in MPEG-1/2 PS. > > > >its probab

Re: [FFmpeg-devel] avfilter/vf_blend : add 16 bit simd version for basic blend mode

2018-02-08 Thread Martin Vignali
> > breaks build on x86-32 linux > > X86ASM libavfilter/x86/vf_blend.o > src/libavfilter/x86/vf_blend.asm:389: error: invalid combination of > opcode and operands > src/libavfilter/x86/vf_blend.asm:390: error: invalid combination of > opcode and operands > src/libavfilter/x86/vf_blend.asm:391: err

Re: [FFmpeg-devel] [PATCH]lavc/exr: Ignore long names flag

2018-02-08 Thread Martin Vignali
> > Until now, two types of files are supported: > Files with flags==0 and files with flags&0x02. > The specification requires that (flags&0x02) > implies flags==2 or possibly flags==6: "if bit > 9 is 1, bits 11 and 12 must be 0" > > After my patch, the following values are > accepted for flags: 0,

Re: [FFmpeg-devel] [PATCH] cmdutils: fix printing of codecs

2018-02-08 Thread wm4
On Thu, 8 Feb 2018 12:34:07 -0300 James Almer wrote: > On 2/8/2018 7:25 AM, Rostislav Pehlivanov wrote: > > On 8 February 2018 at 10:06, Nicolas George wrote: > > > >> Michael Niedermayer (2018-02-08): > >>> +1 > >> > >> I agree too. > >> > >> And maybe, since we are reverting something,

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/huffyuvdec: Check input buffer size

2018-02-08 Thread Paul B Mahol
On 2/5/18, Michael Niedermayer wrote: > On Mon, Feb 05, 2018 at 10:04:47AM +0100, Paul B Mahol wrote: >> On 2/5/18, Michael Niedermayer wrote: >> > On Thu, Feb 01, 2018 at 02:36:16AM +0100, Michael Niedermayer wrote: >> >> On Wed, Jan 31, 2018 at 07:56:06PM +0100, Paul B Mahol wrote: >> >> > On 1

[FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-08 Thread Nekopanda
- Fix field selection for skipped macroblocks For B field pictures, the spec says, > The prediction shall be made from the field of the same parity as the field > being predicted. I did it. - Fix motion vector rounding for chroma components In 16x8 motion compensation, for lower 16x8 region,

Re: [FFmpeg-devel] [PATCH] cmdutils: Do not unconditionally define functions using avdevice's API

2018-02-08 Thread Derek Buitenhuis
On 2/8/2018 4:34 PM, James Almer wrote: > I just reverted that commit, but in any case this patch needs to be > taken into account for when (and if) it's reapplied. Sounds good. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg

Re: [FFmpeg-devel] [PATCH] cmdutils: Do not unconditionally define functions using avdevice's API

2018-02-08 Thread James Almer
On 2/8/2018 12:21 PM, Derek Buitenhuis wrote: > avdevice is not a hard requiremnet for any of the fftools, and this was > broken in cdc78058c78dfa4966758a342acd2c1f3b282c46. I just reverted that commit, but in any case this patch needs to be taken into account for when (and if) it's reapplied. >

Re: [FFmpeg-devel] [PATCH] cmdutils: fix printing of codecs

2018-02-08 Thread James Almer
On 2/8/2018 1:16 PM, Rostislav Pehlivanov wrote: > On 8 February 2018 at 13:19, James Almer wrote: > >> On 2/8/2018 9:52 AM, wm4 wrote: >>> On Thu, 8 Feb 2018 10:29:11 + >>> Rostislav Pehlivanov wrote: >>> On 8 February 2018 at 01:08, Muhammad Faiz wrote: > On Thu, Feb 8, 2018

Re: [FFmpeg-devel] [PATCH] cmdutils: fix printing of codecs

2018-02-08 Thread Rostislav Pehlivanov
On 8 February 2018 at 13:19, James Almer wrote: > On 2/8/2018 9:52 AM, wm4 wrote: > > On Thu, 8 Feb 2018 10:29:11 + > > Rostislav Pehlivanov wrote: > > > >> On 8 February 2018 at 01:08, Muhammad Faiz wrote: > >> > >>> On Thu, Feb 8, 2018 at 7:35 AM, James Almer wrote: > On 2/7/2018 9:

Re: [FFmpeg-devel] [PATCH] cmdutils: fix printing of codecs

2018-02-08 Thread James Almer
On 2/8/2018 7:25 AM, Rostislav Pehlivanov wrote: > On 8 February 2018 at 10:06, Nicolas George wrote: > >> Michael Niedermayer (2018-02-08): >>> +1 >> >> I agree too. >> >> And maybe, since we are reverting something, revert the whole series. >> >> Regards, >> >> -- >> Nicolas George >> >>

[FFmpeg-devel] [PATCH] cmdutils: Do not unconditionally define functions using avdevice's API

2018-02-08 Thread Derek Buitenhuis
avdevice is not a hard requiremnet for any of the fftools, and this was broken in cdc78058c78dfa4966758a342acd2c1f3b282c46. Fixes build with --disable-avdevice. Signed-off-by: Derek Buitenhuis --- I see you guys can't decide on whether to revert or not, but in the meantime, there is a fix for bu

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB and RGBA 12-bit packed decoding

2018-02-08 Thread Kieran O Leary
Hi Jerome, Thank you so much for this patch. I ran a quick test and ffmpeg and ffplay seems to decode these files just fine. I noticed that taking a short 12-bit sequence (i didn't even realise that they were big endian actually) from the Blackmagic Cintel Scanner turned into FFV1 version 3 in Ma

Re: [FFmpeg-devel] [PATCH] cmdutils: fix printing of codecs

2018-02-08 Thread James Almer
On 2/8/2018 9:52 AM, wm4 wrote: > On Thu, 8 Feb 2018 10:29:11 + > Rostislav Pehlivanov wrote: > >> On 8 February 2018 at 01:08, Muhammad Faiz wrote: >> >>> On Thu, Feb 8, 2018 at 7:35 AM, James Almer wrote: On 2/7/2018 9:32 PM, Michael Niedermayer wrote: > On Wed, Feb 07, 2018

Re: [FFmpeg-devel] [PATCH] cmdutils: fix printing of codecs

2018-02-08 Thread wm4
On Thu, 8 Feb 2018 12:03:22 + Rostislav Pehlivanov wrote: > On 8 February 2018 at 10:35, Nicolas George wrote: > > > Rostislav Pehlivanov (2018-02-08): > > > We should fix what we have right now. The API looks good too except some > > > people here feel like they haven't bikeshedded enoug

Re: [FFmpeg-devel] [PATCH] cmdutils: fix printing of codecs

2018-02-08 Thread wm4
On Thu, 8 Feb 2018 10:29:11 + Rostislav Pehlivanov wrote: > On 8 February 2018 at 01:08, Muhammad Faiz wrote: > > > On Thu, Feb 8, 2018 at 7:35 AM, James Almer wrote: > > > On 2/7/2018 9:32 PM, Michael Niedermayer wrote: > > >> On Wed, Feb 07, 2018 at 09:07:39PM +, Josh de Kock wro

Re: [FFmpeg-devel] [PATCH] libavformat/avio: NULL check for URLContext in ffurl_write().

2018-02-08 Thread Nicolas George
Patagar, Ravindra (2018-02-08): > We observed NULL pointer during HLS/DASH streaming when we simulated > network congestion and disconnects with persistent HTTP connection. > That is why added this check to handle segmentation fault. Please investigate further: find who is calling this function w

Re: [FFmpeg-devel] [PATCH] libavformat/avio: NULL check for URLContext in ffurl_write().

2018-02-08 Thread Patagar, Ravindra
Hi, We observed NULL pointer during HLS/DASH streaming when we simulated network congestion and disconnects with persistent HTTP connection. That is why added this check to handle segmentation fault. On 2/7/18, 4:52 PM, "wm4" wrote: On Wed, 7 Feb 2018 08:57:26 +0530 rpata...@akamai.co

Re: [FFmpeg-devel] [PATCH] cmdutils: fix printing of codecs

2018-02-08 Thread James Almer
On 2/8/2018 7:29 AM, Rostislav Pehlivanov wrote: > On 8 February 2018 at 01:08, Muhammad Faiz wrote: > >> On Thu, Feb 8, 2018 at 7:35 AM, James Almer wrote: >>> On 2/7/2018 9:32 PM, Michael Niedermayer wrote: On Wed, Feb 07, 2018 at 09:07:39PM +, Josh de Kock wrote: > Yes, my bad. I

Re: [FFmpeg-devel] [PATCH] cmdutils: fix printing of codecs

2018-02-08 Thread Rostislav Pehlivanov
On 8 February 2018 at 10:35, Nicolas George wrote: > Rostislav Pehlivanov (2018-02-08): > > We should fix what we have right now. The API looks good too except some > > people here feel like they haven't bikeshedded enough and want to cause > > even more chaos. > > Do you realize that sentence ac

Re: [FFmpeg-devel] tinterlace license

2018-02-08 Thread Vasile Toncu
Shall I start a new thread for the patch with the new filter, or can I use this one? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] tinterlace license

2018-02-08 Thread Vasile Toncu
From the git history I figured out that they wrote a quite big part of tinterlace. Other parts are written mainly by the maintainers of ffmpeg project. Look at the first commit: lavfi: port tinterlace filter from MPlayer That means you need to look at the MPlayer history too to know

Re: [FFmpeg-devel] tinterlace license

2018-02-08 Thread Nicolas George
Vasile Toncu (2018-02-08): > From the git history I figured out that they wrote a quite big part of > tinterlace. Other parts are written mainly by the maintainers of ffmpeg > project. Look at the first commit: lavfi: port tinterlace filter from MPlayer That means you need to look at the

Re: [FFmpeg-devel] tinterlace license

2018-02-08 Thread Vasile Toncu
Hello, Then the best solution - imo! - is that you send a patch that adds your new filter that uses the existing asm optimizations if FFmpeg was configured for GPL. First send one patch only adding a new filter (with a new name) to get some technical review I'll send a patch with my new filte

Re: [FFmpeg-devel] [PATCH] cmdutils: fix printing of codecs

2018-02-08 Thread Nicolas George
Rostislav Pehlivanov (2018-02-08): > We should fix what we have right now. The API looks good too except some > people here feel like they haven't bikeshedded enough and want to cause > even more chaos. Do you realize that sentence accuses Michael, Muhammad and me of pursuing a personal power trip

Re: [FFmpeg-devel] [PATCH] cmdutils: fix printing of codecs

2018-02-08 Thread Rostislav Pehlivanov
On 8 February 2018 at 10:06, Nicolas George wrote: > Michael Niedermayer (2018-02-08): > > +1 > > I agree too. > > And maybe, since we are reverting something, revert the whole series. > > Regards, > > -- > Nicolas George > > ___ > ffmpeg-devel mailin

[FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB and RGBA 12-bit packed decoding

2018-02-08 Thread Jerome Martinez
Currently RGB and RGBA 12-bit are supported by DPX decoder only if component values are padded (packing "Filled to 32-bit words, method A"). This patch adds decoding of RGB and RGBA 12-bit with no padding (packing "Packed into 32-bit words"). As I have no file with line boundaries not aligned o

Re: [FFmpeg-devel] [PATCH] cmdutils: fix printing of codecs

2018-02-08 Thread Rostislav Pehlivanov
On 8 February 2018 at 01:08, Muhammad Faiz wrote: > On Thu, Feb 8, 2018 at 7:35 AM, James Almer wrote: > > On 2/7/2018 9:32 PM, Michael Niedermayer wrote: > >> On Wed, Feb 07, 2018 at 09:07:39PM +, Josh de Kock wrote: > >>> Yes, my bad. It looked like it worked initially (was more > >>> worr

Re: [FFmpeg-devel] [PATCH] cmdutils: fix printing of codecs

2018-02-08 Thread Nicolas George
Michael Niedermayer (2018-02-08): > +1 I agree too. And maybe, since we are reverting something, revert the whole series. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mpegenc - accept PCM_DVD streams

2018-02-08 Thread Gyan Doshi
On 2/3/2018 3:59 AM, Michael Niedermayer wrote: PCM_S16BE stream packets in MPEG-PS have a 3-byte header and recognized as PCM_DVD by the demuxer which prevents their proper remuxing in MPEG-1/2 PS. its probably a good idea to add a fate test for this too. (could be in a seperate patch) Wh

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-02-08 Thread Nablet Developer
On 1/31/2018 4:11 AM, Nablet Developer wrote: protocol requires libsrt (https://github.com/Haivision/srt) to be installed Signed-off-by: Nablet Developer --- ping ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listin