Re: [FFmpeg-devel] [PATCH v2 1/2] fftools/ffmpeg: fix progress log message in case pts is not available

2018-02-26 Thread Tobias Rapp
On 27.02.2018 01:12, Michael Niedermayer wrote: On Mon, Feb 26, 2018 at 05:09:04PM +0100, Tobias Rapp wrote: Move time string formatting into inline function. Also fixes out_time sign prefix for progress report. Signed-off-by: Tobias Rapp --- fftools/ffmpeg.c | 48

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: replace call to av_strerror with av_err2str

2018-02-26 Thread Tobias Rapp
On 26.02.2018 08:40, Tobias Rapp wrote: Signed-off-by: Tobias Rapp --- fftools/ffmpeg.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) [...] Pushed. Thanks Jan and Michael for review. Regards, Tobias

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-02-26 Thread Sven Dueking
> -Ursprüngliche Nachricht- > Von: Sven Dueking [mailto:s...@nablet.com] > Gesendet: Mittwoch, 21. Februar 2018 15:25 > An: 'FFmpeg development discussions and patches' > Betreff: AW: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision > Open SRT protocol > > > > >

[FFmpeg-devel] [PATCH] avformat/hlsenc: add reference stream index for split segment

2018-02-26 Thread Steven Liu
fix ticket: #7044 Get the first video stream to reference for split segment when there have more than one video stream Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavformat/hlsenc.c

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegenc - reject unsupported audio streams

2018-02-26 Thread Gyan Doshi
On 2/27/2018 4:44 AM, Carl Eugen Hoyos wrote: "16 bit" seems useless to me, even more so as all other strings are the FFmpeg codec names (as opposed to generally used names) which seems a very good idea to me. 20 and 24 bit PCM DVD streams cannot be muxed, as the packet header and block

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: Removed usage of deprecated 'filename' variable

2018-02-26 Thread Jeyapal, Karthick
On 2/24/18 12:47 PM, Karthick J wrote: > From: Karthick Jeyapal > > --- > libavformat/dashenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c > index d6474f3..ebff3c5 100644 > ---

Re: [FFmpeg-devel] [PATCH] DASH muxer: add option to change HTTP method

2018-02-26 Thread Jeyapal, Karthick
On 2/26/18 2:16 PM, Serhii Marchuk wrote: > Please have a look at the attached patch. Pushed. Thanks, Karthick > > 2018-02-24 7:31 GMT+02:00 Jeyapal, Karthick : > >> >> >> On 2/23/18 3:30 PM, Serhii Marchuk wrote: >>> --- >>> libavformat/dashenc.c | 4 >>> 1 file

[FFmpeg-devel] [PATCH] avformat/mxg: return reference counted packets

2018-02-26 Thread James Almer
Signed-off-by: James Almer --- libavformat/mxg.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/libavformat/mxg.c b/libavformat/mxg.c index 6fbf99cfa3..fe5879ecf0 100644 --- a/libavformat/mxg.c +++ b/libavformat/mxg.c @@ -169,11 +169,14

Re: [FFmpeg-devel] [PATCH] avformat/utils: don't overwrite the return value of read_packet()

2018-02-26 Thread James Almer
On 2/26/2018 10:14 PM, Michael Niedermayer wrote: > On Mon, Feb 26, 2018 at 12:19:19AM -0300, James Almer wrote: >> This only affected demuxers that didn't return reference counted packets. >> >> Signed-off-by: James Almer >> --- >> libavformat/utils.c | 6 +++--- >> 1 file

Re: [FFmpeg-devel] [PATCH] avformat/utils: don't overwrite the return value of read_packet()

2018-02-26 Thread Michael Niedermayer
On Mon, Feb 26, 2018 at 12:19:19AM -0300, James Almer wrote: > This only affected demuxers that didn't return reference counted packets. > > Signed-off-by: James Almer > --- > libavformat/utils.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) probably ok thx

Re: [FFmpeg-devel] [PATCH v2 1/2] fftools/ffmpeg: fix progress log message in case pts is not available

2018-02-26 Thread Michael Niedermayer
On Mon, Feb 26, 2018 at 05:09:04PM +0100, Tobias Rapp wrote: > Move time string formatting into inline function. Also fixes out_time > sign prefix for progress report. > > Signed-off-by: Tobias Rapp > --- > fftools/ffmpeg.c | 48

Re: [FFmpeg-devel] [PATCH 2/3 v1.1] avcodec/vaapi: add fields for VAAPI VC-1 interlaced decoding

2018-02-26 Thread Mark Thompson
On 25/02/18 19:12, Jerome Borsboom wrote: > avcodec/vaapi: add fields for VAAPI VC-1 interlaced decoding > > Pass necessary bitstream elements to the VAAPI VC-1 decoder in order > to start doing interlaced decoding in hardware. > > Signed-off-by: Jerome Borsboom >

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: replace call to av_strerror with av_err2str

2018-02-26 Thread Michael Niedermayer
On Mon, Feb 26, 2018 at 08:40:02AM +0100, Tobias Rapp wrote: > Signed-off-by: Tobias Rapp > --- > fftools/ffmpeg.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegenc - reject unsupported audio streams

2018-02-26 Thread Carl Eugen Hoyos
2018-02-23 6:05 GMT+01:00 Gyan Doshi : > > > On 2/23/2018 3:50 AM, Carl Eugen Hoyos wrote: >> >> >> Please also mention "mp1" and "pcm_dvd" in the log message. > > > Revised patch attached. "16 bit" seems useless to me, even more so as all other strings are the FFmpeg codec

Re: [FFmpeg-devel] [mpegaudio_parser] Skip trailing junk data when flushing parser.

2018-02-26 Thread Michael Niedermayer
On Mon, Feb 26, 2018 at 10:30:26AM -0800, Dale Curtis wrote: > On Fri, Feb 23, 2018 at 7:01 PM, Michael Niedermayer > wrote: > > > > this goes the wrong direction. > > Parsers should not discard data by default. The code we have for tags is a > > hack. > > There are many

Re: [FFmpeg-devel] Pull requests

2018-02-26 Thread Lou Logan
On Mon, Feb 26, 2018, at 12:39 PM, Bjorn Roche wrote: > > I have a patch I'd like to submit -- can I submit a PR on GitHub, or no? The main problem with github and such is that all development discussions and reviews occur at one location: the ffmpeg-devel mailing list. PRs are therefore out of

Re: [FFmpeg-devel] Pull requests

2018-02-26 Thread Bjorn Roche
Okay, thanks Nicolas. I already submitted a patch to the mailing list a few months ago, I was just hoping for an easier way to keep it fresh since it's gone stale, and I had some more fixes for it. bjorn On Mon, Feb 26, 2018 at 4:49 PM, Nicolas George wrote: > Bjorn Roche

Re: [FFmpeg-devel] Pull requests

2018-02-26 Thread James Almer
On 2/26/2018 6:39 PM, Bjorn Roche wrote: > Hey there, > > Your docs (https://ffmpeg.org/developer.html) say: > > There are 3 ways by which code gets into FFmpeg. > > - Submitting patches to the main developer mailing list. See Submitting > patches for details. > - Directly committing changes to

[FFmpeg-devel] [PATCH 2/2] avcodec/bintext: sanity check dimensions

2018-02-26 Thread Michael Niedermayer
Fixes: Timeout Fixes: 6277/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XBIN_fuzzer-6047202288861184 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/bintext.c | 7

[FFmpeg-devel] [PATCH 1/2] avcodec/msmpeg4dec: Check for input end in msmpeg4v34_decode_mb()

2018-02-26 Thread Michael Niedermayer
Fixes: Timeout Fixes: 6276/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV1_fuzzer-5881196690014208 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/msmpeg4dec.c

Re: [FFmpeg-devel] Pull requests

2018-02-26 Thread Nicolas George
Bjorn Roche (2018-02-26): > - Committing changes to a git clone, for example on github.com or > gitorious.org. And asking us to merge these changes. Note that it does not say how you are supposed to "ask". You are supposed to ask on the mailing-list. > I have a patch I'd like to submit -- can I

[FFmpeg-devel] Pull requests

2018-02-26 Thread Bjorn Roche
Hey there, Your docs (https://ffmpeg.org/developer.html) say: There are 3 ways by which code gets into FFmpeg. - Submitting patches to the main developer mailing list. See Submitting patches for details. - Directly committing changes to the main tree. - Committing changes to a git clone, for

Re: [FFmpeg-devel] [PATCH] compat: remove in-tree NVidia headers

2018-02-26 Thread Marton Balint
On Mon, 26 Feb 2018, Timo Rothenpieler wrote: The reason I haven't pushed this yet is because it breaks the build on MSVC, and I haven't gotten around to figuring out pkg-config for it. Right. I picked this up because I thought it would be nice if we could go through with it before the

Re: [FFmpeg-devel] [mpegaudio_parser] Skip trailing junk data when flushing parser.

2018-02-26 Thread wm4
On Mon, 26 Feb 2018 10:30:26 -0800 Dale Curtis wrote: > On Fri, Feb 23, 2018 at 7:01 PM, Michael Niedermayer > wrote: > > > > this goes the wrong direction. > > Parsers should not discard data by default. The code we have for tags is a > > hack.

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: replace call to av_strerror with av_err2str

2018-02-26 Thread Jan Ekström
On Mon, Feb 26, 2018 at 9:40 AM, Tobias Rapp wrote: > Signed-off-by: Tobias Rapp > --- > fftools/ffmpeg.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index

Re: [FFmpeg-devel] Fix memset size on ctts_data in mov_read_trun()

2018-02-26 Thread 王消寒
Thanks! Updated the patch. Please take a look again. On Sat, Feb 24, 2018 at 7:04 PM, Michael Niedermayer wrote: > On Fri, Feb 23, 2018 at 05:12:05PM -0800, Xiaohan Wang (王消寒) wrote: > > Michael: Dale and I dig into history a bit more and we don't understand > why > >

Re: [FFmpeg-devel] [mpegaudio_parser] Skip trailing junk data when flushing parser.

2018-02-26 Thread Dale Curtis
On Fri, Feb 23, 2018 at 7:01 PM, Michael Niedermayer wrote: > > this goes the wrong direction. > Parsers should not discard data by default. The code we have for tags is a > hack. > There are many better ways to handle this. > Something similar to a AV_PKT_FLAG_CORRUPT

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: update print_report to use AVBPrint API

2018-02-26 Thread wm4
On Mon, 26 Feb 2018 17:09:05 +0100 Tobias Rapp wrote: > Signed-off-by: Tobias Rapp > --- > fftools/ffmpeg.c | 44 > 1 file changed, 20 insertions(+), 24 deletions(-) > Yeah, that seems generally

Re: [FFmpeg-devel] [PATCH] DASH muxer: add option to change HTTP method

2018-02-26 Thread Serhii Marchuk
Please have a look at the attached patch. 2018-02-24 7:31 GMT+02:00 Jeyapal, Karthick : > > > On 2/23/18 3:30 PM, Serhii Marchuk wrote: > > --- > > libavformat/dashenc.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/libavformat/dashenc.c

[FFmpeg-devel] [PATCH 3/3 v1.1] avcodec/vaapi: mask unused bits in bitplane_present.value

2018-02-26 Thread Jerome Borsboom
avcodec/vaapi: mask unused bits in bitplane_present.value Due to the union construct, unused bits in bitplane_present.value might be uninitialized even when the used bits are all set to a value. Masking the unused bits prevents spurious true values when all used bits are unset, e.g. skipped

[FFmpeg-devel] [PATCH 2/3 v1.1] avcodec/vaapi: add fields for VAAPI VC-1 interlaced decoding

2018-02-26 Thread Jerome Borsboom
avcodec/vaapi: add fields for VAAPI VC-1 interlaced decoding Pass necessary bitstream elements to the VAAPI VC-1 decoder in order to start doing interlaced decoding in hardware. Signed-off-by: Jerome Borsboom --- libavcodec/vaapi_vc1.c | 167

[FFmpeg-devel] [PATCH 1/3 v1.1] avcodec/vc1: add bitstream elements for VAAPI VC-1 interlaced decoding

2018-02-26 Thread Jerome Borsboom
This patch-set adds support for hardware accelerated VC-1 interlaced decoding that was recently added to Intel's libva/intel-vaapi-driver. This version hopefully does not suffer from the word wrapping issue in my previous submission. Please ignore the previous version. avcodec/vc1: add

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegenc - reject unsupported audio streams

2018-02-26 Thread Gyan Doshi
On 2/23/2018 10:35 AM, Gyan Doshi wrote: On 2/23/2018 3:50 AM, Carl Eugen Hoyos wrote: Please also mention "mp1" and "pcm_dvd" in the log message. Revised patch attached. Ping. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] FFmpeg 3.5 / 4.0

2018-02-26 Thread Thomas Volkert
Hi, On 19.02.2018 02:50, Michael Niedermayer wrote: > Hi > > Its 4 months since 3.4 was branched so its time for a new major release > > Is 4.0 or 3.5 preferred ? > Any name suggestions ? > > If there are no objections i will likely make that release in the next weeks I would like to see the

[FFmpeg-devel] [PATCH v2 1/2] fftools/ffmpeg: fix progress log message in case pts is not available

2018-02-26 Thread Tobias Rapp
Move time string formatting into inline function. Also fixes out_time sign prefix for progress report. Signed-off-by: Tobias Rapp --- fftools/ffmpeg.c | 48 +++- 1 file changed, 31 insertions(+), 17 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: update print_report to use AVBPrint API

2018-02-26 Thread Tobias Rapp
Signed-off-by: Tobias Rapp --- fftools/ffmpeg.c | 44 1 file changed, 20 insertions(+), 24 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 0097a7d..9654e07 100644 --- a/fftools/ffmpeg.c +++

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix progress log message in case pts is not available

2018-02-26 Thread wm4
On Mon, 26 Feb 2018 14:47:30 +0100 Tobias Rapp wrote: > On 26.02.2018 14:02, wm4 wrote: > > On Mon, 26 Feb 2018 13:14:58 +0100 > > Tobias Rapp wrote: > > > >> Also fixes sign prefix for progress report. > >> > >> Signed-off-by: Tobias Rapp

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix progress log message in case pts is not available

2018-02-26 Thread Tobias Rapp
On 26.02.2018 14:02, wm4 wrote: On Mon, 26 Feb 2018 13:14:58 +0100 Tobias Rapp wrote: Also fixes sign prefix for progress report. Signed-off-by: Tobias Rapp --- fftools/ffmpeg.c | 25 + 1 file changed, 17

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix progress log message in case pts is not available

2018-02-26 Thread wm4
On Mon, 26 Feb 2018 13:14:58 +0100 Tobias Rapp wrote: > Also fixes sign prefix for progress report. > > Signed-off-by: Tobias Rapp > --- > fftools/ffmpeg.c | 25 + > 1 file changed, 17 insertions(+), 8 deletions(-) > >

[FFmpeg-devel] [PATCH] fftools/ffmpeg: fix progress log message in case pts is not available

2018-02-26 Thread Tobias Rapp
Also fixes sign prefix for progress report. Signed-off-by: Tobias Rapp --- fftools/ffmpeg.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 32caa4b..51f27bf 100644 ---

Re: [FFmpeg-devel] GSoC

2018-02-26 Thread Carl Eugen Hoyos
2018-02-26 0:01 GMT+01:00 Stephan Holljes : > Since someone else already applied for the DICOM project, > which I would also like to do Note that no qualification task was submitted so far, meaning that no student qualified for DICOM as of now. Since several different