Re: [FFmpeg-devel] [PATCH 07/10] lavf: document that AVStream::codecpar may be modified by lavf after avformat_write_header(). This is assumed not to break API because it's already true (see e.g. matr

2018-03-15 Thread Rodger Combs
Could we just declare that lavf can update extradata (and nothing else) if it gets packets with new-extradata side-data? If not, I suppose we could either add something to AVStreamInternal, or do something internal in check_bitstream (and update movenc and matroskaenc, as both exhibit this behav

[FFmpeg-devel] [PATCH 1/2] lavc/qsvenc: fix the typo of FrameRateExtD

2018-03-15 Thread Zhong Li
Signed-off-by: Zhong Li --- libavcodec/qsvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 9710f5b..0d2e223 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -366,7 +366,7 @@ static int check_enc_param(AVCodecCon

[FFmpeg-devel] [PATCH 2/2] lavc/qsvenc: add the Access Unit Delimiter NAL Unit support

2018-03-15 Thread Zhong Li
Signed-off-by: Zhong Li --- libavcodec/qsvenc.c | 1 + libavcodec/qsvenc.h | 2 ++ libavcodec/qsvenc_h264.c | 2 ++ 3 files changed, 5 insertions(+) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 0d2e223..afb953e 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c

Re: [FFmpeg-devel] [PATCH] ffmpeg.c - drain all decoded frames during stream_loop flush

2018-03-15 Thread Gyan Doshi
Revised patch only drains 1 packet per call and loops via transcode_step() till EOF, just like when decoders are truly closed. Functionally the same result as first version. On 3/15/2018 3:31 PM, Gyan Doshi wrote: Fixes a bug with flushing decoders during stream_loop. Note that the issue is al

Re: [FFmpeg-devel] [PATCH 07/10] lavf: document that AVStream::codecpar may be modified by lavf after avformat_write_header(). This is assumed not to break API because it's already true (see e.g. matr

2018-03-15 Thread Hendrik Leppkes
On Fri, Mar 16, 2018 at 12:29 AM, Michael Niedermayer wrote: > On Wed, Mar 14, 2018 at 01:24:42AM -0500, Rodger Combs wrote: >> --- >> libavformat/avformat.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/avformat.h b/libavformat/avformat.h >> index 9e87

Re: [FFmpeg-devel] [PATCH V3 02/11] lavu/opt: add bit stream filter option dump support

2018-03-15 Thread Michael Niedermayer
On Wed, Mar 14, 2018 at 01:41:41PM +0800, Jun Zhao wrote: > > libavutil/opt.c|1 + > tests/ref/fate/opt | 50 +- > 2 files changed, 26 insertions(+), 25 deletions(-) > cd3cff1a3823029158a1f5698ea94b8917dfaa5f > 0002-lavu-opt-add-bit-str

Re: [FFmpeg-devel] [PATCH V3 03/11] ffmpeg: support dump bit stream filter options

2018-03-15 Thread Michael Niedermayer
On Wed, Mar 14, 2018 at 01:41:52PM +0800, Jun Zhao wrote: > > cmdutils.c | 17 + > ffmpeg_opt.c |3 ++- > 2 files changed, 19 insertions(+), 1 deletion(-) > 354b73b3bf935d05abb5b3ddc9566f1852bcd773 > 0003-ffmpeg-support-dump-bit-stream-filter-options.patch > From 6b8f19

Re: [FFmpeg-devel] [PATCH V3 01/11] lavu/opt: add AV_OPT_FLAG_BSF_PARAM

2018-03-15 Thread Michael Niedermayer
On Wed, Mar 14, 2018 at 01:41:04PM +0800, Jun Zhao wrote: > V3: rearrange the patch-sets as Michael's comments > V2: update opt fate test ref file > opt.h |1 + > 1 file changed, 1 insertion(+) > 6be6265316a6a31ffb6d4c8db7ed5d0c7c9b53c8 > 0001-lavu-opt-add-AV_OPT_FLAG_BSF_PARAM.patch > From

Re: [FFmpeg-devel] [PATCH] avformat/movenc: move the concatenated eac3 packet reference

2018-03-15 Thread James Almer
On 3/15/2018 8:36 PM, Michael Niedermayer wrote: > On Tue, Mar 13, 2018 at 11:35:18PM -0300, James Almer wrote: >> Simplifies code. >> >> Signed-off-by: James Almer >> --- >> libavformat/movenc.c | 5 + >> 1 file changed, 1 insertion(+), 4 deletions(-) > > should be ok > > thx Pushed, than

Re: [FFmpeg-devel] [PATCH] avformat/movenc: move the concatenated eac3 packet reference

2018-03-15 Thread Michael Niedermayer
On Tue, Mar 13, 2018 at 11:35:18PM -0300, James Almer wrote: > Simplifies code. > > Signed-off-by: James Almer > --- > libavformat/movenc.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) should be ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040

Re: [FFmpeg-devel] [PATCH 07/10] lavf: document that AVStream::codecpar may be modified by lavf after avformat_write_header(). This is assumed not to break API because it's already true (see e.g. matr

2018-03-15 Thread Michael Niedermayer
On Wed, Mar 14, 2018 at 01:24:42AM -0500, Rodger Combs wrote: > --- > libavformat/avformat.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index 9e87d6cdac..5f0ebfc114 100644 > --- a/libavformat/avformat.h > +++ b/liba

Re: [FFmpeg-devel] [PATCH 2/2] avutil/log: print level prefix also when no AVClass context is available

2018-03-15 Thread Michael Niedermayer
On Wed, Mar 14, 2018 at 09:55:23AM +0100, Tobias Rapp wrote: > Adds the level prefix to all log messages, except those with level <= > AV_LOG_QUIET as they seem to be used for flushing the log buffer. > > Signed-off-by: Tobias Rapp > --- > libavutil/log.c | 6 +++--- > 1 file changed, 3 insertio

Re: [FFmpeg-devel] [PATCH 08/10] lavf/matroskaenc: don't rewrite extradata if we already have some

2018-03-15 Thread Rodger Combs
> On Mar 15, 2018, at 17:36, James Almer wrote: > > On 3/14/2018 3:24 AM, Rodger Combs wrote: >> matroska doesn't support mid-stream extradata changes > > How so? We update flac extradata as sent by the encoder in the last > packet as side data. Right, but the format itself doesn't support ch

Re: [FFmpeg-devel] [PATCH 07/10] lavf: document that AVStream::codecpar may be modified by lavf after avformat_write_header(). This is assumed not to break API because it's already true (see e.g. matr

2018-03-15 Thread James Almer
On 3/14/2018 3:24 AM, Rodger Combs wrote: > This is assumed not to break API because it's already true (see e.g. > matroskaenc handling of new AAC extradata) That's an API violation from the muxer's part instead. The correct approach is to fix the violation, not adapt the API around it. > --- >

Re: [FFmpeg-devel] [PATCH 08/10] lavf/matroskaenc: don't rewrite extradata if we already have some

2018-03-15 Thread James Almer
On 3/14/2018 3:24 AM, Rodger Combs wrote: > matroska doesn't support mid-stream extradata changes How so? We update flac extradata as sent by the encoder in the last packet as side data. > , and rewriting > the same extradata already written in write_header would cause errors > since we previousl

Re: [FFmpeg-devel] [PATCH 06/10] Revert "avformat/mux: stop delaying writing the header"

2018-03-15 Thread Michael Niedermayer
On Wed, Mar 14, 2018 at 01:24:41AM -0500, Rodger Combs wrote: > This reverts commit d6d605eb05c3ca32f591016c345eb2ad9e81c554. > --- The commit message should explain why this change is done and as this causes fate changes it should explain what changes and why thx [...] -- Michael GnuPG fi

Re: [FFmpeg-devel] [PATCH] Correcting spelling mistakes

2018-03-15 Thread Lou Logan
On Thu, Mar 15, 2018, at 3:00 AM, sanilraut wrote: > Hi, > I found a few spelling mistakes in variable names. Following is the patch. > > --- > libavformat/dashdec.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) Pushed, thanks. ___

[FFmpeg-devel] [PATCH] avfilter: add hrtfm filter

2018-03-15 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/af_hrtfm.c | 477 +++ libavfilter/allfilters.c | 1 + 3 files changed, 479 insertions(+) create mode 100644 libavfilter/af_hrtfm.c diff --git a/libavfilter/Makefile b/li

Re: [FFmpeg-devel] GSoC

2018-03-15 Thread Mark Thompson
On 15/03/18 01:08, Dylan Fernando wrote: > On Sun, Mar 11, 2018 at 10:18 PM, Mark Thompson wrote: > >> On 11/03/18 04:36, Dylan Fernando wrote: >>> On Thu, Mar 8, 2018 at 8:57 AM, Mark Thompson wrote: >>> On 07/03/18 03:56, Dylan Fernando wrote: > Thanks, it works now > > Would

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_avgblur_opencl.c: add openCL version of libavfilter/vf_avgblur.c filter

2018-03-15 Thread Mark Thompson
On 15/03/18 02:49, Dylan Fernando wrote: > [master 319e56f87c] lavfi: Add OpenCL avgblur filter > 6 files changed, 381 insertions(+) > create mode 100644 libavfilter/opencl/avgblur.cl > create mode 100644 libavfilter/vf_avgblur_opencl.c This patch is corrupted by newlines, probably inserted by

Re: [FFmpeg-devel] [CLT2018] FFmpeg at Chemnitzer Linux-Tage

2018-03-15 Thread Paul B Mahol
On 3/13/18, Thilo Borgmann wrote: > Am 13.03.18 um 19:52 schrieb Paul B Mahol: >> On 3/13/18, Thilo Borgmann wrote: >>> Hi, >>> once again, FFmpeg has been accepted for CLT 2018 in Chemnitz, Germany! This "Chemnitzer Linux Tage" will take place on 10th and 11th of March. You can fi

Re: [FFmpeg-devel] [PATCH] doc/outdevs: Add declink signal generator example

2018-03-15 Thread Marton Balint
On Thu, 15 Mar 2018, Carl Eugen Hoyos wrote: 2018-03-09 21:58 GMT+01:00, Marton Balint : On Fri, 9 Mar 2018, Devin Heitmueller wrote: Also, isn’t -format_code a capture parameter? Is it even valid to provide that on output? Yes, it is capture only indeed. Wonder why does ffmpeg accept i

Re: [FFmpeg-devel] [PATCH] doc/outdevs: Add declink signal generator example

2018-03-15 Thread Marton Balint
On Thu, 15 Mar 2018, Mike Goins wrote: On Fri, Mar 9, 2018 at 3:38 PM, Devin Heitmueller wrote: +ffmpeg -re -f lavfi -i "testsrc=s=1920x1080:rate=3/1000" -f lavfi -i "sine=frequency=1000:sample_rate=48000" +-ac 2 -acodec pcm_s16le -pix_fmt uyvy422 -format_code Hi30 -f decklin

Re: [FFmpeg-devel] [PATCH] Correcting spelling mistakes

2018-03-15 Thread Steven Liu
2018-03-15 19:00 GMT+08:00 sanilraut : > Hi, > I found a few spelling mistakes in variable names. Following is the patch. > > --- > libavformat/dashdec.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > inde

[FFmpeg-devel] [PATCH] Correcting spelling mistakes

2018-03-15 Thread sanilraut
Hi, I found a few spelling mistakes in variable names. Following is the patch. --- libavformat/dashdec.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 2b396a0..7b79b93 100644 --- a/libavformat/dashdec.c +

Re: [FFmpeg-devel] [PATCH] Fix iterating of input and output devices

2018-03-15 Thread Timo Rothenpieler
Looks reasonable to me. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] ffmpeg.c - drain all decoded frames during stream_loop flush

2018-03-15 Thread Gyan Doshi
Fixes a bug with flushing decoders during stream_loop. Note that the issue is also averted if we skip flushing altogether. From 2d3f9b06092d1a0ac09d9b2d1b86fbf6692282e4 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Thu, 15 Mar 2018 15:01:53 +0530 Subject: [PATCH] ffmpeg.c - drain all decoded fr

Re: [FFmpeg-devel] [PATCH] libavformat/movenc : Change MOV_TIMESCALE from 1000 to 600

2018-03-15 Thread Mark Burton
On 14 Mar 2018, at 23:20, Michael Niedermayer wrote: > is there something that i am missing or can this simply > be computed from the input timebases instead of being > a fixed value ? > so its accurate for the input when that is possible > and only some fixed value when that is not possible I th

Re: [FFmpeg-devel] [PATCH] doc/outdevs: Add declink signal generator example

2018-03-15 Thread Carl Eugen Hoyos
2018-03-09 21:58 GMT+01:00, Marton Balint : > > On Fri, 9 Mar 2018, Devin Heitmueller wrote: >> Also, isn’t -format_code a capture parameter? Is it even valid >> to provide that on output? > > Yes, it is capture only indeed. Wonder why does ffmpeg > accept it in the first place? Output options a

Re: [FFmpeg-devel] [PATCH] doc/outdevs: Add declink signal generator example

2018-03-15 Thread Mike Goins
On Fri, Mar 9, 2018 at 3:38 PM, Devin Heitmueller wrote: > >>> +ffmpeg -re -f lavfi -i "testsrc=s=1920x1080:rate=3/1000" -f lavfi -i >>> "sine=frequency=1000:sample_rate=48000" +-ac 2 -acodec pcm_s16le >>> -pix_fmt uyvy422 -format_code Hi30 -f decklink 'DeckLink Studio 2' >> >> You s