Re: [FFmpeg-devel] [PATCH] avcodec/utvideodec: Set pro flag based on fourcc

2018-03-30 Thread Paul B Mahol
On 3/31/18, Michael Niedermayer wrote: > This avoids mixing 8bit variants with pro and 10bit with non pro mode. > Fixes: out of array read > Fixes: poc_03_30.avi > > Found-by: GwanYeong Kim > Signed-off-by: Michael Niedermayer > --- > libavcodec/utvideodec.c | 8 +--- > 1 file changed, 5 in

Re: [FFmpeg-devel] [PATCH] [RFC] avformat/movenc: support writing iTunes cover image

2018-03-30 Thread Timo Teras
Hi On Sat, 31 Mar 2018 02:13:14 +0200 Michael Niedermayer wrote: > On Thu, Mar 29, 2018 at 09:45:13AM +0300, Timo Teräs wrote: > > Fixes https://trac.ffmpeg.org/ticket/2798 > > > > This makes movenc handle AV_DISPOSITION_ATTACHED_PIC and write > > the associated pictures in iTunes cover atom. T

[FFmpeg-devel] [PATCH v4] avfilter: add OpenCL scale filter

2018-03-30 Thread Gabriel Machado
From: Gabriel Machado Implemented the scaling filters using discrete convolution and ported most of the filters from libswscale. --- configure | 1 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/opencl/scale.cl | 67 ++ l

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-03-30 Thread Derek Buitenhuis
On 3/30/2018 11:20 AM, Michael Niedermayer wrote: > I mean derek (who wrote the patch) has not even had time to reply to my > comment. > I am very interrested in what his oppinion is, does he agree? does he > think its impossible or too hard or irrelevant ? Or does he see something > i didnt think

[FFmpeg-devel] [PATCH] avcodec/utvideodec: Set pro flag based on fourcc

2018-03-30 Thread Michael Niedermayer
This avoids mixing 8bit variants with pro and 10bit with non pro mode. Fixes: out of array read Fixes: poc_03_30.avi Found-by: GwanYeong Kim Signed-off-by: Michael Niedermayer --- libavcodec/utvideodec.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/utvi

Re: [FFmpeg-devel] [PATCH 2/2] pixdesc: deprecate AV_PIX_FMT_FLAG_PSEUDOPAL

2018-03-30 Thread James Almer
On 3/30/2018 9:55 PM, wm4 wrote: > On Sat, 31 Mar 2018 01:55:52 +0200 > Michael Niedermayer wrote: > >> On Fri, Mar 30, 2018 at 01:31:35PM +0200, Paul B Mahol wrote: >> [...] >>> Why you and some other 'old' developers have urge to block every single >>> patch >>> that comes from some developers

Re: [FFmpeg-devel] [PATCH 2/2] pixdesc: deprecate AV_PIX_FMT_FLAG_PSEUDOPAL

2018-03-30 Thread wm4
On Sat, 31 Mar 2018 01:55:52 +0200 Michael Niedermayer wrote: > On Fri, Mar 30, 2018 at 01:31:35PM +0200, Paul B Mahol wrote: > [...] > > Why you and some other 'old' developers have urge to block every single > > patch > > that comes from some developers? > > Thats a pretty serious accusatio

Re: [FFmpeg-devel] [PATCH] [RFC] avformat/movenc: support writing iTunes cover image

2018-03-30 Thread Michael Niedermayer
On Thu, Mar 29, 2018 at 09:45:13AM +0300, Timo Teräs wrote: > Fixes https://trac.ffmpeg.org/ticket/2798 > > This makes movenc handle AV_DISPOSITION_ATTACHED_PIC and write > the associated pictures in iTunes cover atom. This corresponds > to how 'mov' demuxer parses and exposes the cover images whe

Re: [FFmpeg-devel] [PATCH 2/2] pixdesc: deprecate AV_PIX_FMT_FLAG_PSEUDOPAL

2018-03-30 Thread Michael Niedermayer
On Fri, Mar 30, 2018 at 01:31:35PM +0200, Paul B Mahol wrote: [...] > Why you and some other 'old' developers have urge to block every single patch > that comes from some developers? Thats a pretty serious accusation, you should not throw this around lightly unless its true. Also i would generall

Re: [FFmpeg-devel] [PATCH 3/3] arm: hevcdsp: Avoid using macro expansion counters

2018-03-30 Thread Hendrik Leppkes
On Fri, Mar 30, 2018 at 9:14 PM, Martin Storsjö wrote: > Clang supports the macro expansion counter (used for making unique > labels within macro expansions), but not when targeting darwin. > > Convert uses of the counter into normal local labels, as used > elsewhere. > > Since Xcode 9.3, the bund

Re: [FFmpeg-devel] [PATCH] doc/encoders - list missing options for x265

2018-03-30 Thread Lou Logan
On Fri, 30 Mar 2018 19:22:29 +0530 Gyan Doshi wrote: > From dafcf437cf6ef407b95b63ac21589137c0e78c9b Mon Sep 17 00:00:00 2001 > From: Gyan Doshi > Date: Fri, 30 Mar 2018 19:19:09 +0530 > Subject: [PATCH] doc/encoders - list missing options for x265 > > Add entries for crf and profile in libx265

[FFmpeg-devel] avfilter/showvolume : various "fix"

2018-03-30 Thread Martin Vignali
Hello, After discussion in user mailing list, several patchs, trying to fix various "issue" with showvolume filter A wav example can be found here (1000 hz with -12 db, then -18 db then 0 db) : https://we.tl/X6L69kEWAN Command line to test (vertical) ./ffmpeg -i inputFile.wav -filter_complex "[0

[FFmpeg-devel] [PATCH 1/3] arm: swscale: Only compile the rgb2yuv asm if .dn aliases are supported

2018-03-30 Thread Martin Storsjö
Vanilla clang supports altmacro since clang 5.0, and thus doesn't require gas-preprocessor for building the arm assembly any longer. However, the built-in assembler doesn't support .dn directives. This readds checks that were removed in d7320ca3ed10f0d, when the last usage of .dn directives withi

[FFmpeg-devel] [PATCH 2/3] arm: hevcdsp_deblock: Add commas between macro arguments

2018-03-30 Thread Martin Storsjö
When targeting darwin, clang requires commas between arguments, while the no-comma form is allowed for other targets. Since Xcode 9.3, the bundled clang supports altmacro and doesn't require using gas-preprocessor any longer. --- libavcodec/arm/hevcdsp_deblock_neon.S | 8 1 file changed,

[FFmpeg-devel] [PATCH 3/3] arm: hevcdsp: Avoid using macro expansion counters

2018-03-30 Thread Martin Storsjö
Clang supports the macro expansion counter (used for making unique labels within macro expansions), but not when targeting darwin. Convert uses of the counter into normal local labels, as used elsewhere. Since Xcode 9.3, the bundled clang supports altmacro and doesn't require using gas-preprocess

[FFmpeg-devel] [PATCH] avcodec/aic: fix decoding of videos which height is not multiple of 16

2018-03-30 Thread Paul B Mahol
Fate output changes and under close inspection looks more correctly. Fixes #6187. Signed-off-by: Paul B Mahol --- libavcodec/aic.c | 14 +- tests/ref/fate/aic | 30 ++-- tests/ref/fate/aic-oddsize | 114 ++--- 3 files change

Re: [FFmpeg-devel] [PATCH 1/5 v2] avformat/utils: make AVPacketList helper functions shared

2018-03-30 Thread James Almer
On 3/27/2018 7:48 PM, James Almer wrote: > Based on a patch by Luca Barbato. > > Signed-off-by: James Almer > --- > libavformat/internal.h | 38 + > libavformat/utils.c| 57 > +- > 2 files changed, 71 insertions

[FFmpeg-devel] [PATCH 1/6] avcodec/avpacket: add av_packet_make_refcounted()

2018-03-30 Thread James Almer
It works as a drop in replacement for the deprecated av_dup_packet(), to ensure a packet is reference counted. Signed-off-by: James Almer --- libavcodec/avcodec.h | 18 +- libavcodec/avpacket.c | 18 ++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH] avformat/mpeg: fix detection and demuxing of raw AC3 in mpegps

2018-03-30 Thread Paul B Mahol
Fixes #4889. Signed-off-by: Paul B Mahol --- libavformat/mpeg.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c index 69d4a9d8ac..f6e3439e68 100644 --- a/libavformat/mpeg.c +++ b/libavformat/mpeg.c @@ -128,6

Re: [FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

2018-03-30 Thread Jan Ekström
On Thu, Mar 29, 2018 at 5:25 PM, Jan Ekström wrote: > On Thu, Mar 29, 2018 at 1:14 PM, Michael Niedermayer > wrote: >> >> this breaks fate-sub2video >> >> TESTsub2video >> --- ./tests/ref/fate/sub2video 2018-03-29 02:30:48.095578219 +0200 >> +++ tests/data/fate/sub2video 2018-03-29 12:13:2

[FFmpeg-devel] [PATCH] lavfi: add a Vulkan Chromatic Aberration filter

2018-03-30 Thread Rostislav Pehlivanov
This implements a simple chromatic aberration filter. The curve could use a little bit of tweaking, right now its not as curvy as it should be but nevertheless it models the imperfections of lenses. Meant to be applied on top of my previous patches. RFC quality again. Signed-off-by: Rostislav Peh

[FFmpeg-devel] [PATCH] doc/encoders - list missing options for x265

2018-03-30 Thread Gyan Doshi
From dafcf437cf6ef407b95b63ac21589137c0e78c9b Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Fri, 30 Mar 2018 19:19:09 +0530 Subject: [PATCH] doc/encoders - list missing options for x265 Add entries for crf and profile in libx265 section --- doc/encoders.texi | 6 ++ 1 file changed, 6 inser

[FFmpeg-devel] [PATCH] avformat/mpeg: fix PCM-DVD mis-detection as MLP

2018-03-30 Thread Paul B Mahol
Fixes #6563. Signed-off-by: Paul B Mahol --- libavformat/mpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c index abdc6a937c..69d4a9d8ac 100644 --- a/libavformat/mpeg.c +++ b/libavformat/mpeg.c @@ -568,7 +568,7 @@ redo: cod

Re: [FFmpeg-devel] [PATCH 4/8] avformat/utils: function to check and ignore non fatal network errors

2018-03-30 Thread wm4
On Fri, 30 Mar 2018 10:38:34 +0530 vdi...@akamai.com wrote: > From: Vishwanath Dixit > > For live HLS/DASH output usecases, currently ffmpeg application exits > for any network error during muxing. However, some of the errors like > EPIPE, ECONNREFUSED and ECONNRESET are non-fatal. They might ca

Re: [FFmpeg-devel] [PATCH 2/2] lavf/tcp.c: Free allocated client URLContext in case of error.

2018-03-30 Thread Stephan Holljes
On Fri, Jan 12, 2018 at 8:47 PM, Michael Niedermayer wrote: > On Fri, Jan 12, 2018 at 07:16:30PM +0100, Stephan Holljes wrote: >> Signed-off-by: Stephan Holljes >> --- >> libavformat/tcp.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) > > patchset is probably ok > > [...] > > -- >

Re: [FFmpeg-devel] [PATCH 1/8] avformat/avio: check for null context to avoid uninitialized pointer access

2018-03-30 Thread wm4
On Fri, 30 Mar 2018 10:38:09 +0530 vdi...@akamai.com wrote: > From: Vishwanath Dixit > > --- > libavformat/avio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/avio.c b/libavformat/avio.c > index 63e8287..18e58ae 100644 > --- a/libavformat/avio.c > +++ b/

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-03-30 Thread wm4
On Fri, 30 Mar 2018 12:20:38 +0200 Michael Niedermayer wrote: > On Thu, Mar 29, 2018 at 09:08:52PM +0200, wm4 wrote: > > On Thu, 29 Mar 2018 20:55:52 +0200 > > Michael Niedermayer wrote: > > > > > On Thu, Mar 29, 2018 at 08:49:21PM +0200, Michael Niedermayer wrote: > > > > On Thu, Mar 29, 2

Re: [FFmpeg-devel] [PATCH 2/2] pixdesc: deprecate AV_PIX_FMT_FLAG_PSEUDOPAL

2018-03-30 Thread wm4
On Fri, 30 Mar 2018 13:22:25 +0200 Michael Niedermayer wrote: > On Fri, Mar 30, 2018 at 03:23:25AM +0200, wm4 wrote: > > On Fri, 30 Mar 2018 03:13:07 +0200 > > Michael Niedermayer wrote: > > > > > On Thu, Mar 29, 2018 at 03:30:43PM +0200, wm4 wrote: > > > > PSEUDOPAL pixel formats are not p

[FFmpeg-devel] [PATCH] [RFC]doc/examples: alternative input handler

2018-03-30 Thread Bodecs Bela
Hi All, regularly, on different forums and mailing lists a requirement popups for a feature to automatically failover switching between main input and a secondary input in case of main input unavailability. The base motivation: let's say you have a unreliable live stream source and you want

[FFmpeg-devel] [PATCH] use bcrypt instead of the old wincrypt API

2018-03-30 Thread Steve Lhomme
Remove the wincrypt API calls since we don't support XP anymore and bcrypt is available since Vista, even on Windows Store builds. --- configure | 6 +++--- libavutil/random_seed.c | 20 ++-- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/configure

Re: [FFmpeg-devel] [PATCH 2/2] pixdesc: deprecate AV_PIX_FMT_FLAG_PSEUDOPAL

2018-03-30 Thread Paul B Mahol
On 3/30/18, Michael Niedermayer wrote: > On Fri, Mar 30, 2018 at 03:23:25AM +0200, wm4 wrote: >> On Fri, 30 Mar 2018 03:13:07 +0200 >> Michael Niedermayer wrote: >> >> > On Thu, Mar 29, 2018 at 03:30:43PM +0200, wm4 wrote: >> > > PSEUDOPAL pixel formats are not paletted, but carried a palette wit

Re: [FFmpeg-devel] [PATCH 2/2] pixdesc: deprecate AV_PIX_FMT_FLAG_PSEUDOPAL

2018-03-30 Thread Michael Niedermayer
On Fri, Mar 30, 2018 at 03:23:25AM +0200, wm4 wrote: > On Fri, 30 Mar 2018 03:13:07 +0200 > Michael Niedermayer wrote: > > > On Thu, Mar 29, 2018 at 03:30:43PM +0200, wm4 wrote: > > > PSEUDOPAL pixel formats are not paletted, but carried a palette with the > > > intention of allowing code to trea

Re: [FFmpeg-devel] [PATCH] use bcrypt instead of the old wincrypt API

2018-03-30 Thread Hendrik Leppkes
On Fri, Mar 30, 2018 at 9:23 AM, Steve Lhomme wrote: > When targeting Windows Vista and above > The wincrypt API is deprecated and not allowed for Windows Store apps. > --- > configure | 4 +++- > libavutil/random_seed.c | 16 ++-- > 2 files changed, 17 insertions(+), 3

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-03-30 Thread Michael Niedermayer
On Thu, Mar 29, 2018 at 09:08:52PM +0200, wm4 wrote: > On Thu, 29 Mar 2018 20:55:52 +0200 > Michael Niedermayer wrote: > > > On Thu, Mar 29, 2018 at 08:49:21PM +0200, Michael Niedermayer wrote: > > > On Thu, Mar 29, 2018 at 02:53:52PM +0100, Derek Buitenhuis wrote: > > > > On 3/29/2018 2:13 AM,

Re: [FFmpeg-devel] [PATCH v3 2/3] avutil/log: add av_log_set_opts function

2018-03-30 Thread Michael Niedermayer
On Wed, Mar 28, 2018 at 05:03:39PM +0200, Tobias Rapp wrote: > Allows to set log level and flag values from string. > > Signed-off-by: Tobias Rapp > --- > doc/APIchanges | 3 +++ > libavutil/log.c | 76 > + > libavutil/log.h | 16

Re: [FFmpeg-devel] [PATCH 3/3] lavfi: add a Vulkan avgblur filter

2018-03-30 Thread Paul B Mahol
On 3/30/18, Rostislav Pehlivanov wrote: > This commit adds an average blur Vulkan filter which functions > exactly the same as avgblur but on Vulkan surfaces. > > Currently contains a workaround that will be removed for the actual, > non-RFC version. > > It implements a clever way of minimizing te

[FFmpeg-devel] [PATCH] use bcrypt instead of the old wincrypt API

2018-03-30 Thread Steve Lhomme
When targeting Windows Vista and above The wincrypt API is deprecated and not allowed for Windows Store apps. --- configure | 4 +++- libavutil/random_seed.c | 16 ++-- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 99570a1415