Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-05-19 Thread Moritz Barsnick
On Fri, May 18, 2018 at 16:54:25 -0700, Wang Cao wrote: Apart from the functional changes: > data_size += ost->data_size; > -if ( (ost->enc_ctx->flags & (AV_CODEC_FLAG_PASS1 | > AV_CODEC_FLAG_PASS2)) > + > +if ((ost->enc_ctx->flags & (AV_CODEC_FLAG_PASS1 | > AV_CODEC

Re: [FFmpeg-devel] avdevice/sdl output : fix window_size and add new option (WIP)

2018-05-19 Thread Martin Vignali
> > Thanks for comments and testing. > Dropped the window_pos patch. > > New patch in attach : > - 001 : Fix -window_size option --> Unchanged patch > - 002 : Add option to disable quit action : Add doc > > > Pushed Martin ___ ffmpeg-devel mailing list f

[FFmpeg-devel] [PATCH] avcodec/libvpxenc: fix setting amount of threads used for encoding

2018-05-19 Thread James Almer
The libvpx doxy says that a value of 0 for the g_threads field is equivalent to a value of 1, whereas for avctx->thread_count it means the maximum amount of threads possible for the host system. Use av_cpu_count() to get the correct thread count when auto threads is requested. Signed-off-by: Jame

Re: [FFmpeg-devel] [PATCH 3/5] avformat/mp3dec: Require probing data to be 50% mp3 frames for low score probing to succeed

2018-05-19 Thread Paul B Mahol
On 5/12/18, Michael Niedermayer wrote: > This massively reduces the detection of random data as low score mp3 > It may improve security by making it harder to read non multimedia data > > Signed-off-by: Michael Niedermayer > --- > libavformat/mp3dec.c | 10 +++--- > 1 file changed, 7 inserti

Re: [FFmpeg-devel] [PATCH 4/5] avformat/mp3dec: Require 50% of the file to be mp3 frames in the maxframes>200 probing test

2018-05-19 Thread Michael Niedermayer
On Sat, May 12, 2018 at 06:33:28PM +0200, Michael Niedermayer wrote: > This corrects several misdetections of large files > > Signed-off-by: Michael Niedermayer > --- > libavformat/mp3dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply please report any cases with CC to me

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mp3dec: require 90% of a file to be mp3 if only 1 mp3 frame is found in sequence

2018-05-19 Thread Michael Niedermayer
On Sat, May 12, 2018 at 06:33:29PM +0200, Michael Niedermayer wrote: > This eliminates several low score detections of non mp3 files > > Signed-off-by: Michael Niedermayer > --- > libavformat/mp3dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply please report any cases th

Re: [FFmpeg-devel] [PATCH 3/5] avformat/mp3dec: Require probing data to be 50% mp3 frames for low score probing to succeed

2018-05-19 Thread Michael Niedermayer
On Sat, May 19, 2018 at 08:51:26PM +0200, Paul B Mahol wrote: > On 5/12/18, Michael Niedermayer wrote: > > This massively reduces the detection of random data as low score mp3 > > It may improve security by making it harder to read non multimedia data > > > > Signed-off-by: Michael Niedermayer >

Re: [FFmpeg-devel] [PATCH v4 1/3] avformat: add fields to AVProgram/AVStream for PMT change tracking

2018-05-19 Thread Michael Niedermayer
On Fri, May 18, 2018 at 11:15:04AM -0700, Aman Gupta wrote: > From: Aman Gupta > > These fields will allow the mpegts demuxer to expose details about > the PMT/program which created the AVProgram and its AVStreams. > > In mpegts, a PMT which advertises streams has a version number > which can be

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/vc1: store zero MVs for all blocks in a MB

2018-05-19 Thread Michael Niedermayer
On Fri, May 18, 2018 at 05:06:36PM +0200, Jerome Borsboom wrote: > Direct prediction for interlace frame B pictures references the mv in the > second block in an MB in the backward reference frame for the twomv case. > When the backward reference frame is an I frame, this value may be unset. > > S

Re: [FFmpeg-devel] [PATCH v4 1/3] avformat: add fields to AVProgram/AVStream for PMT change tracking

2018-05-19 Thread James Almer
On 5/19/2018 6:31 PM, Michael Niedermayer wrote: > On Fri, May 18, 2018 at 11:15:04AM -0700, Aman Gupta wrote: >> From: Aman Gupta >> >> These fields will allow the mpegts demuxer to expose details about >> the PMT/program which created the AVProgram and its AVStreams. >> >> In mpegts, a PMT which

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/vc1: fix mquant calculation for interlace field pictures

2018-05-19 Thread Michael Niedermayer
On Fri, May 18, 2018 at 05:06:23PM +0200, Jerome Borsboom wrote: > For interlace field pictures s->mb_height indicates the height of the full > picture in MBs, i.e. the two fields combined. A single field is half this > size. When calculating mquant for interlace field pictures, the bottom edge > i

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/vc1: store zero MVs for all blocks in a MB

2018-05-19 Thread James Almer
On 5/19/2018 6:40 PM, Michael Niedermayer wrote: > On Fri, May 18, 2018 at 05:06:36PM +0200, Jerome Borsboom wrote: >> Direct prediction for interlace frame B pictures references the mv in the >> second block in an MB in the backward reference frame for the twomv case. >> When the backward referenc

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/vc1: fix calculation of the last line of a slice

2018-05-19 Thread Michael Niedermayer
On Fri, May 18, 2018 at 05:06:32PM +0200, Jerome Borsboom wrote: > Only for the last slice of the first field is the last line of the slice > equal to the height of the field. > > Signed-off-by: Jerome Borsboom > --- > libavcodec/vc1dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/vc1: DIRECTBIT is only present in inter MBs

2018-05-19 Thread Michael Niedermayer
On Fri, May 18, 2018 at 05:06:28PM +0200, Jerome Borsboom wrote: > DIRECTBIT was decoded before the intra/inter MB branching when decoding > interlace frame B pictures. Resulting in mistakenly also decoding it for intra > MBs where this syntax element is not present. > > Signed-off-by: Jerome Bors

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/vc1: store zero MVs for all blocks in a MB

2018-05-19 Thread Michael Niedermayer
On Sat, May 19, 2018 at 08:23:59PM -0300, James Almer wrote: > On 5/19/2018 6:40 PM, Michael Niedermayer wrote: > > On Fri, May 18, 2018 at 05:06:36PM +0200, Jerome Borsboom wrote: > >> Direct prediction for interlace frame B pictures references the mv in the > >> second block in an MB in the backw

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/vc1: FIELDTX is only coded raw in interlaced frame I pictures

2018-05-19 Thread Michael Niedermayer
On Fri, May 18, 2018 at 05:06:18PM +0200, Jerome Borsboom wrote: > FIELDTX bitplane is only present in interlace frame I pictures. > v->fieldtx_is_raw may spill over from a previous interlaced frame I picture > while decoding a non-interlace frame I picture. > > Signed-off-by: Jerome Borsboom > -

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/vc1: store zero MVs for all blocks in a MB

2018-05-19 Thread James Almer
On 5/19/2018 9:13 PM, Michael Niedermayer wrote: > On Sat, May 19, 2018 at 08:23:59PM -0300, James Almer wrote: >> On 5/19/2018 6:40 PM, Michael Niedermayer wrote: >>> On Fri, May 18, 2018 at 05:06:36PM +0200, Jerome Borsboom wrote: Direct prediction for interlace frame B pictures references t