Re: [FFmpeg-devel] [PATCH v7 3/3] lavc, doc, configure: add avs2 video decoder wrapper

2018-07-04 Thread Gyan Doshi
On 05-07-2018 10:42 AM, hwren wrote: + +libdavs2 uses GPLv2, so you may also need to add @code{--enable-gpl} while configuring. Is it permissible to link against GPLv3 ffmpeg build? If yes, please change above line to what x264 section currently has. Thanks, Gyan

Re: [FFmpeg-devel] [PATCH v6 4/4] lavc, doc, configure: add avs2 video decoder

2018-07-04 Thread hwren
Almost another one. hwrenx. At 2018-07-04 04:28:16, "Carl Eugen Hoyos" wrote: >2018-07-03 6:22 GMT+02:00, hwren : > >> +- AVS2 video decoder via libdavs2 > >Is this related to ticket #6948 or is this another codec? > >Carl Eugen >___ >ffmpeg

[FFmpeg-devel] [PATCH v7 2/3] lavf: add avs2 fourcc

2018-07-04 Thread hwren
Signed-off-by: hwren --- libavformat/riff.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/riff.c b/libavformat/riff.c index 8911725..4153372 100644 --- a/libavformat/riff.c +++ b/libavformat/riff.c @@ -369,6 +369,7 @@ const AVCodecTag ff_codec_bmp_tags[] = { { AV_CODEC_ID_Z

[FFmpeg-devel] [PATCH v7 1/3] lavc: add avs2 parser

2018-07-04 Thread hwren
Signed-off-by: hwren --- libavcodec/Makefile | 1 + libavcodec/avcodec.h | 1 + libavcodec/avs2_parser.c | 95 libavcodec/codec_desc.c | 7 libavcodec/parser.c | 1 + libavcodec/version.h | 4 +- 6 files changed, 107 in

[FFmpeg-devel] [PATCH v7 3/3] lavc, doc, configure: add avs2 video decoder wrapper

2018-07-04 Thread hwren
Signed-off-by: hwren --- Changelog | 1 + configure | 4 ++ doc/decoders.texi | 10 +++ doc/general.texi | 8 +++ libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/libdavs2.c | 177 ++

Re: [FFmpeg-devel] [PATCH v6 1/4] lavc,doc: add avs2 codec

2018-07-04 Thread hwren
The decoder could not work well without its parser, so I merged the parser-patch into the codec-patch. Thanks for advice, hwrenx. At 2018-07-04 04:24:39, "Carl Eugen Hoyos" wrote: >2018-07-03 6:22 GMT+02:00, hwren : >> Signed-off-by: hwren >> --- >> doc/APIchanges | 3 +++ >>

Re: [FFmpeg-devel] [PATCH 01/12] avformat/mxfenc: automatically update descriptors klv size

2018-07-04 Thread Michael Niedermayer
On Wed, Jul 04, 2018 at 11:35:03AM -0700, Baptiste Coudurier wrote: > --- > libavformat/mxfenc.c | 80 +--- > 1 file changed, 39 insertions(+), 41 deletions(-) > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c > index 77f60f5874..b98d234f03 10064

Re: [FFmpeg-devel] [PATCH v2] lavf/mxfenc: support creating s436m data tracks

2018-07-04 Thread Marton Balint
On Wed, 4 Jul 2018, Baptiste Coudurier wrote: --- libavformat/mxf.c| 1 + libavformat/mxfdec.c | 2 ++ libavformat/mxfenc.c | 41 + libavformat/utils.c | 6 +- 4 files changed, 45 insertions(+), 5 deletions(-) diff --git a/libavformat/mxf.c b/lib

Re: [FFmpeg-devel] [PATCH v2] lavf/mxfdec: demux s436m as eia608 subtitle track

2018-07-04 Thread Derek Buitenhuis
On 04/07/2018 23:05, Baptiste Coudurier wrote: > +if (length < 0) > +return AVERROR_INVALIDDATA; > + > +int array_count = avio_rb32(s->pb); > +int array_elem_size = avio_rb32(s->pb); Mixed declarations aren't allowed in FFmpeg. - Derek _

[FFmpeg-devel] [PATCH v2] lavf/mxfenc: support creating s436m data tracks

2018-07-04 Thread Baptiste Coudurier
--- libavformat/mxf.c| 1 + libavformat/mxfdec.c | 2 ++ libavformat/mxfenc.c | 41 + libavformat/utils.c | 6 +- 4 files changed, 45 insertions(+), 5 deletions(-) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index 8376a2b9bf..451cbcfb2c 1

[FFmpeg-devel] [PATCH v2] lavf/mxfdec: demux s436m as eia608 subtitle track

2018-07-04 Thread Baptiste Coudurier
--- libavformat/mxfdec.c | 103 +++ 1 file changed, 103 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 575126d639..13226333cc 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -52,6 +52,7 @@ #include "libavutil/i

Re: [FFmpeg-devel] [PATCH 09/12] lavf/mxfenc: support creating s436m data tracks

2018-07-04 Thread Baptiste Coudurier
Hi Marton, On Wed, Jul 4, 2018 at 1:38 PM, Marton Balint wrote: > > > On Wed, 4 Jul 2018, Baptiste Coudurier wrote: > > --- >> libavformat/mxf.c| 1 + >> libavformat/mxfdec.c | 3 +++ >> libavformat/mxfenc.c | 41 + >> libavformat/utils.c | 6 +- >

Re: [FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

2018-07-04 Thread Michael Niedermayer
On Wed, Jul 04, 2018 at 09:32:32AM +0200, Karsten Otto wrote: > > > Am 04.07.2018 um 03:26 schrieb Michael Niedermayer : > > > > Signierter PGP-Teil > > On Tue, Jul 03, 2018 at 10:25:36PM +0200, Karsten Otto wrote: > >> TL;DR: I will drop patch 3/3, may rather spend some time investigating why >

Re: [FFmpeg-devel] [PATCH 10/12] lavf/mxfdec: demux s436m as eia608 subtitle track

2018-07-04 Thread Marton Balint
On Wed, 4 Jul 2018, Baptiste Coudurier wrote: --- libavformat/mxfdec.c | 102 +++ 1 file changed, 102 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 3f443bbbc9..54e4be7934 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/

Re: [FFmpeg-devel] [PATCH 09/12] lavf/mxfenc: support creating s436m data tracks

2018-07-04 Thread Marton Balint
On Wed, 4 Jul 2018, Baptiste Coudurier wrote: --- libavformat/mxf.c| 1 + libavformat/mxfdec.c | 3 +++ libavformat/mxfenc.c | 41 + libavformat/utils.c | 6 +- 4 files changed, 46 insertions(+), 5 deletions(-) diff --git a/libavformat/mxf.c b/l

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/mpeg4videodec: Check for bitstream end in read_quant_matrix_ext()

2018-07-04 Thread Michael Niedermayer
On Wed, Jul 04, 2018 at 03:03:03AM +0200, Michael Niedermayer wrote: > On Tue, Jul 03, 2018 at 11:52:59PM +0200, Carl Eugen Hoyos wrote: > > 2018-07-03 23:05 GMT+02:00, Michael Niedermayer : > > > Fixes: out of array read > > > Fixes: asff-crash-0e53d0dc491dfdd507530b66562812fbd4c36678 > > > > > >

[FFmpeg-devel] [PATCH] avformat/mxfdec: only return stream indexes which have a corresponding track

2018-07-04 Thread Marton Balint
Without this check some crafted files might crash because a packet might be demuxed which have no corresponding mxf track. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index b

Re: [FFmpeg-devel] [PATCH 1/5] avformat/mxfdec: add support for clip wrapped essences

2018-07-04 Thread Marton Balint
On Tue, 3 Jul 2018, Tomas Härdin wrote: tis 2018-07-03 klockan 22:36 +0200 skrev Marton Balint: On Mon, 25 Jun 2018, Marton Balint wrote: > Also use common code with opAtom. > > Fixes ticket #2776. > Partially fixes ticket #5671. > Fixes ticket #5866. Will push the series soon. Sorry,

[FFmpeg-devel] [PATCH] Optimize libavformat/metadata.c

2018-07-04 Thread Shlomi Fish
-- - Shlomi Fish http://www.shlomifish.org/ What does “Zionism” mean? - http://shlom.in/def-zionism It is impossible to make anything foolproof because fools are so ingenious. — Source Unknown Please reply to list if it'

[FFmpeg-devel] [PATCH 09/12] lavf/mxfenc: support creating s436m data tracks

2018-07-04 Thread Baptiste Coudurier
--- libavformat/mxf.c| 1 + libavformat/mxfdec.c | 3 +++ libavformat/mxfenc.c | 41 + libavformat/utils.c | 6 +- 4 files changed, 46 insertions(+), 5 deletions(-) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index 8376a2b9bf..451cbcfb2c

[FFmpeg-devel] [PATCH 12/12] lavf/sccenc: write proper timecode, use proper stream timebase and split lines properly

2018-07-04 Thread Baptiste Coudurier
--- libavformat/sccenc.c | 90 ++-- 1 file changed, 54 insertions(+), 36 deletions(-) diff --git a/libavformat/sccenc.c b/libavformat/sccenc.c index f3cf3d599c..dd6a4b36d8 100644 --- a/libavformat/sccenc.c +++ b/libavformat/sccenc.c @@ -23,16 +23,22 @@ #in

[FFmpeg-devel] [PATCH 08/12] avformat/mxfenc: fix muxing when audio tracks are longer than video track

2018-07-04 Thread Baptiste Coudurier
--- libavformat/mxfenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index 1f272ce6e5..036adce011 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -2935,6 +2935,9 @@ static int mxf_interleave_get_packet(AVForm

[FFmpeg-devel] [PATCH 05/12] avformat/mxfenc: correctly set content package rate in system element

2018-07-04 Thread Baptiste Coudurier
--- libavformat/mxf.c| 17 + libavformat/mxf.h| 2 ++ libavformat/mxfenc.c | 4 +++- tests/ref/lavf/mxf | 2 +- 4 files changed, 23 insertions(+), 2 deletions(-) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index c8b57f7f0b..8376a2b9bf 100644 --- a/libavformat/m

[FFmpeg-devel] [PATCH 10/12] lavf/mxfdec: demux s436m as eia608 subtitle track

2018-07-04 Thread Baptiste Coudurier
--- libavformat/mxfdec.c | 102 +++ 1 file changed, 102 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 3f443bbbc9..54e4be7934 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -52,6 +52,7 @@ #include "libavutil/i

[FFmpeg-devel] [PATCH 11/12] lavf/sccdec: fix timestamps and demux one eai608 frame at a time

2018-07-04 Thread Baptiste Coudurier
--- libavformat/sccdec.c | 100 --- 1 file changed, 56 insertions(+), 44 deletions(-) diff --git a/libavformat/sccdec.c b/libavformat/sccdec.c index 89d21b9c1f..0472b4e031 100644 --- a/libavformat/sccdec.c +++ b/libavformat/sccdec.c @@ -24,9 +24,14 @@ #inc

[FFmpeg-devel] [PATCH 07/12] ratecontrol: fix stuffing bits for 30000/1001 fps one frame vbv

2018-07-04 Thread Baptiste Coudurier
--- libavcodec/ratecontrol.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/ratecontrol.c b/libavcodec/ratecontrol.c index 49d169ba25..28bdddbad1 100644 --- a/libavcodec/ratecontrol.c +++ b/libavcodec/ratecontrol.c @@ -705,16 +705,16 @@ int ff_vbv_updat

[FFmpeg-devel] [PATCH 06/12] avformat/audiointerleave: pad last audio frame

2018-07-04 Thread Baptiste Coudurier
--- libavformat/audiointerleave.c | 10 +++--- tests/ref/lavf/mxf| 4 ++-- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/libavformat/audiointerleave.c b/libavformat/audiointerleave.c index 6d4954befe..dea5d99821 100644 --- a/libavformat/audiointerleave.c +++ b/lib

[FFmpeg-devel] [PATCH 04/12] avformat/mxfenc: update body partition with footer offset

2018-07-04 Thread Baptiste Coudurier
--- libavformat/mxfenc.c| 9 +++-- tests/ref/lavf/mxf | 6 +++--- tests/ref/lavf/mxf_d10 | 2 +- tests/ref/lavf/mxf_dv25 | 2 +- tests/ref/lavf/mxf_dvcpro50 | 2 +- tests/ref/lavf/mxf_opatom | 2 +- tests/ref/lavf/mxf_opatom_audio | 2 +- 7 f

[FFmpeg-devel] [PATCH 02/12] avformat/mxfenc: write index delta entry array needed by sony vegas pro 11

2018-07-04 Thread Baptiste Coudurier
--- libavformat/mxfenc.c| 208 ++-- tests/ref/lavf/mxf | 6 +- tests/ref/lavf/mxf_d10 | 2 +- tests/ref/lavf/mxf_dv25 | 2 +- tests/ref/lavf/mxf_dvcpro50 | 2 +- tests/ref/lavf/mxf_opatom | 2 +- tests/ref/la

[FFmpeg-devel] [PATCH 03/12] avformat/mxfenc: add mpeg-2 specific metadata, fix compatibility with sony content browser

2018-07-04 Thread Baptiste Coudurier
--- libavformat/mxfenc.c| 46 ++--- tests/ref/lavf/mxf | 6 ++--- tests/ref/lavf/mxf_d10 | 2 +- tests/ref/lavf/mxf_dv25 | 2 +- tests/ref/lavf/mxf_dvcpro50 | 2 +- tests/ref/lavf/mxf_opatom | 2 +- tests/ref/lavf

[FFmpeg-devel] [PATCH 01/12] avformat/mxfenc: automatically update descriptors klv size

2018-07-04 Thread Baptiste Coudurier
--- libavformat/mxfenc.c | 80 +--- 1 file changed, 39 insertions(+), 41 deletions(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index 77f60f5874..b98d234f03 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -1104,14 +1104,16 @@

Re: [FFmpeg-devel] [PATCH] Refactor two near-identical clauses - take 2

2018-07-04 Thread Shlomi Fish
On Wed, 4 Jul 2018 18:55:42 +0200 Carl Eugen Hoyos wrote: > 2018-06-28 10:52 GMT+02:00, Shlomi Fish : > > > Attached is the 2nd take of the patch for vf_weave.c. Please review. > > Patch applied. > Thanks! > Thank you, Carl Eugen > ___ > ffmpeg-d

Re: [FFmpeg-devel] [PATCH] Refactor two near-identical clauses - take 2

2018-07-04 Thread Shlomi Fish
Hi, On Wed, 4 Jul 2018 18:45:09 +0200 Carl Eugen Hoyos wrote: > 2018-06-28 10:52 GMT+02:00, Shlomi Fish : > > > Attached is the 2nd take of the patch for vf_weave.c. Please review. > > For future patches: > > > The changes contained in this patch are hereby placed under the Expat > > licenc

Re: [FFmpeg-devel] [RFC] New build system

2018-07-04 Thread Mathieu Duponchelle
On 07/04/2018 07:01 PM, Carl Eugen Hoyos wrote: > I don't understand: If everything is enabled and there are > no options to disable features, how did you (and other > people in favour of this change) measure performance? Everything is automatically enabled indeed, but most of the system checks a

Re: [FFmpeg-devel] [RFC] New build system

2018-07-04 Thread Carl Eugen Hoyos
2018-06-14 18:03 GMT+02:00, Josh de Kock : > - Exposing options, for now everything is automatically enabled I don't understand: If everything is enabled and there are no options to disable features, how did you (and other people in favour of this change) measure performance? Carl Eugen

Re: [FFmpeg-devel] [PATCH] Refactor two near-identical clauses - take 2

2018-07-04 Thread Carl Eugen Hoyos
2018-06-28 10:52 GMT+02:00, Shlomi Fish : > Attached is the 2nd take of the patch for vf_weave.c. Please review. Patch applied. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] Adds ESPCN super resolution filter merged with SRCNN filter.

2018-07-04 Thread Jean-Baptiste Kempf
Hello, On Wed, 4 Jul 2018, at 16:19, Pedro Arthur wrote: > 2018-07-04 4:03 GMT-03:00 Jean-Baptiste Kempf : > > On Wed, 4 Jul 2018, at 01:22, Carl Eugen Hoyos wrote: > >> 2018-07-04 0:14 GMT+02:00, Jean-Baptiste Kempf : > >> > On Tue, 3 Jul 2018, at 20:59, Carl Eugen Hoyos wrote: > >> >> How is thi

Re: [FFmpeg-devel] [FFmpeg-cvslog] Adds ESPCN super resolution filter merged with SRCNN filter.

2018-07-04 Thread Jean-Baptiste Kempf
Hello, On Wed, 4 Jul 2018, at 18:42, Carl Eugen Hoyos wrote: > > The point is: you can recreate all of those arrays. > > I believe the only way to recreate (some of) the > arrays in libavcodec/*data* is to look into old > FFmpeg sources but I apparently misunderstand > you, sorry. > > I always t

Re: [FFmpeg-devel] [PATCH] Refactor two near-identical clauses - take 2

2018-07-04 Thread Carl Eugen Hoyos
2018-06-28 10:52 GMT+02:00, Shlomi Fish : > Attached is the 2nd take of the patch for vf_weave.c. Please review. For future patches: > The changes contained in this patch are hereby placed under the Expat licence. If you add a new file (like a new filter or decoder) please feel free to use the

Re: [FFmpeg-devel] [FFmpeg-cvslog] Adds ESPCN super resolution filter merged with SRCNN filter.

2018-07-04 Thread Carl Eugen Hoyos
2018-07-04 9:03 GMT+02:00, Jean-Baptiste Kempf : > On Wed, 4 Jul 2018, at 01:22, Carl Eugen Hoyos wrote: >> 2018-07-04 0:14 GMT+02:00, Jean-Baptiste Kempf : >> > On Tue, 3 Jul 2018, at 20:59, Carl Eugen Hoyos wrote: >> >> How is this case different from many arrays in libavcodec/*data*? >> > >> > I

Re: [FFmpeg-devel] [FFmpeg-cvslog] Adds ESPCN super resolution filter merged with SRCNN filter.

2018-07-04 Thread Paul B Mahol
On 7/4/18, Jean-Baptiste Kempf wrote: > On Tue, 3 Jul 2018, at 20:59, Carl Eugen Hoyos wrote: >> How is this case different from many arrays in libavcodec/*data*? > > It is very different: the arrays in *data* come either from a mathematical > computation or a spec. > > Else, as some Debian Develo

Re: [FFmpeg-devel] [PATCH] Refactor two near-identical clauses - take 2

2018-07-04 Thread Paul B Mahol
On 7/4/18, Shlomi Fish wrote: > On Thu, 28 Jun 2018 11:52:10 +0300 > Shlomi Fish wrote: > >> Hi all! >> >> Attached is the 2nd take of the patch for vf_weave.c. Please review. >> > > Ping. If expat license is compatible with LGPL that it is ok for merge. Otherwise it should not be committed. __

Re: [FFmpeg-devel] [RFC] New build system

2018-07-04 Thread Mathieu Duponchelle
Hey $list, not an FFmpeg developer, but I worked on the meson port and figured I could address some of the points that were made. Since the initial post I have also added support for compiling with Msys/MingW on Window now in addition to MSVC. ## Performance comparison A significant part of the

Re: [FFmpeg-devel] [FFmpeg-cvslog] Adds ESPCN super resolution filter merged with SRCNN filter.

2018-07-04 Thread Pedro Arthur
2018-07-04 4:03 GMT-03:00 Jean-Baptiste Kempf : > On Wed, 4 Jul 2018, at 01:22, Carl Eugen Hoyos wrote: >> 2018-07-04 0:14 GMT+02:00, Jean-Baptiste Kempf : >> > On Tue, 3 Jul 2018, at 20:59, Carl Eugen Hoyos wrote: >> >> How is this case different from many arrays in libavcodec/*data*? >> > >> > It

[FFmpeg-devel] [PATCH] avutil/hwcontext_qsv: fix log level for session initialization error

2018-07-04 Thread Moritz Barsnick
While the error is not fatal, the message should not be displayed only in verbose logging, as its consequences are of interest. Also fix message formatting (missing space). Signed-off-by: Moritz Barsnick --- Ideally, the returned mfxStatus would be evaluated and printed, but no such function is

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/videotoolboxenc: fix undefined behavior with rc_max_rate=0

2018-07-04 Thread Thomas Guillem
On Wed, Jul 4, 2018, at 09:05, Thomas Guillem wrote: > On macOS, a zero rc_max_rate cause an error from > VTSessionSetProperty(kVTCompressionPropertyKey_DataRateLimits). > > on iOS (depending on device/version), a zero rc_max_rate cause invalid > arguments from the vtenc_output_callback after few

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/truemotion2: Check len in tm2_read_stream()

2018-07-04 Thread Michael Niedermayer
On Mon, Jul 02, 2018 at 02:10:44AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 8774/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-5942199639343104 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: Remove use of FF_PROFILE_MPEG4_SIMPLE_STUDIO as indicator of studio profile

2018-07-04 Thread Michael Niedermayer
On Tue, Jul 03, 2018 at 01:08:58AM +0200, Michael Niedermayer wrote: > The profile field is changed by code inside and outside the decoder, > its not a reliable indicator of the internal codec state. > Maintaining it consistency with studio_profile is messy. > Its easier to just avoid it and use on

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/utils: report insane channel count errors

2018-07-04 Thread Michael Niedermayer
On Tue, Jul 03, 2018 at 12:51:11PM +0200, Marton Balint wrote: > More than 64 is not *that* insane, so let's report the error at least. > > Signed-off-by: Marton Balint > --- > libavcodec/utils.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c >

Re: [FFmpeg-devel] [PATCH] Refactor two near-identical clauses - take 2

2018-07-04 Thread Shlomi Fish
On Thu, 28 Jun 2018 11:52:10 +0300 Shlomi Fish wrote: > Hi all! > > Attached is the 2nd take of the patch for vf_weave.c. Please review. > Ping. -- - Shlomi Fish http://www.shlomifish.org/ My Aphorisms - http://www.shlomif

Re: [FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

2018-07-04 Thread Karsten Otto
> Am 04.07.2018 um 03:26 schrieb Michael Niedermayer : > > Signierter PGP-Teil > On Tue, Jul 03, 2018 at 10:25:36PM +0200, Karsten Otto wrote: >> TL;DR: I will drop patch 3/3, may rather spend some time investigating why >> "ff ee 47 9d“ passes the mp3 header parser. Also, the aa file "index" can

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: fix undefined behavior with rc_max_rate=0

2018-07-04 Thread Thomas Guillem
On Tue, Jul 3, 2018, at 20:53, Carl Eugen Hoyos wrote: > 2018-07-03 17:05 GMT+02:00, Thomas Guillem : > > On macOS, a zero rc_max_rate cause an error from > > VTSessionSetProperty(kVTCompressionPropertyKey_DataRateLimits). > > > > on iOS (depending on device/version), a zero rc_max_rate cause inva

[FFmpeg-devel] [PATCH 2/2] avcodec/videotoolboxenc: reindent after previous commit

2018-07-04 Thread Thomas Guillem
--- libavcodec/videotoolboxenc.c | 72 ++-- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index aa9aae7e05..050e5cefee 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videotoolb

[FFmpeg-devel] [PATCH 1/2] avcodec/videotoolboxenc: fix undefined behavior with rc_max_rate=0

2018-07-04 Thread Thomas Guillem
On macOS, a zero rc_max_rate cause an error from VTSessionSetProperty(kVTCompressionPropertyKey_DataRateLimits). on iOS (depending on device/version), a zero rc_max_rate cause invalid arguments from the vtenc_output_callback after few frames and then a crash within the VideoToolbox library. --- l

Re: [FFmpeg-devel] [PATCH] lavfi/minterpolate: fix blending calc issue.

2018-07-04 Thread myp...@gmail.com
On Wed, Jun 27, 2018 at 5:52 PM Jun Zhao wrote: > > the right blending calc is: > (alpha * Frame_2 + (MAX - alpha) * Frame_1 + 512) >> 10 > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_minterpolate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vf_

Re: [FFmpeg-devel] [FFmpeg-cvslog] Adds ESPCN super resolution filter merged with SRCNN filter.

2018-07-04 Thread Jean-Baptiste Kempf
On Wed, 4 Jul 2018, at 01:22, Carl Eugen Hoyos wrote: > 2018-07-04 0:14 GMT+02:00, Jean-Baptiste Kempf : > > On Tue, 3 Jul 2018, at 20:59, Carl Eugen Hoyos wrote: > >> How is this case different from many arrays in libavcodec/*data*? > > > > It is very different: the arrays in *data* come either fr