Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: Check in decode_tiles() if there is data remaining

2018-08-10 Thread Ronald S. Bultje
Hi, On Fri, Aug 10, 2018 at 6:54 PM, Michael Niedermayer wrote: > On Fri, Aug 10, 2018 at 02:16:56AM -0400, Ronald S. Bultje wrote: > > My objection: > > if a file has exactly symbols of 8 bits in arithdata, then after all > this, > > the arithcoder will signal empty and EOF, even though no

Re: [FFmpeg-devel] [GSoC] FFserver libmicrohttpd interface

2018-08-10 Thread Michael Niedermayer
On Thu, Aug 09, 2018 at 02:46:59PM +0200, Stephan Holljes wrote: > On Thu, Aug 2, 2018 at 1:00 AM, Stephan Holljes > wrote: > > After fighting for a bit too long, I am finally submitting this patch series > > that adds the more mature libmicrohttpd library. Client disconnect detection > > is not

Re: [FFmpeg-devel] [PATCH 4/7] Adds gray floating-point pixel formats.

2018-08-10 Thread Michael Niedermayer
On Thu, Aug 09, 2018 at 08:15:16PM +0300, Sergey Lavrushkin wrote: > Here are updated patches with fixes. I updated conversion functions, so > they should > properly work with format for different endianness. > > 2018-08-08 1:47 GMT+03:00 Michael Niedermayer : > > > On Tue, Aug 07, 2018 at

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Set start_time for all sterams (in case of edit lists).

2018-08-10 Thread Michael Niedermayer
On Thu, Aug 09, 2018 at 08:48:46AM -0700, Sasi Inguva wrote: > Thanks. Attaching the corrected patch > > > On Thu, Aug 9, 2018 at 5:59 AM Moritz Barsnick wrote: > > > > [PATCH] lavf/mov.c: Set start_time for all sterams (in case of edit > > lists). > >

Re: [FFmpeg-devel] [PATCH] libavformat/dashdec: Support negative value of the @r attrbute of S in SegmentTimeline element

2018-08-10 Thread sanilraut
Thanks Moritz. I have re-submitted the patch. Sanil On Wed, Aug 8, 2018 at 1:04 AM, Moritz Barsnick wrote: > On Mon, Aug 06, 2018 at 19:18:27 -0700, sanil wrote: > > The following patch supports parsing negative value of the @r attribute > of S in SegmentTimeline element. > > > > Example

[FFmpeg-devel] [PATCH v2] libavformat/dashdec: Support negative value of the @r attrbute of S in SegmentTimeline element.

2018-08-10 Thread sanil
Hi, The following patch supports parsing negative value of the @r attribute of S in SegmentTimeline element. Example streams: 1. http://dash.edgesuite.net/dash264/TestCases/1c/qualcomm/1/MultiRate.mpd 2. http://dash.edgesuite.net/dash264/TestCases/1c/qualcomm/2/MultiRate.mpd ---

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/dxtory: Remove code that corrupts dimensions

2018-08-10 Thread Michael Niedermayer
On Fri, Aug 10, 2018 at 09:05:42AM +0200, Paul B Mahol wrote: > On 2/20/18, Michael Niedermayer wrote: > > On Sat, Feb 17, 2018 at 10:25:10PM +0100, Michael Niedermayer wrote: > >> Fixes: Timeout > >> Fixes: 5796/clusterfuzz-testcase-minimized-5206729085157376 > >> > >> Does someone have a valid

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: Check in decode_tiles() if there is data remaining

2018-08-10 Thread Michael Niedermayer
On Fri, Aug 10, 2018 at 02:16:56AM -0400, Ronald S. Bultje wrote: > Hi Michael, > > On Thu, Aug 9, 2018 at 8:49 PM, Michael Niedermayer > wrote: > > > On Wed, Aug 08, 2018 at 10:00:42PM -0300, James Almer wrote: > > > > Apply this patch with changes to allow that specific condition and lets > >

[FFmpeg-devel] [PATCH] lavfi/avf_concat: switch to activate.

2018-08-10 Thread Nicolas George
Fix trac ticket #7351. Signed-off-by: Nicolas George --- libavfilter/avf_concat.c | 156 +++ 1 file changed, 78 insertions(+), 78 deletions(-) diff --git a/libavfilter/avf_concat.c b/libavfilter/avf_concat.c index 46bd42359b..1d0c2de290 100644 ---

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: Fix compilation on osx 10.10.5 Yosemite

2018-08-10 Thread Aman Gupta
LGTM, will commit in a few days. Aman On Thu, Aug 9, 2018 at 4:56 AM Thilo Borgmann wrote: > $Subject > > -Thilo > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-10 Thread Kyle Swanson
Hi, > On Aug 9, 2018, at 10:10 AM, Kyle Swanson wrote: > > Hi, > >> On Tue, Aug 7, 2018 at 3:37 PM, Kyle Swanson wrote: >> From: Kyle Swanson >> >> Signed-off-by: Kyle Swanson >> --- >> configure| 2 +- >> libavfilter/vf_libvmaf.c | 9 - >> 2 files changed, 9

Re: [FFmpeg-devel] [PATCH] lavfi: add erosion_opencl, dilation_opencl filters

2018-08-10 Thread Michael Niedermayer
On Thu, Aug 09, 2018 at 05:41:53AM +0300, Danil Iashchenko wrote: > Add erosion_opencl, dilation_opencl filters. Behave like existing erosion and > dilation filters. > --- > > Thanks! Fixed. fix confirmed thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH 4/7] Adds gray floating-point pixel formats.

2018-08-10 Thread Michael Niedermayer
On Thu, Aug 09, 2018 at 08:15:16PM +0300, Sergey Lavrushkin wrote: > Here are updated patches with fixes. I updated conversion functions, so > they should > properly work with format for different endianness. [...] > diff --git a/libswscale/input.c b/libswscale/input.c > index

Re: [FFmpeg-devel] [PATCH V2] lavc/qsvenc: add quality status to side_data

2018-08-10 Thread James Almer
On 8/10/2018 5:10 AM, Zhong Li wrote: > Add fix a memory leak issue as James's comments. > > V2: use a local pict_type since coded_frame is deprecated. > > Signed-off-by: Zhong Li > --- > libavcodec/qsvenc.c | 32 ++-- > libavcodec/qsvenc.h | 2 -- >

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-10 Thread Ronak Patel
On Aug 10, 2018, at 7:30 AM, Liu Steven wrote: >>> >>> Hi Steven, >>> >>> Please see my new patch taking your feedback into account. >>> >>> Ronak >> >> Hi Steven, >> >> Did you have a chance to review? I’m going to send you a new patch for >> dashenc.c shortly. > Don’t worry, i

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-10 Thread Liu Steven
>>> >> >> Hi Steven, >> >> Please see my new patch taking your feedback into account. >> >> Ronak > > Hi Steven, > > Did you have a chance to review? I’m going to send you a new patch for > dashenc.c shortly. Don’t worry, i will review it weekend, but i think your ways is not a better way,

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-10 Thread Ronak Patel
> On Aug 8, 2018, at 5:37 PM, Ronak wrote: > > > >> On Aug 8, 2018, at 3:52 PM, Ronak wrote: >> >> >> >>> On Aug 6, 2018, at 10:20 AM, Steven Liu wrote: >>> >>> >>> > On Aug 6, 2018, at 19:29, Ronak Patel > wrote: > > > On Aug 6, 2018, at 7:19 AM, Liu Steven

Re: [FFmpeg-devel] [PATCH] Fix heap buffer overflow in ff_combine_frame

2018-08-10 Thread Baozeng
Sorry. I do not understand the API. I will learn it later. Thank you. 2018-08-10 17:24 GMT+08:00 Hendrik Leppkes : > On Fri, Aug 10, 2018 at 10:41 AM Baozeng wrote: > > > > I do not agree with you. We cannot trust any user input. > > > > The API requires this, if this is not fullfilled then the

Re: [FFmpeg-devel] [PATCH] Fix heap buffer overflow in ff_combine_frame

2018-08-10 Thread Hendrik Leppkes
On Fri, Aug 10, 2018 at 10:41 AM Baozeng wrote: > > I do not agree with you. We cannot trust any user input. > The API requires this, if this is not fullfilled then the user application is buggy, not avcodec. PS: Please don't top post on this ML. - Hendrik

Re: [FFmpeg-devel] [PATCH] Fix heap buffer overflow in ff_combine_frame

2018-08-10 Thread Baozeng
I do not agree with you. We cannot trust any user input. 2018-06-27 1:29 GMT+08:00 Michael Niedermayer : > On Tue, Jun 26, 2018 at 07:02:38PM +0800, Baozeng Ding wrote: > > Signed-off-by: Baozeng Ding > > --- > > libavcodec/parser.c | 10 +++--- > > 1 file changed, 7 insertions(+), 3

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: add quality status to side_data

2018-08-10 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of James Almer > Sent: Wednesday, August 8, 2018 11:08 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: add quality status to > side_data > > On 8/8/2018 11:51 AM, Zhong Li wrote: > > Add

[FFmpeg-devel] [PATCH V2] lavc/qsvenc: add quality status to side_data

2018-08-10 Thread Zhong Li
Add fix a memory leak issue as James's comments. V2: use a local pict_type since coded_frame is deprecated. Signed-off-by: Zhong Li --- libavcodec/qsvenc.c | 32 ++-- libavcodec/qsvenc.h | 2 -- libavcodec/qsvenc_h264.c | 5 - 3 files changed, 22

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/dxtory: Remove code that corrupts dimensions

2018-08-10 Thread Paul B Mahol
On 2/20/18, Michael Niedermayer wrote: > On Sat, Feb 17, 2018 at 10:25:10PM +0100, Michael Niedermayer wrote: >> Fixes: Timeout >> Fixes: 5796/clusterfuzz-testcase-minimized-5206729085157376 >> >> Does someone have a valid sample that triggers this path ? >> >> Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: Check in decode_tiles() if there is data remaining

2018-08-10 Thread Ronald S. Bultje
Hi Michael, On Thu, Aug 9, 2018 at 8:49 PM, Michael Niedermayer wrote: > On Wed, Aug 08, 2018 at 10:00:42PM -0300, James Almer wrote: > > Apply this patch with changes to allow that specific condition and lets > > not waste more time on this. > > this is the only change the patch does. Without