Re: [FFmpeg-devel] [PATCH 7/7] doc/protocols: simplify and clarify UDP localaddr option

2018-09-22 Thread Gyan
On Sun, Sep 23, 2018 at 3:24 AM Marton Balint wrote: > Signed-off-by: Marton Balint > --- > doc/protocols.texi | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/doc/protocols.texi b/doc/protocols.texi > index 7173bb173a..b34f29eebf 100644 > --- a/doc/protocols.texi >

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add SStP FATE test

2018-09-22 Thread Michael Niedermayer
On Sat, Sep 22, 2018 at 03:14:27PM +0200, Kieran Kunhya wrote: > > fate/mpeg4.mak|4 +++- > ref/fate/m4v-sstp |6 ++ > 2 files changed, 9 insertions(+), 1 deletion(-) > d37202c7163298be91a39bc93eb7cd04296d277a > 0001-mpeg4video-Add-SStP-FATE-test.patch > From 111d5f320d06dc9318

[FFmpeg-devel] [PATCH 6/7] avformat/udp: always use IP_ADD_SOURCE_MEMBERSHIP for subscribing to an UDP multicast source group in IPv4

2018-09-22 Thread Marton Balint
That alone supports specifying the interface based on its address. Getting the interface index from the local address seems quite a bit of work in a platform independent way... Obviously for IPv6 we still always use MCAST_JOIN_SOURCE_GROUP. Signed-off-by: Marton Balint --- libavformat/udp.c | 5

[FFmpeg-devel] [PATCH 5/7] avformat/udp: specify the local address for some source filtered multicast joins

2018-09-22 Thread Marton Balint
We already use localaddr for the multicast joins without source filters, so we should use them for source filters as well. This patch only fixes the IP_ADD_SOURCE_MEMBERSHIP and the IP_BLOCK_SOURCE case. Unless we do this, the kernel automatically selects an interface based on the source address,

[FFmpeg-devel] [PATCH 7/7] doc/protocols: simplify and clarify UDP localaddr option

2018-09-22 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/protocols.texi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 7173bb173a..b34f29eebf 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -1544,9 +1544,8 @@ packet bursts. Override

[FFmpeg-devel] [PATCH 4/7] avformat/udp: add support for generic source filtering

2018-09-22 Thread Marton Balint
This allows getting data only from a specific source IP. This is useful not only for unicast but for multicast as well because multicast source subscriptions do not act as source filters for the incoming packets. Signed-off-by: Marton Balint --- doc/protocols.texi | 8 libavformat/udp.

[FFmpeg-devel] [PATCH 3/7] avformat/rtpproto: use factorized ip functions

2018-09-22 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/Makefile | 2 +- libavformat/rtpproto.c | 126 - 2 files changed, 11 insertions(+), 117 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index 467ae2d87e..e0222535c1 100644 --- a

[FFmpeg-devel] [PATCH 1/7] avformat/ip: factorize some IP filtering and resolving functions to a new file

2018-09-22 Thread Marton Balint
These are based on the very similar UDP and RTP protocol functions. Signed-off-by: Marton Balint --- libavformat/ip.c | 165 +++ libavformat/ip.h | 74 + 2 files changed, 239 insertions(+) create mode 100644 libavforma

[FFmpeg-devel] [PATCH 2/7] avformat/udp: use factorized ip functions

2018-09-22 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/Makefile | 4 +- libavformat/udp.c| 123 +-- 2 files changed, 23 insertions(+), 104 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index ccb39b5469..467ae2d87e 100644 --- a/l

Re: [FFmpeg-devel] [PATCH 01/11] avcodec/prosumer: Remove dead code

2018-09-22 Thread Michael Niedermayer
On Sat, Sep 22, 2018 at 06:24:14PM +0200, Paul B Mahol wrote: > On 9/22/18, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/prosumer.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/libavcodec/prosumer.c b/libavcodec/prosumer.c > > index

Re: [FFmpeg-devel] [PATCH 1/4] avformat/ip: factorize some IP filtering and resolving functions to a new file

2018-09-22 Thread Marton Balint
On Sat, 22 Sep 2018, Michael Niedermayer wrote: On Fri, Sep 21, 2018 at 12:11:59AM +0200, Marton Balint wrote: These are based on the very similar UDP and RTP protocol functions. Signed-off-by: Marton Balint [...] Thanks, I will resubmit the patch series with some extra docs. [...] +

[FFmpeg-devel] cache: read ahead to avoid excessive small requests

2018-09-22 Thread Robert Nagy
*diff --git a/libavformat/cache.c b/libavformat/cache.c* *index 66bbbf54c9..48ff5ab363 100644* *--- a/libavformat/cache.c* *+++ b/libavformat/cache.c* @@ -153,6 +153,38 @@ fail: return ret; } +static int cache_read_ahead(URLContext *h) +{ +Context *c= h->priv_data; +int64_

Re: [FFmpeg-devel] cache: read ahead to avoid excessive small requests

2018-09-22 Thread Robert Nagy
diff --git a/libavformat/cache.c b/libavformat/cache.c index 66bbbf54c9..48ff5ab363 100644 --- a/libavformat/cache.c +++ b/libavformat/cache.c @@ -153,6 +153,38 @@ fail: return ret; } +static int cache_read_ahead(URLContext *h) +{ +Context *c= h->priv_data; +int64_t r, read_ahead, po

Re: [FFmpeg-devel] [PATCH] cache: read_buf_size

2018-09-22 Thread Robert Nagy
Ignore this patch. I created a new one with a simpler and more appropriate implementation. On Sat, Sep 22, 2018 at 6:22 PM Michael Niedermayer wrote: > On Sat, Sep 22, 2018 at 12:16:10PM +0200, Robert Nagy wrote: > > This adds a `read_buf_size` option which can help avoid excessive seeking > > w

Re: [FFmpeg-devel] [PATCH 01/11] avcodec/prosumer: Remove dead code

2018-09-22 Thread Paul B Mahol
On 9/22/18, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/prosumer.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/libavcodec/prosumer.c b/libavcodec/prosumer.c > index a2932852c9..e6959bfb6c 100644 > --- a/libavcodec/prosumer.c > +++ b/libavcode

Re: [FFmpeg-devel] [PATCH] libavformat/segment: strftime date sub-directories

2018-09-22 Thread Michael Niedermayer
On Thu, Nov 30, 2017 at 11:07:03PM +, James Courtier-Dutton wrote: > > segment.c | 48 > 1 file changed, 48 insertions(+) > e3e9961df186f73adb24f7a334d398884e894d53 > 0001-libavformat-segment-strftime-date-sub-directories.patch > From b6a6

Re: [FFmpeg-devel] [PATCH] cache: read_buf_size

2018-09-22 Thread Michael Niedermayer
On Sat, Sep 22, 2018 at 12:16:10PM +0200, Robert Nagy wrote: > This adds a `read_buf_size` option which can help avoid excessive seeking > when a file has e.g. badly interleaved audio and video. > > > --- > > libavformat/cache.c | 69 + > > 1 file ch

[FFmpeg-devel] [PATCH 04/11] avcodec/prosumer: Use 16bit instead of 32 for table

2018-09-22 Thread Michael Niedermayer
Simplifies code and reduces needed memory Signed-off-by: Michael Niedermayer --- libavcodec/prosumer.c | 168 +- 1 file changed, 84 insertions(+), 84 deletions(-) diff --git a/libavcodec/prosumer.c b/libavcodec/prosumer.c index 46031aa0c0..399350031a 1006

[FFmpeg-devel] [PATCH 11/11] avcodec/prosumer: Check remaining space in put byte context

2018-09-22 Thread Michael Niedermayer
Fixes: Timeout Fixes: 10053/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PROSUMER_fuzzer-5636993883570176 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/prosumer.c | 2 ++ 1 file changed

[FFmpeg-devel] [PATCH 10/11] avcodec/prosumer: Remove unused table element

2018-09-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/prosumer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/prosumer.c b/libavcodec/prosumer.c index 0fa0109950..2420dd5f12 100644 --- a/libavcodec/prosumer.c +++ b/libavcodec/prosumer.c @@ -274,7 +274,6 @@ static const uint16_t table

[FFmpeg-devel] [PATCH 05/11] avcodec/prosumer: factorize e0 setting out

2018-09-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/prosumer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/prosumer.c b/libavcodec/prosumer.c index 399350031a..9e8a94d4db 100644 --- a/libavcodec/prosumer.c +++ b/libavcodec/prosumer.c @@ -290,14 +290,13 @@ static

[FFmpeg-devel] [PATCH 08/11] avcodec/prosumer: Rename do_shift() to vertical_predict()

2018-09-22 Thread Michael Niedermayer
It seems what this function does is a vertical prediction filter, thus the new name should improve understanding. rename the related table_b too Signed-off-by: Michael Niedermayer --- libavcodec/prosumer.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/liba

[FFmpeg-devel] [PATCH 09/11] avcodec/prosumer: remove unneeded variable from vertical_predict

2018-09-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/prosumer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/prosumer.c b/libavcodec/prosumer.c index 575b00baca..0fa0109950 100644 --- a/libavcodec/prosumer.c +++ b/libavcodec/prosumer.c @@ -134,13 +134,11 @@ stati

[FFmpeg-devel] [PATCH 06/11] avcodec/prosumer: Only scan as many elements as matter in fill_elements()

2018-09-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/prosumer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/prosumer.c b/libavcodec/prosumer.c index 9e8a94d4db..b7e417aa0b 100644 --- a/libavcodec/prosumer.c +++ b/libavcodec/prosumer.c @@ -279,12 +279,12 @@ st

[FFmpeg-devel] [PATCH 01/11] avcodec/prosumer: Remove dead code

2018-09-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/prosumer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/prosumer.c b/libavcodec/prosumer.c index a2932852c9..e6959bfb6c 100644 --- a/libavcodec/prosumer.c +++ b/libavcodec/prosumer.c @@ -322,9 +322,6 @@ static void fill_lut(uin

[FFmpeg-devel] [PATCH 02/11] avcodec/prosumer: clean up loop end code in fill_elements()

2018-09-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/prosumer.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/libavcodec/prosumer.c b/libavcodec/prosumer.c index e6959bfb6c..cf2a4afbf6 100644 --- a/libavcodec/prosumer.c +++ b/libavcodec/prosumer.c @@ -280,36

[FFmpeg-devel] [PATCH 07/11] avcodec/prosumer: mark src as const

2018-09-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/prosumer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/prosumer.c b/libavcodec/prosumer.c index b7e417aa0b..9eb3c18cae 100644 --- a/libavcodec/prosumer.c +++ b/libavcodec/prosumer.c @@ -132,7 +132,7 @@ static

[FFmpeg-devel] [PATCH 03/11] avcodec/prosumer: Factorize the 2 loops in fill_elements()

2018-09-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/prosumer.c | 41 ++--- 1 file changed, 18 insertions(+), 23 deletions(-) diff --git a/libavcodec/prosumer.c b/libavcodec/prosumer.c index cf2a4afbf6..46031aa0c0 100644 --- a/libavcodec/prosumer.c +++ b/libavcod

Re: [FFmpeg-devel] fate/mov : use do_md5sum for mov-faststart-4gb-overflow test

2018-09-22 Thread Martin Vignali
Le ven. 21 sept. 2018 à 05:17, James Almer a écrit : > > > Should be ok. > > Pushed, Thanks Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] mpeg4video: Add SStP FATE test

2018-09-22 Thread Kieran Kunhya
0001-mpeg4video-Add-SStP-FATE-test.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avcodec/unary: Improve get_unary() docs

2018-09-22 Thread Michael Niedermayer
Found-by: kierank Signed-off-by: Michael Niedermayer --- libavcodec/unary.h | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/libavcodec/unary.h b/libavcodec/unary.h index 908dc93507..d57f9f70c5 100644 --- a/libavcodec/unary.h +++ b/libavcodec/unary.h @@ -28,7 +2

[FFmpeg-devel] [PATCH] avfilter: add afftdn filter

2018-09-22 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- configure|3 + doc/filters.texi | 47 ++ libavfilter/Makefile |1 + libavfilter/af_afftdn.c | 1309 ++ libavfilter/allfilters.c |1 + 5 files changed, 1361 insertions(+) create mode 100

[FFmpeg-devel] Patch to add automatic file splitting when recording.

2018-09-22 Thread James Courtier-Dutton
Hi, Please can someone consider adding this patch to ffmpeg. I find it useful, for example to record from a CCTV camera and have it automatically split the stream into 10 minute files, storing them and automatically creating subdirectories by date. The patch is already here: https://patchwork.ffm

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: add support for selecting devices based on their unique ID

2018-09-22 Thread Jeyapal, Karthick
On 9/21/18 5:10 PM, Marton Balint wrote: > > > On Fri, 21 Sep 2018, Jeyapal, Karthick wrote: > >> >> On 9/21/18 3:35 AM, Marton Balint wrote: >>> Also bump the API version requirement to 10.9.5, because on olders versions >>> there were some reports of crashes using the undocumented, yet available

[FFmpeg-devel] [PATCH] cache: read_buf_size

2018-09-22 Thread Robert Nagy
This adds a `read_buf_size` option which can help avoid excessive seeking when a file has e.g. badly interleaved audio and video. --- libavformat/cache.c | 69 + 1 file changed, 57 insertions(+), 12 deletions(-) diff --git a/libavformat/cache.c b/l