Re: [FFmpeg-devel] [PATCH 2/2] avformat/hlsenc : Added an option to ignore IO errors

2018-12-07 Thread Steven Liu
> 在 2018年12月7日,下午12:49,Karthick J 写道: > > Useful for long duration runs with network output > --- > doc/muxers.texi | 3 +++ > libavformat/hlsenc.c | 41 +++-- > 2 files changed, 34 insertions(+), 10 deletions(-) > > diff --git a/doc/muxers.texi

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Skip DWT if nothing is coded

2018-12-07 Thread Michael Niedermayer
On Sun, Dec 02, 2018 at 03:22:28AM +0100, Michael Niedermayer wrote: > Improves speed in uncommon case > > Fixes: Timeout > Fixes: > 10964/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5132066034286592 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/dxv: Check that there is enough data to decompress

2018-12-07 Thread Michael Niedermayer
On Sat, Dec 01, 2018 at 10:16:20PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 10979/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DXV_fuzzer-6178582203203584 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH] libavcodec/zmbvenc.c: don't allow motion estimation out of range.

2018-12-07 Thread Matthew Fearnley
Hi Tomas, thanks for looking through my patch. > > Practically, this patch fixes graphical glitches e.g. when reencoding the > > Commander Keen sample video with me_range 65 or higher: > > > > ffmpeg -i keen4e_000.avi -c:v zmbv -me_range 65 keen4e_me65.avi > I'd expect this problem to pop up

Re: [FFmpeg-devel] [PATCH] libstr.c: Fixed rendezvous mode

2018-12-07 Thread Marton Balint
On Fri, 7 Dec 2018, Moritz Barsnick wrote: On Fri, Dec 07, 2018 at 14:01:03 +, Adrian Grzeca wrote: Please read the coding guidelines here: https://www.ffmpeg.org/developer.html#Coding-Rules-1 Your indentation is incorrect, incl. use of tabs, which is not supported in the ffmpeg code

[FFmpeg-devel] [PATCH 3/3] avformat/mov: Simplify get_stream_info_time()

2018-12-07 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index ec57a05803..878e8a3ab2 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -1234,16 +1234,12 @@ static

[FFmpeg-devel] [PATCH 1/3] avformat/mpegts: Fix side data type for stream id

2018-12-07 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/mpegts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index edf6b5701d..a5e850e121 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -918,7 +918,7 @@ static void

[FFmpeg-devel] [PATCH 2/3] avcodec/avcodec: Document the data type for AV_PKT_DATA_MPEGTS_STREAM_ID

2018-12-07 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/avcodec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 3922e89331..fd7f60bf4a 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -1328,7 +1328,7 @@ enum

[FFmpeg-devel] [PATCH] avformat/mxfenc: calculate and store DAR from user SAR

2018-12-07 Thread Paul B Mahol
Fixes #5155 Signed-off-by: Paul B Mahol --- libavformat/mxfenc.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index 3549b4137d..8f762c7eaf 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -2726,6 +2726,14 @@ static int

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-07 Thread Jan Ekström
On Wed, Dec 5, 2018 at 7:13 PM Jan Ekström wrote: > > On Mon, Dec 3, 2018 at 3:19 AM Jan Ekström wrote: > > > > From: Rodger Combs > > > > These are registered identifiers at the MPEG-4 RA, which are > > defined as to be utilized for Dolby Vision AVC/HEVC streams that > > are not correctly

Re: [FFmpeg-devel] [PATCH] avcodec/h264_refs: reset MMCO when invalid mmco code is found

2018-12-07 Thread Paul B Mahol
On 12/7/18, Michael Niedermayer wrote: > On Fri, Dec 07, 2018 at 10:36:23AM +0100, Paul B Mahol wrote: >> On 12/7/18, Paul B Mahol wrote: >> > On 12/7/18, Michael Niedermayer wrote: >> >> On Thu, Dec 06, 2018 at 03:26:41PM +0100, Paul B Mahol wrote: >> >>> This recovers state with #7374 linked

Re: [FFmpeg-devel] [PATCH] libstr.c: Fixed rendezvous mode

2018-12-07 Thread Moritz Barsnick
On Fri, Dec 07, 2018 at 14:01:03 +, Adrian Grzeca wrote: Please read the coding guidelines here: https://www.ffmpeg.org/developer.html#Coding-Rules-1 Your indentation is incorrect, incl. use of tabs, which is not supported in the ffmpeg code base. Also, your brackets and whitespace are

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-07 Thread Michael Niedermayer
On Fri, Dec 07, 2018 at 01:43:37PM +0100, Hendrik Leppkes wrote: > On Fri, Dec 7, 2018 at 1:15 PM Paul B Mahol wrote: > > > > On 12/7/18, Michael Niedermayer wrote: > > > On Fri, Dec 07, 2018 at 11:21:57AM +0100, Paul B Mahol wrote: > > >> On 12/7/18, Michael Niedermayer wrote: > > >> > On Fri,

Re: [FFmpeg-devel] [PATCH] avcodec/h264_refs: reset MMCO when invalid mmco code is found

2018-12-07 Thread Michael Niedermayer
On Fri, Dec 07, 2018 at 10:36:23AM +0100, Paul B Mahol wrote: > On 12/7/18, Paul B Mahol wrote: > > On 12/7/18, Michael Niedermayer wrote: > >> On Thu, Dec 06, 2018 at 03:26:41PM +0100, Paul B Mahol wrote: > >>> This recovers state with #7374 linked sample. > >>> > >>> Work funded by Open

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: set pict_type to be I for IDR frames.

2018-12-07 Thread Carl Eugen Hoyos
2018-12-07 10:25 GMT+01:00, Zhong Li : > Signed-off-by: Zhong Li > --- > libavcodec/qsvenc.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > index aa7f347..8289a32 100644 > --- a/libavcodec/qsvenc.c > +++

Re: [FFmpeg-devel] [PATCH, v3] lavc/qsvenc: replace assert with error return

2018-12-07 Thread Carl Eugen Hoyos
2018-12-07 11:14 GMT+01:00, Linjie Fu : > bs->FrameType is not set in MSDK in some cases (mjpeg encode for example), > and assert on a value coming from an external library is not proper. > > Add default type check for bs->FrameType, and return invalid data error in > function > ff_qsv_encode to

Re: [FFmpeg-devel] [PATCH V3 0/2] Add libsvt HEVC encoder wrapper

2018-12-07 Thread Carl Eugen Hoyos
2018-12-07 12:55 GMT+01:00, Jun Zhao : > More performance/quality data will be public as soon as quick. Please either: Revisit this patch once quality data showing advantages over exising (GPL) encoders of this new implementation are public. Or: Add the following to the commit message: This

[FFmpeg-devel] [PATCH] libstr.c: Fixed rendezvous mode

2018-12-07 Thread Adrian Grzeca
--- libavformat/libsrt.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index fe3b312151..fced18fb92 100644 --- a/libavformat/libsrt.c +++ b/libavformat/libsrt.c @@ -84,6 +84,8 @@ typedef struct

Re: [FFmpeg-devel] [PATCH] avcodec/h264_refs: reset MMCO when invalid mmco code is found

2018-12-07 Thread Carl Eugen Hoyos
2018-12-06 15:26 GMT+01:00, Paul B Mahol : > This recovers state with #7374 linked sample. > > Work funded by Open Broadcast Systems. > > Signed-off-by: Paul B Mahol > --- > libavcodec/h264_refs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/h264_refs.c

Re: [FFmpeg-devel] [PATCH] swscale/output: VSX-optimize nbps yuv2plane1

2018-12-07 Thread Lauri Kasanen
On Fri, 7 Dec 2018 13:50:12 +0100 Carl Eugen Hoyos wrote: > > Carl Eugen Hoyos wrote: > >> 2018-11-27 14:26 GMT+01:00, Lauri Kasanen : > >> > Fate passes, each format tested with an image to video conversion. > >> > > >> > Depends on "swscale/ppc: Move VSX-using code to its own file". > >> > >>

Re: [FFmpeg-devel] [PATCH V3 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2018-12-07 Thread Gyan Doshi
On 07-12-2018 05:26 PM, Jun Zhao wrote: +{"perset", "Encoding preset [0, 12] (e,g, for subjective quality tuning mode and >=4k resolution), [0, 10] (for >= 1080p resolution), [0, 9] (for all resolution and modes)", preset --> preset +static const AVCodecDefault eb_enc_defaults[] = { +

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-07 Thread Hendrik Leppkes
On Fri, Dec 7, 2018 at 1:15 PM Paul B Mahol wrote: > > On 12/7/18, Michael Niedermayer wrote: > > On Fri, Dec 07, 2018 at 11:21:57AM +0100, Paul B Mahol wrote: > >> On 12/7/18, Michael Niedermayer wrote: > >> > On Fri, Dec 07, 2018 at 10:28:09AM +0100, Paul B Mahol wrote: > >> >> On 12/7/18,

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/dpx: improve decoding of 10 bit gray images

2018-12-07 Thread Carl Eugen Hoyos
2018-12-06 20:34 GMT+01:00, Paul B Mahol : > +temp = *lbuf >> shift & 0x3FF; > +*lbuf = *lbuf >> 10; > + > +return temp; > +} > + > static uint16_t read10in32(const uint8_t **ptr, uint32_t * lbuf, >int * n_datum, int is_big, int shift) > { > @@

Re: [FFmpeg-devel] Fix for KLV in mpegts

2018-12-07 Thread Carl Eugen Hoyos
2018-12-07 13:27 GMT+01:00, Peter Ross : > On Fri, Dec 07, 2018 at 12:06:36PM +0200, Artyom Lebedev wrote: >> This fixes bug which prevents from proper muxing-in KLV stream into >> mpeg-ts. >> >> mpegtsenc.c:1526 >> >> char *side_data = NULL; >> int stream_id = -1; >> >> side_data =

Re: [FFmpeg-devel] [PATCH V3 2/2] doc: Add libsvt_hevc encoder docs

2018-12-07 Thread Gyan Doshi
You'll need to rebase as I just rearranged entries (and style, a bit) in doc/general On 07-12-2018 05:26 PM, Jun Zhao wrote: Signed-off-by: Jun Zhao Signed-off-by: Huang, Zhengxu Signed-off-by: hassene --- doc/encoders.texi | 98 +

Re: [FFmpeg-devel] Fix for KLV in mpegts

2018-12-07 Thread Peter Ross
On Fri, Dec 07, 2018 at 12:06:36PM +0200, Artyom Lebedev wrote: > This fixes bug which prevents from proper muxing-in KLV stream into mpeg-ts. > > mpegtsenc.c:1526 > >     char *side_data = NULL; >     int stream_id = -1; > >     side_data = av_packet_get_side_data(pkt, >

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-07 Thread Paul B Mahol
On 12/7/18, Michael Niedermayer wrote: > On Fri, Dec 07, 2018 at 11:21:57AM +0100, Paul B Mahol wrote: >> On 12/7/18, Michael Niedermayer wrote: >> > On Fri, Dec 07, 2018 at 10:28:09AM +0100, Paul B Mahol wrote: >> >> On 12/7/18, Michael Niedermayer wrote: >> >> > On Wed, Dec 05, 2018 at

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-07 Thread Michael Niedermayer
On Fri, Dec 07, 2018 at 11:21:57AM +0100, Paul B Mahol wrote: > On 12/7/18, Michael Niedermayer wrote: > > On Fri, Dec 07, 2018 at 10:28:09AM +0100, Paul B Mahol wrote: > >> On 12/7/18, Michael Niedermayer wrote: > >> > On Wed, Dec 05, 2018 at 09:22:48PM +0100, Paul B Mahol wrote: > >> >>

[FFmpeg-devel] [PATCH V3 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2018-12-07 Thread Jun Zhao
base on patch by Huang, Zhengxu from https://github.com/intel/SVT-HEVC Signed-off-by: Huang, Zhengxu Signed-off-by: hassene Signed-off-by: Jun Zhao --- Changelog|1 + configure|4 + libavcodec/Makefile |1 + libavcodec/allcodecs.c |1 +

[FFmpeg-devel] [PATCH V3 0/2] Add libsvt HEVC encoder wrapper

2018-12-07 Thread Jun Zhao
The Scalable Video Technology for HEVC Encoder (SVT-HEVC Encoder) is an HEVC-compliant encoder library core that achieves excellent density-quality tradeoffs, and is highly optimized for Intel Xeon Scalable Processor and Xeon D processors. Intel open source SVT-HEVC encoder in:

[FFmpeg-devel] [PATCH V3 2/2] doc: Add libsvt_hevc encoder docs

2018-12-07 Thread Jun Zhao
Signed-off-by: Jun Zhao Signed-off-by: Huang, Zhengxu Signed-off-by: hassene --- doc/encoders.texi | 98 + doc/general.texi |8 2 files changed, 106 insertions(+), 0 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi

Re: [FFmpeg-devel] [PATCH] lavc/hevc_parser: add 4 bytes startcode condition in hevc_find_frame_end

2018-12-07 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Michael Niedermayer > Sent: Friday, November 30, 2018 07:01 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] lavc/hevc_parser: add 4

[FFmpeg-devel] [PATCH, v2] lavc/hevc_parser: add 4 bytes startcode condition and update FATE

2018-12-07 Thread Linjie Fu
The startcode before VPS,SPS,PPS and the first NALU in an AU is 4 bytes. Blindly taking the startcode as 3 bytes will leave 0x00 in last packet and may lead to some warnings in parse_nal_units when s->flags is set to PARSER_FLAG_COMPLETE_FRAMES. Add 4 bytes startcode condition in

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/dpx: fix spotted code style issues

2018-12-07 Thread Paul B Mahol
On 12/6/18, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/dpx.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Will apply this patch set ASAP. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] avformat/mov.c: Fix infinite loop when fragments seek

2018-12-07 Thread Seokjin Hong
It will never escape this loop when moof has no sidx info Signed-off-by: Seokjin Hong --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index ec57a05803..b7b69e2772 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -1293,6

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-07 Thread Paul B Mahol
On 12/7/18, Michael Niedermayer wrote: > On Fri, Dec 07, 2018 at 10:28:09AM +0100, Paul B Mahol wrote: >> On 12/7/18, Michael Niedermayer wrote: >> > On Wed, Dec 05, 2018 at 09:22:48PM +0100, Paul B Mahol wrote: >> >> Signed-off-by: Paul B Mahol >> >> --- >> >> libavcodec/proresdec2.c | 51 >>

[FFmpeg-devel] [PATCH, v3] lavc/qsvenc: replace assert with error return

2018-12-07 Thread Linjie Fu
bs->FrameType is not set in MSDK in some cases (mjpeg encode for example), and assert on a value coming from an external library is not proper. Add default type check for bs->FrameType, and return invalid data error in function ff_qsv_encode to avoid using uninitialized value. Fix #7593.

[FFmpeg-devel] Fix for KLV in mpegts

2018-12-07 Thread Artyom Lebedev
This fixes bug which prevents from proper muxing-in KLV stream into mpeg-ts. mpegtsenc.c:1526     char *side_data = NULL;     int stream_id = -1;     side_data = av_packet_get_side_data(pkt, AV_PKT_DATA_MPEGTS_STREAM_ID,     _data_size);     if (side_data)   

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-07 Thread Michael Niedermayer
On Fri, Dec 07, 2018 at 10:28:09AM +0100, Paul B Mahol wrote: > On 12/7/18, Michael Niedermayer wrote: > > On Wed, Dec 05, 2018 at 09:22:48PM +0100, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol > >> --- > >> libavcodec/proresdec2.c | 51 ++--- > >> 1

Re: [FFmpeg-devel] [PATCH, v2] lavc/qsvenc: replace assert with error return

2018-12-07 Thread Li, Zhong
> > > Subject: [FFmpeg-devel] [PATCH, v2] lavc/qsvenc: replace assert with > > > error return > > > > > > bs->FrameType is not set in MSDK in some cases (mjpeg encode for > > > bs->example), > > > and assert on a value coming from an external library is not proper. > > > > > > Add default type

Re: [FFmpeg-devel] [PATCH] avcodec/h264_refs: reset MMCO when invalid mmco code is found

2018-12-07 Thread Paul B Mahol
On 12/7/18, Michael Niedermayer wrote: > On Thu, Dec 06, 2018 at 03:26:41PM +0100, Paul B Mahol wrote: >> This recovers state with #7374 linked sample. >> >> Work funded by Open Broadcast Systems. >> >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/h264_refs.c | 2 +- >> 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] avcodec/h264_refs: reset MMCO when invalid mmco code is found

2018-12-07 Thread Paul B Mahol
On 12/7/18, Paul B Mahol wrote: > On 12/7/18, Michael Niedermayer wrote: >> On Thu, Dec 06, 2018 at 03:26:41PM +0100, Paul B Mahol wrote: >>> This recovers state with #7374 linked sample. >>> >>> Work funded by Open Broadcast Systems. >>> >>> Signed-off-by: Paul B Mahol >>> --- >>>

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-07 Thread Paul B Mahol
On 12/7/18, Michael Niedermayer wrote: > On Wed, Dec 05, 2018 at 09:22:48PM +0100, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/proresdec2.c | 51 ++--- >> 1 file changed, 27 insertions(+), 24 deletions(-) >> >> diff --git

[FFmpeg-devel] [PATCH] lavc/qsvenc: set pict_type to be I for IDR frames.

2018-12-07 Thread Zhong Li
Signed-off-by: Zhong Li --- libavcodec/qsvenc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index aa7f347..8289a32 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -1378,10 +1378,11 @@ int

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-07 Thread Michael Niedermayer
On Wed, Dec 05, 2018 at 09:22:48PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/proresdec2.c | 51 ++--- > 1 file changed, 27 insertions(+), 24 deletions(-) > > diff --git a/libavcodec/proresdec2.c b/libavcodec/proresdec2.c >