Re: [FFmpeg-devel] [PATCH 1/1] avcodec/vaapi_encode: add frame-skip func

2018-12-09 Thread Sun, Jing A
Hi Mark, Thanks for your kind guidance, but the problem is we are not trying to control the output framerate by this skip-frame feature. Our purpose is to just skip some frames, which are being requested by the content producer. And to implement that, we need an interface between the app and th

Re: [FFmpeg-devel] [PATCH V1 1/2] lavfi/vf_scale_vaapi: add scaling mode setting support.

2018-12-09 Thread myp...@gmail.com
now, On Mon, Dec 10, 2018 at 2:25 AM Mark Thompson wrote: > > On 06/12/2018 10:39, Jun Zhao wrote: > > before this change, scale_vaapi hard coding the scaling mode, add a > > new option "mode" to setting the scaling mode, it can be use to change > > scaling algorithm for performance/quality trade

Re: [FFmpeg-devel] [PATCH v4 8/9] lavc/qsvenc: enable QVBR mode

2018-12-09 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Monday, December 10, 2018 3:10 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v4 8/9] lavc/qsvenc: enable QVBR mode > > On 29/11/2018 08:29, Zhong Li wrote: > > QVBR mode is to

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc_hevc: correction for QSV HEVC default plugin selection on Windows

2018-12-09 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Monday, December 10, 2018 2:48 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc_hevc: correction for > QSV HEVC default plugin selection on Windows > > On 06/1

Re: [FFmpeg-devel] [PATCH, v4] lavc/qsvenc: replace assert with error return

2018-12-09 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Linjie Fu > Sent: Sunday, December 9, 2018 9:31 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [FFmpeg-devel] [PATCH, v4] lavc/qsvenc: replace assert with error > return > > bs->FrameType is not set in MSDK

Re: [FFmpeg-devel] [PATCH] add support for ROI-based encoding

2018-12-09 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Monday, December 10, 2018 3:21 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] add support for ROI-based encoding > > On 05/12/2018 09:58, Guo, Y

Re: [FFmpeg-devel] [PATCH]configure: Default to clang for Android

2018-12-09 Thread Carl Eugen Hoyos
2018-12-07 3:06 GMT+01:00, Carl Eugen Hoyos : > I believe the Android documentation indicates that gcc will be > removed from ndk. Attached patch changes the default to > "clang" for --target-os=android. > > Now with patch. Any comments? Carl Eugen ___

Re: [FFmpeg-devel] [PATCH]lavc/xpmdec: Allow more colours per character

2018-12-09 Thread Carl Eugen Hoyos
2018-12-06 19:11 GMT+01:00, Carl Eugen Hoyos : > Attached patch fixes decoding the files attached to ticket #6234. > > Please comment, Carl Eugen Ping. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/

Re: [FFmpeg-devel] [PATCH]lavd: Remove libndi newtek

2018-12-09 Thread Carl Eugen Hoyos
2018-12-03 17:05 GMT+01:00, Carl Eugen Hoyos : > It appears to me that NewTek abused our willingness to add an optional > external nonfree library, I don't see many better options. See Ticket > #7589 and a blog post by a NewTek engineer confirming the issue. > > Patch untested. After several peop

Re: [FFmpeg-devel] [PATCH V1 2/2] lavc/vaapi_encode: fix slices number check.

2018-12-09 Thread myp...@gmail.com
On Mon, Dec 10, 2018 at 2:08 AM Mark Thompson wrote: > > On 06/12/2018 10:39, Jun Zhao wrote: > > Fix slice number check logic. Only when the user setting slices > > number more than the driver constraints dump the rounded up warning > > message. > > > > Signed-off-by: Jun Zhao > > --- > > libav

[FFmpeg-devel] [RFC]lavc/mjpegenc_common: Fix aspect ratio

2018-12-09 Thread Carl Eugen Hoyos
Hi! Reading the specification and Wikipedia, it appears to me that FFmpeg is writing wrong values as aspect ratio for jfif files. I hope somebody can prove me wrong! This would need a slightly more sophisticated update to the decoder. Please comment, Carl Eugen From 9c42114da17c20ef6d81d3989b552

Re: [FFmpeg-devel] AMD Vega 56, UVD and OpenCL

2018-12-09 Thread Mironov, Mikhail
There are decoding samples and some other samples here: https://github.com/GPUOpen-LibrariesAndSDKs/AMF There are no samples how to get Vulkan surfaces/images into OpenCL. These are public interops that you can use yourself at this point. Mikhail From: ffmpeg

Re: [FFmpeg-devel] [PATCH] lavfi/buffersink: fix abuffersink flag setting issue

2018-12-09 Thread myp...@gmail.com
On Sun, Dec 9, 2018 at 10:58 PM Nicolas George wrote: > > Jun Zhao (2018-12-09): > > abuffersink need to setting AV_OPT_FLAG_AUDIO_PARAM flag. > > > > Signed-off-by: Jun Zhao > > --- > > libavfilter/buffersink.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > LGTM, thanks. >

Re: [FFmpeg-devel] [PATCH V4 0/2] Add libsvt HEVC encoder wrapper

2018-12-09 Thread myp...@gmail.com
On Sun, Dec 9, 2018 at 11:45 PM Carl Eugen Hoyos wrote: > > 2018-12-09 10:24 GMT+01:00, Jun Zhao : > > > SVT-HEVC encoder have some interesting features compare > > with the existing HEVC encoder. > > > > - Multidimensional parallelism > > a). Picture-based parallelism > > b). Segment-base

Re: [FFmpeg-devel] [PATCH]lavc/cbs_vp9: Avoid an implicit conversion from 255 to -1

2018-12-09 Thread Carl Eugen Hoyos
2018-12-09 16:15 GMT+01:00, Mark Thompson : > On 07/12/2018 00:17, James Almer wrote: >> On 12/6/2018 8:29 PM, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch silences an ugly clang warning. >>> >>> Please comment, Carl Eugen >>> >>> >>> 0001-lavc-cbs_vp9-Avoid-an-implicit-conversion-from-25

Re: [FFmpeg-devel] [PATCH]lavf/matroskadec: Do not use strncat() to limit copying a one-char constant

2018-12-09 Thread Carl Eugen Hoyos
2018-12-09 19:03 GMT+01:00, Mark Thompson : > On 06/12/2018 22:26, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch silences a new gcc warning, alternative would be to >> disable the warning. >> >> Please comment, Carl Eugen >> >> >> From dd49cddc6fad136222d4a168301059d55fea4a4c Mon Sep 17 00:00

Re: [FFmpeg-devel] [PATCH]lavc/decode: Initialize a return value on get_format() error

2018-12-09 Thread Carl Eugen Hoyos
2018-12-09 18:54 GMT+01:00, Mark Thompson : > On 06/12/2018 22:27, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch silences a clang warning, please comment. >> >> Carl Eugen >> >> >> From 3b5fc2473235410920ca89c7d84654e2ce8fb29d Mon Sep 17 00:00:00 2001 >> From: Carl Eugen Hoyos >> Date: Thu,

Re: [FFmpeg-devel] [PATCH]lavd/v4l2: Use ioctl(..., "int request" ) on Android

2018-12-09 Thread Carl Eugen Hoyos
2018-12-09 18:50 GMT+01:00, Mark Thompson : > On 06/12/2018 22:37, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes building with new Android toolchain, used to be a >> warning. >> >> Please comment, Carl Eugen >> >> From d366c948af086520bfb2a4048e76f8d117690776 Mon Sep 17 00:00:00 2001 >>

Re: [FFmpeg-devel] AMD Vega 56, UVD and OpenCL

2018-12-09 Thread James Courtier-Dutton
On Sun, 9 Dec 2018 at 23:21, Mironov, Mikhail wrote: > There is one potential way to do it: > Decode using AMF on Vulkan, then Vulkan has interop to OpenGL and OpenGL > has interop to OpenCL. > AMF on Vulkan on Linux was released (decoder and encoder). > To integrate it to FFmpeg we need FFmpeg A

Re: [FFmpeg-devel] AMD Vega 56, UVD and OpenCL

2018-12-09 Thread Mironov, Mikhail
There is one potential way to do it: Decode using AMF on Vulkan, then Vulkan has interop to OpenGL and OpenGL has interop to OpenCL. AMF on Vulkan on Linux was released (decoder and encoder). To integrate it to FFmpeg we need FFmpeg AMF context committed. It is waiting for Mark to commit for qui

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-09 Thread Michael Niedermayer
On Fri, Dec 07, 2018 at 07:34:43PM +0200, Jan Ekström wrote: > On Wed, Dec 5, 2018 at 7:13 PM Jan Ekström wrote: > > > > On Mon, Dec 3, 2018 at 3:19 AM Jan Ekström wrote: > > > > > > From: Rodger Combs > > > > > > These are registered identifiers at the MPEG-4 RA, which are > > > defined as to b

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: calculate and store DAR from user SAR

2018-12-09 Thread Michael Niedermayer
On Sun, Dec 09, 2018 at 02:38:55PM +0100, Paul B Mahol wrote: > Fixes #5155 > > Signed-off-by: Paul B Mahol > --- > libavformat/mxfenc.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c > index 3549b4137d..b3c8dc43bd 100644 > --- a/libav

Re: [FFmpeg-devel] [PATCH 4/4] avformat/concatdec: always re-calculate start time and duration

2018-12-09 Thread Marton Balint
On Sun, 9 Dec 2018, Nicolas George wrote: Marton Balint (2018-11-22): This allows the underlying files to change their duration on subsequent avformat context opens. An example use case where this matters: ffconcat version 1.0 file dummy.mxf file dummy.mxf ffmpeg -re -stream_loop -1 -i dum

Re: [FFmpeg-devel] [PATCH] libavcodec/zmbvenc.c: don't allow motion estimation out of range.

2018-12-09 Thread Matthew Fearnley
On Sun, 9 Dec 2018 at 16:27, Michael Niedermayer wrote: > On Sat, Dec 08, 2018 at 02:53:44PM +0100, Tomas Härdin wrote: > > lör 2018-12-08 klockan 00:29 + skrev Matthew Fearnley: > > > Hi Tomas, thanks for looking through my patch. > > > > > > > > Practically, this patch fixes graphical glitc

Re: [FFmpeg-devel] [PATCH V4 2/2] doc: Add libsvt_hevc encoder docs

2018-12-09 Thread Gyan
On 09-12-2018 02:54 PM, Jun Zhao wrote: Add docs for libsvt_hevc encoder in encoders.texi and general.texi Signed-off-by: Jun Zhao Signed-off-by: Huang, Zhengxu Signed-off-by: hassene --- doc/encoders.texi | 157 + doc/general.texi |

Re: [FFmpeg-devel] [PATCH] add support for ROI-based encoding

2018-12-09 Thread Mark Thompson
On 05/12/2018 09:58, Guo, Yejun wrote: > this patch is not ask for merge, it is more to get a feature feedback. > > The encoders such as libx264 support different QPs offset for different MBs, > it makes possible for ROI-based encoding. It makes sense to add support > within ffmpeg to generate/acc

Re: [FFmpeg-devel] [PATCH v4 8/9] lavc/qsvenc: enable QVBR mode

2018-12-09 Thread Mark Thompson
On 29/11/2018 08:29, Zhong Li wrote: > QVBR mode is to use the variable bitrate control algorithm > with constant quality. > mfxExtCodingOption3 should be supported to enable QVBR mode. > > Example usage: ffmpeg -hwaccel qsv -c:v h264_qsv -i input.mp4 -c:v > h264_qsv -global_quality 25 -maxrate 2M

Re: [FFmpeg-devel] [PATCH 3/3] qsvdec: Fix running with assert_level > 0

2018-12-09 Thread Mark Thompson
On 27/11/2018 09:40, Li, Zhong wrote: >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Mark Thompson >> Sent: Sunday, November 11, 2018 11:32 PM >> To: ffmpeg-devel@ffmpeg.org >> Subject: [FFmpeg-devel] [PATCH 3/3] qsvdec: Fix running with assert_level > >> 0 >> >> Ass

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc_hevc: correction for QSV HEVC default plugin selection on Windows

2018-12-09 Thread Mark Thompson
On 06/12/2018 05:21, Li, Zhong wrote: >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Landgraph >> Sent: Thursday, December 6, 2018 4:23 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc_hevc: correction for >> QSV HEVC default

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/vaapi_encode: add frame-skip func

2018-12-09 Thread Mark Thompson
On 06/12/2018 10:04, Sun, Jing A wrote: > Hi Mark, > > This patch is not trying to support VFR. Some frames, after which are just > produced, could be considered as not needed by theirs producer and will get > skipped in the encoding process. And in my opinion the existing timing > information

Re: [FFmpeg-devel] [PATCH] ffmpeg-opt: mark stream disable options as output-only

2018-12-09 Thread Gyan
On 09-12-2018 11:32 PM, Michael Niedermayer wrote: On Sat, Dec 08, 2018 at 06:56:10PM +0530, Gyan Doshi wrote: I see users with these options set in front of input. Stream disabling for input requires -discard though one packet tends to get smuggled across. But that's for another patch. Gyan

Re: [FFmpeg-devel] [PATCH V1 1/2] lavfi/vf_scale_vaapi: add scaling mode setting support.

2018-12-09 Thread Mark Thompson
On 06/12/2018 10:39, Jun Zhao wrote: > before this change, scale_vaapi hard coding the scaling mode, add a > new option "mode" to setting the scaling mode, it can be use to change > scaling algorithm for performance/quality trade off. > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_scale_vaap

Re: [FFmpeg-devel] [PATCH V1 2/2] lavc/vaapi_encode: fix slices number check.

2018-12-09 Thread Mark Thompson
On 06/12/2018 10:39, Jun Zhao wrote: > Fix slice number check logic. Only when the user setting slices > number more than the driver constraints dump the rounded up warning > message. > > Signed-off-by: Jun Zhao > --- > libavcodec/vaapi_encode.c |2 +- > 1 files changed, 1 insertions(+), 1 d

Re: [FFmpeg-devel] [PATCH]lavf/matroskadec: Do not use strncat() to limit copying a one-char constant

2018-12-09 Thread Mark Thompson
On 06/12/2018 22:26, Carl Eugen Hoyos wrote: > Hi! > > Attached patch silences a new gcc warning, alternative would be to > disable the warning. > > Please comment, Carl Eugen > > > From dd49cddc6fad136222d4a168301059d55fea4a4c Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Thu, 6 D

Re: [FFmpeg-devel] [PATCH] ffmpeg-opt: mark stream disable options as output-only

2018-12-09 Thread Michael Niedermayer
On Sat, Dec 08, 2018 at 06:56:10PM +0530, Gyan Doshi wrote: > I see users with these options set in front of input. > > Stream disabling for input requires -discard though one packet tends to get > smuggled across. But that's for another patch. > > Gyan > ffmpeg_opt.c |8 > 1 file

Re: [FFmpeg-devel] [PATCH]lavc/decode: Initialize a return value on get_format() error

2018-12-09 Thread Mark Thompson
On 06/12/2018 22:27, Carl Eugen Hoyos wrote: > Hi! > > Attached patch silences a clang warning, please comment. > > Carl Eugen > > > From 3b5fc2473235410920ca89c7d84654e2ce8fb29d Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Thu, 6 Dec 2018 23:17:13 +0100 > Subject: [PATCH] lavc/de

Re: [FFmpeg-devel] [PATCH]lavd/v4l2: Use ioctl(..., "int request" ) on Android

2018-12-09 Thread Mark Thompson
On 06/12/2018 22:37, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes building with new Android toolchain, used to be a > warning. > > Please comment, Carl Eugen > > From d366c948af086520bfb2a4048e76f8d117690776 Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Thu, 6 Dec 2018 23

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: add row-mt option

2018-12-09 Thread James Almer
On 12/9/2018 2:25 PM, Mark Thompson wrote: > On 08/12/2018 23:18, James Almer wrote: >> Default to disable, same as aomenc. >> >> Signed-off-by: James Almer >> --- >> libavcodec/libaomenc.c | 11 +++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/libavcodec/libaomenc.c b/libavcode

Re: [FFmpeg-devel] [PATCH, v2] lavc/hevc_parser: add 4 bytes startcode condition and update FATE

2018-12-09 Thread Mark Thompson
On 07/12/2018 11:33, Linjie Fu wrote: > The startcode before VPS,SPS,PPS and the first NALU in an AU is 4 bytes. > Blindly taking the startcode as 3 bytes will leave 0x00 in last packet > and may lead to some warnings in parse_nal_units when s->flags is set to > PARSER_FLAG_COMPLETE_FRAMES. > > Ad

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: add row-mt option

2018-12-09 Thread Mark Thompson
On 08/12/2018 23:18, James Almer wrote: > Default to disable, same as aomenc. > > Signed-off-by: James Almer > --- > libavcodec/libaomenc.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c > index 17565017b4..1d3cef73f3 100644

Re: [FFmpeg-devel] [PATCH] avcodec/h264_refs: reset MMCO when invalid mmco code is found

2018-12-09 Thread Paul B Mahol
On 12/9/18, Mark Thompson wrote: > On 09/12/2018 13:54, Paul B Mahol wrote: >> On 12/9/18, Mark Thompson wrote: >>> On 09/12/2018 08:52, Paul B Mahol wrote: On 12/7/18, Paul B Mahol wrote: > On 12/7/18, Michael Niedermayer wrote: >> On Fri, Dec 07, 2018 at 10:36:23AM +0100, Paul B

Re: [FFmpeg-devel] [PATCH] libavcodec/zmbvenc.c: don't allow motion estimation out of range.

2018-12-09 Thread Michael Niedermayer
On Sat, Dec 08, 2018 at 02:53:44PM +0100, Tomas Härdin wrote: > lör 2018-12-08 klockan 00:29 + skrev Matthew Fearnley: > > Hi Tomas, thanks for looking through my patch. > > > > > > Practically, this patch fixes graphical glitches e.g. when reencoding > > > > the > > > > Commander Keen sample

Re: [FFmpeg-devel] AMD Vega 56, UVD and OpenCL

2018-12-09 Thread James Courtier-Dutton
On Sun, 9 Dec 2018 at 13:37, Mark Thompson wrote: > On 09/12/2018 01:22, James Courtier-Dutton wrote: > > Hi, > > > > I little off topic, but hopefully someone here might be able to help me > as > > it is video processing related. > > > > I wish to use UVD to send a video stream to the GPU, and t

Re: [FFmpeg-devel] [PATCH V4 0/2] Add libsvt HEVC encoder wrapper

2018-12-09 Thread Carl Eugen Hoyos
2018-12-09 10:24 GMT+01:00, Jun Zhao : > SVT-HEVC encoder have some interesting features compare > with the existing HEVC encoder. > > - Multidimensional parallelism > a). Picture-based parallelism > b). Segment-based parallelism (scales over many CPU cores) > c). Will support tile-bas

Re: [FFmpeg-devel] [PATCH]lavc/cbs_vp9: Avoid an implicit conversion from 255 to -1

2018-12-09 Thread Mark Thompson
On 07/12/2018 00:17, James Almer wrote: > On 12/6/2018 8:29 PM, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch silences an ugly clang warning. >> >> Please comment, Carl Eugen >> >> >> 0001-lavc-cbs_vp9-Avoid-an-implicit-conversion-from-255-t.patch >> >> From 20a643259b8e382bdfd759af78c36c3442

Re: [FFmpeg-devel] [PATCH V4 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2018-12-09 Thread Mark Thompson
On 09/12/2018 09:24, Jun Zhao wrote: > base on patch by Huang, Zhengxu from https://github.com/intel/SVT-HEVC > > Signed-off-by: Huang, Zhengxu > Signed-off-by: hassene > Signed-off-by: Jun Zhao > --- > Changelog|1 + > configure|4 + > libavcodec/Makefi

Re: [FFmpeg-devel] [PATCH] lavfi/buffersink: fix abuffersink flag setting issue

2018-12-09 Thread Nicolas George
Jun Zhao (2018-12-09): > abuffersink need to setting AV_OPT_FLAG_AUDIO_PARAM flag. > > Signed-off-by: Jun Zhao > --- > libavfilter/buffersink.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) LGTM, thanks. Regards, -- Nicolas George signature.asc Description: Digital signat

[FFmpeg-devel] [PATCH] lavfi/buffersink: fix abuffersink flag setting issue

2018-12-09 Thread Jun Zhao
abuffersink need to setting AV_OPT_FLAG_AUDIO_PARAM flag. Signed-off-by: Jun Zhao --- libavfilter/buffersink.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c index 0f87b54..f9b0b5e 100644 --- a/libavfilter/buffersink.

Re: [FFmpeg-devel] [PATCH] avcodec/h264_refs: reset MMCO when invalid mmco code is found

2018-12-09 Thread Mark Thompson
On 09/12/2018 13:54, Paul B Mahol wrote: > On 12/9/18, Mark Thompson wrote: >> On 09/12/2018 08:52, Paul B Mahol wrote: >>> On 12/7/18, Paul B Mahol wrote: On 12/7/18, Michael Niedermayer wrote: > On Fri, Dec 07, 2018 at 10:36:23AM +0100, Paul B Mahol wrote: >> On 12/7/18, Paul B Ma

Re: [FFmpeg-devel] [PATCH] avcodec/h264_refs: reset MMCO when invalid mmco code is found

2018-12-09 Thread Paul B Mahol
On 12/9/18, Mark Thompson wrote: > On 09/12/2018 08:52, Paul B Mahol wrote: >> On 12/7/18, Paul B Mahol wrote: >>> On 12/7/18, Michael Niedermayer wrote: On Fri, Dec 07, 2018 at 10:36:23AM +0100, Paul B Mahol wrote: > On 12/7/18, Paul B Mahol wrote: >> On 12/7/18, Michael Niedermay

Re: [FFmpeg-devel] [PATCH] avcodec/h264_refs: reset MMCO when invalid mmco code is found

2018-12-09 Thread Mark Thompson
On 09/12/2018 08:52, Paul B Mahol wrote: > On 12/7/18, Paul B Mahol wrote: >> On 12/7/18, Michael Niedermayer wrote: >>> On Fri, Dec 07, 2018 at 10:36:23AM +0100, Paul B Mahol wrote: On 12/7/18, Paul B Mahol wrote: > On 12/7/18, Michael Niedermayer wrote: >> On Thu, Dec 06, 2018 at

[FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: calculate and store DAR from user SAR

2018-12-09 Thread Paul B Mahol
Fixes #5155 Signed-off-by: Paul B Mahol --- libavformat/mxfenc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index 3549b4137d..b3c8dc43bd 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -2726,6 +2726,12 @@ static int mxf_w

[FFmpeg-devel] [PATCH 1/2] avutil/rational: add av_reduce_q()

2018-12-09 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavutil/rational.c | 5 + libavutil/rational.h | 12 2 files changed, 17 insertions(+) diff --git a/libavutil/rational.c b/libavutil/rational.c index 35ee08877f..47f64e914e 100644 --- a/libavutil/rational.c +++ b/libavutil/rational.c @@ -77,6 +

Re: [FFmpeg-devel] AMD Vega 56, UVD and OpenCL

2018-12-09 Thread Mark Thompson
On 09/12/2018 01:22, James Courtier-Dutton wrote: > Hi, > > I little off topic, but hopefully someone here might be able to help me as > it is video processing related. > > I wish to use UVD to send a video stream to the GPU, and then have OpenCL > process the output video frames. > > Can anyone

[FFmpeg-devel] [PATCH, v4] lavc/qsvenc: replace assert with error return

2018-12-09 Thread Linjie Fu
bs->FrameType is not set in MSDK in some cases (mjpeg encode for example), and assert on a value coming from an external library is not proper. Add default type check for bs->FrameType, and return invalid data error in function ff_qsv_encode to avoid using uninitialized value. Fix #7593. Signed

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: calculate and store DAR from user SAR

2018-12-09 Thread Nicolas George
Paul B Mahol (2018-12-09): > >> +if (st->codecpar->sample_aspect_ratio.num && > >> st->codecpar->sample_aspect_ratio.den) { > >> +av_reduce(&sc->aspect_ratio.num, &sc->aspect_ratio.den, > >> + st->codecpar->sample_aspect_ratio.num * > >> st->codecpar->width, > >> +

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: calculate and store DAR from user SAR

2018-12-09 Thread Paul B Mahol
On 12/9/18, Tomas Härdin wrote: > fre 2018-12-07 klockan 21:30 +0100 skrev Paul B Mahol: >> Fixes #5155 >> >> > Signed-off-by: Paul B Mahol >> --- >> libavformat/mxfenc.c | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c >> index 3549

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: calculate and store DAR from user SAR

2018-12-09 Thread Tomas Härdin
fre 2018-12-07 klockan 21:30 +0100 skrev Paul B Mahol: > Fixes #5155 > > > Signed-off-by: Paul B Mahol > --- >  libavformat/mxfenc.c | 8 >  1 file changed, 8 insertions(+) > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c > index 3549b4137d..8f762c7eaf 100644 > --- a/libavfor

Re: [FFmpeg-devel] [PATCH] libavcodec/zmbvenc.c: don't allow motion estimation out of range.

2018-12-09 Thread Tomas Härdin
lör 2018-12-08 klockan 00:29 + skrev Matthew Fearnley: > All that said, *xored==0 is actually the most desirable outcome because it > means the block doesn't need to be output. > So if *xored is 0, the best thing to do is probably to finish immediately > (making sure *mx,*my are set), without p

Re: [FFmpeg-devel] [PATCH 4/4] avformat/concatdec: always re-calculate start time and duration

2018-12-09 Thread Nicolas George
Marton Balint (2018-11-22): > This allows the underlying files to change their duration on subsequent > avformat context opens. > > An example use case where this matters: > > ffconcat version 1.0 > file dummy.mxf > file dummy.mxf > > ffmpeg -re -stream_loop -1 -i dummy.ffconcat -f sdl2 none >

Re: [FFmpeg-devel] [PATCH 3/4] avformat/concatdec: fix cur_dts based duration calculation with nonzero stream start_time

2018-12-09 Thread Nicolas George
Marton Balint (2018-11-22): > Signed-off-by: Marton Balint > --- > libavformat/concatdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I suppose it is valid. Regards, -- Nicolas George signature.asc Description: Digital signature ___

[FFmpeg-devel] [PATCH 1/2] avcodec: add gif parser

2018-12-09 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/gif_parser.c | 188 libavcodec/parsers.c| 1 + 3 files changed, 190 insertions(+) create mode 100644 libavcodec/gif_parser.c diff --git a/libavcodec/Makefile b/libavcodec/M

Re: [FFmpeg-devel] [PATCH 2/4] avformat/concatdec: factorize the duration calculating function

2018-12-09 Thread Nicolas George
Marton Balint (2018-11-22): > Signed-off-by: Marton Balint > --- > libavformat/concatdec.c | 37 +++-- > 1 file changed, 23 insertions(+), 14 deletions(-) LGTM. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH 1/4] avformat/concatdec: set seekable flag after opening the last file

2018-12-09 Thread Nicolas George
Marton Balint (2018-11-22): > After finishing the last file all durations and start times should be known. > > Signed-off-by: Marton Balint > --- > libavformat/concatdec.c | 1 + > 1 file changed, 1 insertion(+) Ok in principle. I would be more comfortable if some kind of consistency test were

Re: [FFmpeg-devel] [PATCH V4 2/2] doc: Add libsvt_hevc encoder docs

2018-12-09 Thread Gyan
On 09-12-2018 02:54 PM, Jun Zhao wrote: Add docs for libsvt_hevc encoder in encoders.texi and general.texi Signed-off-by: Jun Zhao Signed-off-by: Huang, Zhengxu Signed-off-by: hassene --- doc/encoders.texi | 157 + doc/general.texi

[FFmpeg-devel] [PATCH V4 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2018-12-09 Thread Jun Zhao
base on patch by Huang, Zhengxu from https://github.com/intel/SVT-HEVC Signed-off-by: Huang, Zhengxu Signed-off-by: hassene Signed-off-by: Jun Zhao --- Changelog|1 + configure|4 + libavcodec/Makefile |1 + libavcodec/allcodecs.c |1 + li

[FFmpeg-devel] [PATCH V4 0/2] Add libsvt HEVC encoder wrapper

2018-12-09 Thread Jun Zhao
The Scalable Video Technology for HEVC Encoder (SVT-HEVC Encoder) is an HEVC-compliant encoder library core that achieves excellent density-quality tradeoffs, and is highly optimized for Intel Xeon Scalable Processor and Xeon D processors. Intel open source SVT-HEVC encoder in: https://github.c

[FFmpeg-devel] [PATCH V4 2/2] doc: Add libsvt_hevc encoder docs

2018-12-09 Thread Jun Zhao
Add docs for libsvt_hevc encoder in encoders.texi and general.texi Signed-off-by: Jun Zhao Signed-off-by: Huang, Zhengxu Signed-off-by: hassene --- doc/encoders.texi | 157 + doc/general.texi | 14 + 2 files changed, 171 insertions(+)

Re: [FFmpeg-devel] [PATCH] avcodec/h264_refs: reset MMCO when invalid mmco code is found

2018-12-09 Thread Paul B Mahol
On 12/7/18, Paul B Mahol wrote: > On 12/7/18, Michael Niedermayer wrote: >> On Fri, Dec 07, 2018 at 10:36:23AM +0100, Paul B Mahol wrote: >>> On 12/7/18, Paul B Mahol wrote: >>> > On 12/7/18, Michael Niedermayer wrote: >>> >> On Thu, Dec 06, 2018 at 03:26:41PM +0100, Paul B Mahol wrote: >>> >>>