[FFmpeg-devel] [PATCH v2] libswscale/ppc: VSX-optimize 9-16 bit yuv2planeX

2019-01-06 Thread Lauri Kasanen
./ffmpeg_g -f rawvideo -pix_fmt rgb24 -s hd1080 -i /dev/zero -pix_fmt yuv420p16be \ -s 1920x1728 -f null -vframes 100 -v error -nostats - 9-14 bit funcs get about 6x speedup, 16-bit gets about 15x. Fate passes, each format tested with an image to video conversion. Only POWER8 includes 32-bit vec

Re: [FFmpeg-devel] [PATCH V5 2/2] avcodec/libx264: add support for ROI-based encoding

2019-01-06 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Moritz Barsnick > Sent: Friday, January 04, 2019 7:58 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH V5 2/2] avcodec/libx264: add

Re: [FFmpeg-devel] [PATCH V5 1/2] avutil: add ROI (Region Of Interest) data struct and bump version

2019-01-06 Thread Guo, Yejun
thanks a lot for all your valuable comments. > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Nicolas George > Sent: Saturday, January 05, 2019 12:51 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmp

Re: [FFmpeg-devel] [PATCH] avformat/file: Fix file delete for Windows

2019-01-06 Thread Jeyapal, Karthick
>On 12/31/18, 1:08 PM, "Karthick J" wrote: > >From: Karthick Jeyapal > >Fixes bug id : 7638 >--- > libavformat/file.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > [...] Pushed ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org h

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/avpacket: Avoid unspecific return -1 for av_grow_packet()

2019-01-06 Thread Michael Niedermayer
On Sun, Jan 06, 2019 at 10:43:53AM -0300, James Almer wrote: > On 1/6/2019 10:36 AM, Carl Eugen Hoyos wrote: > > 2019-01-02 0:23 GMT+01:00, Michael Niedermayer : > >> ffmpeg | branch: master | Michael Niedermayer | > >> Mon > >> Dec 31 18:25:18 2018 +0100| [9520d51e21f9aa5adc807b0b89322bd822b0673

[FFmpeg-devel] [PATCH] avcodec/qpeg: Optimize long runs in qpeg_decode_intra() not spanning a full row

2019-01-06 Thread Michael Niedermayer
Fixes: Timeout Fixes: 11354/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QPEG_fuzzer-5766275943366656 Before: Executed clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QPEG_fuzzer-5766275943366656 in 9470 ms After : Executed clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QPEG_fuzzer-5

Re: [FFmpeg-devel] [PATCH] dstdec: big-endian compatiblity

2019-01-06 Thread Carl Eugen Hoyos
2019-01-06 23:55 GMT+01:00, Peter Ross : > On Sun, Jan 06, 2019 at 12:57:37PM +0100, Carl Eugen Hoyos wrote: >> 2019-01-06 12:12 GMT+01:00, Peter Ross : >> > for the '127-bit shift left' algorithm to work as intended, >> > little-endian >> > reads and writes must be used. >> > >> Why not using AV_W

Re: [FFmpeg-devel] [PATCH 3/4] VP4 data tables

2019-01-06 Thread Peter Ross
On Sun, Jan 06, 2019 at 02:40:44PM -0300, James Almer wrote: > On 1/6/2019 4:43 AM, Peter Ross wrote: > > --- > > libavcodec/vp4data.h | 3784 ++ > > 1 file changed, 3784 insertions(+) > > create mode 100644 libavcodec/vp4data.h > > This should be squashed

Re: [FFmpeg-devel] [PATCH] dstdec: big-endian compatiblity

2019-01-06 Thread Peter Ross
On Sun, Jan 06, 2019 at 12:57:37PM +0100, Carl Eugen Hoyos wrote: > 2019-01-06 12:12 GMT+01:00, Peter Ross : > > for the '127-bit shift left' algorithm to work as intended, little-endian > > reads and writes must be used. > > > Why not using AV_WL64() and and AV_RL64()? good question. > Is there

Re: [FFmpeg-devel] [PATCH] swscale/output: VSX-optimize 9-16 bit yuv2planeX

2019-01-06 Thread Carl Eugen Hoyos
2019-01-04 20:43 GMT+01:00, Lauri Kasanen : > The existing VSX yuv2plane1 is also ifdefed out for POWER7, > even though it works there. > This is for cleanliness mainly, separating the macros would > be a bit uglier. Please make it a bit uglier. Sorry for missing this paragraph, Carl Eugen _

Re: [FFmpeg-devel] [PATCH] swscale/output: VSX-optimize 9-16 bit yuv2planeX

2019-01-06 Thread Lauri Kasanen
On Sun, 6 Jan 2019 13:23:43 +0100 Carl Eugen Hoyos wrote: > 2019-01-04 20:43 GMT+01:00, Lauri Kasanen : > > +#ifdef __POWER8_VECTOR__ > > If this is correct, I assume it fixes a bug in the current code > and should be a separate patch, no? > > > case 16: > > c->yuv2plane1

Re: [FFmpeg-devel] [PATCH] configure: add dxva2 extralibs to avcodec

2019-01-06 Thread Carl Eugen Hoyos
2019-01-06 16:19 GMT+01:00, James Almer : > DXVA2 may be enabled even when every relevant module is disabled, > which would result in the dependency generator not including its > extralibs to avcodec. > > Fixes ticket #7642. Thank you! Carl Eugen ___ ff

Re: [FFmpeg-devel] [PATCH] configure: add dxva2 extralibs to avcodec

2019-01-06 Thread Paul B Mahol
On 1/6/19, James Almer wrote: > DXVA2 may be enabled even when every relevant module is disabled, > which would result in the dependency generator not including its > extralibs to avcodec. > > Fixes ticket #7642. > > Signed-off-by: James Almer > --- > configure | 2 +- > 1 file changed, 1 insert

Re: [FFmpeg-devel] [PATCH 3/4] VP4 data tables

2019-01-06 Thread James Almer
On 1/6/2019 4:43 AM, Peter Ross wrote: > --- > libavcodec/vp4data.h | 3784 ++ > 1 file changed, 3784 insertions(+) > create mode 100644 libavcodec/vp4data.h This should be squashed with the patch adding the decoder before pushing.

[FFmpeg-devel] [PATCH] configure: add dxva2 extralibs to avcodec

2019-01-06 Thread James Almer
DXVA2 may be enabled even when every relevant module is disabled, which would result in the dependency generator not including its extralibs to avcodec. Fixes ticket #7642. Signed-off-by: James Almer --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/c

Re: [FFmpeg-devel] [PATCH]configure: ole32 is needed for shared libavcodec linking with dxva2.

2019-01-06 Thread Carl Eugen Hoyos
2019-01-06 14:57 GMT+01:00, James Almer : > On 1/6/2019 10:32 AM, Carl Eugen Hoyos wrote: >> 2018-12-31 2:44 GMT+01:00, James Almer : >>> On 12/30/2018 5:52 PM, Carl Eugen Hoyos wrote: 2018-12-30 21:37 GMT+01:00, Hendrik Leppkes : > On Sun, Dec 30, 2018 at 9:16 PM Carl Eugen Hoyos > w

Re: [FFmpeg-devel] [PATCH]configure: ole32 is needed for shared libavcodec linking with dxva2.

2019-01-06 Thread James Almer
On 1/6/2019 10:32 AM, Carl Eugen Hoyos wrote: > 2018-12-31 2:44 GMT+01:00, James Almer : >> On 12/30/2018 5:52 PM, Carl Eugen Hoyos wrote: >>> 2018-12-30 21:37 GMT+01:00, Hendrik Leppkes : On Sun, Dec 30, 2018 at 9:16 PM Carl Eugen Hoyos wrote: >>> > Attached patch fixes a Windows li

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/avpacket: Avoid unspecific return -1 for av_grow_packet()

2019-01-06 Thread Carl Eugen Hoyos
2019-01-06 14:43 GMT+01:00, James Almer : > On 1/6/2019 10:36 AM, Carl Eugen Hoyos wrote: >> 2019-01-02 0:23 GMT+01:00, Michael Niedermayer : >>> ffmpeg | branch: master | Michael Niedermayer | >>> Mon >>> Dec 31 18:25:18 2018 +0100| [9520d51e21f9aa5adc807b0b89322bd822b06738] | >>> committer: Mich

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/avpacket: Avoid unspecific return -1 for av_grow_packet()

2019-01-06 Thread James Almer
On 1/6/2019 10:36 AM, Carl Eugen Hoyos wrote: > 2019-01-02 0:23 GMT+01:00, Michael Niedermayer : >> ffmpeg | branch: master | Michael Niedermayer | Mon >> Dec 31 18:25:18 2018 +0100| [9520d51e21f9aa5adc807b0b89322bd822b06738] | >> committer: Michael Niedermayer >> >> avcodec/avpacket: Avoid unspec

Re: [FFmpeg-devel] [PATCH] avcodec/bsf_list: implement a AVBSFContext.flush callback

2019-01-06 Thread James Almer
On 1/6/2019 6:08 AM, Paul B Mahol wrote: > On 1/6/19, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/bsf.c | 11 +++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c >> index 03841da682..41dde4dcc8 100644 >> --- a/libavcode

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/avpacket: Avoid unspecific return -1 for av_grow_packet()

2019-01-06 Thread Carl Eugen Hoyos
2019-01-02 0:23 GMT+01:00, Michael Niedermayer : > ffmpeg | branch: master | Michael Niedermayer | Mon > Dec 31 18:25:18 2018 +0100| [9520d51e21f9aa5adc807b0b89322bd822b06738] | > committer: Michael Niedermayer > > avcodec/avpacket: Avoid unspecific return -1 for av_grow_packet() > > Reviewed-by:

Re: [FFmpeg-devel] [PATCH]configure: ole32 is needed for shared libavcodec linking with dxva2.

2019-01-06 Thread Carl Eugen Hoyos
2018-12-31 2:44 GMT+01:00, James Almer : > On 12/30/2018 5:52 PM, Carl Eugen Hoyos wrote: >> 2018-12-30 21:37 GMT+01:00, Hendrik Leppkes : >>> On Sun, Dec 30, 2018 at 9:16 PM Carl Eugen Hoyos >>> wrote: >> Attached patch fixes a Windows linking issue described in ticket #7642, only share

[FFmpeg-devel] [PATCH] avfilter: add anlmdn audio filter

2019-01-06 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 23 libavfilter/Makefile | 1 + libavfilter/af_anlmdn.c | 249 +++ libavfilter/allfilters.c | 1 + 4 files changed, 274 insertions(+) create mode 100644 libavfilter/af_anlmdn.c diff --g

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add HCOM decoder

2019-01-06 Thread Carl Eugen Hoyos
2019-01-03 0:51 GMT+01:00, Rostislav Pehlivanov : > On Wed, 2 Jan 2019 at 19:02, Paul B Mahol wrote: >> +while (bits-- > 0) { >> + >> +if (current & 0x8000) { >> +s->dict_entry = s->dict[s->dict_entry].r; >> +} else { >> +s->dic

Re: [FFmpeg-devel] patch for failing on WavPack DSD files

2019-01-06 Thread Carl Eugen Hoyos
2019-01-03 6:19 GMT+01:00, David Bryant : > On 12/28/18 3:56 AM, Paul B Mahol wrote: >> On 12/24/18, Derek Buitenhuis wrote: >>> On 24/12/2018 17:47, David Bryant wrote: I want to do that, but am swamped at work right now, so it will probably be a few months before I can get to that. >>>

Re: [FFmpeg-devel] [PATCH] swscale/output: VSX-optimize 9-16 bit yuv2planeX

2019-01-06 Thread Carl Eugen Hoyos
2019-01-04 20:43 GMT+01:00, Lauri Kasanen : > +#ifdef __POWER8_VECTOR__ If this is correct, I assume it fixes a bug in the current code and should be a separate patch, no? > case 16: > c->yuv2plane1 = isBE(dstFormat) ? yuv2plane1_16BE_vsx : > yuv2plane1_16LE_vsx; > +

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/huffyuvdec: Check that slice height is non negative.

2019-01-06 Thread Paul B Mahol
On 1/6/19, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 12381/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HYMT_fuzzer-5705474280783872 > Fixes: > 12384/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HYMT_fuzzer-5725303345774592 > Fixes: > 12389/clusterfuzz-testcase-m

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/huffyuvdec: Check that slices do not exceed frame height

2019-01-06 Thread Paul B Mahol
On 1/6/19, Michael Niedermayer wrote: > Fixes: Out of array access > Fixes: > 12367/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HYMT_fuzzer-5662313959391232 > Fixes: > 12370/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HYMT_fuzzer-5670984961490944 > Fixes: > 12376/clusterfuzz-testcase-m

Re: [FFmpeg-devel] [PATCH] avcodec/dxva2: d3d11va: don't try to get surface description for nullptr

2019-01-06 Thread Carl Eugen Hoyos
2019-01-05 11:44 GMT+01:00, Anton Fedchin : > From: Anton Fedchin > > after 153b36f there is a possibility to crash when trying to get index of > a surface which points to nirvana. it may occurs when a stream starts with > non i-frame. > --- > libavcodec/dxva2.c | 10 ++ > 1 file changed,

Re: [FFmpeg-devel] [PATCH] dstdec: big-endian compatiblity

2019-01-06 Thread Carl Eugen Hoyos
2019-01-06 12:12 GMT+01:00, Peter Ross : > for the '127-bit shift left' algorithm to work as intended, little-endian > reads and writes must be used. > > libavcodec/dstdec.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/dstdec.c b/libavcodec/dstdec

Re: [FFmpeg-devel] [PATCH 3/4] VP4 data tables

2019-01-06 Thread Carl Eugen Hoyos
2019-01-06 8:43 GMT+01:00, Peter Ross : > +static const uint32_t vp4_generic_dequant[64] = { > +16, 17, 18, 20, 22, 24, 26, 28, > +17, 18, 20, 22, 24, 26, 28, 32, > +18, 20, 22, 24, 26, 28, 32, 36, > +20, 22, 24, 26, 28, 32, 36, 40, > +22, 24, 26, 28, 32, 36, 40, 44, > +24,

Re: [FFmpeg-devel] [PATCH 4/4] VP4 video decoder

2019-01-06 Thread Carl Eugen Hoyos
2019-01-06 12:50 GMT+01:00, Peter Ross : > On Sun, Jan 06, 2019 at 10:11:14AM +0100, Paul B Mahol wrote: >> On 1/6/19, Peter Ross wrote: >> > --- >> > Changelog | 1 + >> > doc/general.texi| 2 + >> > libavcodec/codec_desc.c | 2 +- >> > libavcodec/vp3.c| 701 +

Re: [FFmpeg-devel] [PATCH 4/4] VP4 video decoder

2019-01-06 Thread Peter Ross
On Sun, Jan 06, 2019 at 10:11:14AM +0100, Paul B Mahol wrote: > On 1/6/19, Peter Ross wrote: > > --- > > Changelog | 1 + > > doc/general.texi| 2 + > > libavcodec/codec_desc.c | 2 +- > > libavcodec/vp3.c| 701 ++-- > > liba

[FFmpeg-devel] [PATCH 1/2] avcodec/huffyuvdec: Check that slice height is non negative.

2019-01-06 Thread Michael Niedermayer
Fixes: out of array access Fixes: 12381/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HYMT_fuzzer-5705474280783872 Fixes: 12384/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HYMT_fuzzer-5725303345774592 Fixes: 12389/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HYMT_fuzzer-5704033050

[FFmpeg-devel] [PATCH 2/2] avcodec/huffyuvdec: Check that slices do not exceed frame height

2019-01-06 Thread Michael Niedermayer
Fixes: Out of array access Fixes: 12367/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HYMT_fuzzer-5662313959391232 Fixes: 12370/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HYMT_fuzzer-5670984961490944 Fixes: 12376/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HYMT_fuzzer-5644026183

[FFmpeg-devel] [PATCH] dstdec: big-endian compatiblity

2019-01-06 Thread Peter Ross
for the '127-bit shift left' algorithm to work as intended, little-endian reads and writes must be used. libavcodec/dstdec.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/libavcodec/dstdec.c b/libavcodec/dstdec.c index 511861f4d2..e9653edc9f 100644 --- a/libavcod

Re: [FFmpeg-devel] [PATCH] avcodec/bsf_list: implement a AVBSFContext.flush callback

2019-01-06 Thread Paul B Mahol
On 1/6/19, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/bsf.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c > index 03841da682..41dde4dcc8 100644 > --- a/libavcodec/bsf.c > +++ b/libavcodec/bsf.c > @@ -350,6 +350,1

Re: [FFmpeg-devel] [PATCH 4/4] VP4 video decoder

2019-01-06 Thread Paul B Mahol
On 1/6/19, Peter Ross wrote: > --- > Changelog | 1 + > doc/general.texi| 2 + > libavcodec/codec_desc.c | 2 +- > libavcodec/vp3.c| 701 ++-- > libavformat/riff.c | 1 + > 5 files changed, 671 insertions(+), 36 deleti