Re: [FFmpeg-devel] avcodec/proresenc_aw : improve speed by replacing PutBitContext for codeword encoding

2019-03-05 Thread Carl Eugen Hoyos
2019-02-27 17:50 GMT+01:00, Martin Vignali : >> >> Shouldn’t there be a 64Bit PutBitContext instead so other encoders can >> also profit? > > I only use here a small part of putbitcontext, and in an "unsafe" mode (the > buffer of the prores aw encoder is big enough to not check it, and write 64 >

Re: [FFmpeg-devel] [PATCH] libavcodec/vp8dec: fix the multi-thread HWAccel decode error

2019-03-05 Thread Carl Eugen Hoyos
2018-08-09 9:09 GMT+02:00, Jun Zhao : > the root cause is update_dimentions call get_pixel_format will > trigger the hwaccel_uninit/hwaccel_init , in current context, > there are 3 situations in the update_dimentions(): > 1. First time calling. No matter single thread or multithread, >

Re: [FFmpeg-devel] [PATCH 3/4] lavfi/nlmeans: Checking number precision when computing integral images

2019-03-05 Thread Carl Eugen Hoyos
2019-03-06 4:18 GMT+01:00, Jun Zhao : > From: Jun Zhao > > accumulation of 8-bits uint_8 (uint8_t *src) into 32-bits (uint32_t *ii) > data type, it will have a risk of an integral value becoming larger than > the 32-bits integer capacity and resulting in an integer overflow. For > this risk, add

Re: [FFmpeg-devel] [PATCH v2] avformat/mpegts: reduce buffering during initialization

2019-03-05 Thread Carl Eugen Hoyos
2019-03-06 7:01 GMT+01:00, Andriy Gelman : > From: Andriy Gelman > > Reduces buffering latency with low bitrate streams, where > 8192 bytes can mean several seconds. Would it be an alternative to add an option that allows to force the packet size? Carl Eugen

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix hang while seek on a kind of fragmented mp4.

2019-03-05 Thread Carl Eugen Hoyos
2019-03-06 8:46 GMT+01:00, C.H.Liu : > Yes. Patch aa25198f1b925a464bdfa83a98476f08d26c9209 works to ticket 7572 > luckily. To reproduce #7572, need to revert this patch first. > As we talked, #7572 has a deeper reason. > Mov demuxer consider that > fragmented index is completed if a ‘sidx’ point

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix hang while seek on a kind of fragmented mp4.

2019-03-05 Thread C.H.Liu
Yes. Patch aa25198f1b925a464bdfa83a98476f08d26c9209 works to ticket 7572 luckily. To reproduce #7572, need to revert this patch first. As we talked, #7572 has a deeper reason. Mov demuxer consider that fragmented index is completed if a ‘sidx’ point to the end of the file. But there may be other

Re: [FFmpeg-devel] [PATCH] libavcodec/vp8dec: fix the multi-thread HWAccel decode error

2019-03-05 Thread Li, Zhong
> > > if (width != s->avctx->width || ((width+15)/16 != s->mb_width || > > > (height+15)/16 != s->mb_height) && s->macroblocks_base || > > > height != s->avctx->height) { > > >... > > >ff_set_dimensions(...); > > > } > > > > > > The condition for updating dimensions is

[FFmpeg-devel] [PATCH v2] avformat/mpegts: reduce buffering during initialization

2019-03-05 Thread Andriy Gelman
From: Andriy Gelman Reduces buffering latency with low bitrate streams, where 8192 bytes can mean several seconds. --- libavformat/mpegts.c | 60 +++- 1 file changed, 37 insertions(+), 23 deletions(-) diff --git a/libavformat/mpegts.c

Re: [FFmpeg-devel] [PATCH 1/1] avformat/dashenc: Added #EXT-X-PROGRAM-DATE-TIME to HLS playlists

2019-03-05 Thread Jeyapal, Karthick
On 3/5/19 8:07 PM, joepadmiraal wrote: > --- > libavformat/dashenc.c | 20 ++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c > index c5e882f4ae..6bcdc9ba36 100644 > --- a/libavformat/dashenc.c > +++

[FFmpeg-devel] [PATCH 3/4] lavfi/nlmeans: Checking number precision when computing integral images

2019-03-05 Thread Jun Zhao
From: Jun Zhao accumulation of 8-bits uint_8 (uint8_t *src) into 32-bits (uint32_t *ii) data type, it will have a risk of an integral value becoming larger than the 32-bits integer capacity and resulting in an integer overflow. For this risk, add a checking with warning message. Signed-off-by:

[FFmpeg-devel] [PATCH 4/4] doc/bsfs: h264_metadata: Update docs about display orientation SEI

2019-03-05 Thread Jun Zhao
From: Jun Zhao Add docs about display orientation SEI. Signed-off-by: Jun Zhao --- doc/bitstream_filters.texi | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 076b910..83ef89c 100644 ---

[FFmpeg-devel] [PATCH 2/4] lavfi/tonemap: make use of AVFILTER_DEFINE_CLASS

2019-03-05 Thread Jun Zhao
From: Jun Zhao use AVFILTER_DEFINE_CLASS for defining the filter classes Signed-off-by: Jun Zhao --- libavfilter/vf_tonemap.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_tonemap.c b/libavfilter/vf_tonemap.c index 98a2c4b..efd4af5 100644 ---

[FFmpeg-devel] [PATCH 1/4] lavfi/zscale: make use of AVFILTER_DEFINE_CLASS

2019-03-05 Thread Jun Zhao
From: Jun Zhao use AVFILTER_DEFINE_CLASS for defining the filter classes Signed-off-by: Jun Zhao --- libavfilter/vf_zscale.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index 6e1d36c..f030927 100644 ---

Re: [FFmpeg-devel] [PATCH] avformat/mpegts.c: reduce buffering during initialization

2019-03-05 Thread Michael Niedermayer
On Mon, Mar 04, 2019 at 10:21:01PM -0500, andriy.gel...@gmail.com wrote: > From: Andriy Gelman > > Reduces buffering during estimation of mpegts raw_packet_size > parameter. Instead of buffering a fixed 8192 bytes, calculate > probe scores on a smaller buffer. Increase buffer size until > probe

Re: [FFmpeg-devel] [PATCH] avformat/mpegts.c: reduce buffering during initialization

2019-03-05 Thread Marton Balint
On Mon, 4 Mar 2019, andriy.gel...@gmail.com wrote: From: Andriy Gelman Reduces buffering during estimation of mpegts raw_packet_size parameter. Instead of buffering a fixed 8192 bytes, calculate probe scores on a smaller buffer. Increase buffer size until probe score is greater than minimum

Re: [FFmpeg-devel] avcodec/proresenc_aw : improve speed by replacing PutBitContext for codeword encoding

2019-03-05 Thread Michael Niedermayer
On Tue, Mar 05, 2019 at 11:28:56AM +0100, Martin Vignali wrote: > Hello, > > do i understand correctly that there is no check that prevents out of array > > writing ? > > not even an assert > > If thats the case, then i think this is unwise. > > > > > Thanks for testing. > > For the buffer

Re: [FFmpeg-devel] [PATCH v6 2/2] doc: Add libsvt_hevc encoder docs

2019-03-05 Thread Mark Thompson
On 05/03/2019 07:43, Jing SUN wrote: > Add docs for libsvt_hevc encoder in encoders.texi and general.texi > > Signed-off-by: Jun Zhao > Signed-off-by: Huang, Zhengxu > Signed-off-by: hassene > Signed-off-by: Jing SUN > --- > doc/encoders.texi | 161 >

Re: [FFmpeg-devel] [PATCH v6 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-05 Thread Mark Thompson
On 05/03/2019 07:43, Jing SUN wrote: > From: Jing Sun > > base on patch by Huang, Zhengxu from https://github.com/intel/SVT-HEVC > > V4: - Fix the build error with new API in PR#52 > - Fix the encoding hang issue by API change in PR#52 > - Fix the last frame dropping issue > - Fix

Re: [FFmpeg-devel] [PATCH] avformat/mpegts.c: reduce buffering during initialization

2019-03-05 Thread Andriy Gelman
> What is the issue that you are seeing and that this patch fix? Is it only > matters for low bitrate mpegts? (like 64 kbps streams?) Or does this > improve high bitrate streams as well somehow? I'm muxing hevc video + very low bitrate binary messages into mpegts. If the hevc video is not

[FFmpeg-devel] [PATCH 5/5] avfilter/af_astats: add support for optimized min/max/peak calculation

2019-03-05 Thread Marton Balint
Signed-off-by: Marton Balint --- libavfilter/af_astats.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/libavfilter/af_astats.c b/libavfilter/af_astats.c index 9915a7965e..92368793c2 100644 --- a/libavfilter/af_astats.c +++

[FFmpeg-devel] [PATCH 4/5] avfilter/af_astats: rework sample loops

2019-03-05 Thread Marton Balint
The channel loop is now the outer loop for both planar and interleaved. This is needed by the next patch, and the speed difference is negligable if any. Signed-off-by: Marton Balint --- libavfilter/af_astats.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[FFmpeg-devel] [PATCH 1/5] avfilter/af_astats: add support for selecting measured statistics

2019-03-05 Thread Marton Balint
set_metadata with many entries is not very efficient, and with small audio frames the performance loss is noticable. Also with this very simple calculations (like peak) can be even further optimized. Unfoturnately there are some small differences in metadata and av_log info output, so factorizing

[FFmpeg-devel] [PATCH 3/5] avfilter/af_astats: factorize sample loops

2019-03-05 Thread Marton Balint
Signed-off-by: Marton Balint --- libavfilter/af_astats.c | 108 +--- 1 file changed, 37 insertions(+), 71 deletions(-) diff --git a/libavfilter/af_astats.c b/libavfilter/af_astats.c index ddda84cfbb..f45558909a 100644 --- a/libavfilter/af_astats.c +++

[FFmpeg-devel] [PATCH 2/5] avfilter/af_astats: fix identation

2019-03-05 Thread Marton Balint
Signed-off-by: Marton Balint --- libavfilter/af_astats.c | 148 1 file changed, 74 insertions(+), 74 deletions(-) diff --git a/libavfilter/af_astats.c b/libavfilter/af_astats.c index 09fbd8c1ae..ddda84cfbb 100644 --- a/libavfilter/af_astats.c +++

[FFmpeg-devel] [PATCH 1/2] avcodec/cdgraphics: Use ff_set_dimensions()

2019-03-05 Thread Michael Niedermayer
Fixes: Timeout (17 sec -> 65 milli sec) Fixes: 13264/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CDGRAPHICS_fuzzer-5711167941509120 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 2/2] avcodec/dvbsubdec: Check object position

2019-03-05 Thread Michael Niedermayer
Reference: ETSI EN 300 743 V1.2.1 7.2.2 Region composition segment Fixes: Timeout Fixes: 13325/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DVBSUB_fuzzer-5143979392237568 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH v1] avformat/smoothstreamingenc:add bitrate calculate

2019-03-05 Thread Jun Li
From: jun Calculate bitrate based on fragment size, only applied when bitrate is not set, for example rtsp source. Signed-off-by: Jun Li --- libavformat/smoothstreamingenc.c | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix hang while seek on a kind of fragmented mp4.

2019-03-05 Thread Anthony Recascino
the bug that caused the hang is absolutely still present, the fix that was pushed was only fixing the surface level issue of the hang. > On Mar 5, 2019, at 11:28 AM, Carl Eugen Hoyos wrote: > > 2019-03-05 17:02 GMT+01:00, Charles Liu : >> 1. organize fragmented information according to the

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libdav1d: use a custom picture allocator

2019-03-05 Thread James Almer
On 3/5/2019 3:19 PM, Vittorio Giovara wrote: > On Mon, Mar 4, 2019 at 4:08 PM James Almer wrote: > >> Replaces the libdav1d internal allocator. It uses an AVBufferPool to >> reduce the >> amount of allocated buffers. >> About 5% speed up when decoding 720p or higher streams. >> >> Signed-off-by:

Re: [FFmpeg-devel] [PATCH] libdav1d: Add support for reading hdr10 metadata

2019-03-05 Thread James Almer
On 3/5/2019 3:19 PM, Vittorio Giovara wrote: > --- > configure | 2 +- > libavcodec/libdav1d.c | 30 +- > 2 files changed, 30 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index dcead3a300..a5cef4bc09 100755 > --- a/configure >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libdav1d: use a custom picture allocator

2019-03-05 Thread Vittorio Giovara
On Mon, Mar 4, 2019 at 4:08 PM James Almer wrote: > Replaces the libdav1d internal allocator. It uses an AVBufferPool to > reduce the > amount of allocated buffers. > About 5% speed up when decoding 720p or higher streams. > > Signed-off-by: James Almer > --- > get_buffer2() can't be used for

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libdav1d: route dav1d internal logs through av_log()

2019-03-05 Thread Vittorio Giovara
On Mon, Mar 4, 2019 at 4:08 PM James Almer wrote: > Bump the minimum required version to the first one with the logger API > callback. > > Signed-off-by: James Almer > --- > configure | 2 +- > libavcodec/libdav1d.c | 9 + > 2 files changed, 10 insertions(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH v6 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-05 Thread Vittorio Giovara
On Tue, Mar 5, 2019 at 1:45 AM Jing SUN wrote: > From: Jing Sun > > base on patch by Huang, Zhengxu from https://github.com/intel/SVT-HEVC > > V4: - Fix the build error with new API in PR#52 > - Fix the encoding hang issue by API change in PR#52 > - Fix the last frame dropping issue >

[FFmpeg-devel] [PATCH] libdav1d: Add support for reading hdr10 metadata

2019-03-05 Thread Vittorio Giovara
--- configure | 2 +- libavcodec/libdav1d.c | 30 +- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/configure b/configure index dcead3a300..a5cef4bc09 100755 --- a/configure +++ b/configure @@ -6142,7 +6142,7 @@ enabled libcelt

Re: [FFmpeg-devel] [PATCH] avcodec/imm4: add support for mid-stream size changes

2019-03-05 Thread Paul B Mahol
On 3/1/19, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/imm4.c | 27 +++ > 1 file changed, 15 insertions(+), 12 deletions(-) > Will apply. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avformat/mpegts.c: reduce buffering during initialization

2019-03-05 Thread Marton Balint
On Mon, 4 Mar 2019, andriy.gel...@gmail.com wrote: From: Andriy Gelman Reduces buffering during estimation of mpegts raw_packet_size parameter. Instead of buffering a fixed 8192 bytes, calculate probe scores on a smaller buffer. Increase buffer size until probe score is greater than minimum

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix hang while seek on a kind of fragmented mp4.

2019-03-05 Thread Carl Eugen Hoyos
2019-03-05 17:02 GMT+01:00, Charles Liu : > 1. organize fragmented information according to the tracks. > 2. do NOT skip the last boxes of fragmented info. > ticket #7572 Assuming the ticket is not reproducible for you with current FFmpeg git head (it wasn't for me two weeks ago), please reword

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix hang while seek on a kind of fragmented mp4.

2019-03-05 Thread C.H.Liu
Thanks for your reply. If a track id of the test clip does not appear in its ‘moov’, the do/while loop cannot exit indeed. The purpose of this patch is to solve AV_NOPTS_VALUE in the fragment info structure. Because the original structures is oriented to ‘moof’ boxes in file. I tried to organize

[FFmpeg-devel] [PATCH] avformat/mov: fix hang while seek on a kind of fragmented mp4.

2019-03-05 Thread Charles Liu
1. organize fragmented information according to the tracks. 2. do NOT skip the last boxes of fragmented info. ticket #7572 Signed-off-by: Charles Liu --- libavformat/isom.h | 10 +- libavformat/mov.c | 378 + 2 files changed, 185 insertions(+), 203

[FFmpeg-devel] [PATCH 1/1] avformat/dashenc: Added #EXT-X-PROGRAM-DATE-TIME to HLS playlists

2019-03-05 Thread joepadmiraal
--- libavformat/dashenc.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index c5e882f4ae..6bcdc9ba36 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -61,6 +61,7 @@ typedef struct Segment {

[FFmpeg-devel] [PATCH 0/1] avformat/dashenc: Added #EXT-X-PROGRAM-DATE-TIME to HLS playlists

2019-03-05 Thread joepadmiraal
This is the third attempt for a patch that adds the #EXT-X-PROGRAM-DATE-TIME tag to HLS playlists when using the Dash muxer. Thanks for reviewing the previous patches. I used both a _ms and a _s variable to be in line with format_date_now(). However this is redundant in my use case so I changed

Re: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to match documentation

2019-03-05 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Tuesday, March 05, 2019 8:52 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to > match documentation > > On

Re: [FFmpeg-devel] avcodec/proresenc_aw : improve speed by replacing PutBitContext for codeword encoding

2019-03-05 Thread Martin Vignali
Hello, do i understand correctly that there is no check that prevents out of array > writing ? > not even an assert > If thats the case, then i think this is unwise. > > Thanks for testing. For the buffer check, i can add a test (assert or error), before slice plane encoding, in order to check