Re: [FFmpeg-devel] [PATCH] avformat/mpegenc - reject unsupported audio streams

2019-04-21 Thread Gyan
On 20-04-2019 03:01 PM, Gyan wrote: Old patch that was never applied. Rebased. Plan to push tonight if no changes. Thanks, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH 1/4] cbs_mpeg2: Correct and use enum values

2019-04-21 Thread James Almer
On 4/21/2019 11:04 AM, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cbs_mpeg2.c | 24 +++- > libavcodec/cbs_mpeg2.h | 2 +- > libavcodec/cbs_mpeg2_syntax_template.c | 10 +- > 3 files changed, 17

[FFmpeg-devel] Help:The Android Q Release compatibility problem

2019-04-21 Thread heyunhao
Due to the next major release of android employs the sandbox mechanism, refer to : https://source.android.com/security/app-sandbox. The Old way of accessing files is not working anymore, the app cannot access another app's private file directly by passing the filename parameter. Is there any

[FFmpeg-devel] [PATCH v1] lavf/dashenc: Add option for calculting pkt duration

2019-04-21 Thread Jun Li
Fix #7144. The current packet duration calculation is heuristic, which uses the historical durtion as current duration. This commit adds the option to buffer one packet and calcuate its duration when next packet arrives. Obviously it adds one frame latency, which might be significant for VFR live

Re: [FFmpeg-devel] [PATCH 14/15] avformat/matroskaenc: Improve log messages for blocks

2019-04-21 Thread Andreas Rheinhardt
Michael Niedermayer: > On Sat, Apr 20, 2019 at 01:41:09AM +0200, Andreas Rheinhardt wrote: >> Up until now, a block's relative offset has been reported as the offset >> in the log messages output when writing blocks; given that it is >> impossible to know the real offset from the beginning of the

Re: [FFmpeg-devel] [PATCH v2] lavf/img2enc: add support for option strftime_start_realtime

2019-04-21 Thread Steven Liu
> 在 2019年4月22日,04:50,Jun Li 写道: > > On Thu, Apr 18, 2019 at 5:59 PM Jun Li wrote: > >> Currently the strftime option generate timestamp based on generation >> time. The new option would calcualte timestamp from start_time_realtime >> and pkt->pts, based on output's timescale. >> --- >>

Re: [FFmpeg-devel] [PATCH 14/15] avformat/matroskaenc: Improve log messages for blocks

2019-04-21 Thread Michael Niedermayer
On Sat, Apr 20, 2019 at 01:41:09AM +0200, Andreas Rheinhardt wrote: > Up until now, a block's relative offset has been reported as the offset > in the log messages output when writing blocks; given that it is > impossible to know the real offset from the beginning of the file at > this point due

Re: [FFmpeg-devel] [PATCH] libavformat/mov: limit nb_frames_for_fps to INT_MAX

2019-04-21 Thread Michael Niedermayer
On Sat, Apr 20, 2019 at 12:59:29AM +0300, Dan Sanders via ffmpeg-devel wrote: > Date: Fri, 19 Apr 2019 14:52:01 -0700 > From: Dan Sanders > To: FFmpeg development discussions and patches > Subject: [PATCH] libavformat/mov: limit nb_frames_for_fps to INT_MAX > > Fixes: UBSan runtime error >

Re: [FFmpeg-devel] [PATCH v2] lavf/img2enc: add support for option strftime_start_realtime

2019-04-21 Thread Jun Li
On Thu, Apr 18, 2019 at 5:59 PM Jun Li wrote: > Currently the strftime option generate timestamp based on generation > time. The new option would calcualte timestamp from start_time_realtime > and pkt->pts, based on output's timescale. > --- > doc/muxers.texi | 5 + >

Re: [FFmpeg-devel] [PATCH v3] lavfi: add colorkey_opencl filter

2019-04-21 Thread Paul B Mahol
On 4/20/19, Mark Thompson wrote: > On 17/04/2019 03:08, Jarek Samic wrote: >> This is a direct port of the CPU filter. >> >> Signed-off-by: Jarek Samic >> --- >> More fixes based on the comments from the second version of the patch >> (moving sampler declaration into the program scope,

Re: [FFmpeg-devel] [PATCH 2/4] cbs_mpeg2: Improve checks for invalid values

2019-04-21 Thread James Almer
On 4/21/2019 11:04 AM, Andreas Rheinhardt wrote: > horizontal/vertical_size_value (containing the twelve least significant > bits of the frame size) mustn't be zero according to the specifications; > and the value 0 is forbidden for the colour_description elements. > > Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH 3/4] mpeg2_metadata, cbs_mpeg2: Fix handling of colour_description

2019-04-21 Thread James Almer
On 4/21/2019 11:04 AM, Andreas Rheinhardt wrote: > If a sequence display extension is read with colour_description equal to > zero, but a user wants to add one or more of the colour_description > elements, then the colour_description elements the user did not explicitly > request to be set are set

[FFmpeg-devel] [PATCH v3] avformat/utils: Use av_packet_move_ref for packet ownership transfer

2019-04-21 Thread Andriy Gelman
From: Andriy Gelman During AVPacket assignment, it is currently not clear when the lhs takes ownership of the packet. This commit replaces assignment with an explicit av_packet_move_ref call when there is an ownership transfer to clear the distinction. --- libavformat/utils.c | 30

[FFmpeg-devel] [PATCH 2/4] cbs_mpeg2: Improve checks for invalid values

2019-04-21 Thread Andreas Rheinhardt
horizontal/vertical_size_value (containing the twelve least significant bits of the frame size) mustn't be zero according to the specifications; and the value 0 is forbidden for the colour_description elements. Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_mpeg2.c | 17

[FFmpeg-devel] [PATCH 1/4] cbs_mpeg2: Correct and use enum values

2019-04-21 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_mpeg2.c | 24 +++- libavcodec/cbs_mpeg2.h | 2 +- libavcodec/cbs_mpeg2_syntax_template.c | 10 +- 3 files changed, 17 insertions(+), 19 deletions(-) diff --git

[FFmpeg-devel] [PATCH 0/4] cbs_mpeg2, mpeg2_metadata

2019-04-21 Thread Andreas Rheinhardt
Hello, mpeg2_metadata currently has a bug wrt its handling of the colour_description elements in case the input already had a sequence_display_extension, but with colour_description set to zero. Then the colour_description elements are zero at the end of the read process; but zero is a forbidden

[FFmpeg-devel] [PATCH 4/4] cbs_mpeg2: Correct error codes

2019-04-21 Thread Andreas Rheinhardt
Up until now, things that are merely unsupported by cbs_mpeg2 have been declared to be invalid input. This has been changed. Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_mpeg2.c | 4 +--- libavcodec/cbs_mpeg2_syntax_template.c | 4 ++-- 2 files changed, 3 insertions(+),

[FFmpeg-devel] [PATCH 3/4] mpeg2_metadata, cbs_mpeg2: Fix handling of colour_description

2019-04-21 Thread Andreas Rheinhardt
If a sequence display extension is read with colour_description equal to zero, but a user wants to add one or more of the colour_description elements, then the colour_description elements the user did not explicitly request to be set are set to zero and not to the value equal to

Re: [FFmpeg-devel] [PATCH V2] lavfi/frei0r: Fixes the compilation warnings

2019-04-21 Thread Paul B Mahol
On 4/21/19, Jun Zhao wrote: > From: Jun Zhao > > Fixes the compilation warnings > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_frei0r.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavfilter/vf_frei0r.c b/libavfilter/vf_frei0r.c > index c775ed1..165fbd7

[FFmpeg-devel] [PATCH V2] lavfi/frei0r: Fixes the compilation warnings

2019-04-21 Thread Jun Zhao
From: Jun Zhao Fixes the compilation warnings Signed-off-by: Jun Zhao --- libavfilter/vf_frei0r.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavfilter/vf_frei0r.c b/libavfilter/vf_frei0r.c index c775ed1..165fbd7 100644 --- a/libavfilter/vf_frei0r.c +++

Re: [FFmpeg-devel] [PATCH V2 2/2] lavfi/opencl: add nlmeans_opencl filter

2019-04-21 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Mark Thompson > Sent: Saturday, April 20, 2019 11:08 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V2 2/2] lavfi/opencl: add nlmeans_opencl > filter > > On

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-21 Thread Paul B Mahol
On 4/21/19, Nicolas George wrote: > I apperciate the efforts to reply more than half a line. > > Paul B Mahol (12019-04-21): >> It is not kind of resampling. Resampling is specific and belongs to >> separate library. > > There is no doubt it IS a kind of resampling: it is in the name. The >

Re: [FFmpeg-devel] [PATCH v2] avformat/utils: Use av_packet_move_ref for packet ownership transfer

2019-04-21 Thread Michael Niedermayer
On Mon, Apr 08, 2019 at 02:03:31PM -0400, Andriy Gelman wrote: > From: Andriy Gelman > > This commit replaces packet assignment operator with av_packet_move_ref > when there is a packet ownership transfer. > --- > Michael, the update patch now has correct behavior for ticket 4221. > >

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-21 Thread Nicolas George
I apperciate the efforts to reply more than half a line. Paul B Mahol (12019-04-21): > It is not kind of resampling. Resampling is specific and belongs to > separate library. There is no doubt it IS a kind of resampling: it is in the name. The question is whether is it specific enough to warrant

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/agm: Do not crash on invalid codes

2019-04-21 Thread Michael Niedermayer
On Sun, Apr 21, 2019 at 11:31:10AM +0200, Paul B Mahol wrote: > On 4/21/19, Michael Niedermayer wrote: > > I do not know if such vlc trees are allowed in agm, I have no specification > > So i do not know if these should be treated as error, or not. > > But the code does contain a check for idx <

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/agm: Check for too many too short codes in make_new_tree()

2019-04-21 Thread Michael Niedermayer
On Sun, Apr 21, 2019 at 11:36:00AM +0200, Paul B Mahol wrote: > On 4/21/19, Michael Niedermayer wrote: > > Fixes: SEGV on unknown address > > Fixes: > > 14198/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AGM_fuzzer-5723579234123776 > > > > untested due to lack of valid samples using this

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/agm: remove ;;

2019-04-21 Thread Michael Niedermayer
On Sun, Apr 21, 2019 at 11:31:26AM +0200, Paul B Mahol wrote: > On 4/21/19, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/agm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/agm.c b/libavcodec/agm.c > > index

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-21 Thread Paul B Mahol
On 4/21/19, Nicolas George wrote: > Paul B Mahol (12019-04-19): >> Generic resampling via aresample is completely another filtering that >> have >> nothing to do with this filters, for more info read: >> >> https://www.oblique-audio.com/technique/oversampling > > Quite the opposite: this page

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-21 Thread Nicolas George
Paul B Mahol (12019-04-19): > Generic resampling via aresample is completely another filtering that have > nothing to do with this filters, for more info read: > > https://www.oblique-audio.com/technique/oversampling Quite the opposite: this page makes it rather clear that oversampling is a kind

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/agm: Do not crash on invalid codes

2019-04-21 Thread Paul B Mahol
On 4/21/19, Michael Niedermayer wrote: > I do not know if such vlc trees are allowed in agm, I have no specification > So i do not know if these should be treated as error, or not. > But the code does contain a check for idx < 0 already ... > > untested due to lack of valid samples using this

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/agm: Check for too many too short codes in make_new_tree()

2019-04-21 Thread Paul B Mahol
On 4/21/19, Michael Niedermayer wrote: > Fixes: SEGV on unknown address > Fixes: > 14198/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AGM_fuzzer-5723579234123776 > > untested due to lack of valid samples using this codepath > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/agm: remove ;;

2019-04-21 Thread Paul B Mahol
On 4/21/19, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/agm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/agm.c b/libavcodec/agm.c > index c9d7be5521..7dcfaff4ad 100644 > --- a/libavcodec/agm.c > +++

[FFmpeg-devel] [PATCH 2/3] avcodec/agm: Check for too many too short codes in make_new_tree()

2019-04-21 Thread Michael Niedermayer
Fixes: SEGV on unknown address Fixes: 14198/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AGM_fuzzer-5723579234123776 untested due to lack of valid samples using this codepath Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 1/3] avcodec/agm: Do not crash on invalid codes

2019-04-21 Thread Michael Niedermayer
I do not know if such vlc trees are allowed in agm, I have no specification So i do not know if these should be treated as error, or not. But the code does contain a check for idx < 0 already ... untested due to lack of valid samples using this codepath Fixes: Stack-buffer-overflow in

[FFmpeg-devel] [PATCH 3/3] avcodec/agm: remove ;;

2019-04-21 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/agm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/agm.c b/libavcodec/agm.c index c9d7be5521..7dcfaff4ad 100644 --- a/libavcodec/agm.c +++ b/libavcodec/agm.c @@ -943,7 +943,7 @@ static int make_new_tree(const

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/agm: add support for higher compression

2019-04-21 Thread Michael Niedermayer
On Sun, Apr 21, 2019 at 08:50:04AM +0200, Paul B Mahol wrote: > On 4/21/19, Michael Niedermayer wrote: > > On Wed, Apr 10, 2019 at 01:45:51PM +0200, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol > >> --- > >> libavcodec/agm.c | 404 +++-- > >>

[FFmpeg-devel] [PATCH] avcodec/rkmpp: stop blocking output while input is not full

2019-04-21 Thread Cameron Gutman
By requiring that the decoder stay full, we introduce unnecessary output latency when decoding from a real-time source. Additionally, we can cause MPP to assert if we submit data, but don't actually output a frame before closing our decoding session, because it expects us to read the format change

[FFmpeg-devel] [PATCH V1 1/2] examples/avio_reading: Use avio_context_free() to free AVIOContext

2019-04-21 Thread Jun Zhao
From: Jun Zhao Signed-off-by: Jun Zhao --- doc/examples/avio_reading.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/examples/avio_reading.c b/doc/examples/avio_reading.c index cbfeb17..36ee02a 100644 --- a/doc/examples/avio_reading.c +++

Re: [FFmpeg-devel] [PATCH V1 2/2] lavf/frei0r: Fixes the compilation warnings

2019-04-21 Thread Paul B Mahol
Subject should be lavfi/frei0r On 4/21/19, Jun Zhao wrote: > From: Jun Zhao > > Fixes the compilation warnings > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_frei0r.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavfilter/vf_frei0r.c

[FFmpeg-devel] [PATCH V1 2/2] lavf/frei0r: Fixes the compilation warnings

2019-04-21 Thread Jun Zhao
From: Jun Zhao Fixes the compilation warnings Signed-off-by: Jun Zhao --- libavfilter/vf_frei0r.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavfilter/vf_frei0r.c b/libavfilter/vf_frei0r.c index c775ed1..165fbd7 100644 --- a/libavfilter/vf_frei0r.c +++

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/agm: add support for higher compression

2019-04-21 Thread Paul B Mahol
On 4/21/19, Michael Niedermayer wrote: > On Wed, Apr 10, 2019 at 01:45:51PM +0200, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/agm.c | 404 +++-- >> libavformat/riff.c | 4 + >> 2 files changed, 392 insertions(+), 16