[FFmpeg-devel] [PATCH v4] lavu/display: add av_display_rotation_get2 and bump version

Add av_display_rotation_get2 to get information whether the matrix indicates horizontal flip. --- doc/APIchanges| 3 +++ libavutil/display.c | 13 + libavutil/display.h | 14 ++ libavutil/tests/display.c | 26 ++ libavutil/ve

Re: [FFmpeg-devel] [PATCH v2] doc/filters: add the sr filter model generation scripts new repository link

> 在 2019年5月17日，下午1:20，Gyan 写道： > > > > On 17-05-2019 10:36 AM, Liu Steven wrote: >> >>> 在 2019年5月17日，下午12:46，Gyan 写道： >>> >>> >>> >>> On 17-05-2019 03:14 AM, Steven Liu wrote: > 在 2019年5月17日，02:57，Gyan 写道： > > > > On 16-05-2019 11:13 AM, Steven Liu wrote: >> H

Re: [FFmpeg-devel] [PATCH v2] doc/filters: add the sr filter model generation scripts new repository link

On 17-05-2019 10:36 AM, Liu Steven wrote: 在 2019年5月17日，下午12:46，Gyan 写道： On 17-05-2019 03:14 AM, Steven Liu wrote: 在 2019年5月17日，02:57，Gyan 写道： On 16-05-2019 11:13 AM, Steven Liu wrote: Hold on the old repository link and mention new repository link development continues Signed-off

Re: [FFmpeg-devel] [PATCH v2] doc/filters: add the sr filter model generation scripts new repository link

> 在 2019年5月17日，下午12:46，Gyan 写道： > > > > On 17-05-2019 03:14 AM, Steven Liu wrote: >> >>> 在 2019年5月17日，02:57，Gyan 写道： >>> >>> >>> >>> On 16-05-2019 11:13 AM, Steven Liu wrote: Hold on the old repository link and mention new repository link development continues Sign

Re: [FFmpeg-devel] [PATCH v2] doc/filters: add the sr filter model generation scripts new repository link

On 17-05-2019 03:14 AM, Steven Liu wrote: 在 2019年5月17日，02:57，Gyan 写道： On 16-05-2019 11:13 AM, Steven Liu wrote: Hold on the old repository link and mention new repository link development continues Signed-off-by: Steven Liu --- doc/filters.texi | 3 ++- 1 file changed, 2 insertion

Re: [FFmpeg-devel] [PATCH v3 2/2] fftools/ffmpeg: add support for per frame rotation and flip

On Thu, 16. May 18:28, Jun Li wrote: > On Thu, May 16, 2019 at 12:54 PM Andriy Gelman > wrote: > > > Hi Jun, > > > > On Thu, 16. May 00:12, Jun Li wrote: > > > Fix #6945 > > > Current implementaion for autorotate works fine for stream > > > level rotataion but no support for frame level operation

Re: [FFmpeg-devel] [PATCH 1/2] avformat/dashenc: use 64bit for handling the return of avio_tell()

On 5/14/19 4:34 PM, Michael Niedermayer wrote: > The return code is 64bit, so this is more correct, especially in case it > actually would be a file of such large size > > Signed-off-by: Michael Niedermayer > --- > libavformat/dashenc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] Export display matrix mirroring info as part of the rotate API

On Thu, May 16, 2019 at 9:32 PM Jun Li wrote: > On Thu, May 16, 2019 at 4:34 PM Ted Meyer < > tmathmeyer-at-google@ffmpeg.org> wrote: > > > Right now ffmpeg doesn't export a mirroring status when checking the > > display matrix for rotation. > > Here is an example video: https://files.tedm.io

Re: [FFmpeg-devel] Export display matrix mirroring info as part of the rotate API

On Thu, May 16, 2019 at 4:34 PM Ted Meyer < tmathmeyer-at-google@ffmpeg.org> wrote: > Right now ffmpeg doesn't export a mirroring status when checking the > display matrix for rotation. > Here is an example video: https://files.tedm.io/flip.mp4 > -Ted >

Re: [FFmpeg-devel] [PATCH v3 2/2] fftools/ffmpeg: add support for per frame rotation and flip

On Thu, May 16, 2019 at 12:54 PM Andriy Gelman wrote: > Hi Jun, > > On Thu, 16. May 00:12, Jun Li wrote: > > Fix #6945 > > Current implementaion for autorotate works fine for stream > > level rotataion but no support for frame level operation > > and frame flip. This patch is for adding flip supp

Re: [FFmpeg-devel] [PATCH v3 2/2] fftools/ffmpeg: add support for per frame rotation and flip

On Thu, May 16, 2019 at 12:04 PM Paul B Mahol wrote: > On 5/16/19, Nicolas George wrote: > > Jun Li (12019-05-16): > >> Sure. > >> This patch is checking the frame's orientation status, and apply input > >> filter if necessary. > >>frame 1 -> check orientation -> get 2 -> need flip --> goto

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of James Almer > Sent: Friday, May 17, 2019 5:30 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx) > > On 5/16/2019 6:06 PM, Lynne wrot

[FFmpeg-devel] Export display matrix mirroring info as part of the rotate API

Right now ffmpeg doesn't export a mirroring status when checking the display matrix for rotation. Here is an example video: https://files.tedm.io/flip.mp4 -Ted From 7121cecdd54f403cb857dbfd056ca22253d6948a Mon Sep 17 00:00:00 2001 From: Ted Meyer Date: Thu, 16 May 2019 14:17:51 -0700 Subject: [PAT

[FFmpeg-devel] [PATCH 09/37] avformat/matroskadec: Remove redundant initialization

Every new element of an EbmlList is zeroed initially in ebml_parse_elem, so that in particular a SimpleBlock's duration is initialized to zero. Therefore it is unnecessary to initialize this field again (for SimpleBlocks) in matroska_parse_cluster_incremental. Signed-off-by: Andreas Rheinhardt --

[FFmpeg-devel] [PATCH 11/37] avformat/matroskadec: Improve read error/EOF checks I

ebml_read_num had a number of flaws: 1. The check for read errors/EOF was totally wrong. E.g. an EBML number beginning with the invalid 0x00 would be considered a read error, although it is just invalid data. 2. The check for read errors/EOF was done just once, after reading the first byte of the

[FFmpeg-devel] [PATCH 12/37] avformat/matroskadec: Improve read error/EOF checks II

This commit fixes a number of bugs: 1. There was no check that no read error/EOF occured during ebml_read_uint, ebml_read_sint and ebml_read_float. 2. ebml_read_ascii and ebml_read_binary did sometimes not forward error codes; instead they simply returned AVERROR(EIO). 3. In particular, AVERROR_EO

[FFmpeg-devel] [PATCH 07/37] avformat/matroskadec: Set offset of first cluster

By default, the data_offset member of the AVFormatInternal of the AVFormatContext associated with the MatroskaDemuxContext has not been initialized explicitly by any Matroska-specific function, so that it was initialized by default to the offset at the end of matroska_read_header, i.e. usually to t

[FFmpeg-devel] [PATCH 05/37] avformat/matroskadec: Get rid of cluster size field assumption

The earlier code relied on the length of clusters always being coded on eight bytes as was the behaviour of libavformat's Matroska muxer until recently. But given that our own Matroska muxer now (and mkvmerge from time immemorial) creates files that don't conform to this assumption, it is high time

[FFmpeg-devel] [PATCH 03/37] avformat/matroskadec: Compactify structure

Matroska EBML IDs can be only four bytes long maximally, so it is natural to use uint32_t for them. By doing this and rearranging the elements of the MatroskaLevel1Element structure, one can reduce the size of said structure. Notice that this field is not read via the generic reading process for E

[FFmpeg-devel] [PATCH 15/37] avformat/matroskadec: Don't keep old blocks

Before this commit, the Matroska muxer would read a block when required to do so, parse the block, create and return the necessary AVPackets and yet keep the blocks (in a dynamically allocated list), although they aren't used at all any more. This has been changed. There is no list any more and the

[FFmpeg-devel] [PATCH 10/37] avformat/matroskadec: Properly check return values

Up until now, webm_dash_manifest_cues used the return values of ebml_read_num and ebml_read_length without checking for errors, i.e. return values < 0. This has been changed. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 17 +++-- 1 file changed, 11 insertions(+),

[FFmpeg-devel] [PATCH 02/37] avformat/matroskadec: Correct outdated error message

This error message is outdated since d31fb1a9. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index ed901f19ab..6da9b15d79 100644 --- a/libavformat/matroskad

[FFmpeg-devel] [PATCH 08/37] avformat/matroskadec: Don't copy attached pictures

This commit replaces copying attached pictures by using references to the already existing buffers. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matros

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

There isn't one, as I said the added indentation is because of the new loop! On 5/13/19 3:39 PM, Carl Eugen Hoyos wrote: > Am Mi., 10. Apr. 2019 um 13:26 Uhr schrieb Mathieu Duponchelle > : > >> No problem > I don't see an updated patch. > > Carl Eugen > ___

[FFmpeg-devel] [PATCH 06/37] avformat/matroskadec: Use generic size check for signed integers

and drop the redundant checks contained in ebml_read_uint and ebml_read_sint. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 6fd5537f5a..927462d3

[FFmpeg-devel] [PATCH 16/37] avformat/matroskadec: Treat SimpleBlock as EBML_BIN

Up until now, the SimpleBlock was treated specially: It basically had its own EBML category and it was also included in the BlockGroup EBML syntax (although a SimpleBlock must not exist in a BlockGroup according to the Matroska specifications). The latter fact also meant that a MatroskaBlock's buff

[FFmpeg-devel] [PATCH 18/37] avformat/matroskadec: Add function to reset status

This function will be useful later to reset the status (e.g. current level and the already parsed id). Signed-off-by: Andreas Rheinhardt --- This function is not used yet, so compilation will likely result in a warning because of an unused function. This will be fixed with the next commit. Splitt

[FFmpeg-devel] [PATCH 13/37] avformat/matroskadec: Improve error/EOF checks III

Up until now, when an element was skipped, it was relied upon ffio_limit to make sure that there is enough data available to skip. ffio_limit itself relies upon the availability of the file's size. As this needn't be available, the check has been refined: First one byte less than intended is skippe

[FFmpeg-devel] [PATCH 20/37] avformat/matroskadec: Refactor some functions

Since the changes to the parsing of SimpleBlocks, both ebml_parse_id and ebml_parse_elem are only called from one place, so that it is possible to inline these two function calls. This is done, but not completely: ebml_parse_id still exists in a modified form. This is done in preparation for a furt

[FFmpeg-devel] [PATCH 19/37] avformat/matroskadec: Use proper levels after discontínuity

The earlier code set the level to zero upon seeking and after a discontinuity although in both cases parsing (re)starts at a level 1 element. Also set the segment's length to unkown if an error occured in order not to drop any valid data that happens to be beyond the designated end of the segment.

[FFmpeg-devel] [PATCH 36/37] avformat/matroskadec: Use file offsets for level 1 elements

This commit converts the MatroskaLevel1Element struct to use file-based offsets, as opposed to the current practice of using offsets relative to the beginning of the segment in it. This also includes a change from uint64_t to int64_t. This is in preparation to another patch that improves the check

[FFmpeg-devel] [PATCH 37/37] avformat/matroskadec: Improve check for level 1 duplicates

If a file uses unknown-length level 1 elements besides clusters and such elements are after the first cluster, then these elements will usually be parsed twice: Once during parsing of the file header and once when reading the file reaches the position where these elements are located. The second ti

[FFmpeg-devel] [PATCH 32/37] avformat/matroskadec: Accept more unknown-length elements

The current Matroska specifications mandate that only two elements may use an unknown-length length: Segments and clusters. But this was not always so: For the greater part of Matroska's existence, all master elements were allowed to make use of the unknown-length feature. And there were muxers cr

[FFmpeg-devel] [PATCH 35/37] avformat/matroskadec: Reindent after previous commit

Also use the smallest scope possible for a loop variable. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 76 +++ 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index dfd5

[FFmpeg-devel] [PATCH 33/37] avformat/matroskadec: Fix probing of unknown-length headers

matroska_probe did not support the case of an unknown-length EBML header at all; given that libavformat's Matroska muxer used to produce such files in the streaming case, support for them has been added. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 11 --- 1 file cha

[FFmpeg-devel] [PATCH 34/37] avformat/matroskadec: Accept more unknown-length elements II

Up until now, one last kind of unknown-length element hasn't been properly handled: Unknown-length elements that are supposed to be skipped, i.e. the level 1 elements that might reside after the clusters. This commit changes this. To do this, ebml_parse got a mode that essentially tries to skip ev

[FFmpeg-devel] [PATCH 31/37] avformat/matroskadec: Improve invalid length error handling

1. Up until now, the error message for EBML numbers whose length exceeds the limits imposed upon them because of the element's type did not distinguish between known-length and unknown-length elements. As a consequence, the numerical value of the define constant EBML_UNKNOWN_LENGTH was emitted as p

[FFmpeg-devel] [PATCH 28/37] avformat/matroskadec: Reuse positions

Up until now, avio_tell was used multiple times in ebml_parse and its subroutines, although the result of these calls can usually be simply derived from the result of earlier calls to avio_tell. This has been changed. Unnecessary calls to avio_tell in ebml_parse are avoided now. Furthermore, there

[FFmpeg-devel] [PATCH 30/37] avformat/matroskadec: Don't skip too much when unseekable

The Matroska (and WebM) file format achieves forward-compability by insisting that demuxers ignore and skip elements they don't know about. Unfortunately, this complicates the detection of errors as errors resulting from loosing sync can't be reliably distinguished from unknown elements that are pa

[FFmpeg-devel] [PATCH 29/37] avformat/matroskadec: Typos, nits and cosmetics

Cosmetics include reordering EbmlType so that EBML_SINT is adjacent to the other numbers (and matches the order in the switch in ebml_parse) and also reordering the switch for assignment of default values so that it matches the order in EbmlType. Signed-off-by: Andreas Rheinhardt --- libavformat

[FFmpeg-devel] [PATCH 27/37] avformat/matroskadec: Redo EOF handling

This commit closes the last hole in the system of checks for a known-length file ending too early: Now an error message is emitted in case the file ends directly after an EBML element. Furthermore, this commit adds a check and a corresponding warning whether there is data beyond the Matroska segme

[FFmpeg-devel] [PATCH 21/37] avformat/matroskadec: Introduce a "last known good" position

Currently, resyncing during reading packets works as follows: The current position is recorded, then a call to matroska_parse_cluster is made and if said call fails, the demuxer tries to resync from the earlier position. If the call doesn't fail, but also doesn't deliver a packet, then this is loop

[FFmpeg-devel] [PATCH 23/37] avformat/matroskadec: Redo level handling

This commit changes how levels are handled: If the level used for ebml_parse ends directly after an element that has been consumed, then ebml_parse ends the level itself (and any known-length levels that end there as well) and informs the caller via the return value; if the current level is of unkn

[FFmpeg-devel] [PATCH 26/37] avformat/matroskadec: Combine arrays

By including SimpleBlocks and BlockGroups twice in the same EbmlSyntax array (with different semantics), one can reduce the duplication of the other values. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-)

[FFmpeg-devel] [PATCH 25/37] avformat/matroskadec: Don't reset cluster position

The new code does not rely on whether the cluster's position is set or not to infer whether a cluster needs to be closed or not (instead, this is done in ebml_parse), so there is no need to reset the cluster's position at all any more. It will be automatically set to the correct value when a cluste

[FFmpeg-devel] [PATCH 24/37] avformat/matroskadec: Make cluster parsing level compatible

Before this commit, the parsing of clusters mixed EBML levels by allowing elements from different levels in a EbmlSyntax (namely matroska_cluster_parsing). This has been changed. And the level is now explicitly used to determine how to parse. Signed-off-by: Andreas Rheinhardt --- libavformat/mat

[FFmpeg-devel] [PATCH 17/37] avformat/matroskadec: Don't abort resyncing upon seek failure

When an error happens, the Matroska demuxer tries to resync to level 1 elements from an earlier position onwards. If the seek to said earlier position fails, the demuxer currently treats this as an unrecoverable error. And that behaviour is suboptimal as said failure is nothing unrecoverable or une

[FFmpeg-devel] [PATCH 22/37] avformat/matroskadec: Link to parents in syntax tables

By linking to the syntax of the parent (i.e. the containing master element) one can check whether an element is actually part of a higher level in the EBML hierarchy. Knowing this is important for unknown-length levels, because they end when an element that doesn't belong to this, but to a higher h

[FFmpeg-devel] [PATCH 01/37] avformat/matroskadec: Remove unused variables

Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index cba2b3d1f8..ed901f19ab 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@

[FFmpeg-devel] [PATCH 14/37] avformat/matroskadec: Remove non-incremental parsing of clusters

When the new incremental parser was introduced, the old parser was kept, because the new parser was unable to handle the way SSA packets are put into Matroska. But since 2014 (since c7d8dbad) this is no longer needed, so that the old parser can be completely removed. Signed-off-by: Andreas Rheinha

[FFmpeg-devel] [PATCH 04/37] avformat/matroskadec: Don't zero unnecessarily

It is only necessary to zero the initial allocated memory used to store the size of laced frames if the block used Xiph lacing. Otherwise no unintialized data was ever used, so use av_malloc instead of av_mallocz. Also use the correct type for the allocations. Signed-off-by: Andreas Rheinhardt -

[FFmpeg-devel] [PATCH 00/37 v3] Matroska demuxer patches

Hello, here is the patchset for the Matroska demuxer that I already announced last week [1]. It is an improvement upon an earlier patchset from March [2] which has been kindly reviewed by Steve Lhomme. Just as the earlier attempt, it is intended to get rid of a bogus error message introduced in

Re: [FFmpeg-devel] [PATCH v2] doc/filters: add the sr filter model generation scripts new repository link

> 在 2019年5月17日，02:57，Gyan 写道： > > > > On 16-05-2019 11:13 AM, Steven Liu wrote: >> Hold on the old repository link and mention new repository link development >> continues >> >> Signed-off-by: Steven Liu >> --- >> doc/filters.texi | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

May 16, 2019, 10:29 PM by jamr...@gmail.com: > On 5/16/2019 6:06 PM, Lynne wrote: > >> May 16, 2019, 8:43 PM by >> geo...@nsup.org >> : >> >>> Lynne (12019-05-16): >>> I'm not, I still want the 2 checks. >>> >>> Arguments please. As I explained, the first check is

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

On 5/16/2019 6:06 PM, Lynne wrote: > May 16, 2019, 8:43 PM by geo...@nsup.org: > >> Lynne (12019-05-16): >> >>> I'm not, I still want the 2 checks. >>> >> >> Arguments please. As I explained, the first check is harmful to >> applications because it hides bug. >> > > Nevermind, its not really poss

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

May 16, 2019, 8:43 PM by geo...@nsup.org: > Lynne (12019-05-16): > >> I'm not, I still want the 2 checks. >> > > Arguments please. As I explained, the first check is harmful to > applications because it hides bug. > Nevermind, its not really possible to give av_tx_uninit() a NULL double pointer

Re: [FFmpeg-devel] [PATCH v3 2/2] fftools/ffmpeg: add support for per frame rotation and flip

Hi Jun, On Thu, 16. May 00:12, Jun Li wrote: > Fix #6945 > Current implementaion for autorotate works fine for stream > level rotataion but no support for frame level operation > and frame flip. This patch is for adding flip support and > per frame operations. > --- > fftools/cmdutils.c |

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

May 16, 2019, 7:22 PM by jamr...@gmail.com: > On 5/16/2019 3:11 PM, Nicolas George wrote: > >> James Almer (12019-05-16): >> >>> There are two precedents in the codebase, one checking for both the >>> passed argument and then the struct pointer pointed by it (av_bsf_free >>> and av_buffer_unref as

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

Lynne (12019-05-16): > I'm not, I still want the 2 checks. Arguments please. As I explained, the first check is harmful to applications because it hides bug. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mail

Re: [FFmpeg-devel] [PATCH] avcodec/qtrle: return last frame even if unchanged

On Wed, 15 May 2019, Michael Niedermayer wrote: Fixes: Ticket7880 Signed-off-by: Michael Niedermayer --- libavcodec/qtrle.c| 27 +-- tests/ref/fate/qtrle-8bit | 1 + 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/libavcodec/qtrle.c b/libavcodec/

Re: [FFmpeg-devel] [PATCH v3 2/2] fftools/ffmpeg: add support for per frame rotation and flip

On 5/16/19, Nicolas George wrote: > Jun Li (12019-05-16): >> Sure. >> This patch is checking the frame's orientation status, and apply input >> filter if necessary. >>frame 1 -> check orientation -> get 2 -> need flip --> goto filter >>frame 2 -> check orientation -> get 1 -> do nothing >

Re: [FFmpeg-devel] [PATCH v2] doc/filters: add the sr filter model generation scripts new repository link

On 16-05-2019 11:13 AM, Steven Liu wrote: Hold on the old repository link and mention new repository link development continues Signed-off-by: Steven Liu --- doc/filters.texi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 3

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

On Thu, May 16, 2019 at 08:00:55PM +0200, Reimar Döffinger wrote: > On Thu, May 16, 2019 at 09:35:00PM +1000, Peter Ross wrote: > > +static int read_mb_value(GetBitContext *gb) > > +{ > > +int v = 1; > > +int size; > > +OPEN_READER(re, gb); > > + > > +do { > > +int bit; > >

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

On Thu, May 16, 2019 at 08:00:55PM +0200, Reimar Döffinger wrote: > v = 127 + SHOW_UBITS(re, gb, 7); Sorry typo, must be 129 instead of 127. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To un

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

On 5/16/2019 3:11 PM, Nicolas George wrote: > James Almer (12019-05-16): >> There are two precedents in the codebase, one checking for both the >> passed argument and then the struct pointer pointed by it (av_bsf_free >> and av_buffer_unref as i mentioned above), and one checking only the >> struct

Re: [FFmpeg-devel] [PATCH v3 2/2] fftools/ffmpeg: add support for per frame rotation and flip

Jun Li (12019-05-16): > Sure. > This patch is checking the frame's orientation status, and apply input > filter if necessary. >frame 1 -> check orientation -> get 2 -> need flip --> goto filter >frame 2 -> check orientation -> get 1 -> do nothing >frame 3 -> check orientation -> get 7

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

James Almer (12019-05-16): > There are two precedents in the codebase, one checking for both the > passed argument and then the struct pointer pointed by it (av_bsf_free > and av_buffer_unref as i mentioned above), and one checking only the > struct pointer (av_bsf_list_free as you mentioned in ano

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

On Thu, May 16, 2019 at 09:35:00PM +1000, Peter Ross wrote: > +static int read_mb_value(GetBitContext *gb) > +{ > +int v = 1; > +int size; > +OPEN_READER(re, gb); > + > +do { > +int bit; > +size = 0; > + > +UPDATE_CACHE(re, gb); > +bit = SHOW_UBITS(re

Re: [FFmpeg-devel] [PATCH] Populate MPEG2TS codec_tag using ff_codec_movvideo_tags/ff_codec_movaudio_tags (av4cc) rather than the PES stream_type. For MPEG2TS files containing h264, ffprobe currently

On Thu, May 16, 2019 at 6:12 PM Damien Lévin wrote: > > Thanks Hendrik, > > The documentation from the AVCodecParameters codec_tag changed here (and > not AVCodecContext which you are referring to) seems pretty explicit about > being an AVI fourcc. So I'm not sure I understand why setting the PES

Re: [FFmpeg-devel] [PATCH] Populate MPEG2TS codec_tag using ff_codec_movvideo_tags/ff_codec_movaudio_tags (av4cc) rather than the PES stream_type. For MPEG2TS files containing h264, ffprobe currently

Thanks Hendrik, The documentation from the AVCodecParameters codec_tag changed here (and not AVCodecContext which you are referring to) seems pretty explicit about being an AVI fourcc. So I'm not sure I understand why setting the PES stream_type (ISO/IEC 13818-1, table 2-34) would be more correct.

Re: [FFmpeg-devel] [PATCH v3 2/2] fftools/ffmpeg: add support for per frame rotation and flip

On Thu, May 16, 2019 at 2:06 AM Jun Li wrote: > > > On Thu, May 16, 2019 at 1:21 AM Nicolas George wrote: > >> Jun Li (12019-05-16): >> > Fix #6945 >> > Current implementaion for autorotate works fine for stream >> > level rotataion but no support for frame level operation >> > and frame flip. T

[FFmpeg-devel] Support for Multiview Video Coding (MVC)

Hi, May I know if there is a plan to integrate MVC into ffmpeg? Thanks, Brook ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.or

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

On 5/16/2019 11:31 AM, Nicolas George wrote: > James Almer (12019-05-16): >> An assert is meant to detect developer errors, not user errors. Crashing >> the user's whole application because they misused the API is not really >> acceptable. >> >> I can't find examples of such functions using asserts

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

James Almer (12019-05-16): > An assert is meant to detect developer errors, not user errors. Crashing > the user's whole application because they misused the API is not really > acceptable. > > I can't find examples of such functions using asserts this way, but > there are several uninit/free/unre

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

On 5/16/2019 5:03 AM, Nicolas George wrote: > Ruiling Song (12019-05-16): >> ctx is a pointer to pointer here. >> >> Signed-off-by: Ruiling Song >> --- >> libavutil/tx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavutil/tx.c b/libavutil/tx.c >> index 934ef27c81

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

John Cox (12019-05-16): > >> -if (!ctx) > >> +if (!ctx || !(*ctx)) > >That would protect somebody stupid enough to call av_tx_uninit(NULL) > >instead of av_tx_uninit(&var). A hard crass is completely warranted in > >this case. An assert would be acceptable. > Actually that is what the origi

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

On 5/16/2019 8:35 AM, Peter Ross wrote: > --- > > what's changed: > * reordered AV_CODEC_ID_VP4 > * minor read_mb_values improvement (reproducible 0.5% speedup) > * configure/Makefile fix > * squished data tables to fill 80 columns. > > UNCHECKED_BITSTREAM_READER doesn't give any performance impr

[FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

Minimal support for ATSC PSIP tables. Does not support STT or EIT tables and so is not compliant with terrestrial ATSC. ATSC tables are not created by default, and will only be transmitted if either "atsc_name" or "atsc_channel" metadata is supplied. Signed-off-by: Phillip Burr --- libavformat/

[FFmpeg-devel] reconfig encoder libx264

Hello, I wrote in funck "do_encode(AVCodecContext *avctx, const AVFrame *frame,int *got_packet)" avctx-bit_rate = 80, but  FFmpeg dont't chage bitrate, when i set opt in bash "-b:v 1M", ffmpeg print that bitrate=1M, why ? (codec libx264) ___ ffmpe

Re: [FFmpeg-devel] [PATCH]

On Wed, May 15, 2019 at 11:23 PM Michael Niedermayer wrote: > > On Wed, May 15, 2019 at 11:13:57PM +0200, Werner Robitza wrote: > > On Wed, May 15, 2019 at 4:55 PM Gyan wrote: > > > On 15-05-2019 05:06 PM, Werner Robitza wrote: > > > > On Wed, May 15, 2019 at 11:36 AM Gyan wrote: > > > >> Which

Re: [FFmpeg-devel] [PATCH]lavf/utils: Do not read "@" without ":" as user name separator

On 06-05-2019 01:36 AM, Carl Eugen Hoyos wrote: Am So., 5. Mai 2019 um 21:56 Uhr schrieb Hendrik Leppkes : On Sun, May 5, 2019 at 9:47 PM Carl Eugen Hoyos wrote: Am So., 5. Mai 2019 um 21:18 Uhr schrieb Hendrik Leppkes : On Sun, May 5, 2019 at 9:08 PM Carl Eugen Hoyos wrote: Hi! Attached

[FFmpeg-devel] [PATCHv3] VP4 video decoder

--- what's changed: * reordered AV_CODEC_ID_VP4 * minor read_mb_values improvement (reproducible 0.5% speedup) * configure/Makefile fix * squished data tables to fill 80 columns. UNCHECKED_BITSTREAM_READER doesn't give any performance improvement on my i7, even with unrealisticly huge 4k vp4 vide

[FFmpeg-devel] [PATCH 2/3] avcodec/aacdec_template: Merge 3 #ifs related to noise handling

Fewer #if and fewer lines Signed-off-by: Michael Niedermayer --- libavcodec/aacdec_template.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c index 721511c5e9..7021153103 100644 --- a/libavcodec/aac

[FFmpeg-devel] [PATCH 1/3] avcodec/aacdec_fixed: ssign seems always -1 in noise_scale(), simplify

--- libavcodec/aacdec_fixed.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/aacdec_fixed.c b/libavcodec/aacdec_fixed.c index b051e75709..0808c81005 100644 --- a/libavcodec/aacdec_fixed.c +++ b/libavcodec/aacdec_fixed.c @@ -195,12 +195,12 @@ static void subb

[FFmpeg-devel] [PATCH 3/3] avcodec/aacdec_fixed: Handle more extreem cases in noise_scale()

Its unclear if these cases have any relevance in real files Fixes: shift exponent -2 is negative Fixes: 14489/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5681941631729664 Signed-off-by: Michael Niedermayer --- libavcodec/aacdec_fixed.c | 13 + 1 file changed,

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

May 16, 2019, 11:35 AM by geo...@nsup.org: > Lynne (12019-05-16): > >> LGTM >> > > As I said, not to me. Please take all comments into account. > Its fine by me. Adding an AVClass is unwarranted and absolutely no standalone API we've ever used like av_fft or av_has has a class. _

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

>Ruiling Song (12019-05-16): >> ctx is a pointer to pointer here. >> >> Signed-off-by: Ruiling Song >> --- >> libavutil/tx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavutil/tx.c b/libavutil/tx.c >> index 934ef27c81..1690604040 100644 >> --- a/libavutil/tx.c

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: add siren audio decoder

May 16, 2019, 10:43 AM by one...@gmail.com: > Signed-off-by: Paul B Mahol <> one...@gmail.com > > > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7 + > libavcodec/siren.c |

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

Lynne (12019-05-16): > LGTM As I said, not to me. Please take all comments into account. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

May 16, 2019, 6:02 AM by ruiling.s...@intel.com: > ctx is a pointer to pointer here. > > Signed-off-by: Ruiling Song <> ruiling.s...@intel.com > > > > --- > libavutil/tx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/tx.c b/lib

Re: [FFmpeg-devel] [PATCH] ffplay: added option always on top for video window

Dňa st 15. 5. 2019, 11:14 Daniel Kučera napísal(a): > > > > Ping. > > > > -- > > > > S pozdravom / Best regards > > Daniel Kucera. > > Ping. > > -- > > S pozdravom / Best regards > Daniel Kucera. > Ping. > ___ ffmpeg-devel mailing list ffmpeg-devel@ff

[FFmpeg-devel] [PATCH 1/4] avcodec: add siren audio decoder

Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 + libavcodec/siren.c | 724 5 files changed, 734 insertions(+) create mode 100644 libavc

[FFmpeg-devel] [PATCH 4/4] avformat/vivo: set packet duration

Signed-off-by: Paul B Mahol --- libavformat/vivo.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/vivo.c b/libavformat/vivo.c index 730ca4bb99..f3436fccd2 100644 --- a/libavformat/vivo.c +++ b/libavformat/vivo.c @@ -36,6 +36,7 @@ typedef struct VivoContext {

[FFmpeg-devel] [PATCH 3/4] avformat/vivo: add support for siren codec

Signed-off-by: Paul B Mahol --- libavformat/vivo.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/vivo.c b/libavformat/vivo.c index 1b1bfaffc7..730ca4bb99 100644 --- a/libavformat/vivo.c +++ b/libavformat/vivo.c @@ -232,6 +232,11 @@ static int vivo_read_header(AVFormatContex

[FFmpeg-devel] [PATCH 2/4] avformat/vivo: improve probing of some files

Signed-off-by: Paul B Mahol --- libavformat/vivo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/vivo.c b/libavformat/vivo.c index 9a07c43849..1b1bfaffc7 100644 --- a/libavformat/vivo.c +++ b/libavformat/vivo.c @@ -59,9 +59,10 @@ static int vivo_probe(const

Re: [FFmpeg-devel] [PATCH v3 2/2] fftools/ffmpeg: add support for per frame rotation and flip

On Thu, May 16, 2019 at 1:21 AM Nicolas George wrote: > Jun Li (12019-05-16): > > Fix #6945 > > Current implementaion for autorotate works fine for stream > > level rotataion but no support for frame level operation > > and frame flip. This patch is for adding flip support and > > per frame opera

[FFmpeg-devel] [PATCH V2] avfilter/vf_unsharp: enable slice threading

benchmarking with a simple command: ffmpeg -i 1080p.mp4 -vf unsharp=la=3:ca=3 -an -f null /dev/null with the patch, the fps increase from 50 to 120 on my local machine (i7-6770HQ). v2: make av_image_copy_plane() only copy per-slice content. Signed-off-by: Ruiling Song --- libavfilter/unsharp.h

Re: [FFmpeg-devel] [PATCH v3 2/2] fftools/ffmpeg: add support for per frame rotation and flip

Jun Li (12019-05-16): > Fix #6945 > Current implementaion for autorotate works fine for stream > level rotataion but no support for frame level operation > and frame flip. This patch is for adding flip support and > per frame operations. Can you explain why you decided to do that in the command-li

Re: [FFmpeg-devel] [PATCH v1] lavf/mov: Fix timestamp rescale on sidx atom

On Sun, May 12, 2019 at 7:44 PM Jun Li wrote: > > > On Fri, May 10, 2019 at 7:25 PM Jun Li wrote: > >> >> On Thu, May 9, 2019 at 2:08 AM Jun Li wrote: >> >>> Fix #5090 >>> Fix the timestamp rescale issue, from sidx timebase to >>> stream's timebase. >>> --- >>> libavformat/mov.c | 2 +- >>> 1

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

Ruiling Song (12019-05-16): > ctx is a pointer to pointer here. > > Signed-off-by: Ruiling Song > --- > libavutil/tx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/tx.c b/libavutil/tx.c > index 934ef27c81..1690604040 100644 > --- a/libavutil/tx.c > +++ b/li

  1   2   >