Re: [FFmpeg-devel] [PATCH, v2] lavc/qsvenc: Fix the memory leak for enc_ctrl.Payload

> -Original Message- > From: Li, Zhong > Sent: Monday, April 29, 2019 17:00 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: RE: [FFmpeg-devel] [PATCH, v2] lavc/qsvenc: Fix the memory leak > for enc_ctrl.Payload > > > From: ffmpeg-devel [mail

[FFmpeg-devel] [PATCH V1] doc/build_system: Document checkheaders/alltools and consistency fixes

From: Jun Zhao Document checkheaders/alltools and consistency fixes Signed-off-by: Jun Zhao --- doc/build_system.txt |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/build_system.txt b/doc/build_system.txt index 325a9e8..9a12b3a 100644 --- a/doc/build_system.

Re: [FFmpeg-devel] [PATCH 1/2] lavf/vf_vpp_qsv: add transpose support for QSV VPP

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Fu, Linjie > Sent: Monday, March 18, 2019 13:35 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Mark Thompson > Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavf/vf_vpp_qs

Re: [FFmpeg-devel] [PATCH V2] lavfi/colorlevels: Add slice threading support

> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Jun Zhao > Sent: Tuesday, May 21, 2019 7:21 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Jun Zhao > Subject: [FFmpeg-devel] [PATCH V2] lavfi/colorlevels: Add slice threading > support > > From: Jun Zhao > > Add slice threadi

Re: [FFmpeg-devel] [PATCH] lavc/qsvdec: reinit if the resolution changes little

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Fu, Linjie > Sent: Friday, February 22, 2019 10:40 > To: Li, Zhong ; FFmpeg development discussions and > patches > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvdec: reinit if the resolution >

Re: [FFmpeg-devel] [PATCH V1] lavfi/lut: Add slice threading support

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of myp...@gmail.com > Sent: Wednesday, May 22, 2019 11:14 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Jun Zhao > Subject: Re: [FFmpeg-devel] [PATCH V1] lavfi/lu

Re: [FFmpeg-devel] [PATCH V1] lavfi/lut: Add slice threading support

On Wed, May 22, 2019 at 11:03 AM Song, Ruiling wrote: > > > > > -Original Message- > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > Of Jun Zhao > > Sent: Wednesday, May 22, 2019 12:29 AM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Jun Zhao > > Subject: [FFmpeg-dev

Re: [FFmpeg-devel] [PATCH V1] lavfi/lut: Add slice threading support

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Jun Zhao > Sent: Wednesday, May 22, 2019 12:29 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Jun Zhao > Subject: [FFmpeg-devel] [PATCH V1] lavfi/lut: Add slice threading support > > From: Jun Zhao

[FFmpeg-devel] change for ROI interface/document

> -Original Message- > From: Guo, Yejun > Sent: Thursday, May 09, 2019 10:08 AM > To: FFmpeg development discussions and patches > Cc: Mark Thompson > Subject: RE: [FFmpeg-devel] [PATCH v2 2/6] lavu/frame: Expand ROI > documentation > > > > > -Original Message- > > From: ffmp

Re: [FFmpeg-devel] [PATCH] libavfilter/dnn_native: Add multiple activation functions in dnn native

> 在 2019年5月21日，下午8:48，Guo, Yejun 写道： > > > >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of >> Xuewei Meng >> Sent: Tuesday, May 21, 2019 2:53 PM >> To: ffmpeg-devel@ffmpeg.org >> Subject: [FFmpeg-devel] [PATCH] libavfilter/dnn_native:

[FFmpeg-devel] [PATCH V1 2/2] doc/writing_filters: Use ff_filter_get_nb_threads() get number of threads

From: Jun Zhao ff_filter_get_nb_threads() respect AVFilterContext.nb_threads and graph->nb_threads both, in most case, we perfer this API than using ctx->graph->nb_threads directly. --- doc/writing_filters.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/writing_

[FFmpeg-devel] [PATCH V1 1/2] lavfi/lensfun: Use ff_filter_get_nb_threads() get number of threads

From: Jun Zhao ff_filter_get_nb_threads() respect AVFilterContext.nb_threads and graph->nb_threads both, in most case, we perfer this API than using ctx->graph->nb_threads directly. Signed-off-by: Jun Zhao --- libavfilter/vf_lensfun.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: disable ICQ mode when enabling low power

> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Linjie Fu > Sent: Wednesday, May 22, 2019 4:31 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: disable ICQ mode > when enabling low power > > ICQ mode is not support

Re: [FFmpeg-devel] [PATCH 04/11] cbs_mpeg2: Fix storage type for frame_centre_*_offset

On 5/21/2019 10:04 PM, Andreas Rheinhardt wrote: > The frame_centre_horizontal/vertical_offset values contained in picture > display extensions are actually signed values (i.e. it is possible to > indicate that the display device should add black bars/pillars). > > The files sony-ct3.bs and tcela-

[FFmpeg-devel] [PATCH 02/11] cbs_mpeg2: Improve checks for invalid values

MPEG-2 contains several elements that mustn't be zero according to the specifications: horizontal/vertical_size_value, aspect_ratio_information, frame_rate_code, the quantiser matrices, the colour_description elements, picture_coding_type, the f_code[r][s] values and quantiser_scale_code. It is now

[FFmpeg-devel] [PATCH 03/11] mpeg2_metadata, cbs_mpeg2: Fix handling of colour_description

If a sequence display extension is read with colour_description equal to zero, but a user wants to add one or more of the colour_description elements, then the colour_description elements the user did not explicitly request to be set are set to zero and not to the value equal to unknown/unspecified

[FFmpeg-devel] [PATCH 07/11] cbs: Remove useless initializations

Up until now, a temporary variable was used and initialized every time a value was read in CBS; if reading turned out to be successfull, this value was overwritten (without having ever been looked at) with the value read if reading was successfull; on failure the variable wasn't touched either. The

[FFmpeg-devel] [PATCH 11/11] cbs_mpeg2: Remove zero byte stuffing

Remove superfluous trailing zeros from slices. Because MPEG-2 slices can end with zero bits a safe number of trailing zero bits is always kept. More explicitly, 6 + max{f_code[i][1] - 1, i = 0,1, f_code[i][1] != 0xf} is an upper bound for the number of possible trailing zeros that are part of the

[FFmpeg-devel] [PATCH 10/11] cbs_mpeg2: Fix parsing of picture headers

MPEG-2 picture and slice headers can contain optional extra information; both use the same syntax for their extra information. And cbs_mpeg2's implementations of both were buggy until recently; the one for the picture headers still is and this is fixed in this commit. The extra information in pict

[FFmpeg-devel] [PATCH 09/11] cbs_mpeg2: Fix parsing of slice headers

1. The extra information in slice headers was parsed incorrectly: In the first reading pass to derive the length of the extra information, one should look at bits n, n + 9, n + 18, ... and check whether they equal one (further extra information) or zero (end of extra information), but instead bits

[FFmpeg-devel] [PATCH 08/11] avcodec/cbs_mpeg2: fix leak of extra_information_slice buffer in cbs_mpeg2_read_slice_header()

From: James Almer cbs_mpeg2_free_slice() calls av_buffer_unref() on extra_information_ref, meaning allocating with av_malloc() was not the intention. Signed-off-by: James Almer --- libavcodec/cbs_mpeg2_syntax_template.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a

[FFmpeg-devel] [PATCH 04/11] cbs_mpeg2: Fix storage type for frame_centre_*_offset

The frame_centre_horizontal/vertical_offset values contained in picture display extensions are actually signed values (i.e. it is possible to indicate that the display device should add black bars/pillars). The files sony-ct3.bs and tcela-6.bits (which are both used in fate tests for mpeg2_metadat

[FFmpeg-devel] [PATCH 06/11] cbs, cbs_mpeg2, cbs_jpeg: Don't av_freep local variables

There is no danger of leaving dangling pointers behind, as the lifespan of local variables (including pointers passed (by value) as function arguments) ends anyway as soon as we exit their scope. Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs.c | 2 +- libavcodec/cbs_jpeg.c | 8

[FFmpeg-devel] [PATCH 05/11] cbs_mpeg2: Correct error codes

Up until now, things that are merely unsupported by cbs_mpeg2 have been declared to be invalid input. This has been changed. Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_mpeg2.c | 4 +--- libavcodec/cbs_mpeg2_syntax_template.c | 4 ++-- 2 files changed, 3 insertions(+), 5

[FFmpeg-devel] [PATCH 01/11] cbs_mpeg2: Correct and use enum values

Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_mpeg2.c | 30 +++--- libavcodec/cbs_mpeg2.h | 2 +- libavcodec/cbs_mpeg2_syntax_template.c | 10 - 3 files changed, 23 insertions(+), 19 deletions(-) diff --git a/libavcodec/cbs_mpeg

[FFmpeg-devel] [PATCH 00/11 v3] cbs (mostly MPEG-2) patches

Hello, this patchset is an updated and expanded version of my patchset [1] from April. Changes include: 1. I have found more elements in MPEG-2 with forbidden values. And it was always zero that was forbidden. Therefore the macro for ranges has been simplified to simply disallow the value 0. 2. c

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

Hi! On 2019-05-20 20:51 +0200, Marton Balint wrote: > > On Mon, 20 May 2019, Gyan wrote: > > > On 20-05-2019 02:18 AM, Marton Balint wrote: > > > > > > On Sun, 19 May 2019, Paul B Mahol wrote: > > > > > > > On 5/19/19, Marton Balint wrote: > > > > > > > > > > On Sun, 19 May 2019, Paul B Mahol wro

[FFmpeg-devel] [PATCH] avcodec/diracdec: Fix integer overflow in global_mv()

Fixes: signed integer overflow: 16384 * 196607 cannot be represented in type 'int' Fixes: 14810/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5091232683917312 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mich

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: Fix compilation for IOS < 11.0 and OSX, < 10.13

Hi, On Tue, May 14, 2019 at 4:16 PM Thilo Borgmann wrote: > > $Subject > > Tested compilation only, sanity test actually using it appreciated. > Thanks for the patch. To be completely fair, this is not to fix compilation for specific target systems, but rather to fix compilation on older SDKs (b

Re: [FFmpeg-devel] [PATCH v2 06/11] cbs: Add support functions for handling unit content references

On 5/20/2019 8:02 PM, Mark Thompson wrote: > Use the unit type table to determine what we need to do to clone the > internals of the unit content when making copies for refcounting or > writeability. (This will still fail for units with complex content > if they do not have a defined clone functio

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

On 5/21/2019 3:42 PM, Carl Eugen Hoyos wrote: > Am Di., 21. Mai 2019 um 09:45 Uhr schrieb Peter Ross : > >> diff --git a/configure b/configure >> index 9b4305cf0d..61eb774116 100755 >> --- a/configure >> +++ b/configure >> @@ -2825,6 +2825,7 @@ vc1image_decoder_select="vc1_decoder" >> vorbis_deco

Re: [FFmpeg-devel] [PATCH] web/download: set realistic release schedule

On Mon, May 20, 2019, at 11:00 AM, Lou Logan wrote: > Major releases have been every 6 months approximately; not every 3 months. > > Signed-off-by: Lou Logan > --- > src/download | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Pushed. ___ ffmp

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

On Tue, May 21, 2019 at 05:44:20PM +1000, Peter Ross wrote: > +if (bits < 0x100) { > +skip_bits(gb, 1); > +} else if (bits < 0x180) { > +skip_bits(gb, 2); > +v += 1; > +} > +#define body(n) { \ > +skip_bits(gb, 2 + n); \ > +v += (1 << n) + get_bits(gb, n)

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

On Tue, May 21, 2019 at 11:15:03AM -0300, James Almer wrote: > > I have a feeling this loop should have a stop condition like v < > > SOME_LARGE_VALUE, say INT_MAX-255 or yuv_macroblock_count, to reject > > corrupt/malicious files and not cause undefined behavior > > Using get_bits_left(gb) would b

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

Am Di., 21. Mai 2019 um 09:45 Uhr schrieb Peter Ross : > diff --git a/configure b/configure > index 9b4305cf0d..61eb774116 100755 > --- a/configure > +++ b/configure > @@ -2825,6 +2825,7 @@ vc1image_decoder_select="vc1_decoder" > vorbis_decoder_select="mdct" > vorbis_encoder_select="audio_frame_

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

Am Di., 21. Mai 2019 um 19:18 Uhr schrieb Lynne : > > May 21, 2019, 8:44 AM by pr...@xvid.org : > > > --- > > > > what's changed: > > * apply #if CONFIG_VP4_DECODER around large vp4 code blocks > > * improved vp4_read_mb_value thanks to reminars suggestions > > * improved con

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: add siren audio decoder

On Tue, May 21, 2019 at 04:51:19PM +0200, Moritz Barsnick wrote: > (It only matters on hardware which requires double precision software > emulation, but if explicitly using float, make sure to stick to float.) It's a best practice regardless of emulation or not. Even x86 has for example much bett

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

May 21, 2019, 8:44 AM by pr...@xvid.org : > --- > > what's changed: > * apply #if CONFIG_VP4_DECODER around large vp4 code blocks > * improved vp4_read_mb_value thanks to reminars suggestions > * improved configure vp3_decoder_select > > > Changelog |1 + >

[FFmpeg-devel] [PATCH V1] lavfi/lut: Add slice threading support

From: Jun Zhao Used the command for 1080p h264 clip as follow: a). ffmpeg -i input -vf lutyuv="u=128:v=128" -f null /dev/null b). ffmpeg -i input -vf lutrgb="g=0:b=0" -f null /dev/null after enabled the slice threading, the fps change from: a). 144fps to 258fps (lutyuv) b). 94fps to 153fps (l

Re: [FFmpeg-devel] [PATCH v4] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

This patch has a bit more restructuring to consolidate the ATSC specific fields. I fixed some bugs where a few fields were set incorrectly. Specifically, the MGT transmits the length of each table it describes and so each table it describes is pre-populated. Testing last night involved taking an

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: add siren audio decoder

On Thu, May 16, 2019 at 12:51:46 +0200, Lynne wrote: > > +#define STEPSIZE0.3010299957 > > Just hardcode this in the powf call. With an appended 'f'. > > +const float scale = 1.0f; > const float scale = 1.0 / 32768; 1.0f, but it doesn't matter here, as the preprocessor reduces it to flo

[FFmpeg-devel] [PATCH v4] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

Minimal support for ATSC PSIP tables. Does not support STT or EIT tables and so is not compliant with terrestrial ATSC. ATSC tables are not created by default, and will only be transmitted if either "atsc_name" or "atsc_channel" metadata is supplied. Signed-off-by: Phillip Burr --- doc/muxers.t

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

On 5/21/2019 6:34 AM, Tomas Härdin wrote: > tis 2019-05-21 klockan 17:44 +1000 skrev Peter Ross: >> --- >> >> what's changed: >> * apply #if CONFIG_VP4_DECODER around large vp4 code blocks >> * improved vp4_read_mb_value thanks to reminars suggestions >> * improved configure vp3_decoder_select >> >

[FFmpeg-devel] [PATCH] avformat/segment: populate empty outer stream extradata from packet

Fixes playback in QT for me. Gyan From 3b7c51ebb8e26aafe27170e1c8e969b854c985ff Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Tue, 21 May 2019 17:15:54 +0530 Subject: [PATCH] avformat/segment: populate empty outer stream extradata from packet At present, if the outer stream extradata is empt

Re: [FFmpeg-devel] [PATCH] libavfilter/dnn_native: Add multiple activation functions in dnn native

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Xuewei Meng > Sent: Tuesday, May 21, 2019 2:53 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] libavfilter/dnn_native: Add multiple > activation > functions in dnn native

[FFmpeg-devel] [PATCH V2] lavfi/colorlevels: Add slice threading support

From: Jun Zhao Add slice threading support, use the command like: ./ffmpeg -i input -vf colorlevel with 1080p h264 clip, the fps from 39 fps to 79 fps in the local Signed-off-by: Jun Zhao --- libavfilter/vf_colorlevels.c | 125 +++-- 1 files changed, 106 i

[FFmpeg-devel] [PATCH V3] lavfi/colorlevels: Add slice threading support

From: Jun Zhao Add slice threading support, use the command like: ./ffmpeg -i input -vf colorlevels -f null /dev/null with 1080p h264 clip, the fps from 39 fps to 79 fps in the local(Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz) Signed-off-by: Jun Zhao --- libavfilter/vf_colorlevels.c | 121 +++

Re: [FFmpeg-devel] [PATCH] lavfi/colorlevels: Add slice threading support

On Tue, May 21, 2019 at 9:49 AM Jun Zhao wrote: > > From: Jun Zhao > > Add slice threading support, use the command like: > > ./ffmpeg -i input -vf colorlevel with 1080p h264 clip, the fps > from 39 fps to 79 fps in the local > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_colorlevels.c | 1

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

tis 2019-05-21 klockan 17:44 +1000 skrev Peter Ross: > --- > > what's changed: > * apply #if CONFIG_VP4_DECODER around large vp4 code blocks > * improved vp4_read_mb_value thanks to reminars suggestions > * improved configure vp3_decoder_select > > [...] >   > +#define BLOCK_X (2 * mb_x + (k & 1)

[FFmpeg-devel] [PATCH] lavc/vaapi_encode: disable ICQ mode when enabling low power

ICQ mode is not supported in low power mode and should be disabled. For H264, Driver supports RC modes CQP, CBR, VBR, QVBR. For HEVC, Driver supports RC modes CQP, CBR, VBR, ICQ, QVBR. ICQ is not exposed while working on low power mode for h264_vaapi, but will trigger issues for hevc_vaapi. Sign

Re: [FFmpeg-devel] [PATCH v1] lavf/mov: Fix timestamp rescale on sidx atom

On Thu, May 16, 2019 at 1:00 AM Jun Li wrote: > > > On Sun, May 12, 2019 at 7:44 PM Jun Li wrote: > >> >> >> On Fri, May 10, 2019 at 7:25 PM Jun Li wrote: >> >>> >>> On Thu, May 9, 2019 at 2:08 AM Jun Li wrote: >>> Fix #5090 Fix the timestamp rescale issue, from sidx timebase to

[FFmpeg-devel] [PATCHv4] VP4 video decoder

--- what's changed: * apply #if CONFIG_VP4_DECODER around large vp4 code blocks * improved vp4_read_mb_value thanks to reminars suggestions * improved configure vp3_decoder_select Changelog |1 + configure |1 + doc/general.texi|2 + libavcodec/Ma

[FFmpeg-devel] [PATCH] libavfilter/dnn_native: Add multiple activation functions in dnn native

Add "Leaky_relu" and "None" option in activation function. Signed-off-by: Xuewei Meng --- libavfilter/dnn_backend_native.c | 5 + libavfilter/dnn_backend_native.h | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/libavfilter/dnn_backend_native.c b/libavfilter/dnn_backend_