[FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-09 Thread Amir Pauker
set AVFrame decode_error_flags in case h->slice_ctx->er.error_occurred is set after the call to ff_h264_execute_decode_slices. This allows the user to detect concealed decoding errors in the call to avcodec_receive_frame Signed-off-by: Amir Pauker --- libavcodec/h264dec.c | 6 ++ 1 file chan

[FFmpeg-devel] [PATCH v1] avfilter/vaapi: add overlay_vaapi filter

2019-06-09 Thread Zachary Zhou
--- configure | 1 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vaapi_vpp.c| 95 + libavfilter/vaapi_vpp.h| 5 + libavfilter/vf_overlay_vaapi.c | 352 + 6 files change

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264_sei: Add acces to truncated SEI data

2019-06-09 Thread Vittorio Giovara
On Sat, Jun 8, 2019 at 9:28 AM Antonin Gouzer wrote: > --- > Some codecs editors had miss interpreted the H264 standart and > have coded a wrong size in the SEI data. > size = SEI size + 1. > The SEI data is detected as "truncated" > Ex: > https://drive.google.com/file/d/1cNtLwnfPnyJnYqE7OYhU3SCo

[FFmpeg-devel] [PATCHv6] VP4 video decoder

2019-06-09 Thread Peter Ross
--- Changes: vp4_get_mb_count() & vp4_unpack_macroblocks(): improved error handling and add comments. vp4_dc_pred(): always use / 2 vp4_mc_loop_filter(): drop look up tables. if there are no more comments, i will push in a few days, together with earlier posted patches (vp40 riff, fate test).

[FFmpeg-devel] [PATCH v6] avformat/ifv: added support for ifv cctv files

2019-06-09 Thread Swaraj Hota
Fixes ticket #2956. Signed-off-by: Swaraj Hota --- Added entry in "doc/general.texi". --- Changelog| 1 + doc/general.texi | 2 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/ifv.c| 304 +++

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-09 Thread Amir Z
Sounds good, thanks I will submit a new patch On Sun, Jun 9, 2019 at 10:53 PM James Almer wrote: > On 6/10/2019 12:32 AM, Amir Z wrote: > > As far as I can tell FF_DECODE_ERROR_MISSING_REFERENCE is not used > > anywhere. > > > > Since the new flag DECODE_ERROR covers also missing reference case

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-09 Thread James Almer
On 6/10/2019 12:32 AM, Amir Z wrote: > As far as I can tell FF_DECODE_ERROR_MISSING_REFERENCE is not used > anywhere. > > Since the new flag DECODE_ERROR covers also missing reference case i > thought it will be more appropriate to replace it instead of adding a new > enum value. Removing a def

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-09 Thread Amir Z
As far as I can tell FF_DECODE_ERROR_MISSING_REFERENCE is not used anywhere. Since the new flag DECODE_ERROR covers also missing reference case i thought it will be more appropriate to replace it instead of adding a new enum value. Thanks On Sun, Jun 9, 2019 at 10:15 PM James Almer wrote: >

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-09 Thread James Almer
On 6/10/2019 12:03 AM, Amir Pauker wrote: > set AVFrame decode_error_flags in case h->slice_ctx->er.error_occurred is set > after the call to ff_h264_execute_decode_slices. This allows the user to > detect > concealed decoding errors in the call to avcodec_receive_frame > > Signed-off-by: Amir Pa

Re: [FFmpeg-devel] [PATCH V2 1/2] libavfilter/dnn: add script to convert TensorFlow model (.pb) to native model (.model)

2019-06-09 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: Tuesday, June 04, 2019 3:10 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun > Subject: [PATCH V2 1/2] libavfilter/dnn: add script to convert TensorFlow > model > (.pb) to native model (.model) > > For example, given TensorFlow model fil

[FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-09 Thread Amir Pauker
set AVFrame decode_error_flags in case h->slice_ctx->er.error_occurred is set after the call to ff_h264_execute_decode_slices. This allows the user to detect concealed decoding errors in the call to avcodec_receive_frame Signed-off-by: Amir Pauker --- libavcodec/h264dec.c | 7 +++ libavutil/

[FFmpeg-devel] [PATCH v10 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-06-09 Thread Jun Li
Fix #6945 Rotate or/and flip frame according to frame's metadata orientation --- fftools/ffmpeg.c| 5 +++-- fftools/ffmpeg.h| 8 fftools/ffmpeg_filter.c | 40 +++- 3 files changed, 46 insertions(+), 7 deletions(-) diff --git a/fftools

Re: [FFmpeg-devel] [PATCH v9 1/2] lavf/vf_transpose: add exif orientation support

2019-06-09 Thread Jun Li
On Sun, Jun 9, 2019 at 1:52 AM Paul B Mahol wrote: > On 6/9/19, Jun Li wrote: > > On Sun, Jun 9, 2019 at 12:49 AM Paul B Mahol wrote: > > > >> On 6/9/19, Jun Li wrote: > >> > Add exif orientation support and expose an option. > >> > --- > >> > libavfilter/hflip.h| 2 + > >> > libavf

[FFmpeg-devel] [PATCH v10 1/2] lavf/vf_transpose: add exif orientation support

2019-06-09 Thread Jun Li
Add exif orientation support and expose an option. --- libavfilter/hflip.h| 2 + libavfilter/transpose.h| 14 libavfilter/vf_hflip.c | 40 ++--- libavfilter/vf_transpose.c | 168 - 4 files changed, 192 insertions(+), 32 deletions(-)

[FFmpeg-devel] [PATCH] avformat/aviobuf: Delay buffer downsizing until asserts are met

2019-06-09 Thread Michael Niedermayer
Fixes: Assertion failure Fixes: 15151/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5757079496687616 Signed-off-by: Michael Niedermayer --- libavformat/aviobuf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index 5a33

Re: [FFmpeg-devel] [PATCHv5 2/2] VP4 video decoder

2019-06-09 Thread Reimar Döffinger
On 09.06.2019, at 03:07, Peter Ross wrote: > On Sat, Jun 08, 2019 at 08:49:15AM +0200, Reimar Döffinger wrote: >> >> >> On 08.06.2019, at 03:08, Peter Ross wrote: >> >>> --- >>> comments against v4 patch addressed. thanks. >>> >>> +#if CONFIG_VP4_DECODER >>> +static int vp4_get_mb_count(Vp3D

Re: [FFmpeg-devel] [PATCH v5] avformat/ifv: added support for ifv cctv files

2019-06-09 Thread Swaraj Hota
On Sun 9 Jun, 2019, 5:09 PM Peter Ross, wrote: > On Sun, Jun 09, 2019 at 09:36:33PM +1000, Peter Ross wrote: > > On Mon, Jun 03, 2019 at 04:06:10AM +0530, Swaraj Hota wrote: > > > On Sun, May 26, 2019 at 01:46:32AM +0530, Swaraj Hota wrote: > > > > Fixes ticket #2956. > > > > > > > > Signed-off-b

Re: [FFmpeg-devel] [PATCH v5] avformat/ifv: added support for ifv cctv files

2019-06-09 Thread Peter Ross
On Sun, Jun 09, 2019 at 09:36:33PM +1000, Peter Ross wrote: > On Mon, Jun 03, 2019 at 04:06:10AM +0530, Swaraj Hota wrote: > > On Sun, May 26, 2019 at 01:46:32AM +0530, Swaraj Hota wrote: > > > Fixes ticket #2956. > > > > > > Signed-off-by: Swaraj Hota > > > --- > > > Minor changes based on previ

Re: [FFmpeg-devel] [PATCH v5] avformat/ifv: added support for ifv cctv files

2019-06-09 Thread Peter Ross
On Mon, Jun 03, 2019 at 04:06:10AM +0530, Swaraj Hota wrote: > On Sun, May 26, 2019 at 01:46:32AM +0530, Swaraj Hota wrote: > > Fixes ticket #2956. > > > > Signed-off-by: Swaraj Hota > > --- > > Minor changes based on previous discussions. > > Seeking is fixed. > > --- > > Changelog

[FFmpeg-devel] [PATCH 5/5] startcode: Filter out non-startcodes earlier

2019-06-09 Thread Andreas Rheinhardt
Up until now, the bitmasks used to initially find out when one needs to take a closer look and search for startcodes were rather primitive: If a block (of four or eight bytes, depending on the system) contained a zero, it was treated as a target for closer inspection. This can be improved: Using th

[FFmpeg-devel] [PATCH 1/5] startcode: Use common macro and switch to pointer arithmetic

2019-06-09 Thread Andreas Rheinhardt
The reasons are cosmetics and preparation for future patches that will have even more cases and whose performance improves when switching to direct pointer arithmetic: Benchmarks have shown that using pointers directly instead of indexing to access the array to be about 5% faster (33665 vs. 31806 f

[FFmpeg-devel] [PATCH 3/5] startcode: Stop overreading

2019-06-09 Thread Andreas Rheinhardt
Up until now ff_startcode_find_candidate_c could overread; it relied on zero-padding after the buffer in order to function correctly. This has been changed: No overreads occur any more. The ultimate goal behind all this is to create a high-performance function for searching of startcodes that can b

[FFmpeg-devel] [PATCH 2/5] startcode: Switch to aligned reads

2019-06-09 Thread Andreas Rheinhardt
ff_startcode_find_candidate_c already checked multiple bytes for zeros at once if HAVE_FAST_UNALIGNED is true; up until now the other case checked all bytes one by one. This has been modified: A few bytes are checked until alignment is reached from which point on several bytes can be checked at onc

[FFmpeg-devel] [PATCH 4/5] startcode: Don't return false positives

2019-06-09 Thread Andreas Rheinhardt
Until now the function ff_startcode_find_candidate_c did not really search for startcodes (the startcode 0x00 0x00 0x01 (used in MPEG-1/2/4, VC-1 and H.264/5) is the only startcode meant here). Instead it searched for zero bytes and returned the earliest position of a zero byte. This of course led

[FFmpeg-devel] [PATCH 0/5 v2] New version

2019-06-09 Thread Andreas Rheinhardt
Hello, I have added the necessary numbers for the index version (which you can find at https://github.com/mkver/FFmpeg/commits/start_6 if you care) to the commit message of the first patch and have also adapted the overread check as you suggested (no performance impact whatsoever from this). - An

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: log skipped initial non-keyframes

2019-06-09 Thread Stephan Hilb
> Repeated messages only get supressed if there is no interspaced > message if 2 things generate a message per frame, neither will be > supressed So should I leave it at DEBUG level or implement a custom log_once? The "cur_dts invalid" debug message is currently being printed at least as often.

Re: [FFmpeg-devel] [PATCH v9 1/2] lavf/vf_transpose: add exif orientation support

2019-06-09 Thread Paul B Mahol
On 6/9/19, Jun Li wrote: > On Sun, Jun 9, 2019 at 12:49 AM Paul B Mahol wrote: > >> On 6/9/19, Jun Li wrote: >> > Add exif orientation support and expose an option. >> > --- >> > libavfilter/hflip.h| 2 + >> > libavfilter/transpose.h| 14 >> > libavfilter/vf_hflip.c | 4

Re: [FFmpeg-devel] [PATCH v9 1/2] lavf/vf_transpose: add exif orientation support

2019-06-09 Thread Jun Li
On Sun, Jun 9, 2019 at 12:49 AM Paul B Mahol wrote: > On 6/9/19, Jun Li wrote: > > Add exif orientation support and expose an option. > > --- > > libavfilter/hflip.h| 2 + > > libavfilter/transpose.h| 14 > > libavfilter/vf_hflip.c | 40 ++--- > > libavfilter/vf_tra

Re: [FFmpeg-devel] [PATCH v9 1/2] lavf/vf_transpose: add exif orientation support

2019-06-09 Thread Paul B Mahol
On 6/9/19, Jun Li wrote: > Add exif orientation support and expose an option. > --- > libavfilter/hflip.h| 2 + > libavfilter/transpose.h| 14 > libavfilter/vf_hflip.c | 40 ++--- > libavfilter/vf_transpose.c | 168 - > 4 files chan