Re: [FFmpeg-devel] [PATCH v3] avfilter/vaapi: add overlay_vaapi filter

2019-07-07 Thread Zhou, Zachary
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Mark Thompson > Sent: Sunday, July 7, 2019 8:56 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v3] avfilter/vaapi: add overlay_vaapi > filter > > On 20/06/2019

Re: [FFmpeg-devel] [PATCH 2/2] lavf/vf_vpp_qsv: add support for QSV transpose filter

2019-07-07 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Linjie Fu > Sent: Tuesday, June 18, 2019 10:53 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [FFmpeg-devel] [PATCH 2/2] lavf/vf_vpp_qsv: add support for QSV > transpose filter > > Add transpose support

[FFmpeg-devel] [PATCH 4/4] avcodec/vorbisdec: Check get_vlc2() failure

2019-07-07 Thread Michael Niedermayer
No testcase Signed-off-by: Michael Niedermayer --- libavcodec/vorbisdec.c | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c index d6c6a56e0c..60de34e432 100644 --- a/libavcodec/vorbisdec.c +++

[FFmpeg-devel] [PATCH 3/4] avcodec/vorbisdec: Check vlc for floor0 dec vector offset

2019-07-07 Thread Michael Niedermayer
Fixes: out of array access Fixes: 15649/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VORBIS_fuzzer-5729191309344768 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vorbisdec.c | 6 --

[FFmpeg-devel] [PATCH 2/4] avcodec/vorbisdec: amplitude bits can be more than 25 bits

2019-07-07 Thread Michael Niedermayer
Fixes: assertion failure, invalid shift Fixes: 15583/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VORBIS_fuzzer-5640157484548096 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 1/4] tools/target_dec_fuzzer: Free parser in case of avcodec_open2() failure

2019-07-07 Thread Michael Niedermayer
Fixes: memleak Fixes: part of 15529/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LIBVPX_VP8_fuzzer-5140143700180992 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 +

[FFmpeg-devel] [PATCH 11/12] cbs: ff_cbs_delete_unit: Replace return value with assert

2019-07-07 Thread Andreas Rheinhardt
ff_cbs_delete_unit never fails if the index of the unit to delete is valid, as it is with all current callers of the function. So just assert in ff_cbs_delete_unit that the index is valid and change the return value to void in order to remove the callers' checks for whether ff_cbs_delete_unit

[FFmpeg-devel] [PATCH 12/12] cbs_h264, h264_metadata: Deleting SEI messages never fails

2019-07-07 Thread Andreas Rheinhardt
Given the recent changes to ff_cbs_delete_unit, it is no longer sensible to use a return value for ff_cbs_h264_delete_sei_message; instead, use asserts to ensure that the required conditions are met and remove the callers' checks for the return value. Also, document said conditions. An assert

Re: [FFmpeg-devel] [PATCH 19/31] vp9_metadata: Avoid allocations and copies of packet structures

2019-07-07 Thread Mark Thompson
On 20/06/2019 00:45, Andreas Rheinhardt wrote: > This commit changes vp9_metadata to (a) use ff_bsf_get_packet_ref > instead of ff_bsf_get_packet (thereby avoiding one malloc and free per > filtered packet) and (b) to use only one packet structure at all, > thereby avoiding a call to

Re: [FFmpeg-devel] [PATCH 29/31] vp9_metadata: Update AVCodecParameters

2019-07-07 Thread James Almer
On 6/19/2019 8:45 PM, Andreas Rheinhardt wrote: > This commit adds an option to not only update the bitstream parameters > when using the vp9_metadata bitstream filter, but also the relevant > AVCodecParameters. The new option is on by default. > > This commit also adds documentation for this

Re: [FFmpeg-devel] [PATCH 11/31] cbs: Remove superfluous checks for ff_cbs_delete_unit

2019-07-07 Thread Mark Thompson
On 20/06/2019 00:45, Andreas Rheinhardt wrote: > ff_cbs_delete_unit never fails if the index of the unit to delete is > valid; document this behaviour explicitly and remove the checks for > whether ff_cbs_delete_unit failed, because all the callers of > ff_cbs_delete_unit already made sure the

Re: [FFmpeg-devel] [PATCH 00/18] cbs: Use ff_bsf_get_packet_ref etc.

2019-07-07 Thread Mark Thompson
On 17/06/2019 04:42, Andreas Rheinhardt wrote: > Hello, > > this patchset is mainly about switching the bitstream filters using cbs > from ff_bsf_get_packet to ff_bsf_get_packet_ref (except trace_headers, > which also uses it). But in the course of doing so, I also found several > other (usually

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-07-07 Thread Michael Niedermayer
On Fri, Jun 21, 2019 at 07:15:17AM -0700, Amir Pauker wrote: > set AVFrame decode_error_flags in case h->slice_ctx->er.error_occurred is set > after the call to ff_h264_execute_decode_slices. This allows the user to > detect > concealed decoding errors in the call to avcodec_receive_frame > >

[FFmpeg-devel] [PATCH v4 2/2] lavfi: addroi filter

2019-07-07 Thread Mark Thompson
This can be used to add region of interest side data to video frames. --- doc/filters.texi | 73 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_addroi.c | 269 +++ 4 files changed, 344 insertions(+)

[FFmpeg-devel] [PATCH v4 1/2] vaapi_encode: Add ROI support

2019-07-07 Thread Mark Thompson
--- libavcodec/vaapi_encode.c | 118 libavcodec/vaapi_encode.h | 18 + libavcodec/vaapi_encode_h264.c | 2 + libavcodec/vaapi_encode_h265.c | 2 + libavcodec/vaapi_encode_mpeg2.c | 2 + libavcodec/vaapi_encode_vp8.c | 2 +

Re: [FFmpeg-devel] [PATCH v3 3/5] libx265: Update ROI behaviour to match documentation

2019-07-07 Thread Mark Thompson
On 25/06/2019 09:47, Guo, Yejun wrote:>> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of >> Guo, Yejun >> Sent: Tuesday, June 04, 2019 2:46 PM >> To: FFmpeg development discussions and patches >> Subject: Re: [FFmpeg-devel] [PATCH v3 3/5]

Re: [FFmpeg-devel] [PATCH v4 1/5] lavc/h265_profile_level: Fix DPB size calculation

2019-07-07 Thread Mark Thompson
On 20/06/2019 17:10, James Almer wrote: > On 6/2/2019 1:48 PM, Mark Thompson wrote: >> On 06/05/2019 22:02, Mark Thompson wrote: >>> The maxDpbPicBuf value which is used in the DPB size calculation depends >>> on the profile (it's usually 6, but 7 for screen-extended profiles). >>> --- >>>

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-07 Thread Tomas Härdin
sön 2019-07-07 klockan 18:19 +0200 skrev Michael Niedermayer: > On Sat, Jul 06, 2019 at 11:22:59PM +0200, Tomas Härdin wrote: > > lör 2019-07-06 klockan 18:34 +0200 skrev Michael Niedermayer: > > > On Sat, Jul 06, 2019 at 02:34:34PM +0200, Tomas Härdin wrote: > > > > lör 2019-07-06 klockan 00:08

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-07 Thread Michael Niedermayer
On Sat, Jul 06, 2019 at 11:22:59PM +0200, Tomas Härdin wrote: > lör 2019-07-06 klockan 18:34 +0200 skrev Michael Niedermayer: > > On Sat, Jul 06, 2019 at 02:34:34PM +0200, Tomas Härdin wrote: > > > lör 2019-07-06 klockan 00:08 +0200 skrev Michael Niedermayer: > > > > As we are already off topic,

Re: [FFmpeg-devel] [PATCH 2/2] lavc/vaapi_decode: recreate hw_frames_ctx without destroy va_context

2019-07-07 Thread Fu, Linjie
goto fail; > > > + } > > > > > > -av_log(avctx, AV_LOG_DEBUG, "Decode context initialised: " > > > - "%#x/%#x.\n", ctx->va_config, ctx->va_context); > > > +av_log(avctx, AV_LOG_DEBUG, "Decode conte

Re: [FFmpeg-devel] [PATCH 2/5] lavu/hwcontext_vaapi: add vaapi_format_map for Y210/AYUV/Y410

2019-07-07 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Sunday, July 7, 2019 20:13 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 2/5] lavu/hwcontext_vaapi: add > vaapi_format_map for Y210/AYUV/Y410 > > On

Re: [FFmpeg-devel] [PATCH 2/2] lavc/vaapi_decode: recreate hw_frames_ctx without destroy va_context

2019-07-07 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Hendrik Leppkes > Sent: Sunday, July 7, 2019 15:39 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavc/vaapi_decode: recreate >

Re: [FFmpeg-devel] [PATCH 2/2] lavc/vaapi_decode: recreate hw_frames_ctx without destroy va_context

2019-07-07 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Sunday, July 7, 2019 19:51 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavc/vaapi_decode: recreate > hw_frames_ctx without destroy va_context

[FFmpeg-devel] [PATCH 5/5] avutil/softfloat_ieee754: Fix odd bit position for exponent and sign in av_bits2sf_ieee754()

2019-07-07 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavutil/softfloat_ieee754.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/softfloat_ieee754.h b/libavutil/softfloat_ieee754.h index b8957fb0a9..3398aa18be 100644 --- a/libavutil/softfloat_ieee754.h +++

[FFmpeg-devel] [PATCH 2/5] avcodec/alsdec: fix undefined shift in multiply()

2019-07-07 Thread Michael Niedermayer
Fixes: left shift of negative value -6 Fixes: 15564/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5701655938465792 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/alsdec.c | 2

[FFmpeg-devel] [PATCH 3/5] avcodec/flashsv: add FF_CODEC_CAP_INIT_CLEANUP to flashsv1

2019-07-07 Thread Michael Niedermayer
Fixes: memleaks on error paths during init Fixes: 15533/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLASHSV_fuzzer-5647977168764928 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 4/5] avcodec/flashsv: add FF_CODEC_CAP_INIT_CLEANUP to flashsv2

2019-07-07 Thread Michael Niedermayer
Fixes: memleaks on error paths during init Fixes: 15548/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLASHSV2_fuzzer-6324019382452224 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 1/5] avcodec/alsdec: Fix 2 integer overflows

2019-07-07 Thread Michael Niedermayer
Fixes: signed integer overflow: 1270564968 + 904828220 cannot be represented in type 'int' Fixes: 15402/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5755426823471104 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH] AMF: Vulkan initialization support for encoder.

2019-07-07 Thread Mark Thompson
On 19/06/2019 16:03, OvchinnikovDmitrii wrote: > Added linux support for amf encoder through vulkan. > > To use h.264(AMD VCE) encoder on linux amdgru-pro version 19.20+ and > amf-amdgpu-pro package(amdgru-pro contains, but does not install > automatically) are required. > > Initialization of

Re: [FFmpeg-devel] [PATCH v3] avfilter/vaapi: add overlay_vaapi filter

2019-07-07 Thread Mark Thompson
On 20/06/2019 08:42, Zachary Zhou wrote: > --- > configure | 1 + > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vaapi_vpp.c| 95 + > libavfilter/vaapi_vpp.h| 5 + > libavfilter/vf_overlay_vaapi.c

Re: [FFmpeg-devel] [PATCH 2/5] lavu/hwcontext_vaapi: add vaapi_format_map for Y210/AYUV/Y410

2019-07-07 Thread Mark Thompson
On 28/06/2019 03:27, Linjie Fu wrote: > Signed-off-by: Linjie Fu > --- > libavutil/hwcontext_vaapi.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c > index 4227c3c..6378d0e 100644 > --- a/libavutil/hwcontext_vaapi.c >

Re: [FFmpeg-devel] [PATCH]lavc/frame_thread_encoder: Do not memcpy() from NULL

2019-07-07 Thread Mark Thompson
On 02/07/2019 10:44, Carl Eugen Hoyos wrote: > Am Di., 2. Juli 2019 um 08:31 Uhr schrieb Reimar Döffinger > : >> >> On 01.07.2019, at 00:51, Carl Eugen Hoyos wrote: > >>> I believe attached patch fixes undefined behaviour and ticket #7981. >> >> Same here, I think it makes more sense to check

Re: [FFmpeg-devel] [PATCH 2/2] lavc/vaapi_decode: recreate hw_frames_ctx without destroy va_context

2019-07-07 Thread Mark Thompson
On 07/07/2019 17:38, Linjie Fu wrote: > VP9 allows resolution changes per frame. Currently in VAAPI, resolution > changes leads to va context destroy and reinit. Which is correct - it needs to remake the context because the old one is for the wrong resolution. >

Re: [FFmpeg-devel] [PATCH V1 2/2] doc/filters: Document missing options for scale in/out color matrix

2019-07-07 Thread myp...@gmail.com
On Fri, Jul 5, 2019 at 12:48 PM Gyan wrote: > > > > On 05-07-2019 10:06 AM, Jun Zhao wrote: > > From: Jun Zhao > > > > Document missing options for scale in/out color matrix > > > > Signed-off-by: Jun Zhao > > --- > > doc/filters.texi |5 + > > 1 files changed, 5 insertions(+), 0

Re: [FFmpeg-devel] [PATCH v1] lavc/libdavs2.c: optimize frame copy

2019-07-07 Thread myp...@gmail.com
On Fri, Jul 5, 2019 at 9:09 AM Song, Ruiling wrote: > > > -Original Message- > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > Of hwrenx > > Sent: Wednesday, July 3, 2019 11:24 AM > > To: ffmpeg-devel@ffmpeg.org > > Subject: [FFmpeg-devel] [PATCH v1]

Re: [FFmpeg-devel] [PATCH] avcodec: Implement DM PAR Muxer/Demuxer

2019-07-07 Thread Paul B Mahol
On 7/5/19, Tom Needham <06needh...@gmail.com> wrote: > Samples are Available from > > https://transfernow.net/131xk9g4u0jt > Is there native Windows player for those files? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/2] lavc/vaapi_decode: recreate hw_frames_ctx without destroy va_context

2019-07-07 Thread Hendrik Leppkes
On Sun, Jul 7, 2019 at 6:41 AM Linjie Fu wrote: > > VP9 allows resolution changes per frame. Currently in VAAPI, resolution > changes leads to va context destroy and reinit. This will cause > reference frame surface lost and produce garbage. > > As libva allows re-create surface separately