Re: [FFmpeg-devel] [PATCH] DSD and DST speed improvements

2019-08-01 Thread David Bryant
On 7/31/19 11:49 PM, Paul B Mahol wrote: > Hi, > > patches attached. > > This time DSD decoding is approx %50 faster on old Celeron N3050 CPUs and 2 > threads. I see about 42% speedup on Core Duo E8400 (36x to 52x) for a 5-channel file. On the same file encoded in DST, the improvement almost

[FFmpeg-devel] [PATCH] FATE/dnn: let fate/dnn tests depend on ffmpeg static libraries

2019-08-01 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- tests/dnn/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/dnn/Makefile b/tests/dnn/Makefile index b2e6680..0e050ea 100644 --- a/tests/dnn/Makefile +++ b/tests/dnn/Makefile @@ -4,8 +4,8 @@ DNNTESTOBJS :=

Re: [FFmpeg-devel] [PATCH v2] avcodec/vaapi_encode_h264: add support for a/53 closed caption sei

2019-08-01 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Aman Gupta > Sent: Friday, August 2, 2019 07:33 > To: ffmpeg-devel@ffmpeg.org > Cc: Aman Gupta > Subject: [FFmpeg-devel] [PATCH v2] avcodec/vaapi_encode_h264: add > support for a/53 closed

Re: [FFmpeg-devel] [PATCH] Revert "fate: add unit test for dnn-layer-pad"

2019-08-01 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Hendrik Leppkes > Sent: Thursday, August 01, 2019 11:14 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] Revert "fate: add unit test for >

[FFmpeg-devel] [PATCH] Extract QP from h264 encoded videos

2019-08-01 Thread Juan De León
Fixed design doc: https://docs.google.com/document/d/1WClt3EqhjwdGXhEw386O0wfn3IBQ1Ib-_5emVM1gbnA/edit?usp=sharing Signed-off-by: Juan De León --- libavutil/Makefile | 2 + libavutil/frame.h | 6 ++ libavutil/quantization_params.c | 42 +

[FFmpeg-devel] [PATCH v2] avcodec/vaapi_encode_h264: add support for a/53 closed caption sei

2019-08-01 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/vaapi_encode_h264.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c index f4965d8b09..9860bacb91 100644 ---

Re: [FFmpeg-devel] [PATCH] Extract QP from h264 encoded videos

2019-08-01 Thread Michael Niedermayer
On Tue, Jul 30, 2019 at 06:47:23PM -0700, Juan De León wrote: > Removed AVQuantizationParamsArray to prevent ambiguous memory allocation. > For simplicity, the side data will be allocated as an array of > AVQuantizationParams and the last element of the array will have w and h set > to 0. > >

[FFmpeg-devel] [PATCH 2/5] avcodec/pnm: Check magic bytes directly without pnm_get()

2019-08-01 Thread Michael Niedermayer
Fixes: Timeout (10sec -> 30ms) (case 15089) Fixes: 15089/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PBM_fuzzer-5767535057698816 Fixes: 16001/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PGM_fuzzer-5199169645445120 Fixes:

[FFmpeg-devel] [PATCH 3/5] avcodec/pnm: skip reading trailing bytes in get_pnm()

2019-08-01 Thread Michael Niedermayer
None of the keys we support is that long and other keys lead to decoder failure. None of the values is expected to be longer, they are all numbers or short keywords. This simplifies the code Fixes: Timeout (9sec->43ms) Fixes:

[FFmpeg-devel] [PATCH 5/5] avcodec/pnm_parser: Use memmove() to handle "overread"

2019-08-01 Thread Michael Niedermayer
This is significantly faster Fixes: Timeout (1sec after this and the previous commit) Fixes: 15558/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PPM_fuzzer-5705273643106304 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 4/5] avcodec/parser: Optimize ff_combine_frame() with massivly negative next

2019-08-01 Thread Michael Niedermayer
Fixes: Timeout Fixes: 15558/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PPM_fuzzer-5705273643106304 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/parser.c | 4 1 file changed, 4

[FFmpeg-devel] [PATCH 1/5] avcodec/vp8: do vp7_fade_frame() later

2019-08-01 Thread Michael Niedermayer
Fixes: Timeout (100sec -> 5sec) Fixes: 15073/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP7_fuzzer-5649257362620416 Untested as none of the vp7 samples i found executes this codepath Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v3]

2019-08-01 Thread Marton Balint
On Thu, 1 Aug 2019, Andreas Håkon wrote: Hi Marton, First of all, a new version [v4] is posted here: https://patchwork.ffmpeg.org/patch/14121/ I replied to the wrong (v3) mail, but I commented the v4 version. However, I'll comment on your suggestions, as they are reasonable. ‐‐‐

Re: [FFmpeg-devel] [PATCH] mpegts pat and sdt period should respect user options

2019-08-01 Thread Tomas Hulata
Hi, sorry for delay, I wasn't tracking response, let's try it as attachment. Thx On 6/6/19 11:58 PM, Michael Niedermayer wrote: On Wed, Jun 05, 2019 at 11:13:20PM +0200, Tomas Hulata wrote: When mux_rate (CBR) is defined, pat/sdt period setting is now respected. In case of VBR, leave it as

[FFmpeg-devel] [PATCH] avcodec/vaapi_encode_h264: add support for a/53 closed caption sei

2019-08-01 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/vaapi_encode_h264.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c index f4965d8b09..f66e483b7f 100644 ---

Re: [FFmpeg-devel] [PATCH] Extract QP from h264 encoded videos

2019-08-01 Thread Juan De León
On Tue, Jul 30, 2019 at 6:50 PM Juan De León wrote: > Removed AVQuantizationParamsArray to prevent ambiguous memory allocation. > For simplicity, the side data will be allocated as an array of > AVQuantizationParams and the last element of the array will have w and h > set to 0. > > Better

Re: [FFmpeg-devel] [PATCH] DSD and DST speed improvements

2019-08-01 Thread Carl Eugen Hoyos
Am Do., 1. Aug. 2019 um 08:55 Uhr schrieb Paul B Mahol : > patches attached. > > This time DSD decoding is approx %50 faster on old Celeron N3050 CPUs and 2 > threads. As written on irc: On both Intel and ppc, I see worse performance for threads=2 and threads =6 than threads=1 with this patch

Re: [FFmpeg-devel] [PATCH] lavfi/zmq: Avoid mem copy past the end of input buffer

2019-08-01 Thread Carl Eugen Hoyos
Am Di., 30. Juli 2019 um 23:25 Uhr schrieb Andriy Gelman : > > From: Andriy Gelman > > --- > libavfilter/f_zmq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/f_zmq.c b/libavfilter/f_zmq.c > index 89da5bef06..744c721305 100644 > --- a/libavfilter/f_zmq.c >

Re: [FFmpeg-devel] [PATCH 2/3] avformat: Support s337m in mxf/wav/w64

2019-08-01 Thread Gaullier Nicolas
> > > MXF has a UL registered for Dolby-E: > I also notice this UL is already in mxf.c, but added commented out by > Baptiste back in 2006.. There are two ways for signalling dolby-E in MXF : channel status IF using an AES3 descriptor, or the registered UL for Sound Essence Coding. ARD/ZDF/HDF

Re: [FFmpeg-devel] [PATCH] dnn: rename function from dnn_execute_layer_pad to avfilter_dnn_execute_layer_pad

2019-08-01 Thread Paul B Mahol
On Thu, Aug 1, 2019 at 6:07 PM Pedro Arthur wrote: > Hi, > > Em qui, 1 de ago de 2019 às 06:36, Paul B Mahol > escreveu: > > > > Why test uses internal function, why was this allowed to be committed at > > all? > > Who is reviewing this mess? > > > > Why test does not use normal filtergraph? >

Re: [FFmpeg-devel] [PATCH] dnn: rename function from dnn_execute_layer_pad to avfilter_dnn_execute_layer_pad

2019-08-01 Thread Pedro Arthur
Hi, Em qui, 1 de ago de 2019 às 06:36, Paul B Mahol escreveu: > > Why test uses internal function, why was this allowed to be committed at > all? > Who is reviewing this mess? > > Why test does not use normal filtergraph? > I was responsible for pushing the patch, thanks for point out the

Re: [FFmpeg-devel] [PATCH] lavu/tx: add support for double precision FFT and MDCT

2019-08-01 Thread Lynne
Jul 27, 2019, 7:29 PM by d...@lynne.ee: > Simply moves and templates the actual transforms to support an > additional data type. > Unlike the float version, which is equal or better than libfftw3f, > double precision output is bit identical with libfftw3. > Planning to push attached version

Re: [FFmpeg-devel] [PATCH] lavfi/zmq: Avoid mem copy past the end of input buffer

2019-08-01 Thread Paul B Mahol
On Tue, Jul 30, 2019 at 11:24 PM Andriy Gelman wrote: > From: Andriy Gelman > > --- > libavfilter/f_zmq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/f_zmq.c b/libavfilter/f_zmq.c > index 89da5bef06..744c721305 100644 > --- a/libavfilter/f_zmq.c > +++

Re: [FFmpeg-devel] [PATCH] Revert "fate: add unit test for dnn-layer-pad"

2019-08-01 Thread Hendrik Leppkes
On Thu, Aug 1, 2019 at 4:53 PM Guo, Yejun wrote: > > This reverts commit 3805aae47966b691f825abab6843f55676437a02. > > this test calls internal DNN functions within libavfilter, it is > not allowed, and so revert it. > Its not that its not allowed, it just needs to be setup properly. We have for

[FFmpeg-devel] [PATCH] Revert "fate: add unit test for dnn-layer-pad"

2019-08-01 Thread Guo, Yejun
This reverts commit 3805aae47966b691f825abab6843f55676437a02. this test calls internal DNN functions within libavfilter, it is not allowed, and so revert it. Signed-off-by: Guo, Yejun --- tests/Makefile | 5 +- tests/dnn/Makefile | 11 ---

Re: [FFmpeg-devel] [PATCH, v2 2/4] avc/avcodec: add AV_CODEC_CAP_VARIABLE_DIMENSIONS flag

2019-08-01 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Michael Niedermayer > Sent: Wednesday, July 31, 2019 14:04 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, v2 2/4] avc/avcodec: add >

Re: [FFmpeg-devel] [PATCH, v2 3/3] lavc/libvpxenc: add dynamic resolution encode support for libvpx

2019-08-01 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of James Zern > Sent: Thursday, August 1, 2019 07:15 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, v2 3/3] lavc/libvpxenc: add dynamic

Re: [FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v4]

2019-08-01 Thread Andriy Gelman
Andreas, On Thu, 01. Aug 08:24, Andreas Håkon wrote: > Hi Andriy, > > > ‐‐‐ Original Message ‐‐‐ > On Thursday, 1 de August de 2019 0:23, Andriy Gelman > wrote: > > > > +for (i = 0; i < ts->nb_services; i++) { > > > +service = ts->services[i]; > > > +

[FFmpeg-devel] [PATCH] avcodec/msrle: remove unused items

2019-08-01 Thread Paul B Mahol
Hi, patch attached. 0001-avcodec-msrle-remove-unused-items.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH]Support for Frame Doubling/ Tripling in FFMPEG's HEVC Decoder by parsing the picture_struct SEI value (Support for http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.h

2019-08-01 Thread Devin Heitmueller
> On Aug 1, 2019, at 8:46 AM, Praveen Kumar wrote: > > Hi, > > This patch has the implementation for frame duplication (doubling/ tripling) > in FFmpeg's HEVC decoder based on the picture_structre SEI value (7 for > doubling and 8 for tripling) set while encoding. > This addresses the

[FFmpeg-devel] [PATCH]Support for Frame Doubling/ Tripling in FFMPEG's HEVC Decoder by parsing the picture_struct SEI value (Support for http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.html)

2019-08-01 Thread Praveen Kumar
Hi, This patch has the implementation for frame duplication (doubling/ tripling) in FFmpeg's HEVC decoder based on the picture_structre SEI value (7 for doubling and 8 for tripling) set while encoding. This addresses the requirement mentioned in the thread

Re: [FFmpeg-devel] [PATCH] dnn: rename function from dnn_execute_layer_pad to avfilter_dnn_execute_layer_pad

2019-08-01 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Nicolas George > Sent: Thursday, August 01, 2019 5:10 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] dnn: rename function from >

Re: [FFmpeg-devel] [PATCH] Ticket #7124: Fixes compiler bug - replace vec_lvsl/vec_perm with vec_xl

2019-08-01 Thread Moritz Barsnick
Hi, On Thu, Aug 01, 2019 at 07:42:28 -0400, ckerchne wrote: Just a small hint: You patch was corrupted by newlines inserted by your email client. Try attaching the patch file, or using git send-email. > > --- a/libswscale/ppc/yuv2rgb_altivec.c > > +++ b/libswscale/ppc/yuv2rgb_altivec.c > > @@

Re: [FFmpeg-devel] [PATCH] Ticket #7124: Fixes compiler bug - replace vec_lvsl/vec_perm with vec_xl

2019-08-01 Thread ckerchne
On 2019-07-23 08:51, ckerchne wrote: A bug exist with the gcc compilers for Power in versions 6.x and 7.x (verified with 6.3 and 7.4). It was fixed in version 8.x (verified with 8.3). I was using a Power 9 ppc64le machine for building and testing. It appears the compiler is generating the wrong

Re: [FFmpeg-devel] [PATCH] FATE: add hls single file mode test case

2019-08-01 Thread Liu Steven
> 在 2019年7月30日,下午5:16,Steven Liu 写道: > > Signed-off-by: Steven Liu > --- > tests/fate/hlsenc.mak | 11 + > tests/ref/fate/hls-segment-single | 772 ++ > 2 files changed, 783 insertions(+) > create mode 100644 tests/ref/fate/hls-segment-single > > diff

Re: [FFmpeg-devel] [PATCH] dnn: rename function from dnn_execute_layer_pad to avfilter_dnn_execute_layer_pad

2019-08-01 Thread Paul B Mahol
Why test uses internal function, why was this allowed to be committed at all? Who is reviewing this mess? Why test does not use normal filtergraph? > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v3]

2019-08-01 Thread Andreas Håkon
Hi Marton, First of all, a new version [v4] is posted here: https://patchwork.ffmpeg.org/patch/14121/ However, I'll comment on your suggestions, as they are reasonable. ‐‐‐ Original Message ‐‐‐ On Wednesday, 31 de July de 2019 23:58, Marton Balint wrote: > > +for (i = 0; i <

Re: [FFmpeg-devel] [PATCH] dnn: rename function from dnn_execute_layer_pad to avfilter_dnn_execute_layer_pad

2019-08-01 Thread Nicolas George
Paul B Mahol (12019-08-01): > I do not like this. I agree. The av namespace is for public functions. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] dnn: rename function from dnn_execute_layer_pad to avfilter_dnn_execute_layer_pad

2019-08-01 Thread Paul B Mahol
I do not like this. On Thu, Aug 1, 2019 at 8:22 AM Guo, Yejun wrote: > background: > DNN (deep neural network) is a sub module of libavfilter, and FATE/dnn > is unit test for the DNN module, one unit test for one dnn layer. > The unit tests are not based on the APIs exported by libavfilter, >

Re: [FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v4]

2019-08-01 Thread Andreas Håkon
Hi Andriy, ‐‐‐ Original Message ‐‐‐ On Thursday, 1 de August de 2019 0:23, Andriy Gelman wrote: > > +for (i = 0; i < ts->nb_services; i++) { > > +service = ts->services[i]; > > +service->pcr_st = NULL; > > +} > > + > > If you are going to add pcr_st to

[FFmpeg-devel] [PATCH] DSD and DST speed improvements

2019-08-01 Thread Paul B Mahol
Hi, patches attached. This time DSD decoding is approx %50 faster on old Celeron N3050 CPUs and 2 threads. 0001-avformat-dsfdec-set-packet-pts-duration-pos-correctl.patch Description: Binary data 0002-avcodec-dsddec-add-slice-threading-support.patch Description: Binary data

Re: [FFmpeg-devel] [PATCH] avcodec/dsddec: add slice threading support

2019-08-01 Thread Paul B Mahol
On Thu, Aug 1, 2019 at 3:56 AM David Bryant wrote: > > On 7/30/19 1:43 AM, Carl Eugen Hoyos wrote: > > Am So., 28. Juli 2019 um 23:35 Uhr schrieb Paul B Mahol < > one...@gmail.com>: > >> Hi, > >> > >> patch attached. > > As just posted on irc: > > On an 8-core Intel cpu, this makes decoding

Re: [FFmpeg-devel] [PATCH v16 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-08-01 Thread Sun, Jing A
-Original Message- From: Sun, Jing A Sent: Thursday, August 1, 2019 3:53 PM To: ffmpeg-devel@ffmpeg.org Cc: Sun, Jing A ; Huang, Zhengxu ; Tmar, Hassene ; Jun Zhao Subject: [PATCH v16 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper [Patch content] This update removed the code line

[FFmpeg-devel] Recall: [PATCH v16 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-08-01 Thread Sun, Jing A
Sun, Jing A would like to recall the message, "[PATCH v16 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

Re: [FFmpeg-devel] [PATCH v16 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-08-01 Thread Sun, Jing A
-Original Message- From: Sun, Jing A Sent: Thursday, August 1, 2019 3:53 PM To: ffmpeg-devel@ffmpeg.org Cc: Sun, Jing A ; Huang, Zhengxu ; Tmar, Hassene ; Jun Zhao Subject: [PATCH v16 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper [Patch content] This update removed the code

[FFmpeg-devel] [PATCH v16 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-08-01 Thread Jing Sun
Signed-off-by: Zhengxu Huang Signed-off-by: Hassene Tmar Signed-off-by: Jun Zhao Signed-off-by: Jing Sun --- configure| 4 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libsvt_hevc.c | 500 +++

[FFmpeg-devel] [PATCH] dnn: rename function from dnn_execute_layer_pad to avfilter_dnn_execute_layer_pad

2019-08-01 Thread Guo, Yejun
background: DNN (deep neural network) is a sub module of libavfilter, and FATE/dnn is unit test for the DNN module, one unit test for one dnn layer. The unit tests are not based on the APIs exported by libavfilter, they just directly call into the functions within DNN submodule. (It is not easy