Re: [FFmpeg-devel] [PATCH 1/3] avutil/pixfmt: Add EBU Tech. 3213-E AVColorPrimaries value

2019-08-31 Thread Raphaël Zumer
It's been about 3 weeks, so sending a reminder in case anyone can review this. On 2019-08-11 9:54 a.m., rzu...@tebako.net wrote: From: Raphaël Zumer This is an alias for JEDEC P22. The name associated with the value is also changed from "jedec-p22" to "ebu3213" to match ITU-T H.273. Signed-

[FFmpeg-devel] [PATCH 2/5] avcodec/vc1_pred: Fix refdist in scaleforopp()

2019-08-31 Thread Michael Niedermayer
Fixes: out of array access Fixes: 16601/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1IMAGE_fuzzer-5656105392275456 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vc1_pred.c | 3 ++- 1

[FFmpeg-devel] [PATCH 1/5] avcodec/vc1: check REFDIST

2019-08-31 Thread Michael Niedermayer
"9.1.1.43 P Reference Distance (REFDIST)" "The value of REFDIST shall be less than, or equal to, 16." Signed-off-by: Michael Niedermayer --- libavcodec/vc1.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/vc1.c b/libavcodec/vc1.c index e102b931d8..42bfca55b1 10

[FFmpeg-devel] [PATCH 5/5] avformat/vividas: check for tiny blocks using alignment

2019-08-31 Thread Michael Niedermayer
Ask for a sample for these Fixes: out of array access Fixes: 16624/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5762455661182976 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/vivida

[FFmpeg-devel] [PATCH 4/5] avformat/vividas: Remove align offset which is always masked off

2019-08-31 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/vividas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/vividas.c b/libavformat/vividas.c index 61dfcf11c1..075a521cd2 100644 --- a/libavformat/vividas.c +++ b/libavformat/vividas.c @@ -214,7 +214,7 @@ static uin

[FFmpeg-devel] [PATCH 3/5] avformat/vividas: remove dead assignment

2019-08-31 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/vividas.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/vividas.c b/libavformat/vividas.c index 645e322b6e..61dfcf11c1 100644 --- a/libavformat/vividas.c +++ b/libavformat/vividas.c @@ -160,8 +160,6 @@ static void decode_block(

Re: [FFmpeg-devel] [PATCH v4] Add ZeroMQ as protocol option

2019-08-31 Thread Andriy Gelman
On Sat, 31. Aug 03:20, Marton Balint wrote: > > > On Sat, 31 Aug 2019, Marton Balint wrote: > > > > > > > On Fri, 30 Aug 2019, Andriy Gelman wrote: > > > > > On Thu, 29. Aug 21:01, Marton Balint wrote: > > > > > > > > > > > > On Thu, 29 Aug 2019, Andriy Gelman wrote: > > > > > > > > > Chan

[FFmpeg-devel] [PATCH v6] Add ZeroMQ as protocol option

2019-08-31 Thread Andriy Gelman
Changes in v6: - Changed minimum required libzmq version from 4.3.1 to 4.2.1 - Removed ff_ prefix from static functions - Use zmq_ctx_term function instead of zmq_ctx_destroy (since zmq_ctx_destroy is deprecated) Thanks, Andriy >From 6f63e7303e35fe9a16d1f76091fc50694457d952 Mon

Re: [FFmpeg-devel] [PATCH v5] Add ZeroMQ as protocol option

2019-08-31 Thread Andriy Gelman
On Sat, 31. Aug 01:59, Marton Balint wrote: > > > On Fri, 30 Aug 2019, Andriy Gelman wrote: > > > Changes in v5: > >- Use polling in a loop to check interrupt callback. > >- Remove timeout_send/timeout_recv options and update > > documentation. > > Thanks, two comments: > > I noti

Re: [FFmpeg-devel] [PATCH 1/2] lavu/pixfmt: add AYUV pixel format

2019-08-31 Thread Carl Eugen Hoyos
Am Sa., 31. Aug. 2019 um 19:25 Uhr schrieb Fu, Linjie : > > > -Original Message- > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > Of Mark Thompson > > Sent: Saturday, August 31, 2019 23:10 > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH 1/

Re: [FFmpeg-devel] [PATCH 1/2] lavu/pixfmt: add AYUV pixel format

2019-08-31 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Saturday, August 31, 2019 23:10 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavu/pixfmt: add AYUV pixel format > > On 31/08/2019 05:22, Fu, Li

Re: [FFmpeg-devel] [PATCH 1/2] docs/formats: fix max_interleave_delta default

2019-08-31 Thread Gyan
On 31-08-2019 09:55 PM, Marton Balint wrote: On Tue, 27 Aug 2019, Marton Balint wrote: Signed-off-by: Marton Balint --- doc/formats.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/formats.texi b/doc/formats.texi index 729c77b01d..d689fbadfa 100644 --- a/doc/form

Re: [FFmpeg-devel] [PATCH 1/2] docs/formats: fix max_interleave_delta default

2019-08-31 Thread Marton Balint
On Tue, 27 Aug 2019, Marton Balint wrote: Signed-off-by: Marton Balint --- doc/formats.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/formats.texi b/doc/formats.texi index 729c77b01d..d689fbadfa 100644 --- a/doc/formats.texi +++ b/doc/formats.texi @@ -139,7 +139,7

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: fix teletext PTS when selecting teletext streams only

2019-08-31 Thread Marton Balint
On Wed, 28 Aug 2019, Jan Ekström wrote: On Sat, Aug 24, 2019 at 2:04 AM Marton Balint wrote: After a1b4f120c031e6697bac9fd8c725d9c37ee36d13 the teletext PTS values were set to AV_NOPTS_VALUE if the stream of the PCR pid was discarded. What actually matters is that if we parse the PCR of th

Re: [FFmpeg-devel] [PATCH] avformat/utils: return pending IO error on EOF in av_read_frame()

2019-08-31 Thread Marton Balint
On Thu, 29 Aug 2019, Nicolas George wrote: Marton Balint (12019-08-24): avio_feof() returns true both in case of actual EOF and in case of IO errors. Some demuxers (matroska) have special handling to be able to return the proper error for this exact reason, e.g.: if (avio_feof(pb)) { if

Re: [FFmpeg-devel] [PATCH] avformat/avidec: add support for recognizing HEVC fourcc when demuxing

2019-08-31 Thread Marton Balint
On Thu, 29 Aug 2019, Marton Balint wrote: On Sat, 24 Aug 2019, James Almer wrote: On Sat, Aug 24, 2019 at 5:48 AM Marton Balint wrote: On Sat, 24 Aug 2019, Carl Eugen Hoyos wrote: > Am Sa., 24. Aug. 2019 um 01:47 Uhr schrieb Marton Balint : >> >> Some security cams generate this, as

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/truemotion2: Fix multiple integer overflows in

2019-08-31 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 11:21:04AM +0200, Michael Niedermayer wrote: > On Sat, Aug 17, 2019 at 03:40:26PM +0200, Moritz Barsnick wrote: > > On Thu, Aug 15, 2019 at 23:49:15 +0200, Michael Niedermayer wrote: > > > Subject: [FFmpeg-devel] [PATCH 7/7] avcodec/truemotion2: Fix multiple > > > integer o

Re: [FFmpeg-devel] [PATCH 6/7] tools/target_dec_fuzzer: adjust pixel threshold for TRUEMOTION2, as it allows coding gigantic images on tiny input

2019-08-31 Thread Michael Niedermayer
On Thu, Aug 15, 2019 at 11:49:14PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (137sec -> 6sec) > Fixes: > 16090/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-5674245178261504 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/

Re: [FFmpeg-devel] [PATCH 4/7] avcodec/vc1_block: Check the return code from vc1_decode_p_block()

2019-08-31 Thread Michael Niedermayer
On Thu, Aug 15, 2019 at 11:49:12PM +0200, Michael Niedermayer wrote: > Fixes: left shift of negative value -1 > Fixes: > 16424/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV3_fuzzer-5656579055026176 > Fixes: > 16358/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1IMAGE_fuzzer-57144363

Re: [FFmpeg-devel] [PATCH 3/7] avcodec/vc1dec: Require res_sprite for wmv3images

2019-08-31 Thread Michael Niedermayer
On Thu, Aug 15, 2019 at 11:49:11PM +0200, Michael Niedermayer wrote: > non res_sprite leads to decoder delay which leads to assertion failure > Fixes: Assertion failure > Fixes: > 16402/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV3IMAGE_fuzzer-5704510034411520 > Fixes: left shift of 10737

Re: [FFmpeg-devel] [PATCH 2/7] avcodec/vc1_block: Check for double escapes

2019-08-31 Thread Michael Niedermayer
On Thu, Aug 15, 2019 at 11:49:10PM +0200, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 16331/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV3IMAGE_fuzzer-5672735195267072 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/

Re: [FFmpeg-devel] [PATCH 1/3] tools/target_dec_fuzzer: Init parsepkt

2019-08-31 Thread Michael Niedermayer
On Fri, Aug 30, 2019 at 08:51:53PM -0300, James Almer wrote: > On 8/30/2019 8:25 PM, Michael Niedermayer wrote: > > Fixes: memory corruption > > Fixes: > > 16702/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PNG_fuzzer-5768418552184832 > > > > Found-by: continuous fuzzing process > > https:/

[FFmpeg-devel] [PATCH] avcodec/decode: add a flags parameter to ff_reget_buffer()

2019-08-31 Thread James Almer
Some decoders may not need a writable buffer in some specific cases, but only a reference to the existing buffer with updated frame properties instead, for the purpose of returning duplicate frames. For this, the FF_REGET_BUFFER_FLAG_READONLY flag is added, which will prevent potential allocations

Re: [FFmpeg-devel] [PATCH 1/2] lavu/pixfmt: add AYUV pixel format

2019-08-31 Thread Mark Thompson
On 31/08/2019 05:22, Fu, Linjie wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Carl Eugen Hoyos >> Sent: Friday, August 30, 2019 00:12 >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: Re: [FFmpeg-d

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: adjust for timecode lag

2019-08-31 Thread Gyan
On 31-08-2019 08:11 PM, Marton Balint wrote: On Sat, 31 Aug 2019, Gyan wrote: On 31-08-2019 04:14 AM, Marton Balint wrote: On Fri, 30 Aug 2019, Gyan wrote: On 22-08-2019 01:10 AM, Marton Balint wrote: On Tue, 20 Aug 2019, Devin Heitmueller wrote: A couple of follow-up Qs: Is

[FFmpeg-devel] [PATCH] ffmpeg: switch to avformat_seek_file for stream_loop

2019-08-31 Thread Gyan
A user observed that stream_loop didn't work with very short FLV files. seek_to_start in ffmpeg.c calls av_seek_frame with no flags; FLV seek only works with RTMP protocol so lavf falls back on seek_frame_generic which searches forward, skipping a GOP. With files with two index entries in strea

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: adjust for timecode lag

2019-08-31 Thread Marton Balint
On Sat, 31 Aug 2019, Gyan wrote: On 31-08-2019 04:14 AM, Marton Balint wrote: On Fri, 30 Aug 2019, Gyan wrote: On 22-08-2019 01:10 AM, Marton Balint wrote: On Tue, 20 Aug 2019, Devin Heitmueller wrote: A couple of follow-up Qs: Is auto-detection available for all Decklink device

Re: [FFmpeg-devel] [PATCH] avcodec/decode: add a parameter to ff_reget_buffer() to request a writable buffer

2019-08-31 Thread Michael Niedermayer
On Fri, Aug 30, 2019 at 04:26:57PM -0300, James Almer wrote: > Some decoders may not need a writable buffer in some specific cases, but only > a reference to the existing buffer with updated frame properties instead, for > the purpose of returning duplicate frames. > > Signed-off-by: James Almer

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: Check for EOF in mov_read_meta()

2019-08-31 Thread Nicolas George
James Almer (12019-08-31): > There's Marton's "avformat/utils: return pending IO error on EOF in > av_read_frame()" patch to check in generic code if avio_feof() != 0 is > an actual EOF or an IO error, so if you make this code here simply break > the loop, same as it's done in mov_read_default(), t

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: Check for EOF in mov_read_meta()

2019-08-31 Thread James Almer
On 8/31/2019 5:47 AM, Michael Niedermayer wrote: > On Fri, Aug 30, 2019 at 08:57:29PM -0300, James Almer wrote: >> On 8/30/2019 8:25 PM, Michael Niedermayer wrote: >>> Fixes: Timeout (195sec -> 2ms) >>> Fixes: >>> 16735/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5090676403863552 >>> >>>

[FFmpeg-devel] [PATCH] avformat/mpegts: Only add keyframe index entries for keyframe packets

2019-08-31 Thread fumoboy007
From: fumoboy007 Signed-off-by: fumoboy007 --- libavformat/mpegts.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 47d8d5f877..a35ea65875 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -3201,8 +3201,11 @

[FFmpeg-devel] [PATCH 1/2] avformat/avformat: Introduced `AVInputFormat.read_timestamp2` to fix keyframe seeking for formats that rely on `read_timestamp` for seeking

2019-08-31 Thread fumoboy007
From: fumoboy007 If the user omits `AVSEEK_FLAG_ANY`, then the result of the seek should be a keyframe. `ff_gen_search` did not respect that contract because it had no good way to determine whether a timestamp returned by `read_timestamp` was for a keyframe packet. Therefore, we introduce `re

[FFmpeg-devel] [PATCH 2/2] avformat/mpegts: Fixed keyframe seeking by migrating from `read_timestamp` to `read_timestamp2`

2019-08-31 Thread fumoboy007
From: fumoboy007 Signed-off-by: fumoboy007 --- libavformat/mpegts.c | 46 ++-- tests/ref/fate/concat-demuxer-simple2-lavf-ts | 70 ++- tests/ref/seek/lavf-ts| 6 +- 3 files changed, 96 insertions(+), 26 deletions(-) diff

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: Check for EOF in mov_read_meta()

2019-08-31 Thread Michael Niedermayer
On Fri, Aug 30, 2019 at 08:57:29PM -0300, James Almer wrote: > On 8/30/2019 8:25 PM, Michael Niedermayer wrote: > > Fixes: Timeout (195sec -> 2ms) > > Fixes: > > 16735/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5090676403863552 > > > > Found-by: continuous fuzzing process > > https://g

Re: [FFmpeg-devel] [PATCH v1 4/5] avcodec/v210enc: make 8bit and 10bit process consistent

2019-08-31 Thread Limin Wang
On Fri, Aug 30, 2019 at 08:15:12PM +0200, Michael Niedermayer wrote: > On Wed, Aug 28, 2019 at 11:45:15PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/v210enc.c | 16 > > 1 file changed, 8 insertions(+), 8 de

Re: [FFmpeg-devel] [PATCH v1 3/5] avcodec/v210enc: define DEFINE_V210_PLANAR_FUNC to remove duplicate function

2019-08-31 Thread Limin Wang
On Fri, Aug 30, 2019 at 08:16:31PM +0200, Michael Niedermayer wrote: > On Wed, Aug 28, 2019 at 11:45:14PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/v210enc.c | 43 --- > > 1 file cha

Re: [FFmpeg-devel] [PATCH v1 5/5] avcodec/v210enc: define DEFINE_V210_ENCODE_FUNC to remove duplicate code

2019-08-31 Thread Limin Wang
On Fri, Aug 30, 2019 at 08:11:17PM +0200, Michael Niedermayer wrote: > On Wed, Aug 28, 2019 at 11:45:16PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/v210enc.c | 171 > > +-- >