[FFmpeg-devel] [PATCH v2 1/4] avutil/avstring: support input path is a null pointer or empty string

2019-09-16 Thread lance . lmwang
From: Limin Wang Reviewed-by: Tomas Härdin Reviewed-by: Liu Steven Signed-off-by: Limin Wang --- libavutil/avstring.c | 12 libavutil/avstring.h | 13 + 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/libavutil/avstring.c b/libavutil/avstring.c index 4

[FFmpeg-devel] [PATCH v4 3/3] avcodec/v210enc: move v210_enc_8/10 function to template file

2019-09-16 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/v210_template.c | 90 + libavcodec/v210enc.c | 135 +++-- 2 files changed, 114 insertions(+), 111 deletions(-) create mode 100644 libavcodec/v210_template.c diff --git a/li

[FFmpeg-devel] [PATCH v4 2/3] avcodec/v210enc: make 8bit and 10bit process consistent

2019-09-16 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/v210enc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/v210enc.c b/libavcodec/v210enc.c index 1b840b2c22..f545e43c6c 100644 --- a/libavcodec/v210enc.c +++ b/libavcodec/v210enc.c @@ -75

[FFmpeg-devel] [PATCH v4 1/3] avcodec/v210enc: add depth parameter for WRITE_PIXELS and CLIP

2019-09-16 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/v210enc.c | 83 +++- 1 file changed, 36 insertions(+), 47 deletions(-) diff --git a/libavcodec/v210enc.c b/libavcodec/v210enc.c index b024806d0b..1b840b2c22 100644 --- a/libavcodec/v210enc.c +++ b

Re: [FFmpeg-devel] [PATCH] Fix gif decoder max option

2019-09-16 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Tuesday, September 17, 2019 3:29 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] Fix gif decoder max option > > On 9/16/2019 10:24 PM, Soft Works wrote: > >> From: ffmpeg-devel On Behalf O

Re: [FFmpeg-devel] [PATCH v3 5/5] avcodec/v210enc: move the duplicate code to template file

2019-09-16 Thread Limin Wang
On Tue, Sep 17, 2019 at 01:16:36AM +0200, Michael Niedermayer wrote: > On Mon, Sep 16, 2019 at 07:17:52PM +0800, Limin Wang wrote: > > On Mon, Sep 16, 2019 at 12:21:36PM +0200, Michael Niedermayer wrote: > > > On Sun, Sep 01, 2019 at 09:20:23PM +0800, lance.lmw...@gmail.com wrote: > > > > From: Lim

[FFmpeg-devel] [PATCH v2] Fix printing integer option defaults

2019-09-16 Thread Soft Works
Integer values should not be printed using format specifier '%g' which leads to inexact display in case of higher values. Before this patch: -trans_color .D.V. color value [...] (default 1.67772e+07) Afterwards: -trans_color .D.V. color value [...] (defau

Re: [FFmpeg-devel] [PATCH v3 2/5] avcodec/v210enc: make 8bit and 10bit function consistent

2019-09-16 Thread Limin Wang
On Mon, Sep 16, 2019 at 09:06:06PM +0200, Michael Niedermayer wrote: > On Sun, Sep 01, 2019 at 09:20:20PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > I have benchmarked the performance with c code and haven't see any > > performance impact. > > > > Signed-off-by: Limin Wang

Re: [FFmpeg-devel] [PATCH] Fix gif decoder max option

2019-09-16 Thread James Almer
On 9/16/2019 10:24 PM, Soft Works wrote: >> From: ffmpeg-devel On Behalf Of >> James Almer >> Sent: Tuesday, September 17, 2019 3:11 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH] Fix gif decoder max option >> >> On 9/16/2019 10:05 PM, Soft Works wrote: >>> An int32 optio

[FFmpeg-devel] [PATCH v2] libavformat/webvttenc: Allow (but discard) additional streams

2019-09-16 Thread Soft Works
This allows mapping a video stream as reference stream for creating vtt segments when using the segment muxer. Example: ffmpeg -i INPUT -map 0:3 -c:0 webvtt -map 0:0 -c:v:0 copy -f segment -segment_format webvtt -segment_time 6 -write_empty_segments 1 -y "sub_segment3%d.vtt" The mpegts segment

Re: [FFmpeg-devel] [PATCH] Fix gif decoder max option

2019-09-16 Thread Soft Works
> From: ffmpeg-devel On Behalf Of > James Almer > Sent: Tuesday, September 17, 2019 3:11 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] Fix gif decoder max option > > On 9/16/2019 10:05 PM, Soft Works wrote: > > An int32 option cannot have a maximum of UINT32_MAX > > AV_O

Re: [FFmpeg-devel] [PATCH v2 1/4] avutil/avstring: support input path is a null pointer or empty string

2019-09-16 Thread Limin Wang
On Mon, Sep 16, 2019 at 09:30:15PM +0200, Michael Niedermayer wrote: > On Mon, Sep 16, 2019 at 07:25:13PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Reviewed-by: Tomas Härdin > > Reviewed-by: Liu Steven > > Signed-off-by: Limin Wang > > --- > > libavutil/avstring.c | 12

Re: [FFmpeg-devel] [PATCH] Fix printing integer option defaults

2019-09-16 Thread James Almer
On 9/16/2019 10:07 PM, Soft Works wrote: > Integer values should not be printed using format specifier '%g' which leads > to inexact display in case of higher values. > > Before this patch: > -trans_color .D.V. color value [...] (default > 1.67772e+07) > > Afterwards: > -t

Re: [FFmpeg-devel] [PATCH] Fix gif decoder max option

2019-09-16 Thread James Almer
On 9/16/2019 10:05 PM, Soft Works wrote: > An int32 option cannot have a maximum of UINT32_MAX AV_OPT_TYPE_INT options are int64_t. In this case however the storage type for trans_color in GifState is int. Reading the code i see it's intended to be uint32_t, so i think the correct fix is changing

[FFmpeg-devel] [PATCH] Print out numeric values of option constants

2019-09-16 Thread Soft Works
It's often not obvious how option constants relate to numerical values. Defaults are sometimes printed as numbers and from/to are always printed as numbers. Printing the numeric values of options constants avoids this confusion. It also allows to see which constants are equivalent. Before this pa

[FFmpeg-devel] [PATCH] Fix printing integer option defaults

2019-09-16 Thread Soft Works
Integer values should not be printed using format specifier '%g' which leads to inexact display in case of higher values. Before this patch: -trans_color .D.V. color value [...] (default 1.67772e+07) Afterwards: -trans_color .D.V. color value [...] (defau

[FFmpeg-devel] [PATCH] Fix gif decoder max option

2019-09-16 Thread Soft Works
An int32 option cannot have a maximum of UINT32_MAX Before this patch -trans_color .D.V. color value (ARGB) that is used instead of transparent color (from 0 to UINT32_MAX) Afterwards: -trans_color .D.V. color value (ARGB) that is used instead of transpar

[FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-16 Thread Hyun Yoo
I implemented a g.722.1 decoder by linking FreeSwitch's libg722_1 as external lib like libilbc, libspeex(ex. configure --enable-libg722_1) (https://github.com/traviscross/freeswitch/tree/master/libs/libg722_1) But I'm not sure about the license issue because g.722.1 is licensed by Polycom(royalty-

[FFmpeg-devel] [PATCH v2] Add option to log timing

2019-09-16 Thread Soft Works
This commit adds two logging flags: 'timing' and 'datetiming'. Usage: ffmpeg -loglevel +timing or ffmpeg -loglevel +datetiming --- fftools/cmdutils.c | 14 ++ libavutil/log.c| 37 - libavutil/log.h| 10 ++ 3 files changed, 56 inse

Re: [FFmpeg-devel] [PATCH v3 5/5] avcodec/v210enc: move the duplicate code to template file

2019-09-16 Thread Michael Niedermayer
On Mon, Sep 16, 2019 at 07:17:52PM +0800, Limin Wang wrote: > On Mon, Sep 16, 2019 at 12:21:36PM +0200, Michael Niedermayer wrote: > > On Sun, Sep 01, 2019 at 09:20:23PM +0800, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > > > Signed-off-by: Limin Wang > > > --- > > > libavcodec/

Re: [FFmpeg-devel] [PATCH v3 1/5] avcodec/v210enc: add depth parameter for WRITE_PIXELS and CLIP

2019-09-16 Thread Michael Niedermayer
On Mon, Sep 16, 2019 at 07:11:06PM +0800, Limin Wang wrote: > On Mon, Sep 16, 2019 at 12:05:45PM +0200, Michael Niedermayer wrote: > > On Thu, Sep 12, 2019 at 11:32:32PM +0800, Limin Wang wrote: > > > > > > ping for the patchset. > > > > output support for swscale would simplify testing > > > >

Re: [FFmpeg-devel] [PATCH v2 1/8] avformat/utils: Fix memleaks

2019-09-16 Thread Andreas Rheinhardt
Andreas Rheinhardt: > ff_read_packet had several potential memleaks: > 1. If av_packet_make_refcounted fails, it means that the packet is not > refcounted, but it could nevertheless carry side data and therefore > needs to be unreferenced. > 2. If a packet happens to have an illegal stream index (i

Re: [FFmpeg-devel] [PATCH] avcodec/ttaenc: Fix undefined shift

2019-09-16 Thread Michael Niedermayer
On Mon, Sep 16, 2019 at 10:16:36AM +0200, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety -- Benjamin

Re: [FFmpeg-devel] [PATCH v2 1/4] avutil/avstring: support input path is a null pointer or empty string

2019-09-16 Thread Michael Niedermayer
On Mon, Sep 16, 2019 at 07:25:13PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Reviewed-by: Tomas Härdin > Reviewed-by: Liu Steven > Signed-off-by: Limin Wang > --- > libavutil/avstring.c | 12 > libavutil/avstring.h | 13 + > 2 files changed, 17 inser

Re: [FFmpeg-devel] [PATCH v3 2/5] avcodec/v210enc: make 8bit and 10bit function consistent

2019-09-16 Thread Michael Niedermayer
On Sun, Sep 01, 2019 at 09:20:20PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > I have benchmarked the performance with c code and haven't see any > performance impact. > > Signed-off-by: Limin Wang > --- > libavcodec/v210enc.c | 7 +-- > 1 file changed, 1 insertion(+), 6 de

Re: [FFmpeg-devel] [PATCH]lavc/g729dec: Support decoding ACELP.KELVIN

2019-09-16 Thread Carl Eugen Hoyos
Am Fr., 23. Aug. 2019 um 09:14 Uhr schrieb Paul B Mahol : > > allcodecs.c entry is in wrong section, it should be audio one but yours is > in video section. > the avcodec.h entry may contradict with next libav entry so better move it > bellow hcom. Pushed with these changes. Thank you! Carl Euge

Re: [FFmpeg-devel] [PATCH] avcodec/allcodecs: make libdav1d the preferred AV1 decoder

2019-09-16 Thread James Almer
On 9/15/2019 11:31 AM, James Almer wrote: > It's considerably faster than libaom in most systems. > > Signed-off-by: James Almer > --- > libavcodec/allcodecs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c > index 5130fc

Re: [FFmpeg-devel] [PATCH] doc: fix various spelling mistakes

2019-09-16 Thread Gyan
On 16-09-2019 07:50 PM, Moritz Barsnick wrote: On Sun, Sep 15, 2019 at 09:59:49 +0530, Gyan wrote: On 15-09-2019 01:41 AM, Moritz Barsnick wrote: @item lp -Lowpass lines prior further proccessing. Default is disabled. +Lowpass lines prior further processing. Default is disabled. "Lowpass

[FFmpeg-devel] [PATCH 3/5] libavformat/mov: Improve demuxing DV audio

2019-09-16 Thread Andreas Rheinhardt
The code for demuxing DV audio predates the introduction of refcounted packets and when the latter was added, changes to the former were forgotten. This meant that when avpriv_dv_produce_packet initialized the packet containing the AVBufferRef, the AVBufferRef as well as the underlying AVBuffer lea

[FFmpeg-devel] [PATCH 2/5] avformat/mov: Fix memleak

2019-09-16 Thread Andreas Rheinhardt
When the mov/mp4 demuxer encounters an error during decrypting a packet, it returns the error, yet doesn't free the packet, so that the packet leaks. This has been fixed in this commit. Fixes the memleaks from ticket #8150. Signed-off-by: Andreas Rheinhardt --- This only fixes the memleaks from

[FFmpeg-devel] [PATCH 5/5] avformat/utils: Fix always true check

2019-09-16 Thread Andreas Rheinhardt
Found via PVS-Studio (ticket #8156). Signed-off-by: Andreas Rheinhardt --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index b83a740500..1cd7aa211c 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@

[FFmpeg-devel] [PATCH 4/5] fftools/ffmpeg_opt: Fix signed integer overflow

2019-09-16 Thread Andreas Rheinhardt
Fixes ticket #8154. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg_opt.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index f5ca18aa64..b2aa63e7ee 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -1,3 +

[FFmpeg-devel] [PATCH 1/5] avutil/encryption_info: Don't pass NULL to memcpy

2019-09-16 Thread Andreas Rheinhardt
The pointer arguments to memcpy (and several other functions of the C standard library) are not allowed to be NULL, not even when the number of bytes to copy is zero. An AVEncryptionInitInfo's data pointer is explicitly allowed to be NULL and yet av_encryption_init_info_add_side_data uncoditionally

[FFmpeg-devel] [PATCH] avcodecc/dnxhddec: fix ACT checking

2019-09-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/dnxhddec.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/libavcodec/dnxhddec.c b/libavcodec/dnxhddec.c index 1e95086696..512accadfd 100644 --- a/libavcodec/dnxhddec.c +++ b/libavcodec/dnxhddec.c @@ -499,19 +

Re: [FFmpeg-devel] [PATCH 4/5] lavc/vaapi_decode: add profile_parser and format map support for HEVC REXT

2019-09-16 Thread Carl Eugen Hoyos
Am Mo., 16. Sept. 2019 um 16:01 Uhr schrieb Fu, Linjie : > > > -Original Message- > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > Of Carl Eugen Hoyos > > Sent: Monday, September 16, 2019 18:14 > > To: FFmpeg development discussions and patches > de...@ffmpeg.o

Re: [FFmpeg-devel] [PATCH] doc: fix various spelling mistakes

2019-09-16 Thread Moritz Barsnick
On Sun, Sep 15, 2019 at 09:59:49 +0530, Gyan wrote: > On 15-09-2019 01:41 AM, Moritz Barsnick wrote: > > @item lp > > -Lowpass lines prior further proccessing. Default is disabled. > > +Lowpass lines prior further processing. Default is disabled. > > "Lowpass lines prior to further ..." I only m

Re: [FFmpeg-devel] [PATCH 4/5] lavc/vaapi_decode: add profile_parser and format map support for HEVC REXT

2019-09-16 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: Monday, September 16, 2019 18:14 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 4/5] lavc/vaapi_decode: add >

Re: [FFmpeg-devel] [PATCH 2/5] lavc/hevc_ps: parse constraint flags for HEVC REXT

2019-09-16 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: Monday, September 16, 2019 18:06 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/5] lavc/hevc_ps: parse const

Re: [FFmpeg-devel] [PATCH v2 2/4] avformat/hlsenc: remove the unnecessary null pointer check

2019-09-16 Thread Steven Liu
> 在 2019年9月16日,20:06,Liu Steven 写道: > > > >> 在 2019年9月16日,下午7:25,lance.lmw...@gmail.com 写道: >> >> From: Limin Wang >> >> Reviewed-by: Liu Steven >> Signed-off-by: Limin Wang >> --- >> libavformat/hlsenc.c | 26 ++ >> 1 file changed, 2 insertions(+), 24 deletions(-)

Re: [FFmpeg-devel] [PATCH v2 2/4] avformat/hlsenc: remove the unnecessary null pointer check

2019-09-16 Thread Liu Steven
> 在 2019年9月16日,下午7:25,lance.lmw...@gmail.com 写道: > > From: Limin Wang > > Reviewed-by: Liu Steven > Signed-off-by: Limin Wang > --- > libavformat/hlsenc.c | 26 ++ > 1 file changed, 2 insertions(+), 24 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/h

Re: [FFmpeg-devel] [PATCH v2 4/4] avformat/hlsenc: replace with av_freep for all av_free

2019-09-16 Thread Liu Steven
> 在 2019年9月16日,下午7:25,lance.lmw...@gmail.com 写道: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/hlsenc.c | 64 ++-- > 1 file changed, 32 insertions(+), 32 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c

Re: [FFmpeg-devel] [PATCH 2/3] tools/target_dec_fuzzer: Adjust threshold for binkvideo

2019-09-16 Thread Peter Ross
On Sat, Sep 14, 2019 at 11:39:49PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (89sec -> 7sec) > Fixes: > 17035/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK_fuzzer-5737222422134784 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects

Re: [FFmpeg-devel] [PATCH v4 1/2] libavuitl: add A2R10G10B10 & A2B10G10R10

2019-09-16 Thread Carl Eugen Hoyos
Am Mi., 11. Sept. 2019 um 07:40 Uhr schrieb Zachary Zhou : > +AV_PIX_FMT_A2R10G10B10, ///< 10-bit Pixel RGB formats. > +AV_PIX_FMT_A2B10G10R10, ///< 10-bit Pixel BGR formats. Without more explanation, this patch is not ok imo. Carl Eugen ___ ff

Re: [FFmpeg-devel] [PATCH v4 2/2] avfilter: Add tonemap vaapi filter

2019-09-16 Thread Carl Eugen Hoyos
Am Mi., 11. Sept. 2019 um 23:02 Uhr schrieb Carl Eugen Hoyos : > > Am Mi., 11. Sept. 2019 um 07:41 Uhr schrieb Zachary Zhou > : > > > > It supports ICL platform. > > H2H (HDR to HDR): P010 -> A2R10G10B10 > > H2S (HDR to SDR): P010 -> ARGB > > > +if (ctx->hdr_type == HDR_VAAPI_H2H) { > > +

Re: [FFmpeg-devel] [PATCH NV HEADERS] Add cuCtxGetDevice

2019-09-16 Thread Steve Lhomme
On 2019-09-13 11:56, Timo Rothenpieler wrote: On 12/09/2019 15:19, Steve Lhomme wrote: It can be useful to determine if the decoder context is the same as the display context. It's used in some samples at https://github.com/NVIDIA/video-sdk-samples ---   include/ffnvcodec/dynlink_cuda.h   | 1

[FFmpeg-devel] [PATCH v2 3/4] avformat/hlsenc: replace with av_dirname to get the directory

2019-09-16 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index d663785e4a..753addcbde 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @

[FFmpeg-devel] [PATCH v2 4/4] avformat/hlsenc: replace with av_freep for all av_free

2019-09-16 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 64 ++-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 753addcbde..784a2b5ec0 100644 --- a/libavformat/hlsenc.c +++ b

[FFmpeg-devel] [PATCH v2 2/4] avformat/hlsenc: remove the unnecessary null pointer check

2019-09-16 Thread lance . lmwang
From: Limin Wang Reviewed-by: Liu Steven Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 26 ++ 1 file changed, 2 insertions(+), 24 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 1f2bdfbe4d..d663785e4a 100644 --- a/libavformat/hlsenc.c

[FFmpeg-devel] [PATCH v2 1/4] avutil/avstring: support input path is a null pointer or empty string

2019-09-16 Thread lance . lmwang
From: Limin Wang Reviewed-by: Tomas Härdin Reviewed-by: Liu Steven Signed-off-by: Limin Wang --- libavutil/avstring.c | 12 libavutil/avstring.h | 13 + 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/libavutil/avstring.c b/libavutil/avstring.c index 4

Re: [FFmpeg-devel] [PATCH v3 1/5] avcodec/v210enc: add depth parameter for WRITE_PIXELS and CLIP

2019-09-16 Thread Limin Wang
On Mon, Sep 16, 2019 at 12:05:45PM +0200, Michael Niedermayer wrote: > On Thu, Sep 12, 2019 at 11:32:32PM +0800, Limin Wang wrote: > > > > ping for the patchset. > > output support for swscale would simplify testing > > ./ffplay matrixbench_mpeg2.mpg -vf format=y210 > ... > Impossible to convert

Re: [FFmpeg-devel] [PATCH v3 5/5] avcodec/v210enc: move the duplicate code to template file

2019-09-16 Thread Limin Wang
On Mon, Sep 16, 2019 at 12:21:36PM +0200, Michael Niedermayer wrote: > On Sun, Sep 01, 2019 at 09:20:23PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/v210_template.c | 59 +- > > libavcodec/v210enc.c

Re: [FFmpeg-devel] [PATCH V3 1/2] avformat/dashdec: fix pointer being freed was not allocated

2019-09-16 Thread Liu Steven
> 在 2019年9月16日,下午6:44,vectronic 写道: > > prevent attempt to call xmlFree if val was not allocated > > fixes: 8135 > Signed-off-by: vectronic > --- > libavformat/dashdec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > index 8c0a9b0102..

[FFmpeg-devel] [PATCH V3 2/2] avformat/dashdec: fix segfault when parsing segmentlist

2019-09-16 Thread vectronic
index into segmentlists_tab was specified as 4 instead of 3 causing invalid access further fix to: 8135 Signed-off-by: vectronic --- libavformat/dashdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 738bfeaefb..7713ee8

[FFmpeg-devel] [PATCH V3 1/2] avformat/dashdec: fix pointer being freed was not allocated

2019-09-16 Thread vectronic
prevent attempt to call xmlFree if val was not allocated fixes: 8135 Signed-off-by: vectronic --- libavformat/dashdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 8c0a9b0102..738bfeaefb 100644 --- a/libavformat/dashdec.c +++ b/libavfor

Re: [FFmpeg-devel] [PATCH v3 5/5] avcodec/v210enc: move the duplicate code to template file

2019-09-16 Thread Michael Niedermayer
On Sun, Sep 01, 2019 at 09:20:23PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/v210_template.c | 59 +- > libavcodec/v210enc.c | 123 > +++-- > 2 files changed, 75 in

Re: [FFmpeg-devel] [PATCH 4/5] lavc/vaapi_decode: add profile_parser and format map support for HEVC REXT

2019-09-16 Thread Carl Eugen Hoyos
Am Mo., 16. Sept. 2019 um 09:36 Uhr schrieb Linjie Fu : > > Add function pointer field in vaapi_profile_map[], set profile_parser > for HEVC_REXT to find the exact va_profile. > > Also add format map support. Please remove all cosmetic changes from this patch. Carl Eugen _

Re: [FFmpeg-devel] [PATCH 2/5] lavc/hevc_ps: parse constraint flags for HEVC REXT

2019-09-16 Thread Carl Eugen Hoyos
Am Mo., 16. Sept. 2019 um 09:35 Uhr schrieb Linjie Fu : > > Parse all the constraint flags according to ITU-T Rec. H.265 (02/2018). > It can be passed to hw decoders to determine the exact profile for > Range Extension HEVC. I am not a native speaker but I believe this should be more like: They a

Re: [FFmpeg-devel] [PATCH v3 1/5] avcodec/v210enc: add depth parameter for WRITE_PIXELS and CLIP

2019-09-16 Thread Michael Niedermayer
On Thu, Sep 12, 2019 at 11:32:32PM +0800, Limin Wang wrote: > > ping for the patchset. output support for swscale would simplify testing ./ffplay matrixbench_mpeg2.mpg -vf format=y210 ... Impossible to convert between the formats supported by the filter 'ffplay_buffer' and the filter 'auto_scal

Re: [FFmpeg-devel] [PATCH v1 1/4] avutil/avstring: support input path is a null pointer or empty string

2019-09-16 Thread Liu Steven
> 在 2019年9月16日,下午4:19,Tomas Härdin 写道: > > mån 2019-09-16 klockan 09:03 +0800 skrev lance.lmw...@gmail.com: >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> libavutil/avstring.c | 12 >> libavutil/avstring.h | 13 + >> 2 files changed, 17 insertions(+), 8

Re: [FFmpeg-devel] [PATCH] avcodec/ttaenc: Fix undefined shift

2019-09-16 Thread Paul B Mahol
LGTM On 9/15/19, Andreas Rheinhardt wrote: > ttaenc contained (1 << unary) - 1 as an argument for a function > expecting an unsigned int. unary can be as big as 31 in this case. > The type of the shift and the whole expression is int, because 1 fits > into an integer, so that the behaviour is und

Re: [FFmpeg-devel] [PATCH v1 1/4] avutil/avstring: support input path is a null pointer or empty string

2019-09-16 Thread Tomas Härdin
mån 2019-09-16 klockan 09:03 +0800 skrev lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavutil/avstring.c | 12 > libavutil/avstring.h | 13 + > 2 files changed, 17 insertions(+), 8 deletions(-) > > diff --git a/libavutil/avstring.c

[FFmpeg-devel] [PATCH 5/5] lavc/hevcdec: add VAAPI decode support for HEVC Rext

2019-09-16 Thread Linjie Fu
Add decode support for 422/444, 8/10bit HEVC REXT clips. Signed-off-by: Linjie Fu --- libavcodec/hevcdec.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index eed0319..f1ff177 100644 --- a/libavcodec/hevcdec.c +

[FFmpeg-devel] [PATCH 4/5] lavc/vaapi_decode: add profile_parser and format map support for HEVC REXT

2019-09-16 Thread Linjie Fu
Add function pointer field in vaapi_profile_map[], set profile_parser for HEVC_REXT to find the exact va_profile. Also add format map support. Signed-off-by: Linjie Fu --- libavcodec/vaapi_decode.c | 83 ++- 1 file changed, 53 insertions(+), 30 deleti

[FFmpeg-devel] [PATCH 3/5] lavc/vaapi_hevc: add function to find exact va_profile for REXT

2019-09-16 Thread Linjie Fu
Add vaapi_parse_rext_profile and use profile constraint flags to determine the exact va_profile for HEVC_REXT. Add build object in Makefile for h265_profile_level dependency. Signed-off-by: Linjie Fu --- libavcodec/Makefile | 2 +- libavcodec/vaapi_hevc.c | 69 +

[FFmpeg-devel] [PATCH 2/5] lavc/hevc_ps: parse constraint flags for HEVC REXT

2019-09-16 Thread Linjie Fu
Parse all the constraint flags according to ITU-T Rec. H.265 (02/2018). It can be passed to hw decoders to determine the exact profile for Range Extension HEVC. Signed-off-by: Linjie Fu --- libavcodec/hevc_ps.c | 44 libavcodec/hevc_ps.h | 13 +++

[FFmpeg-devel] [PATCH 1/5] lavc/vaapi_hevc: extend parameter buffer to ParameterBufferHEVCExtension

2019-09-16 Thread Linjie Fu
Extend ParameterBufferHEVC to ParameterBufferHEVCExtension for both VAPicture and VASlice. Pass Range Extension flags to support the decode for HEVC REXT. Separate the behaviour of ff_vaapi_decode_make_slice_buffer for base and rext to avoid potential regression. Signed-off-by: Linjie Fu --- l

[FFmpeg-devel] [PATCH 2/3] swscale: Add swscale and fate support for AYUV

2019-09-16 Thread Linjie Fu
Add input and output support in swscale for AYUV. Add fate test for AYUV. Signed-off-by: Linjie Fu --- libavutil/tests/pixfmt_best.c| 1 + libswscale/input.c | 26 + libswscale/output.c | 50

[FFmpeg-devel] [PATCH 3/3] swscale: Add swscale input support for Y210

2019-09-16 Thread Linjie Fu
Add swscale input support for Y210, output support and fate test could be added later if there is requirement for software CSC to this packed format. Signed-off-by: Linjie Fu --- libswscale/input.c | 36 libswscale/utils.c | 2 ++ 2 files changed, 38 inserti

[FFmpeg-devel] [PATCH 1/3] lavu/pixfmt: add new pixel format ayuv/y210/y410

2019-09-16 Thread Linjie Fu
Previously, media driver provided planar format(like 420 8 bit), but for HEVC Range Extension (422/444 8/10 bit), the decoded image is produced in packed format because Windows expects it. Add some packed pixel formats for hardware decode support in VAAPI and QSV: 4:2:2 10 bit: Y210 4:4:4 8 bit:

Re: [FFmpeg-devel] [PATCH, v2 1/6] lavu/pixfmt: add new pixel format ayuv/y210/y410

2019-09-16 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: Saturday, September 14, 2019 00:31 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, v2 1/6] lavu/pixfmt: add ne