Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: replace with av_freep for all av_free

2019-10-07 Thread Steven Liu
> 在 2019年9月16日,09:03,lance.lmw...@gmail.com 写道: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/hlsenc.c | 64 ++-- > 1 file changed, 32 insertions(+), 32 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c >

Re: [FFmpeg-devel] [PATCH v1] avformat/tee.c: steal bsf option before passing to fifo muxer

2019-10-07 Thread Steven Liu
> 在 2019年10月8日,05:54,Dennis Mungai 写道: > > On Mon, 7 Oct 2019 at 08:26, Liu Steven wrote: >> >> >> >>> 在 2019年10月6日,上午11:37,Jun Li 写道: >>> >>> Fix #7620 >>> In the case tee muxer with both "bsf" and "use_fifo" parameters >>> wil trigger this bug. Tee muxer will first steal parameters (lik

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_freezedetect: add discard option to force drop freezen frame

2019-10-07 Thread Gyan
On 08-10-2019 10:58 AM, Limin Wang wrote: On Tue, Oct 08, 2019 at 10:02:25AM +0530, Gyan wrote: On 08-10-2019 09:24 AM, lance.lmw...@gmail.com wrote: From: Limin Wang How to tested it, please try with the following command: ./ffmpeg -f lavfi -i "smptebars=duration=5:size=1280x720:rate=30

Re: [FFmpeg-devel] [PATCH] Change libvpxenc default to crf=32.

2019-10-07 Thread James Zern
On Sat, Oct 5, 2019 at 1:23 PM James Zern wrote: > > On Tue, Sep 24, 2019 at 4:31 PM Elliott Karpilovsky > wrote: > > > > Current default is 200kbps, which produces inconsistent > > results (too high for low-res, too low for hi-res). Use > > CRF instead, which will adapt. Affects VP9. Also have >

[FFmpeg-devel] [PATCH 2/4] avformat/mpeg: Remove secondary packet for reading VobSub

2019-10-07 Thread Andreas Rheinhardt
When vobsub_read_packet() reads a packet, it uses a dedicated AVPacket to get the subtitle timing and position from an FFDemuxSubtitlesQueue (which has been filled with this data during reading the idx file in vobsub_read_header); afterwards the actual subtitle data is read into the packet destined

[FFmpeg-devel] [PATCH 4/4] avformat/flacdec: Remove useless packet

2019-10-07 Thread Andreas Rheinhardt
flac_read_timestamp() applied av_init_packet() to a packet (which initializes all fields of the packet except for data and size) and then went on to use only the data and size fields. In other words: Said packet can be removed and replaced by an uint8_t * and an int. Signed-off-by: Andreas Rheinha

[FFmpeg-devel] [PATCH 3/4] avformat/utils: Remove redundant save+restore

2019-10-07 Thread Andreas Rheinhardt
If the size of the input packet is zero, av_grow_packet() used to call av_new_packet() which would initialize the packet and (in particular) reset the pos field. This behaviour (which was never documented and arguably always contradicted the documented behaviour) was changed in 2fe04630. This means

[FFmpeg-devel] [PATCH 1/4] avformat/mpeg: Remove set-but-unused variable

2019-10-07 Thread Andreas Rheinhardt
Forgotten in 7da57875. Signed-off-by: Andreas Rheinhardt --- libavformat/mpeg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c index 6f132aae05..bd182e4429 100644 --- a/libavformat/mpeg.c +++ b/libavformat/mpeg.c @@ -489,7 +489,6 @@

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_freezedetect: add discard option to force drop freezen frame

2019-10-07 Thread Limin Wang
On Tue, Oct 08, 2019 at 10:02:25AM +0530, Gyan wrote: > > > On 08-10-2019 09:24 AM, lance.lmw...@gmail.com wrote: > >From: Limin Wang > > > >How to tested it, please try with the following command: > >./ffmpeg -f lavfi -i > >"smptebars=duration=5:size=1280x720:rate=30,freezedetect=d=1:discard=

[FFmpeg-devel] [PATCH] lavc/qsv: remove vaapi device free function

2019-10-07 Thread Zhong Li
It is not needed since av_buffer_unref() will call it internally Signed-off-by: Zhong Li --- libavcodec/qsv.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c index a43f0d5..81fa4a8 100644 --- a/libavcodec/qsv.c +++ b/libavcodec/qsv.c @@ -835,10 +835,6 @

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_freezedetect: add discard option to force drop freezen frame

2019-10-07 Thread Gyan
On 08-10-2019 09:24 AM, lance.lmw...@gmail.com wrote: From: Limin Wang How to tested it, please try with the following command: ./ffmpeg -f lavfi -i "smptebars=duration=5:size=1280x720:rate=30,freezedetect=d=1:discard=0" -f null - frame= 150 fps=0.0 q=-0.0 Lsize=N/A time=00:00:05.00 bitr

[FFmpeg-devel] [PATCH v2] avfilter/vf_freezedetect: add discard option to force drop freezen frame

2019-10-07 Thread lance . lmwang
From: Limin Wang How to tested it, please try with the following command: ./ffmpeg -f lavfi -i "smptebars=duration=5:size=1280x720:rate=30,freezedetect=d=1:discard=0" -f null - frame= 150 fps=0.0 q=-0.0 Lsize=N/A time=00:00:05.00 bitrate=N/A speed= 234x ./ffmpeg -f lavfi -i "smptebars=dur

[FFmpeg-devel] [PATCH v3] avfilter/vf_delogo: make the interp value compute method simple

2019-10-07 Thread Steven Liu
because the interp >= 0UL comparison of an unsigned value is always true fix CID: 1454642 Signed-off-by: Steven Liu --- libavfilter/vf_delogo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c index 376c5e850f..a268b3e9b3 10064

[FFmpeg-devel] [PATCH v2] avcodec/h264_parse: decode sps before pps

2019-10-07 Thread Jun Li
Fix ticket #6422 The content put pps before sps, which is not a common case. The change put decoding sps before pps, just for compability. Signed-off-by: Jun Li --- libavcodec/h264_parse.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/libavcodec/h264_pa

Re: [FFmpeg-devel] [PATCH v1] avcodec/h264_parse: decode sps before pps

2019-10-07 Thread Jun Li
On Mon, Oct 7, 2019 at 7:50 PM Fu, Linjie wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of Jun > > Li > > Sent: Tuesday, October 8, 2019 05:42 > > To: ffmpeg-devel@ffmpeg.org > > Subject: [FFmpeg-devel] [PATCH v1] avcodec/h264_parse: decode sps > > before pps > > > > Fix

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_delogo: make the interp value compute method simple

2019-10-07 Thread Limin Wang
On Tue, Oct 08, 2019 at 10:47:56AM +0800, myp...@gmail.com wrote: > On Mon, Oct 7, 2019 at 11:14 PM Limin Wang wrote: > > > > On Mon, Oct 07, 2019 at 01:12:46PM +0800, Steven Liu wrote: > > > because the interp >= 0UL comparison of an unsigned value is always true > > > fix CID: 1454642 > > > > >

Re: [FFmpeg-devel] [PATCH v1] avcodec/h264_parse: decode sps before pps

2019-10-07 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of Jun > Li > Sent: Tuesday, October 8, 2019 05:42 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v1] avcodec/h264_parse: decode sps > before pps > > Fix ticket #6422 > The content put pps before sps, which is not a commo

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_delogo: make the interp value compute method simple

2019-10-07 Thread myp...@gmail.com
On Mon, Oct 7, 2019 at 11:14 PM Limin Wang wrote: > > On Mon, Oct 07, 2019 at 01:12:46PM +0800, Steven Liu wrote: > > because the interp >= 0UL comparison of an unsigned value is always true > > fix CID: 1454642 > > > > Signed-off-by: Steven Liu > > --- > > libavfilter/vf_delogo.c | 2 +- > > 1

Re: [FFmpeg-devel] [PATCH V1 1/2] avutil/common: Fix underflow for ROUNDED_DIV with unsigned integer

2019-10-07 Thread myp...@gmail.com
On Sat, Oct 5, 2019 at 10:16 PM Michael Niedermayer wrote: > > On Thu, Oct 03, 2019 at 09:53:15AM +0800, Jun Zhao wrote: > > From: Mengye Lv > > > > When used ROUNDED_DIV(a,b), if a is unsigned integer zero, it's > > will lead to an underflow issue(it called unsigned integer > > wrapping). > > >

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: split empty text sample when duration overflow

2019-10-07 Thread Jun Li
On Mon, Oct 7, 2019 at 6:34 PM Jun Li wrote: > Fix #7637 > One empty/end sample is created and inserted between two caption lines > when there is a gap. > This patch is to split the sample into multiple ones when its duration is > too long (>= INT_MAX) > > Signed-off-by: Jun Li > --- > libavfor

[FFmpeg-devel] [PATCH v4] avformat/movenc: split empty text sample when duration overflow

2019-10-07 Thread Jun Li
Fix #7637 One empty/end sample is created and inserted between two caption lines when there is a gap. This patch is to split the sample into multiple ones when its duration is too long (>= INT_MAX) Signed-off-by: Jun Li --- libavformat/movenc.c | 26 ++-

Re: [FFmpeg-devel] [PATCH V1 2/3] lavc/options_table: Correct the flags for AVCodecContext.flags2

2019-10-07 Thread myp...@gmail.com
On Sat, Oct 5, 2019 at 9:44 PM Michael Niedermayer wrote: > > On Fri, Oct 04, 2019 at 09:36:54PM +0800, Jun Zhao wrote: > > From: Jun Zhao > > > > Correct the flags for AVCodecContext.flags2. > > > > Signed-off-by: Jun Zhao > > --- > > libavcodec/options_table.h |4 ++-- > > 1 files changed

Re: [FFmpeg-devel] [PATCH V1 1/3] avcodec/decode: fix identation

2019-10-07 Thread myp...@gmail.com
On Fri, Oct 4, 2019 at 10:23 PM Gyan wrote: > > > > On 04-10-2019 07:06 PM, Jun Zhao wrote: > > From: Jun Zhao > > > > fix identation. > > indentation > > > > > Signed-off-by: Jun Zhao > > --- > > libavcodec/decode.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff

Re: [FFmpeg-devel] [PATCH V1 2/2] lavfi/hqdn3d: add slice thread optionmation

2019-10-07 Thread myp...@gmail.com
On Sun, Oct 6, 2019 at 2:09 AM Moritz Barsnick wrote: > > On Thu, Oct 03, 2019 at 09:53:16 +0800, Jun Zhao wrote: > > From: Jun Zhao > > Subject: [PATCH V1 2/2] lavfi/hqdn3d: add slice thread optionmation > > Nit: big typo in the first line of your commit message. > > Moritz Will fix the typo, th

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter/vf_scenechangedetect: add filter to detect scene change

2019-10-07 Thread Limin Wang
On Mon, Oct 07, 2019 at 09:00:10PM +0200, Paul B Mahol wrote: > Too long filter name. Yes, the name is too long, how about to use scdetect? If it's OK, I'll update the patch. > > On 10/7/19, Limin Wang wrote: > > > > ping, please give comments. > > > > On Sun, Sep 29, 2019 at 09:25:12PM +0800,

Re: [FFmpeg-devel] [PATCH v1] avformat/tee.c: steal bsf option before passing to fifo muxer

2019-10-07 Thread Dennis Mungai
On Mon, 7 Oct 2019 at 08:26, Liu Steven wrote: > > > > > 在 2019年10月6日,上午11:37,Jun Li 写道: > > > > Fix #7620 > > In the case tee muxer with both "bsf" and "use_fifo" parameters > > wil trigger this bug. Tee muxer will first steal parameters (like "f", > > "select"...) and then "use_fifo" will try r

[FFmpeg-devel] [PATCH v1] avcodec/h264_parse: decode sps before pps

2019-10-07 Thread Jun Li
Fix ticket #6422 The content put pps before sps, which is not a common case. The change just put decoding sps before pps, just for compability. Signed-off-by: Jun Li --- libavcodec/h264_parse.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/libavcodec

[FFmpeg-devel] [PATCH v1] avcodec/h264_parse: decode sps before pps Fix ticket #6422 The content put pps before sps, which is not a common case. The change just put decoding sps before pps, just for c

2019-10-07 Thread Jun Li
Signed-off-by: Jun Li --- libavcodec/h264_parse.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/libavcodec/h264_parse.c b/libavcodec/h264_parse.c index 352ffea948..26aaa751ad 100644 --- a/libavcodec/h264_parse.c +++ b/libavcodec/h264_parse.c @@ -373,3

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: parse sdtp atom and set the pkt disposable flag accordingly

2019-10-07 Thread Derek Buitenhuis
On 07/10/2019 16:06, Matthieu Bouron wrote: > Ping. > No objections from me. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...

Re: [FFmpeg-devel] [PATCH] avformat/ivfenc: Change the length fields to 32 bits

2019-10-07 Thread Vittorio Giovara
this seems good to me, unless objections i'll merge it in 24h On Mon, Oct 7, 2019 at 11:10 AM Raphaël Zumer wrote: > Just sending a reminder for my set of patches (the set of v2 patches up > in the thread and this one). Are there any further comments? > > Thanks > Raphaël Zumer > > On Wed, 2019-

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_delogo: make the interp value compute method simple

2019-10-07 Thread Michael Niedermayer
On Mon, Oct 07, 2019 at 01:12:46PM +0800, Steven Liu wrote: > because the interp >= 0UL comparison of an unsigned value is always true > fix CID: 1454642 > > Signed-off-by: Steven Liu > --- > libavfilter/vf_delogo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) this changes fate-filte

Re: [FFmpeg-devel] [PATCH] avcodec/filter: Remove extra '; ' outside of functions

2019-10-07 Thread Paul B Mahol
applied On 10/7/19, Paul B Mahol wrote: > ok > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter/vf_scenechangedetect: add filter to detect scene change

2019-10-07 Thread Paul B Mahol
Too long filter name. On 10/7/19, Limin Wang wrote: > > ping, please give comments. > > On Sun, Sep 29, 2019 at 09:25:12PM +0800, lance.lmw...@gmail.com wrote: >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> Please provide a comment to add a new filter for scene change detection t

Re: [FFmpeg-devel] [PATCH v1] doc/developer: make clear for the patch processing time

2019-10-07 Thread Andriy Gelman
On Tue, 08. Oct 00:07, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/developer.texi | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/doc/developer.texi b/doc/developer.texi > index 5c342c9..698a814 100644 > --- a/doc/

[FFmpeg-devel] [PATCH 4/6] avcodec/hcom: Check the root entry and the right entries

2019-10-07 Thread Michael Niedermayer
Fixes: Segfault Fixes: 17991/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HCOM_fuzzer-5647235349479424 Also fixes related memleak Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hcom.c |

[FFmpeg-devel] [PATCH 2/6] tools/target_dec_fuzzer: Adjust threshold for CFHD

2019-10-07 Thread Michael Niedermayer
Fixes: Timeout (18sec -> 5sec) Fixes: 17977/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CFHD_fuzzer-5186112762413056 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 +

Re: [FFmpeg-devel] [PATCH] avcodec/zmbv: Simplify assigning decode_intra function pointer

2019-10-07 Thread Andreas Rheinhardt
Tomas Härdin: > mån 2019-10-07 klockan 02:57 +0200 skrev Andreas Rheinhardt: >> zmbv has only one function for decoding intra frames, namely >> decode_intra. This can be used to simplify the process of choosing the >> right function pointer. >> >> This also removes spec-incompliant conversions betw

[FFmpeg-devel] [PATCH 5/6] avcodec/interplayacm: Fix integer overflows in juggle()

2019-10-07 Thread Michael Niedermayer
Fixes: signed integer overflow: -760459023 + -1520918047 cannot be represented in type 'int' Fixes: 17994/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_INTERPLAY_ACM_fuzzer-5647123042795520 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg S

[FFmpeg-devel] [PATCH 1/6] tools/target_dec_fuzzer: Adjust ffwavesynth threshold

2019-10-07 Thread Michael Niedermayer
ffwavesynth can produce large amounts of data relatively slowly on very small input Fixes: Timeout (60sec -> 9sec) Fixes: 17970/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5689121279836160 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/mas

[FFmpeg-devel] [PATCH 6/6] avcodec/truespeech: Fix integer overflow in truespeech_synth()

2019-10-07 Thread Michael Niedermayer
Fixes: signed integer overflow: -1801695444 + -830224908 cannot be represented in type 'int' Fixes: 17995/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUESPEECH_fuzzer-5648084880588800 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Sign

[FFmpeg-devel] [PATCH 3/6] avcodec/qdrw: Check input for header/skiped space before get_buffer()

2019-10-07 Thread Michael Niedermayer
Fixes: Timeout (21sec -> 0.8sec) Fixes: 17990/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QDRAW_fuzzer-5200374436200448 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/qdrw.c | 2 ++ 1 f

[FFmpeg-devel] [PATCH v1] doc/developer: make clear for the patch processing time

2019-10-07 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/developer.texi | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/doc/developer.texi b/doc/developer.texi index 5c342c9..698a814 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -497,8 +497,12 @@ incorporates

Re: [FFmpeg-devel] [PATCH v1 1/6] avfilter/af_silencedetect: change parameters order for av_malllocz_array

2019-10-07 Thread Limin Wang
On Mon, Oct 07, 2019 at 05:40:50PM +0200, Moritz Barsnick wrote: > On Mon, Oct 07, 2019 at 22:28:01 +0800, Limin Wang wrote: > > It's minor change, please corrent me if I'm misunderstanding. by > > description of the av_malloc_array parameters: > > * @param nmemb Number of element > > * @param

Re: [FFmpeg-devel] [PATCH v1 1/6] avfilter/af_silencedetect: change parameters order for av_malllocz_array

2019-10-07 Thread Moritz Barsnick
On Mon, Oct 07, 2019 at 22:28:01 +0800, Limin Wang wrote: > It's minor change, please corrent me if I'm misunderstanding. by description > of the av_malloc_array parameters: > * @param nmemb Number of element > * @param size Size of a single element I agree that it's more true to the documen

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_delogo: make the interp value compute method simple

2019-10-07 Thread Limin Wang
On Mon, Oct 07, 2019 at 01:12:46PM +0800, Steven Liu wrote: > because the interp >= 0UL comparison of an unsigned value is always true > fix CID: 1454642 > > Signed-off-by: Steven Liu > --- > libavfilter/vf_delogo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavf

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: parse sdtp atom and set the pkt disposable flag accordingly

2019-10-07 Thread Matthieu Bouron
On Fri, Sep 27, 2019 at 04:37:31PM +0200, Matthieu Bouron wrote: > Allows the creation of the sdtp atom while remuxing MP4 to MP4. This > atom is required by Apple devices (iPhone, Apple TV) in order to accept > 2160p medias. > --- > libavformat/isom.h | 2 ++ > libavformat/mov.c | 41 ++

Re: [FFmpeg-devel] [PATCH v4 1/4] avutil/avstring: support input path as a null pointer or empty string

2019-10-07 Thread Limin Wang
ping the patchset, haven't merge yet. On Tue, Sep 24, 2019 at 07:23:58PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Linux and OSX systems support basename and dirname via , I plan to > make the wrapper interface conform to the standard interface first. > If it is feasible, I wi

Re: [FFmpeg-devel] [PATCH] avformat/ivfenc: Change the length fields to 32 bits

2019-10-07 Thread Raphaël Zumer
Just sending a reminder for my set of patches (the set of v2 patches up in the thread and this one). Are there any further comments? Thanks Raphaël Zumer On Wed, 2019-10-02 at 09:04 -0400, Raphaël Zumer wrote: > There is no change in the encoded bitstream, but this > ensures that the written fiel

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter/vf_scenechangedetect: add filter to detect scene change

2019-10-07 Thread Limin Wang
ping, please give comments. On Sun, Sep 29, 2019 at 09:25:12PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > Please provide a comment to add a new filter for scene change detection to > avoid > multiple calculations of mafd in the filter chain.

Re: [FFmpeg-devel] [PATCH] avcodec/zmbv: Simplify assigning decode_intra function pointer

2019-10-07 Thread Tomas Härdin
mån 2019-10-07 klockan 02:57 +0200 skrev Andreas Rheinhardt: > zmbv has only one function for decoding intra frames, namely > decode_intra. This can be used to simplify the process of choosing the > right function pointer. > > This also removes spec-incompliant conversions between function pointer

Re: [FFmpeg-devel] [PATCH v1 2/6] avfilter/af_silencedetect: document metadata

2019-10-07 Thread Limin Wang
On Tue, Oct 01, 2019 at 09:40:45AM +0200, Moritz Barsnick wrote: > On Mon, Sep 30, 2019 at 21:36:43 +0800, lance.lmw...@gmail.com wrote: > > -The printed times and duration are expressed in seconds. > > +The printed times and duration are expressed in seconds. The > > @code{lavfi.silence_start} >

Re: [FFmpeg-devel] [PATCH v1 1/6] avfilter/af_silencedetect: change parameters order for av_malllocz_array

2019-10-07 Thread Limin Wang
On Tue, Oct 01, 2019 at 01:23:04PM +0200, Carl Eugen Hoyos wrote: > Am Mo., 30. Sept. 2019 um 15:37 Uhr schrieb : > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/af_silencedetect.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_freezedetect: add force_discard option to force discard freeze/non-freeze frame

2019-10-07 Thread Limin Wang
On Tue, Oct 01, 2019 at 09:34:48PM +0200, Marton Balint wrote: > > > On Mon, 30 Sep 2019, lance.lmw...@gmail.com wrote: > > >From: Limin Wang > > > >How to tested it, please try with the following command: > >./ffmpeg -f lavfi -i > >"smptebars=duration=5:size=1280x720:rate=30,freezedetect=d=1

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_freezedetect: add force_discard option to force discard freeze/non-freeze frame

2019-10-07 Thread Limin Wang
On Tue, Oct 01, 2019 at 09:47:19AM +0200, Moritz Barsnick wrote: > On Mon, Sep 30, 2019 at 23:22:18 +0800, lance.lmw...@gmail.com wrote: > > +if ( s->force_discard > 0 && frozen) > > +s->drop_count++; > > +else if ( s->force_discard < 0 && frozen

Re: [FFmpeg-devel] [PATCH v5 1/3] hevc_mp4toannexb: Insert correct parameter sets before IRAP

2019-10-07 Thread Andriy Gelman
On Wed, 02. Oct 08:05, Andriy Gelman wrote: > On Thu, 26. Sep 14:09, Andriy Gelman wrote: > > From: Andriy Gelman > > > > Fixes #7799 > > > > Currently, the mp4toannexb filter always inserts the same extradata at > > the start of the first IRAP unit. As in ticket #7799, this can lead to > > deco

Re: [FFmpeg-devel] [PATCH] Fix segment muxer

2019-10-07 Thread just . one . man
When incoming media has non-zero start PTS, segment muxer would fail to correctly calculate the point where to chunk segments, as it always assumed that media starts with PTS==0. This change removes this assumption by remembering the PTS of the very first frame passed through the muxer. Also fix

Re: [FFmpeg-devel] [PATCH] Fix segment muxer

2019-10-07 Thread Nicolas George
just.one@yandex.ru (12019-10-07): > Updated patch This should be after the triple dash, because it does not belong in the commit message. > --- > > When incoming media has non-zero start PTS, > segment muxer would fail to correctly calculate > the point where to chunk segments, as it always

Re: [FFmpeg-devel] [PATCH] Fix segment muxer

2019-10-07 Thread just . one . man
Updated patch --- When incoming media has non-zero start PTS, segment muxer would fail to correctly calculate the point where to chunk segments, as it always assumed that media starts with PTS==0. This change removes this assumption by remembering the PTS of the very first frame passed through th

Re: [FFmpeg-devel] [PATCH 0/5] adding ICC profile support to MOV decode/encode

2019-10-07 Thread vectronic
> On 23 Sep 2019, at 21:43, vectronic wrote: > > As discussed earlier on this mailing list, I needed to implement support for > reading and writing ICC profiles which can be stored in MOV/MP4 sample > descriptor colour information. > > The overall changes are: > > 1. Add a new enum value AVPa

Re: [FFmpeg-devel] [PATCH] avcodec/zmbv: Simplify assigning decode_intra function pointer

2019-10-07 Thread Paul B Mahol
lgtm On 10/7/19, Andreas Rheinhardt wrote: > zmbv has only one function for decoding intra frames, namely > decode_intra. This can be used to simplify the process of choosing the > right function pointer. > > This also removes spec-incompliant conversions between function pointers > and pointers

Re: [FFmpeg-devel] [PATCH v3 3/3] avformat/mpjpegdec: ensure seekback for latest chunk

2019-10-07 Thread Paul B Mahol
lgtm On 10/7/19, Moritz Barsnick wrote: > Not only the first, but each latest chunk must be cached to allow > seekback after finding the mime boundary. > > Fixes trac #5023 and #5921. > > Signed-off-by: Moritz Barsnick > --- > libavformat/mpjpegdec.c | 6 ++ > 1 file changed, 2 insertions(+

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/mpjpegdec: fix strict boundary search string

2019-10-07 Thread Paul B Mahol
lgtm On 10/7/19, Moritz Barsnick wrote: > According to RFC1341, the multipart boundary indicated by the > Content-Type header must be prepended by CRLF + "--", and followed > by CRLF. In the case of strict MIME header boundary handling, the > "--" was forgotten to add. > > Fixes trac #7921. > > A

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/mpjpegdec: fix finding multipart boundary parameter

2019-10-07 Thread Paul B Mahol
lgtm On 10/7/19, Moritz Barsnick wrote: > The string matching function's return value was evaluated incorrectly. > > Fixes trac #7920. > > Signed-off-by: Moritz Barsnick > --- > libavformat/mpjpegdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mpjpegde

Re: [FFmpeg-devel] [PATCH] avcodec/filter: Remove extra '; ' outside of functions

2019-10-07 Thread Paul B Mahol
ok On 10/7/19, Andreas Rheinhardt wrote: > They are not allowed outside of functions. Fixes the warning > "ISO C does not allow extra ‘;’ outside of a function [-Wpedantic]" > when compiling with GCC and -pedantic. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/v4l2_m2m_dec.c|