Re: [FFmpeg-devel] [PATCH 4/4] avfilter: add a generic filter for rgb proccessing with dnn networks

2019-10-16 Thread Paul B Mahol
There should be only one dnn_processing filter. Not one that does only rgb packed formats. On 10/16/19, Guo, Yejun wrote: > This filter accepts all the dnn networks which do image processing > on RGB-based format. Currently, frame with formats rgb24 and bgr24 > are supported. Other formats such a

[FFmpeg-devel] [PATCH] Feature for setting custom HTTP headers on the DASH muxer

2019-10-16 Thread Ole Andre Birkedal
Only some HTTP headers are exposed in the DASH muxer API. This patch just does the same as what's being done for HLS where it allows the user to set arbitrary HTTP headers. Useful for pushing directly to for example AWS MediaConnect, since they require some weird headers in addition to the Auth

Re: [FFmpeg-devel] [PATCH 1/2] mpeg4_unpack_bframes: Avoid allocations and copies of packet structures

2019-10-16 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> Andreas Rheinhardt: >>> 1. Since bd90a2ec, mpeg4_unpack_bframes caches whole packets instead of >>> just the pointer to the buffer and the buffer's size in order to be able >>> to make use of refcounting to avoid copying of data; this unfortunately >>> i

Re: [FFmpeg-devel] [PATCH] avfilter: add arnndn filter

2019-10-16 Thread Paul B Mahol
Will apply. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] mpeg4_unpack_bframes: Avoid allocations and copies of packet structures

2019-10-16 Thread Paul B Mahol
Could someone apply this? On 10/16/19, Andreas Rheinhardt wrote: > Andreas Rheinhardt: >> Andreas Rheinhardt: >>> Andreas Rheinhardt: 1. Since bd90a2ec, mpeg4_unpack_bframes caches whole packets instead of just the pointer to the buffer and the buffer's size in order to be able to

Re: [FFmpeg-devel] [PATCH 4/4] avfilter: add a generic filter for rgb proccessing with dnn networks

2019-10-16 Thread Guo, Yejun
-Original Message- From: Paul B Mahol Sent: Wednesday, October 16, 2019 5:17 PM To: FFmpeg development discussions and patches Cc: Guo, Yejun Subject: Re: [FFmpeg-devel] [PATCH 4/4] avfilter: add a generic filter for rgb proccessing with dnn networks There should be only one dnn_pro

Re: [FFmpeg-devel] [PATCH 4/4] avfilter: add a generic filter for rgb proccessing with dnn networks

2019-10-16 Thread Guo, Yejun
> -Original Message- > From: Paul B Mahol [mailto:one...@gmail.com] > Sent: Wednesday, October 16, 2019 5:17 PM > To: FFmpeg development discussions and patches > Cc: Guo, Yejun > Subject: Re: [FFmpeg-devel] [PATCH 4/4] avfilter: add a generic filter for rgb > proccessing with dnn netwo

Re: [FFmpeg-devel] [PATCH 4/4] avfilter: add a generic filter for rgb proccessing with dnn networks

2019-10-16 Thread Paul B Mahol
On 10/16/19, Guo, Yejun wrote: > > >> -Original Message- >> From: Paul B Mahol [mailto:one...@gmail.com] >> Sent: Wednesday, October 16, 2019 5:17 PM >> To: FFmpeg development discussions and patches >> Cc: Guo, Yejun >> Subject: Re: [FFmpeg-devel] [PATCH 4/4] avfilter: add a generic fil

Re: [FFmpeg-devel] [PATCH 4/4] avfilter: add a generic filter for rgb proccessing with dnn networks

2019-10-16 Thread Guo, Yejun
> -Original Message- > From: Paul B Mahol [mailto:one...@gmail.com] > Sent: Wednesday, October 16, 2019 7:30 PM > To: Guo, Yejun > Cc: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 4/4] avfilter: add a generic filter for rgb > proccessing with dnn netwo

Re: [FFmpeg-devel] [PATCH 09/12] avcodec/pafvideo: Only clear frame when it was written to

2019-10-16 Thread Michael Niedermayer
On Thu, Sep 26, 2019 at 11:18:37PM +0200, Michael Niedermayer wrote: > On Thu, Sep 26, 2019 at 10:04:44AM +0200, Paul B Mahol wrote: > > Why this does not set dirty for all decoding cases? > > dirty is set for c->current_frame, so cases which write only > into that do not need an explicit case. >

Re: [FFmpeg-devel] [PATCH 1/3] swscale/output: Implement Luma computation from yuv2ya16_X_c_template() without 64bit

2019-10-16 Thread Michael Niedermayer
On Thu, Sep 26, 2019 at 05:45:00PM +0200, Michael Niedermayer wrote: > This also reverts 21838cad2fc44023ad85e35d5c677e2f8d29a0ef > The revert is in this commit to avoid 2 fate updates > > Signed-off-by: Michael Niedermayer > --- > libswscale/output.c | 3 ++- > 1 file changed, 2 insertions(+),

Re: [FFmpeg-devel] [PATCH 10/12] tools/target_dec_fuzzer: Adjust threshold for MSZH

2019-10-16 Thread Michael Niedermayer
On Wed, Sep 25, 2019 at 10:38:56PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (250sec -> 6sec) > Fixes: > 17627/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSZH_fuzzer-5643017129558016 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/project

Re: [FFmpeg-devel] [PATCH 1/4] avformat/shortendec: Check k in probe

2019-10-16 Thread Michael Niedermayer
On Wed, Sep 25, 2019 at 12:01:17PM +0200, Michael Niedermayer wrote: > Fixes: Assertion failure > Fixes: > 17640/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5708767475269632 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signe

Re: [FFmpeg-devel] [PATCH 09/12] avcodec/pafvideo: Only clear frame when it was written to

2019-10-16 Thread Paul B Mahol
On 10/16/19, Michael Niedermayer wrote: > On Thu, Sep 26, 2019 at 11:18:37PM +0200, Michael Niedermayer wrote: >> On Thu, Sep 26, 2019 at 10:04:44AM +0200, Paul B Mahol wrote: >> > Why this does not set dirty for all decoding cases? >> >> dirty is set for c->current_frame, so cases which write onl

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/cavsdec: Check remaining bitstream in the main loop in decode_pic()

2019-10-16 Thread Michael Niedermayer
On Wed, Sep 25, 2019 at 12:01:18PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (149sec ->1sec) > Fixes: > 17311/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CAVS_fuzzer-5679368642232320 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects

Re: [FFmpeg-devel] [PATCH 2/5] tools/target_dec_fuzzer: Adjust threshold for SCPR

2019-10-16 Thread Michael Niedermayer
On Thu, Sep 26, 2019 at 11:10:54PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (46sec -> 7sec) > Fixes: > 17644/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SCPR_fuzzer-5715704283660288 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects

Re: [FFmpeg-devel] [PATCH 3/5] tools/target_dec_fuzzer: Adjust threshold for EATGV

2019-10-16 Thread Michael Niedermayer
On Thu, Sep 26, 2019 at 11:10:55PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (26sec -> 9sec) > Fixes: > 17645/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EATGV_fuzzer-5717065922510848 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/project

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/smacker: cleanup on errors in smka_decode_frame()

2019-10-16 Thread Michael Niedermayer
On Sun, Oct 13, 2019 at 12:20:28AM -0300, James Almer wrote: > On 10/10/2019 7:40 PM, Michael Niedermayer wrote: > > Fixes: multiple memleaks > > Fixes: > > 17660/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKAUD_fuzzer-5689769928949760 > > Fixes: > > 18064/clusterfuzz-testcase-minimized

[FFmpeg-devel] [PATCH] avformat/mpegenc: Fix memleaks and return values

2019-10-16 Thread Andreas Rheinhardt
If there is an error in mpeg_mux_init() (the write_header function of the various MPEG-PS muxers), two things might happen: 1. Several fifos might leak. Instead of freeing them, the goto fail part of the functions freed the private data of the AVStreams instead, although this will be freed later i

Re: [FFmpeg-devel] [PATCH 09/12] avcodec/pafvideo: Only clear frame when it was written to

2019-10-16 Thread Michael Niedermayer
On Wed, Oct 16, 2019 at 06:27:10PM +0200, Paul B Mahol wrote: > On 10/16/19, Michael Niedermayer wrote: > > On Thu, Sep 26, 2019 at 11:18:37PM +0200, Michael Niedermayer wrote: > >> On Thu, Sep 26, 2019 at 10:04:44AM +0200, Paul B Mahol wrote: > >> > Why this does not set dirty for all decoding ca

Re: [FFmpeg-devel] [PATCH 01/11] avcodec/adpcm: Fix left shifts in AV_CODEC_ID_ADPCM_EA

2019-10-16 Thread Michael Niedermayer
On Fri, Sep 27, 2019 at 07:23:40PM +0200, Michael Niedermayer wrote: > Fixes: left shift of negative value -1 > Fixes: > 17683/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_EA_R2_fuzzer-5111690013704192 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/

Re: [FFmpeg-devel] [PATCH] avformat/mpegenc: Fix memleaks and return values

2019-10-16 Thread Paul B Mahol
LGTM On 10/16/19, Andreas Rheinhardt wrote: > If there is an error in mpeg_mux_init() (the write_header function of > the various MPEG-PS muxers), two things might happen: > > 1. Several fifos might leak. Instead of freeing them, the goto fail part > of the functions freed the private data of the

Re: [FFmpeg-devel] [PATCH] avfilter: add bilateral filter

2019-10-16 Thread Andriy Gelman
On Sun, 13. Oct 17:08, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 17 ++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_bilateral.c | 372 + > 4 files changed, 391 insert

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

2019-10-16 Thread Michael Niedermayer
On Tue, Oct 15, 2019 at 08:44:23PM +1100, Peter Ross wrote: > On Mon, Oct 14, 2019 at 10:06:55PM +0200, Michael Niedermayer wrote: > > On Sun, Oct 13, 2019 at 10:51:49AM +1100, Peter Ross wrote: > > > On Sat, Oct 12, 2019 at 06:53:05PM -0300, James Almer wrote: > > > > On 10/12/2019 5:47 PM, Michae

[FFmpeg-devel] [PATCH] avfilter: add tdisplace filter

2019-10-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 21 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_tdisplace.c | 234 + 4 files changed, 257 insertions(+) create mode 100644 libavfilter/vf_tdisplace.c

Re: [FFmpeg-devel] [PATCH] avfilter: add bilateral filter

2019-10-16 Thread Moritz Barsnick
On Wed, Oct 16, 2019 at 13:19:44 -0400, Andriy Gelman wrote: > > +@item planes > > +Set planes to filter. Default is first only. > > +@end table > > It may be good to add that planes is a decimal representation of the planes to > filter. (i.e. 3 implies that 1st/2nd planes are filtered, 7 implies

Re: [FFmpeg-devel] [PATCH] avfilter: add tdisplace filter

2019-10-16 Thread Moritz Barsnick
Hi Paul, interesting concept! On Wed, Oct 16, 2019 at 20:35:46 +0200, Paul B Mahol wrote: Doc nits: > +It takes two input streams and outputs one stream, the first input is the > +source, and second input in temporal displacement map. "in" seems misplaced. Probably: [...] , the first input is

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/cavsdec: Check remaining bitstream in the main loop in decode_pic()

2019-10-16 Thread Andreas Rheinhardt
Michael Niedermayer: > On Wed, Sep 25, 2019 at 12:01:18PM +0200, Michael Niedermayer wrote: >> Fixes: Timeout (149sec ->1sec) >> Fixes: >> 17311/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CAVS_fuzzer-5679368642232320 >> >> Found-by: continuous fuzzing process >> https://github.com/google/o