[FFmpeg-devel] [PATCH] avfilter/af_anlmdn: Remove threading flag

2019-10-24 Thread Andriy Gelman
From: Andriy Gelman Unset flag because there is no threading in filter. --- libavfilter/af_anlmdn.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavfilter/af_anlmdn.c b/libavfilter/af_anlmdn.c index 6e37452963..c25454e6f8 100644 --- a/libavfilter/af_anlmdn.c +++ b/liba

[FFmpeg-devel] [PATCH v2] Add support for VP9 VDPAU hwaccel decode

2019-10-24 Thread ManojGuptaBonda
Support for VDPAU accelerated VP9 decoding was added with libvdpau-1.3. Support for the same in ffmpeg is added with this patch. Profiles related to VDPAU VP9 can be found in latest vdpau.h present in libvdpau-1.3. DRC clips are not supported yet due to http://trac.ffmpeg.org/ticket/8068 Add VP9 V

[FFmpeg-devel] [PATCH 2/2] frame: make av_frame_remove_side_data return early

2019-10-24 Thread quinkblack
From: Zhao Zhili --- libavutil/frame.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index bb20e99331..9edf971c55 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -825,6 +825,7 @@ void av_frame_remove_side_data(AVFrame *frame, enum AVFrameSid

[FFmpeg-devel] [PATCH 1/2] frame: handle add side data with the same type

2019-10-24 Thread quinkblack
From: Zhao Zhili --- libavutil/frame.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index dcf1fc3d17..bb20e99331 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -692,10 +692,23 @@ AVFrameSideData *av_frame_new_side_data_from_b

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: split empty text sample when duration overflow

2019-10-24 Thread Liu Steven
> 在 2019年10月25日,上午10:34,Jun Li 写道: > > On Fri, Oct 18, 2019 at 11:56 AM Jun Li wrote: > >> >> >> On Wed, Oct 9, 2019 at 3:42 PM Jun Li wrote: >> >>> >>> >>> On Mon, Oct 7, 2019 at 6:36 PM Jun Li wrote: >>> On Mon, Oct 7, 2019 at 6:34 PM Jun Li wrote: > Fix

Re: [FFmpeg-devel] [PATCH v2] avformat/tee.c: steal bsf option before passing to fifo muxer

2019-10-24 Thread Liu Steven
> 在 2019年10月17日,下午4:09,Jun Li 写道: > > On Sun, Oct 13, 2019 at 2:14 PM Jun Li wrote: > >> Fix #7620 >> In the case tee muxer with both "bsf" and "use_fifo" parameters >> will trigger this bug. Tee muxer will first steal parameters (like "f", >> "select"...) and then "use_fifo" will try reading

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mpeg: Remove secondary packet for reading VobSub

2019-10-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > When vobsub_read_packet() reads a packet, it uses a dedicated AVPacket > to get the subtitle timing and position from an FFDemuxSubtitlesQueue > (which has been filled with this data during reading the idx file in > vobsub_read_header); afterwards the actual subtitle data is r

Re: [FFmpeg-devel] [PATCH v6 1/3] hevc_mp4toannexb: Insert correct parameter sets before IRAP

2019-10-24 Thread Andriy Gelman
On Tue, 15. Oct 22:50, Andriy Gelman wrote: > From: Andriy Gelman > > Fixes #7799 > > Currently, the mp4toannexb filter always inserts the same extradata at > the start of the first IRAP unit. As in ticket #7799, this can lead to > decoding errors if modified parameter sets are signalled in-band

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: split empty text sample when duration overflow

2019-10-24 Thread Jun Li
On Fri, Oct 18, 2019 at 11:56 AM Jun Li wrote: > > > On Wed, Oct 9, 2019 at 3:42 PM Jun Li wrote: > >> >> >> On Mon, Oct 7, 2019 at 6:36 PM Jun Li wrote: >> >>> >>> >>> On Mon, Oct 7, 2019 at 6:34 PM Jun Li wrote: >>> Fix #7637 One empty/end sample is created and inserted between two

Re: [FFmpeg-devel] ffmpeg-qsv: Is opaque memory allocation path used in ffmpeg-qsv?

2019-10-24 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Rogozhkin, Dmitry V > Sent: Friday, October 25, 2019 05:17 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] ffmpeg-qsv: Is opaque memory allocation path > used in ffmpeg-qsv? > > On Thu, 2019-10-24 at 17:12 +0200, Max Dmi

[FFmpeg-devel] [PATCH] avformat/aiffenc: Add deinit function

2019-10-24 Thread Andreas Rheinhardt
Prevents memleaks if the trailer is never written. Signed-off-by: Andreas Rheinhardt --- libavformat/aiffenc.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/libavformat/aiffenc.c b/libavformat/aiffenc.c index d37b9ae1c6..e25794d185 100644 --- a/libavformat/aif

[FFmpeg-devel] [PATCH 2/2] avformat/mpeg: Fix leaks of AVFormatContext and subtitle packets

2019-10-24 Thread Andreas Rheinhardt
If an error happens in vobsub_read_header() after allocating the AVFormatContext intended to read the sub-file, both the AVFormatContext as well as the data in the subtitles queues leaks. This has been fixed. Signed-off-by: Andreas Rheinhardt --- libavformat/mpeg.c | 27 ++---

[FFmpeg-devel] [PATCH 1/2] avformat/mpeg: Don't copy or leak string in AVBPrint

2019-10-24 Thread Andreas Rheinhardt
vobsub_read_header() uses an AVBPrint to write a string and up until now, it collected the string stored in the AVBPrint via av_bprint_finalize(), which might involve an allocation and copy of the string. But this is unnecessary, as the lifetime of the returned string does not exceed the lifetime o

Re: [FFmpeg-devel] [PATCH v3 3/3] avutil/avstring: replace with system interface if dirname and basename functions are detected

2019-10-24 Thread Limin Wang
On Wed, Oct 23, 2019 at 06:07:24PM +0200, Paul B Mahol wrote: > Why? > Sorry, I haven't get your question, you mean why to use system standard c lib API? > On 10/23/19, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > configure|

[FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-10-24 Thread ckennedy
From: Christopher Kennedy this adds a phqm filter and OpenCV img_hash based resource usable by the phqm and future filters using image hash functionality from OpenCV. C++ to C handling so that full OpenCV functionality and API can be used instead of the C versions (which are incomplete and don't

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Free swresample dictionary during cleanup

2019-10-24 Thread Michael Niedermayer
On Thu, Oct 24, 2019 at 03:46:53PM +0200, Paul B Mahol wrote: > LGTM will apply thx > > On 10/24/19, Andreas Rheinhardt wrote: > > Freeing this was forgotten in ad899522. > > > > Fixes #8315 and #8316. > > > > Signed-off-by: Andreas Rheinhardt > > --- > > fftools/ffmpeg.c | 1 + > > 1 file c

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/vp5: Check render_x/y

2019-10-24 Thread Michael Niedermayer
On Thu, Oct 24, 2019 at 08:37:09PM +1100, Peter Ross wrote: > On Wed, Oct 23, 2019 at 08:57:12PM +0200, Michael Niedermayer wrote: > > Fixes: Timeout (15sec -> 91ms) > > Fixes: > > 18353/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP5_fuzzer-5704150326706176 > > > > Found-by: continuous fuz

Re: [FFmpeg-devel] ffmpeg-qsv: Is opaque memory allocation path used in ffmpeg-qsv?

2019-10-24 Thread Rogozhkin, Dmitry V
On Thu, 2019-10-24 at 17:12 +0200, Max Dmitrichenko wrote: > Hi, > > Just have a look at any usage as: ffmpeg -hwaccel qsv ... I looked into these 3 command lines on Linux: ffmpeg -hwaccel qsv -c:v h264_qsv -i AUD_MW_E.264 \ -vf hwdownload,format=nv12 -pix_fmt yuv420p \ AUD_MW

Re: [FFmpeg-devel] [PATCH] web/download: general improvements

2019-10-24 Thread Lou Logan
On Tue, Oct 22, 2019, at 10:05 AM, Paul B Mahol wrote: > probably ok Pushed b293ec7188b6b39ac769f358a2f4a95d0a49c1b7. Now giant download button is more giant, but I will adjust the CSS. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpe

Re: [FFmpeg-devel] [PATCH 1/6] tools/target_dec_fuzzer: Adjust ffwavesynth threshold

2019-10-24 Thread Michael Niedermayer
On Mon, Oct 07, 2019 at 06:39:17PM +0200, Michael Niedermayer wrote: > ffwavesynth can produce large amounts of data relatively slowly on very small > input > > Fixes: Timeout (60sec -> 9sec) > Fixes: > 17970/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5689121279836160 >

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/takdec: Fix overflow with large sample rates

2019-10-24 Thread Michael Niedermayer
On Sat, Oct 05, 2019 at 11:41:07PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483647 + 511 cannot be represented in > type 'int' > Fixes: > 17899/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TAK_fuzzer-5719753322135552 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/ralf: Skip initializing unused filter variables

2019-10-24 Thread Michael Niedermayer
On Sat, Oct 05, 2019 at 11:41:05PM +0200, Michael Niedermayer wrote: > Fixes: left shift of negative value -1 > Fixes: > 17890/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RALF_fuzzer-5643307467669504 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/

Re: [FFmpeg-devel] [PATCH 1/5] avformat/mpeg: Don't free unintialized pointer

2019-10-24 Thread James Almer
On 10/22/2019 10:16 AM, Andreas Rheinhardt wrote: > In order to fix a potential memleak upon failure, 0b8956b2 made sure that > a buffer given by a pointer was freed upon error. But this pointer was > only initialized upon use and in several cases (Clang gives no fewer > than 13 -Wsometimes-uniniti

Re: [FFmpeg-devel] [PATCH 2/5] avformat/mpeg: Add padding to extradata

2019-10-24 Thread Michael Niedermayer
On Tue, Oct 22, 2019 at 03:16:42PM +0200, Andreas Rheinhardt wrote: > Extradata is supposed to be padded with AV_INPUT_BUFFER_PADDING_SIZE bytes, > yet the VobSub demuxer used av_strdup for the allocation of extradata. > This has been changed. > > Signed-off-by: Andreas Rheinhardt > --- > I did n

Re: [FFmpeg-devel] [PATCH 2/6] avformat/aiffenc: Use better error codes

2019-10-24 Thread Michael Niedermayer
On Wed, Oct 23, 2019 at 02:59:40PM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/aiffenc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH 6/6] avformat/icoenc: Add deinit function

2019-10-24 Thread Michael Niedermayer
On Wed, Oct 23, 2019 at 02:59:44PM +0200, Andreas Rheinhardt wrote: > Prevents memleaks in situations where the trailer isn't written, e.g. > because of errors during writing the header. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/icoenc.c | 10 -- > 1 file changed, 8 inser

Re: [FFmpeg-devel] [PATCH] mpegvideo_enc: add option to disable intra mbs in p frames

2019-10-24 Thread Michael Niedermayer
On Wed, Oct 23, 2019 at 09:24:39PM +0200, Ramiro Polla wrote: > On Sun, Jun 17, 2018 at 6:23 AM Ramiro Polla wrote: > > On Sun, Jun 10, 2018 at 2:32 AM, Michael Niedermayer > > wrote: > > > On Sat, Jun 09, 2018 at 05:09:13PM +0200, Ramiro Polla wrote: > > >> On Thu, May 10, 2018 at 11:01 PM, Mich

Re: [FFmpeg-devel] [PATCH 4/5] avformat/mpeg: Fix memleak II

2019-10-24 Thread Michael Niedermayer
On Tue, Oct 22, 2019 at 03:16:44PM +0200, Andreas Rheinhardt wrote: > If an error happens in vobsub_read_header() after allocating the > AVFormatContext intended to read the sub-file, both the AVFormatContext > as well as the data in the subtitles queues leaks. This has been fixed. > > Signed-off-

Re: [FFmpeg-devel] [PATCH 1/6] avformat/aiffenc: Add deinit function

2019-10-24 Thread Michael Niedermayer
On Wed, Oct 23, 2019 at 02:59:39PM +0200, Andreas Rheinhardt wrote: > Prevents memleaks if the trailer is never written. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/aiffenc.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/libavformat/aiffe

Re: [FFmpeg-devel] [PATCH 4/6] avformat/flvenc: Add deinit function

2019-10-24 Thread Michael Niedermayer
On Wed, Oct 23, 2019 at 02:59:42PM +0200, Andreas Rheinhardt wrote: > Fixes memleaks when the trailer is never written or when shift_data() > fails when writing the trailer. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/flvenc.c | 30 -- > 1 file changed,

Re: [FFmpeg-devel] [PATCH] Support for zulu timezone format for PDT in HLS playlists

2019-10-24 Thread Marton Balint
On Thu, 24 Oct 2019, Ole Andre Birkedal wrote: This is something that Akamai requires for their MSL4 product when ingesting HLS and using it to generate clips on their CDN. It's also something required by one of our customers, but we don't know the exact reason of why they require this. I'll

Re: [FFmpeg-devel] ffmpeg-qsv: Is opaque memory allocation path used in ffmpeg-qsv?

2019-10-24 Thread Max Dmitrichenko
Hi, Just have a look at any usage as: ffmpeg -hwaccel qsv ... any 3rd_party implementation can use it by requesting AV_PIX_FMT_QSV regards Max On Thu, Oct 24, 2019 at 12:47 AM Rogozhkin, Dmitry V < dmitry.v.rogozh...@intel.com> wrote: > Hi, > > I was looking into the ffmpeg qsv (mediasdk h

Re: [FFmpeg-devel] [PATCH] avfilter/vf_lut3d: allocate 3d lut dynamically

2019-10-24 Thread Paul B Mahol
On 10/24/19, James Almer wrote: > On 10/24/2019 8:54 AM, Paul B Mahol wrote: >> +static int allocate_3dlut(AVFilterContext *ctx, int lutsize) >> +{ >> +LUT3DContext *lut3d = ctx->priv; >> + >> +if (lutsize < 2 || lutsize > MAX_LEVEL) { >> +av_log(ctx, AV_LOG_ERROR, "Too large or in

Re: [FFmpeg-devel] [PATCH] avfilter/vf_lut3d: allocate 3d lut dynamically

2019-10-24 Thread James Almer
On 10/24/2019 8:54 AM, Paul B Mahol wrote: > +static int allocate_3dlut(AVFilterContext *ctx, int lutsize) > +{ > +LUT3DContext *lut3d = ctx->priv; > + > +if (lutsize < 2 || lutsize > MAX_LEVEL) { > +av_log(ctx, AV_LOG_ERROR, "Too large or invalid 3D LUT size\n"); > +return

Re: [FFmpeg-devel] [PATCH v1] avformat/mpeg: fix CID 1455132: Memory - illegal accesses (UNINIT)

2019-10-24 Thread Limin Wang
On Thu, Oct 24, 2019 at 04:07:37AM +0200, Andreas Rheinhardt wrote: > On Thu, Oct 24, 2019 at 3:36 AM wrote: > > > From: Limin Wang > > > > Before header_str is initialized, the code is possible to goto end and > > free the > > header_str and cause invalid access. > > > > Signed-off-by: Limin Wa

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Free swresample dictionary during cleanup

2019-10-24 Thread Paul B Mahol
LGTM On 10/24/19, Andreas Rheinhardt wrote: > Freeing this was forgotten in ad899522. > > Fixes #8315 and #8316. > > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffmpeg.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index 8e408c808a..27f689

[FFmpeg-devel] [PATCH] fftools/ffmpeg: Free swresample dictionary during cleanup

2019-10-24 Thread Andreas Rheinhardt
Freeing this was forgotten in ad899522. Fixes #8315 and #8316. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 8e408c808a..27f68933f8 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -567

Re: [FFmpeg-devel] [PATCH] avfilter: add maskedmin/maskedmax filters

2019-10-24 Thread Paul B Mahol
Will apply. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavformat/rtsp: fix rtsp multicasts

2019-10-24 Thread Wolfgang Haupt
On 2019-10-18 18:59, Wolfgang Haupt wrote: If an rtsp server offers a udp multicast address as response of a DESCRIBE command the rtsp client is expected to issue SETUP with "Transport: RTP/AVP/UDP;multicast". Some rtsp servers bail out otherwise. --- libavformat/rtsp.c | 3 +++ 1 file changed

[FFmpeg-devel] [PATCH] avfilter/vf_lut3d: allocate 3d lut dynamically

2019-10-24 Thread Paul B Mahol
Also increase MAX_LEVEL while here. Signed-off-by: Paul B Mahol --- libavfilter/vf_lut3d.c | 165 ++--- 1 file changed, 107 insertions(+), 58 deletions(-) diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c index a525039baa..8ea6f44469 100644 --- a/l

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/vp5: Check render_x/y

2019-10-24 Thread Peter Ross
On Wed, Oct 23, 2019 at 08:57:12PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (15sec -> 91ms) > Fixes: > 18353/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP5_fuzzer-5704150326706176 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/

Re: [FFmpeg-devel] [PATCH] Support for zulu timezone format for PDT in HLS playlists

2019-10-24 Thread Ole Andre Birkedal
This is something that Akamai requires for their MSL4 product when ingesting HLS and using it to generate clips on their CDN. It's also something required by one of our customers, but we don't know the exact reason of why they require this. I'll update the patch with a better commit message expl

Re: [FFmpeg-devel] [PATCH] Add support for VP9 VDPAU hwaccel decode

2019-10-24 Thread Moritz Barsnick
On Tue, Oct 22, 2019 at 17:36:22 +0530, ManojGuptaBonda wrote: > --- a/Changelog > +++ b/Changelog > @@ -16,7 +16,7 @@ version : > - photosensitivity filter > - anlms filter > - arnndn filter > - > +- VDPAU VP9 hwaccel Nit: Please don't remove the empty line from the Changelog. > #define LIBA

Re: [FFmpeg-devel] [PATCH V2] avfilter/vf_bilateral: process command to set the parameter at runtime

2019-10-24 Thread Tao Zhang
Paul B Mahol 于2019年10月24日周四 下午3:42写道: > > Still not OK, you are using old process command which is pointless now. Right. I will submit a new version. Thanks a lot. > > On 10/24/19, leozhang wrote: > > Reviewed-by: Paul B Mahol > > Reviewed-by: Jun Zhao > > Signed-off-by: leozhang > > --- > >

Re: [FFmpeg-devel] [PATCH] Support for zulu timezone format for PDT in HLS playlists

2019-10-24 Thread Moritz Barsnick
On Wed, Oct 23, 2019 at 14:44:38 +0200, Marton Balint wrote: > Please also explain why this might be required in the docs. In the commit > message please name the specific vendor/device which is not parsing zero > offset correctly. > > I wonder if it would make sense to set this flag by default (do

Re: [FFmpeg-devel] [PATCH V2] avfilter/vf_bilateral: process command to set the parameter at runtime

2019-10-24 Thread Paul B Mahol
Still not OK, you are using old process command which is pointless now. On 10/24/19, leozhang wrote: > Reviewed-by: Paul B Mahol > Reviewed-by: Jun Zhao > Signed-off-by: leozhang > --- > libavfilter/vf_bilateral.c | 60 > +++--- > 1 file changed, 46 ins