Re: [FFmpeg-devel] [PATCH] avfilter/avf_showfreqs: free input frame after using it

2019-10-26 Thread Paul B Mahol
LGTM On 10/26/19, James Almer wrote: > Fixes ticket #8336. > > Signed-off-by: James Almer > --- > libavfilter/avf_showfreqs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/avf_showfreqs.c b/libavfilter/avf_showfreqs.c > index c44ac564ac..645754ded3 100644 > --- a/libavfil

Re: [FFmpeg-devel] [PATCH v1] avfilter/asrc_anoisesrc: change type to TYPE_INT64 for color is int64_t

2019-10-26 Thread Paul B Mahol
Not OK, variable should be int and not int64_t. On 10/26/19, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Or it'll cause invalid color and s->filter is NULL. > Please reproduce it with below command on big endian system: > $ ./ffmpeg -f lavfi -i "anoisesrc=d=60:c=1:r=48000" -f s16le -c:a

Re: [FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-10-26 Thread Carl Eugen Hoyos
Am Sa., 26. Okt. 2019 um 06:45 Uhr schrieb : > +// convert from avframe to iplimage format > +static int fill_iplimage_from_frame(IplImage *img, const AVFrame *frame, > enum AVPixelFormat pixfmt) > +{ > +IplImage *tmpimg; > +int depth = IPL_DEPTH_8U, channels_nb; > + > +switch (pixfmt

[FFmpeg-devel] [PATCH] libavcodec/h261dec: Fix keyframe markup and frame skipping.

2019-10-26 Thread Andrey Semashev
The decoder never marks pictures as I-frames, which results in no keyframe indication and incorrect frame skipping, in cases when keyframes should be decoded. This commit works around this decoder limitation and marks I-frames and keyframes based on "freeze picture release" bit in h261 picture hea

Re: [FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-10-26 Thread Chris Kennedy
On Sat, Oct 26, 2019 at 4:15 AM Carl Eugen Hoyos wrote: > > Am Sa., 26. Okt. 2019 um 06:45 Uhr schrieb : > > > +// convert from avframe to iplimage format > > +static int fill_iplimage_from_frame(IplImage *img, const AVFrame *frame, > > enum AVPixelFormat pixfmt) > > +{ > > +IplImage *tmpimg;

[FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-10-26 Thread ckennedy
From: Christopher Kennedy this adds a phqm filter and OpenCV img_hash based resource usable by the phqm and future filters using image hash functionality from OpenCV. C++ to C handling so that full OpenCV functionality and API can be used instead of the C versions (which are incomplete and don't

Re: [FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-10-26 Thread Paul B Mahol
Why is this not generic filter like already existing opencv filter? On 10/26/19, ckenn...@ellation.com wrote: > From: Christopher Kennedy > > this adds a phqm filter and OpenCV img_hash based resource usable > by the phqm and future filters using image hash functionality > from OpenCV. > > C++ t

Re: [FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-10-26 Thread Carl Eugen Hoyos
Am Sa., 26. Okt. 2019 um 14:00 Uhr schrieb : > > From: Christopher Kennedy > > this adds a phqm filter and OpenCV img_hash based resource usable > by the phqm and future filters using image hash functionality > from OpenCV. > C++ to C handling so that full OpenCV functionality and API can > be us

Re: [FFmpeg-devel] [PATCH] libavcodec/h261dec: Fix keyframe markup and frame skipping.

2019-10-26 Thread Carl Eugen Hoyos
Am Sa., 26. Okt. 2019 um 13:12 Uhr schrieb Andrey Semashev : > > The decoder never marks pictures as I-frames, which results in no > keyframe indication and incorrect frame skipping, in cases when > keyframes should be decoded. > > This commit works around this decoder limitation and marks I-frames

Re: [FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-10-26 Thread Christopher Kennedy
This is a reference/encode comparison filter with two files input like the psnr or vmaf filter. So it is completely different and uses the C++ OpenCV API since this img_hash library is not in the C API. It's unique to what the OCV filter does, and has more research implications from my talk at Demu

Re: [FFmpeg-devel] [PATCH] libavcodec/h261dec: Fix keyframe markup and frame skipping.

2019-10-26 Thread Andrey Semashev
On 2019-10-26 15:49, Carl Eugen Hoyos wrote: Am Sa., 26. Okt. 2019 um 13:12 Uhr schrieb Andrey Semashev : The decoder never marks pictures as I-frames, which results in no keyframe indication and incorrect frame skipping, in cases when keyframes should be decoded. This commit works around this

Re: [FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-10-26 Thread Christopher Kennedy
On Sat, Oct 26, 2019 at 7:39 AM Carl Eugen Hoyos wrote: > > Am Sa., 26. Okt. 2019 um 14:00 Uhr schrieb : > > > > From: Christopher Kennedy > > > > this adds a phqm filter and OpenCV img_hash based resource usable > > by the phqm and future filters using image hash functionality > > from OpenCV. >

Re: [FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-10-26 Thread Paul B Mahol
On 10/26/19, Christopher Kennedy wrote: > This is a reference/encode comparison filter with two files input like > the psnr or vmaf filter. > So it is completely different and uses the C++ OpenCV API since this > img_hash library is not in the C API. > It's unique to what the OCV filter does, and

[FFmpeg-devel] [PATCH v2] avfilter/asrc_anoisesrc: change color variable to int

2019-10-26 Thread lance . lmwang
From: Limin Wang Or it'll cause invalid color and s->filter is NULL. Please reproduce it with below command on big endian system: $ ./ffmpeg -f lavfi -i "anoisesrc=d=60:c=1:r=48000" -f s16le -c:a pcm_s16le -f null - Segmentation fault (core dumped) Signed-off-by: Limin Wang --- libavfilter/a

Re: [FFmpeg-devel] [PATCH] avfilter/avf_showfreqs: free input frame after using it

2019-10-26 Thread James Almer
On 10/26/2019 4:31 AM, Paul B Mahol wrote: > LGTM > > On 10/26/19, James Almer wrote: >> Fixes ticket #8336. >> >> Signed-off-by: James Almer >> --- >> libavfilter/avf_showfreqs.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavfilter/avf_showfreqs.c b/libavfilter/avf_showfreqs

Re: [FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-10-26 Thread Christopher Kennedy
On Sat, Oct 26, 2019 at 8:22 AM Paul B Mahol wrote: > > On 10/26/19, Christopher Kennedy wrote: > > This is a reference/encode comparison filter with two files input like > > the psnr or vmaf filter. > > So it is completely different and uses the C++ OpenCV API since this > > img_hash library is

Re: [FFmpeg-devel] [PATCH v2] avfilter/asrc_anoisesrc: change color variable to int

2019-10-26 Thread Paul B Mahol
OK On 10/26/19, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Or it'll cause invalid color and s->filter is NULL. > Please reproduce it with below command on big endian system: > $ ./ffmpeg -f lavfi -i "anoisesrc=d=60:c=1:r=48000" -f s16le -c:a pcm_s16le > -f > null - > Segmentation faul

[FFmpeg-devel] [PATCH 1/2] lavc/qsvenc: enable vp9 encoder

2019-10-26 Thread zhongli_dev
From: Zhong Li 1. must enable low_power mode since just VDENC can be supported by iHD driver right now 2. Coding option1 and extra_data are not supported by MSDK 3. IVF header will be inserted in MSDK by default, but it is not needed for FFmpeg, so disable it. Signed-off-by: Zhong Li --- Chang

[FFmpeg-devel] [PATCH 2/2] tools/probetest: replace the deprecated API

2019-10-26 Thread zhongli_dev
From: Zhong Li Signed-off-by: Zhong Li --- tools/probetest.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/probetest.c b/tools/probetest.c index 2c6c1de246..75ed42d480 100644 --- a/tools/probetest.c +++ b/tools/probetest.c @@ -39,8 +39,9 @@ static void probe(AV

[FFmpeg-devel] [PATCH] avcodec/tiff: check the black level denominator

2019-10-26 Thread James Almer
Fixes ticket #8327. Signed-off-by: James Almer --- libavcodec/tiff.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index f537e99b5a..c34e97cd6d 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -1413,6 +1413,10 @@ static int tiff_decode_tag

Re: [FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-10-26 Thread Jan Ekström
Hi, On Sat, Oct 26, 2019 at 4:35 PM Christopher Kennedy wrote: > The C OpenCV API is not recommended so this does the OpenCV part > in C++ which allows it to be fully utilized and supported. So that seems > better to me than using the API OpenCV won't really support and doesn't > allow usage of i

Re: [FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-10-26 Thread Paul B Mahol
On 10/26/19, Christopher Kennedy wrote: > On Sat, Oct 26, 2019 at 8:22 AM Paul B Mahol wrote: >> >> On 10/26/19, Christopher Kennedy wrote: >> > This is a reference/encode comparison filter with two files input like >> > the psnr or vmaf filter. >> > So it is completely different and uses the C+

Re: [FFmpeg-devel] [PATCH v2] Add support for VP9 VDPAU hwaccel decode

2019-10-26 Thread Philip Langdale
On Fri, 25 Oct 2019 11:00:13 +0530 ManojGuptaBonda wrote: > Support for VDPAU accelerated VP9 decoding was added with > libvdpau-1.3. Support for the same in ffmpeg is added with this > patch. Profiles related to VDPAU VP9 can be found in latest vdpau.h > present in libvdpau-1.3. DRC clips are no

Re: [FFmpeg-devel] [PATCH 1/4] avformat/flvenc: Forward errors from allocating keyframe index

2019-10-26 Thread Michael Niedermayer
On Sat, Oct 26, 2019 at 04:55:35AM +0200, Andreas Rheinhardt wrote: > On Fri, Oct 25, 2019 at 11:12 PM Michael Niedermayer > wrote: > > > On Fri, Oct 25, 2019 at 10:52:19AM +0200, Andreas Rheinhardt wrote: > > > While the function adding a new element to the keyframe index checked > > > the alloc

Re: [FFmpeg-devel] [PATCH] libavcodec/h261dec: Fix keyframe markup and frame skipping.

2019-10-26 Thread Michael Niedermayer
On Sat, Oct 26, 2019 at 02:05:27PM +0300, Andrey Semashev wrote: > The decoder never marks pictures as I-frames, which results in no > keyframe indication and incorrect frame skipping, in cases when > keyframes should be decoded. > > This commit works around this decoder limitation and marks I-fra

Re: [FFmpeg-devel] [PATCH] libavcodec/h261dec: Fix keyframe markup and frame skipping.

2019-10-26 Thread Andrey Semashev
On 2019-10-26 21:15, Michael Niedermayer wrote: On Sat, Oct 26, 2019 at 02:05:27PM +0300, Andrey Semashev wrote: The decoder never marks pictures as I-frames, which results in no keyframe indication and incorrect frame skipping, in cases when keyframes should be decoded. This commit works aroun

Re: [FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-10-26 Thread Christopher Kennedy
On Sat, Oct 26, 2019 at 11:15 AM Paul B Mahol wrote: > > On 10/26/19, Christopher Kennedy wrote: > > On Sat, Oct 26, 2019 at 8:22 AM Paul B Mahol wrote: > >> > >> On 10/26/19, Christopher Kennedy wrote: > >> > This is a reference/encode comparison filter with two files input like > >> > the psn

Re: [FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-10-26 Thread Chris Kennedy
On Sat, Oct 26, 2019 at 8:50 AM Jan Ekström wrote: > Hi, > > On Sat, Oct 26, 2019 at 4:35 PM Christopher Kennedy > wrote: > > The C OpenCV API is not recommended so this does the OpenCV part > > in C++ which allows it to be fully utilized and supported. So that seems > > better to me than using

[FFmpeg-devel] [PATCH] avfilter: add median filter

2019-10-26 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 15 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/median.h | 50 +++ libavfilter/median_template.c | 162 + libavfilter/vf_median.c | 267 +++

Re: [FFmpeg-devel] ffmpeg-qsv: Is opaque memory allocation path used in ffmpeg-qsv?

2019-10-26 Thread Max Dmitrichenko
usage as format= AV_PIX_FMT_QSV; frame_type = MFX_MEMTYPE_OPAQUE_FRAME; enforces usage of opaque memory from any 3rd_party application. you can offer patch to remove opaque implementation where it will be not reasonable to apply it unless deprecated and dropped from MediaSDK defin

[FFmpeg-devel] [PATCH] avformat/ftp: add AVOptions for authentication

2019-10-26 Thread Nicolas Frattaroli
This introduces two new AVOption options for the FTP protocol, one named ftp-user to supply the username to be used for auth, one named ftp-password to supply the password to be used for auth. These are useful for when an API user does not wish to deal with URL manipulation and percent encoding.

[FFmpeg-devel] [PATCH 4/4] avcodec/libvorbisdec: Fix insufficient input checks leading to out of array reads

2019-10-26 Thread Michael Niedermayer
Fixes: 16144/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LIBVORBIS_fuzzer-5638618940440576 Fixes: out of array read Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/libvorbisdec.c | 11 ++

[FFmpeg-devel] [PATCH 3/4] avcodec/g723_1dec: fix invalid shift with negative sid_gain

2019-10-26 Thread Michael Niedermayer
Fixes: left shift of negative value -1 Fixes: 18395/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_G723_1_fuzzer-5710313034350592 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/g723_1dec.c

[FFmpeg-devel] [PATCH 1/4] avcodec/truemotion2: Fix several integer overflows with *Yo, *Uo, *Vo

2019-10-26 Thread Michael Niedermayer
Fixes: signed integer overflow: 538976288 - -2080374792 cannot be represented in type 'int' Fixes: 16196/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-5144044274974720 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Sign

[FFmpeg-devel] [PATCH 2/4] avcodec/truemotion2: Fix several integer overflows in tm2_low_res_block()

2019-10-26 Thread Michael Niedermayer
Fixes: signed integer overflow: 1077952576 + 1355863565 cannot be represented in type 'int' Fixes: 16196/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-5679842317565952 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Sign

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames

2019-10-26 Thread hydra3333
On 14.10.2019 18:56 Timo Rothenpieler wrote: > On 14.10.2019 17:43, Hendrik Leppkes wrote: > > Since some users seem to have blindly passed -refs to their > > commandline which now fails without really telling them why, any > > thoughts on moving the capability check error messages onto a high log

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames

2019-10-26 Thread hydra3333
> On 14.10.2019 18:56 Timo Rothenpieler wrote: > > On 14.10.2019 17:43, Hendrik Leppkes wrote: > > > Since some users seem to have blindly passed -refs to their > > > commandline which now fails without really telling them why, any > > > thoughts on moving the capability check error messages onto a

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames

2019-10-26 Thread Nicolas Frattaroli
On 27.10.19 02:14, hydra3...@gmail.com wrote: > I see the attachment (attached by outlook) was scrubbed. > Sorry, I'd hoped it would work. > So, patch just pasted below to see if that works. > Please use git send-email. It's the easiest way to properly send patches to the list.

[FFmpeg-devel] [PATCH 1/1] Slightly update nvenc error messages and warnings

2019-10-26 Thread hydra3333
--- libavcodec/nvenc.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index bbb43ddad8..a18eb1df89 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -321,39 +321,39 @@ static int nvenc

[FFmpeg-devel] [PATCH 0/1] Slightly update nvenc error messages and warnings

2019-10-26 Thread hydra3333
On 14.10.2019 18:56 Timo Rothenpieler wrote in http://ffmpeg.org/pipermail/ffmpeg-devel/2019-October/251611.html : > On 14.10.2019 17:43, Hendrik Leppkes wrote: > > Since some users seem to have blindly passed -refs to their > > commandline which now fails without really telling them why, any > >

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames

2019-10-26 Thread hydra3333
On 27.10.19 02:14, hydra at gmail.com wrote: > > I see the attachment (attached by outlook) was scrubbed. > > Sorry, I'd hoped it would work. > > So, patch just pasted below to see if that works. > > > Please use git send-email. It's the easiest way to properly send patches to the list OK,

[FFmpeg-devel] [PATCH 1/2] avcodec/v4l2_buffers: Fix infinite loop

2019-10-26 Thread Andriy Gelman
From: Andriy Gelman This part of the code counts the number of planes returned by the v4l2 device for each queried capture/output buffer. When testing the GPU h264 encoder on Nvidia's Jetson Nano, this caused an infinite loop because avbuf->buf.length included some empty buffers (i.e. where avbuf

[FFmpeg-devel] [PATCH 2/2] avcodec/v4l2_m2m: Fix indentation

2019-10-26 Thread Andriy Gelman
From: Andriy Gelman --- libavcodec/v4l2_m2m.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/v4l2_m2m.c b/libavcodec/v4l2_m2m.c index 358f587797..1112d71ead 100644 --- a/libavcodec/v4l2_m2m.c +++ b/libavcodec/v4l2_m2m.c @@ -377,7 +377,7 @@ int ff_v4l2_m2m_codec_in

Re: [FFmpeg-devel] [PATCH v2] Add support for VP9 VDPAU hwaccel decode

2019-10-26 Thread Manoj Bonda
Thanks Philip. > -Original Message- > From: ffmpeg-devel On Behalf Of Philip > Langdale > Sent: Saturday, October 26, 2019 10:35 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2] Add support for VP9 VDPAU hwaccel > decode > > On Fri, 25 Oct 2019 11:00:13 +0530 > M