[FFmpeg-devel] [PATCH v2 2/2] lavf/movenc: cosmetics

2019-10-29 Thread Yuki.Tsuchiya
Signed-off-by: Yuki.Tsuchiya --- libavformat/movenc.c | 72 +++- 1 file changed, 38 insertions(+), 34 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index ff234d9..85f978a 100644 --- a/libavformat/movenc.c +++

[FFmpeg-devel] [PATCH v2 1/2] lavf/isom: support for demuxing MPEG-H 3D Audio in MP4

2019-10-29 Thread Yuki.Tsuchiya
Implemented according to the specification at https://www.iso.org/standard/69561.html The 'mhm1' sample entry is registered with MP4RA, which is defined as MHAS encapsulated single stream MPEG-H 3D Audio. 'MHAS' stands for MPEG-H audio stream, which contains encoded audio data and corresponds

[FFmpeg-devel] [PATCH v2 0/2] lavf/isom: support for demuxing MPEG-H 3D Audio in MP4

2019-10-29 Thread Yuki.Tsuchiya
Hi, Here is the sample content of the MPEG-H 3D Audio.

Re: [FFmpeg-devel] [PATCH v1 1/3] tests/fate/filter-video: add fate pixfmts test for lut3d

2019-10-29 Thread Limin Wang
On Wed, Oct 30, 2019 at 09:22:52AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > tests/fate/filter-video.mak | 3 +++ > tests/ref/fate/filter-pixfmts-lut3d | 24 > 2 files changed, 27 insertions(+) > create mode

[FFmpeg-devel] [PATCH v1 2/3] avfilter/vf_lut3d: simplify code

2019-10-29 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_lut3d.c | 27 +++ 1 file changed, 3 insertions(+), 24 deletions(-) diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c index cd0aba1f69..ff030f0950 100644 --- a/libavfilter/vf_lut3d.c +++

[FFmpeg-devel] [PATCH v1 3/3] avfilter/vf_lut: simplify code

2019-10-29 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_lut.c | 60 1 file changed, 11 insertions(+), 49 deletions(-) diff --git a/libavfilter/vf_lut.c b/libavfilter/vf_lut.c index 1fdc5e1812..3aed4ccc2c 100644 --- a/libavfilter/vf_lut.c +++

[FFmpeg-devel] [PATCH v1 1/3] tests/fate/filter-video: add fate pixfmts test for lut3d

2019-10-29 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- tests/fate/filter-video.mak | 3 +++ tests/ref/fate/filter-pixfmts-lut3d | 24 2 files changed, 27 insertions(+) create mode 100644 tests/ref/fate/filter-pixfmts-lut3d diff --git a/tests/fate/filter-video.mak

Re: [FFmpeg-devel] [PATCH] avformat/hls: Set AVFMT_TS_DISCONT flag on HLS input format

2019-10-29 Thread Dennis Mungai
On Tue, 29 Oct 2019 at 06:07, Steven Liu wrote: > > > > > 在 2019年10月29日,01:09,Dennis Mungai 写道: > > > > On Mon, 28 Oct 2019 at 05:45, Steven Liu wrote: > >> > >> > >> > >>> 在 2019年10月28日,02:39,Philip Langdale 写道: > >>> > >>> There have been many reports over the years about problems when > >>>

[FFmpeg-devel] [PATCH] configure: fix standalone compilation of mxf muxer

2019-10-29 Thread Lou Logan
Signed-off-by: Lou Logan --- Fixes: ./configure --disable-everything --enable-muxer=mxf ... LD ffmpeg_g /usr/bin/ld: libavformat/libavformat.a(mxfenc.o): in function `get_ue_golomb_31': ffmpeg/./libavcodec/golomb.h:140: undefined reference to `ff_ue_golomb_vlc_code' collect2: error: ld

[FFmpeg-devel] [PATCH 4/4] avformat/vividas: Add EOF check in val_1 loop in track_header()

2019-10-29 Thread Michael Niedermayer
Fixes: Timeout (148sec -> 0.1sec) Fixes: 18427/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5682124627116032 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/vividas.c | 2 ++ 1 file

[FFmpeg-devel] [PATCH 3/4] avcodec/iff: Move index use after check in decodeplane8()

2019-10-29 Thread Michael Niedermayer
Fixes: index 9 out of bounds for type 'const uint64_t [8][256]' Fixes: 18409/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5767030560522240 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCH 1/4] avcodec/apedec: Fixes integer overflow of res+*data in do_apply_filter()

2019-10-29 Thread Michael Niedermayer
Fixes: signed integer overflow: 7400 + 2147482786 cannot be represented in type 'int' Fixes: 18405/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5708834760294400 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 2/4] avcodec/ra288: Check block_align for the assumed value

2019-10-29 Thread Michael Niedermayer
Fixes: Timeout (224sec -> 1ms) Fixes: 18408/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RA_288_fuzzer-5740382570151936 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/ra288.c | 2 +- 1

[FFmpeg-devel] [PATCH 2/3] avfilter/vf_fps: reindent

2019-10-29 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_fps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_fps.c b/libavfilter/vf_fps.c index 7c9762864b..993a6be1b9 100644 --- a/libavfilter/vf_fps.c +++ b/libavfilter/vf_fps.c @@ -158,8 +158,8 @@ static int

[FFmpeg-devel] [PATCH 3/3] avfilter/vf_fps: add option to change way how frames are duplicated

2019-10-29 Thread Paul B Mahol
Default behaviour is unchanged, and that is always rounding down when picking which frame to clone. Signed-off-by: Paul B Mahol --- doc/filters.texi | 19 +++ libavfilter/vf_fps.c | 23 --- 2 files changed, 39 insertions(+), 3 deletions(-) diff --git

[FFmpeg-devel] [PATCH 1/3] avfilter/vf_fps: add way to get CFR output without knowing input frame rate

2019-10-29 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 3 +++ libavfilter/vf_fps.c | 10 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 11f715319a..1e815bf940 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -10737,6

Re: [FFmpeg-devel] Reimbursement request

2019-10-29 Thread Thilo Borgmann
Am 29.10.19 um 09:34 schrieb Steven Liu: > Hi, > I'm requesting the reimbursement of travel expenses for the Google Mentor > Summit. > I mentored the Derain project, more details can be found in [1]. > > > Flight (CNY) ¥ 7062.00 > One night hotel (CNY) ¥ 632.00 > > Total

Re: [FFmpeg-devel] [PATCH v1 1/2] avcodec/dds: simplify the calculation of slice start and end

2019-10-29 Thread Limin Wang
ping On Mon, Oct 21, 2019 at 08:48:13AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/dds.c | 19 +++ > 1 file changed, 3 insertions(+), 16 deletions(-) > > diff --git a/libavcodec/dds.c b/libavcodec/dds.c > index

Re: [FFmpeg-devel] [PATCH v4 1/4] avfilter/vf_scdet: add filter to detect scene change

2019-10-29 Thread Limin Wang
ping, I have other developing filter is using this metadata, please feedback whether it's OK to merge. On Tue, Oct 08, 2019 at 11:28:36PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Reviewed-by: Paul B Mahol > Signed-off-by: Limin Wang > --- > configure|

Re: [FFmpeg-devel] [PATCH v4 3/3] FATE: add a test for freeezedetect

2019-10-29 Thread Limin Wang
ping, the patchset 1 and 2 has been pushed by Michael, but the #3 haven't merged yet. On Mon, Oct 21, 2019 at 06:12:13PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > tests/fate/filter-video.mak | 4 + >

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_fps: add way to get CFR output without knowing input frame rate

2019-10-29 Thread Moritz Barsnick
On Tue, Oct 29, 2019 at 14:47:43 +0100, Paul B Mahol wrote: > +{ "input", "use input framerate is available", OFFSET(input), > AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, V|F }, I assume you meant: is -> if > -av_log(ctx, AV_LOG_VERBOSE, "fps=%d/%d\n", s->framerate.num, > s->framerate.den);

Re: [FFmpeg-devel] [PATCH] avfilter: remove useless cast

2019-10-29 Thread zhilizhao(赵志立)
> On Oct 29, 2019, at 9:15 PM, Paul B Mahol wrote: > > On 10/29/19, Michael Niedermayer wrote: >> On Mon, Oct 28, 2019 at 11:18:04AM +0800, myp...@gmail.com wrote: >>> On Mon, Oct 28, 2019 at 12:03 AM Zhao Zhili >>> wrote: --- libavfilter/allfilters.c | 2 +- 1 file

[FFmpeg-devel] [PATCH] libavcodec/amfenc.h: Added engine selection support for AMFContext initialisation.

2019-10-29 Thread OvchinnikovDmitrii
--- libavcodec/amfenc.c | 93 +++- libavcodec/amfenc.h | 8 libavcodec/amfenc_h264.c | 6 +++ libavcodec/amfenc_hevc.c | 6 +++ 4 files changed, 93 insertions(+), 20 deletions(-) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_fps: add way to get CFR output without knowing input frame rate

2019-10-29 Thread Paul B Mahol
On 10/29/19, Gyan wrote: > > > On 29-10-2019 07:17 PM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 3 +++ >> libavfilter/vf_fps.c | 10 +- >> 2 files changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/doc/filters.texi

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_fps: add way to get CFR output without knowing input frame rate

2019-10-29 Thread Gyan
On 29-10-2019 07:17 PM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- doc/filters.texi | 3 +++ libavfilter/vf_fps.c | 10 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 11f715319a..1e815bf940 100644 ---

[FFmpeg-devel] [PATCH V2] libavformat/flacenc: reject too big picture blocks

2019-10-29 Thread Mattias Wadman
A too big picture will case the muxer to write a truncated block size (uint24) causing the output file to be corrupt. How to reproduce: Write a file with truncated block size: ffmpeg -y -f lavfi -i sine -f lavfi -i color=red:size=2400x2400 -map 0:a:0 -map 1:v:0 -c:v:0 bmp -disposition:1

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_fps: reindent

2019-10-29 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_fps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_fps.c b/libavfilter/vf_fps.c index 3561332f0e..da004937d5 100644 --- a/libavfilter/vf_fps.c +++ b/libavfilter/vf_fps.c @@ -160,8 +160,8 @@ static int

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_fps: add way to get CFR output without knowing input frame rate

2019-10-29 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 3 +++ libavfilter/vf_fps.c | 10 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 11f715319a..1e815bf940 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -10737,6

Re: [FFmpeg-devel] [PATCH] libavcodec/h261dec: Fix keyframe markup and frame skipping.

2019-10-29 Thread Andrey Semashev
On 2019-10-26 14:05, Andrey Semashev wrote: The decoder never marks pictures as I-frames, which results in no keyframe indication and incorrect frame skipping, in cases when keyframes should be decoded. This commit works around this decoder limitation and marks I-frames and keyframes based on

Re: [FFmpeg-devel] [PATCH] avformat/dss: Remove superfluous headers

2019-10-29 Thread Michael Niedermayer
On Sat, Oct 26, 2019 at 06:59:57AM +0200, Andreas Rheinhardt wrote: > Both attributes.h and bswap.h have been included from the very beginning > of this muxer without there being any reason to do so. > > Signed-off-by: Andreas Rheinhardt > --- > The earlier mail claimed this to be about

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/libvorbisdec: Fix insufficient input checks leading to out of array reads

2019-10-29 Thread Michael Niedermayer
On Sun, Oct 27, 2019 at 01:15:47AM +0200, Michael Niedermayer wrote: > Fixes: > 16144/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LIBVORBIS_fuzzer-5638618940440576 > Fixes: out of array read > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/g723_1dec: fix invalid shift with negative sid_gain

2019-10-29 Thread Michael Niedermayer
On Sun, Oct 27, 2019 at 12:55:32PM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Breaking DRM is a little like attempting to break through a door even though the window is wide open and the only thing in the

Re: [FFmpeg-devel] [PATCH v2] avfilter/asrc_anoisesrc: change color variable to int

2019-10-29 Thread Michael Niedermayer
On Sat, Oct 26, 2019 at 03:34:04PM +0200, Paul B Mahol wrote: > OK will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Awnsering whenever a program halts or runs forever is On a turing machine, in general impossible (turings halting problem). On any

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/apedec: Only clear the needed buffer space, instead of all

2019-10-29 Thread Michael Niedermayer
On Mon, Oct 28, 2019 at 07:22:31PM +0100, Paul B Mahol wrote: > probably ok will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Elect your leaders based on what they did after the last election, not based on what they say before an election.

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/adpcm: Fix invalid shifts in ADPCM DTK

2019-10-29 Thread Michael Niedermayer
On Mon, Oct 28, 2019 at 07:21:42PM +0100, Paul B Mahol wrote: > Trivial change, LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Awnsering whenever a program halts or runs forever is On a turing machine, in general impossible (turings

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/wmalosslessdec: Fix some integer anomalies

2019-10-29 Thread Michael Niedermayer
On Mon, Oct 28, 2019 at 07:22:11PM +0100, Paul B Mahol wrote: > Trivial change, LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is what and why we do it that matters, not just one of them. signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] avfilter: remove useless cast

2019-10-29 Thread Paul B Mahol
On 10/29/19, Michael Niedermayer wrote: > On Mon, Oct 28, 2019 at 11:18:04AM +0800, myp...@gmail.com wrote: >> On Mon, Oct 28, 2019 at 12:03 AM Zhao Zhili >> wrote: >> > >> > --- >> > libavfilter/allfilters.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git

Re: [FFmpeg-devel] [PATCH] avfilter: remove useless cast

2019-10-29 Thread Michael Niedermayer
On Mon, Oct 28, 2019 at 11:18:04AM +0800, myp...@gmail.com wrote: > On Mon, Oct 28, 2019 at 12:03 AM Zhao Zhili wrote: > > > > --- > > libavfilter/allfilters.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavfilter/allfilters.c b/libavfilter/allfilters.c > >

Re: [FFmpeg-devel] [PATCH]Avoid duplicating Closed Captions when increasing frame rate

2019-10-29 Thread Paul B Mahol
On 11/27/18, Carl Eugen Hoyos wrote: > 2018-11-23 19:03 GMT+01:00, Carl Eugen Hoyos : > >> Attached patches fix Closed Captions when increasing frame rate, both >> with "-r" and the fps filter, fixes ticket #7506. > > Patches applied. > Please revert your incorrect change. You clone frame but

Re: [FFmpeg-devel] [PATCH 1/1] Slightly update nvenc error messages and warnings

2019-10-29 Thread Timo Rothenpieler
Good oh. Thank you. "No capable devices found" is briefer, I wonder whether it works for a confused user like me :) I suppose it would, given it would be in combination the other message expanded as "Multiple reference frames are not supported by the device". On that note, I suppose some or

Re: [FFmpeg-devel] [PATCH] avformat/utils: fix logic failure

2019-10-29 Thread Paul B Mahol
On 10/29/19, Michael Niedermayer wrote: > On Tue, Oct 29, 2019 at 10:45:20AM +0100, Paul B Mahol wrote: >> Fixes decoding of wav file which is wrongly recognized as mp1 audio. >> >> Signed-off-by: Paul B Mahol >> --- >> libavformat/utils.c | 2 +- >> 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: check denominator values in tiff_decode_tag()

2019-10-29 Thread Michael Niedermayer
On Sun, Oct 27, 2019 at 10:26:45AM -0300, James Almer wrote: > Fixes ticket #8327. > > Signed-off-by: James Almer > --- > The first case may be for either black level or SAR, so i decided to use a > generic error message. > > libavcodec/tiff.c | 9 + > 1 file changed, 9 insertions(+)

Re: [FFmpeg-devel] [PATCH] libavformat/flacenc: reject too big picture blocks

2019-10-29 Thread Michael Niedermayer
On Sun, Oct 27, 2019 at 10:06:11PM +0100, Mattias Wadman wrote: > Think i messed up the formatting of the in-line patch somehow. Ill send the > patch as an attachment instead. Hope reply and attach is ok? > > On Sun, Oct 27, 2019 at 8:22 PM Mattias Wadman > wrote: > > > A too big picture will

Re: [FFmpeg-devel] [PATCH] avformat/utils: fix logic failure

2019-10-29 Thread Michael Niedermayer
On Tue, Oct 29, 2019 at 10:45:20AM +0100, Paul B Mahol wrote: > Fixes decoding of wav file which is wrongly recognized as mp1 audio. > > Signed-off-by: Paul B Mahol > --- > libavformat/utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/utils.c

Re: [FFmpeg-devel] [PATCH] examples: set GOP size to 10 seconds

2019-10-29 Thread Steven Liu
Alfred E. Heggestad 于2019年10月29日周二 下午6:08写道: > > On 29/10/2019 10:34, Steven Liu wrote: > > > > > >> 在 2019年10月29日,17:25,Alfred E. Heggestad 写道: > >> > >> using a gop_size of 10 in the example code is very misleading. > >> in practice this means around 2 keyframes per second. > >> > >> a normal

Re: [FFmpeg-devel] [PATCH] examples: set GOP size to 10 seconds

2019-10-29 Thread Alfred E. Heggestad
On 29/10/2019 10:34, Steven Liu wrote: 在 2019年10月29日,17:25,Alfred E. Heggestad 写道: using a gop_size of 10 in the example code is very misleading. in practice this means around 2 keyframes per second. a normal video encoder should not send keyframes so frequent, a better interval is 10

[FFmpeg-devel] [PATCH] avformat/utils: fix logic failure

2019-10-29 Thread Paul B Mahol
Fixes decoding of wav file which is wrongly recognized as mp1 audio. Signed-off-by: Paul B Mahol --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index cfb6d03397..bf27531ed0 100644 --- a/libavformat/utils.c

Re: [FFmpeg-devel] [PATCH] examples: set GOP size to 10 seconds

2019-10-29 Thread Steven Liu
> 在 2019年10月29日,17:25,Alfred E. Heggestad 写道: > > using a gop_size of 10 in the example code is very misleading. > in practice this means around 2 keyframes per second. > > a normal video encoder should not send keyframes so frequent, > a better interval is 10 seconds. 10 seconds is too

[FFmpeg-devel] [PATCH] examples: set GOP size to 10 seconds

2019-10-29 Thread Alfred E. Heggestad
using a gop_size of 10 in the example code is very misleading. in practice this means around 2 keyframes per second. a normal video encoder should not send keyframes so frequent, a better interval is 10 seconds. Signed-off-by: Alfred E. Heggestad --- doc/examples/encode_video.c | 4 ++-- 1

Re: [FFmpeg-devel] Reimbursement request

2019-10-29 Thread Paul B Mahol
On 10/29/19, Steven Liu wrote: > Hi, > I'm requesting the reimbursement of travel expenses for the Google Mentor > Summit. > I mentored the Derain project, more details can be found in [1]. > > > Flight (CNY) ¥ 7062.00 > One night hotel (CNY) ¥ 632.00 > > Total (CNY) ¥

[FFmpeg-devel] Reimbursement request

2019-10-29 Thread Steven Liu
Hi, I'm requesting the reimbursement of travel expenses for the Google Mentor Summit. I mentored the Derain project, more details can be found in [1]. Flight (CNY) ¥ 7062.00 One night hotel (CNY) ¥ 632.00 Total (CNY) ¥ 7694.00 Total (USD) ≈$ 1089.54 CNY to USD