Re: [FFmpeg-devel] [PATCH v2 3/5] tests/fate/filter-video: add fate pixfmts test for lut1d and lut3d

2019-11-01 Thread Limin Wang
On Fri, Nov 01, 2019 at 01:56:06PM +0100, Michael Niedermayer wrote: > On Wed, Oct 30, 2019 at 09:20:54PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > tests/fate/filter-video.mak | 6 ++ > >

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-11-01 Thread Carl Eugen Hoyos
Am Do., 31. Okt. 2019 um 18:30 Uhr schrieb Dale Curtis : > > On Thu, Oct 31, 2019 at 1:32 AM Swaraj Hota wrote: > > > Yes I will send the patch soon for review. Still a few things left to do. > > > > Swaraj > > > > Great! Let me know if there's anything I can help with. Testing would be helpful.

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/v4l2_buffers: Fix infinite loop

2019-11-01 Thread Aman Gupta
On Fri, Nov 1, 2019 at 6:39 AM Andriy Gelman wrote: > On Sun, 27. Oct 00:19, Andriy Gelman wrote: > > From: Andriy Gelman > > > > This part of the code counts the number of planes returned by the v4l2 > > device for each queried capture/output buffer. > > When testing the GPU h264 encoder on

[FFmpeg-devel] [PATCH 1/5] configure: select jpegtables for rtp muxer

2019-11-01 Thread Lou Logan
Signed-off-by: Lou Logan --- Fixes: ./configure --disable-everything --enable-muxer=rtp && make /usr/bin/ld: libavformat/libavformat.a(rtpenc_jpeg.o): in function `ff_rtp_send_jpeg': libavformat/rtpenc_jpeg.c:116: undefined reference to `avpriv_mjpeg_bits_dc_chrominance' /usr/bin/ld:

[FFmpeg-devel] [PATCH 3/5] avformat/Makefile: add missing pcm dependency to hcom demuxer

2019-11-01 Thread Lou Logan
Signed-off-by: Lou Logan --- Fixes: ./configure --disable-everything --enable-demuxer=hcom && make /usr/bin/ld: libavformat/libavformat.a(hcom.o):(.data.rel+0x58): undefined reference to `ff_pcm_read_packet' --- libavformat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH 4/5] avformat/Makefile: add missing pcm dependency to nsp demuxer

2019-11-01 Thread Lou Logan
Signed-off-by: Lou Logan --- Fixes: ./configure --disable-everything --enable-demuxer=nsp && make /usr/bin/ld: libavformat/libavformat.a(nspdec.o):(.data.rel+0x58): undefined reference to `ff_pcm_read_packet' /usr/bin/ld: libavformat/libavformat.a(nspdec.o):(.data.rel+0x68): undefined

[FFmpeg-devel] [PATCH 5/5] avformat/Makefile: add missing pcm dependency to sdx demuxer

2019-11-01 Thread Lou Logan
Signed-off-by: Lou Logan --- Fixes: ./configure --disable-everything --enable-demuxer=sdx && make /usr/bin/ld: libavformat/libavformat.a(sdxdec.o):(.data.rel+0x58): undefined reference to `ff_pcm_read_packet' /usr/bin/ld: libavformat/libavformat.a(sdxdec.o):(.data.rel+0x68): undefined

[FFmpeg-devel] [PATCH 2/5] configure: select riffdec for act demuxer

2019-11-01 Thread Lou Logan
Signed-off-by: Lou Logan --- Fixes: ./configure --disable-everything --enable-demuxer=act && make /usr/bin/ld: libavformat/libavformat.a(act.o): in function `read_header': libavformat/act.c:78: undefined reference to `ff_get_wav_header' --- configure | 1 + 1 file changed, 1 insertion(+)

Re: [FFmpeg-devel] [PATCH] avfilter: add eval video filter

2019-11-01 Thread Paul B Mahol
On 11/1/19, Michael Niedermayer wrote: > On Fri, Nov 01, 2019 at 04:50:38PM +0100, Paul B Mahol wrote: >> On 11/1/19, Michael Niedermayer wrote: >> > On Fri, Nov 01, 2019 at 01:09:24PM +0100, Paul B Mahol wrote: >> >> Signed-off-by: Paul B Mahol >> >> --- >> >> doc/filters.texi | 78

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-11-01 Thread Dale Curtis
On Fri, Nov 1, 2019 at 4:14 AM Swaraj Hota wrote: > Sure. Thanks for the samples! > I have not currently tested the patch with avif format, was only focused on > heif. But as the only difference is the decoder (?), this support could be > easily added. I'll try to add it but as I have been

Re: [FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-11-01 Thread Paul B Mahol
On 11/1/19, Christopher Kennedy wrote: > On Wed, Oct 30, 2019 at 10:57 AM Paul B Mahol wrote: >> >> On 10/30/19, Christopher Kennedy wrote: >> > On Wed, Oct 30, 2019 at 10:07 AM Paul B Mahol wrote: >> >> >> >> On 10/30/19, Christopher Kennedy wrote: >> >> > On Sat, Oct 26, 2019 at 9:15 AM

Re: [FFmpeg-devel] [PATCH] avformat/nutenc: Do not pass NULL to memcmp() in get_needed_flags()

2019-11-01 Thread Andreas Rheinhardt
On Fri, Nov 1, 2019 at 1:32 PM Michael Niedermayer wrote: > On Fri, Nov 01, 2019 at 11:22:41AM +0100, Andreas Rheinhardt wrote: > > On Fri, Nov 1, 2019 at 10:42 AM Michael Niedermayer > > > wrote: > > > > > This compared to the other suggestions is cleaner and easer to > understand > > >

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/libvpxdec: reject video and alpha dimension mismatches

2019-11-01 Thread James Zern
On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote: > > Signed-off-by: Marton Balint > --- > libavcodec/libvpxdec.c | 11 +++ > 1 file changed, 11 insertions(+) > lgtm. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/libvpxdec: decode to custom framebuffers for vp9

2019-11-01 Thread James Zern
On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote: > > This avoids copying the full frame after decoding. > > Signed-off-by: Marton Balint > --- > libavcodec/libvpxdec.c | 73 > ++ > 1 file changed, 68 insertions(+), 5 deletions(-) > lgtm. >

Re: [FFmpeg-devel] [PATCH] avcodec/libtwolame: fix mono default bitrate

2019-11-01 Thread Moritz Barsnick
On Fri, Nov 01, 2019 at 08:51:07 +, James Cowgill wrote: > As of libtwolame 0.4.0, 384 kbps is not accepted as a valid bitrate > for encoding mono audio and the maximum bitrate is now halved to 192 > kbps to comply with the MP2 standard. Example error: I also just noticed this, after update

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/rv10: Check input for minimal frame size

2019-11-01 Thread Michael Niedermayer
On Wed, Oct 09, 2019 at 12:14:51PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (18sec -> 4sec) > Fixes: > 18012/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV20_fuzzer-5767486145822720 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/truemotion2: Fix several integer overflows with *Yo, *Uo, *Vo

2019-11-01 Thread Michael Niedermayer
On Sun, Oct 27, 2019 at 01:15:44AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 538976288 - -2080374792 cannot be represented > in type 'int' > Fixes: > 16196/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-5144044274974720 > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/truemotion2: Fix several integer overflows in tm2_low_res_block()

2019-11-01 Thread Michael Niedermayer
On Sun, Oct 27, 2019 at 01:15:45AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 1077952576 + 1355863565 cannot be represented > in type 'int' > Fixes: > 16196/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-5679842317565952 > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-11-01 Thread Christopher Kennedy
On Wed, Oct 30, 2019 at 10:57 AM Paul B Mahol wrote: > > On 10/30/19, Christopher Kennedy wrote: > > On Wed, Oct 30, 2019 at 10:07 AM Paul B Mahol wrote: > >> > >> On 10/30/19, Christopher Kennedy wrote: > >> > On Sat, Oct 26, 2019 at 9:15 AM Paul B Mahol wrote: > >> >> > >> >> On 10/26/19,

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/libvpxdec: make sure BlockAdditional side data size >= 8

2019-11-01 Thread James Zern
On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote: > > Signed-off-by: Marton Balint > --- > libavcodec/libvpxdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > lgtm. good catch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/libvpxdec: pass decoder instances to vpx_init directly

2019-11-01 Thread James Zern
On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote: > > If the alpha decoder init failed we presented the error message from the > normal > decoder. This change should prevent such mistakes. > > Signed-off-by: Marton Balint > --- > libavcodec/libvpxdec.c | 26 +- > 1

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/libvpxenc: fix alpha stride

2019-11-01 Thread James Zern
On Sun, Oct 27, 2019 at 10:10 AM Marton Balint wrote: > > Signed-off-by: Marton Balint > --- > libavcodec/libvpxenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > lgtm. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/libvpxenc: only allocate U/V planes once for the alpha encoder instance

2019-11-01 Thread James Zern
On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote: > > Signed-off-by: Marton Balint > --- > libavcodec/libvpxenc.c | 44 +++- > 1 file changed, 23 insertions(+), 21 deletions(-) > The encoder can handle frame size changes. This seems to assume the

Re: [FFmpeg-devel] [PATCH v2 1/5] swscale/swscale_unscaled: fix gbrap10be md5 different on big endian system

2019-11-01 Thread Michael Niedermayer
On Thu, Oct 31, 2019 at 11:12:56AM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The misfortune of the wise is better than the prosperity of the fool. -- Epicurus signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 1/1] libavformat/flacenc: reject too big picture blocks

2019-11-01 Thread Michael Niedermayer
On Wed, Oct 30, 2019 at 02:01:28PM +0100, Mattias Wadman wrote: > A too big picture will case the muxer to write a truncated block size (uint24) > causing the output file to be corrupt. > > How to reproduce: > > Write a file with truncated block size: > ffmpeg -y -f lavfi -i sine -f lavfi -i

Re: [FFmpeg-devel] [PATCH v2 4/5] avfilter/vf_lut3d: simplify code

2019-11-01 Thread Michael Niedermayer
On Wed, Oct 30, 2019 at 03:34:59PM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Opposition brings concord. Out of discord comes the fairest harmony. -- Heraclitus signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] avfilter: add eval video filter

2019-11-01 Thread Michael Niedermayer
On Fri, Nov 01, 2019 at 04:50:38PM +0100, Paul B Mahol wrote: > On 11/1/19, Michael Niedermayer wrote: > > On Fri, Nov 01, 2019 at 01:09:24PM +0100, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol > >> --- > >> doc/filters.texi | 78 + > >> libavfilter/Makefile | 1 + >

Re: [FFmpeg-devel] [PATCH v2] avformat: Add max_probe_packets option

2019-11-01 Thread Andriy Gelman
Michael, On Sat, 19. Oct 16:54, Michael Niedermayer wrote: > On Thu, Oct 17, 2019 at 10:49:20AM -0400, Andriy Gelman wrote: > > From: Andriy Gelman > > > > Allows user to set maximum number of buffered packets when > > probing a codec. It was a hard-coded parameter before this commit. > > --- >

Re: [FFmpeg-devel] [PATCH] sdl2: map AV_PIX_FMT_NONE to SDL_PIXELFORMAT_UNKNOWN

2019-11-01 Thread Marton Balint
On Wed, 30 Oct 2019, Alfred E. Heggestad wrote: This does not change the programs behaviour. The purpose of this patch is to make the code more robust against future changes, in case someone starts using the AV_PIX_FMT_NONE entry. PIX_FMT_NONE signals the end of the array, whatever it maps

Re: [FFmpeg-devel] [PATCH v2 1/4] frame: handle add side data with the same type

2019-11-01 Thread Marton Balint
On Sat, 2 Nov 2019, Zhao Zhili wrote: On Nov 2, 2019, at 1:16 AM, Marton Balint wrote: On Fri, 1 Nov 2019, "zhilizhao(赵志立)" wrote: On Nov 1, 2019, at 8:13 PM, Hendrik Leppkes wrote: On Fri, Nov 1, 2019 at 1:03 PM wrote: From: Zhao Zhili --- libavutil/frame.c | 13 +

Re: [FFmpeg-devel] [PATCH v2 1/4] frame: handle add side data with the same type

2019-11-01 Thread Zhao Zhili
> On Nov 2, 2019, at 1:16 AM, Marton Balint wrote: > > > > On Fri, 1 Nov 2019, "zhilizhao(赵志立)" wrote: > >> >> >>> On Nov 1, 2019, at 8:13 PM, Hendrik Leppkes wrote: >>> On Fri, Nov 1, 2019 at 1:03 PM wrote: From: Zhao Zhili --- libavutil/frame.c | 13 +

Re: [FFmpeg-devel] [PATCH v2 1/4] frame: handle add side data with the same type

2019-11-01 Thread Marton Balint
On Fri, 1 Nov 2019, "zhilizhao(赵志立)" wrote: On Nov 1, 2019, at 8:13 PM, Hendrik Leppkes wrote: On Fri, Nov 1, 2019 at 1:03 PM wrote: From: Zhao Zhili --- libavutil/frame.c | 13 + libavutil/frame.h | 4 2 files changed, 17 insertions(+) I believe there have been

Re: [FFmpeg-devel] [PATCH] avformat/segment: fix cuttting for non-zero start pts

2019-11-01 Thread Marton Balint
On Thu, 31 Oct 2019, Vasily wrote: Hi Marton, Please use a proper commit title: e.g: avformat/segment: fix non-zero start pts Also make sure you provide the author name you want when you send the patch email. (you only provided an email address in the From field, not a full name, I guess

Re: [FFmpeg-devel] [PATCH] avfilter: add eval video filter

2019-11-01 Thread Paul B Mahol
On 11/1/19, Michael Niedermayer wrote: > On Fri, Nov 01, 2019 at 01:09:24PM +0100, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 78 + >> libavfilter/Makefile | 1 + >> libavfilter/allfilters.c | 1 + >> libavfilter/vf_eval.c| 687

Re: [FFmpeg-devel] [PATCH] avfilter: add eval video filter

2019-11-01 Thread Michael Niedermayer
On Fri, Nov 01, 2019 at 01:09:24PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 78 + > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_eval.c| 687 +++ > 4 files

Re: [FFmpeg-devel] [PATCH 3/8] avcodec/utils: Check block_align

2019-11-01 Thread Michael Niedermayer
On Fri, Nov 01, 2019 at 09:26:52AM +0100, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "Nothing to hide" only works if the folks in power share the values of you and everyone you know entirely and always will -- Tom

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/v4l2_buffers: Fix infinite loop

2019-11-01 Thread Andriy Gelman
On Sun, 27. Oct 00:19, Andriy Gelman wrote: > From: Andriy Gelman > > This part of the code counts the number of planes returned by the v4l2 > device for each queried capture/output buffer. > When testing the GPU h264 encoder on Nvidia's Jetson Nano, this caused an > infinite loop because

Re: [FFmpeg-devel] [PATCH] lavc/qsv: improve the default GPU memory usage

2019-11-01 Thread Max Dmitrichenko
On Fri, Nov 1, 2019 at 11:20 AM Zhong Li wrote: > > A large initial_pool_size leads to redundant GPU memory allocations > > compared with MSDK. > > > > For some special cases which needs larger GPU memory like look_ahead, > > add -extra_hw_frames to allocate more. > > > > CMD: > > ffmpeg

Re: [FFmpeg-devel] [PATCH v2 3/5] tests/fate/filter-video: add fate pixfmts test for lut1d and lut3d

2019-11-01 Thread Michael Niedermayer
On Wed, Oct 30, 2019 at 09:20:54PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > tests/fate/filter-video.mak | 6 ++ > tests/ref/fate/filter-pixfmts-lut1d | 24 > tests/ref/fate/filter-pixfmts-lut3d | 24

Re: [FFmpeg-devel] [PATCH] avcodec/libtwolame: fix mono default bitrate

2019-11-01 Thread Paul B Mahol
applied On 11/1/19, James Cowgill wrote: > As of libtwolame 0.4.0, 384 kbps is not accepted as a valid bitrate > for encoding mono audio and the maximum bitrate is now halved to 192 > kbps to comply with the MP2 standard. Example error: > > twolame_init_params(): 384kbps is an invalid

Re: [FFmpeg-devel] [PATCH v2 1/4] frame: handle add side data with the same type

2019-11-01 Thread zhilizhao(赵志立)
> On Nov 1, 2019, at 8:13 PM, Hendrik Leppkes wrote: > > On Fri, Nov 1, 2019 at 1:03 PM wrote: >> >> From: Zhao Zhili >> >> --- >> libavutil/frame.c | 13 + >> libavutil/frame.h | 4 >> 2 files changed, 17 insertions(+) >> > > I believe there have been some use-cases,

Re: [FFmpeg-devel] Reimbursement request

2019-11-01 Thread Stefano Sabatini
On date Wednesday 2019-10-30 21:25:24 +0100, Carl Eugen Hoyos wrote: > Hi! > > I am requesting reimbursement for my travel to the Google mentor summit. > My total travelling expenses were € 90,90 LGTM, please fill the form here: https://www.spi-inc.org/treasurer/reimbursement-form/ and send it

Re: [FFmpeg-devel] [PATCH 1/1] avformat/mpegenc.c: vbvsize option

2019-11-01 Thread Michael Niedermayer
On Thu, Oct 31, 2019 at 06:04:58PM +0100, Nicolas Gaullier wrote: > Allow the user to set or override the vbv size > --- > libavformat/mpegenc.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavformat/mpegenc.c b/libavformat/mpegenc.c > index

[FFmpeg-devel] [PATCH] avformat/nutenc: Do not pass NULL to memcmp() in get_needed_flags()

2019-11-01 Thread Michael Niedermayer
This compared to the other suggestions is cleaner and easier to understand keeping the condition in the if() simple. This affects alot of fate tests. See: [FFmpeg-devel] [PATCH 05/11] avformat/nutenc: Don't pass NULL to memcmp See: [FFmpeg-devel] [PATCH]lavf/nutenc: Do not call memcmp() with

Re: [FFmpeg-devel] [PATCH] avformat/nutenc: Do not pass NULL to memcmp() in get_needed_flags()

2019-11-01 Thread Michael Niedermayer
On Fri, Nov 01, 2019 at 11:22:41AM +0100, Andreas Rheinhardt wrote: > On Fri, Nov 1, 2019 at 10:42 AM Michael Niedermayer > wrote: > > > This compared to the other suggestions is cleaner and easer to understand > > keeping the condition in the if() simple > > > > See: [FFmpeg-devel] [PATCH]

Re: [FFmpeg-devel] [PATCH v2 1/4] frame: handle add side data with the same type

2019-11-01 Thread Hendrik Leppkes
On Fri, Nov 1, 2019 at 1:03 PM wrote: > > From: Zhao Zhili > > --- > libavutil/frame.c | 13 + > libavutil/frame.h | 4 > 2 files changed, 17 insertions(+) > I believe there have been some use-cases, especially around closed-captions, where multiple blocks of the same type

[FFmpeg-devel] [PATCH] avfilter: add eval video filter

2019-11-01 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 78 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_eval.c| 687 +++ 4 files changed, 767 insertions(+) create mode 100644 libavfilter/vf_eval.c diff

[FFmpeg-devel] [PATCH v2 4/4] avcodec/avcodec.h: document add/new_side_data with the same type

2019-11-01 Thread quinkblack
From: Zhao Zhili --- libavcodec/avcodec.h | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index bcb931f0dd..84dcf52285 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -4486,6 +4486,8 @@ void av_free_packet(AVPacket *pkt); /**

[FFmpeg-devel] [PATCH v2 2/4] frame: make av_frame_remove_side_data return early

2019-11-01 Thread quinkblack
From: Zhao Zhili --- libavutil/frame.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index bb20e99331..9edf971c55 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -825,6 +825,7 @@ void av_frame_remove_side_data(AVFrame *frame, enum

[FFmpeg-devel] [PATCH v2 1/4] frame: handle add side data with the same type

2019-11-01 Thread quinkblack
From: Zhao Zhili --- libavutil/frame.c | 13 + libavutil/frame.h | 4 2 files changed, 17 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index dcf1fc3d17..bb20e99331 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -692,10 +692,23 @@ AVFrameSideData

[FFmpeg-devel] [PATCH v2 3/4] avformat/avformat.h: document add/new_side_data with the same type

2019-11-01 Thread quinkblack
From: Zhao Zhili --- libavformat/avformat.h | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 6eb329f13f..acce242398 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -2162,6 +2162,8 @@ AVStream

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-11-01 Thread Swaraj Hota
On Thu, Oct 31, 2019, 11:00 PM Dale Curtis wrote: > On Thu, Oct 31, 2019 at 1:32 AM Swaraj Hota > wrote: > > > Yes I will send the patch soon for review. Still a few things left to do. > > > > Swaraj > > > > Great! Let me know if there's anything I can help with. If you need some > AVIF samples

Re: [FFmpeg-devel] [PATCH 1/2] frame: handle add side data with the same type

2019-11-01 Thread Marton Balint
On Fri, 1 Nov 2019, "zhilizhao(赵志立)" wrote: Ping for review, thanks! You should update the documentation for the function, that it replaces existing side data of the same type. You should also make sure it works as it is documented now: on failure, the frame is unchanged. Regards,

Re: [FFmpeg-devel] [PATCH] avformat/nutenc: Do not pass NULL to memcmp() in get_needed_flags()

2019-11-01 Thread Andreas Rheinhardt
On Fri, Nov 1, 2019 at 10:42 AM Michael Niedermayer wrote: > This compared to the other suggestions is cleaner and easer to understand > keeping the condition in the if() simple > > See: [FFmpeg-devel] [PATCH] avformat/nutenc: Fix memleak > See: [FFmpeg-devel] [PATCH]lavf/nutenc: Do not call

Re: [FFmpeg-devel] [PATCH] lavc/qsv: improve the default GPU memory usage

2019-11-01 Thread Zhong Li
> A large initial_pool_size leads to redundant GPU memory allocations > compared with MSDK. > > For some special cases which needs larger GPU memory like look_ahead, > add -extra_hw_frames to allocate more. > > CMD: > ffmpeg -hwaccel qsv -extra_hw_frames 50 -c:v hevc_qsv -i hevc.h265 -c:v >

Re: [FFmpeg-devel] [PATCH 1/2] frame: handle add side data with the same type

2019-11-01 Thread zhilizhao(赵志立)
Ping for review, thanks! > On Oct 25, 2019, at 1:00 PM, quinkbl...@foxmail.com wrote: > > From: Zhao Zhili > > --- > libavutil/frame.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/libavutil/frame.c b/libavutil/frame.c > index dcf1fc3d17..bb20e99331 100644 > ---

[FFmpeg-devel] [PATCH] avformat/nutenc: Do not pass NULL to memcmp() in get_needed_flags()

2019-11-01 Thread Michael Niedermayer
This compared to the other suggestions is cleaner and easer to understand keeping the condition in the if() simple See: [FFmpeg-devel] [PATCH] avformat/nutenc: Fix memleak See: [FFmpeg-devel] [PATCH]lavf/nutenc: Do not call memcmp() with NULL argument Fixes: Ticket 7980 Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH] doc/filters: fix overlay_opencl document typo

2019-11-01 Thread Steven Liu
> 在 2019年11月1日,17:10,Gyan 写道: > > > > On 01-11-2019 02:15 PM, Steven Liu wrote: >> Reported-by: Yabo Wei >> Signed-off-by: Steven Liu >> --- >> doc/filters.texi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/doc/filters.texi b/doc/filters.texi >> index

Re: [FFmpeg-devel] [PATCH 05/11] avformat/nutenc: Don't pass NULL to memcmp

2019-11-01 Thread Michael Niedermayer
On Thu, Oct 31, 2019 at 07:38:00AM +, Andreas Rheinhardt wrote: > Andreas Rheinhardt: > > Carl Eugen Hoyos: > >> Am Fr., 20. Sept. 2019 um 00:30 Uhr schrieb Andreas Rheinhardt > >> : > >>> > >>> Fixes lots of FATE tests, e.g. lavf-nut, as well as the nut part of > >>> ticket #7980. > >>> > >>>

Re: [FFmpeg-devel] [PATCH] doc/filters: fix overlay_opencl document typo

2019-11-01 Thread Gyan
On 01-11-2019 02:15 PM, Steven Liu wrote: Reported-by: Yabo Wei Signed-off-by: Steven Liu --- doc/filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 9d387be1f5..a6ff5037a6 100644 --- a/doc/filters.texi +++

[FFmpeg-devel] [PATCH] avcodec/libtwolame: fix mono default bitrate

2019-11-01 Thread James Cowgill
As of libtwolame 0.4.0, 384 kbps is not accepted as a valid bitrate for encoding mono audio and the maximum bitrate is now halved to 192 kbps to comply with the MP2 standard. Example error: twolame_init_params(): 384kbps is an invalid bitrate for mono encoding. Adjust the default bitrate

[FFmpeg-devel] [PATCH] doc/filters: fix overlay_opencl document typo

2019-11-01 Thread Steven Liu
Reported-by: Yabo Wei Signed-off-by: Steven Liu --- doc/filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 9d387be1f5..a6ff5037a6 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -20503,7 +20503,7 @@ Set the x

Re: [FFmpeg-devel] [PATCH 3/8] avcodec/utils: Check block_align

2019-11-01 Thread Paul B Mahol
LGTM On 10/31/19, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 18432/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMAV2_fuzzer-5675574936207360 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: