On 11/10/2019 10:21 PM, Derek Buitenhuis wrote:
> On 11/11/2019 01:19, James Almer wrote:
>> Fixes leaks.
>>
>> Signed-off-by: James Almer
>> ---
>> Missed this detail when reviewing. It's a remnant of the version where the
>> RaPacket was attached to the AVPacket.
>
> Woops, yeah. I remember /th
On 11/11/2019 01:19, James Almer wrote:
> Fixes leaks.
>
> Signed-off-by: James Almer
> ---
> Missed this detail when reviewing. It's a remnant of the version where the
> RaPacket was attached to the AVPacket.
Woops, yeah. I remember /thinking/ I needed too and then forgot.
LGTM.
- Derek
_
Fixes leaks.
Signed-off-by: James Almer
---
Missed this detail when reviewing. It's a remnant of the version where the
RaPacket was attached to the AVPacket.
libavcodec/librav1e.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c
This will likely also fix CID 1452589 and 1452460, false positives
resulting from Coverity thinking that av_dict_set() automatically
frees its key and value parameters (even without the
AV_DICT_DONT_STRDUP_* flags).
Signed-off-by: Andreas Rheinhardt
---
libavformat/mpegts.c | 18 +---
This will likely also fix CID 1452427, a false positive resulting from
Coverity thinking that av_dict_set() automatically frees its key and
value parameters (even without the AV_DICT_DONT_STRDUP_* flags).
(AV_DICT_APPEND and AV_DICT_DONT_STRDUP_VAL are compatible with each
other since a8c5b455, so
If a key already exists in an AVDictionary and the AV_DICT_APPEND flag
is set, the old entry is at first discarded from the dictionary, but
a pointer to the value is kept. Lateron enough memory to store the
appended string is allocated; should this allocation fail, the old string
is not freed and h
From: Limin Wang
Signed-off-by: Limin Wang
---
Note, the patchset are changed after applied mp3 probe fix patchset:
https://patchwork.ffmpeg.org/patch/16158/
libavformat/mp3dec.c | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/liba
From: Limin Wang
mp3 header bitstream syntax:
header()
{
syncword 12bits bslsf
id 1bitbslsf
layer 2bitbslsf
protection_bit 1bit bslsf
bitrate_index 4bits bslsf
sampling_frequency 2bits bslsf
padding_bit 1bit bslsf
private_bit 1bit bslsf
> Am 11.11.2019 um 04:42 schrieb Andriy Gelman :
>
> +/* check configured pix_fmt matches avctx->pix_fmt */
Is this comment really useful?
> +pix_fmt_output = ff_v4l2_format_v4l2_to_avfmt(v4l2_fmt_output,
> AV_CODEC_ID_RAWVIDEO);
> +if (pix_fmt_output != avctx->pix_fmt) {
> +
On Tue, 05. Nov 09:25, Andriy Gelman wrote:
> On Wed, 30. Oct 09:45, Andriy Gelman wrote:
> > On Thu, 24. Oct 20:50, Andriy Gelman wrote:
> > > On Tue, 15. Oct 22:50, Andriy Gelman wrote:
> > > > From: Andriy Gelman
> > > >
> > > > Fixes #7799
> > > >
> > > > Currently, the mp4toannexb filter al
From: Andriy Gelman
Fixes #8079
During initialization of a v4l2m2m device, the configured pix_fmt can be
different to the pix_fmt of the encoder (i.e. avctx->pix_fmt).
For example on the Odroid XU4:
./ffmpeg -f lavfi -i yuvtestsrc -codec:v h264_v4l2m2m out.h264
will configure the v4l2 encoder
On Sun, 3 Nov 2019, Zhao Zhili wrote:
remove_side_data is supposed to remove a single instance by design.
Since new_side_data() doesn't forbid add multiple instances of the
same type, remove_side_data should deal with that.
---
I'm afraid this patch makes it harder to enforce single entry per
Signed-off-by: Andreas Rheinhardt
---
libavformat/id3v2.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c
index e9843eef9a..abe073dcc1 100644
--- a/libavformat/id3v2.c
+++ b/libavformat/id3v2.c
@@ -361,8 +361,8 @@ static
On 09/11/2019 22:32, James Almer wrote:
> LGTM. Don't forget to add a line to Changelog and bump lavc minor before
> pushing.
Done and pushed. Thanks!
- Derek
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmp
On 11/10/19, Vittorio Giovara wrote:
> On Mon, Oct 28, 2019 at 10:48 PM Paul B Mahol wrote:
>
>> The new API is more extensible and allows for custom layouts.
>> More accurate information is exported, eg for decoders that do not
>> set a channel layout, lavc will not make one up for them.
>>
>> D
On Mon, Oct 28, 2019 at 10:48 PM Paul B Mahol wrote:
> The new API is more extensible and allows for custom layouts.
> More accurate information is exported, eg for decoders that do not
> set a channel layout, lavc will not make one up for them.
>
> Deprecate the old API working with just uint64_
16 matches
Mail list logo
