[FFmpeg-devel] [PATCHv2] fate: Use a oneoff test for the tremolo filter

2019-12-10 Thread Martin Storsjö
The tremolo filter uses floating point internally, and uses multiplication factors derived from sin(fmod()), neither of which is bitexact for use with framecrc. This fixes running this test with mingw/x86_32 binaries when run in wine on linux (unsure if the same issue is present when run on

Re: [FFmpeg-devel] [PATCH] fate: Use a oneoff test for the tremolo filter

2019-12-10 Thread Martin Storsjö
On Tue, 10 Dec 2019, James Almer wrote: On 12/10/2019 5:11 PM, Martin Storsjö wrote: The tremolo filter uses floating point internally, and uses multiplication factors derived from sin(fmod()), neither of which is bitexact for use with framecrc. This fixes running this test with mingw/x86_32

Re: [FFmpeg-devel] [PATCH v2] avcodec/cbs_av1: avoid reading trailing bits when obu type is OBU_TILE_LIST

2019-12-10 Thread Wang, Fei W
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Wednesday, December 11, 2019 10:41 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/cbs_av1: avoid reading > trailing bits when obu type is OBU_TILE_LIST > > On 12/10/2019

Re: [FFmpeg-devel] [PATCH] avfilter/scale_eval: remove redundant mathematical constants

2019-12-10 Thread Gyan
On 10-12-2019 07:30 pm, Gyan wrote: Regards, Gyan Will push soon. Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH v2] avcodec/cbs_av1: avoid reading trailing bits when obu type is OBU_TILE_LIST

2019-12-10 Thread James Almer
On 12/10/2019 10:37 PM, Fei Wang wrote: > Signed-off-by: Fei Wang > --- > libavcodec/cbs_av1.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c > index bbe4461130..ab006f4d11 100644 > --- a/libavcodec/cbs_av1.c > +++ b/libavcodec/cbs_av1.c >

Re: [FFmpeg-devel] [PATCH v2] avcodec/cbs_av1: rename enable_intraintra_compound flag

2019-12-10 Thread Wang, Fei W
> -Original Message- > From: ffmpeg-devel On Behalf Of Fei > Wang > Sent: Wednesday, December 11, 2019 9:55 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Wang, Fei W > Subject: [FFmpeg-devel] [PATCH v2] avcodec/cbs_av1: rename > enable_intraintra_compound flag > > rename

[FFmpeg-devel] [PATCH V2 2/2] lavf/tls_openssl: support both pre-1.1.0 and post-1.1.0 init

2019-12-10 Thread Jun Zhao
From: Jun Zhao supporting both pre-1.1.0 and post-1.1.0 version of the OpenSSL library as the link: https://wiki.openssl.org/index.php/Library_Initialization Signed-off-by: Jun Zhao --- libavformat/tls_openssl.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git

[FFmpeg-devel] [PATCH V2 1/2] configure: add OPENSSL_init_ssl check if pkg-config fail

2019-12-10 Thread Jun Zhao
From: macweng fix when pkg-config fail and openssl > 1.1.0 --enable-openssl fail, the root cause is check_lib can't found the SSL_library_init(). Signed-off-by: macweng --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index

[FFmpeg-devel] [PATCH v2] avcodec/cbs_av1: rename enable_intraintra_compound flag

2019-12-10 Thread Fei Wang
rename enable_intraintra_compound to enable_interintra_compound, which keep same as AV1 sepc(v1.0.0-errata1). Signed-off-by: Fei Wang --- libavcodec/cbs_av1.h | 2 +- libavcodec/cbs_av1_syntax_template.c | 4 ++-- libavformat/av1.c| 2 +- 3 files changed, 4

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: avoid reading trailing bits when obu type is OBU_TILE_LIST

2019-12-10 Thread Wang, Fei W
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Wednesday, December 11, 2019 1:11 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: avoid reading trailing > bits when obu type is OBU_TILE_LIST > > On 12/10/2019 6:01 AM,

[FFmpeg-devel] [PATCH v2] avcodec/cbs_av1: avoid reading trailing bits when obu type is OBU_TILE_LIST

2019-12-10 Thread Fei Wang
Signed-off-by: Fei Wang --- libavcodec/cbs_av1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c index bbe4461130..ab006f4d11 100644 --- a/libavcodec/cbs_av1.c +++ b/libavcodec/cbs_av1.c @@ -1039,6 +1039,7 @@ static int

Re: [FFmpeg-devel] [PATCH V1 2/2] lavf/tls_openssl: support both pre-1.1.0 and post-1.1.0 init

2019-12-10 Thread myp...@gmail.com
On Wed, Dec 11, 2019 at 3:47 AM James Almer wrote: > > On 12/10/2019 11:02 AM, Jun Zhao wrote: > > From: Jun Zhao > > > > supporting both pre-1.1.0 and post-1.1.0 version of the OpenSSL > > library as the link: > > https://wiki.openssl.org/index.php/Library_Initialization > > > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH v3] avfilter: Add tonemap vaapi filter for H2S

2019-12-10 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel On Behalf Of > Vittorio Giovara > Sent: Tuesday, December 3, 2019 2:28 AM > To: FFmpeg development discussions and patches > Cc: Sun, Xinpeng ; Zhou, Zachary > > Subject: Re: [FFmpeg-devel] [PATCH v3] avfilter: Add tonemap vaapi filter for > H2S

Re: [FFmpeg-devel] [PATCH] fate: Use a oneoff test for the tremolo filter

2019-12-10 Thread James Almer
On 12/10/2019 5:11 PM, Martin Storsjö wrote: > The tremolo filter uses floating point internally, and uses > multiplication factors derived from sin(fmod()), neither of > which is bitexact for use with framecrc. > > This fixes running this test with mingw/x86_32 binaries when run > in wine on

Re: [FFmpeg-devel] [PATCH] fate: Add an option for disabling the 4k tests

2019-12-10 Thread James Almer
On 12/10/2019 7:46 PM, Michael Niedermayer wrote: > On Tue, Dec 10, 2019 at 10:12:24PM +0200, Martin Storsjö wrote: >> When testing on a memory limited system, these tests consume a >> significant amount of memory and can often fail if testing by running >> multiple processes in parallel. >> ---

Re: [FFmpeg-devel] [PATCH] fate: Add an option for disabling the 4k tests

2019-12-10 Thread Michael Niedermayer
On Tue, Dec 10, 2019 at 10:12:24PM +0200, Martin Storsjö wrote: > When testing on a memory limited system, these tests consume a > significant amount of memory and can often fail if testing by running > multiple processes in parallel. > --- > configure | 3 +++ > tests/fate/seek.mak

[FFmpeg-devel] [aarch64] improve performance of ff_yuv2planeX_8_neon

2019-12-10 Thread Sebastian Pop
Hi, This patch rewrites the innermost loop of ff_yuv2planeX_8_neon to avoid zips and horizontal adds by using fused multiply adds. The patch also uses ld1r to load one element and replicate it across all lanes of the vector. The patch also improves the clipping code by removing the shift right

Re: [FFmpeg-devel] [PATCH 04/11] avformat/apngdec: Return error when header incomplete

2019-12-10 Thread James Almer
On 12/10/2019 6:59 PM, Andreas Rheinhardt wrote: > When an incomplete header is encountered, apng_read_header would under > certain circumstances only return the return value of the last > successfull call. So override this by returning AVERROR_EOF manually. > > Signed-off-by: Andreas Rheinhardt

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/cbs: Check for overflow when reading

2019-12-10 Thread Andriy Gelman
On Mon, 09. Dec 23:25, Andreas Rheinhardt wrote: > While CBS itself uses size_t for sizes, it relies on other APIs that use > int for their sizes; in particular, AVBuffer uses int for their size > parameters and so does GetBitContext with their number of bits. While > CBS aims to be a safe API,

[FFmpeg-devel] [PATCH 11/11] avcodec/avcodec: Nits

2019-12-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/avcodec.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 735a3c2d76..ab61f76337 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -4848,7 +4848,7 @@ int

[FFmpeg-devel] [PATCH 07/11] avformat/rtpdec_qt: Remove unnecessary AVPacket

2019-12-10 Thread Andreas Rheinhardt
rtpdec_qt contains an AVPacket inside its context. But actually only three fields of said packet were actually used: data, size and flags. E.g. av_init_packet() effectively only reset the flags. This has been changed: Only fields for the three elements that are actually used are kept; the actual

[FFmpeg-devel] [PATCH 08/11] avformat/rtpdec_hevc: Don't reimplement ff_alloc_extradata

2019-12-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/rtpdec_hevc.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/libavformat/rtpdec_hevc.c b/libavformat/rtpdec_hevc.c index 5a06b2362c..f467104ca5 100644 --- a/libavformat/rtpdec_hevc.c +++

[FFmpeg-devel] [PATCH 06/11] avformat/rtpdec_xiph: Don't add padding twice

2019-12-10 Thread Andreas Rheinhardt
ff_alloc_extradata already adds padding to extradata. Signed-off-by: Andreas Rheinhardt --- libavformat/rtpdec_xiph.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/rtpdec_xiph.c b/libavformat/rtpdec_xiph.c index 574508affb..1bd48fa562 100644 ---

[FFmpeg-devel] [PATCH 04/11] avformat/apngdec: Return error when header incomplete

2019-12-10 Thread Andreas Rheinhardt
When an incomplete header is encountered, apng_read_header would under certain circumstances only return the return value of the last successfull call. So override this by returning AVERROR_EOF manually. Signed-off-by: Andreas Rheinhardt --- libavformat/apngdec.c | 2 ++ 1 file changed, 2

[FFmpeg-devel] [PATCH 09/11] avformat: Forward errors where possible

2019-12-10 Thread Andreas Rheinhardt
It is not uncommon to find code where the caller thinks to know better what the return value should be than the callee. E.g. something like "if (av_new_packet(pkt, size) < 0) return AVERROR(ENOMEM);". This commit changes several instances of this to instead forward the actual error.

[FFmpeg-devel] [PATCH 05/11] avformat/apngdec: Remove goto fail that does nothing

2019-12-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/apngdec.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/libavformat/apngdec.c b/libavformat/apngdec.c index 6c58fd9d04..f66432f2d6 100644 --- a/libavformat/apngdec.c +++

[FFmpeg-devel] [PATCH 10/11] avformat: Don't free old extradata before ff_allocate/get_extradata

2019-12-10 Thread Andreas Rheinhardt
These functions already free it themselves before they allocate the new extradata. Signed-off-by: Andreas Rheinhardt --- libavformat/avidec.c | 2 -- libavformat/cafdec.c | 7 ++- libavformat/concatdec.c| 4 libavformat/flic.c | 1 - libavformat/flvdec.c |

[FFmpeg-devel] [PATCH 02/11] avformat/apngdec: Make sure that extradata is zero-padded

2019-12-10 Thread Andreas Rheinhardt
Zeroing the padding has been forgotten. Signed-off-by: Andreas Rheinhardt --- libavformat/apngdec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/apngdec.c b/libavformat/apngdec.c index c8db9c6e1f..b5696e069c 100644 --- a/libavformat/apngdec.c +++

[FFmpeg-devel] [PATCH 01/11] avformat/mov: Use ff_alloc_extradata for dvdsub extradata

2019-12-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/mov.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 7553a7fdfc..733f4e4a34 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2255,7 +2255,7 @@ static int

[FFmpeg-devel] [PATCH 03/11] avformat/apngdec: Don't free extradata manually

2019-12-10 Thread Andreas Rheinhardt
The extradata will be freed automatically when the corresponding stream gets freed. Signed-off-by: Andreas Rheinhardt --- libavformat/apngdec.c | 4 1 file changed, 4 deletions(-) diff --git a/libavformat/apngdec.c b/libavformat/apngdec.c index b5696e069c..0f1d04a365 100644 ---

[FFmpeg-devel] [PATCH 1/3] fate: Fix dependencies to sample files to use local paths

2019-12-10 Thread Martin Storsjö
These dependencies are evaluted by make and must be expressed with the paths as in the local filesystem. --- tests/fate/ffmpeg.mak | 32 tests/fate/mpegps.mak | 2 +- tests/fate/mxf.mak| 8 3 files changed, 21 insertions(+), 21 deletions(-) diff

[FFmpeg-devel] [PATCH] configure: Check for the SetDllDirectory and GetModuleHandle functions

2019-12-10 Thread Martin Storsjö
These functions aren't available when building for the restricted UWP/WinRT/WinStore API subsets. Normally when building in this mode, one is probably only building the libraries, but being able to build ffmpeg.exe still is useful (and a ffmpeg.exe targeting these API subsets still can be run

[FFmpeg-devel] [PATCH] fate: Add an option for disabling the 4k tests

2019-12-10 Thread Martin Storsjö
When testing on a memory limited system, these tests consume a significant amount of memory and can often fail if testing by running multiple processes in parallel. --- configure | 3 +++ tests/fate/seek.mak | 4 +++- tests/fate/vcodec.mak | 5 +++-- 3 files changed, 9

[FFmpeg-devel] [PATCH] fate: Use a oneoff test for the tremolo filter

2019-12-10 Thread Martin Storsjö
The tremolo filter uses floating point internally, and uses multiplication factors derived from sin(fmod()), neither of which is bitexact for use with framecrc. This fixes running this test with mingw/x86_32 binaries when run in wine on linux (unsure if the same issue is present when run on

[FFmpeg-devel] [PATCH 1/2] checkasm: aacpsdsp: Tolerate extra intermediate precision in stereo_interpolate

2019-12-10 Thread Martin Storsjö
The stereo_interpolate functions add h_step to the values h BUF_SIZE times. Within the stereo_interpolate C functions, the values h (h0-h3, h00-h13) are declared as local float variables, but the compiler is free to keep them in a register with extra precision. If the accumulation is rounded to

[FFmpeg-devel] [PATCH 2/2] checkasm: float_dsp: Scale FLT/DBL_EPSILON sufficiently when comparing

2019-12-10 Thread Martin Storsjö
This fixes the float_dsp checkasm test for some seeds, when built with clang for mingw/x86_32. --- tests/checkasm/float_dsp.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/tests/checkasm/float_dsp.c b/tests/checkasm/float_dsp.c index 2abe4eccbd..9f7caa1456

[FFmpeg-devel] [PATCH 3/3] ffprobe: Fix fate tests for ffprobe in cases where TARGET_PATH differs from the current path

2019-12-10 Thread Martin Storsjö
In these cases, we must pass the full path of the file to ffprobe (as the current working dir on the remote system, e.g. when invoked with "ssh remote ffprobe ..." isn't the wanted one). The input filename passed to ffprobe is also included in the output, which is part of the reference test data.

[FFmpeg-devel] [PATCH 2/3] fate: Fix use of target_path/target_samples

2019-12-10 Thread Martin Storsjö
--- tests/fate-run.sh | 24 - tests/fate/filter-video.mak | 4 +- tests/fate/gapless.mak | 104 ++-- tests/fate/mov.mak | 2 +- tests/fate/seek.mak | 2 +- 5 files changed, 68 insertions(+), 68 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH V1 2/2] lavf/tls_openssl: support both pre-1.1.0 and post-1.1.0 init

2019-12-10 Thread James Almer
On 12/10/2019 11:02 AM, Jun Zhao wrote: > From: Jun Zhao > > supporting both pre-1.1.0 and post-1.1.0 version of the OpenSSL > library as the link: > https://wiki.openssl.org/index.php/Library_Initialization > > Signed-off-by: Jun Zhao > --- > libavformat/tls_openssl.c |4 > 1 files

Re: [FFmpeg-devel] [PATCH V1 1/2] configure: add OPENSSL_init_ssl check if pkg-config fail

2019-12-10 Thread James Almer
On 12/10/2019 11:02 AM, Jun Zhao wrote: > From: macweng > > fix when pkg-config fail and openssl > 1.1.0 --enable-openssl fail, > the root cause is check_lib can't found the SSL_library_init(). > > Signed-off-by: macweng > --- > configure |1 + > 1 files changed, 1 insertions(+), 0

Re: [FFmpeg-devel] FFmpeg developer meeting 2019/12/9 notes

2019-12-10 Thread Kieran O Leary
These notes are really helpful, I hope they continue for future meetings! Best, Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: avoid reading trailing bits when obu type is OBU_TILE_LIST

2019-12-10 Thread James Almer
On 12/10/2019 6:01 AM, Wangfei wrote: > Signed-off-by: Wangfei Could you fix your git configuration to use your full name instead? The same you use in normal replies. I'll commit this after you resend this patch with the fixed authorship. > --- > libavcodec/cbs_av1.c | 1 + > 1 file changed, 1

[FFmpeg-devel] [PATCH V1 2/2] lavf/tls_openssl: support both pre-1.1.0 and post-1.1.0 init

2019-12-10 Thread Jun Zhao
From: Jun Zhao supporting both pre-1.1.0 and post-1.1.0 version of the OpenSSL library as the link: https://wiki.openssl.org/index.php/Library_Initialization Signed-off-by: Jun Zhao --- libavformat/tls_openssl.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

[FFmpeg-devel] [PATCH V1 1/2] configure: add OPENSSL_init_ssl check if pkg-config fail

2019-12-10 Thread Jun Zhao
From: macweng fix when pkg-config fail and openssl > 1.1.0 --enable-openssl fail, the root cause is check_lib can't found the SSL_library_init(). Signed-off-by: macweng --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index

Re: [FFmpeg-devel] [PATCH v2] avfilter/formats: optimize ff_all_formats

2019-12-10 Thread zhilizhao
> On Dec 10, 2019, at 4:20 AM, Tomas Härdin wrote: > > lör 2019-12-07 klockan 01:06 +0800 skrev Zhao Zhili: >> This is a micro-optimization. Saving almost 200 reallocations makes >> it >> worth a try. >> --- >> fix commit message typo: relocations -> reallocations >> >> libavfilter/formats.c

[FFmpeg-devel] [PATCH] avfilter/scale_eval: remove redundant mathematical constants

2019-12-10 Thread Gyan
Regards, Gyan From 5466e975523502944af84bb43edf1e793554 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Tue, 10 Dec 2019 19:24:30 +0530 Subject: [PATCH] avfilter/scale_eval: remove redundant mathematical constants Even though removed from vf_scale in 3b316f9f22, they were reintroduced when

Re: [FFmpeg-devel] [PATCH v6 1/2] lavf/isom: support for demuxing and remuxing of MPEG-H 3D Audio in MP4

2019-12-10 Thread James Almer
On 11/22/2019 5:36 AM, Yuki Tsuchiya wrote: > Implemented according to the specification at > https://www.iso.org/standard/69561.html > The 'mhm1' sample entry is registered with MP4RA, which is defined as MHAS > encapsulated single stream MPEG-H 3D Audio. > 'MHAS' stands for MPEG-H audio

[FFmpeg-devel] FFmpeg developer meeting 2019/12/9 notes

2019-12-10 Thread Ronald S. Bultje
Dear all, below are the notes I took of the 2019/12/9 FFmpeg developer meeting. The meeting was held on a Google Meet, and there was an IRC proxy channel (#ffmpeg-meeting) also. Kind regards, Ronald - jb opens, agenda for this meeting o what happened at last meeting (at VDD) o various next

Re: [FFmpeg-devel] [PATCH 001/244] Add a new channel layout API

2019-12-10 Thread Anton Khirnov
Quoting Nicolas George (2019-12-09 20:34:45) > Michael Niedermayer (12019-12-09): > > mixing unsigned and signed int of course works if one is aware of > > * what is signed, what is unsigned > > * exact semantics of expressions mixing them > > * does not miss any corner cases > > I think it is

Re: [FFmpeg-devel] [PATCH v6 1/2] lavf/isom: support for demuxing and remuxing of MPEG-H 3D Audio in MP4

2019-12-10 Thread Tsuchiya, Yuki (SHES)
Hi, Is there any comments? On 2019/11/22 17:44, "Tsuchiya, Yuki (SHES)" wrote: > > Implemented according to the specification at > https://www.iso.org/standard/69561.html > The 'mhm1' sample entry is registered with MP4RA, which is defined as > MHAS encapsulated single stream MPEG-H

[FFmpeg-devel] [PATCH] avcodec/cbs_av1: avoid reading trailing bits when obu type is OBU_TILE_LIST

2019-12-10 Thread Wangfei
Signed-off-by: Wangfei --- libavcodec/cbs_av1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c index bbe4461130..ab006f4d11 100644 --- a/libavcodec/cbs_av1.c +++ b/libavcodec/cbs_av1.c @@ -1039,6 +1039,7 @@ static int