Re: [FFmpeg-devel] [PATCH 1/2] avcodec/pgssubdec: Free subtitle on error

2020-01-04 Thread Paul B Mahol
lgtm On 1/5/20, Michael Niedermayer wrote: > Fixes: Assertion failure > Fixes: > 19753/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PGSSUB_fuzzer-5688461843759104 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michae

Re: [FFmpeg-devel] [PATCH] ffmpeg: don't force source-tracked keyframes for duplicates

2020-01-04 Thread Gyan
On 04-01-2020 10:02 am, Gyan wrote: On 03-01-2020 04:05 pm, Gyan wrote: On 03-01-2020 03:30 pm, Michael Niedermayer wrote: On Fri, Jan 03, 2020 at 12:35:22PM +0530, Gyan Doshi wrote: Prevents a run of consecutive duplicate frames from all being encoded as keyframes, when force_key_frames

Re: [FFmpeg-devel] [PATCH] ffmpeg: remove premature rescaling of forced_keyframe times

2020-01-04 Thread Gyan
On 04-01-2020 10:02 am, Gyan wrote: On 02-01-2020 09:21 pm, Gyan Doshi wrote: The user-set forced KF times are parsed *after* this deleted loop and rescaled right after parsing. ---   fftools/ffmpeg.c | 4   1 file changed, 4 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c

Re: [FFmpeg-devel] [PATCH] Fix spelling in ID3v1 genres and extend the list of Winamp extensions.

2020-01-04 Thread Michael Niedermayer
On Wed, Dec 25, 2019 at 09:45:47PM +0100, Michael Niedermayer wrote: > On Wed, Dec 25, 2019 at 04:44:51PM +0100, Ulrich Spörlein wrote: > > On Tue, 24 Dec 2019, 00:42 Michael Niedermayer, > > wrote: > > > > > On Mon, Dec 23, 2019 at 11:43:10AM +0100, Ulrich Spörlein wrote: > > > > On Sun, 2019-12

[FFmpeg-devel] [PATCH 2/2] avcodec/dca_lbr: Fix some error codes and error passing

2020-01-04 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/dca_lbr.c | 162 +-- 1 file changed, 93 insertions(+), 69 deletions(-) diff --git a/libavcodec/dca_lbr.c b/libavcodec/dca_lbr.c index 3b50a99cf6..747fdafd3e 100644 --- a/libavcodec/dca_lbr.c +++ b/libavcode

[FFmpeg-devel] [PATCH 1/2] avcodec/pgssubdec: Free subtitle on error

2020-01-04 Thread Michael Niedermayer
Fixes: Assertion failure Fixes: 19753/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PGSSUB_fuzzer-5688461843759104 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/pgssubdec.c | 5 - 1

Re: [FFmpeg-devel] [PATCH] Workaround to build ffmpeg on MacOs 10.15

2020-01-04 Thread Michael Niedermayer
On Sat, Jan 04, 2020 at 10:35:59PM +0100, Michael Niedermayer wrote: > On Sat, Jan 04, 2020 at 09:25:40PM +0200, Martin Storsjö wrote: > > On Sat, 4 Jan 2020, Michael Niedermayer wrote: > > > > >On Sat, Jan 04, 2020 at 12:06:55AM +0100, Henrik Gramner wrote: > > >>On Fri, Jan 3, 2020 at 7:37 PM Mo

Re: [FFmpeg-devel] [PATCH] Workaround to build ffmpeg on MacOs 10.15

2020-01-04 Thread Michael Niedermayer
On Sat, Jan 04, 2020 at 09:25:40PM +0200, Martin Storsjö wrote: > On Sat, 4 Jan 2020, Michael Niedermayer wrote: > > >On Sat, Jan 04, 2020 at 12:06:55AM +0100, Henrik Gramner wrote: > >>On Fri, Jan 3, 2020 at 7:37 PM Moritz Barsnick wrote: > >>>On Fri, Jan 03, 2020 at 11:05:25 +0100, Timo Rothenp

Re: [FFmpeg-devel] [aarch64] improve performance of ff_yuv2planeX_8_neon

2020-01-04 Thread Michael Niedermayer
On Sat, Jan 04, 2020 at 05:53:34PM +0100, Clément Bœsch wrote: > On Tue, Dec 10, 2019 at 04:38:25PM -0600, Sebastian Pop wrote: > > Hi, > > > > This patch rewrites the innermost loop of ff_yuv2planeX_8_neon to avoid > > zips and > > horizontal adds by using fused multiply adds. The patch also use

Re: [FFmpeg-devel] [PATCH v2] avcodec/bsf: replace ctx->internal-> with bsfi-> for better readability

2020-01-04 Thread Michael Niedermayer
On Mon, Dec 16, 2019 at 01:01:49PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/bsf.c | 49 +++-- > 1 file changed, 27 insertions(+), 22 deletions(-) will apply thx [...] -- Michael G

Re: [FFmpeg-devel] [PATCH] Workaround to build ffmpeg on MacOs 10.15

2020-01-04 Thread Martin Storsjö
On Sat, 4 Jan 2020, Michael Niedermayer wrote: On Sat, Jan 04, 2020 at 12:06:55AM +0100, Henrik Gramner wrote: On Fri, Jan 3, 2020 at 7:37 PM Moritz Barsnick wrote: On Fri, Jan 03, 2020 at 11:05:25 +0100, Timo Rothenpieler wrote: I think this was discussed on this list in the past. Not sure

Re: [FFmpeg-devel] [PATCH] lavc/avpacket: forward av_buffer_realloc() error code.

2020-01-04 Thread Andreas Rheinhardt
Nicolas George: > Fix CID 1457229. > > Signed-off-by: Nicolas George > --- > libavcodec/avpacket.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c > index 858f827a0a..4da832c53c 100644 > --- a/libavcodec/avpacket.c >

Re: [FFmpeg-devel] [PATCH] lavu/buffer: forward av_buffer_realloc() error code.

2020-01-04 Thread Nicolas George
Andreas Rheinhardt (12020-01-04): > Shouldn't you check for (ret < 0) instead of (!new)? I am unsure > whether Coverity will really count this as a fix. I hesitated and went for the minimalist patch. New version. Regards, -- Nicolas George From 8ef49a7c86e108ed9e6981d482ae892e6f62c0f5 Mon Sep

Re: [FFmpeg-devel] [PATCH] lavu/buffer: forward av_buffer_realloc() error code.

2020-01-04 Thread Andreas Rheinhardt
Nicolas George: > Fix CID 1457235. > > Signed-off-by: Nicolas George > --- > libavutil/buffer.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavutil/buffer.c b/libavutil/buffer.c > index 6d9cb7428e..2f33e5ebb6 100644 > --- a/libavutil/buffer.c > +++ b/libavuti

Re: [FFmpeg-devel] [PATCH] lavu/buffer: forward av_buffer_realloc() error code.

2020-01-04 Thread Paul B Mahol
On 1/4/20, Nicolas George wrote: > Fix CID 1457235. > > Signed-off-by: Nicolas George > --- > libavutil/buffer.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavutil/buffer.c b/libavutil/buffer.c > index 6d9cb7428e..2f33e5ebb6 100644 > --- a/libavutil/buffer.c

[FFmpeg-devel] [PATCH] lavc/avpacket: forward av_buffer_realloc() error code.

2020-01-04 Thread Nicolas George
Fix CID 1457229. Signed-off-by: Nicolas George --- libavcodec/avpacket.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index 858f827a0a..4da832c53c 100644 --- a/libavcodec/avpacket.c +++ b/libavcodec/avpacket.c @@ -170,7

[FFmpeg-devel] [PATCH] lavu/buffer: forward av_buffer_realloc() error code.

2020-01-04 Thread Nicolas George
Fix CID 1457235. Signed-off-by: Nicolas George --- libavutil/buffer.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavutil/buffer.c b/libavutil/buffer.c index 6d9cb7428e..2f33e5ebb6 100644 --- a/libavutil/buffer.c +++ b/libavutil/buffer.c @@ -171,6 +171,7 @@ int av_

Re: [FFmpeg-devel] [PATCH V1] lavfi/buffersrc: Remove redundancy free after ff_filter_frame fail

2020-01-04 Thread Nicolas George
Jun Zhao (12020-01-01): > From: Jun Zhao > > ff_filter_frame always free the frame in case of error, so we don't > need to free the frame after ff_filter_frame fail. > > Signed-off-by: Jun Zhao > --- > libavfilter/buffersrc.c |4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) Tha

Re: [FFmpeg-devel] [aarch64] improve performance of ff_yuv2planeX_8_neon

2020-01-04 Thread Clément Bœsch
On Tue, Dec 10, 2019 at 04:38:25PM -0600, Sebastian Pop wrote: > Hi, > > This patch rewrites the innermost loop of ff_yuv2planeX_8_neon to avoid zips > and > horizontal adds by using fused multiply adds. The patch also uses ld1r to load > one element and replicate it across all lanes of the vecto

Re: [FFmpeg-devel] [PATCH] Workaround to build ffmpeg on MacOs 10.15

2020-01-04 Thread lance . lmwang
On Sat, Jan 04, 2020 at 03:35:42PM +0100, Hendrik Leppkes wrote: > On Sat, Jan 4, 2020 at 3:27 PM Timo Rothenpieler > wrote: > > > > On 04.01.2020 14:37, Michael Niedermayer wrote: > > > I dont know how effective this is or what exactly this option does, i > > > couldnt find documentation for it

Re: [FFmpeg-devel] [PATCH v2] avcodec/bsf: replace ctx->internal-> with bsfi-> for better readability

2020-01-04 Thread lance . lmwang
ping? On Mon, Dec 16, 2019 at 01:01:49PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/bsf.c | 49 +++-- > 1 file changed, 27 insertions(+), 22 deletions(-) > > diff --git a/libavcodec/bsf.

Re: [FFmpeg-devel] [PATCH] lavc/ffv1: Properly check that the 4th and 5th quant tables are zeroes

2020-01-04 Thread Derek Buitenhuis
On 03/01/2020 21:59, Derek Buitenhuis wrote: > Is this guaranteed somehow? It isn't mentioned in the spec. Looks like it's inherent to how it's stored. I'll send a v2 with this. Thanks, - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH] avformat/image2: Upon request, make available extra metadata, fields related to input path to be used by filters.

2020-01-04 Thread Alexandre Heitor Schmidt
Hi there! I'm just writing to make sure this patch wasn't forgotten. :) Best wishes to you all! Alex. On 01/01/2020 17:17, Alexandre Heitor Schmidt wrote: The patch follows attached, to avoid formatting issues. The commit message is as follows: avformat/image2: Upon request, make available ex

Re: [FFmpeg-devel] [PATCH] Workaround to build ffmpeg on MacOs 10.15

2020-01-04 Thread Hendrik Leppkes
On Sat, Jan 4, 2020 at 3:27 PM Timo Rothenpieler wrote: > > On 04.01.2020 14:37, Michael Niedermayer wrote: > > I dont know how effective this is or what exactly this option does, i > > couldnt find documentation for it quickly what it does in clang on macosx. > > google keeps pointing to gcc > >

Re: [FFmpeg-devel] [PATCH] Workaround to build ffmpeg on MacOs 10.15

2020-01-04 Thread Timo Rothenpieler
On 04.01.2020 14:37, Michael Niedermayer wrote: I dont know how effective this is or what exactly this option does, i couldnt find documentation for it quickly what it does in clang on macosx. google keeps pointing to gcc but a crash is better than arbitrary code execution, which IIUC is the ide

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_gblur: fix divide by zero

2020-01-04 Thread zhilizhao
> On Jan 4, 2020, at 9:09 PM, Paul B Mahol wrote: > > On 1/4/20, zhilizhao wrote: >> >> >>> On Jan 4, 2020, at 7:04 PM, Paul B Mahol wrote: >>> >>> I do not like this “fix" >> >> What do you suggest? It’s numerical unstable for small sigma. > > For small sigma return frames unchanged as

Re: [FFmpeg-devel] [PATCH] Workaround to build ffmpeg on MacOs 10.15

2020-01-04 Thread Michael Niedermayer
On Sat, Jan 04, 2020 at 12:06:55AM +0100, Henrik Gramner wrote: > On Fri, Jan 3, 2020 at 7:37 PM Moritz Barsnick wrote: > > On Fri, Jan 03, 2020 at 11:05:25 +0100, Timo Rothenpieler wrote: > > > I think this was discussed on this list in the past. > > > Not sure what the conclusion was, but I thin

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_gblur: fix divide by zero

2020-01-04 Thread Paul B Mahol
On 1/4/20, zhilizhao wrote: > > >> On Jan 4, 2020, at 7:04 PM, Paul B Mahol wrote: >> >> I do not like this “fix" > > What do you suggest? It’s numerical unstable for small sigma. For small sigma return frames unchanged as it currently does. > >> >> On 1/4/20, quinkbl...@foxmail.com wrote: >>

Re: [FFmpeg-devel] [PATCH V1] lavfi/buffersrc: Remove redundancy free after ff_filter_frame fail

2020-01-04 Thread Paul B Mahol
LGTM On 1/1/20, Jun Zhao wrote: > From: Jun Zhao > > ff_filter_frame always free the frame in case of error, so we don't > need to free the frame after ff_filter_frame fail. > > Signed-off-by: Jun Zhao > --- > libavfilter/buffersrc.c |4 +--- > 1 files changed, 1 insertions(+), 3 deletions

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_gblur: fix divide by zero

2020-01-04 Thread zhilizhao
> On Jan 4, 2020, at 7:04 PM, Paul B Mahol wrote: > > I do not like this “fix" What do you suggest? It’s numerical unstable for small sigma. > > On 1/4/20, quinkbl...@foxmail.com wrote: >> From: Zhao Zhili >> >> ./ffmpeg -i ~/Pictures/test.jpg -vf 'gblur=sigma=0' -f null - >> ... >> src/

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_gblur: remove unnecessary check

2020-01-04 Thread Paul B Mahol
Invalid, sigma can be 0. On 1/4/20, quinkbl...@foxmail.com wrote: > From: Zhao Zhili > > --- > libavfilter/vf_gblur.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/libavfilter/vf_gblur.c b/libavfilter/vf_gblur.c > index e057937fb7..0d7d5438d1 100644 > --- a/libavf

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_gblur: fix divide by zero

2020-01-04 Thread Paul B Mahol
I do not like this "fix" On 1/4/20, quinkbl...@foxmail.com wrote: > From: Zhao Zhili > > ./ffmpeg -i ~/Pictures/test.jpg -vf 'gblur=sigma=0' -f null - > ... > src/libavfilter/vf_gblur.c:260:59: runtime error: division by zero > src/libavfilter/vf_gblur.c:261:26: runtime error: division by zero >

Re: [FFmpeg-devel] [PATCH V1] lavfi/buffersrc: Remove redundancy free after ff_filter_frame fail

2020-01-04 Thread Andreas Rheinhardt
Jun Zhao: > From: Jun Zhao > > ff_filter_frame always free the frame in case of error, so we don't > need to free the frame after ff_filter_frame fail. > > Signed-off-by: Jun Zhao > --- > libavfilter/buffersrc.c |4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_gblur: remove unnecessary check

2020-01-04 Thread quinkblack
From: Zhao Zhili --- libavfilter/vf_gblur.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavfilter/vf_gblur.c b/libavfilter/vf_gblur.c index e057937fb7..0d7d5438d1 100644 --- a/libavfilter/vf_gblur.c +++ b/libavfilter/vf_gblur.c @@ -189,9 +189,6 @@ static void gaussi

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_gblur: fix divide by zero

2020-01-04 Thread quinkblack
From: Zhao Zhili ./ffmpeg -i ~/Pictures/test.jpg -vf 'gblur=sigma=0' -f null - ... src/libavfilter/vf_gblur.c:260:59: runtime error: division by zero src/libavfilter/vf_gblur.c:261:26: runtime error: division by zero --- libavfilter/vf_gblur.c | 12 +--- 1 file changed, 9 insertions(+),