[FFmpeg-devel] [PATCH v4 1/1] avdevice/gdigrab add use_captureblt option

2020-01-11 Thread fgodtdev
From: FgoDt Add use_captureblt option for disable or use CAPTUREBLT flag, when useing the bitblt function with CAPTUREBLT may caused the Windows mouse cursor flicker. most time we don't need this flag to capture window I tested on Windows 10 works fine Signed-off-by: fgodt --- doc/indevs.tex

[FFmpeg-devel] [PATCH] avfilter: add csound audio filter wrapper

2020-01-11 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- configure| 4 + doc/filters.texi | 16 +++ libavfilter/Makefile | 1 + libavfilter/af_csound.c | 267 +++ libavfilter/allfilters.c | 1 + 5 files changed, 289 insertions(+) create mode 100644

Re: [FFmpeg-devel] [PATCH] avfilter: add crossfade filter

2020-01-11 Thread Paul B Mahol
On 1/11/20, Gyan wrote: > Paul, this is useful. When can you merge this? You actually tried it? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-dev

Re: [FFmpeg-devel] [PATCH] avfilter: add crossfade filter

2020-01-11 Thread Gyan
On 11-01-2020 03:35 pm, Paul B Mahol wrote: On 1/11/20, Gyan wrote: Paul, this is useful. When can you merge this? You actually tried it? No. Do I need to? It looks to be video counterpart of acrossfade. Gyan ___ ffmpeg-devel mailing list ffmpeg

Re: [FFmpeg-devel] [PATCH] avfilter: add crossfade filter

2020-01-11 Thread Paul B Mahol
On 1/11/20, Gyan wrote: > > > On 11-01-2020 03:35 pm, Paul B Mahol wrote: >> On 1/11/20, Gyan wrote: >>> Paul, this is useful. When can you merge this? >> You actually tried it? > > No. Do I need to? It looks to be video counterpart of acrossfade. Yes, but generic filtering/crossfade is pretty s

Re: [FFmpeg-devel] [PATCH] avfilter: add crossfade filter

2020-01-11 Thread Gyan
On 11-01-2020 03:53 pm, Paul B Mahol wrote: On 1/11/20, Gyan wrote: On 11-01-2020 03:35 pm, Paul B Mahol wrote: On 1/11/20, Gyan wrote: Paul, this is useful. When can you merge this? You actually tried it? No. Do I need to? It looks to be video counterpart of acrossfade. Yes, but gener

Re: [FFmpeg-devel] [PATCH] avfilter: add freezeframes video filter

2020-01-11 Thread Paul B Mahol
Will apply soon. On 12/31/19, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 19 > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_freezeframes.c | 167 ++ > 4 files

[FFmpeg-devel] [PATCH 1/2] avformat/mov: Check STCO location

2020-01-11 Thread Michael Niedermayer
Fixes: bypassing of checks and assertion failure Fixes: asan_1003879.mp4 Found-by: Clusterfuzz + asan Reported-by: Thomas Guilbert Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 589576b

[FFmpeg-devel] [PATCH 2/2] avformat/mov: Free memory before returning in update_frag_index, when streams lack track id.

2020-01-11 Thread Michael Niedermayer
From: Thomas Guilbert Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 75f098af09..c49fd4d43f 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -1327,8 +1327,10 @@

Re: [FFmpeg-devel] [PATCHv2 1/3] avutil/eval: separate AVExpr state to a new AVExprState struct

2020-01-11 Thread Michael Niedermayer
On Fri, Jan 10, 2020 at 12:49:08AM +0100, Marton Balint wrote: > > > On Thu, 9 Jan 2020, Michael Niedermayer wrote: > > >On Wed, Jan 01, 2020 at 05:40:33PM +0100, Marton Balint wrote: > >> > >> > >>On Wed, 1 Jan 2020, Michael Niedermayer wrote: > >> > >>>On Mon, Dec 30, 2019 at 11:23:40PM +0100,

Re: [FFmpeg-devel] [PATCH 01/20] avformat/matroskaenc: Fix ReferenceBlock timestamp

2020-01-11 Thread Andreas Rheinhardt
On Tue, Jan 7, 2020 at 3:12 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > On Wed, Jan 1, 2020 at 1:59 AM Andreas Rheinhardt < > andreas.rheinha...@gmail.com> wrote: > >> In order to indicate that the frames in a BlockGroup are not keyframes, >> one has to add a ReferenceBlock elem

Re: [FFmpeg-devel] [PATCH 01/20] avformat/matroskaenc: Fix ReferenceBlock timestamp

2020-01-11 Thread Paul B Mahol
probably ok On 1/1/20, Andreas Rheinhardt wrote: > In order to indicate that the frames in a BlockGroup are not keyframes, > one has to add a ReferenceBlock element containing the timestamp of a > referenced Block that has already been written. The timestamp ought to be > relative to the timestam

Re: [FFmpeg-devel] [PATCH 01/20] avformat/matroskaenc: Fix ReferenceBlock timestamp

2020-01-11 Thread James Almer
On 1/11/2020 11:12 AM, Paul B Mahol wrote: > probably ok Applied. > > On 1/1/20, Andreas Rheinhardt wrote: >> In order to indicate that the frames in a BlockGroup are not keyframes, >> one has to add a ReferenceBlock element containing the timestamp of a >> referenced Block that has already bee

Re: [FFmpeg-devel] [PATCHv2 1/3] avutil/eval: separate AVExpr state to a new AVExprState struct

2020-01-11 Thread Marton Balint
On Sat, 11 Jan 2020, Michael Niedermayer wrote: On Fri, Jan 10, 2020 at 12:49:08AM +0100, Marton Balint wrote: On Thu, 9 Jan 2020, Michael Niedermayer wrote: On Wed, Jan 01, 2020 at 05:40:33PM +0100, Marton Balint wrote: On Wed, 1 Jan 2020, Michael Niedermayer wrote: On Mon, Dec 30,

Re: [FFmpeg-devel] [PATCH V1 02/11] lavfi/spp: enable runtime change flag

2020-01-11 Thread Michael Niedermayer
On Sat, Jan 11, 2020 at 12:13:49PM +0800, Jun Zhao wrote: > From: Jun Zhao > > enable runtime change flag. > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_spp.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6

Re: [FFmpeg-devel] [PATCH V1 11/11] lavfi/vulume: enable runtime change flag

2020-01-11 Thread Michael Niedermayer
On Sat, Jan 11, 2020 at 12:13:58PM +0800, Jun Zhao wrote: > From: Jun Zhao > > enable runtime change flag. > > Signed-off-by: Jun Zhao > --- > libavfilter/af_volume.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) typo in commit message (vulume) [...] -- Michael GnuPG f

Re: [FFmpeg-devel] [PATCH V1 01/11] lavfi/spp: add "quality" option in runtime change path

2020-01-11 Thread Michael Niedermayer
On Sat, Jan 11, 2020 at 12:13:48PM +0800, Jun Zhao wrote: > From: Jun Zhao > > it's stranage to use option "level" in runtime change path but used > "quality" in option, add "quality" in runtime change path, it's more > intuitive and keep the "level" for compatibility. > > Signed-off-by: Jun Zha

Re: [FFmpeg-devel] [PATCH V1 04/11] lavfi/hue: enable runtime change flag

2020-01-11 Thread Michael Niedermayer
On Sat, Jan 11, 2020 at 12:13:51PM +0800, Jun Zhao wrote: > From: Jun Zhao > > enable runtime change flag. > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_hue.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavfilter/vf_hue.c b/libavfilter/vf_hue.c > inde

Re: [FFmpeg-devel] [PATCH V1 04/11] lavfi/hue: enable runtime change flag

2020-01-11 Thread Paul B Mahol
On 1/11/20, Michael Niedermayer wrote: > On Sat, Jan 11, 2020 at 12:13:51PM +0800, Jun Zhao wrote: >> From: Jun Zhao >> >> enable runtime change flag. >> >> Signed-off-by: Jun Zhao >> --- >> libavfilter/vf_hue.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/l

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_d3d11va: Use secure dlopen.

2020-01-11 Thread Matt Oliver
On Tue, 31 Dec 2019 at 03:37, Andriy Gelman wrote: > On Mon, 30. Dec 11:31, Andriy Gelman wrote: > > On Tue, 31. Dec 03:02, Matt Oliver wrote: > > > dlopen contains additional security to prevent dll hijacking compared > to > > > standard LoadLibrary. > > > --- > > > libavutil/hwcontext_d3d11va.

[FFmpeg-devel] New Defects reported by Coverity Scan for FFmpeg/FFmpeg (fwd)

2020-01-11 Thread Marton Balint
Hi, Has anybody reported these and similar false positives involving av_dict_set() with a 0 flag to Coverity? These are popping up all over the codebase, something should be done to make Coverity smarter about them. Any ideas? Thanks, Marton -- Forwarded message -- Date: Sa

Re: [FFmpeg-devel] [PATCH v1] avcodec/wavpack: simplify the code

2020-01-11 Thread Michael Niedermayer
On Sat, Jan 11, 2020 at 01:31:06PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/wavpack.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/vc1dec: Limit bits by the actual bitstream size

2020-01-11 Thread Michael Niedermayer
On Sun, Dec 08, 2019 at 10:31:18PM +0100, Michael Niedermayer wrote: > Fixes: Timeout (350 ->19sec) > Fixes: > 19249/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1IMAGE_fuzzer-6566896438870016 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projec

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/vc1dec: Check field_mode for sprites

2020-01-11 Thread Michael Niedermayer
On Sun, Dec 08, 2019 at 10:31:19PM +0100, Michael Niedermayer wrote: > Fixes: Out of array read > Fixes: > 19263/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1IMAGE_fuzzer-5389219325542400 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/f

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/vc1: Remove bits variable

2020-01-11 Thread Michael Niedermayer
On Sun, Dec 08, 2019 at 10:31:20PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mss2.c | 2 -- > libavcodec/vc1.h | 2 -- > libavcodec/vc1_block.c | 16 > libavcodec/vc1dec.c| 2 -- > 4 files changed, 8 insertions(+),

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/g729postfilter: Optimize out overflowing multiplication from apply_tilt_comp()

2020-01-11 Thread Michael Niedermayer
On Sun, Dec 08, 2019 at 12:20:09AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: -1114392282 * 2 cannot be represented in type > 'int' > Fixes: > 19236/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_G729_fuzzer-5741678938030080 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/alac: Fix integer overflow in LPC coefficient adaption

2020-01-11 Thread Michael Niedermayer
On Sun, Dec 08, 2019 at 12:20:10AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 267693597 * 10 cannot be represented in type > 'int' > Fixes: > 19237/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5755407700328448 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/adpcm: Fix overflow in FFABS() IMA_EA_EACS

2020-01-11 Thread Michael Niedermayer
On Sat, Dec 07, 2019 at 10:24:03AM +0100, Michael Niedermayer wrote: > Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to > an unsigned type to negate this value to itself > Fixes: > 19235/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_IMA_EA_EACS_fuzzer-56808789

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h2645: Skip all 0 NAL units

2020-01-11 Thread Michael Niedermayer
On Fri, Dec 13, 2019 at 07:26:04PM -0300, James Almer wrote: > On 12/13/2019 7:17 PM, Michael Niedermayer wrote: > > Fixes: assertion failure > > Fixes: > > 19286/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_REDUNDANT_PPS_fuzzer-5707990724509696 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] [PATCH 3/3] tools/target_dec_fuzzer: Adjust threshold for RASC

2020-01-11 Thread Michael Niedermayer
On Wed, Dec 11, 2019 at 10:03:52PM +0100, Michael Niedermayer wrote: > Fixes: Timeout(35sec -> 4sec) > Fixes: > 19289/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RASC_fuzzer-5676526398078976 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/

Re: [FFmpeg-devel] [PATCH 05/11] avformat/apngdec: Remove goto fail that does nothing

2020-01-11 Thread Michael Niedermayer
On Tue, Dec 10, 2019 at 10:59:49PM +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/apngdec.c | 31 --- > 1 file changed, 12 insertions(+), 19 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6

Re: [FFmpeg-devel] [PATCH 05/11] avformat/apngdec: Remove goto fail that does nothing

2020-01-11 Thread Michael Niedermayer
On Sat, Jan 11, 2020 at 11:46:07PM +0100, Michael Niedermayer wrote: > On Tue, Dec 10, 2019 at 10:59:49PM +0100, Andreas Rheinhardt wrote: > > Signed-off-by: Andreas Rheinhardt > > --- > > libavformat/apngdec.c | 31 --- > > 1 file changed, 12 insertions(+), 19 deletio

Re: [FFmpeg-devel] [PATCH 1/8] lavu/pix_fmt: add new pixel format y210

2020-01-11 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Mark Thompson > Sent: Thursday, January 9, 2020 05:47 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavu/pix_fmt: add new pixel format > y210 > > On 29/12/2019 16:28, Linjie Fu wrote: > > Add some packed 4: