Re: [FFmpeg-devel] [PATCH 1/3] avcodec/screenpresso: Optimize sum_delta_flipped()

2020-01-30 Thread Paul B Mahol
lgtm On 1/29/20, Michael Niedermayer wrote: > 553 -> 332 sec > > Testcase: > 20280/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SCREENPRESSO_fuzzer-6238663432470528 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/screenpresso.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deleti

[FFmpeg-devel] [PATCH] dashenc: check pts to prevent division by zero error

2020-01-30 Thread Alfred E. Heggestad
this usecase will cause a division by zero trap: 1. dashenc has received one frame 2. os->max_pts and os->start_pts have same value 3. delta between max_pts and start_pts is 0 4. av_rescale_q(0, x, y) returns 0 5. this value is used as denominator in division 6. Bang! -> segfault this fix checks

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/x86/diracdsp: Fix incorrect src addressing in dequant_subband_32()

2020-01-30 Thread Paul B Mahol
probably ok On 1/29/20, Michael Niedermayer wrote: > Fixes: Segfault (not reproducable with asm, which made this hard to debug) > Fixes: decoding errors > Fixes: > 19854/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5729372837511168 > > Found-by: continuous fuzzing process > http

Re: [FFmpeg-devel] [PATCH 5/6] avfilter/vf_drawtext: use replacement chars for invalid UTF8 sequences

2020-01-30 Thread Paul B Mahol
probably ok On 1/30/20, Marton Balint wrote: > continue is explicitly disallowed for GET_UTF8, so let's fix that as well. > Fixes crash with invalid UTF8 sequences. > > Signed-off-by: Marton Balint > --- > libavfilter/vf_drawtext.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-

Re: [FFmpeg-devel] [PATCH 6/6] avfilter/vf_drawtext: do not overread text if the last UTF8 sequence is invalid

2020-01-30 Thread Paul B Mahol
lgtm On 1/30/20, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavfilter/vf_drawtext.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c > index ed10175af0..b58556e0f1 100644 > --- a/libavfilter/v

Re: [FFmpeg-devel] [PATCH 1/6] avutil/common: use unsigned int in GET_UTF8

2020-01-30 Thread Paul B Mahol
bug in commit message, otherwise lgtm On 1/30/20, Marton Balint wrote: > Right shift of signed value is impelentation defined. > > Signed-off-by: Marton Balint > --- > libavutil/common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/common.h b/libavutil/comm

Re: [FFmpeg-devel] [PATCH 4/6] avutil/common: warn about possible move of the data pointer after the last 0 byte in GET_UTF8

2020-01-30 Thread Paul B Mahol
lgtm On 1/30/20, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/common.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavutil/common.h b/libavutil/common.h > index e6f076a13c..142ff9abe7 100644 > --- a/libavutil/common.h > +++ b/libavutil/

Re: [FFmpeg-devel] [PATCH 3/6] avutil/common: put ERROR statements into separate code blocks in GET_UTF8/16

2020-01-30 Thread Paul B Mahol
missing rationale explanation. On 1/30/20, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/common.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavutil/common.h b/libavutil/common.h > index 02671190a6..e6f076a13c 100644 > --- a/libavuti

Re: [FFmpeg-devel] [PATCH 2/6] avutil/common: add parenthesis around GET_16BIT in GET_UTF16

2020-01-30 Thread Paul B Mahol
why? On 1/30/20, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/common.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavutil/common.h b/libavutil/common.h > index 5568754bb9..02671190a6 100644 > --- a/libavutil/common.h > +++ b/libavutil

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-30 Thread Wonkap Jang
Hi James, My answers are in-line. On Wed, Jan 29, 2020 at 8:36 AM James Zern wrote: > On Fri, Jan 17, 2020 at 1:56 PM Wonkap Jang > wrote: > > > > Hi James, > > > > On Fri, Jan 17, 2020 at 1:50 PM Wonkap Jang wrote: > > > > > This commit reuses the configuration options for VP8 that enables >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/aviobuf: Remove AVIOInternal and one level of indirection

2020-01-30 Thread Paul B Mahol
I guess it is fine, see no negative implications. On 1/30/20, Andreas Rheinhardt wrote: > Andreas Rheinhardt: >> Andreas Rheinhardt: >>> On Mon, Jan 6, 2020 at 3:51 PM Andreas Rheinhardt < >>> andreas.rheinha...@gmail.com> wrote: >>> In the Libav commit cae448cf, the opaque of every AVIOCont

Re: [FFmpeg-devel] [PATCH]lavf/nut: Explicitely add tags for NV12 and NV21

2020-01-30 Thread Michael Niedermayer
On Wed, Jan 29, 2020 at 02:44:02PM +0100, Paul B Mahol wrote: > On 1/29/20, Michael Niedermayer wrote: > > On Wed, Jan 29, 2020 at 01:44:52AM +0100, Carl Eugen Hoyos wrote: > >> Hi! > >> > >> Mentioned tags are already used in nut by fate. > >> > >> Please comment, Carl Eugen > > > >> nut.c |

Re: [FFmpeg-devel] [PATCH]lavf/nut: Explicitely add tags for NV12 and NV21

2020-01-30 Thread Paul B Mahol
On 1/30/20, Michael Niedermayer wrote: > On Wed, Jan 29, 2020 at 02:44:02PM +0100, Paul B Mahol wrote: >> On 1/29/20, Michael Niedermayer wrote: >> > On Wed, Jan 29, 2020 at 01:44:52AM +0100, Carl Eugen Hoyos wrote: >> >> Hi! >> >> >> >> Mentioned tags are already used in nut by fate. >> >> >> >>

[FFmpeg-devel] [PATCH V1] cmdutils: fix crash if no name for "ffmpeg -h protocol"

2020-01-30 Thread Jun Zhao
From: Jun Zhao fix crash when used the command like: - ffmpeg -h protocol - ffmpeg -h protocol= Signed-off-by: Jun Zhao --- fftools/cmdutils.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 2284631..f0f2b4f 100644 -

Re: [FFmpeg-devel] [PATCH 1/2] avutil/log: Add av_log_once() for printing a message just once per instance

2020-01-30 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-01-29 12:25:42) > On Tue, Jan 28, 2020 at 07:38:45PM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2020-01-24 13:04:08) > > > On Tue, Jan 21, 2020 at 07:44:46PM +0100, Anton Khirnov wrote: > > > > Quoting Michael Niedermayer (2020-01-21 15:43:48) > >

Re: [FFmpeg-devel] [PATCH 1/5] avformat/format: add av_find_input_format2

2020-01-30 Thread Anton Khirnov
Quoting Gyan (2020-01-29 16:48:14) > > > On 29-01-2020 03:10 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2020-01-28 08:44:42) > >> Identifies demuxer by extension if search by short name fails. > >> --- > >> libavformat/avformat.h | 7 +++ > >> libavformat/format.c | 14 +++

Re: [FFmpeg-devel] [PATCH V1] cmdutils: fix crash if no name for "ffmpeg -h protocol"

2020-01-30 Thread Paul B Mahol
lgtm On 1/30/20, Jun Zhao wrote: > From: Jun Zhao > > fix crash when used the command like: > - ffmpeg -h protocol > - ffmpeg -h protocol= > > Signed-off-by: Jun Zhao > --- > fftools/cmdutils.c |8 +++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/fftools/cmdutil

Re: [FFmpeg-devel] [PATCH 3/6] avutil/common: put ERROR statements into separate code blocks in GET_UTF8/16

2020-01-30 Thread Marton Balint
On Thu, 30 Jan 2020, Paul B Mahol wrote: missing rationale explanation. Patch 5 is using two statements as ERROR, without this the second statement is executed always and not only if the if condition is true. On 1/30/20, Marton Balint wrote: Signed-off-by: Marton Balint --- libavuti

Re: [FFmpeg-devel] [PATCH 2/6] avutil/common: add parenthesis around GET_16BIT in GET_UTF16

2020-01-30 Thread Marton Balint
On Thu, 30 Jan 2020, Paul B Mahol wrote: why? Because it is a macro and otherwise operator precedence might interfere with what the user would expect. In the second GET_16BIT you can't use bitwise operators because their precedence is lower than substraction which is used there. On 1/

Re: [FFmpeg-devel] [PATCH 2/6] avutil/common: add parenthesis around GET_16BIT in GET_UTF16

2020-01-30 Thread Paul B Mahol
On 1/30/20, Marton Balint wrote: > > > On Thu, 30 Jan 2020, Paul B Mahol wrote: > >> why? > > Because it is a macro and otherwise operator precedence might > interfere with what the user would expect. In the second GET_16BIT you > can't use bitwise operators because their precedence is lower than

Re: [FFmpeg-devel] [PATCH 3/6] avutil/common: put ERROR statements into separate code blocks in GET_UTF8/16

2020-01-30 Thread Paul B Mahol
On 1/30/20, Marton Balint wrote: > > > On Thu, 30 Jan 2020, Paul B Mahol wrote: > >> missing rationale explanation. > > Patch 5 is using two statements as ERROR, without this the second > statement is executed always and not only if the if condition is true. > patch lgtm >> >> On 1/30/20, Marton

Re: [FFmpeg-devel] [PATCH] avfilter/vf_geq: use per-thread AVExpr for expression evaluation

2020-01-30 Thread Michael Niedermayer
On Wed, Jan 29, 2020 at 08:25:17PM +0100, Marton Balint wrote: > There was no consensus about separating AVExprState from AVExpr so here is a > minimal patch using the existing AVExpr to fix ticket #7528. > > Signed-off-by: Marton Balint > --- > doc/filters.texi | 5 + > libavfilter/vf_

Re: [FFmpeg-devel] [PATCH] ac3enc: drop a global variable

2020-01-30 Thread Michael Niedermayer
On Wed, Jan 29, 2020 at 04:34:48PM +0100, Anton Khirnov wrote: > Log the warning message once per encoder instance instead. > --- > libavcodec/ac3enc.c | 5 ++--- > libavcodec/ac3enc.h | 2 ++ > 2 files changed, 4 insertions(+), 3 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/screenpresso: Optimize sum_delta_flipped()

2020-01-30 Thread Michael Niedermayer
On Thu, Jan 30, 2020 at 09:22:53AM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "You are 36 times more likely to die in a bathtub than at the hands of a terrorist. Also, you are 2.5 times more likely to become

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/x86/diracdsp: Fix incorrect src addressing in dequant_subband_32()

2020-01-30 Thread Michael Niedermayer
On Thu, Jan 30, 2020 at 11:30:03AM +0100, Paul B Mahol wrote: > probably ok will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things microsoft did are stupid, but not doing something just because microsoft did it is even more stupid. If everyt

Re: [FFmpeg-devel] [PATCH 1/2] avformat/aviobuf: Remove AVIOInternal and one level of indirection

2020-01-30 Thread Michael Niedermayer
On Thu, Jan 30, 2020 at 01:33:43PM +0100, Paul B Mahol wrote: > I guess it is fine, see no negative implications. will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things microsoft did are stupid, but not doing something just because microsoft

Re: [FFmpeg-devel] [PATCH] lavc/dvdsubenc: accept palette from options

2020-01-30 Thread Michael Kuron
Is there anything else you need me to change before this can be merged? If not, I am happy to split it into two patches if necessary. On Sat, Jan 25, 2020 at 3:33 PM Michael Kuron wrote: > > Previously, the default palette would always be used. > Now, we can accept a custom palette, just like dvd

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpeg12dec: Fix invalid shift in mpeg2_fast_decode_block_intra()

2020-01-30 Thread Michael Niedermayer
On Thu, Dec 26, 2019 at 02:13:59AM +, Kieran Kunhya wrote: > On Thu, 26 Dec 2019 at 00:27, Michael Niedermayer > wrote: > > > Fixes: left shift of negative value -695 > > Fixes: > > 19232/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG1VIDEO_fuzzer-5702856963522560 > > Fixes: > > 19555

[FFmpeg-devel] Unable to log into the bug tracker

2020-01-30 Thread Alberto Salvia Novella
Screencast (Please include my address into "To:" when replying) smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] tools/target_dec_fuzzer: Add threshold for ALS

2020-01-30 Thread Michael Niedermayer
On Sun, Jan 26, 2020 at 12:56:26AM +0100, Michael Niedermayer wrote: > Fixes: Timeout (253sec -> 16sec) > Fixes: > 18668/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-6227155369590784 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/project

Re: [FFmpeg-devel] [PATCH] doc/filters: Document geq *sum functions

2020-01-30 Thread Michael Niedermayer
On Sat, Dec 28, 2019 at 11:28:44AM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > doc/filters.texi | 4 > 1 file changed, 4 insertions(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When the tyrant has dispos

Re: [FFmpeg-devel] [PATCH] avcodec/iff: Over-allocate ham_palbuf for HAM6 IFF-PBM

2020-01-30 Thread Michael Niedermayer
On Sat, Jan 04, 2020 at 01:41:31AM +0100, Michael Niedermayer wrote: > IFF-PBM-HAM6 can read out of array without this overallocation > Fixes: Out of array read > Fixes: > 19752/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5675331403120640 > > Found-by: continuous fuzzing pro

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/smacker: Check space before decoding type

2020-01-30 Thread Michael Niedermayer
On Thu, Jan 02, 2020 at 01:01:51AM +0100, Michael Niedermayer wrote: > Fixes: Timeout (232sec -> 280ms) > Fixes: > 19682/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKER_fuzzer-5654129649385472 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/pro

Re: [FFmpeg-devel] [PATCH 1/2] remove tests/ref/lavf/fits

2020-01-30 Thread Michael Niedermayer
On Mon, Jan 06, 2020 at 02:55:38PM +0100, Michael Niedermayer wrote: > This appears to be forgotten in ac4b5d86222006fa71ffe5922e1a34f1422507d8 > > Signed-off-by: Michael Niedermayer > --- > tests/ref/lavf/fits | 18 -- > 1 file changed, 18 deletions(-) > delete mode 100644 test

Re: [FFmpeg-devel] Fix undefined behavior in ff_configure_buffers_for_index()

2020-01-30 Thread Dale Curtis
On Wed, Jan 29, 2020 at 10:23 PM Michael Niedermayer wrote: > so i think it works but maybe ive missed something, for which values > of e2_pts do you see a problem with e1_pts = INT64_MIN? > For e1_pts = INT64_MIN and e2_pts >= 0 you end up with a negative int64_t result for e2_pts - (uint64_t)e

Re: [FFmpeg-devel] [PATCH 2/2] tests/fate/lavf-video.mak: better looking gif dependancies

2020-01-30 Thread Michael Niedermayer
On Mon, Jan 06, 2020 at 11:43:29AM -0300, James Almer wrote: > On 1/6/2020 10:55 AM, Michael Niedermayer wrote: [...] > > FATE_LAVF_VIDEO-$(CONFIG_YUV4MPEGPIPE_MUXER)+= y4m > > > > FATE_LAVF_VIDEO = $(FATE_LAVF_VIDEO-yes:%=fate-lavf-%) > > > > Make the commit message "fix

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/apedec: Fix undefined integer overflow in decode_array_0000()

2020-01-30 Thread Michael Niedermayer
On Sun, Dec 08, 2019 at 12:20:12AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: -2143289344 - 6246400 cannot be represented > in type 'int' > Fixes: > 19239/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5173755680915456 > > Found-by: continuous fuzzing proce

Re: [FFmpeg-devel] [PATCH] avcodec/wmalosslessdec: Fix multiple integer overflows

2020-01-30 Thread Michael Niedermayer
On Thu, Jan 09, 2020 at 03:44:04PM +0100, Michael Niedermayer wrote: > Fixes: left shift of 3329 by 20 places cannot be represented in type 'int' > Fixes: signed integer overflow: -199378355 + -1948950833 cannot be > represented in type 'int' > Fixes: > 19837/clusterfuzz-testcase-minimized-ffmpeg

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Check STCO location

2020-01-30 Thread Michael Niedermayer
On Sat, Jan 11, 2020 at 02:27:22PM +0100, Michael Niedermayer wrote: > Fixes: bypassing of checks and assertion failure > Fixes: asan_1003879.mp4 > > Found-by: Clusterfuzz + asan > Reported-by: Thomas Guilbert > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 4 > 1 file cha

Re: [FFmpeg-devel] [PATCH 3/3] tools/target_dec_fuzzer: limit per frame samples for APE

2020-01-30 Thread Michael Niedermayer
On Fri, Jan 10, 2020 at 11:03:53PM +0100, Michael Niedermayer wrote: > APE in its highest compression mode is really slow so even one frame > of millions of samples takes a long time > > Fixes: Timeout (too long -> 3sec) > Fixes: > 19937/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzze

Re: [FFmpeg-devel] [PATCH] avcodec/ralf: Fix overflows of biased values

2020-01-30 Thread Michael Niedermayer
On Fri, Dec 27, 2019 at 12:43:25AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2003010644 * 2 cannot be represented in type > 'int' > Fixes: > 19593/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RALF_fuzzer-5660628006207488 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/x86/diracdsp: Fix incorrect src addressing in dequant_subband_32()

2020-01-30 Thread James Almer
On 1/29/2020 6:55 PM, Michael Niedermayer wrote: > Fixes: Segfault (not reproducable with asm, which made this hard to debug) > Fixes: decoding errors > Fixes: > 19854/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5729372837511168 > > Found-by: continuous fuzzing process > https

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix hls_ts_options with mpegts

2020-01-30 Thread Marton Balint
On Wed, 22 Jan 2020, Marton Balint wrote: Was broken since cdbf8847ea97a985dfd55432e1384bb7fe5d2d3b. Ping, will apply soon. Thanks, Marton Signed-off-by: Marton Balint --- libavformat/hlsenc.c | 36 +--- 1 file changed, 17 insertions(+), 19 deletions(-) d

[FFmpeg-devel] [PATCH] avfilter/vf_ssim: improve precision

2020-01-30 Thread Paul B Mahol
Use doubles for accumulating floats. Signed-off-by: Paul B Mahol --- libavfilter/ssim.h | 2 +- libavfilter/vf_ssim.c | 18 - libavfilter/x86/vf_ssim.asm| 36 ++ libavfilter/x86/vf_ssim_init.c | 2 +- 4 files changed, 35

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/x86/diracdsp: Fix incorrect src addressing in dequant_subband_32()

2020-01-30 Thread Michael Niedermayer
On Thu, Jan 30, 2020 at 05:14:18PM -0300, James Almer wrote: > On 1/29/2020 6:55 PM, Michael Niedermayer wrote: > > Fixes: Segfault (not reproducable with asm, which made this hard to debug) > > Fixes: decoding errors > > Fixes: > > 19854/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuz

Re: [FFmpeg-devel] Unable to log into the bug tracker

2020-01-30 Thread Michael Niedermayer
On Thu, Jan 30, 2020 at 08:07:36PM +0100, Alberto Salvia Novella wrote: > Screencast you succeeded in creating your account but it has no verified email address associated with it. check your spam folder for a email with a verify link maybe Thanks -- Michael G

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/x86/diracdsp: Fix incorrect src addressing in dequant_subband_32()

2020-01-30 Thread Carl Eugen Hoyos
Am Mi., 29. Jan. 2020 um 22:56 Uhr schrieb Michael Niedermayer : > > Fixes: Segfault (not reproducable with asm, which made this hard to debug) without? > Fixes: decoding errors > Fixes: > 19854/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5729372837511168 > > Found-by: contin

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpeg12dec: Fix invalid shift in mpeg2_fast_decode_block_intra()

2020-01-30 Thread Carl Eugen Hoyos
Am Do., 26. Dez. 2019 um 03:22 Uhr schrieb Kieran Kunhya : > Can we not remove this "fast" code? Decoding MPEG-2 is not exactly hard in > 2019. The world is not a VAX, or multi-cpu x86- > Also it has the following comment associated with it: > > /** > * Note: this function can read out of range

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/x86/diracdsp: Fix incorrect src addressing in dequant_subband_32()

2020-01-30 Thread Michael Niedermayer
On Thu, Jan 30, 2020 at 11:11:27PM +0100, Carl Eugen Hoyos wrote: > Am Mi., 29. Jan. 2020 um 22:56 Uhr schrieb Michael Niedermayer > : > > > > Fixes: Segfault (not reproducable with asm, which made this hard to debug) > > without? well i had the testcase from ossfuzz but that didnt reproduce

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/x86/diracdsp: Fix incorrect src addressing in dequant_subband_32()

2020-01-30 Thread Michael Niedermayer
On Thu, Jan 30, 2020 at 10:11:05PM +0100, Michael Niedermayer wrote: > On Thu, Jan 30, 2020 at 05:14:18PM -0300, James Almer wrote: > > On 1/29/2020 6:55 PM, Michael Niedermayer wrote: > > > Fixes: Segfault (not reproducable with asm, which made this hard to debug) > > > Fixes: decoding errors > >

Re: [FFmpeg-devel] [PATCH 1/6] avutil/common: use unsigned int in GET_UTF8

2020-01-30 Thread Marton Balint
On Thu, 30 Jan 2020, Paul B Mahol wrote: bug in commit message, otherwise lgtm Thanks, pushed the series. Regards, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit

Re: [FFmpeg-devel] [PATCH V1] cmdutils: fix crash if no name for "ffmpeg -h protocol"

2020-01-30 Thread Liu Steven
> 在 2020年1月30日,下午10:03,Jun Zhao 写道: > > From: Jun Zhao > > fix crash when used the command like: > - ffmpeg -h protocol > - ffmpeg -h protocol= > > Signed-off-by: Jun Zhao > --- > fftools/cmdutils.c |8 +++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/fftools

[FFmpeg-devel] [PATCH] avformat/protocols: check protocol name before foreach

2020-01-30 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/protocols.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/protocols.c b/libavformat/protocols.c index 29fb99e7fa..c692342132 100644 --- a/libavformat/protocols.c +++ b/libavformat/protocols.c @@ -110,6 +110,8 @@ const char *avio_enum_p

[FFmpeg-devel] [PATCH v2] avfilter/scale: fix CID 1457833

2020-01-30 Thread Gyan Doshi
Remove expressions with constant results and improve overflow checks. --- libavfilter/vf_scale.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 0348f19d33..b6c6414258 100644 --- a/libavfilter/vf_scale.c +++ b/libavfil