[FFmpeg-devel] [PATCH] avfilter/scene_sad: add AArch64 SIMD

2020-02-01 Thread quinkblack
From: Zhao Zhili For 8 bit depth: ./ffmpeg -threads 1 -f lavfi -t 10 -i 'yuvtestsrc=size=4096x2048,format=yuv444p' -vf 'freezedetect' -f null -benchmark - Test results on Snapdragon 845: Before: frame= 250 fps= 23 q=-0.0 Lsize=N/A time=00:00:10.00 bitrate=N/A speed=0.924x

Re: [FFmpeg-devel] [PATCH] af_volume: fix integer clip

2020-02-01 Thread zhilizhao
> On Jan 27, 2020, at 6:28 PM, Zhao Zhili wrote: > > > >> On Jan 27, 2020, at 12:59 AM, Carl Eugen Hoyos > > wrote: >> >> Am So., 26. Jan. 2020 um 17:13 Uhr schrieb Zhao Zhili >> mailto:quinkbl...@foxmail.com>>: >>> >>> --- >>> Or specify an upper limit on volume

Re: [FFmpeg-devel] [PATCH] avfilter/af_anlmdn: add AArch64 SIMD for compute_distance_ssd

2020-02-01 Thread zhilizhao
> On Jan 25, 2020, at 12:13 AM, Carl Eugen Hoyos wrote: > > Am Fr., 24. Jan. 2020 um 10:15 Uhr schrieb Zhao Zhili >: >> >> ./ffmpeg -threads 1 -f lavfi -t 60 -i anoisesrc -af 'anlmdn' -f null >> -benchmark - >> >> Test results on Snapdragon 845: >>Before:

Re: [FFmpeg-devel] [PATCH] avfilter/af_afir: add AArch64 SIMD for fcmul_add

2020-02-01 Thread zhilizhao
> On Jan 24, 2020, at 6:54 PM, Paul B Mahol wrote: > > Seems very trivial. Yes it is. Please help review the patch, thanks! > > On 1/18/20, Zhao Zhili wrote: >> ./ffmpeg -threads 1 -f lavfi -i anoisesrc -f lavfi -t 30 -i anoisesrc -t >> 600 -lavfi afir -benchmark -f null - >> >> Test re

Re: [FFmpeg-devel] [IMPORTANT] FOSDEM meeting

2020-02-01 Thread James Darnley
On 28/01/2020, Liu Steven wrote: > > >> 在 2020年1月27日,下午3:29,Jean-Baptiste Kempf 写道: >> It will be joinable through some VideoConf tool. > Can we join by IRC or other things on internet? > Because these days are Spring Festival (Chinese New Year, Important > festivals that have lasted for thousand

Re: [FFmpeg-devel] [IMPORTANT] FOSDEM meeting

2020-02-01 Thread Jean-Baptiste Kempf
On Sat, 1 Feb 2020, at 11:32, James Darnley wrote: > On 28/01/2020, Liu Steven wrote: > >> 在 2020年1月27日,下午3:29,Jean-Baptiste Kempf 写道: > >> It will be joinable through some VideoConf tool. > > Can we join by IRC or other things on internet? > > Because these days are Spring Festival (Chinese Ne

Re: [FFmpeg-devel] Unable to log into the bug tracker

2020-02-01 Thread Michael Niedermayer
On Thu, Jan 30, 2020 at 10:32:56PM +0100, Michael Niedermayer wrote: > On Thu, Jan 30, 2020 at 08:07:36PM +0100, Alberto Salvia Novella wrote: > > Screencast > > you succeeded in creating your account but it has no verified email address > associated with it. > check

Re: [FFmpeg-devel] What new instructions would you like?

2020-02-01 Thread James Darnley
On 30/12/2019, Lauri Kasanen wrote: > Hi, > > For the Libre RISC-V project, I'm going to research the popular codecs > and design new instructions to help speed them up. With ffmpeg being > home to lots of asm folks for many platforms, I also want to ask your > opinion. > > What new instructions w

Re: [FFmpeg-devel] [PATCH] af_volume: fix integer clip

2020-02-01 Thread Michael Niedermayer
On Sat, Feb 01, 2020 at 06:06:39PM +0800, zhilizhao wrote: > > > > On Jan 27, 2020, at 6:28 PM, Zhao Zhili wrote: > > > > > > > >> On Jan 27, 2020, at 12:59 AM, Carl Eugen Hoyos >> > wrote: > >> > >> Am So., 26. Jan. 2020 um 17:13 Uhr schrieb Zhao Zhili > >> mail

Re: [FFmpeg-devel] [PATCH] Vulkan hwcontext and filters

2020-02-01 Thread Lynne
Jan 21, 2020, 23:03 by s...@jkqxz.net: > On 10/01/2020 21:05, Lynne wrote: > >> From 04c1836f89d89dcdc892cef66ee82afbcfda9f2d Mon Sep 17 00:00:00 2001 >> From: Lynne >> Date: Sun, 27 Oct 2019 14:44:00 + >> Subject: [PATCH 4/9] lavfi: add Vulkan filtering framework >> >> This commit adds a Vul

Re: [FFmpeg-devel] [PATCH] af_volume: fix integer clip

2020-02-01 Thread zhilizhao
> On Feb 1, 2020, at 8:00 PM, Michael Niedermayer > wrote: > > On Sat, Feb 01, 2020 at 06:06:39PM +0800, zhilizhao wrote: >> >> >>> On Jan 27, 2020, at 6:28 PM, Zhao Zhili wrote: >>> >>> >>> On Jan 27, 2020, at 12:59 AM, Carl Eugen Hoyos >>> > wrote:

[FFmpeg-devel] [PATCH] avfilter: add afirsrc filter

2020-02-01 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 38 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/asrc_afirsrc.c | 330 + 4 files changed, 370 insertions(+) create mode 100644 libavfilter/asrc_afirsrc.c

Re: [FFmpeg-devel] [PATCH] avfilter: add xfade opencl filter

2020-02-01 Thread Mark Thompson
On 26/01/2020 18:28, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure | 1 + > doc/filters.texi | 97 > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/opencl/xfade.cl | 136 +++

Re: [FFmpeg-devel] [PATCH 001/244] Add a new channel layout API

2020-02-01 Thread Nicolas George
Anton Khirnov (12020-01-28): > That makes no sense. The filter cannot "have needs" when the current API > does not support the use case you have in mind (which is good). The > filter can either be modified to allow multiple inputs or a new filter > can be added. It makes perfect sense: I know what

Re: [FFmpeg-devel] [PATCH] lavc/h265_profile_level: Fix the default profile in ff_h265_guess_level

2020-02-01 Thread Mark Thompson
On 15/01/2020 06:54, Linjie Fu wrote: > Default to use multiplication factors for Main profile. > > Introduced since cd3578a8e4e11e0ba021e621367a7974d6de5da0. > > Fixed the notation at the same time. > > Signed-off-by: Linjie Fu > --- > libavcodec/h265_profile_level.c | 4 ++-- > 1 file change

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: cope with race map for YUV420P

2020-02-01 Thread Mark Thompson
On 15/01/2020 06:55, Linjie Fu wrote: > There is a race condition for AV_PIX_FMT_YUV420P when mapping from pix_fmt > to fourcc, both VA_FOURCC_I420 and VA_FOURCC_YV12 could be found by pix_fmt. The title and this comment are very confusing. As far as I can see this has nothing to do with a race

Re: [FFmpeg-devel] [PATCH 001/244] Add a new channel layout API

2020-02-01 Thread Paul B Mahol
On 2/1/20, Nicolas George wrote: > Anton Khirnov (12020-01-28): >> That makes no sense. The filter cannot "have needs" when the current API >> does not support the use case you have in mind (which is good). The >> filter can either be modified to allow multiple inputs or a new filter >> can be add

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-01 Thread Mark Thompson
On 15/01/2020 07:05, Linjie Fu wrote: > Currently, ffmpeg inserts scale filter by default in the filter graph > to force the whole decoded stream to scale into the same size with the > first frame. It's not quite make sense in resolution changing cases if > user wants the rawvideo without any scale

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/amfenc_hevc.c: Fix constant QP settings for I, P

2020-02-01 Thread Mark Thompson
On 28/01/2020 16:23, OvchinnikovDmitrii wrote: > --- > libavcodec/amfenc_hevc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/amfenc_hevc.c b/libavcodec/amfenc_hevc.c > index 7c9a33ab33..8b4d289fac 100644 > --- a/libavcodec/amfenc_hevc.c > +++ b/libavcode

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/amfenc_hevc.c: Fix Profile level option on AMF HEVC.

2020-02-01 Thread Mark Thompson
On 28/01/2020 16:23, OvchinnikovDmitrii wrote: > Patch was made by Sitan Liu If you are not the author then please ensure that the git author field is filled correctly. > The same code already exists in amfenc_h264.c > --- > libavcodec/amfenc_hevc.c | 4 ++-- > 1 file changed, 2 insertions(+),

Re: [FFmpeg-devel] [PATCH V2] fate/filter-video.mak: do not use bit-exact check for dnn_processing

2020-02-01 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: Wednesday, January 22, 2020 9:45 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun > Subject: [PATCH V2] fate/filter-video.mak: do not use bit-exact check for > dnn_processing > > The reason is that the tested models are in float format. A

Re: [FFmpeg-devel] [PATCH v2] lavc/qsv: adding DX11 support

2020-02-01 Thread Mark Thompson
On 24/01/2020 19:37, Artem Galin wrote: > On Fri, 24 Jan 2020 at 00:46, Mark Thompson wrote: > >> On 23/01/2020 15:18, Artem Galin wrote: >>> This enables DX11 support for QSV with higher priority than DX9. >>> In case of multiple GPUs configuration, DX9 API does not allow to get >>> access to QS

[FFmpeg-devel] [PLEASE IGNORE] [PATCH] avfilter: add xfade opencl filter

2020-02-01 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- configure | 1 + doc/filters.texi | 97 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/opencl/xfade.cl | 145 +++ libavfilter/opencl_source.h | 1 + libavfilter/vf

Re: [FFmpeg-devel] [PATCH] avcodec/binkaudio: Check sample_rate to avoid integer overflow

2020-02-01 Thread Michael Niedermayer
On Tue, Jan 14, 2020 at 04:04:29PM +0100, Paul B Mahol wrote: > This better belong to generic code. This specific check (which checks for INT_MAX) is specific to our bink audio code which does a +1 so it would not fit in generic code We could arbitrarily decide on a maximum sample rate hardcode t

Re: [FFmpeg-devel] [PATCH] avcodec/binkaudio: Check sample_rate to avoid integer overflow

2020-02-01 Thread Paul B Mahol
On 2/1/20, Michael Niedermayer wrote: > On Tue, Jan 14, 2020 at 04:04:29PM +0100, Paul B Mahol wrote: >> This better belong to generic code. > > This specific check (which checks for INT_MAX) is specific to our > bink audio code which does a +1 > so it would not fit in generic code > > We could ar

[FFmpeg-devel] [PATCH] MAINTAINERS: Add myself as mxf* maintainer

2020-02-01 Thread Tomas Härdin
Hi I've been poking at mxfdec recently, and I keep an eye on the mxf tag on trac, so I might as well add myself as maintainer again. /Tomas From 87f37fdbddc72aa472b9b5ce9d69ed77dcf9ed74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Sat, 1 Feb 2020 16:15:53 +0100 Subject: [

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add myself as mxf* maintainer

2020-02-01 Thread Paul B Mahol
On 2/1/20, Tomas Härdin wrote: > Hi > > I've been poking at mxfdec recently, and I keep an eye on the mxf tag > on trac, so I might as well add myself as maintainer again. > > /Tomas > Do you plan to waste significant non trivial time on mxf and plan send patches instead of arguing how same code

Re: [FFmpeg-devel] [PATCH V2] fate/filter-video.mak: do not use bit-exact check for dnn_processing

2020-02-01 Thread zhilizhao
> On Feb 1, 2020, at 10:50 PM, Guo, Yejun wrote: > > > >> -Original Message- >> From: Guo, Yejun >> Sent: Wednesday, January 22, 2020 9:45 PM >> To: ffmpeg-devel@ffmpeg.org >> Cc: Guo, Yejun >> Subject: [PATCH V2] fate/filter-video.mak: do not use bit-exact check for >> dnn_processin

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add myself as mxf* maintainer

2020-02-01 Thread Carl Eugen Hoyos
> Am 01.02.2020 um 16:22 schrieb Paul B Mahol : > >> On 2/1/20, Tomas Härdin wrote: >> Hi >> >> I've been poking at mxfdec recently, and I keep an eye on the mxf tag >> on trac, so I might as well add myself as maintainer again. >> >> /Tomas >> > > Do you plan to waste significant non trivi

Re: [FFmpeg-devel] [PATCH V2] fate/filter-video.mak: do not use bit-exact check for dnn_processing

2020-02-01 Thread Carl Eugen Hoyos
> Am 01.02.2020 um 15:50 schrieb Guo, Yejun : > Just checked the master and found the original patch is reverted. Yes, I sent an email as a reply to the relevant mailing list thread (created by you) to the list: http://ffmpeg.org/pipermail/ffmpeg-devel/2020-January/256482.html > I'm ok for i

Re: [FFmpeg-devel] [PATCH] avcodec/utils: remove extra brackets

2020-02-01 Thread Michael Niedermayer
On Sat, Feb 01, 2020 at 05:12:13PM +0800, leozhang wrote: > Signed-off-by: leozhang > --- > libavcodec/utils.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary,

Re: [FFmpeg-devel] What new instructions would you like?

2020-02-01 Thread Lauri Kasanen
On Sat, 1 Feb 2020 12:53:28 +0100 James Darnley wrote: > On 30/12/2019, Lauri Kasanen wrote: > > For the Libre RISC-V project, I'm going to research the popular codecs > > and design new instructions to help speed them up. With ffmpeg being > > home to lots of asm folks for many platforms, I als

Re: [FFmpeg-devel] [PATCH] avcodec/adpcm_argo: simplify and move duplicated logic into a function

2020-02-01 Thread Michael Niedermayer
On Sat, Feb 01, 2020 at 06:59:59AM +, Zane van Iperen wrote: > Signed-off-by: Zane van Iperen > --- > libavcodec/adpcm.c | 40 ++-- > 1 file changed, 18 insertions(+), 22 deletions(-) it seems theres no fate test for adpcm_argo this patch looks ok but the

[FFmpeg-devel] [PATCH] avformat: Add AMQP version 0-9-1 protocol support

2020-02-01 Thread Andriy Gelman
From: Andriy Gelman Supports connecting to a RabbitMQ broker via AMQP version 0-9-1. The broker can redistribute content to other clients based on "exchange" and "routing_key" fields. --- Compilation notes: - Requires librabbitmq-dev package (on ubuntu). - The pkg-config libprabbitmq.pc has a c

Re: [FFmpeg-devel] [PATCH] lavc/ac3dec: disable DRC by default

2020-02-01 Thread Paul B Mahol
On 1/29/20, rcombs wrote: > This issue has been argued before, with the status quo being preserved under > the logic that the spec says this parameter is supposed to default to 1, > and that we should follow the spec. The spec was misguided, and thus so was > blindly following it. > > The (E-)AC3

[FFmpeg-devel] [PATCH] lavc/ac3dec: disable DRC by default

2020-02-01 Thread rcombs
This issue has been argued before, with the status quo being preserved under the logic that the spec says this parameter is supposed to default to 1, and that we should follow the spec. The spec was misguided, and thus so was blindly following it. The (E-)AC3 DRC architecture is a clever optimizat

Re: [FFmpeg-devel] [PATCH] lavc/ac3dec: disable DRC by default

2020-02-01 Thread James Almer
On 2/1/2020 4:34 PM, rcombs wrote: > This issue has been argued before, with the status quo being preserved under > the logic that the spec says this parameter is supposed to default to 1, > and that we should follow the spec. The spec was misguided, and thus so was > blindly following it. > > The

Re: [FFmpeg-devel] [PATCH] lavc/ac3dec: disable DRC by default

2020-02-01 Thread Derek Buitenhuis
On 01/02/2020 19:34, rcombs wrote: > This issue has been argued before, with the status quo being preserved under > the logic that the spec says this parameter is supposed to default to 1, > and that we should follow the spec. The spec was misguided, and thus so was > blindly following it. If "I d

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add myself as mxf* maintainer

2020-02-01 Thread Marton Balint
On Sat, 1 Feb 2020, Carl Eugen Hoyos wrote: Am 01.02.2020 um 16:22 schrieb Paul B Mahol : On 2/1/20, Tomas Härdin wrote: Hi I've been poking at mxfdec recently, and I keep an eye on the mxf tag on trac, so I might as well add myself as maintainer again. /Tomas Do you plan to waste s

[FFmpeg-devel] [EXTREMELY IMPORTANT] [PLEASE DO NOT IGNORE] [PATCH] avfilter/framesync: do not pick AV_TIME_BASE for time base when not needed.

2020-02-01 Thread Paul B Mahol
Fixes picking time base when all input time bases are same and for example 20833/50. Signed-off-by: Paul B Mahol --- libavfilter/framesync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/framesync.c b/libavfilter/framesync.c index bc95f7d904..94abb469e6 1006

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add myself as mxf* maintainer

2020-02-01 Thread Paul B Mahol
On 2/1/20, Marton Balint wrote: > > > On Sat, 1 Feb 2020, Carl Eugen Hoyos wrote: > >> >> >>> Am 01.02.2020 um 16:22 schrieb Paul B Mahol : >>> On 2/1/20, Tomas Härdin wrote: Hi I've been poking at mxfdec recently, and I keep an eye on the mxf tag on trac, so I might as w

Re: [FFmpeg-devel] [PATCH] lavc/ac3dec: disable DRC by default

2020-02-01 Thread Paul B Mahol
On 2/1/20, Derek Buitenhuis wrote: > On 01/02/2020 19:34, rcombs wrote: >> This issue has been argued before, with the status quo being preserved >> under >> the logic that the spec says this parameter is supposed to default to 1, >> and that we should follow the spec. The spec was misguided, and

Re: [FFmpeg-devel] [PATCH] avfilter/scene_sad: add AArch64 SIMD

2020-02-01 Thread Marton Balint
On Sat, 1 Feb 2020, quinkbl...@foxmail.com wrote: From: Zhao Zhili For 8 bit depth: ./ffmpeg -threads 1 -f lavfi -t 10 -i 'yuvtestsrc=size=4096x2048,format=yuv444p' -vf 'freezedetect' -f null -benchmark - Test results on Snapdragon 845: Before: frame= 250 fps= 23 q=-0.0 L

Re: [FFmpeg-devel] [PATCH 1/2] avformat/udp: remove setting cancel state from the TX thread

2020-02-01 Thread Marton Balint
On Sun, 26 Jan 2020, Marton Balint wrote: Write mode does not use cancellation. Ping, will apply the series soon. Thanks, Marton Signed-off-by: Marton Balint --- libavformat/udp.c | 4 1 file changed, 4 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index dce4cf76c

Re: [FFmpeg-devel] [PATCH] lavc/ac3dec: disable DRC by default

2020-02-01 Thread Derek Buitenhuis
On 01/02/2020 20:18, Paul B Mahol wrote: > This does not have much logic or valid reasoning. Please stop your constant vague troll replies and ad hominem attacks. They are rampant on this mailing list; practically every thread, but specifically against some people. It's getting ridiculous. It mak

Re: [FFmpeg-devel] [PATCH] lavc/ac3dec: disable DRC by default

2020-02-01 Thread Paul B Mahol
On 2/1/20, Derek Buitenhuis wrote: > On 01/02/2020 20:18, Paul B Mahol wrote: >> This does not have much logic or valid reasoning. > > Please stop your constant vague troll replies and ad hominem attacks. I was not vague, your reasoning that because of dolby we need to comply to some standards is

Re: [FFmpeg-devel] [PATCH] lavc/ac3dec: disable DRC by default

2020-02-01 Thread Derek Buitenhuis
On 01/02/2020 20:37, Paul B Mahol wrote: > I was not vague, your reasoning that because of dolby we need to comply to > some > standards is not good. > Even dolby does not follow this as already mentioned on this same thread. So write this in the email instead of one completely devoid of any reas

Re: [FFmpeg-devel] [PATCH] lavc/ac3dec: disable DRC by default

2020-02-01 Thread Paul B Mahol
On 2/1/20, Derek Buitenhuis wrote: > On 01/02/2020 20:37, Paul B Mahol wrote: >> I was not vague, your reasoning that because of dolby we need to comply to >> some >> standards is not good. >> Even dolby does not follow this as already mentioned on this same thread. > > So write this in the email

Re: [FFmpeg-devel] [PATCH] lavc/ac3dec: disable DRC by default

2020-02-01 Thread rcombs
> On Feb 1, 2020, at 13:43, Derek Buitenhuis wrote: > > On 01/02/2020 19:34, rcombs wrote: >> This issue has been argued before, with the status quo being preserved under >> the logic that the spec says this parameter is supposed to default to 1, >> and that we should follow the spec. The spec

Re: [FFmpeg-devel] [PATCH 2/6] avcodec:v4l2_context: Remove NULL initialization

2020-02-01 Thread Mark Thompson
On 13/01/2020 04:11, Andriy Gelman wrote: > From: Andriy Gelman > > Signed-off-by: Andriy Gelman > --- > libavcodec/v4l2_context.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > On 13/01/2020 04:11, Andriy Gelman wrote:> From: Andriy Gelman > > Before this commit s->avctx =

Re: [FFmpeg-devel] [PATCH] lavc/ac3dec: disable DRC by default

2020-02-01 Thread Derek Buitenhuis
On 01/02/2020 21:03, rcombs wrote: > >> If "I don't agree with the spec" or "this spec does something stupid" were >> valid >> arguments, we may as well not have specs at all, and FFmpeg would have a lot >> more >> garbage in it. You can write at length why you think it's bad, but that does >>

Re: [FFmpeg-devel] [PATCH] lavc/ac3dec: disable DRC by default

2020-02-01 Thread rcombs
> On Feb 1, 2020, at 15:55, Derek Buitenhuis wrote: > >>> and the defacto way to handle decoding AC-3. >> >> Is it, though? My understanding is that AV receivers usually only enable AC3 >> DRC in "night mode" or the like, and few even provide a fully-tunable >> setting for it. Apple's decode

Re: [FFmpeg-devel] [PATCH] lavc/ac3dec: disable DRC by default

2020-02-01 Thread Derek Buitenhuis
On 01/02/2020 22:02, rcombs wrote: >> Because the spec defines what is de facto - it is what defines what AC-3 >> *is*. >> You are choosing to ignore it here because you don't like what's in it. > > This is "de jure"; "de facto" means how it's actually implemented in practice. Woops, yes, you ar

Re: [FFmpeg-devel] [PATCH v2] avcodec/v4l2_m2m_enc: Support changing qmin/qmax

2020-02-01 Thread Mark Thompson
On 19/01/2020 19:54, Andriy Gelman wrote: > From: Andriy Gelman > > Hard coded parameters for qmin and qmax are currently used to initialize > v4l2_m2m device. This commit uses values from avctx->{qmin,qmax} if they > are set. > > Signed-off-by: Andriy Gelman > --- > libavcodec/v4l2_m2m_enc.c

Re: [FFmpeg-devel] [PATCH] avcodec/binkaudio: Check sample_rate to avoid integer overflow

2020-02-01 Thread Michael Niedermayer
On Sat, Feb 01, 2020 at 04:17:10PM +0100, Paul B Mahol wrote: > On 2/1/20, Michael Niedermayer wrote: > > On Tue, Jan 14, 2020 at 04:04:29PM +0100, Paul B Mahol wrote: > >> This better belong to generic code. > > > > This specific check (which checks for INT_MAX) is specific to our > > bink audio

[FFmpeg-devel] [PATCH 1/2] lavc/dvdsubdec: Move palette parsing to new function

2020-02-01 Thread Michael Kuron
Signed-off-by: Michael Kuron --- doc/decoders.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/dvdsub.c| 33 + libavcodec/dvdsubdec.c | 22 ++ libavcodec/internal.h | 2 ++ 5 files changed, 43 insertions(+), 17 deletions(-) cr

[FFmpeg-devel] [PATCH 2/2] lavc/dvdsubenc: accept palette from options

2020-02-01 Thread Michael Kuron
Previously, the default palette would always be used. Now, we can accept a custom palette, just like dvdsubdec does. Signed-off-by: Michael Kuron --- doc/encoders.texi | 8 libavcodec/Makefile| 1 + libavcodec/dvdsubenc.c | 8 +++- 3 files changed, 16 insertions(+), 1 delet

Re: [FFmpeg-devel] [PATCH v3] doc/v4l2_m2m: Add documentation

2020-02-01 Thread Mark Thompson
On 17/01/2020 03:42, Andriy Gelman wrote: > From: Andriy Gelman > > Signed-off-by: Andriy Gelman > --- > > Gyan, I added an extra paragraph about the buffer parameters. It doesn't seem > right to add the same content into each bullet point. Let me know your > thoughts. The discussion of them

Re: [FFmpeg-devel] [PATCH] avcodec/adpcm_argo: simplify and move duplicated logic into a function

2020-02-01 Thread Zane van Iperen
2/2/20 4:04 am, Michael Niedermayer пишет: > > On Sat, Feb 01, 2020 at 06:59:59AM +, Zane van Iperen wrote: >> Signed-off-by: Zane van Iperen >> --- >> libavcodec/adpcm.c | 40 ++-- >> 1 file changed, 18 insertions(+), 22 deletions(-) > > it seems there

[FFmpeg-devel] [PATCH 4/4] avcodec/ac3dec_fixed: Remove some temporary variables from scale_coefs()

2020-02-01 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/ac3dec_fixed.c | 30 -- 1 file changed, 8 insertions(+), 22 deletions(-) diff --git a/libavcodec/ac3dec_fixed.c b/libavcodec/ac3dec_fixed.c index 1e1edc8964..336a538cad 100644 --- a/libavcodec/ac3dec_fixed.c +++ b/liba

[FFmpeg-devel] [PATCH 3/4] avcodec/mlpdsp: Fix a invalid shift in ff_mlp_rematrix_channel()

2020-02-01 Thread Michael Niedermayer
Fixes: left shift of negative value -2 Fixes: 20305/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEHD_fuzzer-5677196618498048 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mlpdsp.c |

[FFmpeg-devel] [PATCH 1/4] avcodec/ac3dec_fixed: Fix several invalid left shifts in scale_coefs()

2020-02-01 Thread Michael Niedermayer
Fixes: left shift of negative value -14336 Fixes: 20298/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AC3_FIXED_fuzzer-5675484201615360 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/ac3d

[FFmpeg-devel] [PATCH 2/4] avcodec/flacdsp_template: Fix invalid shifts in decorrelate

2020-02-01 Thread Michael Niedermayer
Fixes: left shift of negative value -2 Fixes: 20303/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLAC_fuzzer-5096829297623040 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/flacdsp_templ

[FFmpeg-devel] [PATCH 1/1] libswscale: add area upscale

2020-02-01 Thread Pavel Klimov
area upscale is similar to neighbor upscale, just better with non integer factors. math comes from assumption that neighbor filter works fine, and then integrate it over pixel width. Signed-off-by: Pavel Klimov --- libswscale/options.c | 1 + libswscale/swscale.h | 1 + libswscale/utils.c |

[FFmpeg-devel] [PATCH 0/1] libswscale: add area upscale

2020-02-01 Thread Pavel Klimov
I often encode pixelated videos from old game consoles emulators. Usual workaround is upscale with neighbor, or exceeding upscale followed by lanczos downscale. I knew that area upscale should give similar effect, but didn't take effort to find out why ffmpeg with area method doesn't give what I ex

Re: [FFmpeg-devel] [PATCH v2] avcodec/v4l2_m2m_enc: Support changing qmin/qmax

2020-02-01 Thread Andriy Gelman
On Sat, 01. Feb 22:38, Mark Thompson wrote: > On 19/01/2020 19:54, Andriy Gelman wrote: > > From: Andriy Gelman > > > > Hard coded parameters for qmin and qmax are currently used to initialize > > v4l2_m2m device. This commit uses values from avctx->{qmin,qmax} if they > > are set. > > > > Signe

[FFmpeg-devel] [PATCH v1] avformat/sdp, rtsp: add rtcp attribute to sdp file

2020-02-01 Thread Jun Li
Fix #8479 1. write rtcpport to sdp file when rtpport is specified in url 2. apply rtcpport when sdp file contains rtcp attribute Signed-off-by: Jun Li --- libavformat/rtpproto.c | 11 +++ libavformat/rtpproto.h | 2 ++ libavformat/rtsp.c | 12 ++-- libavformat/rtsp.h |

Re: [FFmpeg-devel] [PATCH V2] fate/filter-video.mak: do not use bit-exact check for dnn_processing

2020-02-01 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Carl Eugen Hoyos > Sent: Sunday, February 02, 2020 12:13 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V2] fate/filter-video.mak: do not use > bit-

Re: [FFmpeg-devel] [PATCH] avfilter/scene_sad: add AArch64 SIMD

2020-02-01 Thread zhilizhao
> On Feb 2, 2020, at 4:26 AM, Marton Balint wrote: > > > > On Sat, 1 Feb 2020, quinkbl...@foxmail.com > wrote: > >> From: Zhao Zhili >> >> For 8 bit depth: >> ./ffmpeg -threads 1 -f lavfi -t 10 -i >> 'yuvtestsrc=size=4096x2048,format=yuv444p' -vf 'freeze

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-01 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Mark Thompson > Sent: Saturday, February 1, 2020 22:18 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale > to disable/enable the default scale > > On 15/01/2020 07:05, Linjie F

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec/cbs_jpeg: Use memcpy when writing pictures

2020-02-01 Thread Andreas Rheinhardt
Andreas Rheinhardt: > This is possible because the size of a scan header is always a multiple > of a byte. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cbs_jpeg.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/cbs_jpeg.c b/libavcodec/c