Re: [FFmpeg-devel] [EXTREMELY IMPORTANT] [PLEASE DO NOT IGNORE] [PATCH] avfilter/framesync: do not pick AV_TIME_BASE for time base when not needed.

2020-02-05 Thread Nicolas George
Paul B Mahol (12020-02-05): > I will write patch that fixes this. As unnecessary changing time-base > is wrong way around. I do not want several code paths, requiring extra testing in case of change, unless it is necessary. There is no mystique about the time base: the current code finds one that

[FFmpeg-devel] [PATCH v2 2/2] avformat: add demuxer for Simon & Schuster Interactive's VAG format

2020-02-05 Thread Zane van Iperen
Adds support for the custom VAG container used by some Simon & Schuster Interactive games such as Real War, and Real War: Rogue States. Signed-off-by: Zane van Iperen --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/kvag.c | 117 ++

[FFmpeg-devel] [PATCH v2 0/2] Simon & Schuster Interactive VAG demuxer + decoder.

2020-02-05 Thread Zane van Iperen
Hi all, This patchset adds support for the VAG container and ADPCM variant used by some Simon & Schuster Interactive games such as 'Real War', and 'Real War: Rogue States'. It has been tested against VAG files from both games. v2: - simplify the demuxer - fix error in header structure Some

[FFmpeg-devel] [PATCH v2 1/2] avcodec: add decoder for Simon & Schuster Interactive's ADPCM variant

2020-02-05 Thread Zane van Iperen
Adds support for the ADPCM variant used by some Simon & Schuster Interactive games such as Real War, and Real War: Rogue States. Signed-off-by: Zane van Iperen --- libavcodec/Makefile | 1 + libavcodec/adpcm.c | 10 ++ libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h|

Re: [FFmpeg-devel] [PATCH] avcodec/aptx: split decoder and encoder into separate files

2020-02-05 Thread James Almer
On 1/27/2020 3:36 PM, James Almer wrote: > On 12/8/2019 12:11 PM, James Almer wrote: >> Signed-off-by: James Almer >> --- >> Untested beyond checking it compiles because there are no FATE tests for >> either >> module. >> >> libavcodec/Makefile | 8 +- >> libavcodec/aptx.c| 634 +-

Re: [FFmpeg-devel] [PATCH v5 2/2] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2020-02-05 Thread James Zern
On Mon, Feb 3, 2020 at 5:45 PM Wonkap Jang wrote: > > Hi > > On Mon, Feb 3, 2020 at 12:45 PM James Zern > wrote: > > > On Mon, Feb 3, 2020 at 10:02 AM Wonkap Jang > > wrote: > > > > > > In order for rate control to correctly allocate bitrate to each temporal > > > layer, correct temporal layer i

Re: [FFmpeg-devel] [PATCH] avfilter/pad: round output width/height up instead of down. Fixes bugs #1618 and #8475.

2020-02-05 Thread Ivan Middleton
Hoping someone can review this and apply it if it looks good. > The pad filter is currently broken for cases where all of the following hold: > > (1) chroma subsampling exists (very common), > > (2) an input dimension is odd (uncommon), and > > (3) the corresponding output dimension is either t

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: allow a custom SDT and PAT period

2020-02-05 Thread Marton Balint
On Wed, 5 Feb 2020, Steven Liu wrote: Marton Balint 于 2020年2月5日周三 上午5:39写道: The default is not to write SDT and PAT periodically, only in the beginning of every segment. After this patch the user might override this if needed. Signed-off-by: Marton Balint --- libavformat/hlsenc.c | 4 ++-

[FFmpeg-devel] [PATCH] checkasm: sbrdsp: Fix a spurious test failure by calculating a better epsilon for sum_square

2020-02-05 Thread Martin Storsjö
--- tests/checkasm/sbrdsp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/checkasm/sbrdsp.c b/tests/checkasm/sbrdsp.c index 558f452c9b..516b9f0ec6 100644 --- a/tests/checkasm/sbrdsp.c +++ b/tests/checkasm/sbrdsp.c @@ -17,6 +17,7 @@ */ #include "libavcodec/sbrdsp

Re: [FFmpeg-devel] [PATCH 001/244] Add a new channel layout API

2020-02-05 Thread Marton Balint
On Tue, 7 Jan 2020, Anton Khirnov wrote: Quoting Nicolas George (2019-12-31 16:17:49) Anton Khirnov (12019-12-29): > I do not agree. Duplicated channels in a layout are expected to be a > fringe thing and how you handle them highly depends on the specific use > case. I expect a typical cal

[FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-05 Thread Mohammad Izadi
From: Mohammad Izadi Trying to read HDR10+ metadata from HEVC/SEI and pass it to packet side data in the follow-up CLs. --- libavutil/hdr_dynamic_metadata.c | 165 +++ libavutil/hdr_dynamic_metadata.h | 12 ++- libavutil/version.h | 2 +- 3 files chan

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-05 Thread Mohammad Izadi
Please check my responses inline: On Wed, Feb 5, 2020 at 5:48 AM Moritz Barsnick wrote: > Hi Mohammad, > > On Tue, Feb 04, 2020 at 18:44:00 -0800, Mohammad Izadi wrote: > > --- a/libavutil/hdr_dynamic_metadata.c > > +++ b/libavutil/hdr_dynamic_metadata.c > > @@ -1,4 +1,4 @@ > > -/** > > + /** >

Re: [FFmpeg-devel] [PATCH 06/20] avformat/matroskaenc: Check functions that can fail

2020-02-05 Thread Michael Niedermayer
On Wed, Jan 01, 2020 at 01:58:23AM +0100, Andreas Rheinhardt wrote: > Sometimes it has not been checked whether opening the dynamic buffer for > writing Tags fails; this might have led to segfaults. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/matroskaenc.c | 9 +++-- > 1 file c

Re: [FFmpeg-devel] [PATCH] vf_ssim: Fix loading doubles to float registers on i386

2020-02-05 Thread Martin Storsjö
On Wed, 5 Feb 2020, Paul B Mahol wrote: LGTM, will you push it or me? I pushed it now - thanks! // Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or e

Re: [FFmpeg-devel] [PATCH] vf_ssim: Fix loading doubles to float registers on i386

2020-02-05 Thread Paul B Mahol
LGTM, will you push it or me? On 2/5/20, Martin Storsjö wrote: > This fixes the tests filter-refcmp-ssim-yuv and filter-refcmp-ssim-rgb > on i386 after breaking in fcc0424c933742c8fc852371e985d16b6eb4bfe9. > --- > libavfilter/x86/vf_ssim.asm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-05 Thread Moritz Barsnick
Hi Mohammad, On Tue, Feb 04, 2020 at 18:44:00 -0800, Mohammad Izadi wrote: > --- a/libavutil/hdr_dynamic_metadata.c > +++ b/libavutil/hdr_dynamic_metadata.c > @@ -1,4 +1,4 @@ > -/** > + /** Please review your git diff and your submitted patches carefully. You need to avoid this accidental change.

Re: [FFmpeg-devel] [PATCH 3/3] libfdk-aacdec: Allow explicitly disabling the DRC reference level option

2020-02-05 Thread James Almer
On 2/5/2020 10:12 AM, Martin Storsjö wrote: > On Wed, 5 Feb 2020, James Almer wrote: > >> On 2/5/2020 8:07 AM, Martin Storsjö wrote: >>> Previously, it was always left in the automatic mode, if the option >>> was set to the only special (negative) value. Now there's two separate >>> special values

Re: [FFmpeg-devel] [PATCH 3/3] libfdk-aacdec: Allow explicitly disabling the DRC reference level option

2020-02-05 Thread Martin Storsjö
On Wed, 5 Feb 2020, James Almer wrote: On 2/5/2020 8:07 AM, Martin Storsjö wrote: Previously, it was always left in the automatic mode, if the option was set to the only special (negative) value. Now there's two separate special values for this option, -1 for automatic (metadata based) and -2 f

Re: [FFmpeg-devel] [PATCH 3/3] libfdk-aacdec: Allow explicitly disabling the DRC reference level option

2020-02-05 Thread James Almer
On 2/5/2020 8:07 AM, Martin Storsjö wrote: > Previously, it was always left in the automatic mode, if the option > was set to the only special (negative) value. Now there's two separate > special values for this option, -1 for automatic (metadata based) > and -2 for explicitly disabled. > --- > li

[FFmpeg-devel] [PATCHv2 2/3] libfdk-aacdec: Use the decoder's default level limiter settings

2020-02-05 Thread Martin Storsjö
It was disabled by default in 2dbd35b00c6433e587d5f44d5dbc8972ebbaa88e as it added delay, but now we compensate for the delay properly by offsetting timestamps. --- libavcodec/libfdk-aacdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/libfdk-aacdec.c b/libavco

Re: [FFmpeg-devel] [PATCH 06/20] avformat/matroskaenc: Check functions that can fail

2020-02-05 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Sometimes it has not been checked whether opening the dynamic buffer for > writing Tags fails; this might have led to segfaults. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/matroskaenc.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > dif

Re: [FFmpeg-devel] [PATCH 2/3] libfdk-aacdec: Use the decoder's default level limiter settings

2020-02-05 Thread James Almer
On 2/5/2020 8:07 AM, Martin Storsjö wrote: > It was disabled by default in 2dbd35b00c6433e587d5f44d5dbc8972ebbaa88e > as it added delay, but now we compensate for the delay properly > by offsetting timestamps. > --- > libavcodec/libfdk-aacdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

[FFmpeg-devel] [PATCH] vf_ssim: Fix loading doubles to float registers on i386

2020-02-05 Thread Martin Storsjö
This fixes the tests filter-refcmp-ssim-yuv and filter-refcmp-ssim-rgb on i386 after breaking in fcc0424c933742c8fc852371e985d16b6eb4bfe9. --- libavfilter/x86/vf_ssim.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/x86/vf_ssim.asm b/libavfilter/x86/vf_ssim.asm i

[FFmpeg-devel] [PATCH 2/3] libfdk-aacdec: Use the decoder's default level limiter settings

2020-02-05 Thread Martin Storsjö
It was disabled by default in 2dbd35b00c6433e587d5f44d5dbc8972ebbaa88e as it added delay, but now we compensate for the delay properly by offsetting timestamps. --- libavcodec/libfdk-aacdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libfdk-aacdec.c b/libavcode

[FFmpeg-devel] [PATCH 3/3] libfdk-aacdec: Allow explicitly disabling the DRC reference level option

2020-02-05 Thread Martin Storsjö
Previously, it was always left in the automatic mode, if the option was set to the only special (negative) value. Now there's two separate special values for this option, -1 for automatic (metadata based) and -2 for explicitly disabled. --- libavcodec/libfdk-aacdec.c | 10 -- 1 file change

[FFmpeg-devel] [PATCH 1/3] libfdk-aacdec: Apply the decoder's output delay on timestamps

2020-02-05 Thread Martin Storsjö
The delay is normally zero when the level limiter is disabled, but if enabled, there's a small delay. --- libavcodec/libfdk-aacdec.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/libfdk-aacdec.c b/libavcodec/libfdk-aacdec.c index 1abe1d8438..d9b080cf3e 100644 --- a/libavc

Re: [FFmpeg-devel] [EXTREMELY IMPORTANT] [PLEASE DO NOT IGNORE] [PATCH] avfilter/framesync: do not pick AV_TIME_BASE for time base when not needed.

2020-02-05 Thread Paul B Mahol
On 2/2/20, Paul B Mahol wrote: > On 2/2/20, Nicolas George wrote: >> Paul B Mahol (12020-02-02): >>> I will repeat my last question once again, is it ok for you to check >>> that >>> all >>> input time-bases are same and that not AV_TIME_BASE is used in such >>> case? >> >> Already told you: wast