Re: [FFmpeg-devel] [PATCH 1/4] avfilter/vf_aspect: Fix integer overflow in compute_dar()

2020-02-15 Thread Paul B Mahol
LGTM On 2/15/20, Michael Niedermayer wrote: > Fixes: signed integer overflow: 1562273630 * 17 cannot be represented in > type 'int' > Fixes: Ticket8323 > > Found-by: Suhwan > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_aspect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

[FFmpeg-devel] [PATCH 1/4] avfilter/vf_aspect: Fix integer overflow in compute_dar()

2020-02-15 Thread Michael Niedermayer
Fixes: signed integer overflow: 1562273630 * 17 cannot be represented in type 'int' Fixes: Ticket8323 Found-by: Suhwan Signed-off-by: Michael Niedermayer --- libavfilter/vf_aspect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_aspect.c b/libavfilter/vf_aspe

[FFmpeg-devel] [PATCH 2/4] fftools/ffmpeg: Fix integer overflow in duration computation in seek_to_start()

2020-02-15 Thread Michael Niedermayer
Fixes: signed integer overflow: -9223372036854775808 - 9223372036854775807 cannot be represented in type 'long' Fixes: Ticket8142 Found-by: Suhwan Signed-off-by: Michael Niedermayer --- fftools/ffmpeg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg.c b/fft

[FFmpeg-devel] [PATCH 3/4] avformat/avidec: Avoid integer overflow in NI switch check

2020-02-15 Thread Michael Niedermayer
Fixes: signed integer overflow: 0 - -9223372036854775808 cannot be represented in type 'long' Fixes: Ticket8149 Found-by: Suhwan Signed-off-by: Michael Niedermayer --- libavformat/avidec.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/avidec.c b/libavfor

[FFmpeg-devel] [PATCH 4/4] avformat/utils: Fix integer overflow with complex time bases in avformat_find_stream_info()

2020-02-15 Thread Michael Niedermayer
Fixes: signed integer overflow: 2045163756 * 2 cannot be represented in type 'int' Fixes: Ticket5132 Found-by: tsmith Signed-off-by: Michael Niedermayer --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 7f

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: avoid unsigned integer overflows

2020-02-15 Thread Andreas Rheinhardt
Paul B Mahol: > On 2/15/20, Andreas Rheinhardt wrote: >> Marton Balint: >>> >>> >>> On Sat, 15 Feb 2020, Nicolas George wrote: >>> Marton Balint (12020-02-15): >> +if (s->nb_streams) >> for (i = s->nb_streams - 1; i >= 0; i--) > Maybe rewrite the loop instead? >

Re: [FFmpeg-devel] [PATCH 4/7] avformat/segafilmenc: Remove AVClass

2020-02-15 Thread Michael Niedermayer
On Sat, Feb 15, 2020 at 01:30:33PM +0100, Paul B Mahol wrote: > LGTM will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have never wished to cater to the crowd; for what I know they do not approve, and what they approve I do not know. -- Epicurus sig

[FFmpeg-devel] [PATCH] OpenBSD suport

2020-02-15 Thread Brad Smith
- Garbage collect bitrig. Was a OpenBSD derivative that has been dead for quite awhile. - Enable section_data_rel_ro for ARM support. diff --git a/configure b/configure index ab761c7183..9221621bd1 100755 --- a/configure +++ b/configure @@ -5303,8 +5303,9 @@ case $target_os in oss_outde

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: avoid unsigned integer overflows

2020-02-15 Thread Paul B Mahol
On 2/15/20, Andreas Rheinhardt wrote: > Marton Balint: >> >> >> On Sat, 15 Feb 2020, Nicolas George wrote: >> >>> Marton Balint (12020-02-15): > +if (s->nb_streams) > for (i = s->nb_streams - 1; i >= 0; i--) Maybe rewrite the loop instead? for (i = s->nb_streams; i-

Re: [FFmpeg-devel] [PATCH]lsws/input: Do not change transparency range

2020-02-15 Thread Michael Niedermayer
On Sat, Feb 15, 2020 at 10:10:45AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Transparency levels are currently changed when reading bgra and > friends, this patch changes behaviour and fixes ticket #8509. > > Please comment, Carl Eugen > libswscale/input.c|6 > t

Re: [FFmpeg-devel] avfilter/vf_zscale: fix crash on unaligned input

2020-02-15 Thread Paul B Mahol
On 2/15/20, jjadfh5dfg wrote: > ‐‐‐ Original Message ‐‐‐ > On Saturday, February 15, 2020 7:08 AM, Paul B Mahol > wrote: > >> On 2/15/20, jjadfh5dfg jjadfh5...@protonmail.com wrote: >> >> > Sent with ProtonMail Secure Email. >> >> How to apply this? Author name is not valid. >> Please spe

Re: [FFmpeg-devel] avfilter/vf_zscale: fix crash on unaligned input

2020-02-15 Thread jjadfh5dfg
‐‐‐ Original Message ‐‐‐ On Saturday, February 15, 2020 7:08 AM, Paul B Mahol wrote: > On 2/15/20, jjadfh5dfg jjadfh5...@protonmail.com wrote: > > > Sent with ProtonMail Secure Email. > > How to apply this? Author name is not valid. > Please specify meaningful name, like: Donnie Darko Rab

Re: [FFmpeg-devel] [PATCH] libavformat/utils.c: Fixed URL parsing

2020-02-15 Thread Marton Balint
On Thu, 13 Feb 2020, Gautam Ramakrishnan wrote: On Thu, Feb 13, 2020 at 12:31 AM Marton Balint wrote: On Wed, 12 Feb 2020, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This commit fixes bug #8466 wherein URLs with query string > not preceeded by the '/' symbol in a URL wa

Re: [FFmpeg-devel] [PATCH 01/12] avformat/tests/url: make format more readable

2020-02-15 Thread Marton Balint
On Sat, 15 Feb 2020, Marton Balint wrote: On Sat, 8 Feb 2020, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/tests/url.c | 3 ++- tests/ref/fate/url | 27 ++- 2 files changed, 16 insertions(+), 14 deletions(-) Ping for the series, will appl

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: avoid unsigned integer overflows

2020-02-15 Thread Andreas Rheinhardt
Marton Balint: > > > On Sat, 15 Feb 2020, Nicolas George wrote: > >> Marton Balint (12020-02-15): +    if (s->nb_streams)     for (i = s->nb_streams - 1; i >= 0; i--) >>> Maybe rewrite the loop instead? >>>   for (i = s->nb_streams; i-- > 0;) >> >> Or >> >>    for (i = s->nb_stream

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add myself as libzmq maintainer

2020-02-15 Thread Marton Balint
On Wed, 12 Feb 2020, Andriy Gelman wrote: From: Andriy Gelman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) Thanks, applied. Regards, Marton diff --git a/MAINTAINERS b/MAINTAINERS index 5244d9237a9..55e2b385b5a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -507,6 +507,7 @@ Proto

Re: [FFmpeg-devel] [PATCH] compat/os2threads:define INCL_DOSERRORS

2020-02-15 Thread Marton Balint
On Wed, 12 Feb 2020, Dave Yeo wrote: Thanks, applied. Regards, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.

Re: [FFmpeg-devel] [PATCH 09/11] avformat/utils: Fix memleaks in avformat_open_input()

2020-02-15 Thread Marton Balint
On Tue, 7 Jan 2020, Andreas Rheinhardt wrote: A demuxer might have allocated memory while reading the header. If reading the header was successfull and an error happens before returning (e.g. when queueing the attached pictures), the read_close function would have never been called, so that al

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: avoid unsigned integer overflows

2020-02-15 Thread Marton Balint
On Sat, 15 Feb 2020, Nicolas George wrote: Marton Balint (12020-02-15): +if (s->nb_streams) for (i = s->nb_streams - 1; i >= 0; i--) Maybe rewrite the loop instead? for (i = s->nb_streams; i-- > 0;) Or for (i = s->nb_streams - 1; i < s->nb_streams; i--) Or simply change

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: avoid unsigned integer overflows

2020-02-15 Thread Nicolas George
Marton Balint (12020-02-15): > > +if (s->nb_streams) > > for (i = s->nb_streams - 1; i >= 0; i--) > Maybe rewrite the loop instead? > for (i = s->nb_streams; i-- > 0;) Or for (i = s->nb_streams - 1; i < s->nb_streams; i--) Regards, -- Nicolas George signature.asc Descript

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: avoid unsigned integer overflows

2020-02-15 Thread Marton Balint
On Sat, 15 Feb 2020, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- libavformat/utils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index 81ea239a66..ba2621aa28 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -4450,10 +4450

[FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-15 Thread Linjie Fu
Currently, ffmpeg inserts scale filter by default in the filter graph to force the whole decoded stream to scale into the same size with the first frame. It's not quite make sense in resolution changing cases if user wants the rawvideo without any scale. Using autoscale/noautoscale as an output op

Re: [FFmpeg-devel] avfilter/vf_zscale: fix crash on unaligned input

2020-02-15 Thread Paul B Mahol
On 2/15/20, jjadfh5dfg wrote: > Sent with [ProtonMail](https://protonmail.com) Secure Email. How to apply this? Author name is not valid. Please specify meaningful name, like: Donnie Darko Rabbit ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org htt

Re: [FFmpeg-devel] [PATCH 1/6] avformat/format: add av_demuxer_find_by_ext

2020-02-15 Thread Gyan Doshi
On 12-02-2020 11:12 pm, Gyan Doshi wrote: On 01-02-2020 10:45 am, Gyan Doshi wrote: On 31-01-2020 10:41 pm, Andreas Rheinhardt wrote: Gyan Doshi: Allows selecting demuxer by extension which are more widely recognized by users. Conditional cast added since this function will usually be c

[FFmpeg-devel] [PATCH 2/2] avformat/utils: reindent

2020-02-15 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/utils.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index ba2621aa28..eeb3055f77 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -4450,16 +4450,17 @@ vo

[FFmpeg-devel] [PATCH 1/2] avformat/utils: avoid unsigned integer overflows

2020-02-15 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/utils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index 81ea239a66..ba2621aa28 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -4450,10 +4450,12 @@ void avformat_free_context(AVFormatCo

Re: [FFmpeg-devel] [PATCH] avcodec: fix pcm zork decoder

2020-02-15 Thread Paul B Mahol
On 2/15/20, Carl Eugen Hoyos wrote: > Am Sa., 15. Feb. 2020 um 09:45 Uhr schrieb Paul B Mahol : >> >> On 2/15/20, Carl Eugen Hoyos wrote: >> > Am Fr., 14. Feb. 2020 um 21:25 Uhr schrieb Paul B Mahol >> > : >> > >> >> diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c >> >> index 621a8

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-15 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Gyan Doshi > Sent: Saturday, February 15, 2020 20:37 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale > to disable/enable the default scale > > > > On 15-02-2020 05:44 pm, F

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-15 Thread Gyan Doshi
On 15-02-2020 06:06 pm, Gyan Doshi wrote: Also, based on a glance at the patch, this doesn't apply to output streams exiting a complex filtergraph, right? Make a note of that. Scratch that, it does. Gyan ___ ffmpeg-devel mailing list ffmpeg-deve

Re: [FFmpeg-devel] [PATCH 4/7] avformat/segafilmenc: Remove AVClass

2020-02-15 Thread Paul B Mahol
LGTM On 1/14/20, Andreas Rheinhardt wrote: > This muxer does not have any private options and so does not need a > private class. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/segafilmenc.c | 8 > 1 file changed, 8 deletions(-) > > diff --git a/libavformat/segafilmenc.c b/l

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-15 Thread Gyan Doshi
On 15-02-2020 05:44 pm, Fu, Linjie wrote: -Original Message- From: ffmpeg-devel On Behalf Of Nicolas George Sent: Saturday, February 15, 2020 19:52 To: FFmpeg development discussions and patches Cc: Eoff, Ullysses A Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -auto

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-15 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Saturday, February 15, 2020 19:52 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Eoff, Ullysses A > Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale > to dis

Re: [FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: fix the class_name in help for scale_qsv

2020-02-15 Thread Paul B Mahol
Who gonna apply this? On 2/15/20, Fu, Linjie wrote: >> -Original Message- >> From: myp...@gmail.com >> Sent: Tuesday, January 21, 2020 18:19 >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Cc: Fu, Linjie >> Subject: Re: [FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv:

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-15 Thread Nicolas George
Fu, Linjie (12020-02-15): > "automatically insert a scale filter at the end of the filter graph if a > resolution change is detected (enabled by default)." > in the help message and keep the current explanation unchanged in doc? It's still twice as long as most help text. Take example on the othe

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-15 Thread Paul B Mahol
On 2/15/20, Fu, Linjie wrote: >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Nicolas George >> Sent: Saturday, February 15, 2020 19:01 >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Cc: Fu, Linjie ; Eoff, Ullysses A >> >> Subject: Re: [FFmpeg-devel]

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-15 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Saturday, February 15, 2020 19:01 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie ; Eoff, Ullysses A > > Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -aut

Re: [FFmpeg-devel] [PATCH]lsws/input: Do not change transparency range

2020-02-15 Thread Paul B Mahol
LGTM, but maybe ask Michael for second opinion. On 2/15/20, Carl Eugen Hoyos wrote: > Hi! > > Transparency levels are currently changed when reading bgra and > friends, this patch changes behaviour and fixes ticket #8509. > > Please comment, Carl Eugen > __

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-15 Thread Nicolas George
Linjie Fu (12020-02-15): > Currently, ffmpeg inserts scale filter by default in the filter graph > to force the whole decoded stream to scale into the same size with the > first frame. It's not quite make sense in resolution changing cases if > user wants the rawvideo without any scale. > > Using

Re: [FFmpeg-devel] [PATCH] avcodec: add cdtoons decoder

2020-02-15 Thread Paul B Mahol
Will apply with minor nits fixed. On 2/12/20, Paul B Mahol wrote: > From: Alyssa Milburn > > This adds a decoder for Broderbund's sprite-based QuickTime CDToons > codec, based on the decoder I wrote for ScummVM. > > Signed-off-by: Alyssa Milburn > Signed-off-by: Paul B Mahol > --- > doc/gener

[FFmpeg-devel] [PATCH]lsws/input: Do not change transparency range

2020-02-15 Thread Carl Eugen Hoyos
Hi! Transparency levels are currently changed when reading bgra and friends, this patch changes behaviour and fixes ticket #8509. Please comment, Carl Eugen From a71053df9131be803d9a359a7232e5193747f351 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 15 Feb 2020 10:07:51 +0100 Subject

Re: [FFmpeg-devel] [PATCH] avcodec: fix pcm zork decoder

2020-02-15 Thread Carl Eugen Hoyos
Am Sa., 15. Feb. 2020 um 09:45 Uhr schrieb Paul B Mahol : > > On 2/15/20, Carl Eugen Hoyos wrote: > > Am Fr., 14. Feb. 2020 um 21:25 Uhr schrieb Paul B Mahol : > > > >> diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c > >> index 621a87cf34..48d0e91370 100644 > >> --- a/libavcodec/cod

Re: [FFmpeg-devel] [PATCH] avcodec: fix pcm zork decoder

2020-02-15 Thread Paul B Mahol
On 2/15/20, Carl Eugen Hoyos wrote: > Am Fr., 14. Feb. 2020 um 21:25 Uhr schrieb Paul B Mahol : > >> diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c >> index 621a87cf34..48d0e91370 100644 >> --- a/libavcodec/codec_desc.c >> +++ b/libavcodec/codec_desc.c >> @@ -1871,8 +1871,8 @@ stat

Re: [FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: fix the class_name in help for scale_qsv

2020-02-15 Thread Fu, Linjie
> -Original Message- > From: myp...@gmail.com > Sent: Tuesday, January 21, 2020 18:19 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: Re: [FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: fix the class_name > in help for scale_qsv > > On Tue, Jan

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: add support for external bitrate control for HEVC

2020-02-15 Thread Fu, Linjie
> -Original Message- > From: Zhong Li > Sent: Saturday, February 15, 2020 14:08 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: add support for external > bitrate control for HEVC > > Linjie Fu 于2020

Re: [FFmpeg-devel] [PATCH] avcodec: fix pcm zork decoder

2020-02-15 Thread Carl Eugen Hoyos
Am Fr., 14. Feb. 2020 um 21:25 Uhr schrieb Paul B Mahol : > diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c > index 621a87cf34..48d0e91370 100644 > --- a/libavcodec/codec_desc.c > +++ b/libavcodec/codec_desc.c > @@ -1871,8 +1871,8 @@ static const AVCodecDescriptor codec_descriptors[