Re: [FFmpeg-devel] [PATCH] ffprobe: show stream id in packets and frames

2020-02-19 Thread Gyan Doshi
On 20-02-2020 04:52 am, Jan Ekström wrote: Hi, On Wed, Feb 19, 2020 at 8:31 AM Gyan Doshi wrote: Required for reliably identifying streams in MPEGTS-like live inputs. --- Can you please explain to me how would this be any different from adding `-show_programs -show_streams` and checking out

Re: [FFmpeg-devel] [PATCH 3/3] avformat/dashenc: always attempt to enable prft on ldash mode

2020-02-19 Thread James Almer
On 2/19/2020 11:24 PM, Jeyapal, Karthick wrote: > > On 2/20/20 7:19 AM, James Almer wrote: >> On 2/19/2020 9:33 PM, Jeyapal, Karthick wrote: >>> >>> On 2/19/20 7:05 PM, James Almer wrote: On 2/19/2020 8:50 AM, Jeyapal, Karthick wrote: > > On 2/19/20 4:21 PM, Thilo Borgmann wrote:

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-19 Thread Mohammad Izadi
On Wed, Feb 19, 2020 at 4:22 PM Mark Thompson wrote: > On 10/02/2020 19:38, Mohammad Izadi wrote: > > On Sun, Feb 9, 2020 at 8:31 AM Mark Thompson wrote: > > > >> On 07/02/2020 17:46, Mohammad Izadi wrote: > >>> From: Mohammad Izadi > >>> > >>> Trying to read HDR10+ metadata from HEVC/SEI and p

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add support for external bitrate control for HEVC

2020-02-19 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Mark Thompson > Sent: Thursday, February 20, 2020 07:00 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add support for > external bitrate control for HEVC > > On 18/02/2020 02:32, Linjie Fu

Re: [FFmpeg-devel] [PATCH 3/3] avformat/dashenc: always attempt to enable prft on ldash mode

2020-02-19 Thread Jeyapal, Karthick
On 2/20/20 7:19 AM, James Almer wrote: > On 2/19/2020 9:33 PM, Jeyapal, Karthick wrote: >> >> On 2/19/20 7:05 PM, James Almer wrote: >>> On 2/19/2020 8:50 AM, Jeyapal, Karthick wrote: On 2/19/20 4:21 PM, Thilo Borgmann wrote: > Am 19.02.20 um 06:18 schrieb Jeyapal, Karthick: >> >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/dashenc: always attempt to enable prft on ldash mode

2020-02-19 Thread James Almer
On 2/19/2020 9:33 PM, Jeyapal, Karthick wrote: > > On 2/19/20 7:05 PM, James Almer wrote: >> On 2/19/2020 8:50 AM, Jeyapal, Karthick wrote: >>> >>> On 2/19/20 4:21 PM, Thilo Borgmann wrote: Am 19.02.20 um 06:18 schrieb Jeyapal, Karthick: > > On 2/18/20 9:43 PM, James Almer wrote:

Re: [FFmpeg-devel] [PATCH 3/3] avformat/dashenc: always attempt to enable prft on ldash mode

2020-02-19 Thread Jeyapal, Karthick
On 2/19/20 7:05 PM, James Almer wrote: > On 2/19/2020 8:50 AM, Jeyapal, Karthick wrote: >> >> On 2/19/20 4:21 PM, Thilo Borgmann wrote: >>> Am 19.02.20 um 06:18 schrieb Jeyapal, Karthick: On 2/18/20 9:43 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavforma

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-19 Thread Mark Thompson
On 10/02/2020 19:38, Mohammad Izadi wrote: > On Sun, Feb 9, 2020 at 8:31 AM Mark Thompson wrote: > >> On 07/02/2020 17:46, Mohammad Izadi wrote: >>> From: Mohammad Izadi >>> >>> Trying to read HDR10+ metadata from HEVC/SEI and pass it to packet side >> data in the follow-up CLs. >>> --- >>> lib

Re: [FFmpeg-devel] [PATCH] ffprobe: show stream id in packets and frames

2020-02-19 Thread Jan Ekström
Hi, On Wed, Feb 19, 2020 at 8:31 AM Gyan Doshi wrote: > > Required for reliably identifying streams in MPEGTS-like live inputs. > --- Can you please explain to me how would this be any different from adding `-show_programs -show_streams` and checking out the listing of those first? Generally goi

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add support for external bitrate control for HEVC

2020-02-19 Thread Mark Thompson
On 18/02/2020 02:32, Linjie Fu wrote: > ffmpeg | branch: master | Linjie Fu | Thu Feb 13 > 20:47:24 2020 +0800| [ebee8085952de079946d903f0cc6e37aee3bc035] | committer: > Zhong Li > > lavc/qsvenc: add support for external bitrate control for HEVC > > Enables option for hevc_qsv encoder: > -

Re: [FFmpeg-devel] [PATCH 1/2] lavd/opengl_enc: use proper context for logging.

2020-02-19 Thread Mark Thompson
On 17/02/2020 12:49, Nicolas George wrote: > Log as [opengl @ 0xaddress] instead of [opengl outdev @ 0xaddress]. > > Signed-off-by: Nicolas George > --- > libavdevice/opengl_enc.c | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/libavdevice/opengl_en

Re: [FFmpeg-devel] [PATCH 2/2] lavd/opengl_enc: check strings before parsing them.

2020-02-19 Thread Mark Thompson
On 17/02/2020 12:50, Nicolas George wrote: > Fix a segfault if OpenGL was not initialized before calling > write_header(). > > Signed-off-by: Nicolas George > --- > libavdevice/opengl_enc.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavdevice/opengl_enc.c b/libavdevice/openg

Re: [FFmpeg-devel] [PATCH 4/4] libavcodec/svq: Remove ff_svq1_packet_checksum()

2020-02-19 Thread Michael Niedermayer
On Wed, Feb 19, 2020 at 02:11:27PM +0100, Paul B Mahol wrote: > ok if it works yes, it has been tested with one sample and also with a few values manually will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "I am not trying to be anyone's saviour, I'm tr

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/qdm2: Check fft_coefs_index

2020-02-19 Thread Michael Niedermayer
On Wed, Feb 19, 2020 at 09:35:21AM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The smallest minority on earth is the individual. Those who deny individual rights cannot claim to be defenders of minorities. -

Re: [FFmpeg-devel] [PATCH 1/2] avformat/wtvdec: Forward errors when reading packet

2020-02-19 Thread Michael Niedermayer
On Wed, Feb 19, 2020 at 08:16:03PM +1100, Peter Ross wrote: > On Tue, Feb 18, 2020 at 12:36:00PM +, Andreas Rheinhardt wrote: > > Andreas Rheinhardt: > > > wtvfile_read_packet did not abide by the requirements of an > > > AVIOContext's read_packet-function: If it did not read anything, > > > it

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-19 Thread Derek Buitenhuis
On 19/02/2020 18:25, Mohammad Izadi wrote: > The comment was wrong. Thanks for clarifying! - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: add siren audio decoder

2020-02-19 Thread Lynne
Feb 19, 2020, 17:58 by jamr...@gmail.com: +AVCodec ff_siren_decoder = { +.name = "siren", +.long_name = NULL_IF_CONFIG_SMALL("Siren"), +.priv_data_size = sizeof(SirenContext), +.type = AVMEDIA_TYPE_AUDIO, +.id =

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-19 Thread Mohammad Izadi
The comment was wrong. -- Best, Mohammad On Wed, Feb 19, 2020 at 7:22 AM Derek Buitenhuis wrote: > On 10/02/2020 19:44, Mohammad Izadi wrote: > > /** > > * The nominal maximum display luminance of the targeted system > display, > > - * in units of 0.0001 candelas per square metre

Re: [FFmpeg-devel] [PATCH, v2 2/4] avc/avcodec: add AV_CODEC_CAP_VARIABLE_DIMENSIONS flag

2020-02-19 Thread Michael Niedermayer
On Tue, Feb 18, 2020 at 05:42:19PM +0100, Anton Khirnov wrote: > Quoting Fu, Linjie (2020-02-18 16:06:10) > > > Is there even a sufficiently strong use case for this? Why not just > > > > Like transcoding reinit-large_420_8-to-small_420_8.h264 (from 352x288 to > > 240x196) > > and prefer to keep

Re: [FFmpeg-devel] [PATCH 2/3 v2] avcodec: add an AVCodecContext flag to export PRFT side data on demand

2020-02-19 Thread Andreas Rheinhardt
Derek Buitenhuis: > On 19/02/2020 16:42, James Almer wrote: >> This flag and the x264 addition are both about a month old, and not >> present in any release, so no. > > I see. > > Aside: Do we have an actual written policy on after what amount of time > we consider it an API/ABI break? I always t

Re: [FFmpeg-devel] [PATCH 2/3 v2] avcodec: add an AVCodecContext flag to export PRFT side data on demand

2020-02-19 Thread James Almer
On 2/19/2020 2:58 PM, Derek Buitenhuis wrote: > On 19/02/2020 16:42, James Almer wrote: >> This flag and the x264 addition are both about a month old, and not >> present in any release, so no. > > I see. > > Aside: Do we have an actual written policy on after what amount of time > we consider it

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: add siren audio decoder

2020-02-19 Thread James Almer
On 2/19/2020 1:50 PM, Paul B Mahol wrote: > On 2/19/20, James Almer wrote: >> On 2/19/2020 7:30 AM, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> +static int siren_decode(AVCodecContext *avctx, void *data, >>> +int *got_frame, AVPacket *avpkt) >>> +{ >>> +Sir

Re: [FFmpeg-devel] [PATCH 2/3 v2] avcodec: add an AVCodecContext flag to export PRFT side data on demand

2020-02-19 Thread Derek Buitenhuis
On 19/02/2020 16:42, James Almer wrote: > This flag and the x264 addition are both about a month old, and not > present in any release, so no. I see. Aside: Do we have an actual written policy on after what amount of time we consider it an API/ABI break? I always thought master was also supposed

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: add siren audio decoder

2020-02-19 Thread Paul B Mahol
On 2/19/20, James Almer wrote: > On 2/19/2020 7:30 AM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/Makefile | 1 + >> libavcodec/allcodecs.c | 1 + >> libavcodec/avcodec.h| 1 + >> libavcodec/codec_desc.c | 7 + >> libavcodec/siren.c | 776 ++

Re: [FFmpeg-devel] [PATCH 2/3 v2] avcodec: add an AVCodecContext flag to export PRFT side data on demand

2020-02-19 Thread James Almer
On 2/19/2020 12:21 PM, Derek Buitenhuis wrote: > On 10/02/2020 18:26, James Almer wrote: >> /** >> - * Producer Reference Time data corresponding to the >> AVProducerReferenceTime struct. >> + * Producer Reference Time data corresponding to the >> AVProducerReferenceTime struct >> +

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: add siren audio decoder

2020-02-19 Thread James Almer
On 2/19/2020 7:30 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7 + > libavcodec/siren.c | 776 > lib

Re: [FFmpeg-devel] [PATCH, v2 2/4] avc/avcodec: add AV_CODEC_CAP_VARIABLE_DIMENSIONS flag

2020-02-19 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Wednesday, February 19, 2020 00:42 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, v2 2/4] avc/avcodec: add > AV_CODEC_CAP_VARIABLE_DIMENSIONS flag > >

Re: [FFmpeg-devel] [PATCH 2/3 v2] avcodec: add an AVCodecContext flag to export PRFT side data on demand

2020-02-19 Thread Derek Buitenhuis
On 10/02/2020 18:26, James Almer wrote: > /** > - * Producer Reference Time data corresponding to the > AVProducerReferenceTime struct. > + * Producer Reference Time data corresponding to the > AVProducerReferenceTime struct > + * exported by some encoders (on demand through the

[FFmpeg-devel] [PATCH] avcodec/tiff: Check for Tiled and Stripped TIFFs

2020-02-19 Thread Michael Niedermayer
TIFF 6 spec: "Do not use both strip-oriented and tile-oriented fields in the same TIFF file." Fixes: null pointer use, crash Fixes: crash-762680f9d1b27f9b9085e12887ad44893fb2b020 Found-by: Shiziru Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 6 ++ 1 file changed, 6 insertion

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-19 Thread Derek Buitenhuis
On 10/02/2020 19:44, Mohammad Izadi wrote: > /** > * The nominal maximum display luminance of the targeted system display, > - * in units of 0.0001 candelas per square metre. The value shall be in > + * in units of 1 candelas per square metre. The value shall be in > * the

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: add siren audio decoder

2020-02-19 Thread Lynne
Feb 19, 2020, 10:30 by one...@gmail.com: > Signed-off-by: Paul B Mahol <> one...@gmail.com> > > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7 + > libavcodec/siren.c | 776 ++

Re: [FFmpeg-devel] [PATCH] crash fixed: live stream.

2020-02-19 Thread Andriy Gelman
On Wed, 19. Feb 04:30, mostafa namazi wrote: > Hello Andriyyou can see my patch in below link. please review that. thanks. > [FFmpeg-devel] new patch - Patchwork > If you had a crash, you should probably open a ticket on https://trac.ffmpeg.org/ Thanks, -- Andriy _

Re: [FFmpeg-devel] [PATCH 3/3] avformat/dashenc: always attempt to enable prft on ldash mode

2020-02-19 Thread Thilo Borgmann
Am 19.02.20 um 14:35 schrieb James Almer: > On 2/19/2020 8:50 AM, Jeyapal, Karthick wrote: >> >> On 2/19/20 4:21 PM, Thilo Borgmann wrote: >>> Am 19.02.20 um 06:18 schrieb Jeyapal, Karthick: On 2/18/20 9:43 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavfor

Re: [FFmpeg-devel] [PATCH 1/3 v2] avcodec: add an AVCodecContext field to signal types of packet, frame, and coded stream side data to export

2020-02-19 Thread Anton Khirnov
Quoting James Almer (2020-02-13 20:42:48) > On 2/10/2020 3:26 PM, James Almer wrote: > > Add an initial mvs flag to is, analog to the export_mvs flags2 one. > > > > Signed-off-by: James Almer > > --- > > libavcodec/avcodec.h | 18 ++ > > libavcodec/mpegpicture.c

Re: [FFmpeg-devel] [PATCH 3/3] avformat/dashenc: always attempt to enable prft on ldash mode

2020-02-19 Thread James Almer
On 2/19/2020 8:50 AM, Jeyapal, Karthick wrote: > > On 2/19/20 4:21 PM, Thilo Borgmann wrote: >> Am 19.02.20 um 06:18 schrieb Jeyapal, Karthick: >>> >>> On 2/18/20 9:43 PM, James Almer wrote: Signed-off-by: James Almer --- libavformat/dashenc.c | 5 + 1 file changed, 5 ins

Re: [FFmpeg-devel] [PATCH 2/3] avformat/dashenc: write a capture time Producer Reference Time element when none is provided by the encoder

2020-02-19 Thread James Almer
On 2/19/2020 10:20 AM, Anton Khirnov wrote: > Quoting James Almer (2020-02-18 17:13:35) >> +static int dash_parse_prft(DASHContext *c, AVPacket *pkt) >> +{ >> +OutputStream *os = &c->streams[pkt->stream_index]; >> +int side_data_size; >> +AVProducerReferenceTime *prft; >> + >> +if (

Re: [FFmpeg-devel] [PATCH 2/3] avformat/dashenc: write a capture time Producer Reference Time element when none is provided by the encoder

2020-02-19 Thread Anton Khirnov
Quoting James Almer (2020-02-18 17:13:35) > +static int dash_parse_prft(DASHContext *c, AVPacket *pkt) > +{ > +OutputStream *os = &c->streams[pkt->stream_index]; > +int side_data_size; > +AVProducerReferenceTime *prft; > + > +if (!c->write_prft) > +return 0; > + > +prft

Re: [FFmpeg-devel] [PATCH 7/30] avformat/matroskaenc: Avoid allocations for SeekHead

2020-02-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> Up until e7ddafd5, the Matroska muxer wrote two SeekHeads: One at the >> beginning referencing the main level 1 elements (i.e. not the Clusters) >> and one at the end, referencing the Clusters. This second SeekHead was >> useless and has therefore been r

Re: [FFmpeg-devel] [PATCH 4/4] libavcodec/svq: Remove ff_svq1_packet_checksum()

2020-02-19 Thread Paul B Mahol
ok if it works On 2/19/20, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/Makefile | 4 +-- > libavcodec/svq1.h| 3 -- > libavcodec/svq13.c | 69 > libavcodec/svq1dec.c | 6 ++-- > libavcodec/svq3.c|

Re: [FFmpeg-devel] [PATCH 001/244] Add a new channel layout API

2020-02-19 Thread Anton Khirnov
Quoting Marton Balint (2020-02-18 23:54:56) > > > On Tue, 18 Feb 2020, Anton Khirnov wrote: > > > Quoting Marton Balint (2020-02-05 19:55:24) > >> > >> > >> On Tue, 7 Jan 2020, Anton Khirnov wrote: > >> > >> > Quoting Nicolas George (2019-12-31 16:17:49) > >> >> Anton Khirnov (12019-12-29): >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/dashenc: always attempt to enable prft on ldash mode

2020-02-19 Thread Jeyapal, Karthick
On 2/19/20 4:21 PM, Thilo Borgmann wrote: > Am 19.02.20 um 06:18 schrieb Jeyapal, Karthick: >> >> On 2/18/20 9:43 PM, James Almer wrote: >>> Signed-off-by: James Almer >>> --- >>> libavformat/dashenc.c | 5 + >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/libavformat/dashenc.c b/li

Re: [FFmpeg-devel] [PATCH 3/3] avformat/dashenc: always attempt to enable prft on ldash mode

2020-02-19 Thread Thilo Borgmann
Am 19.02.20 um 06:18 schrieb Jeyapal, Karthick: > > On 2/18/20 9:43 PM, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavformat/dashenc.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c >> index b910cc22d0..045d2f4df6

[FFmpeg-devel] [PATCH 1/3] avcodec: add siren audio decoder

2020-02-19 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 + libavcodec/siren.c | 776 libavformat/vivo.c | 5 + 6 files changed, 791 inserti

[FFmpeg-devel] [PATCH 3/3] avformat/vivo: set packet duration

2020-02-19 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/vivo.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/vivo.c b/libavformat/vivo.c index 2defda992b..fb58aa6178 100644 --- a/libavformat/vivo.c +++ b/libavformat/vivo.c @@ -36,6 +36,7 @@ typedef struct VivoContext {

[FFmpeg-devel] [PATCH 2/3] avformat/vivo: improve probing of some files

2020-02-19 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/vivo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/vivo.c b/libavformat/vivo.c index 7f30a3f031..2defda992b 100644 --- a/libavformat/vivo.c +++ b/libavformat/vivo.c @@ -59,9 +59,10 @@ static int vivo_probe(const

Re: [FFmpeg-devel] [PATCH 1/2] avformat/wtvdec: Forward errors when reading packet

2020-02-19 Thread Peter Ross
On Tue, Feb 18, 2020 at 12:36:00PM +, Andreas Rheinhardt wrote: > Andreas Rheinhardt: > > wtvfile_read_packet did not abide by the requirements of an > > AVIOContext's read_packet-function: If it did not read anything, > > it returned zero, which currently leads to a warning in read_packet_wrap

Re: [FFmpeg-devel] [PATCH v2] HEVC: Export motion vectors to frame side data.

2020-02-19 Thread Asaf Kave
On Thu, Feb 13, 2020 at 3:54 PM Paul B Mahol wrote: > On 2/13/20, Asaf Kave wrote: > > On Wed, Feb 12, 2020 at 4:02 PM Paul B Mahol wrote: > > > >> On 2/12/20, Asaf Kave wrote: > >> > On Wed, Feb 12, 2020 at 11:35 AM Paul B Mahol > wrote: > >> > > >> >> On 2/12/20, Asaf Kave wrote: > >> >> >

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/qdm2: Check fft_coefs_index

2020-02-19 Thread Paul B Mahol
lgtm On 2/19/20, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 20660/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QDM2_fuzzer-5658290216501248 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Micha