Re: [FFmpeg-devel] [PATCH] lavfi/vf_vpp_qsv: fix the infinite loop while framerate lower than input

2020-02-28 Thread Zhong Li
Linjie Fu 于2020年2月28日周五 下午11:34写道: > > There are frame droppings in frc while converting into a lower framerate, > and MSDK returns ERROR_MORE_DATA which should be ignored. Should be fixed in MSDK instead of working around in FFmpeg? ___ ffmpeg-devel ma

[FFmpeg-devel] GSoC: Regarding Parsing and FLIF16 Frame Encoding

2020-02-28 Thread Anamitra Ghorui
Hello, I have been reading through the parsing API and other things and here's what I've managed to gather (I will be ignoring overruns in these functions for now). Please tell me if I am right or wrong: 1. As long as the parse function determines next == END_NOT_FOUND, ff_combine_frame will

Re: [FFmpeg-devel] [PATCH 2/3] libavcodec/libx264.c: refine code to extract function x264_encode_set_roi

2020-02-28 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: Wednesday, February 19, 2020 12:24 PM > To: ffmpeg-devel@ffmpeg.org > Subject: RE: [PATCH 2/3] libavcodec/libx264.c: refine code to extract function > x264_encode_set_roi > > > > > -Original Message- > > From: Guo, Yejun > > Sent:

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/vf_sr.c: refine code to use AVPixFmtDescriptor.log2_chroma_h/w

2020-02-28 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: Tuesday, February 25, 2020 2:07 PM > To: Pedro Arthur ; FFmpeg development discussions > and patches > Subject: RE: [FFmpeg-devel] [PATCH 1/4] avfilter/vf_sr.c: refine code to use > AVPixFmtDescriptor.log2_chroma_h/w > > > > > -Origi

[FFmpeg-devel] [PATCH] [PATCH] avcodec: Fix h264_videotoolbox writing b-frames (fix ticket #8353)

2020-02-28 Thread Nomis101
From: Damiano Galassi Signed-off-by: Nomis101 --- libavcodec/videotoolboxenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index cc08cf6a50..32d893e485 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videotoolboxenc.

Re: [FFmpeg-devel] [PATCH] [PATCH] avcodec: Fix h264_videotoolbox writing b-frames (fix ticket #8353)

2020-02-28 Thread Carl Eugen Hoyos
Am Sa., 29. Feb. 2020 um 00:47 Uhr schrieb Nomis101 : > >> The fix is adopted from HandBrake's FFmpeg patch set: > >> https://github.com/HandBrake/HandBrake/blob/master/contrib/ffmpeg/A04-videotoolbox.patch > > > > Then please fix the attribution. > > OK, will do. But, where in send-email can I ch

Re: [FFmpeg-devel] [PATCH] [PATCH] avcodec: Fix h264_videotoolbox writing b-frames (fix ticket #8353)

2020-02-28 Thread Nomis101
Am 28.02.20 um 19:19 schrieb Carl Eugen Hoyos: > Am Fr., 28. Feb. 2020 um 19:08 Uhr schrieb Nomis101 : >> >> Am 27.02.20 um 19:13 schrieb Nomis101: >>> Signed-off-by: Nomis101 >>> --- >>> libavcodec/videotoolboxenc.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/libavcodec/videot

[FFmpeg-devel] [PATCH] avfilter/f_sendcmd: implement expr flag

2020-02-28 Thread Paul B Mahol
Make possible to parse expressions and store results as arguments for target filters. Signed-off-by: Paul B Mahol --- doc/filters.texi| 19 libavfilter/f_sendcmd.c | 48 ++--- 2 files changed, 64 insertions(+), 3 deletions(-) diff --g

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_cas: Remove superfluous ;

2020-02-28 Thread Paul B Mahol
lgtm On 2/28/20, Andreas Rheinhardt wrote: > The second ; in a double ;; is actually a null statement. It triggers > the typical declaration-after-statement compiler-warnings if it occurs > in the middle of several declarations (like here). > > Signed-off-by: Andreas Rheinhardt > --- > libavfil

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_opt: Fix leak of options when parsing options fails

2020-02-28 Thread Paul B Mahol
lgtm On 2/28/20, Andreas Rheinhardt wrote: > Fixes #8094. > > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffmpeg_opt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c > index 12d44886ee..3bf90bd20c 100644 > --- a/fftools/ffmpeg_opt.c >

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_cas: Remove superfluous ;

2020-02-28 Thread Andreas Rheinhardt
The second ; in a double ;; is actually a null statement. It triggers the typical declaration-after-statement compiler-warnings if it occurs in the middle of several declarations (like here). Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_cas.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_opt: Fix leak of options when parsing options fails

2020-02-28 Thread Andreas Rheinhardt
Fixes #8094. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg_opt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 12d44886ee..3bf90bd20c 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -3278,6 +3278,7 @@ static int open_

[FFmpeg-devel] [PATCH v2 2/2] avformat/libzmq: Make default pkt_size value consistent with amqp

2020-02-28 Thread Andriy Gelman
From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavformat/libzmq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/libzmq.c b/libavformat/libzmq.c index 8c8b294c921..1b0d8638dbf 100644 --- a/libavformat/libzmq.c +++ b/libavformat/libzmq.c @@ -40,7 +40,7 @@

[FFmpeg-devel] [PATCH v2 1/2] avformat: Add AMQP version 0-9-1 protocol support

2020-02-28 Thread Andriy Gelman
From: Andriy Gelman Supports connecting to a RabbitMQ broker via AMQP version 0-9-1. Signed-off-by: Andriy Gelman --- Changes in v2: - Addressed comments from Marton - Updated documentation Compilation notes: - Requires librabbitmq-dev package (on ubuntu). - The pkg-config li

Re: [FFmpeg-devel] Status and Plans for Subtitle Filters

2020-02-28 Thread Vittorio Giovara
On Fri, Feb 28, 2020 at 6:58 AM Nicolas George wrote: > Anton Khirnov (12020-02-28): > > avpriv is not a necessary result of having multiple libraries. It is a > > bug caused by bad API design. There is no fundamental reason for having > > private interfaces. > > > > In my view, no new private in

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cdtoons: Remove superfluous ;

2020-02-28 Thread Michael Niedermayer
On Thu, Feb 27, 2020 at 06:15:26AM +, Fu, Linjie wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Andreas Rheinhardt > > Sent: Thursday, February 27, 2020 13:34 > > To: ffmpeg-devel@ffmpeg.org > > Cc: Andreas Rheinhardt > > Subject: [FFmpeg-devel] [PATCH 2/2] avco

Re: [FFmpeg-devel] [PATCH] lavc/v4l2_context: fix compile warning for incompatible pointer type

2020-02-28 Thread Michael Niedermayer
On Fri, Feb 28, 2020 at 12:24:27AM -0500, Andriy Gelman wrote: > On Fri, 28. Feb 00:14, Linjie Fu wrote: > > Signed-off-by: Linjie Fu > > --- > > libavcodec/v4l2_context.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_c

Re: [FFmpeg-devel] [PATCH 1/2] avformat/ivfenc: Don't use size_t for size of file

2020-02-28 Thread Michael Niedermayer
On Thu, Feb 27, 2020 at 09:44:05AM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Opposition brings concord. Out of discord comes the fairest harmony. -- Heraclitus signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH 1/3] lavc/avcodec.h: fix missing line breaks in API documentation

2020-02-28 Thread Michael Niedermayer
On Fri, Feb 28, 2020 at 12:13:28AM +0800, Linjie Fu wrote: > "In both cases.." and "Repeat this call until.." would be better to > be in a separate line. > > http://ffmpeg.org/doxygen/trunk/group__lavc__encdec.html > > Signed-off-by: Linjie Fu > --- > libavcodec/avcodec.h | 2 ++ > 1 file chang

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Count last partial frame in probe.

2020-02-28 Thread Michael Niedermayer
On Thu, Feb 27, 2020 at 01:03:26PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-02-26 19:15:03) > > Fixes: regression > > Fixes: Ticket8511 > > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/mp3dec.c | 12 +--- > > 1 file changed, 9 insertions(+), 3 del

Re: [FFmpeg-devel] [PATCH] [PATCH] avcodec: Fix h264_videotoolbox writing b-frames (fix ticket #8353)

2020-02-28 Thread Carl Eugen Hoyos
Am Fr., 28. Feb. 2020 um 19:08 Uhr schrieb Nomis101 : > > Am 27.02.20 um 19:13 schrieb Nomis101: > > Signed-off-by: Nomis101 > > --- > > libavcodec/videotoolboxenc.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c > > inde

Re: [FFmpeg-devel] [PATCH] [PATCH] avcodec: Fix h264_videotoolbox writing b-frames (fix ticket #8353)

2020-02-28 Thread Nomis101
Am 27.02.20 um 19:13 schrieb Nomis101: > Signed-off-by: Nomis101 > --- > libavcodec/videotoolboxenc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c > index cc08cf6a50..32d893e485 100644 > --- a/libavcodec/videotoolboxenc.c > +

Re: [FFmpeg-devel] [PATCH 1/4] tests/checkasm: add overflow test for hevc_add_res

2020-02-28 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of Fu, > Linjie > Sent: Wednesday, December 18, 2019 09:55 > To: FFmpeg development discussions and patches de...@ffmpeg.org>; alexan...@khirnov.net; c...@passwd.hu; Paul B Mahol > ; jamr...@gmail.com; u...@pkh.me > Subject: Re: [FFmpeg-

[FFmpeg-devel] [PATCH] lavfi/vf_vpp_qsv: fix the infinite loop while framerate lower than input

2020-02-28 Thread Linjie Fu
There are frame droppings in frc while converting into a lower framerate, and MSDK returns ERROR_MORE_DATA which should be ignored. Reported-by: Gupta, Pallavi Signed-off-by: Linjie Fu --- Could be reproduced by: ffmpeg -hwaccel qsv -c:v hevc_qsv -i input_25fps.h265 -vf vpp_qsv=framerate

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/encode: restructure the core encoding code

2020-02-28 Thread James Almer
On 2/28/2020 8:52 AM, Michael Niedermayer wrote: > On Thu, Feb 27, 2020 at 03:02:00PM -0300, James Almer wrote: >> This commit follows the same logic as 061a0c14bb, but for the encode API: The >> new public encoding API will no longer be a wrapper around the old deprecated >> one, and the internal

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/encode: restructure the core encoding code

2020-02-28 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Friday, February 28, 2020 19:53 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/4] avcodec/encode: restructure the > core encoding code > > On Th

Re: [FFmpeg-devel] Status and Plans for Subtitle Filters

2020-02-28 Thread Nicolas George
Anton Khirnov (12020-02-28): > avpriv is not a necessary result of having multiple libraries. It is a > bug caused by bad API design. There is no fundamental reason for having > private interfaces. > > In my view, no new private interfaces should be accepted and all of the > existing ones should b

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/encode: restructure the core encoding code

2020-02-28 Thread Michael Niedermayer
On Thu, Feb 27, 2020 at 03:02:00PM -0300, James Almer wrote: > This commit follows the same logic as 061a0c14bb, but for the encode API: The > new public encoding API will no longer be a wrapper around the old deprecated > one, and the internal API used by the encoders now consists of a single > re

Re: [FFmpeg-devel] Status and Plans for Subtitle Filters

2020-02-28 Thread Nicolas George
Jean-Baptiste Kempf (12020-02-27): > Separating I/O from demuxers would bring a lot of interesting things > for security and for custom protocols. At the API level, yes, indeed. I personally would like demuxers to use the same push/pull API the decoders have been made to use. But that does not mea

[FFmpeg-devel] [PATCH v2 6/7] avformat/hlsenc: Factor check out of loop

2020-02-28 Thread Andreas Rheinhardt
The check will be true at most once anyway. Signed-off-by: Andreas Rheinhardt --- libavformat/hlsenc.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index e3a310dbc1..317b1a6f5e 100644 --- a/libavformat/hlsenc.c

[FFmpeg-devel] [PATCH v2 5/7] avformat/hlsenc: Localize initialization of subtitle streams

2020-02-28 Thread Andreas Rheinhardt
Before this commit, the checks were unnecessarily scattered. Signed-off-by: Andreas Rheinhardt --- Now not moving variables into a smaller scope. libavformat/hlsenc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index

[FFmpeg-devel] [PATCH v2 7/7] avformat/hlsenc: Cosmetics

2020-02-28 Thread Andreas Rheinhardt
Mainly includes reindentation and returning directly (i.e. without a goto fail when possible). Signed-off-by: Andreas Rheinhardt --- Now keeping the scope of variables alone. libavformat/hlsenc.c | 129 +-- 1 file changed, 52 insertions(+), 77 deletions(-

[FFmpeg-devel] [PATCH v2 4/7] avformat/hlsenc: Unconditionally free some strings

2020-02-28 Thread Andreas Rheinhardt
hls_init() would at first allocate the vtt_basename string, then allocate the vtt_m3u8_name string followed by several operations that may fail and then open the subtitles' output context. Yet upon freeing, these strings were only freed when the subtitles' output context existed, ensuring that they

[FFmpeg-devel] [PATCH v2 2/7] avformat/hlsenc: Add deinit function

2020-02-28 Thread Andreas Rheinhardt
This fixes memleaks in instances such as: a) When an allocation fails at one of the two places in hls_init() where the error is returned immediately without goto fail first. b) When an error happens when writing the header. c) When an allocation fails at one of the three places in hls_write_trailer

[FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-02-28 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/hlsenc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index a281c379f0..18f40ff3ed 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -1610,6 +1610,8 @@

[FFmpeg-devel] [PATCH v2 1/7] avformat/hlsenc: Avoid setting unused variables

2020-02-28 Thread Andreas Rheinhardt
Several variables which are only used when the HLS_SINGLE_FILE flag is unset have been set even when this flag is set. This has been changed. Signed-off-by: Andreas Rheinhardt --- Now not moving variables into a smaller scope. libavformat/hlsenc.c | 16 1 file changed, 8 insert

Re: [FFmpeg-devel] [PATCH 4/4] avformat/mxfenc: add some missing content package rates

2020-02-28 Thread Marton Balint
On Fri, 28 Feb 2020, Carl Eugen Hoyos wrote: Am Fr., 28. Feb. 2020 um 01:38 Uhr schrieb Marton Balint : Fixes ticket #8523. Signed-off-by: Marton Balint --- libavformat/mxf.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index 140

Re: [FFmpeg-devel] [PATCH]lavc: Use supported_samplerates for Dolby Digital encoders

2020-02-28 Thread Carl Eugen Hoyos
Am Di., 11. Feb. 2020 um 00:24 Uhr schrieb Carl Eugen Hoyos : > Attached patch probably fixes ticket #8518 and definitely simplifies > *ac3* encoding usage. Ping. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailm

Re: [FFmpeg-devel] Status and Plans for Subtitle Filters

2020-02-28 Thread Clément Bœsch
On Fri, Feb 28, 2020 at 05:55:19AM +0100, Anton Khirnov wrote: > Quoting Clément Bœsch (2020-02-27 19:36:24) > > On Thu, Feb 27, 2020 at 12:35:03PM +0100, Anton Khirnov wrote: > > [...] > > > AFAIU one of the still-open questions for the subtitle redesign is what > > > does it mean to decode or enc

Re: [FFmpeg-devel] [PATCH 4/4] avformat/mxfenc: add some missing content package rates

2020-02-28 Thread Carl Eugen Hoyos
Am Fr., 28. Feb. 2020 um 01:38 Uhr schrieb Marton Balint : > > Fixes ticket #8523. > > Signed-off-by: Marton Balint > --- > libavformat/mxf.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/libavformat/mxf.c b/libavformat/mxf.c > index 14056647c5..987410258a 100644 > --- a