Re: [FFmpeg-devel] [PATCH 4/4] avfilter/vf_derain.c: put all the calculation in model file.

> 2020年3月23日 下午12:08，Guo, Yejun 写道： > > currently, the model outputs the rain, and so need a subtraction > in filter c code to get the final derain result. > > I've sent a PR to update the model file and accepted, see at > https://github.com/XueweiMeng/derain_filter/pull/3 > > Signed-off-by:

[FFmpeg-devel] [PATCH 1/4] avfilter/vf_dnn_processing.c: fix typo for the linesize of dnn data

Signed-off-by: Guo, Yejun --- libavfilter/vf_dnn_processing.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_dnn_processing.c b/libavfilter/vf_dnn_processing.c index fabe4f1..cf589ac 100644 --- a/libavfilter/vf_dnn_processing.c +++ b/libavfilter/vf_dnn_proc

[FFmpeg-devel] [PATCH 4/4] avfilter/vf_derain.c: put all the calculation in model file.

currently, the model outputs the rain, and so need a subtraction in filter c code to get the final derain result. I've sent a PR to update the model file and accepted, see at https://github.com/XueweiMeng/derain_filter/pull/3 Signed-off-by: Guo, Yejun --- doc/filters.texi| 7 +-- li

[FFmpeg-devel] [PATCH 3/4] dnn-layer-mathbinary-test: add unit test for subtraction

Signed-off-by: Guo, Yejun --- tests/dnn/.gitignore | 1 + tests/dnn/Makefile| 1 + tests/dnn/dnn-layer-mathbinary-test.c | 173 ++ tests/fate/dnn.mak| 5 + 4 files changed, 180 insertions(+) create mod

[FFmpeg-devel] [PATCH 2/4] dnn_backend_native_layer_mathbinary: add sub support

more math binary operations will be added here Signed-off-by: Guo, Yejun --- libavfilter/dnn/Makefile | 1 + libavfilter/dnn/dnn_backend_native.h | 1 + .../dnn/dnn_backend_native_layer_mathbinary.c | 113 + .../dnn/dnn_backend

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h264_syntax_template: fix off by 1 error with slice_group_change_cycle

On 3/22/2020 8:00 PM, Michael Niedermayer wrote: > Fixes: assertion failure > Fixes: > 20390/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_REDUNDANT_PPS_fuzzer-5683400772157440 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off

[FFmpeg-devel] [PATCH] MAINTAINERS: add my gpg fingerprint

--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f9810d5594..9238a1a762 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -614,6 +614,7 @@ Nikolay Aleksandrov 8978 1D8C FB71 588E 4B27 EAA8 C4F0 B5FC E011 13B1 Panagiotis Issaris

Re: [FFmpeg-devel] [PATCH] configure: Do not abort when cross-compiling to the native CPU

On Mon, Mar 16, 2020 at 9:16 AM David Michael wrote: > On Sat, Mar 7, 2020 at 10:32 AM David Michael wrote: > > Using a compiler with a different host triplet is considered > > cross-compiling, even when it is for the same architecture as the > > build system. With such a cross-compiler, it is s

[FFmpeg-devel] [PATCH] doc/developer.texi: Add variadic macros to allowed C language features

They are used in several places like CBS. Signed-off-by: Andreas Rheinhardt --- doc/developer.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/developer.texi b/doc/developer.texi index 5c342c9106..51e7299b1d 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -131,6 +131,9

[FFmpeg-devel] [PATCH] avcodec/cbs: Avoid leaving the ... out in calls to variadic macros

According to C99, there has to be at least one argument for every ... in a variadic function-like macro. In practice most (all?) compilers also allow to leave it completely out, but it is nevertheless required: In a variadic macro "there shall be more arguments in the invocation than there are para

[FFmpeg-devel] [PATCH] avcodec/cbs_h264_syntax_template: fix off by 1 error with slice_group_change_cycle

Fixes: assertion failure Fixes: 20390/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_REDUNDANT_PPS_fuzzer-5683400772157440 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cbs_h264_syntax_templ

Re: [FFmpeg-devel] [PATCH] avformat: Add Dynacolor MVC Demuxer

Am So., 22. März 2020 um 18:29 Uhr schrieb Tom Needham <06needh...@gmail.com>: > > This demuxer adds support for demuxing files in the Dynacolor format > such as the sample located at: > > http://samples.ffmpeg.org/camera-dvr/dynacolor/dynacolor-camera-sample > > However, some decode errors are sho

Re: [FFmpeg-devel] JPEG2000 Decoder/Encoder Enhancements

Am So., 22. März 2020 um 18:27 Uhr schrieb Gautam Ramakrishnan : > I saw the list of unmentored projects for GSoC and enhancements to the > JPEG2000 decoder and encoder were there. I am finding it very > difficult to make a proposal as the specifications are not available > for free. However, I am

Re: [FFmpeg-devel] [PATCH] avformat: Add Dynacolor MVC Demuxer

On Sun, Mar 22, 2020, at 9:54 AM, Lou Logan wrote: > > Fails to apply. Forgot to mention it looks like your mail client broke/wrapped lines. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubs

Re: [FFmpeg-devel] [PATCH] avformat: Add Dynacolor MVC Demuxer

On Sun, Mar 22, 2020, at 9:28 AM, Tom Needham wrote: > This demuxer adds support for demuxing files in the Dynacolor format > such as the sample located at: > > http://samples.ffmpeg.org/camera-dvr/dynacolor/dynacolor-camera-sample > > However, some decode errors are showing on the resulting MPEG

Re: [FFmpeg-devel] [PATCH 07/14] avformat/matroskadec: fix the type of the TrackLanguage

Steve Lhomme: > From: Steve Lhomme > > It's an ASCII string, not a UTF-8 string. > --- > libavformat/matroskadec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index 4d7fdab99f..383869bced 100644 > --- a/libavfo

[FFmpeg-devel] [PATCH] avformat: Add Dynacolor MVC Demuxer

This demuxer adds support for demuxing files in the Dynacolor format such as the sample located at: http://samples.ffmpeg.org/camera-dvr/dynacolor/dynacolor-camera-sample However, some decode errors are showing on the resulting MPEG4 stream. I don't know whether this is a bug with the demuxer or

[FFmpeg-devel] JPEG2000 Decoder/Encoder Enhancements

Hi, I saw the list of unmentored projects for GSoC and enhancements to the JPEG2000 decoder and encoder were there. I am finding it very difficult to make a proposal as the specifications are not available for free. However, I am willing to work on improving the JPEG2000 features even if it is not

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/get_bits: cosmetics

Am So., 22. März 2020 um 15:54 Uhr schrieb Ramiro Polla : > > On Tue, Nov 5, 2019 at 2:35 PM Michael Niedermayer > wrote: > > On Tue, Nov 05, 2019 at 11:13:49AM +0100, Ramiro Polla wrote: > > > libavcodec/get_bits.h | 8 > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > LGTM

[FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo_enc: fix multi-threaded motion estimation rounding for mpeg4

ff_init_me() was being called after ff_update_duplicate_context(), which caused the propagation of the initialization to other thread contexts to be delayed by one frame. In the case of mpeg4 (or flipflop_rounding), this would make the hpel_put functions differ between the first thread (which woul

[FFmpeg-devel] [PATCH v1] avformat/mxfdec: use av_asprintf()

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mxfdec.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 9113e2a09c..3374f36a88 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -2017,7 +2017,7

[FFmpeg-devel] [PATCH 2/2] avcodec/motion_est: fix penalty_factor for b frames

In ff_estimate_b_frame_motion(), penalty_factor would be used before being initialized in estimate_motion_b(). Also, the initialization would happen more than once unnecessarily. --- libavcodec/motion_est.c | 15 --- tests/ref/vsynth/vsynth2-mpeg2-422 | 6 +++---

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/wmadec: cosmetics

On 3/22/2020 11:46 AM, Ramiro Polla wrote: > On Tue, Nov 5, 2019 at 2:35 PM Michael Niedermayer > wrote: >> On Tue, Nov 05, 2019 at 11:13:50AM +0100, Ramiro Polla wrote: >>> libavcodec/wmadec.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> LGTM > > ping Applied. __

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/get_bits: cosmetics

On 3/22/2020 11:45 AM, Ramiro Polla wrote: > On Tue, Nov 5, 2019 at 2:35 PM Michael Niedermayer > wrote: >> On Tue, Nov 05, 2019 at 11:13:49AM +0100, Ramiro Polla wrote: >>> libavcodec/get_bits.h | 8 >>> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> LGTM > > ping Applied.

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/get_bits: cosmetics

On Tue, Nov 5, 2019 at 2:35 PM Michael Niedermayer wrote: > On Tue, Nov 05, 2019 at 11:13:49AM +0100, Ramiro Polla wrote: > > libavcodec/get_bits.h | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > LGTM ping ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/wmadec: cosmetics

On Tue, Nov 5, 2019 at 2:35 PM Michael Niedermayer wrote: > On Tue, Nov 05, 2019 at 11:13:50AM +0100, Ramiro Polla wrote: > > libavcodec/wmadec.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > LGTM ping ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 04/21] avformat: Redo cleanup of demuxer upon read_header() failure

On Sun, Mar 22, 2020 at 04:47:39AM +0100, Andreas Rheinhardt wrote: > If reading the header fails, the demuxer's read_close() function (if > existing) is not called automatically; instead several demuxers call it > via "goto fail" in read_header(). > > This commit intends to change this by adding

Re: [FFmpeg-devel] [PATCH 13/14] tools: add XLSTs script to generate matroska semantic files

> On 22 Mar 2020, at 11:34, Carl Eugen Hoyos wrote: > > Am So., 22. März 2020 um 10:02 Uhr schrieb Steve Lhomme : >> >> From: Steve Lhomme >> >> Usage: >> xsltproc -o matroska_ids.h schema_2_lavf_h.xsl ebml_matroska.xml >> xsltproc -o matroskasem.c schema_2_lavf_sem_c.xsl ebml_matroska.xml

Re: [FFmpeg-devel] [PATCH v2] avformat/bethsoftvid: Avoid allocations and frees for palettes

On Sat, Mar 21, 2020 at 10:22:08AM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Modern terrorism, a quick summary: Need oil, start war with country that has oil, kill hundread thousand in war. Let country fall

Re: [FFmpeg-devel] [PATCH 2/2] avformat/bethsoftvid: Fix potential memleak upon reallocation failure

On Sat, Mar 21, 2020 at 10:29:26AM +0100, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What does censorship reveal? It reveals fear. -- Julian Assange signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hnm: Check for extradata allocation failure

On Sat, Mar 21, 2020 at 10:21:02AM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things microsoft did are stupid, but not doing something just because microsoft did it is even more stupid. If everything ms

Re: [FFmpeg-devel] [PATCH] avformat/subtitles: Don't increment packet counter prematurely

On Sat, Mar 21, 2020 at 04:50:20AM +0100, Andreas Rheinhardt wrote: > Do it only if the packet has been successfully allocated in > av_new_packet() -- otherwise on error a completely uninitialized packet > would be unreferenced later. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/sub

Re: [FFmpeg-devel] [PATCH v1] avcodec/decode: increase nb_bsfs after av_bsf_alloc in case alloc failed

On Tue, Dec 24, 2019 at 09:06:18AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/decode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF1336

Re: [FFmpeg-devel] [PATCH 13/14] tools: add XLSTs script to generate matroska semantic files

Am So., 22. März 2020 um 10:02 Uhr schrieb Steve Lhomme : > > From: Steve Lhomme > > Usage: > xsltproc -o matroska_ids.h schema_2_lavf_h.xsl ebml_matroska.xml > xsltproc -o matroskasem.c schema_2_lavf_sem_c.xsl ebml_matroska.xml > > The ebml_matroska.xml file comes from > https://github.com/cellar

[FFmpeg-devel] [PATCH 10/14] avformat/matroskadec: move the elements semantic in a separate file

From: Steve Lhomme So the file can be generated from the Matroska Schema. The EbmlSyntax structures are not shared between files. matroska_segments and matroska_cluster_enter also have their size predefined. No functional changes. --- libavformat/Makefile | 2 +- libavformat/matroskadec

[FFmpeg-devel] [PATCH 12/14] avformat/matroskasem: reorder some EbmlSyntax elements

From: Steve Lhomme So it's easier to match with the XSLT ordering which has limited possibilities (15 max criteria for all the syntax tables). No functional changes. --- libavformat/matroskasem.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/li

[FFmpeg-devel] [PATCH 14/14] avformat/matroska: use the generated semantic files

From: Steve Lhomme No functional value/added removed, only more regular spacing. --- libavformat/matroska_ids.h | 290 +++--- libavformat/matroskasem.c | 356 +++-- 2 files changed, 326 insertions(+), 320 deletions(-) diff --git a/libavfo

[FFmpeg-devel] [PATCH 11/14] avformat/matroskasem: reorder EbmlSyntax tables

From: Steve Lhomme So they are sorted by their EBML path, in reverse order so we don't extra declarations. No functional changes. --- libavformat/matroskasem.c | 256 +++--- 1 file changed, 128 insertions(+), 128 deletions(-) diff --git a/libavformat/matroskasem

[FFmpeg-devel] [PATCH 09/14] avformat/matroskadec: remove some implicit default value

From: Steve Lhomme All integers should be initialized to 0. Make the tables more consistent by only setting non zero values. --- libavformat/matroskadec.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroska

[FFmpeg-devel] [PATCH 05/14] avformat:matroska_ids: move some IDs in separate sections

From: Steve Lhomme According grouped with their parent's elements. No value added/removed. --- libavformat/matroska_ids.h | 78 ++ 1 file changed, 54 insertions(+), 24 deletions(-) diff --git a/libavformat/matroska_ids.h b/libavformat/matroska_ids.h index 06

[FFmpeg-devel] [PATCH 08/14] avformat/matroskadec: fix the default of the TagDefault element

From: Steve Lhomme By default a tag is the default one. --- libavformat/matroskadec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 383869bced..3640dd76d9 100644 --- a/libavformat/matroskadec.c +++ b/libavforma

[FFmpeg-devel] [PATCH 07/14] avformat/matroskadec: fix the type of the TrackLanguage

From: Steve Lhomme It's an ASCII string, not a UTF-8 string. --- libavformat/matroskadec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 4d7fdab99f..383869bced 100644 --- a/libavformat/matroskadec.c +++ b/libavform

[FFmpeg-devel] [PATCH 04/14] avformat/matroska: move Matroska IDs and enums in a separate header

From: Steve Lhomme So the file can be generated from the EBML Schema. No functional change. --- libavformat/matroska.h | 302 +- libavformat/matroska_ids.h | 327 + 2 files changed, 328 insertions(+), 301 deletions(-) crea

[FFmpeg-devel] [PATCH 06/14] avformat:matroska_ids: reorder some IDs to match the generated order

From: Steve Lhomme The XSLT scripts produces a similar file to this one, minus some spacing differences. No value added/removed. --- libavformat/matroska_ids.h | 70 +++--- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/libavformat/matroska_ids.h

[FFmpeg-devel] [PATCH 02/14] avformat/matroska: clean the structure formatting

From: Steve Lhomme Always use a comma at the end, order elements by value. --- libavformat/matroska.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/matroska.h b/libavformat/matroska.h index 9e33e51c94..e177cd027f 100644 --- a/libavformat/matroska.h +++ b/lib

[FFmpeg-devel] [PATCH 03/14] avformat/matroska: use more consistent spacing in enums

From: Steve Lhomme --- libavformat/matroska.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavformat/matroska.h b/libavformat/matroska.h index e177cd027f..5520e9ce8f 100644 --- a/libavformat/matroska.h +++ b/libavformat/matroska.h @@ -284,18 +284,18 @@

[FFmpeg-devel] [PATCH 01/14] avformat/matroska: add missing Buttons track type

From: Steve Lhomme --- libavformat/matroska.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/matroska.h b/libavformat/matroska.h index 86968a8de1..9e33e51c94 100644 --- a/libavformat/matroska.h +++ b/libavformat/matroska.h @@ -271,6 +271,7 @@ typedef enum { MATROSKA_TRACK_TYP