Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add matroska subtitle muxer (.mks)

2020-04-04 Thread Andreas Rheinhardt
Jan Chren (rindeal): > Signed-off-by: Jan Chren (rindeal) > --- > libavformat/matroskaenc.c | 28 > 1 file changed, 28 insertions(+) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index 5dae53026d8..62127fe97f0 100644 > --- a/libavformat/mat

[FFmpeg-devel] [PATCH v11 3/3] libavcodec/jpeg2000dec.c: Fix indentation

2020-04-04 Thread gautamramk
From: Gautam Ramakrishnan --- libavcodec/jpeg2000dec.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c index f2039fa8c1..7033417c65 100644 --- a/libavcodec/jpeg2000dec.c +++ b/libavcodec/jpeg2000dec.c @@ -13

[FFmpeg-devel] [PATCH v11 2/3] libavcodec/jpeg2000dec.c: Handle non EOC streams

2020-04-04 Thread gautamramk
From: Gautam Ramakrishnan This patch allows decoding of j2k streams which do not have an EOC marker. --- libavcodec/jpeg2000dec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c index 01509d62c1..f2039fa8c1 100644 --

[FFmpeg-devel] [PATCH v11 1/3] libavcodec/jpeg2000dec.c: Add support for PPT marker

2020-04-04 Thread gautamramk
From: Gautam Ramakrishnan This patch adds functional changes to support the PPT marker. --- libavcodec/jpeg2000dec.c | 88 +++- 1 file changed, 77 insertions(+), 11 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c index 7103cd6ceb

Re: [FFmpeg-devel] [PATCH 1/4] avformat/avidec: Don't reimplement ff_free_stream()

2020-04-04 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Using ff_free_stream() makes the code more readable, more future-proof > (the old code freed AVCodecContexts and AVCodecParameters and its > substructures manually, so that there is a chance that there would be a > memleak for some time if new substructures were added) and red

Re: [FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-04 Thread Andreas Rheinhardt
Limin Wang: > On Fri, Apr 03, 2020 at 11:23:59PM +0200, Michael Niedermayer wrote: >> On Fri, Apr 03, 2020 at 11:05:59PM +0800, lance.lmw...@gmail.com wrote: >>> From: Limin Wang >>> >>> Signed-off-by: Limin Wang >>> --- >>> libavformat/mux.c| 16 >>> tests/ref/fate/bins

Re: [FFmpeg-devel] [PATCH v2] ffplay: always show stats at all log levels if requested by user

2020-04-04 Thread Marton Balint
On Fri, 3 Apr 2020, Gyan Doshi wrote: Since 3b491c5a500, stats would be hidden if loglevel was lower than info, even if -stats was set. Fixes #6962 --- doc/ffplay.texi | 5 +++-- fftools/ffplay.c | 36 2 files changed, 27 insertions(+), 14 deletions(-) di

Re: [FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-04 Thread Nicolas George
Limin Wang (12020-04-04): > I think it's caused by the keyframe flags, so have no clue how to check > the beneficial for these fate testing. Take the actual files produced by the tests, possibly changing the output format from framecrc to an actual format, and compare carefully the version before

Re: [FFmpeg-devel] [PATCH v2] ffplay: always show stats at all log levels if requested by user

2020-04-04 Thread Gyan Doshi
On 04-04-2020 02:49 pm, Marton Balint wrote: On Fri, 3 Apr 2020, Gyan Doshi wrote: Since 3b491c5a500, stats would be hidden if loglevel was lower than info, even if -stats was set. Fixes #6962 --- doc/ffplay.texi  |  5 +++-- fftools/ffplay.c | 36 2 file

[FFmpeg-devel] [PATCH 1/2] libavcodec/libaomenc.c: Support gray input

2020-04-04 Thread Ryo Hirafuji
AV1 decoders, libaomdec and libdav1d, both support grayscale image. However, libaomenc does not support it yet. In this patch, I add a grayscale image support also to libaomenc. --- libavcodec/libaomenc.c | 48 -- 1 file changed, 42 insertions(+), 6 deletio

[FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-04 Thread Ryo Hirafuji
From: Ryo Hirafuji AV1 support lossless encoding. In this patch, I added a command line flag to enable it. --- libavcodec/libaomenc.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index fb61ce82e2..4a7f4b662a 100

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-04 Thread Carl Eugen Hoyos
Am Sa., 4. Apr. 2020 um 11:57 Uhr schrieb Ryo Hirafuji : > > From: Ryo Hirafuji > > AV1 support lossless encoding. > In this patch, I added a command line flag to enable it. > > --- > libavcodec/libaomenc.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/liba

[FFmpeg-devel] [PATCH 2/2] libavcodec/libaomenc.c: Support lossless encoding

2020-04-04 Thread Ryo Hirafuji
AV1 support lossless encoding. In this patch, I added a command line flag to enable it. --- libavcodec/libaomenc.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index fb61ce82e2..4a7f4b662a 100644 --- a/libavcodec/

Re: [FFmpeg-devel] [PATCH] ffplay: flush correct stream after stats update

2020-04-04 Thread Marton Balint
On Fri, 3 Apr 2020, Gyan Doshi wrote: Stats and logs are written to stderr, not stdout. --- fftools/ffplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 416ebbf7df..1beec54293 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c

[FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-04 Thread Ryo Hirafuji
From: Ryo Hirafuji AV1 support lossless encoding. In this patch, I added a command line flag to enable it. --- libavcodec/libaomenc.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index fb61ce82e2..4a7f4b662a 100

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-04 Thread Ryo Hirafuji
> Is it possible to use "cfr 0" instead? Unfortunately, crf=0 is not lossless. "lossless" flag uses "quantisation matrices", which is different from the default quantizer determined by "-crf", to achieve lossless encoding. 2020年4月4日(土) 18:59 Carl Eugen Hoyos : > Am Sa., 4. Apr. 2020 um 11:57 Uh

Re: [FFmpeg-devel] [inline assembly compliance] Issues and patches

2020-04-04 Thread FRÉDÉRIC RECOULES
Thank you for your answers. As you have pointed out, these patches are full of unrelated changes that are not important for safety. Most of them were never intended to be posted here, the diff we submitted was the one of an experimental branch and we apologize to have made such a mistake. We

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-04 Thread Carl Eugen Hoyos
Am Sa., 4. Apr. 2020 um 12:16 Uhr schrieb Ryo Hirafuji : > > > Is it possible to use "cfr 0" instead? > > Unfortunately, crf=0 is not lossless. > "lossless" flag uses "quantisation matrices", which is different from the > default quantizer determined by "-crf", to achieve lossless encoding. So "cr

[FFmpeg-devel] [PATCH 1/5] x86 inline assembly compliance

2020-04-04 Thread FRÉDÉRIC RECOULES
[inline assembly] prepares for contiguous assembly statements merging --- libavcodec/x86/inline_asm.h | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/libavcodec/x86/inline_asm.h b/libavcodec/x86/inline_asm.h index 0198746719..6ead73ac33 10064

Re: [FFmpeg-devel] [PATCH] ffplay: flush correct stream after stats update

2020-04-04 Thread Gyan Doshi
On 04-04-2020 03:30 pm, Marton Balint wrote: On Fri, 3 Apr 2020, Gyan Doshi wrote: Stats and logs are written to stderr, not stdout. --- fftools/ffplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 416ebbf7df..1beec54293 10064

[FFmpeg-devel] [PATCH 2/5] x86 inline assembly compliance

2020-04-04 Thread FRÉDÉRIC RECOULES
[inline assembly] merges contiguous assembly statements --- libavcodec/x86/hpeldsp_init.c | 8 libavcodec/x86/rnd_template.c | 14 +++--- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/libavcodec/x86/hpeldsp_init.c b/libavcodec/x86/hpeldsp_init.c index d89928c

[FFmpeg-devel] [PATCH 3/5] x86 inline assembly compliance

2020-04-04 Thread FRÉDÉRIC RECOULES
[inline assembly] prepares for mmx clobbers akin to xmm --- configure | 4 libavutil/x86/asm.h | 20 2 files changed, 24 insertions(+) diff --git a/configure b/configure index 5fe9950e20..4062ca095a 100755 --- a/configure +++ b/configure @@ -2275,6 +2275,7 @@ TOOL

[FFmpeg-devel] [PATCH 4/5] x86 inline assembly compliance

2020-04-04 Thread FRÉDÉRIC RECOULES
[inline assembly] add mmx clobbers in 3 statements - 1 in lossless_videoencdsp_init.c - 2 in rnd_template.c --- libavcodec/x86/lossless_videoencdsp_init.c | 4 +++- libavcodec/x86/rnd_template.c | 8 ++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/libavcodec/x86/lossle

[FFmpeg-devel] [PATCH 5/5] x86 inline assembly compliance

2020-04-04 Thread FRÉDÉRIC RECOULES
[inline assembly] add "memory" to sub_median_pred_mmxext --- libavcodec/x86/lossless_videoencdsp_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/x86/lossless_videoencdsp_init.c b/libavcodec/x86/lossless_videoencdsp_init.c index fb481e66f5..feb6874f94 1006

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-04 Thread Ryo Hirafuji
> So "crf 0" already has a meaning different from all other crf values? No. "crf 0" has the same meanings. It just makes the quality better than "crf 1". I read libaom again, and I apologize for my wrong explanation: I found that if certain conditions are met, "crf 0" also generates lossless vi

Re: [FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-04 Thread Limin Wang
On Sat, Apr 04, 2020 at 11:42:06AM +0200, Nicolas George wrote: > Limin Wang (12020-04-04): > > I think it's caused by the keyframe flags, so have no clue how to check > > the beneficial for these fate testing. > > Take the actual files produced by the tests, possibly changing the > output format

[FFmpeg-devel] [PATCH 0/2] lavd/avfoundation: Fix build on iOS and fix screen capture

2020-04-04 Thread Thilo Borgmann
Hi, fixing two bugs revealed after last patch to avfoundation. Will apply soon if there are no objections. -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above,

[FFmpeg-devel] [PATCH 2/2] lavd/avfoundation.m: Do not use transport controls for screen capture devices.

2020-04-04 Thread Thilo Borgmann
$Subject -Thilo From a754bd117b6eff1e7c9468a76e236d3f062eb580 Mon Sep 17 00:00:00 2001 From: Thilo Borgmann Date: Sat, 4 Apr 2020 13:51:17 +0200 Subject: [PATCH 2/2] lavd/avfoundation.m: Do not use transport controls for screen capture devices. --- libavdevice/avfoundation.m | 20 +++--

[FFmpeg-devel] [PATCH 1/2] lavd/avfoundation.m: Remove transport controls for iOS.

2020-04-04 Thread Thilo Borgmann
$Subject -Thilo From 20f16ed1ef9f99b847798a28fff46812246a8039 Mon Sep 17 00:00:00 2001 From: Thilo Borgmann Date: Sat, 4 Apr 2020 13:49:46 +0200 Subject: [PATCH 1/2] lavd/avfoundation.m: Remove transport controls for iOS. --- libavdevice/avfoundation.m | 12 ++-- 1 file changed, 10 inse

Re: [FFmpeg-devel] [PATCH 1/4] avformat/avidec: Don't reimplement ff_free_stream()

2020-04-04 Thread James Almer
On 3/27/2020 6:55 AM, Andreas Rheinhardt wrote: > Using ff_free_stream() makes the code more readable, more future-proof > (the old code freed AVCodecContexts and AVCodecParameters and its > substructures manually, so that there is a chance that there would be a > memleak for some time if new subst

Re: [FFmpeg-devel] [PATCH 1/4] avformat/avidec: Don't reimplement ff_free_stream()

2020-04-04 Thread Andreas Rheinhardt
James Almer: > On 3/27/2020 6:55 AM, Andreas Rheinhardt wrote: >> Using ff_free_stream() makes the code more readable, more future-proof >> (the old code freed AVCodecContexts and AVCodecParameters and its >> substructures manually, so that there is a chance that there would be a >> memleak for som

[FFmpeg-devel] [PATCH] avformat/mpegts: use buffer pools for allocating packets

2020-04-04 Thread Marton Balint
This brings a performance improvement when demuxing files, most of the improvement comes from buffer pooling unbound packets. time ffprobe -i samples/ffmpeg-bugs/trac/ticket6132/Samsung_HDR_-_Chasing_the_Light.ts -show_packets >/dev/null 2>&1 Before: real0m1.967s user0m1.471s

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: use buffer pools for allocating packets

2020-04-04 Thread James Almer
On 4/4/2020 11:47 AM, Marton Balint wrote: > This brings a performance improvement when demuxing files, most of the > improvement comes from buffer pooling unbound packets. Yes, as i mentioned in my last reply this was my experience as well. > > time ffprobe -i > samples/ffmpeg-bugs/trac/ticket

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: use buffer pools for allocating packets

2020-04-04 Thread Marton Balint
On Sat, 4 Apr 2020, James Almer wrote: On 4/4/2020 11:47 AM, Marton Balint wrote: This brings a performance improvement when demuxing files, most of the improvement comes from buffer pooling unbound packets. Yes, as i mentioned in my last reply this was my experience as well. time ffprob

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-04 Thread Carl Eugen Hoyos
Am Sa., 4. Apr. 2020 um 13:17 Uhr schrieb Ryo Hirafuji : > > > So "crf 0" already has a meaning different from all other crf values? > > No. "crf 0" has the same meanings. It just makes the quality better than > "crf 1". That was my question, sorry for being unclear. > I read libaom again, and I

[FFmpeg-devel] [PATCH] avformat/matroskaenc: remove MAX_TRACKS limit

2020-04-04 Thread Jan Chren (rindeal)
From 43e4b9695a4342112b1117db6526bafa1f9dab3e Mon Sep 17 00:00:00 2001 From: Jan Chren (rindeal) Date: Thu, 1 Apr 2020 00:00:00 + Subject: [PATCH] avformat/matroskaenc: remove MAX_TRACKS limit It was introduced in 7be0f48a32155ef9f471ffc5a1b41d662ea337f1 to set size of an array struct field,

[FFmpeg-devel] [PATCH] avformat/matroskaenc: add matroska subtitle muxer (.mks)

2020-04-04 Thread Jan Chren (rindeal)
From eaa9f2685436725e19eb94e7f2d0174ba56b7429 Mon Sep 17 00:00:00 2001 From: Jan Chren (rindeal) Date: Thu, 1 Apr 2020 00:00:00 + Subject: [PATCH] avformat/matroskaenc: add matroska subtitle muxer (.mks) Signed-off-by: Jan Chren (rindeal) --- libavformat/matroskaenc.c | 28

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add matroska subtitle muxer (.mks)

2020-04-04 Thread Paul B Mahol
On 4/4/20, Jan Chren (rindeal) wrote: > > Looks like you sent exactly same patch as before. This patch does unfortunately nothing as some changes from other files are missing. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mai

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: remove MAX_TRACKS limit

2020-04-04 Thread Carl Eugen Hoyos
Am Sa., 4. Apr. 2020 um 17:46 Uhr schrieb Jan Chren (rindeal) : > [...] I believe the question was: How did you test your patch? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsub

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add matroska subtitle muxer (.mks)

2020-04-04 Thread Jan Chren (rindeal)
On Sat, 4 Apr 2020 at 15:56, Paul B Mahol wrote: > > Looks like you sent exactly same patch as before. > This is actually the third time I sent it, but first time it went through to Patchwork, which is what counts. > This patch does unfortunately nothing as some changes from other files > are mi

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add matroska subtitle muxer (.mks)

2020-04-04 Thread Andreas Rheinhardt
Jan Chren (rindeal): > On Sat, 4 Apr 2020 at 15:56, Paul B Mahol wrote: >> >> Looks like you sent exactly same patch as before. >> > > This is actually the third time I sent it, but first time it went > through to Patchwork, which is what counts. > >> This patch does unfortunately nothing as som

[FFmpeg-devel] [PATCH] hwcontext_vulkan: only use one semaphore per image

2020-04-04 Thread Lynne
The idea was to allow separate planes to be filtered independently, however, in hindsight, literaly nothing uses separate per-plane semaphores and it would only work when each plane is backed by separate device memory. Patch attached. >From 39506e3d6d703b070d861f88d4cde5689eea7ae2 Mon Sep 17 00:0

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-04 Thread Ryo Hirafuji
> In an ideal world, crf 0 would force all other settings for a lossless encoding. I forgot to say that if "-lossless 1" is set, "crf" will also be 0 (in libaom, internally). All those conditions will be forced (ot at least checked by libaom) if we execute this line: > codecctl_int(avctx, AV1E_S

[FFmpeg-devel] [PATCH] lavc/vaapi_encode: adapt to the new internal encode API

2020-04-04 Thread Linjie Fu
Should be squashed with: Tested with: ffmpeg -hwaccel vaapi -vaapi_device /dev/dri/renderD128 -hwaccel_output_format vaapi \ -i ../bbb_sunflower_1080p_30fps_normal.mp4 -c:v h264_vaapi -f h264 -y /de

Re: [FFmpeg-devel] [inline assembly compliance] Issues and patches

2020-04-04 Thread Michael Niedermayer
On Sat, Apr 04, 2020 at 12:28:43PM +0200, FRÉDÉRIC RECOULES wrote: > Thank you for your answers. > > As you have pointed out, these patches are full of unrelated changes that are > not important for safety. > Most of them were never intended to be posted here, the diff we submitted was > the o

Re: [FFmpeg-devel] [PATCH] avcodec/amfenc: adapt to the new internal encode API

2020-04-04 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > James Almer > Sent: Saturday, April 4, 2020 06:19 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] avcodec/amfenc: adapt to the new > internal encode API > > Signed-off-by: James Almer > --- > libavcodec/amfenc.c | 45 -

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add matroska subtitle muxer (.mks)

2020-04-04 Thread Jan Chren (rindeal)
On Sat, 4 Apr 2020 at 16:32, Andreas Rheinhardt wrote: > > You should read my answers to your earlier mails. Any earlier mails have not reached either my mailbox or Patchwork. But hopefully I have found them in the public mail archive now. Terrible workflow got even worse... > > - Andreas __

[FFmpeg-devel] [PATCH] avutil/log: update text requesting samples

2020-04-04 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/log.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/log.c b/libavutil/log.c index 8d4945249e..a0b2348bd5 100644 --- a/libavutil/log.c +++ b/libavutil/log.c @@ -466,9 +466,9 @@ static void missing_feature_sample(int s

Re: [FFmpeg-devel] [inline assembly compliance] Issues and patches

2020-04-04 Thread FRÉDÉRIC RECOULES
> i can retest and find a mininal command line for configure which triggers > this > in case you cannot reproduce it ? Thank you, but it is a known (non) issue of Clang and is reproducible since at least 3.4.1. The fact is that GCC uses incomplete types in to say "block of unknown size" but

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add matroska subtitle muxer (.mks)

2020-04-04 Thread Jan Chren (rindeal)
On Sat, 4 Apr 2020 at 16:32, Andreas Rheinhardt wrote: > What is the aim of your patch? If it is simply making sure that using > the mks extension autoselects the Matroska muxer, That's correct. > then adding "mks" to > the list of extensions of the ordinary Matroska muxer would be enough. > (No

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Disable copy_ts on timestamp wraparound

2020-04-04 Thread Michael Niedermayer
On Thu, Oct 10, 2019 at 01:37:50PM +0300, Aleksey Skripka wrote: > Greetings! > > Michael, > patch works good for mpegts input, > > but for hls input it works only if add AVFMT_TS_DISCONT to .flags in > ff_hls_demuxer structure (libavformat/hls.c). > Is it right way? since d6ac6650b911f0957e69

Re: [FFmpeg-devel] [PATCH] avcodec/amfenc: adapt to the new internal encode API

2020-04-04 Thread James Almer
On 4/4/2020 1:59 PM, Fu, Linjie wrote: >> From: ffmpeg-devel On Behalf Of >> James Almer >> Sent: Saturday, April 4, 2020 06:19 >> To: ffmpeg-devel@ffmpeg.org >> Subject: [FFmpeg-devel] [PATCH] avcodec/amfenc: adapt to the new >> internal encode API >> >> Signed-off-by: James Almer >> --- >> lib

[FFmpeg-devel] [PATCH v2] avcodec/amfenc: adapt to the new internal encode API

2020-04-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/amfenc.c | 43 libavcodec/amfenc.h | 2 -- libavcodec/amfenc_h264.c | 1 - libavcodec/amfenc_hevc.c | 1 - 4 files changed, 17 insertions(+), 30 deletions(-) diff --git a/libavcodec/amfenc.c b/libavco

Re: [FFmpeg-devel] [PATCH v11 1/3] libavcodec/jpeg2000dec.c: Add support for PPT marker

2020-04-04 Thread Michael Niedermayer
On Sat, Apr 04, 2020 at 01:14:51PM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch adds functional changes to support the > PPT marker. Does this fix any files / testcases ? If yes, they should be mentioned in the commit message thx [...] -- Michael GnuPG fin

Re: [FFmpeg-devel] [PATCH 3/4] swscale/output: Fix integer overflow in yuv2rgb_write_full() with out of range input

2020-04-04 Thread Michael Niedermayer
On Sun, Feb 16, 2020 at 08:43:02PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 1169365504 + 981452800 cannot be represented > in type 'int' > Fixes: ticket8293 > > Found-by: Suhwan > Signed-off-by: Michael Niedermayer > --- > libswscale/output.c | 6 +++--- > 1 file chan

Re: [FFmpeg-devel] [PATCH 4/4] swscale/output: Fix integer overflow in alpha computation in yuv2gbrp16_full_X_c()

2020-04-04 Thread Michael Niedermayer
On Sun, Feb 16, 2020 at 08:43:03PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 524280 * 4432 cannot be represented in type > 'int' > Fixes: ticket8322 > > Found-by: Suhwan > Signed-off-by: Michael Niedermayer > --- > libswscale/output.c | 2 +- > 1 file changed, 1 insert

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Disable copy_ts on timestamp wraparound

2020-04-04 Thread Michael Niedermayer
On Fri, May 03, 2019 at 05:36:07PM +0200, Michael Niedermayer wrote: > This allows handling more than 26.5h of mpeg* input > > Fixes: Ticket 7876 > > Signed-off-by: Michael Niedermayer > --- > fftools/ffmpeg.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) will apply [.

Re: [FFmpeg-devel] [PATCH] avformat/mov: Discard last STSC if its empty

2020-04-04 Thread Michael Niedermayer
On Tue, Feb 04, 2020 at 02:48:42PM +0100, Michael Niedermayer wrote: > Fixes: Ticket8508 > --- > libavformat/mov.c | 4 > 1 file changed, 4 insertions(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "You are 36 times more likely to die in a b

Re: [FFmpeg-devel] [PATCH v11 1/3] libavcodec/jpeg2000dec.c: Add support for PPT marker

2020-04-04 Thread Carl Eugen Hoyos
Am Sa., 4. Apr. 2020 um 22:20 Uhr schrieb Michael Niedermayer : > > On Sat, Apr 04, 2020 at 01:14:51PM +0530, gautamr...@gmail.com wrote: > > From: Gautam Ramakrishnan > > > > This patch adds functional changes to support the > > PPT marker. > > Does this fix any files / testcases ? > If yes, they

[FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_enc: Add option to remove ivf container

2020-04-04 Thread Andriy Gelman
From: Andriy Gelman The dequeued packets from vp8 (s5p-mfc) encoder are output in ivf format which breaks the stream when the packets are muxed in avformat. This commit adds an option to remove the container and thus support the encoder. Signed-off-by: Andriy Gelman --- libavcodec/v4l2_m2m.h

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: increase autodetect timeout to 3 sec

2020-04-04 Thread Marton Balint
On Wed, 1 Apr 2020, Marton Balint wrote: 1 sec might not be enough for the cards to detect the format... Signed-off-by: Marton Balint --- libavdevice/decklink_dec.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_de

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add matroska subtitle muxer (.mks)

2020-04-04 Thread Carl Eugen Hoyos
Am Sa., 4. Apr. 2020 um 20:01 Uhr schrieb Jan Chren (rindeal) : > > On Sat, 4 Apr 2020 at 16:32, Andreas Rheinhardt > wrote: > > What is the aim of your patch? If it is simply making sure that using > > the mks extension autoselects the Matroska muxer, > > That's correct. > > > then adding "mks" t

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add matroska subtitle muxer (.mks)

2020-04-04 Thread James Almer
On 4/4/2020 3:00 PM, Jan Chren (rindeal) wrote: > On Sat, 4 Apr 2020 at 16:32, Andreas Rheinhardt > wrote: >> What is the aim of your patch? If it is simply making sure that using >> the mks extension autoselects the Matroska muxer, > > That's correct. > >> then adding "mks" to >> the list of ex

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add matroska subtitle muxer (.mks)

2020-04-04 Thread Andreas Rheinhardt
James Almer: > On 4/4/2020 3:00 PM, Jan Chren (rindeal) wrote: >> On Sat, 4 Apr 2020 at 16:32, Andreas Rheinhardt >> wrote: >>> What is the aim of your patch? If it is simply making sure that using >>> the mks extension autoselects the Matroska muxer, >> >> That's correct. >> >>> then adding "mks"

Re: [FFmpeg-devel] [PATCH]lavc: Use supported_samplerates for Dolby Digital encoders

2020-04-04 Thread Carl Eugen Hoyos
Am Di., 11. Feb. 2020 um 00:24 Uhr schrieb Carl Eugen Hoyos : > Attached patch probably fixes ticket #8518 and definitely simplifies > *ac3* encoding usage. Patch applied. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.

Re: [FFmpeg-devel] [PATCH]qsv: Fix format specifiers for int variables

2020-04-04 Thread Carl Eugen Hoyos
Am Fr., 3. Apr. 2020 um 21:49 Uhr schrieb Carl Eugen Hoyos : > > Am Mi., 1. Apr. 2020 um 16:55 Uhr schrieb Carl Eugen Hoyos > : > > > Attached patches fix three wrong format specifiers, the variables are > > all of type int but the specifier PRId16 is used. > > Will push them tomorrow. Done. Car

Re: [FFmpeg-devel] [PATCH]lavf, lavfi: Remove uses of sizeof(char)

2020-04-04 Thread Carl Eugen Hoyos
Am Sa., 4. Apr. 2020 um 06:40 Uhr schrieb Andreas Rheinhardt : > > Carl Eugen Hoyos: > > Hi! > > > > Attached patch removes uses of sizeof(char) from libavfilter and > > libavformat. > > > > Please comment, Carl Eugen > > > The commit message is misleading: Actually C is based around > sizeof(char

Re: [FFmpeg-devel] [PATCH] avutil/log: update text requesting samples

2020-04-04 Thread Carl Eugen Hoyos
Am Sa., 4. Apr. 2020 um 19:26 Uhr schrieb Marton Balint : > > Signed-off-by: Marton Balint > --- > libavutil/log.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavutil/log.c b/libavutil/log.c > index 8d4945249e..a0b2348bd5 100644 > --- a/libavutil/log.c > +++ b

Re: [FFmpeg-devel] [PATCH]lavc/sbc: Remove bool usage

2020-04-04 Thread Carl Eugen Hoyos
Am Mi., 1. Apr. 2020 um 21:30 Uhr schrieb Carl Eugen Hoyos : > It seems to me that this was forgotten when the codec was originally ported. Patch applied. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listi

Re: [FFmpeg-devel] [PATCH]configure: Filter -Wl, linker flags out for msvc compilation

2020-04-04 Thread Carl Eugen Hoyos
Am Fr., 3. Apr. 2020 um 22:01 Uhr schrieb Carl Eugen Hoyos : > > Am Mi., 1. Apr. 2020 um 16:59 Uhr schrieb Carl Eugen Hoyos > : > > > Attached patch silences a few warnings when compiling with cl.exe or > > clang-cl.exe. > > Or are there any working options? > > I will push this if there are no ob

Re: [FFmpeg-devel] [PATCH] avcodec/binkaudio: Check sample_rate to avoid integer overflow

2020-04-04 Thread Michael Niedermayer
On Sun, Feb 09, 2020 at 09:28:48PM +0100, Michael Niedermayer wrote: > On Sat, Feb 01, 2020 at 11:48:06PM +0100, Michael Niedermayer wrote: > > On Sat, Feb 01, 2020 at 04:17:10PM +0100, Paul B Mahol wrote: > > > On 2/1/20, Michael Niedermayer wrote: > > > > On Tue, Jan 14, 2020 at 04:04:29PM +0100

Re: [FFmpeg-devel] [PATCH 4/4] avisynth: fix deprecation warning

2020-04-04 Thread Stephen Hutchinson
On 3/24/2020 2:40 PM, Stephen Hutchinson wrote: On 3/12/20 7:38 PM, Stephen Hutchinson wrote: ---   libavformat/avisynth.c | 4 ++--   1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 43b65badc9..2c08ace8db 100644 --- a/libavforma

Re: [FFmpeg-devel] [PATCH]lavc/aacdec_template: Only warn once about unusual 7.1 encoding

2020-04-04 Thread Carl Eugen Hoyos
Am Fr., 27. März 2020 um 22:38 Uhr schrieb Carl Eugen Hoyos : > > Am Fr., 27. März 2020 um 19:00 Uhr schrieb Carl Eugen Hoyos > : > > > Attached patch reduces warnings when decoding a file with 7.1(wide) > > aac encoding. > > New patch attached that does not lead to new crashes. Patch applied. Ca

Re: [FFmpeg-devel] [PATCH 4/4] avisynth: fix deprecation warning

2020-04-04 Thread Carl Eugen Hoyos
Am Fr., 13. März 2020 um 00:38 Uhr schrieb Stephen Hutchinson : > > --- > libavformat/avisynth.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c > index 43b65badc9..2c08ace8db 100644 > --- a/libavformat/avisynth.c > +++ b

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: remove MAX_TRACKS limit

2020-04-04 Thread Jan Chren (rindeal)
On Sat Apr 4 09:29:20 EEST 2020, Andreas Rheinhardt wrote: > Are you running into this limitation? Yes. > If so, do the files that you > create with this patch that have more than 127 tracks work? They > shouldn't. The reason for this (and the reason that I didn't remove this > limit altogether

Re: [FFmpeg-devel] [PATCH] doc/general.texi: AviSynth+ works on Linux now, AvxSynth is gone.

2020-04-04 Thread Stephen Hutchinson
On 3/24/2020 2:39 PM, Stephen Hutchinson wrote: Related to this are the following changes: * Mention the two methods that AviSynth+ provides for installing just the headers. * Expand on users installing AviSynth on their system a little more. --- This is the only patch that needed changes.

[FFmpeg-devel] [PATCH 2/2] avcodec/cbs_h265_syntax_template: Check num_negative/positive_pics when inter_ref_pic_set_prediction_flag is set

2020-04-04 Thread Michael Niedermayer
Fixes: out of array access Fixes: 20446/clusterfuzz-testcase-minimized-ffmpeg_BSF_HEVC_METADATA_fuzzer-5707770718584832 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cbs_h265_syntax_template

[FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Update context on double init

2020-04-04 Thread Michael Niedermayer
Fixes: memleak Fixes: 19949/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5743636058210304 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/oggparsevorbis.c | 1 + 1 file changed, 1 ins

Re: [FFmpeg-devel] [PATCH 4/4] avisynth: fix deprecation warning

2020-04-04 Thread Marton Balint
On Sun, 5 Apr 2020, Carl Eugen Hoyos wrote: Am Fr., 13. März 2020 um 00:38 Uhr schrieb Stephen Hutchinson : --- libavformat/avisynth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 43b65badc9..2c08ace8db 100644

Re: [FFmpeg-devel] [PATCH 4/4] avisynth: fix deprecation warning

2020-04-04 Thread Carl Eugen Hoyos
Am So., 5. Apr. 2020 um 00:48 Uhr schrieb Marton Balint : > > > > On Sun, 5 Apr 2020, Carl Eugen Hoyos wrote: > > > Am Fr., 13. März 2020 um 00:38 Uhr schrieb Stephen Hutchinson > > : > >> > >> --- > >> libavformat/avisynth.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >>

Re: [FFmpeg-devel] [PATCH 2/4] avisynth: switch to AviSynth+ on Linux

2020-04-04 Thread Stephen Hutchinson
On 3/24/2020 2:40 PM, Stephen Hutchinson wrote: On 3/12/20 7:38 PM, Stephen Hutchinson wrote: AviSynth+ now supports non-Windows OSes, making AvxSynth obsolete.  Since we no longer support AviSynth 2.5 (which is essentially what AvxSynth is), remove AvxSynth support and replace it with AviSynth+

Re: [FFmpeg-devel] [PATCH]lavfi/telecine: Mark telecined frames as interlaced

2020-04-04 Thread Carl Eugen Hoyos
Am Sa., 4. Apr. 2020 um 00:44 Uhr schrieb Carl Eugen Hoyos : > > Am Sa., 4. Apr. 2020 um 00:40 Uhr schrieb James Almer : > > > > On 4/3/2020 6:37 PM, Carl Eugen Hoyos wrote: > > > Am Fr., 3. Apr. 2020 um 23:19 Uhr schrieb Carl Eugen Hoyos > > > : > > > > > >> Attached patch marks actually telecine

Re: [FFmpeg-devel] [PATCH 4/4] avisynth: fix deprecation warning

2020-04-04 Thread Marton Balint
On Sun, 5 Apr 2020, Carl Eugen Hoyos wrote: Am So., 5. Apr. 2020 um 00:48 Uhr schrieb Marton Balint : On Sun, 5 Apr 2020, Carl Eugen Hoyos wrote: > Am Fr., 13. März 2020 um 00:38 Uhr schrieb Stephen Hutchinson > : >> >> --- >> libavformat/avisynth.c | 4 ++-- >> 1 file changed, 2 inserti

Re: [FFmpeg-devel] [PATCH]lavc/amrwbdec: Do not ignore NO_DATA frames

2020-04-04 Thread Carl Eugen Hoyos
Am Sa., 9. Feb. 2019 um 20:43 Uhr schrieb Paul B Mahol : > > On 2/9/19, Carl Eugen Hoyos wrote: > > 2019-01-30 14:47 GMT+01:00, Carl Eugen Hoyos : > >> 2019-01-29 22:47 GMT+01:00, Carl Eugen Hoyos : > >>> Hi! > >>> > >>> Attached patch fixes decoding NO_DATA amr-wb frames. > >> > >> Now with patch

[FFmpeg-devel] [PATCH]lavc/amrwb: Output silence for frames marked as broken

2020-04-04 Thread Carl Eugen Hoyos
Hi! Attached patch makes the output of the file in ticket #7113 very similar to the reference decoder. Please comment, Carl Eugen From a10e9983e0724f736850b37d3732161a6cff2d6a Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 5 Apr 2020 01:59:21 +0200 Subject: [PATCH] lavc/amrwb: Output

Re: [FFmpeg-devel] [PATCH]lavfi/telecine: Mark telecined frames as interlaced

2020-04-04 Thread Carl Eugen Hoyos
Am So., 5. Apr. 2020 um 01:02 Uhr schrieb Carl Eugen Hoyos : > > Am Sa., 4. Apr. 2020 um 00:44 Uhr schrieb Carl Eugen Hoyos > : > > > > Am Sa., 4. Apr. 2020 um 00:40 Uhr schrieb James Almer : > > > > > > On 4/3/2020 6:37 PM, Carl Eugen Hoyos wrote: > > > > Am Fr., 3. Apr. 2020 um 23:19 Uhr schrieb

Re: [FFmpeg-devel] [PATCH]lavfi/telecine: Mark telecined frames as interlaced

2020-04-04 Thread Andriy Gelman
On Sun, 05. Apr 02:05, Carl Eugen Hoyos wrote: > Am So., 5. Apr. 2020 um 01:02 Uhr schrieb Carl Eugen Hoyos > : > > > > Am Sa., 4. Apr. 2020 um 00:44 Uhr schrieb Carl Eugen Hoyos > > : > > > > > > Am Sa., 4. Apr. 2020 um 00:40 Uhr schrieb James Almer : > > > > > > > > On 4/3/2020 6:37 PM, Carl Eu

[FFmpeg-devel] [PATCH v12] libavcodec/jpeg2000dec.c: Add support for PPT marker

2020-04-04 Thread gautamramk
From: Gautam Ramakrishnan This patch adds functional changes to support the PPT marker. This patch fixes bug ticket #4610. --- libavcodec/jpeg2000dec.c | 88 +++- 1 file changed, 77 insertions(+), 11 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavc

[FFmpeg-devel] [PATCH] avcodec/vp3: propagate error codes

2020-04-04 Thread Peter Ross
throughout vp3_decode_frame the error code was being captured (ret) but never returned. --- libavcodec/vp3.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index d53dd87029..2ae54255c6 100644 --- a/libavcodec/vp3.c

[FFmpeg-devel] [PATCH 1/2] avcodec/vp9: prevent null pointer use on init_frames() failure

2020-04-04 Thread Peter Ross
--- libavcodec/vp9.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 7ee375d4d0..c125e22975 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -1216,18 +1216,24 @@ static av_cold int vp9_decode_free(AVCodecContext *avctx) int i;

[FFmpeg-devel] [PATCH 2/2] avcodec/vp9: indent

2020-04-04 Thread Peter Ross
--- libavcodec/vp9.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index c125e22975..4f7cc4fc75 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -1225,14 +1225,14 @@ static av_cold int vp9_decode_free(AVCodecContext *av