> -Original Message-
> From: ffmpeg-devel On Behalf Of
> artem.ga...@gmail.com
> Sent: Thursday, April 9, 2020 7:51 PM
> To: ffmpeg-devel@ffmpeg.org
> Cc: Artem Galin
> Subject: [FFmpeg-devel] [PATCH 4/4] libavutil/qsv: enabling d3d11va support
>
> From: Artem Galin
>
> Makes selectio
On 4/10/2020 12:10 AM, Zane van Iperen wrote:
> Signed-off-by: Zane van Iperen
> ---
> Changelog| 1 +
> libavformat/Makefile | 1 +
> libavformat/allformats.c | 1 +
> libavformat/kvag.c | 78 +++-
> libavformat/version.h| 2 +
Signed-off-by: Zane van Iperen
---
Changelog | 1 +
doc/general.texi | 2 +-
libavcodec/Makefile| 1 +
libavcodec/adpcmenc.c | 30 ++
libavcodec/allcodecs.c | 1 +
libavcodec/utils.c | 1 +
libavcodec/version.h | 4 ++--
7 files chan
Signed-off-by: Zane van Iperen
---
Changelog| 1 +
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/kvag.c | 78 +++-
libavformat/version.h| 2 +-
5 files changed, 81 insertions(+), 2 deletions(-)
diff -
On 4/9/2020 10:25 PM, Fu, Linjie wrote:
>> From: ffmpeg-devel On Behalf Of
>> James Almer
>> Sent: Friday, April 10, 2020 02:27
>> To: ffmpeg-devel@ffmpeg.org
>> Subject: [FFmpeg-devel] [PATCH v2] avcodec/nvenc: adapt to the new
>> internal encode API
>>
>> Signed-off-by: James Almer
>> ---
>> Ve
> From: ffmpeg-devel On Behalf Of
> James Almer
> Sent: Friday, April 10, 2020 02:27
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH v2] avcodec/nvenc: adapt to the new
> internal encode API
>
> Signed-off-by: James Almer
> ---
> Version with the flush() callback left in place. Bu
On Thu, Apr 09, 2020 at 07:57:14PM +0200, Nicolas George wrote:
> Limin Wang (12020-04-09):
> > My patch set try to make the loudnorm filter easy to use for end user if
> > they
> > want to process the volume in two pass.
>
> Yes: you are seeing a problem, and you want to fix it, that's fine.
>
On 4/9/2020 10:04 PM, Fu, Linjie wrote:
>> From: ffmpeg-devel On Behalf Of
>> James Almer
>> Sent: Friday, April 10, 2020 02:27
>> To: ffmpeg-devel@ffmpeg.org
>> Subject: [FFmpeg-devel] [PATCH v2] avcodec/nvenc: adapt to the new
>> internal encode API
>>
>> Signed-off-by: James Almer
>> ---
>> Ve
> From: ffmpeg-devel On Behalf Of
> James Almer
> Sent: Friday, April 10, 2020 02:27
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH v2] avcodec/nvenc: adapt to the new
> internal encode API
>
> Signed-off-by: James Almer
> ---
> Version with the flush() callback left in place. Bu
On 4/9/2020 9:11 PM, Marton Balint wrote:
>
>
> On Fri, 10 Apr 2020, Andreas Rheinhardt wrote:
>
>> Marton Balint:
>>> Signed-off-by: Marton Balint
>>> ---
>>> doc/APIchanges | 3 +++
>>> libavcodec/avcodec.h | 19
>>> libavcodec/bsf.c | 62
>>> +
On Fri, 10 Apr 2020, Andreas Rheinhardt wrote:
Marton Balint:
Signed-off-by: Marton Balint
---
doc/APIchanges | 3 +++
libavcodec/avcodec.h | 19
libavcodec/bsf.c | 62
libavcodec/version.h | 2 +-
4 files cha
On Thu, 2020-04-09 at 14:00 -0700, Philip Langdale wrote:
> On Thu, 9 Apr 2020 19:30:53 +
> John Stebbins wrote:
> > Pushed to https://github.com/jstebbins/FFmpeg/commits/movtext
> >
> > There's one additional patch on the top implementing what we
> > discussed
> > about highlight alpha updat
EAGAIN is returned when input is provided but can't be consumed. The filtering
process is unaffected in this case, and the function will be able to consume
new input after retrieving filtered packets with av_bsf_receive_packet().
Remove the line about empty packets never failing added in
41b05b849
Hi,
On Thu, Apr 9, 2020 at 10:57 AM Nicolas George wrote:
> There is JSON-specific code in af_loudnorm.c, there should not be, I
> think we should start here.
>
> My opinion is we should rework ffprobe's writers and move them to lavu.
> That would be the first step.
Is there already a helper API
Marton Balint:
> Signed-off-by: Marton Balint
> ---
> doc/APIchanges | 3 +++
> libavcodec/avcodec.h | 19
> libavcodec/bsf.c | 62
>
> libavcodec/version.h | 2 +-
> 4 files changed, 85 insertions(+), 1 deletion(-
Marton Balint:
>
>
> On Thu, 9 Apr 2020, Andreas Rheinhardt wrote:
>
>> Marton Balint:
>>> Based on the one in ffmpeg.c and it is not using an extra flush_idx
>>> variable.
>>>
>>> Signed-off-by: Marton Balint
>>> ---
>>> libavcodec/bsf.c | 64
>>> ++
On Thu, 9 Apr 2020 19:30:53 +
John Stebbins wrote:
>
> Pushed to https://github.com/jstebbins/FFmpeg/commits/movtext
>
> There's one additional patch on the top implementing what we discussed
> about highlight alpha updates. Should I send that to the ml as well?
>
The new one looks good t
On Thu, 9 Apr 2020, Andreas Rheinhardt wrote:
Marton Balint:
Based on the one in ffmpeg.c and it is not using an extra flush_idx variable.
Signed-off-by: Marton Balint
---
libavcodec/bsf.c | 64 ++--
1 file changed, 25 insertions(+), 39 d
On Sun, Mar 15, 2020 at 06:53:18PM +0100, Stefano Sabatini wrote:
> On date Tuesday 2020-03-10 01:59:17 +0100, Carl Eugen Hoyos wrote:
> > Hi!
> >
> > The Chemnitzer Linuxtage were canceled yesterday because of the Coronavirus.
> > I request reimbursement of €138,86 for the flight to Germany I had
Marton Balint:
> Based on the one in ffmpeg.c and it is not using an extra flush_idx variable.
>
> Signed-off-by: Marton Balint
> ---
> libavcodec/bsf.c | 64
> ++--
> 1 file changed, 25 insertions(+), 39 deletions(-)
>
> diff --git a/libavco
On Thu, 2020-04-09 at 11:17 -0700, Philip Langdale wrote:
> On Thu, 9 Apr 2020 15:51:23 +
> John Stebbins wrote:
>
> > On Wed, 2020-04-08 at 12:24 -0700, Philip Langdale wrote:
> > > On Tue, 7 Apr 2020 14:38:52 +
> > > John Stebbins wrote:
> > >
> > > > After checking carefully, patch
On Thu, 9 Apr 2020 15:51:23 +
John Stebbins wrote:
> On Wed, 2020-04-08 at 12:24 -0700, Philip Langdale wrote:
> > On Tue, 7 Apr 2020 14:38:52 +
> > John Stebbins wrote:
> >
> > > After checking carefully, patches 10 and 23 are as I want them.
> > > Sizes
> > > are relative to 288 whe
On Thu, 9 Apr 2020 15:21:35 +
John Stebbins wrote:
> Well, I was leaving that in as a comment showing the structure of the
> sample description. But if it's confusing, I can just remove all
> those comments. There are several others that do not represent the
> actual values written.
Ok. T
On Thu, 9 Apr 2020 16:17:21 +
John Stebbins wrote:
> > >
> > > Worth a comment that secondary alpha can't be preserved?
> >
> > Sure, will do.
>
> Taking a second look at this, I'm wondering if alpha_id = 2 should be
> applied to the highlight color that is set in mov_text_color_cb? A
Signed-off-by: James Almer
---
Version with the flush() callback left in place. But it will need the
changes i originally added to avcodec_flush_buffers() and then removed
for the latest iteration of this set, in some form or another.
libavcodec/nvenc.c | 78 ++--
Fixes: shift exponent 32 is too large for 32-bit type 'int'
Fixes:
21200/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XAN_DPCM_fuzzer-5754704894361600
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
From: Artem Galin
Makes selection of d3d11va device type by default and over DirectX 9,
which is still supported but requires explicit selection.
This enables usage of non-powered/headless GPU, better HDR support.
Pool of resources is allocated as one texture with array of slices.
Added d3d11va
From: Artem Galin
child_device_type argument is responsible for selection.
Usage examples: -init_hw_device qsv:hw,child_device_type=d3d11va
-init_hw_device qsv:hw,child_device_type=dxva2
Signed-off-by: Artem Galin
---
fftools/ffmpeg_opt.c | 12 +++-
1 file changed, 11
Limin Wang (12020-04-09):
> My patch set try to make the loudnorm filter easy to use for end user if they
> want to process the volume in two pass.
Yes: you are seeing a problem, and you want to fix it, that's fine.
But the problem you are seeing is part of a wider problem, and fixing
the part yo
From: Artem Galin
Adding DX11 relevant device type checks and adjusting callbacks with
proper MediaSDK pair type support.
Extending structure for proper MediaSDK pair type support.
Signed-off-by: Artem Galin
---
libavcodec/qsv.c | 52 ---
libavcode
From: Artem Galin
Adding DX11 relevant device type checks and adjusting callback with
proper MediaSDK pair type support.
Signed-off-by: Artem Galin
---
libavfilter/qsvvpp.c | 40 ++--
1 file changed, 30 insertions(+), 10 deletions(-)
diff --git a/libavfilte
On Thu, 2020-04-09 at 09:43 -0700, Philip Langdale wrote:
> On Thu, 9 Apr 2020 15:09:45 +
> John Stebbins wrote:
>
> > >
> >
> > I missed this review earlier. What about the indentation is
> > off? Do
> > you mean the indent of the function parameters does not align after
> > the openin
On 4/9/2020 1:45 PM, Philip Langdale wrote:
> On Thu, 9 Apr 2020 11:20:09 -0300
> James Almer wrote:
>
>> On 4/8/2020 7:04 PM, Philip Langdale wrote:
>>> On Wed, 8 Apr 2020 14:58:36 -0300
>>> James Almer wrote:
>>>
Signed-off-by: James Almer
---
This removes the encode2() imp
On Thu, 9 Apr 2020 11:20:09 -0300
James Almer wrote:
> On 4/8/2020 7:04 PM, Philip Langdale wrote:
> > On Wed, 8 Apr 2020 14:58:36 -0300
> > James Almer wrote:
> >
> >> Signed-off-by: James Almer
> >> ---
> >> This removes the encode2() implementation as it'll never be used
> >> if a receiv
Am Do., 9. Apr. 2020 um 18:35 Uhr schrieb Andreas Rheinhardt
:
> Ok. Should patches like the ones contained in the patchset [1] also be
> pushed directly?
>
> - Andreas
>
> [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2019-October/252107.html
Imo, after you tested them: Definitely.
Carl Eugen
On Thu, 9 Apr 2020 15:09:45 +
John Stebbins wrote:
> >
>
> I missed this review earlier. What about the indentation is off? Do
> you mean the indent of the function parameters does not align after
> the opening paren? I was keeping the lines aligned without wrapping
> at 80 characters.
Carl Eugen Hoyos:
> Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt
> :
>>
>> Signed-off-by: Andreas Rheinhardt
>> ---
>> libavcodec/jpeg2000dec.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c
>> i
On Thu, 2020-04-09 at 08:23 -0700, John Stebbins wrote:
> On Wed, 2020-04-08 at 11:37 -0700, Philip Langdale wrote:
> > On Mon, 6 Apr 2020 11:52:13 -0600
> > John Stebbins wrote:
> >
> > > ---
> > > libavcodec/movtextenc.c | 25 -
> > > 1 file changed, 24 insertions(+), 1
Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt
:
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/jpeg2000dec.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c
> index 846e31d0a2..9684e57b34 10
On Wed, 2020-04-08 at 12:24 -0700, Philip Langdale wrote:
> On Tue, 7 Apr 2020 14:38:52 +
> John Stebbins wrote:
>
> > After checking carefully, patches 10 and 23 are as I want them.
> > Sizes
> > are relative to 288 when using override APIs, but are relative to
> > PlayResY when processing t
On Wed, 2020-04-08 at 11:37 -0700, Philip Langdale wrote:
> On Mon, 6 Apr 2020 11:52:13 -0600
> John Stebbins wrote:
>
> > ---
> > libavcodec/movtextenc.c | 25 -
> > 1 file changed, 24 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/movtextenc.c b/libavcode
On Wed, 2020-04-08 at 12:23 -0700, Philip Langdale wrote:
> On Mon, 6 Apr 2020 11:52:17 -0600
> John Stebbins wrote:
>
> > Initializes the mov text sample description from the ASS header and
> > creates an mov font table from the fonts available in the ASS
> > Styles.
> > ---
> > libavcodec/ass_
On Mon, 2020-04-06 at 20:03 +0200, Nicolas George wrote:
> John Stebbins (12020-04-06):
> > A conversion from rgb to bgr is necessary
> > ---
> > libavcodec/movtextdec.c | 11 +++
> > 1 file changed, 7 insertions(+), 4 deletions(-)
> >
> > diff --git a/libavcodec/movtextdec.c b/libavcodec
Fixes ticket #8607.
---
libavcodec/mediacodec_wrapper.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c
index 5213cf640a7..79abc8b6aa9 100644
--- a/libavcodec/mediacodec_wrapper.c
+++ b/libavcodec/mediacodec_wrapper.c
@@ -
On 4/8/2020 7:04 PM, Philip Langdale wrote:
> On Wed, 8 Apr 2020 14:58:36 -0300
> James Almer wrote:
>
>> Signed-off-by: James Almer
>> ---
>> This removes the encode2() implementation as it'll never be used if a
>> receive_packet() one exists, and the flush() implementation since
>> according
On Thu, Apr 09, 2020 at 01:16:16PM +0200, Nicolas George wrote:
> lance.lmw...@gmail.com (12020-04-09):
> > From: Limin Wang
> >
> > Signed-off-by: Limin Wang
> > ---
> > doc/filters.texi | 3 +++
> > libavfilter/af_loudnorm.c | 54 +--
> > 2 files
Michael Niedermayer:
> On Tue, Oct 22, 2019 at 03:16:45PM +0200, Andreas Rheinhardt wrote:
>> vobsub_read_packet() didn't check whether an index in array of AVPackets
>> was valid and therefore used uninitialized values.
>>
>> Signed-off-by: Andreas Rheinhardt
>> ---
>> Actually I only wanted to u
> 2020年4月9日 下午8:58，Andreas Rheinhardt 写道：
>
> Steven Liu:
>>
>>
>>> 2020年4月9日 下午5:55，Steven Liu 写道：
>>>
>>>
>>>
2020年4月9日 下午5:48，Andreas Rheinhardt 写道：
Steven Liu:
>
>
>> 2020年2月28日 下午5:53，Andreas Rheinhardt 写道：
>>
>> Signed-off-by: Andreas Rheinha
On Thu, Apr 09, 2020 at 07:07:20PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavfilter/ebur128.c | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147E
Steven Liu:
>
>
>> 2020年4月9日 下午5:55，Steven Liu 写道：
>>
>>
>>
>>> 2020年4月9日 下午5:48，Andreas Rheinhardt 写道：
>>>
>>> Steven Liu:
> 2020年2月28日 下午5:53，Andreas Rheinhardt 写道：
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/hlsenc.c | 13 -
> 1 fi
Signed-off-by: Andreas Rheinhardt
---
libavcodec/jpeg2000dec.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c
index 846e31d0a2..9684e57b34 100644
--- a/libavcodec/jpeg2000dec.c
+++ b/libavcodec/jpeg2000dec.c
@@ -862,6 +
lance.lmw...@gmail.com (12020-04-09):
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> doc/filters.texi | 3 +++
> libavfilter/af_loudnorm.c | 54 +--
> 2 files changed, 55 insertions(+), 2 deletions(-)
NACK.
If we are doing something like
Limin Wang (12020-04-09):
> Sorry, it seems that I remove these checking when av_dirname claims to support
> NULL for path in the API comments like glib dirname function. So I think it's
> duplicate check if the function claims to support NULL.
"Supporting NULL" can mean anything, and therefore me
From: Limin Wang
Signed-off-by: Limin Wang
---
doc/filters.texi | 2 +-
libavfilter/af_loudnorm.c | 12
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/doc/filters.texi b/doc/filters.texi
index 738a40df4e..19171d48dc 100644
--- a/doc/filters.texi
+++ b/doc/
From: Limin Wang
Signed-off-by: Limin Wang
---
libavfilter/af_loudnorm.c | 41 ++-
1 file changed, 40 insertions(+), 1 deletion(-)
diff --git a/libavfilter/af_loudnorm.c b/libavfilter/af_loudnorm.c
index 3012aa2471..380d0570d4 100644
--- a/libavfilter/af_lou
From: Limin Wang
Signed-off-by: Limin Wang
---
libavfilter/ebur128.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/libavfilter/ebur128.c b/libavfilter/ebur128.c
index c8986fb5e1..ca2fca0066 100644
--- a/libavfilter/ebur128.c
+++ b/libavfilter/ebur128.c
@@
From: Limin Wang
Signed-off-by: Limin Wang
---
doc/filters.texi | 3 +++
libavfilter/af_loudnorm.c | 54 +--
2 files changed, 55 insertions(+), 2 deletions(-)
diff --git a/doc/filters.texi b/doc/filters.texi
index 3931d8d79e..738a40df4e 100644
---
Marton Balint , 9 Nis 2020 Per, 01:23 tarihinde şunu yazdı:
>
>
> On Wed, 8 Apr 2020, Philip Langdale wrote:
>
> > On Wed, 8 Apr 2020 14:58:36 -0300
> > James Almer wrote:
> >
> >> Signed-off-by: James Almer
> >> ---
> >> This removes the encode2() implementation as it'll never be used if a
> >
On Thu, Apr 09, 2020 at 11:48:10AM +0200, Andreas Rheinhardt wrote:
> Steven Liu:
> >
> >
> >> 2020年2月28日 下午5:53，Andreas Rheinhardt 写道：
> >>
> >> Signed-off-by: Andreas Rheinhardt
> >> ---
> >> libavformat/hlsenc.c | 13 -
> >> 1 file changed, 12 insertions(+), 1 deletion(-)
> >>
> >
Steven Liu (12020-04-09):
> I said I don’t care about it here, because it don’t is not affected
> the workflow, you can merge it if it can make you happy. I have no
> reason objection it, and no reason agreed it.:D
Ok.
Also, please heed reply-to headers instead of Cc-ing anybody randomly.
Regar
> 2020年4月9日 下午5:55，Steven Liu 写道：
>
>
>
>> 2020年4月9日 下午5:48，Andreas Rheinhardt 写道：
>>
>> Steven Liu:
>>>
>>>
2020年2月28日 下午5:53，Andreas Rheinhardt 写道：
Signed-off-by: Andreas Rheinhardt
---
libavformat/hlsenc.c | 13 -
1 file changed, 12 insertion
> 2020年4月9日 下午5:48，Andreas Rheinhardt 写道：
>
> Steven Liu:
>>
>>
>>> 2020年2月28日 下午5:53，Andreas Rheinhardt 写道：
>>>
>>> Signed-off-by: Andreas Rheinhardt
>>> ---
>>> libavformat/hlsenc.c | 13 -
>>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/libavformat/h
Steven Liu:
>
>
>> 2020年2月28日 下午5:53，Andreas Rheinhardt 写道：
>>
>> Signed-off-by: Andreas Rheinhardt
>> ---
>> libavformat/hlsenc.c | 13 -
>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
>> index a281c379f0..18f40ff3ed
> 2020年4月9日 下午5:33，Nicolas George 写道：
>
> Steven Liu (12020-04-09):
>> I think every body have themselves reason to checking memory and remove the
>> checking at here.
>> Whatever for me you can add them here for somebody copy, other body remove
>> them
>> some days(maybe long time later) so
Steven Liu (12020-04-09):
> I think every body have themselves reason to checking memory and remove the
> checking at here.
> Whatever for me you can add them here for somebody copy, other body remove
> them
> some days(maybe long time later) some body remove remove the for unnecessary
> proces
Signed-off-by: Paul B Mahol
---
libavcodec/zerocodec.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/libavcodec/zerocodec.c b/libavcodec/zerocodec.c
index b0fab91004..1051fdaa45 100644
--- a/libavcodec/zerocodec.c
+++ b/libavcodec/zerocodec.c
@@ -131,10 +131,8 @@ stat
> 2020年4月9日 下午4:49，Nicolas George 写道：
>
> Steven Liu (12020-04-09):
>> It’s unnecessary here,
>> I have checked all strdup return checker in hlsenc some month ago, and
>> double check the workflow in update_master_pl_info,
>> It's the safe whether you check the strdup or not.
>> Reference comm
On Tue, Oct 22, 2019 at 03:16:45PM +0200, Andreas Rheinhardt wrote:
> vobsub_read_packet() didn't check whether an index in array of AVPackets
> was valid and therefore used uninitialized values.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> Actually I only wanted to use Valgrind to check for mem
Signed-off-by: Paul B Mahol
---
libavcodec/zerocodec.c | 8
1 file changed, 8 insertions(+)
diff --git a/libavcodec/zerocodec.c b/libavcodec/zerocodec.c
index e67eee4f7d..b0fab91004 100644
--- a/libavcodec/zerocodec.c
+++ b/libavcodec/zerocodec.c
@@ -139,6 +139,13 @@ static av_cold int
Steven Liu (12020-04-09):
> It’s unnecessary here,
> I have checked all strdup return checker in hlsenc some month ago, and double
> check the workflow in update_master_pl_info,
> It's the safe whether you check the strdup or not.
> Reference commit id: 61aa77272a25d83e5ce5c63d93c64bb9a3e15557
Ho
Rosen Penev (12020-04-08):
> avfilter/vf_drawtext: only test available exceptions
> +#if defined(FE_INVALID) && defined(FE_OVERFLOW) && defined(FE_UNDERFLOW)
Sorry to have missed it before it was pushed: at the very least, the
commit message is misleading.
With this change, if only one or two or
lgtm
Best regards,
Ming Qian
Tel#:86-512-6805-6630
-Original Message-
From: ffmpeg-devel On Behalf Of Andriy Gelman
Sent: Saturday, March 14, 2020 10:32 PM
To: ffmpeg-devel@ffmpeg.org
Subject: [EXT] Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/v4l2_m2m_enc: Reduce
log verbosity for some
Lgtm,
But if don't prevent enqueue frame buffer of capture port, unlikely to happen
this case.
And I think we can get a proper num_frame_buffers by g_ctrl
V4L2_CID_MIN_BUFFERS_FOR_CAPTURE and V4L2_CID_MIN_BUFFERS_FOR_OUTPUT.
Best regards,
Ming Qian
Tel#:86-512-6805-6630
-Original Messag
73 matches
Mail list logo
