Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/libaomenc.c: Add a libaom command-line option 'tune'

On Fri, Apr 3, 2020 at 2:07 PM Wang Cao wrote: > > Signed-off-by: Wang Cao > --- > doc/encoders.texi | 9 + > libavcodec/libaomenc.c | 7 +++ > libavcodec/version.h | 2 +- > 3 files changed, 17 insertions(+), 1 deletion(-) > lgtm. I'll apply this soon. __

Re: [FFmpeg-devel] [PATCH] libavformat/mov: restore use of mfra time as dts

On 10-04-2020 09:20 pm, Gyan Doshi wrote: On 10-04-2020 08:04 pm, John Stebbins wrote: On Thu, 2020-04-09 at 10:56 +0530, Gyan Doshi wrote: On 06-04-2020 11:12 pm, John Stebbins wrote: This was inadvertantly removed in 4a9d32baca ---    libavformat/mov.c | 5 +    1 file changed, 5 inse

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/delogo: remove deprecated options

On 11-04-2020 02:17 am, James Almer wrote: On 4/10/2020 4:30 PM, Gyan Doshi wrote: Deprecated in 2015 in 8bc708fcee1 --- libavfilter/vf_delogo.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c index 5a2c5e

[FFmpeg-devel] [PATCH 1/3] libavcodec/jpeg2000: fix cblk decode error check

From: Gautam Ramakrishnan bpno becoming negative is not an error. This check has been verified with openjpeg, where the loop ends safely when bpno becomes negative, instead of returning an error. This patch must resolve ticket #5630. --- libavcodec/jpeg2000dec.c | 6 +- 1 file changed, 1 ins

[FFmpeg-devel] [PATCH 2/3] libavcodec/jpeg2000dec.c: fix error in cod marker

From: Gautam Ramakrishnan This patch fixes an error where the COC marker overrides all data of the SPcod field of the COD marker. It must override only one bit of SPcod field. This now allows p0_08.j2k to be decoded correctly (mentioned in #4679). --- libavcodec/jpeg2000dec.c | 3 +++ 1 file cha

[FFmpeg-devel] [PATCH 3/3] libavcodec/jpeg2000: fix precinct coordinate calculation

From: Gautam Ramakrishnan The calculation of precinct boundaries has been fixed. The precinct boundaries were calculated as an offset to the band boundary, but must instead be calculated as an offset from the reslevel. This patch fixes #4669 and #4679. --- libavcodec/jpeg2000.c | 4 ++-- 1 file

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/zerocodec: use init cleanup internal cap

On Thu, Apr 9, 2020 at 5:21 AM Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/zerocodec.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/zerocodec.c b/libavcodec/zerocodec.c > index b0fab91004..1051fdaa45 100644 > --- a/libavcode

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/libaomenc.c: Add a libaom command-line option 'tune'

On Fri, Apr 10, 2020 at 10:50 PM James Zern wrote: > > On Fri, Apr 3, 2020 at 2:07 PM Wang Cao wrote: > > > > Signed-off-by: Wang Cao > > --- > > doc/encoders.texi | 9 + > > libavcodec/libaomenc.c | 7 +++ > > libavcodec/version.h | 2 +- > > 3 files changed, 17 insertions(+

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/libaomenc.c: Add super-resolution options to libaom wrapper

On Fri, Apr 3, 2020 at 2:10 PM Wang Cao wrote: > > Signed-off-by: Wang Cao > --- > doc/encoders.texi | 39 +++ > libavcodec/libaomenc.c | 47 ++ > libavcodec/version.h | 2 +- > 3 files changed, 87 insertions(+), 1 d

Re: [FFmpeg-devel] [PATCH] avcodec/cbs: Allocate more CodedBitstreamUnit at once in cbs_insert_unit()

On 4/10/2020 11:49 PM, James Almer wrote: > On 4/10/2020 9:00 PM, James Almer wrote: >> On 4/10/2020 8:53 PM, Michael Niedermayer wrote: >>> On Fri, Apr 10, 2020 at 05:44:25PM -0300, James Almer wrote: On 4/10/2020 5:23 PM, Michael Niedermayer wrote: > Fixes: Timeout (85sec -> 0.5sec)

Re: [FFmpeg-devel] [PATCH] avcodec/cbs: Allocate more CodedBitstreamUnit at once in cbs_insert_unit()

On 4/10/2020 9:00 PM, James Almer wrote: > On 4/10/2020 8:53 PM, Michael Niedermayer wrote: >> On Fri, Apr 10, 2020 at 05:44:25PM -0300, James Almer wrote: >>> On 4/10/2020 5:23 PM, Michael Niedermayer wrote: Fixes: Timeout (85sec -> 0.5sec) Fixes: 20791/clusterfuzz-testcase-minimiz

Re: [FFmpeg-devel] [PATCH] libavcodec/jpeg2000dec.c: fix error in cod marker

On Sat, Apr 11, 2020 at 2:25 AM Carl Eugen Hoyos wrote: > > Am Fr., 10. Apr. 2020 um 20:28 Uhr schrieb : > > > > From: Gautam Ramakrishnan > > > > This patch fixes an error where the COC marker > > overrides all data of the SPcod field of the > > COD marker. It must override only one bit of > > S

Re: [FFmpeg-devel] [PATCH v1] fftools/ffprobe: Use format specifier PRId64 instead of %lld

On Fri, Apr 10, 2020 at 07:37:40PM +0200, Michael Niedermayer wrote: > On Fri, Apr 10, 2020 at 07:04:38PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > fftools/ffprobe.c | 14 +++--- > > 1 file changed, 7 insertions(+), 7 deletio

Re: [FFmpeg-devel] [PATCH v1 2/2] avfilter/vf_subtitles: add force_style option for ass subtitle filter

please help to review, so that we can change the subtitle postion, color by force_style. On Mon, Mar 30, 2020 at 06:52:33PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/filters.texi | 4 > libavfilter/vf_subtitles.c | 23 ++

Re: [FFmpeg-devel] [PATCH v2] avformat/dashdec: add attribute lang for audio and subtitle streams

> 2020年4月8日 下午10:39，Steven Liu 写道： > > > >> 2020年3月31日 下午8:20，Steven Liu 写道： >> >> There should have language in the metadata of streams which show to user >> >> Signed-off-by: Steven Liu >> --- >> libavformat/dashdec.c | 49 +++ >> 1 file changed, 4

Re: [FFmpeg-devel] [PATCH v2] avcodec: Add explicit capability flag for encoder flushing

On Fri, 10 Apr 2020 20:01:29 -0300 James Almer wrote: > The assert needs to be under the following chunk, like it was in the > first version, after we have already established that we're dealing > with a flush enabled encoder to ensure that it's not also wrongly > marked as supporting frame threa

[FFmpeg-devel] [PATCH v3] avcodec: Add explicit capability flag for encoder flushing

We've been in this fuzzy situation where maybe you could call avcodec_flush_buffers() on an encoder but there weren't any encoders that supported it except maybe audiotoolboxenc. Then we added flush support to nvenc very intentionally, and it worked, but that was more a coincidence than anything el

Re: [FFmpeg-devel] [PATCH] avcodec/cbs: Allocate more CodedBitstreamUnit at once in cbs_insert_unit()

On 4/10/2020 8:53 PM, Michael Niedermayer wrote: > On Fri, Apr 10, 2020 at 05:44:25PM -0300, James Almer wrote: >> On 4/10/2020 5:23 PM, Michael Niedermayer wrote: >>> Fixes: Timeout (85sec -> 0.5sec) >>> Fixes: >>> 20791/clusterfuzz-testcase-minimized-ffmpeg_BSF_AV1_FRAME_SPLIT_fuzzer-56595377199

Re: [FFmpeg-devel] [PATCH] avcodec/cbs: Allocate more CodedBitstreamUnit at once in cbs_insert_unit()

On Fri, Apr 10, 2020 at 05:44:25PM -0300, James Almer wrote: > On 4/10/2020 5:23 PM, Michael Niedermayer wrote: > > Fixes: Timeout (85sec -> 0.5sec) > > Fixes: > > 20791/clusterfuzz-testcase-minimized-ffmpeg_BSF_AV1_FRAME_SPLIT_fuzzer-5659537719951360 > > Fixes: > > 21214/clusterfuzz-testcase-min

Re: [FFmpeg-devel] [PATCH v2] avcodec: Add explicit capability flag for encoder flushing

On 4/10/2020 7:38 PM, Philip Langdale wrote: > We've been in this fuzzy situation where maybe you could call > avcodec_flush_buffers() on an encoder but there weren't any encoders > that supported it except maybe audiotoolboxenc. Then we added flush > support to nvenc very intentionally, and it wor

Re: [FFmpeg-devel] [PATCH] avcodec: Add explicit capability flag for encoder flushing

On Fri, 10 Apr 2020 18:47:06 -0300 James Almer wrote: > > Seems fine in principle, but I'd like to hear Anton's opinion. Thanks. I've sent an updated patch and will wait for Anton. --phil ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https:/

[FFmpeg-devel] [PATCH v2] avcodec: Add explicit capability flag for encoder flushing

We've been in this fuzzy situation where maybe you could call avcodec_flush_buffers() on an encoder but there weren't any encoders that supported it except maybe audiotoolboxenc. Then we added flush support to nvenc very intentionally, and it worked, but that was more a coincidence than anything el

Re: [FFmpeg-devel] [PATCH] avcodec/cbs: Allocate more CodedBitstreamUnit at once in cbs_insert_unit()

On 4/10/2020 5:44 PM, James Almer wrote: > On 4/10/2020 5:23 PM, Michael Niedermayer wrote: >> Fixes: Timeout (85sec -> 0.5sec) >> Fixes: >> 20791/clusterfuzz-testcase-minimized-ffmpeg_BSF_AV1_FRAME_SPLIT_fuzzer-5659537719951360 >> Fixes: >> 21214/clusterfuzz-testcase-minimized-ffmpeg_BSF_MPEG2_M

Re: [FFmpeg-devel] [PATCH] libavformat/mov: fix multiple trun per traf

On Sun, Mar 29, 2020 at 02:27:38PM -0700, John Stebbins wrote: > dts would start over at the beginning of each trun when they should be > computed contiguously for each trun in a traf > > Fixes ticket 8070 > --- > libavformat/isom.h | 1 + > libavformat/mov.c | 12 +++- > 2 files change

Re: [FFmpeg-devel] [PATCH] mov: fix seek to next root atom in fragmented mp4

On Sun, Mar 29, 2020 at 08:48:50PM +, John Stebbins wrote: > On Sun, 2020-03-29 at 22:38 +0200, Andreas Rheinhardt wrote: > > John Stebbins: > > > If some but not all moof's are referenced in an sidx, whole > > > fragments > > > were being skipped. > > > > > > Fixes tickets 7377, 7389, and 850

Re: [FFmpeg-devel] Subtitle encoder return codes

On Fri, 2020-04-10 at 14:12 -0700, Philip Langdale wrote: > On Fri, 10 Apr 2020 13:02:16 -0600 > John Stebbins wrote: > > > Patch set makes return codes from subtitle encoders more meaningful > > and consistent. Also fixes output buffer size checking where > > needed. > > > > After this, a user

Re: [FFmpeg-devel] [PATCH] avcodec: Add explicit capability flag for encoder flushing

On 4/10/2020 5:58 PM, Philip Langdale wrote: > We've been in this fuzzy situation where maybe you could call > avcodec_flush_buffers() on an encoder but there weren't any encoders > that supported it except maybe audiotoolboxenc. Then we added flush > support to nvenc very intentionally, and it wor

Re: [FFmpeg-devel] Subtitle encoder return codes

On Fri, 10 Apr 2020 13:02:16 -0600 John Stebbins wrote: > Patch set makes return codes from subtitle encoders more meaningful > and consistent. Also fixes output buffer size checking where needed. > > After this, a user of a subtitle encoder can attempt to encode again > with a larger buffer if

Re: [FFmpeg-devel] [PATCH] avutil/log: update text requesting samples

On Fri, 10 Apr 2020, Carl Eugen Hoyos wrote: Am Fr., 10. Apr. 2020 um 20:12 Uhr schrieb Marton Balint : On Sat, 4 Apr 2020, Carl Eugen Hoyos wrote: > Am Sa., 4. Apr. 2020 um 19:26 Uhr schrieb Marton Balint : >> >> Signed-off-by: Marton Balint >> --- >> libavutil/log.c | 6 +++--- >> 1 f

[FFmpeg-devel] [PATCH] avcodec: Add explicit capability flag for encoder flushing

We've been in this fuzzy situation where maybe you could call avcodec_flush_buffers() on an encoder but there weren't any encoders that supported it except maybe audiotoolboxenc. Then we added flush support to nvenc very intentionally, and it worked, but that was more a coincidence than anything el

Re: [FFmpeg-devel] [PATCH] avutil/log: update text requesting samples

Am Fr., 10. Apr. 2020 um 20:12 Uhr schrieb Marton Balint : > > > > On Sat, 4 Apr 2020, Carl Eugen Hoyos wrote: > > > Am Sa., 4. Apr. 2020 um 19:26 Uhr schrieb Marton Balint : > >> > >> Signed-off-by: Marton Balint > >> --- > >> libavutil/log.c | 6 +++--- > >> 1 file changed, 3 insertions(+), 3 d

Re: [FFmpeg-devel] [PATCH] libavcodec/jpeg2000dec.c: Fix cblk decode error check

Am Fr., 10. Apr. 2020 um 19:48 Uhr schrieb Gautam Ramakrishnan : > > On Wed, Apr 1, 2020 at 5:48 PM Paul B Mahol wrote: > > > > LGTM > > > > On 4/1/20, gautamr...@gmail.com wrote: > > > From: Gautam Ramakrishnan > > > > > > bpno becoming negative is not an error. This check has > > > been verifi

Re: [FFmpeg-devel] [PATCH] libavcodec/jpeg2000dec.c: fix error in cod marker

Am Fr., 10. Apr. 2020 um 20:28 Uhr schrieb : > > From: Gautam Ramakrishnan > > This patch fixes an error where the COC marker > overrides all data of the SPcod field of the > COD marker. It must override only one bit of > SPcod field. This now allows p0_08.j2k to be > decoded correctly (mentioned

Re: [FFmpeg-devel] [PATCH] avcodec/cbs: Allocate more CodedBitstreamUnit at once in cbs_insert_unit()

On 4/10/2020 5:23 PM, Michael Niedermayer wrote: > Fixes: Timeout (85sec -> 0.5sec) > Fixes: > 20791/clusterfuzz-testcase-minimized-ffmpeg_BSF_AV1_FRAME_SPLIT_fuzzer-5659537719951360 > Fixes: > 21214/clusterfuzz-testcase-minimized-ffmpeg_BSF_MPEG2_METADATA_fuzzer-5165560875974656 > Fixes: > 2124

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/delogo: remove deprecated options

On 4/10/2020 4:30 PM, Gyan Doshi wrote: > Deprecated in 2015 in 8bc708fcee1 > --- > libavfilter/vf_delogo.c | 15 +-- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c > index 5a2c5e7feb..8edbe03cdc 100644 > --- a/liba

[FFmpeg-devel] [PATCH] avcodec/cbs: Allocate more CodedBitstreamUnit at once in cbs_insert_unit()

Fixes: Timeout (85sec -> 0.5sec) Fixes: 20791/clusterfuzz-testcase-minimized-ffmpeg_BSF_AV1_FRAME_SPLIT_fuzzer-5659537719951360 Fixes: 21214/clusterfuzz-testcase-minimized-ffmpeg_BSF_MPEG2_METADATA_fuzzer-5165560875974656 Fixes: 21247/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_METADATA_fuzze

[FFmpeg-devel] [PATCH 2/4] avformat/mpegtsenc: only allow one program in m2ts mode

The standard does not allow more. Signed-off-by: Marton Balint --- libavformat/mpegtsenc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 5e71a0b6f8..97d2dda22d 100644 --- a/libavformat/mpegtsenc.c +++ b/libavform

[FFmpeg-devel] [PATCH 1/4] avformat/mpegtsenc: use standard pids for m2ts

Signed-off-by: Marton Balint --- doc/muxers.texi | 6 -- libavformat/mpegts.h| 10 ++ libavformat/mpegtsenc.c | 44 +++- 3 files changed, 57 insertions(+), 3 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 4b6ffaa

[FFmpeg-devel] [PATCH 3/4] avformat/mpegtsenc: factorize determining stream_type

Signed-off-by: Marton Balint --- libavformat/mpegtsenc.c | 147 ++-- 1 file changed, 79 insertions(+), 68 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 97d2dda22d..add35aca89 100644 --- a/libavformat/mpegtsenc.c +++

[FFmpeg-devel] [PATCH 4/4] avformat/mpegtsenc: use the correct stream_types and write HDMV descriptors for m2ts

Fixes ticket #2622. Signed-off-by: Marton Balint --- libavformat/mpegtsenc.c | 58 - 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index add35aca89..b154675d60 100644 --- a/libavform

[FFmpeg-devel] [PATCH 2/2] avfilter/delogo: correct indentation for option show.

--- libavfilter/vf_delogo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c index 8edbe03cdc..e55673d5ad 100644 --- a/libavfilter/vf_delogo.c +++ b/libavfilter/vf_delogo.c @@ -211,7 +211,7 @@ static const AVOption delogo_options

[FFmpeg-devel] [PATCH 1/2] avfilter/delogo: remove deprecated options

Deprecated in 2015 in 8bc708fcee1 --- libavfilter/vf_delogo.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c index 5a2c5e7feb..8edbe03cdc 100644 --- a/libavfilter/vf_delogo.c +++ b/libavfilter/vf_delogo.c @@ -21

Re: [FFmpeg-devel] movtext decode/encode improvements

On Fri, 2020-04-10 at 09:50 -0700, Philip Langdale wrote: > On Thu, 9 Apr 2020 23:28:49 + > John Stebbins wrote: > > > > Essentially yes. We've had our own mov text encoder and decoder in > > HandBrake for years. I added support for using ffmpeg for decoding > > subtitles last year but the

[FFmpeg-devel] [PATCH 7/7] lavc/xsubenc: return meaningfull error codes

--- libavcodec/xsubenc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/xsubenc.c b/libavcodec/xsubenc.c index b3da909679..4d58e0f3b5 100644 --- a/libavcodec/xsubenc.c +++ b/libavcodec/xsubenc.c @@ -63,7 +63,7 @@ static int xsub_encode_rle(PutBitContext

[FFmpeg-devel] [PATCH 6/7] lavc/webvttenc: return more meaningful error codes

--- libavcodec/webvttenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/webvttenc.c b/libavcodec/webvttenc.c index c84bbf4b4e..febf6ee370 100644 --- a/libavcodec/webvttenc.c +++ b/libavcodec/webvttenc.c @@ -168,7 +168,7 @@ static int webvtt_encode_frame(AVCode

[FFmpeg-devel] [PATCH 4/7] lavc/movtextenc: return more meaningful error codes

--- libavcodec/movtextenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c index d8dbc546aa..b2368b641b 100644 --- a/libavcodec/movtextenc.c +++ b/libavcodec/movtextenc.c @@ -693,7 +693,7 @@ static int mov_text_encode_frame

[FFmpeg-devel] [PATCH 2/7] lavc/dvbsub: return meaningful error codes

--- libavcodec/dvbsub.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/dvbsub.c b/libavcodec/dvbsub.c index a0be0b1056..5c081f2b71 100644 --- a/libavcodec/dvbsub.c +++ b/libavcodec/dvbsub.c @@ -282,7 +282,7 @@ static int encode_dvb_subtitles(AVCodecContext *

[FFmpeg-devel] [PATCH 5/7] lavc/srtenc: return more meaninful error codes

--- libavcodec/srtenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/srtenc.c b/libavcodec/srtenc.c index 34f0f0d5e6..655b65679e 100644 --- a/libavcodec/srtenc.c +++ b/libavcodec/srtenc.c @@ -241,7 +241,7 @@ static int encode_frame(AVCodecContext *avctx,

[FFmpeg-devel] [PATCH 3/7] lavc/assenc: return more meaningful error code

When the buffer is too small, return AVERROR_BUFFER_TOO_SMALL --- libavcodec/assenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/assenc.c b/libavcodec/assenc.c index e54c1d8ec3..a6e1d5d8b9 100644 --- a/libavcodec/assenc.c +++ b/libavcodec/assenc.c @@ -93,7 +93,7

[FFmpeg-devel] [PATCH 1/7] lavc/dvbsub: fix potential encode buffer overflow

encode buffer size was ignored --- libavcodec/dvbsub.c | 97 +++-- 1 file changed, 75 insertions(+), 22 deletions(-) diff --git a/libavcodec/dvbsub.c b/libavcodec/dvbsub.c index a8d43d81d6..a0be0b1056 100644 --- a/libavcodec/dvbsub.c +++ b/libavcodec/dvbsub

[FFmpeg-devel] Subtitle encoder return codes

Patch set makes return codes from subtitle encoders more meaningful and consistent. Also fixes output buffer size checking where needed. After this, a user of a subtitle encoder can attempt to encode again with a larger buffer if the encoder returns AVERROR_BUFFER_TOO_SMALL __

[FFmpeg-devel] [PATCH] libavcodec/jpeg2000dec.c: fix error in cod marker

From: Gautam Ramakrishnan This patch fixes an error where the COC marker overrides all data of the SPcod field of the COD marker. It must override only one bit of SPcod field. This now allows p0_08.j2k to be decoded correctly (mentioned in #4679). --- libavcodec/jpeg2000dec.c | 3 +++ 1 file cha

Re: [FFmpeg-devel] [PATCH 4/4] avcodec.h: split bitstream filters API into its own header

On 4/10/2020 12:42 PM, Anton Khirnov wrote: > --- > doc/APIchanges | 3 +- > libavcodec/Makefile| 1 + > libavcodec/aac_adtstoasc_bsf.c | 2 +- > libavcodec/av1_frame_merge_bsf.c | 2 +- > libavcodec/av1_frame_split_bsf.c |

Re: [FFmpeg-devel] [PATCH] avutil/log: update text requesting samples

On Sat, 4 Apr 2020, Carl Eugen Hoyos wrote: Am Sa., 4. Apr. 2020 um 19:26 Uhr schrieb Marton Balint : Signed-off-by: Marton Balint --- libavutil/log.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/log.c b/libavutil/log.c index 8d4945249e..a0b2348bd5 10

Re: [FFmpeg-devel] [PATCH] libavcodec/jpeg2000dec.c: Fix cblk decode error check

On Wed, Apr 1, 2020 at 5:48 PM Paul B Mahol wrote: > > LGTM > > On 4/1/20, gautamr...@gmail.com wrote: > > From: Gautam Ramakrishnan > > > > bpno becoming negative is not an error. This check has > > been verified with openjpeg, where the loop ends safely > > when bpno becomes negative, instead

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/bsf: add av_bsf_join() to chain bitstream filters

James Almer: > On 4/10/2020 11:56 AM, Marton Balint wrote: >> >> >> On Fri, 10 Apr 2020, James Almer wrote: >> >>> On 4/10/2020 5:25 AM, Marton Balint wrote: >> >> [...] >> >>> >>> Finally, (I feel bad having to tell you this given that you have >>> clearly >>> invested a lot of tim

Re: [FFmpeg-devel] [PATCH v1] fftools/ffprobe: Use format specifier PRId64 instead of %lld

On Fri, Apr 10, 2020 at 07:04:38PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > fftools/ffprobe.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index e3f221f560..a

Re: [FFmpeg-devel] [PATCH 04/10] avformat/mux: Fix leaks of uncoded frames on errors

On Fri, 10 Apr 2020, Andreas Rheinhardt wrote: Marton Balint: On Tue, 31 Mar 2020, Andreas Rheinhardt wrote: If writing an uncoded frame fails at the preparatory steps of av_[interleaved_]write_frame(), the frame would be either not freed at all in case of av_write_frame() or would leak w

Re: [FFmpeg-devel] movtext decode/encode improvements

On Thu, 9 Apr 2020 23:28:49 + John Stebbins wrote: > Essentially yes. We've had our own mov text encoder and decoder in > HandBrake for years. I added support for using ffmpeg for decoding > subtitles last year but the movtext decoder wasn't up to the same > level as ours, so we weren't us

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/bsf: add av_bsf_join() to chain bitstream filters

On 4/10/2020 11:56 AM, Marton Balint wrote: > > > On Fri, 10 Apr 2020, James Almer wrote: > >> On 4/10/2020 5:25 AM, Marton Balint wrote: > > [...] > >> >> Finally, (I feel bad having to tell you this given that you have >> clearly >> invested a lot of time in this) we currentl

Re: [FFmpeg-devel] [PATCH 04/10] avformat/mux: Fix leaks of uncoded frames on errors

Marton Balint: > > > On Tue, 31 Mar 2020, Andreas Rheinhardt wrote: > >> If writing an uncoded frame fails at the preparatory steps of >> av_[interleaved_]write_frame(), the frame would be either not freed >> at all in case of av_write_frame() or would leak when the fake packet >> would be unref

Re: [FFmpeg-devel] [PATCH] libavformat/mov: restore use of mfra time as dts

On 10-04-2020 08:04 pm, John Stebbins wrote: On Thu, 2020-04-09 at 10:56 +0530, Gyan Doshi wrote: On 06-04-2020 11:12 pm, John Stebbins wrote: This was inadvertantly removed in 4a9d32baca --- libavformat/mov.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/mov.c b/l

Re: [FFmpeg-devel] [PATCH 1/4] lavc: install codec_desc.h

On 4/10/2020 12:41 PM, Anton Khirnov wrote: > Forgotten in 672946c7fe6de56ccf5d2271ad1bfeb2290f394f > --- > Oops, sorry > --- > libavcodec/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > index d9b04964ca..1970ff027f 100644 > --- a/liba

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: mention that av_bsf_send_packet() returning EAGAIN is not an error

On 4/10/2020 11:07 AM, Derek Buitenhuis wrote: > On 10/04/2020 00:09, James Almer wrote: >> EAGAIN is returned when input is provided but can't be consumed. The >> filtering >> process is unaffected in this case, and the function will be able to consume >> new input after retrieving filtered packe

[FFmpeg-devel] [PATCH 3/4] lavc: rename bsf.h to bsf_internal.h

This will allow adding a public header named bsf.h --- libavcodec/aac_adtstoasc_bsf.c | 2 +- libavcodec/av1_frame_merge_bsf.c | 2 +- libavcodec/av1_frame_split_bsf.c | 2 +- libavcodec/av1_metadata_bsf.c | 2 +- libavcodec/bitstream_filters.c | 2 +- libavcod

[FFmpeg-devel] [PATCH 2/4] avcodec.h: split AVCodecParameters API into its own header

--- Not sure what to do with AVFieldOrder. It gets moved to codec_par.h since it is used in AVCodecParameters, but it isn't precisely the right place for it, though it's not horribly wrong either. Least bad solution I've come up with is making a separate header for "misc small types used in lavc"

[FFmpeg-devel] [PATCH 4/4] avcodec.h: split bitstream filters API into its own header

--- doc/APIchanges | 3 +- libavcodec/Makefile| 1 + libavcodec/aac_adtstoasc_bsf.c | 2 +- libavcodec/av1_frame_merge_bsf.c | 2 +- libavcodec/av1_frame_split_bsf.c | 2 +- libavcodec/av1_metadata_bsf.c | 1 + li

[FFmpeg-devel] [PATCH 1/4] lavc: install codec_desc.h

Forgotten in 672946c7fe6de56ccf5d2271ad1bfeb2290f394f --- Oops, sorry --- libavcodec/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index d9b04964ca..1970ff027f 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -6,6 +6,7 @@ HEADER

Re: [FFmpeg-devel] [PATCH 00/10] libavformat/mux patches

On Tue, 31 Mar 2020, Andreas Rheinhardt wrote: This patchset is a slightly revised version of the remaining patches of a patchset I originally sent last August [1]. I resend it because Marton requested it [2]. I have also added three new patches at the end (but they actually don't depend on an

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/bsf: add av_bsf_join() to chain bitstream filters

On Fri, 10 Apr 2020, James Almer wrote: On 4/10/2020 5:25 AM, Marton Balint wrote: [...] Finally, (I feel bad having to tell you this given that you have clearly invested a lot of time in this) we currently have no case where we need more than one automatically inserted bitstream filter p

Re: [FFmpeg-devel] [PATCH] libavformat/mov: restore use of mfra time as dts

On Thu, 2020-04-09 at 10:56 +0530, Gyan Doshi wrote: > > On 06-04-2020 11:12 pm, John Stebbins wrote: > > This was inadvertantly removed in 4a9d32baca > > --- > > libavformat/mov.c | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/libavformat/mov.c b/libavformat/mov.c > > ind

Re: [FFmpeg-devel] [PATCH 06/10] lavc/libopenh264enc: set slice_mode option to deprecated

> From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Friday, April 10, 2020 18:28 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 06/10] lavc/libopenh264enc: set > slice_mode option to deprecated > > Quoting Linjie Fu (2020-04-06 13:14

[FFmpeg-devel] [RFC] Moving ffprobe's writers to lavu

Hi. In the comments on a recent patch to implement statistics outputs for a specific filter, I noted that this is something that many filters need to do, and therefore in need of unification. I also observed some JSON code in a filter, which does not belong there. https://ffmpeg.org/pipermail/ffm

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: mention that av_bsf_send_packet() returning EAGAIN is not an error

On 10/04/2020 00:09, James Almer wrote: > EAGAIN is returned when input is provided but can't be consumed. The filtering > process is unaffected in this case, and the function will be able to consume > new input after retrieving filtered packets with av_bsf_receive_packet(). > > Remove the line ab

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/bsf: add av_bsf_join() to chain bitstream filters

On 4/10/2020 5:25 AM, Marton Balint wrote: > > > On Thu, 9 Apr 2020, James Almer wrote: > >> On 4/9/2020 9:11 PM, Marton Balint wrote: >>> >>> >>> On Fri, 10 Apr 2020, Andreas Rheinhardt wrote: >>> Marton Balint: > Signed-off-by: Marton Balint > --- >  doc/APIchanges   |  3

Re: [FFmpeg-devel] [PATCH 08/10] lavc/libopenh264enc: add profile high option support

> From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Friday, April 10, 2020 18:57 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 08/10] lavc/libopenh264enc: add profile > high option support > > Quoting Linjie Fu (2020-04-06 13:14:51)

Re: [FFmpeg-devel] [PATCH 05/10] lavc/libopenh264enc: prompt slice number changing according to cpus

> From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Friday, April 10, 2020 18:23 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 05/10] lavc/libopenh264enc: prompt > slice number changing according to cpus > > Quoting Linjie Fu (2020-

[FFmpeg-devel] [PATCH] configure: add MV30 blockdsp dependency

fix link error introduced in 481ebb1c8b3368e2a1bb9e33bd10b50a8818dbf7 --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 09bda9b408..4d4c429be9 100755 --- a/configure +++ b/configure @@ -2790,6 +2790,7 @@ msmpeg4v3_decoder_select="h263_decoder" msmpeg4v3

Re: [FFmpeg-devel] [PATCH 03/10] lavc/libopenh264enc: add default gop size and bit rate

> From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Friday, April 10, 2020 18:14 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 03/10] lavc/libopenh264enc: add > default gop size and bit rate > > Quoting Linjie Fu (2020-04-06 13:14:4

Re: [FFmpeg-devel] [PATCH 01/10] lavc/libopenh264enc: Add default qmin/qmax support

> From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Friday, April 10, 2020 18:12 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 01/10] lavc/libopenh264enc: Add > default qmin/qmax support > > Quoting Linjie Fu (2020-04-06 13:14:44) >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/bsf: add av_bsf_join() to chain bitstream filters

Marton Balint: > > > On Fri, 10 Apr 2020, Andreas Rheinhardt wrote: > >> Marton Balint: >>> >>> >>> On Thu, 9 Apr 2020, James Almer wrote: >>> On 4/9/2020 9:11 PM, Marton Balint wrote: > > > On Fri, 10 Apr 2020, Andreas Rheinhardt wrote: > >> Marton Balint: >>> Signe

[FFmpeg-devel] [PATCH v3 2/2] avformat: add kvag muxer

Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/kvag.c | 84 +++- libavformat/version.h| 2 +- 5 files changed, 87 insertions(+), 2 deletions(-) diff -

[FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/adpcmenc.c | 30 ++ libavcodec/allcodecs.c | 1 + libavcodec/utils.c | 1 + libavcodec/version.h | 2 +- 7 files change

Re: [FFmpeg-devel] [PATCH 2/3] avcodec.h: split codec IDs into their own header

Quoting James Almer (2020-04-08 15:27:40) > On 4/8/2020 4:42 AM, Anton Khirnov wrote: > > The stuff below used to inside the lavc_core doxy group (Which is a > subgroup of libavc). Can you either keep it that way, or maybe some > alternative that reflects this change? Right, that was a brainfart.

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/bsf: add av_bsf_join() to chain bitstream filters

On Fri, 10 Apr 2020, Andreas Rheinhardt wrote: Marton Balint: On Thu, 9 Apr 2020, James Almer wrote: On 4/9/2020 9:11 PM, Marton Balint wrote: On Fri, 10 Apr 2020, Andreas Rheinhardt wrote: Marton Balint: Signed-off-by: Marton Balint ---  doc/APIchanges   |  3 +++  libavcodec/a

[FFmpeg-devel] [PATCH v1] fftools/ffprobe: Use format specifier PRId64 instead of %lld

From: Limin Wang Signed-off-by: Limin Wang --- fftools/ffprobe.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index e3f221f560..a32bc529d9 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -408,7 +408,7 @@ stati

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat: add kvag muxer

Zane van Iperen: > Signed-off-by: Zane van Iperen > --- > Changelog| 1 + > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/kvag.c | 84 +++- > libavformat/version.h| 2 +- > 5 files changed, 87 inse

Re: [FFmpeg-devel] [PATCH 10/10] lavc/libopenh264enc: replace cabac option with coder

Quoting Linjie Fu (2020-04-06 13:14:53) > Change the default option to -1 and allow the default cabac to be > decided by profile. > > Signed-off-by: Linjie Fu > --- > libavcodec/libopenh264enc.c | 27 --- > 1 file changed, 16 insertions(+), 11 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/bsf: add av_bsf_join() to chain bitstream filters

Marton Balint: > > > On Thu, 9 Apr 2020, James Almer wrote: > >> On 4/9/2020 9:11 PM, Marton Balint wrote: >>> >>> >>> On Fri, 10 Apr 2020, Andreas Rheinhardt wrote: >>> Marton Balint: > Signed-off-by: Marton Balint > --- >  doc/APIchanges   |  3 +++ >  libavcodec/avcod

Re: [FFmpeg-devel] [PATCH 08/10] lavc/libopenh264enc: add profile high option support

Quoting Linjie Fu (2020-04-06 13:14:51) > Add support for PRO_HIGH/PRO_BASELINE in SVC Encoding extention mode, > which determined by iEntropyCodingModeFlag in ParamTranscode(). > > > > Signed-off-by: Linjie F

Re: [FFmpeg-devel] [PATCH v1 1/4] avfilter/af_loudnorm: Add file option for the measured stats

Limin Wang (12020-04-10): > If someone can rework the ffprobe writers with a helper function, I'm > glad to use it. I'm not code maintainer, if no other developer review > my code and help to push it, then it's difficult to merge. The time cycle > is too long, so I have no plan to do such work. O

Re: [FFmpeg-devel] [PATCH v1 1/4] avfilter/af_loudnorm: Add file option for the measured stats

Kyle Swanson (12020-04-09): > Is there already a helper API for filters (or codecs) that output a > statistics file? If not, that's probably a pretty big undertaking. In I do not think it is that big a task. It needs a convention for the name of the option(s), a convention for the name of the file

Re: [FFmpeg-devel] [PATCH 06/10] lavc/libopenh264enc: set slice_mode option to deprecated

Quoting Linjie Fu (2020-04-06 13:14:49) > "slice mode" seems to be unnecessary since it could be determined by > -slices/max_nal_size. > > default:SM_FIXEDSLCNUM_SLICE mode with cpu-number slices. > -slices N: SM_FIXEDSLCNUM_SLICE mode with N slices. > -max_nal_size: SM_SIZELIMITED_S

Re: [FFmpeg-devel] [PATCH 05/10] lavc/libopenh264enc: prompt slice number changing according to cpus

Quoting Linjie Fu (2020-04-06 13:14:48) > Libopenh264enc would set the slice according to the number of cpu cores > if uiSliceNum equals to 0 (auto) in SM_FIXEDSLCNUM_SLICE mode. > > Prompt a warning for user to catch this. > > Signed-off-by: Linjie Fu > --- > libavcodec/libopenh264enc.c | 3 ++

Re: [FFmpeg-devel] [PATCH 04/10] lavc/libopenh264enc: add bit rate control select support

Quoting Linjie Fu (2020-04-06 13:14:47) > RC_BITRATE_MODE: > set BITS_EXCEEDED to iCurrentBitsLevel and allows QP adjust > in RcCalculatePictureQp(). > > RC_BUFFERBASED_MODE: > use buffer status to adjust the video quality. > > RC_TIMESTAMP_MODE: > bit rate control based on timest

[FFmpeg-devel] [PATCH v2 2/2] avformat: add kvag muxer

Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/kvag.c | 84 +++- libavformat/version.h| 2 +- 5 files changed, 87 insertions(+), 2 deletions(-) diff -

[FFmpeg-devel] [PATCH v2 1/2] avcodec: add adpcm_ima_ssi encoder

Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/adpcmenc.c | 30 ++ libavcodec/allcodecs.c | 1 + libavcodec/utils.c | 1 + libavcodec/version.h | 4 ++-- 7 files chan

Re: [FFmpeg-devel] [PATCH 03/10] lavc/libopenh264enc: add default gop size and bit rate

Quoting Linjie Fu (2020-04-06 13:14:46) > Signed-off-by: Linjie Fu > --- > libavcodec/libopenh264enc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c > index c7ae5b1..3ff5be7 100644 > --- a/libavcodec/libopenh264enc.c > +++ b/

Re: [FFmpeg-devel] [PATCH 02/10] lavc/libopenh264enc: fix the if-else coding style

Quoting Linjie Fu (2020-04-06 13:14:45) > Signed-off-by: Linjie Fu > --- ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-deve

Re: [FFmpeg-devel] [PATCH 01/10] lavc/libopenh264enc: Add default qmin/qmax support

Quoting Linjie Fu (2020-04-06 13:14:44) > Set default QP range to (1, 51) instead of (2, 32). > > QP = 0 is not well supported currently in libopenh264. If iMaxQp/iMinQp > equals 0, the QP range would be changed unexpectedly inside libopenh264 > with a warning: > > Warning:Change QP Range from(0,

  1   2   >