Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: add low_delay_b option for HEVC

2020-04-13 Thread myp...@gmail.com
On Mon, Apr 13, 2020 at 12:39 PM Linjie Fu wrote: > > Low delay B-frame is supported on ICL+ platform. > > For low power encoding, low_delay_b should be enabled by default. > > Low delay B: > > > There

Re: [FFmpeg-devel] [PATCH v2] avutil/log: update text requesting samples

2020-04-13 Thread Marton Balint
On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: Am Mo., 13. Apr. 2020 um 02:19 Uhr schrieb Marton Balint : On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: > Am Mo., 13. Apr. 2020 um 00:45 Uhr schrieb Marton Balint : >> >> Signed-off-by: Marton Balint >> --- >> libavutil/log.c | 6 +++--- >> 1

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: add low_delay_b option for HEVC

2020-04-13 Thread Fu, Linjie
> From: myp...@gmail.com > Sent: Monday, April 13, 2020 15:43 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: add > low_delay_b option for HEVC > > On Mon, Apr 13, 2020 at 12:39 PM Linjie Fu wrote

[FFmpeg-devel] Job post: Command line audio recorder and player using ffmpeg API / C++

2020-04-13 Thread Yiannis Bourkelis
I have posted in Peopleperhour a job request for this project: https://www.peopleperhour.com/freelance-jobs/software-development/c-c-programming/command-line-audio-recorder-and-player-using-ffmpeg-api-c-2793463?id=2793463&jobview=1 I would prefer someone from the ffmpeg community to do the job, so

Re: [FFmpeg-devel] [PATCH 1/4] avformat/mpegtsenc: use standard pids for m2ts

2020-04-13 Thread Petri Hintukainen
pe, 2020-04-10 kello 21:44 +0200, Marton Balint kirjoitti: > Signed-off-by: Marton Balint > --- > doc/muxers.texi | 6 -- > libavformat/mpegts.h| 10 ++ > libavformat/mpegtsenc.c | 44 > +++- > 3 files changed, 57 insertions(+), 3 d

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add explicit capability flag for encoder flushing

2020-04-13 Thread Anton Khirnov
Quoting Philip Langdale (2020-04-11 01:47:43) > We've been in this fuzzy situation where maybe you could call > avcodec_flush_buffers() on an encoder but there weren't any encoders > that supported it except maybe audiotoolboxenc. Then we added flush > support to nvenc very intentionally, and it wo

[FFmpeg-devel] [PATCH v3 0/7] Support Dolby Vision

2020-04-13 Thread Jun Zhao
From: Jun Zhao V3: - rename the file name for Dolby Vision trademark risk(tks Jean-Baptiste Kempf) - fix other typo issue V2: - used sidedata for Dolby Vision information (tks Jan Ekström's suggestion) - enabled dumping Dolby Vision sidedata for ffmpeg/ffprobe tools - enable dvcC/dvvC box from D

[FFmpeg-devel] [PATCH v3 5/7] lavf/dump: dump DOVI side data

2020-04-13 Thread Jun Zhao
From: Jun Zhao dump DOVI side data. Signed-off-by: Jun Zhao --- libavformat/dump.c | 17 + 1 file changed, 17 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index 220f404..fa7ae1e 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -27,6 +27,7 @@ #

[FFmpeg-devel] [PATCH v3 7/7] lavf/movenc: enable dvcC/dvvC box support from DOVI sidedata

2020-04-13 Thread Jun Zhao
From: Jun Zhao enable dvcC/dvvC box support from DOVI sidedata. Signed-off-by: Jun Zhao --- libavformat/movenc.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 6db09b7..4363e05 100644 --- a/libavformat/

[FFmpeg-devel] [PATCH v1] fftools: fix hwaccles option dump redundancy

2020-04-13 Thread Jun Zhao
From: Jun Zhao when enable the QSV in FFmpeg, used the cmd "ffmpeg -hwaccels" always dump redundancy acceleration methods for QSV like: Hardware acceleration methods: vaapi qsv drm opencl qsv Signed-off-by: Jun Zhao --- fftools/ffmpeg_opt.c | 4 1 file changed, 4 deletions(-) diff --git

[FFmpeg-devel] [PATCH]ffmpeg: Do not clip timestamps at LONG_MAX

2020-04-13 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #8612 here. Please comment, Carl Eugen From d36feae5e072d0efc4b2b85bcf042eb102e331b4 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 13 Apr 2020 14:01:14 +0200 Subject: [PATCH] ffmpeg: Do not clip timestamps at LONG_MAX. Fixes ticket #8612. --- fftool

[FFmpeg-devel] [PATCH v3 4/7] lavf/mov: support dvcC/dvvC box for DOVI

2020-04-13 Thread Jun Zhao
From: vacingfang support dvcC/dvcC box from spec Dolby Vision Streams Within the ISO Base MediaFile Format Version 2.1.2 (https://www.dolby.com/in/en/technologies/dolby-vision/dolby-vision\ -bitstreams-within-the-iso-base-media-file-format-v2.1.2.pdf) export the DOVI information to sidedata. Si

[FFmpeg-devel] [PATCH v3 3/7] lavf/mpegts: support DOVI Video Stream Descriptor

2020-04-13 Thread Jun Zhao
From: vacingfang support DOVI Video Stream Descriptor from Dolby Vision Streams Within the MPEG-2 Transport Stream Format V1.2 From the spec: https://www.dolby.com/us/en/technologies/\ dolby-vision/dolby-vision-bitstreams-in-mpeg-2-transport-\ stream-multiplex-v1.2.pdf. export the DOVI informat

[FFmpeg-devel] [PATCH v3 2/7] lavutil: add DOVI related header

2020-04-13 Thread Jun Zhao
From: vacingfang add DOVI related struct Signed-off-by: vacingfang --- libavutil/Makefile| 1 + libavutil/dovi_meta.h | 58 +++ 2 files changed, 59 insertions(+) create mode 100644 libavutil/dovi_meta.h diff --git a/libavutil/Makefile b/li

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: add low_delay_b option for HEVC

2020-04-13 Thread Mark Thompson
On 13/04/2020 05:32, Linjie Fu wrote: > Low delay B-frame is supported on ICL+ platform. > > For low power encoding, low_delay_b should be enabled by default. > > Low delay B: > > > There is an on-goi

[FFmpeg-devel] [PATCH v3 1/7] lavc: add a new sidedata type for DOVI

2020-04-13 Thread Jun Zhao
From: Jun Zhao add a new sidedata type for DOVI. Signed-off-by: Jun Zhao --- libavcodec/avpacket.c | 1 + libavcodec/packet.h | 9 + 2 files changed, 10 insertions(+) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index ad020ee..675652d 100644 --- a/libavcodec/avpacket.c

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: fix max_transform_hierarchy_depth_inter/intra

2020-04-13 Thread Mark Thompson
On 13/04/2020 05:32, Linjie Fu wrote: > Set the max_transform_hierarchy_depth_inter/intra to 2 by default > based on the Programmer's Reference Manuals (PRM) in [1]. > > Intel Encoder only supports 2 levels of quad-tree. That is: > - max_transform_hierarchy_depth_inter/intra <= 2. > > [1] >

[FFmpeg-devel] [PATCH v3 6/7] fftools/ffprobe: support DOVI sidedata

2020-04-13 Thread Jun Zhao
From: Jun Zhao support DOVI sidedata. Signed-off-by: Jun Zhao --- fftools/ffprobe.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index e3f221f..840fcb7 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -36,6 +36,7 @@ #include "

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: fix max_transform_hierarchy_depth_inter/intra

2020-04-13 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Mark Thompson > Sent: Monday, April 13, 2020 20:20 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: fix > max_transform_hierarchy_depth_inter/intra > > On 13/04/2020 05:32, Linjie Fu wrote: > > Set the max_transform_hi

Re: [FFmpeg-devel] [PATCH] vaapi_decode: Improve logging around codec/profile selection

2020-04-13 Thread Mark Thompson
On 12/04/2020 18:19, Fu, Linjie wrote: >> From: ffmpeg-devel On Behalf Of >> Mark Thompson >> Sent: Sunday, April 12, 2020 21:00 >> To: ffmpeg-devel@ffmpeg.org >> Subject: [FFmpeg-devel] [PATCH] vaapi_decode: Improve logging around >> codec/profile selection >> >> --- >> On 12/04/2020 13:14, Mark

Re: [FFmpeg-devel] [PATCH] avfilter: add eval video filter

2020-04-13 Thread Paul B Mahol
On 11/1/19, Michael Niedermayer wrote: > On Fri, Nov 01, 2019 at 01:09:24PM +0100, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 78 + >> libavfilter/Makefile | 1 + >> libavfilter/allfilters.c | 1 + >> libavfilter/vf_eval.c| 687 ++

Re: [FFmpeg-devel] [PATCH] avfilter: add eval video filter

2020-04-13 Thread Nicolas George
Paul B Mahol (12020-04-13): > Because geq works with only one input. > Gonna apply this filter immediately. You literally just sent a reply on an objection: allow time for other developers to read that reply and make a reply of their own. -- Nicolas George signature.asc Description: PGP sign

Re: [FFmpeg-devel] [PATCH v2] lavc/vaapi_decode: fix the build failure when hevc_vaapi is disabled

2020-04-13 Thread Mark Thompson
On 12/04/2020 16:47, Linjie Fu wrote: > Verified with ./configure --enable-vaapi --disable-hwaccel=hevc_vaapi > > Failure reported in: > http://fate.ffmpeg.org/report.cgi?time=20200401135031&slot=x86_64-archlinux-gcc-random > > Signed-off-by: Linjie Fu > --- > libavcodec/vaapi_decode.c | 2 +- >

Re: [FFmpeg-devel] [PATCH v1] fftools: fix hwaccles option dump redundancy

2020-04-13 Thread Andriy Gelman
On Mon, 13. Apr 20:02, Jun Zhao wrote: > From: Jun Zhao > > when enable the QSV in FFmpeg, used the cmd "ffmpeg -hwaccels" always > dump redundancy acceleration methods for QSV like: > > Hardware acceleration methods: > vaapi > qsv > drm > opencl > qsv > > Signed-off-by: Jun Zhao > --- > ffto

Re: [FFmpeg-devel] [PATCH v1] fftools: fix hwaccles option dump redundancy

2020-04-13 Thread Mark Thompson
On 13/04/2020 13:02, Jun Zhao wrote: > From: Jun Zhao Typo "hwaccels" in subject. > when enable the QSV in FFmpeg, used the cmd "ffmpeg -hwaccels" always > dump redundancy acceleration methods for QSV like: Perhaps: """ When QSV is enabled in FFmpeg, the command "ffmpeg -hwaccels" shows a dupl

Re: [FFmpeg-devel] [PATCH v1] fftools: fix hwaccles option dump redundancy

2020-04-13 Thread myp...@gmail.com
On Mon, Apr 13, 2020 at 9:22 PM Andriy Gelman wrote: > > On Mon, 13. Apr 20:02, Jun Zhao wrote: > > From: Jun Zhao > > > > when enable the QSV in FFmpeg, used the cmd "ffmpeg -hwaccels" always > > dump redundancy acceleration methods for QSV like: > > > > Hardware acceleration methods: > > vaapi

Re: [FFmpeg-devel] [PATCH] vaapi_decode: Improve logging around codec/profile selection

2020-04-13 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Mark Thompson > Sent: Monday, April 13, 2020 21:14 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] vaapi_decode: Improve logging around > codec/profile selection > > On 12/04/2020 18:19, Fu, Linjie wrote: > >> From: ffmpeg-devel On Behalf O

[FFmpeg-devel] [PATCH v2] fftools: fix hwaccles option dump redundancy

2020-04-13 Thread Jun Zhao
From: Jun Zhao when enable the QSV in FFmpeg, used the cmd "ffmpeg -hwaccels" always dump redundancy acceleration methods for QSV like: Hardware acceleration methods: vaapi qsv drm opencl qsv Signed-off-by: Jun Zhao --- fftools/ffmpeg_opt.c | 5 - 1 file changed, 5 deletions(-) diff --gi

Re: [FFmpeg-devel] [PATCH]ffmpeg: Do not clip timestamps at LONG_MAX

2020-04-13 Thread Paul B Mahol
On 4/13/20, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #8612 here. > > Please comment, Carl Eugen > Awesome! Great! LGTM! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsub

Re: [FFmpeg-devel] [PATCH v1] fftools: fix hwaccles option dump redundancy

2020-04-13 Thread myp...@gmail.com
On Mon, Apr 13, 2020 at 9:30 PM Mark Thompson wrote: > > On 13/04/2020 13:02, Jun Zhao wrote: > > From: Jun Zhao > > Typo "hwaccels" in subject. > Missed this comment,sadly, > > when enable the QSV in FFmpeg, used the cmd "ffmpeg -hwaccels" always > > dump redundancy acceleration methods for QSV

[FFmpeg-devel] [PATCH v3] fftools: fix hwaccels option dump redundancy

2020-04-13 Thread Jun Zhao
From: Jun Zhao When QSV is enabled in FFmpeg, the command "ffmpeg -hwaccels" shows a duplicate entry in acceleration methods for QSV: Hardware acceleration methods: vaapi qsv drm opencl qsv Signed-off-by: Jun Zhao --- fftools/ffmpeg_opt.c | 5 - 1 file changed, 5 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH v2] fftools: fix hwaccles option dump redundancy

2020-04-13 Thread myp...@gmail.com
On Mon, Apr 13, 2020 at 9:45 PM Jun Zhao wrote: > > From: Jun Zhao > > when enable the QSV in FFmpeg, used the cmd "ffmpeg -hwaccels" always > dump redundancy acceleration methods for QSV like: > > Hardware acceleration methods: > vaapi > qsv > drm > opencl > qsv > > Signed-off-by: Jun Zhao > --

[FFmpeg-devel] [PATCH]lavc/jpeg2000dec: Allow forcing a compatible pix_fmt

2020-04-13 Thread Carl Eugen Hoyos
Hi! Attached patch makes the behaviour of the jpeg2000 decoder more similar to the libopenjpeg decoder and allows a work-around for ticket #5919. Please comment, Carl Eugen From ca98ca99d267c0c6009ed4e4981f05ed8712adf8 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 13 Apr 2020 16:25:

[FFmpeg-devel] [PATCH] avfilter: add tmedian filter

2020-04-13 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 19 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_xmedian.c | 108 +-- 4 files changed, 124 insertions(+), 5 deletions(-) diff --git a/doc/filters.texi b/d

Re: [FFmpeg-devel] [PATCH] avfilter: add tmedian filter

2020-04-13 Thread James Almer
On 4/13/2020 11:52 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 19 +++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_xmedian.c | 108 +-- > 4 files changed, 124 inserti

Re: [FFmpeg-devel] [PATCH] avfilter: add tmedian filter

2020-04-13 Thread Paul B Mahol
On 4/13/20, James Almer wrote: > On 4/13/2020 11:52 AM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 19 +++ >> libavfilter/Makefile | 1 + >> libavfilter/allfilters.c | 1 + >> libavfilter/vf_xmedian.c | 108 +++

Re: [FFmpeg-devel] [PATCH] avfilter: add tmedian filter

2020-04-13 Thread Nicolas George
James Almer (12020-04-13): > I think you can simplify this using the FFBufQueue API instead. > ff_bufqueue_add() and ff_bufqueue_get() here, ff_bufqueue_peek() in the > s->median_frames functions to read a frame without altering the queue, etc. Or even simpler by treating the array as circular. R

Re: [FFmpeg-devel] Query regarding codec parsers

2020-04-13 Thread Gautam Ramakrishnan
On Sun, Mar 29, 2020 at 8:34 PM Carl Eugen Hoyos wrote: > > Am So., 29. März 2020 um 16:45 Uhr schrieb Gautam Ramakrishnan > : > > > > > What exactly does a parser do and how is it different from a decoder? > > > > I am unable to understand the exact use case of a parser. > > > > > > Try the follo

[FFmpeg-devel] [PATCH 1/8] lavc: Rename hwaccel.h to hwconfig.h

2020-04-13 Thread Mark Thompson
This already applied to decoders as well as hwaccels, and adding encoder support was going to make the name even more inaccurate. --- libavcodec/cuviddec.c| 2 +- libavcodec/decode.c | 2 +- libavcodec/h263dec.c | 2 +- libavcodec/h264dec.c

[FFmpeg-devel] [PATCH 2/8] lavc: Extend hardware config metadata to encoders

2020-04-13 Thread Mark Thompson
--- libavcodec/avcodec.h | 11 ++- libavcodec/hwconfig.h | 18 ++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 55151a0b71..136292fee7 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -2534,6

[FFmpeg-devel] [PATCH 3/8] lavc/qsvenc: Add hardware config metadata

2020-04-13 Thread Mark Thompson
All of these encoders can accept libmfx surfaces directly in a hardware frames context, or they can accept software frames if a suitable device is supplied to use. --- libavcodec/qsvenc.c | 7 +++ libavcodec/qsvenc.h | 3 +++ libavcodec/qsvenc_h264.c | 1 + libavcodec/qsvenc_hevc.

[FFmpeg-devel] [PATCH 8/8] ffmpeg: Remove the hw_device_ctx global

2020-04-13 Thread Mark Thompson
The ad-hoc libmfx setup code is the only place its still used, so move it into that file. --- fftools/ffmpeg.c | 1 - fftools/ffmpeg.h | 1 - fftools/ffmpeg_opt.c | 11 ++- fftools/ffmpeg_qsv.c | 1 + 4 files changed, 3 insertions(+), 11 deletions(-) diff --git a/fftools/ffmpeg

[FFmpeg-devel] [PATCH 4/8] lavc/vaapi_encode: Add hardware config metadata

2020-04-13 Thread Mark Thompson
These encoders all accept VAAPI surfaces in a hardware frames context. --- libavcodec/vaapi_encode.c | 5 + libavcodec/vaapi_encode.h | 3 +++ libavcodec/vaapi_encode_h264.c | 1 + libavcodec/vaapi_encode_h265.c | 1 + libavcodec/vaapi_encode_mjpeg.c | 1 + libavcodec/vaapi_encod

[FFmpeg-devel] [PATCH 5/8] lavc/nvenc: Add hardware config metadata

2020-04-13 Thread Mark Thompson
NOT TESTED. --- Needs someone with suitable hardware to try it. With this and the relevant ffmpeg patches, existing stuff should continue to work and you should also be able to choose between multiple devices for a standalone encoder with things like: ffmpeg -init_hw_device cuda:2 ... -c:v nven

[FFmpeg-devel] [PATCH 7/8] ffmpeg: Use hardware config metadata with encoders

2020-04-13 Thread Mark Thompson
This can support encoders which want frames and/or device contexts. For the device case, it currently picks the first initialised device of the desired type to give to the encoder - a new option would be needed if it were necessary to choose between multiple devices of the same type. --- fftools/

[FFmpeg-devel] [PATCH 6/8] ffmpeg: Make filter hardware device selection clearer

2020-04-13 Thread Mark Thompson
Also move it into a dedicated function in the hardware file. --- fftools/ffmpeg.h| 1 + fftools/ffmpeg_filter.c | 14 +++--- fftools/ffmpeg_hw.c | 28 3 files changed, 32 insertions(+), 11 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpe

[FFmpeg-devel] [PATCH] avformat/movenc: remove the write_clli mov flag

2020-04-13 Thread Michael Bradshaw
The clli atom is expected to be standardized soon. See http://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/259529.html This patch will write the clli atom by default. Please review. 0001-avformat-movenc-remove-the-write_clli-mov-flag.patch Description: Binary data __

Re: [FFmpeg-devel] [PATCH] avformat/movenc: add write_mdcv flag to write mdcv atom

2020-04-13 Thread Michael Bradshaw
On Wed, Apr 1, 2020 at 1:18 PM Carl Eugen Hoyos wrote: > Same here: If this helps, it should not be optional imo. Based on Jan's email I'm fine with removing the flag and just writing this atom by default. Attached patch is updated to do that. 0001-avformat-movenc-write-the-mdcv-atom-by-defau

Re: [FFmpeg-devel] [PATCH] avformat/movenc: stop guessing colr atom values

2020-04-13 Thread Michael Bradshaw
On Tue, Mar 31, 2020 at 6:23 AM Derek Buitenhuis wrote: > I agree strongly with Michael's points. I've pushed the patch to master. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe,

Re: [FFmpeg-devel] [PATCH] avformat/movenc: remove the write_clli mov flag

2020-04-13 Thread James Almer
On 4/13/2020 1:12 PM, Michael Bradshaw wrote: > The clli atom is expected to be standardized soon. See > http://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/259529.html > > This patch will write the clli atom by default. > > Please review. > From a3e74f36c8035716bd89796547722a05e7e014de Mon Sep

Re: [FFmpeg-devel] [PATCH] avformat/movenc: use enum values directly for colr atom

2020-04-13 Thread Michael Bradshaw
Given the lack of objections I've pushed this to the master branch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with sub

Re: [FFmpeg-devel] [PATCH] avformat/movenc: remove the write_clli mov flag

2020-04-13 Thread Michael Bradshaw
On Mon, Apr 13, 2020 at 10:32 AM James Almer wrote: > Should be AV_LOG_VERBOSE, or just removed. Otherwise every muxing > process where there's no CLL side data will print this, and that'll be > the vast majority of cases. > Okay, I switched it to verbose. LGTM otherwise. Thanks. Pushed.

Re: [FFmpeg-devel] [PATCH] avformat/movenc: add write_mdcv flag to write mdcv atom

2020-04-13 Thread Michael Bradshaw
On Mon, Apr 13, 2020 at 10:26 AM Michael Bradshaw wrote: > Attached patch is updated to do that. > Pushed to master, but with a change to use AV_LOG_VERBOSE logging (to be consistent with the clli atom). ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpe

Re: [FFmpeg-devel] [PATCH 5/8] lavc/nvenc: Add hardware config metadata

2020-04-13 Thread Dennis Mungai
On Mon, 13 Apr 2020 at 18:34, Mark Thompson wrote: > NOT TESTED. > --- > Needs someone with suitable hardware to try it. > > With this and the relevant ffmpeg patches, existing stuff should continue > to work and you should also be able to choose between multiple devices for > a standalone encode

Re: [FFmpeg-devel] [PATCH] avformat/spdifenc: handle long TrueHD input_timing gaps

2020-04-13 Thread Carl Eugen Hoyos
Am So., 12. Apr. 2020 um 21:56 Uhr schrieb Anssi Hannula : > > Some TrueHD streams contain frames that have very long gaps in > input_timing fields, while output_timing remains constant-rate. These > are likely due to encoding discontinuities of some sort as the TrueHD > substream terminator marker

Re: [FFmpeg-devel] Query regarding codec parsers

2020-04-13 Thread Carl Eugen Hoyos
Am Mo., 13. Apr. 2020 um 17:27 Uhr schrieb Gautam Ramakrishnan : > > On Sun, Mar 29, 2020 at 8:34 PM Carl Eugen Hoyos wrote: > > > > Am So., 29. März 2020 um 16:45 Uhr schrieb Gautam Ramakrishnan > > : > > > > > > > What exactly does a parser do and how is it different from a decoder? > > > > > I

Re: [FFmpeg-devel] [RFC, PATCH]lavu/log: Do not change the terminal background colour

2020-04-13 Thread Carl Eugen Hoyos
Am So., 29. März 2020 um 17:19 Uhr schrieb Carl Eugen Hoyos : > Attached patch fixes ticket #8587, not sure if we want this or not, > but I do not consider the missing encircled / blinking effect (that is > not used by our command line tools) an issue. > > Please comment, Carl Eugen Ping. Carl E

Re: [FFmpeg-devel] [PATCH] avformat/movenc: write the colr atom by default

2020-04-13 Thread Michael Bradshaw
At the risk of being too non-committal, attached patch is mostly the same but leaves the write_colr flag as experimental. I would love to remove the write_colr flag entirely but we should provide some kind of escape hatch to allow ffmpeg to write "unspecified" (enum value 2) values for the colr ato

[FFmpeg-devel] [PATCH] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-13 Thread James Almer
Process input data as soon as it's fed to av_bsf_send_packet(), instead of storing a single packet and expecting the user to call av_bsf_receive_packet() in order to trigger the decoding process before they are allowed to feed more data. This puts the bsf API more in line with the decoupled decode

Re: [FFmpeg-devel] [PATCH] avformat/movenc: stop guessing colr atom values

2020-04-13 Thread Andriy Gelman
On Mon, 13. Apr 10:29, Michael Bradshaw wrote: > On Tue, Mar 31, 2020 at 6:23 AM Derek Buitenhuis > wrote: > > > I agree strongly with Michael's points. > > > I've pushed the patch to master. seems to break fate make fate-vsynth1-dnxhd-1080i-colr TESTvsynth1-dnxhd-1080i-colr --- ./tests/

Re: [FFmpeg-devel] [PATCH] avformat/movenc: stop guessing colr atom values

2020-04-13 Thread Michael Bradshaw
On Mon, Apr 13, 2020 at 1:24 PM Andriy Gelman wrote: > seems to break fate > make fate-vsynth1-dnxhd-1080i-colr Sorry about that. I should have been more thorough. Attached patch fixes fate. 0001-tests-ref-vsynth-fix-fate-colr-changes.patch Description: Binary data ___

Re: [FFmpeg-devel] [PATCH] avformat/movenc: stop guessing colr atom values

2020-04-13 Thread Michael Bradshaw
On Mon, Apr 13, 2020 at 2:01 PM Michael Bradshaw wrote: > Sorry about that. I should have been more thorough. Attached patch fixes > fate. > And another that got missed. 0001-tests-ref-vsynth-fix-fate-colr-changes-again.patch Description: Binary data ___

Re: [FFmpeg-devel] [PATCH 02/10] configure, libavformat/Makefile: Fix webm_chunk dependencies

2020-04-13 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The webm_chunk muxer requires the WebM muxer, yet it does not directly > require anything from libavformat/matroska.c (it does not even include > the corresponding header). So remove the dependency from the Makefile > and add a _select to configure. > > Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/libaomenc.c: Support gray input

2020-04-13 Thread James Zern
Hi, On Tue, Apr 7, 2020 at 5:14 PM Ryo Hirafuji wrote: > > From: Ryo Hirafuji > > AV1 decoders, libaomdec and libdav1d, both support grayscale image. > However, libaomenc does not support it yet. > In this patch, I add a grayscale image support also to libaomenc. > > Fixes ticket #7599 > --- >

Re: [FFmpeg-devel] [PATCH v3] lavfi: add new iteration API

2020-04-13 Thread Josh Allmann
Hi, On Sat, 24 Mar 2018 at 14:40, Josh de Kock wrote: > > Signed-off-by: Josh de Kock > --- > configure| 29 +- > doc/APIchanges | 4 + > doc/writing_filters.txt | 6 +- > libavfilter/allfilters.c | 823 > +-- > libavf

Re: [FFmpeg-devel] [PATCH v3 1/7] lavc: add a new sidedata type for DOVI

2020-04-13 Thread Jan Ekström
On Mon, Apr 13, 2020 at 3:20 PM Jun Zhao wrote: > > From: Jun Zhao > > add a new sidedata type for DOVI. > > Signed-off-by: Jun Zhao > --- > libavcodec/avpacket.c | 1 + > libavcodec/packet.h | 9 + > 2 files changed, 10 insertions(+) > > diff --git a/libavcodec/avpacket.c b/libavcode

[FFmpeg-devel] [PATCH 2/4] fate: Allow to test temporary files with ffprobe

2020-04-13 Thread Andreas Rheinhardt
This is primarily intended to test that muxers correctly write chapters or metadata; but given that it does this by having our demuxers read the generated files, it also tests demuxers. And of course it may prove useful for encoders, too. Signed-off-by: Andreas Rheinhardt --- transcode() and stre

[FFmpeg-devel] [PATCH 3/4] fate/matroska: Add test for chapters, Vorbis and WebM DASH

2020-04-13 Thread Andreas Rheinhardt
Moreover, putting the Cues in front of the Clusters by reserving space in advance is also tested. The new capability of using ffprobe during a remux/transcode test are used here for information about the chapters. Signed-off-by: Andreas Rheinhardt --- When in DASH audio mode, the Matroska/WebM m

[FFmpeg-devel] [PATCH 1/4] fate: Fix dependencies for ffprobe tests with external samples

2020-04-13 Thread Andreas Rheinhardt
Up until now, they were appended to the FATE_EXTERN-$(CONFIG_FFMPEG) variable and were therefore activated when ffmpeg was enabled regardless of whether ffprobe was enabled. Also the same happened with FATE_SAMPLES_FASTSTART, although the corresponding test (mov-faststart-4gb-overflow) only requir

[FFmpeg-devel] [PATCH 4/4] avformat/matroskadec: Remove redundant setting of chapter titles

2020-04-13 Thread Andreas Rheinhardt
Chapter titles are added to the chapter's metadata since 6cb6e159, yet since 012867f0 (the predecessor of) avpriv_new_chapter() already adds the title to the chapter's metadata. So setting it again in matroskadec.c is redundant and expensive. Signed-off-by: Andreas Rheinhardt --- libavformat/mat

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/libaomenc.c: Add super-resolution options to libaom wrapper

2020-04-13 Thread James Zern
On Tue, Mar 17, 2020 at 7:38 PM James Zern wrote: > > Hi, > > On Thu, Mar 5, 2020 at 6:20 PM Wang Cao wrote: > > > > Signed-off-by: Wang Cao > > --- > > The changes are made according to the code review > > - Bump the MICRO version > > - Use enum for Super resolution mode consts. The original en

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add explicit capability flag for encoder flushing

2020-04-13 Thread Josh Allmann
On Mon, 13 Apr 2020 at 04:39, Anton Khirnov wrote: > > Quoting Philip Langdale (2020-04-11 01:47:43) > > We've been in this fuzzy situation where maybe you could call > > avcodec_flush_buffers() on an encoder but there weren't any encoders > > that supported it except maybe audiotoolboxenc. Then w

Re: [FFmpeg-devel] [PATCH] avformat/movenc: write the colr atom by default

2020-04-13 Thread Michael Bradshaw
Attached is an updated patch that passes fate. 0001-avformat-movenc-write-the-colr-atom-by-default.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, vis

[FFmpeg-devel] [PATCH] avformat/mpeg: Decrease score by 1 for files with very little valid data

2020-04-13 Thread Michael Niedermayer
Fixes: 8233/PPY6574574605_cut.mp3 Signed-off-by: Michael Niedermayer --- libavformat/mpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c index 33c0398060..265b2bd1ad 100644 --- a/libavformat/mpeg.c +++ b/libavformat/mpeg.c @@ -99,7 +

[FFmpeg-devel] [PATCH] avcodec: add a WebP parser

2020-04-13 Thread James Almer
Based on code from the BMP parser. Addresses ticket #8574 Signed-off-by: James Almer --- libavcodec/Makefile | 1 + libavcodec/parsers.c | 1 + libavcodec/webp_parser.c | 112 +++ 3 files changed, 114 insertions(+) create mode 100644 libavcodec/

[FFmpeg-devel] [PATCH] avformat/matroskaenc: Don't write elements with their default value

2020-04-13 Thread Andreas Rheinhardt
This has happened when writing chapters: Both editions as well as chapters are by default not hidden and given that we don't support writing hidden chapters at all, we don't need to write said elements at all. The same goes for ChapterFlagEnabled. Signed-off-by: Andreas Rheinhardt --- This is sup

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Don't write elements with their default value

2020-04-13 Thread James Almer
On 4/13/2020 10:46 PM, Andreas Rheinhardt wrote: > This has happened when writing chapters: Both editions as well as > chapters are by default not hidden and given that we don't support > writing hidden chapters at all, we don't need to write said elements at > all. The same goes for ChapterFlagEna

Re: [FFmpeg-devel] [PATCH v3 1/7] lavc: add a new sidedata type for DOVI

2020-04-13 Thread myp...@gmail.com
On Tue, Apr 14, 2020 at 5:54 AM Jan Ekström wrote: > > On Mon, Apr 13, 2020 at 3:20 PM Jun Zhao wrote: > > > > From: Jun Zhao > > > > add a new sidedata type for DOVI. > > > > Signed-off-by: Jun Zhao > > --- > > libavcodec/avpacket.c | 1 + > > libavcodec/packet.h | 9 + > > 2 files

Re: [FFmpeg-devel] [PATCH v3] fftools: fix hwaccels option dump redundancy

2020-04-13 Thread myp...@gmail.com
On Mon, Apr 13, 2020 at 10:08 PM Jun Zhao wrote: > > From: Jun Zhao > > When QSV is enabled in FFmpeg, the command "ffmpeg -hwaccels" shows a > duplicate entry in acceleration methods for QSV: > > Hardware acceleration methods: > vaapi > qsv > drm > opencl > qsv > > Signed-off-by: Jun Zhao > ---

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Don't write elements with their default value

2020-04-13 Thread Andreas Rheinhardt
James Almer: > On 4/13/2020 10:46 PM, Andreas Rheinhardt wrote: >> This has happened when writing chapters: Both editions as well as >> chapters are by default not hidden and given that we don't support >> writing hidden chapters at all, we don't need to write said elements at >> all. The same goes

[FFmpeg-devel] [PATCH v2 20/20] avformat/matroskaenc: Cosmetics

2020-04-13 Thread Andreas Rheinhardt
Reindentation, removal of { } if they contain only one statement and moving the return statement to a line of its own in situations like "if (ret < 0) return ret;". Moreover, several overlong lines were made shorter and a camelCase variable received a name in line with our naming conventions. Sign

[FFmpeg-devel] [PATCH v4] avcodec: Add explicit capability flag for encoder flushing

2020-04-13 Thread Philip Langdale
Previously, there was no way to flush an encoder such that after draining, the encoder could be used again. We generally suggested that clients teardown and replace the encoder instance in these situations. However, for at least some hardware encoders, the cost of this tear down/replace cycle is ve

[FFmpeg-devel] [PATCH] avformat/oggenc: Don't free AVStream's priv_data, fix memleak

2020-04-13 Thread Andreas Rheinhardt
For FLAC, Speed, Opus and VP8 the Ogg muxer allocates two buffers for building the headers: The first for extradata in an Ogg-specific format and the second contains a Vorbiscomment. These buffers are reachable via pointers in the corresponding AVStream's priv_data. If an error happens during buil

[FFmpeg-devel] [PATCH] ffmpeg: allow full range of dts_delta_threshold

2020-04-13 Thread Gyan Doshi
For inputs from demuxers with AVFMT_TS_DISCONT flag, the existing condition, delta < -1LL*dts_delta_threshold*AV_TIME_BASE is rendered superflous due to the fixed threshold in pkt_dts + AV_TIME_BASE/10 < FFMAX(ist->pts, ist->dts) This prevents users from setting a high threshold to avoid disc